From patchwork Fri Dec 23 07:42:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Max Filippov X-Patchwork-Id: 36156 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp193194wrn; Thu, 22 Dec 2022 23:53:20 -0800 (PST) X-Google-Smtp-Source: AMrXdXuZpJRoa9oI1fSzyKT7A0PbKYKzDXr994zRw8pvCgLJQ+bkepLNdghzMib/2+yeta2HRcJd X-Received: by 2002:aa7:da09:0:b0:480:95f5:1e36 with SMTP id r9-20020aa7da09000000b0048095f51e36mr2238353eds.23.1671782000085; Thu, 22 Dec 2022 23:53:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671782000; cv=none; d=google.com; s=arc-20160816; b=bJpSn80wXPnsOlwS9Qpt4fOYFCdnjRYrA1B+aGMNUJJ0LOqBhlZYdIinZOCtB7tfd4 eDVBioYMzcY/MW1LLFJB1AROT1EJ/c+m2SWU3wiL1xxLsdE1Dxk1YLub4kFquFD9mYYy NhamoWCrYu5KlgKk5NnQGTOEn6fe1WhsxKeE7SyyVvm5Od12U3hlJ2GAY+y4j2Xb7V1E 1TkFMRfzl+74xhQ1sgZgOUm3Lqe7KWdSkuvECbvvF2R0DCHQxwMgMCicSKO/gVjrpKC+ tMvbWrNaMaXdndt3TNZhP+x2HatnoCjta27Iq1ztChZ2Bh+Vp/M8q70lSGk1rn7pAk8w ZvOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=xwkjPkB+HDgaumLrNe3xi/8SHaA70l8jiLgxWpcwsNs=; b=nPdCSeObPR0t7e1gXslfxoGynFI2WDcrltzM32qNhnHxbT/Dc88oAkRF5G1NZhXFDF k+HXutUt4QAnGD6ZbDUwH9dEpsmTnVzaymnbCuBHGhtVu/ONed5js6h8Ch2jTXLTwSJW Rd2XEjHIGMxeoNaPGz0GwDvFZ+V3FwVvuDrCEZHWckYufdaQ+tg017+/XPJvG3rpF68I XJU1pvz0VeNZhghaGvLCVrHhJruoNiZiZIFd+pHR2xy9a6WLnxCcI7+FMb03GGZAJVit HXGu8U/FCRPztlvYpXdQpnz+yn5puQAUcaMsUszIKoxcFzcJVWubDp3PyYhBFuWy+r1z ISsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=qBmFxZfk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s5-20020a056402520500b004677d91cdeasi2599141edd.244.2022.12.22.23.52.56; Thu, 22 Dec 2022 23:53:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=qBmFxZfk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230214AbiLWHm6 (ORCPT + 99 others); Fri, 23 Dec 2022 02:42:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229483AbiLWHm4 (ORCPT ); Fri, 23 Dec 2022 02:42:56 -0500 Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C35B1571D for ; Thu, 22 Dec 2022 23:42:55 -0800 (PST) Received: by mail-pg1-x530.google.com with SMTP id 78so2837658pgb.8 for ; Thu, 22 Dec 2022 23:42:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=xwkjPkB+HDgaumLrNe3xi/8SHaA70l8jiLgxWpcwsNs=; b=qBmFxZfkbscd80v1B1WyDYk9D9+tger1/bHCKo2BM6yGSq2jVt9T11X46Josoz+Tpq DUb4vxLJKp8x0jpJpXd++iHTRULMNRhd5c8v4kNf1oxHboR9i56j4MxbBro7LczOMlzT 7+fyVfe//nG/kYvMgBfzZZim5SlO9Y06SvF9PXXQT32QcroPySZsNeU9r0f/i0hB9b5/ aypk40OEuOmWo2mS6PW2q0VltAolekhZpay6XZFu8O+JWKG0hX4od2gVXn3rE/LvTAr6 BlzeEB1H1J5EhIxWrqmdT46tfDAlYkqIu8Y93s7rtbZ0J+bEasWKjLPpWNqJxjTtODfM USJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xwkjPkB+HDgaumLrNe3xi/8SHaA70l8jiLgxWpcwsNs=; b=o012kjZQlOyD9U3t+0dMh3h9Rhjq3/JoIIe0TJpadjo7Er5k1ttOi78IqPEOY7MDcC rueO6p4ja79rHq/9ODO8jsUMCvN/bW3xZuBRyW1kQb/QILzMH2zctL4T7aKd+UChvLC0 SA0Ee2L3AOnRYK51Vy0N36S6w6ez52A0cGvJfbEjRtu1D8nbcnOqipOvYCmAkPmLLnWK Xct2T8SZFwb4k0bAw2DyQp7nSNhUXJpIimqkCdUwfL9hyZ/ZyUuPSxEgdWGqIRY0NFc+ Tv35CcY6R65rcAsHgtcga5Xyh46ScLniFB3mDjMpsiJMu+YOz7WTMqdPh9iLP/tejFoF gsiQ== X-Gm-Message-State: AFqh2kqLW8Sfy4CLmV8w9Pmm/MqWgo2QiBNOTghotabXk5Ar0pVIx9lz 0rhJdotYU2mfl/H34r6cSRs= X-Received: by 2002:aa7:93b8:0:b0:576:95ec:bc93 with SMTP id x24-20020aa793b8000000b0057695ecbc93mr24262725pff.23.1671781374955; Thu, 22 Dec 2022 23:42:54 -0800 (PST) Received: from octofox.hsd1.ca.comcast.net ([2601:641:401:1d20:3ffc:2c70:d62e:faaf]) by smtp.gmail.com with ESMTPSA id 64-20020a620543000000b0056bd1bf4243sm1887187pff.53.2022.12.22.23.42.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Dec 2022 23:42:54 -0800 (PST) From: Max Filippov To: Marco Elver Cc: Dmitry Vyukov , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-xtensa@linux-xtensa.org, Max Filippov Subject: [PATCH] kcsan: test: don't put the expect array on the stack Date: Thu, 22 Dec 2022 23:42:38 -0800 Message-Id: <20221223074238.4092772-1-jcmvbkbc@gmail.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Spam-Status: No, score=0.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, FROM_LOCAL_NOVOWEL,HK_RANDOM_ENVFROM,HK_RANDOM_FROM,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752990482559652502?= X-GMAIL-MSGID: =?utf-8?q?1752990482559652502?= Size of the 'expect' array in the __report_matches is 1536 bytes, which is exactly the default frame size warning limit of the xtensa architecture. As a result allmodconfig xtensa kernel builds with the gcc that does not support the compiler plugins (which otherwise would push the said warning limit to 2K) fail with the following message: kernel/kcsan/kcsan_test.c:257:1: error: the frame size of 1680 bytes is larger than 1536 bytes Fix it by dynamically alocating the 'expect' array. Signed-off-by: Max Filippov --- kernel/kcsan/kcsan_test.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/kernel/kcsan/kcsan_test.c b/kernel/kcsan/kcsan_test.c index dcec1b743c69..af62ec51bd5f 100644 --- a/kernel/kcsan/kcsan_test.c +++ b/kernel/kcsan/kcsan_test.c @@ -159,7 +159,7 @@ static bool __report_matches(const struct expect_report *r) const bool is_assert = (r->access[0].type | r->access[1].type) & KCSAN_ACCESS_ASSERT; bool ret = false; unsigned long flags; - typeof(observed.lines) expect; + typeof(*observed.lines) *expect; const char *end; char *cur; int i; @@ -168,6 +168,10 @@ static bool __report_matches(const struct expect_report *r) if (!report_available()) return false; + expect = kmalloc(sizeof(observed.lines), GFP_KERNEL); + if (!expect) + return false; + /* Generate expected report contents. */ /* Title */ @@ -253,6 +257,7 @@ static bool __report_matches(const struct expect_report *r) strstr(observed.lines[2], expect[1]))); out: spin_unlock_irqrestore(&observed.lock, flags); + kfree(expect); return ret; }