From patchwork Thu Dec 22 12:42:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Youghandhar Chintala X-Patchwork-Id: 35746 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp306505wrn; Thu, 22 Dec 2022 04:55:31 -0800 (PST) X-Google-Smtp-Source: AMrXdXt8o/ohzExcMt8S0sn58j+UzOAVZ3/BMhNznUA2cn3pincB4Q/UJ9z1DiLA51wIRS24kkLQ X-Received: by 2002:a17:90a:ea81:b0:225:bae0:90f7 with SMTP id h1-20020a17090aea8100b00225bae090f7mr1040356pjz.20.1671713730993; Thu, 22 Dec 2022 04:55:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671713730; cv=none; d=google.com; s=arc-20160816; b=qF+fAfS2U6xWp0ytX0fXFmlWwU0LTWWP0AGUhQHo8mi/US9kC099wDu9G6l1Qa8eAT cDeWM/VzPUb3CgGxy2yQ90kXmpROD9aeQa8fdx3hQVV2IBKx/DK1I60k+KiHQUeS7oqW 4JYFamuXiIF9gFwRUM8piEHdLa+NaqVvAb5K6kyL5047o02wFHfLA04XmH+X091vYn8N q08PbFVpqKxplbl/hoyf7sb4oB01yonGE7EHapOTQrttzuyB7I5nqemEcYPzyUG4iuor +YMcRRpP0qK2hif5zhTAypNM5WM1Lc+XDVjReaJn5lTHfZTuEVB1JtCfAH+9WLh0253A NsJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=4Hkgp5mqnwYGMLAnV4qH/U21gdaKpSgaflWbxhX8fhk=; b=Qi7a+Lyv7dDg9lDO6rCWVXXKOI9ia+59TfiPX8wmLzO0/e/zyp6aXpiKoyf3aUDrLb PM3YHmoIbUP9H4g5K6VJlRozQO0Yvpvu7MWdqy+CLORCGnHaMgDhwrGu21zKaq52DAco L06iStN+MvuZVOB3I4rT++iqgS3VlDK89qgnKn1SPbwLscOhDR8ok2tETa3DkpD1Xluf 8ISf9m5XzyiavLmaTjGO0/PbbfMW3RJSc635xC0jIksOSwW4akQZFfHn9kxvh9IR8mBu l9QNfwR8DIGiTMyNMbJPEjqXXZR4/1elEH8qpOvRoezJ/Pq/t0X22idF0As1KKNJh7N1 Ft3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b="E9TS/Zc+"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ip10-20020a17090b314a00b00219b3307f5fsi4618407pjb.45.2022.12.22.04.55.17; Thu, 22 Dec 2022 04:55:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b="E9TS/Zc+"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235638AbiLVMnl (ORCPT + 99 others); Thu, 22 Dec 2022 07:43:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235647AbiLVMng (ORCPT ); Thu, 22 Dec 2022 07:43:36 -0500 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6660625E85; Thu, 22 Dec 2022 04:43:34 -0800 (PST) Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2BMAn5Qn007102; Thu, 22 Dec 2022 12:43:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=qcppdkim1; bh=4Hkgp5mqnwYGMLAnV4qH/U21gdaKpSgaflWbxhX8fhk=; b=E9TS/Zc+EYzbZIvW1UGJ3hD+eiYb4Y6/421Vab2fbnPIN4NW8WzpSLKzRCdvSaoYqlpG +Z6etqqkBRb/eEnJPHGBNB/SM8NE8yoXhgj24q5oY99EKbUkEPUK7prqumKc5zVXJjNA BayjvO8iFtNcZJMc3SE86oDAJmKkzK7Nb5vQal0l7XP2q8JV+4LmZNUKVsgY326NbgF8 lBFJG/x+h/qcnVHAMKSljQ06Wq+gv1YX+SlooEMDMT23piSYeK0rCBuz+IPKHYlotuWI w2Y48A3BrBjKrlH+B2ofYT65bk1uMArzOZv3X+uAQnZcrBL9KEjMBukOSCaPIzu2ux2v wA== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3mk83xwvxv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Dec 2022 12:43:18 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 2BMChHq2020906 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Dec 2022 12:43:17 GMT Received: from youghand-linux.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Thu, 22 Dec 2022 04:43:14 -0800 From: Youghandhar Chintala To: , CC: , , , Youghandhar Chintala Subject: [PATCH 1/2] wifi: cfg80211: Add beacon hint notifier support Date: Thu, 22 Dec 2022 18:12:20 +0530 Message-ID: <20221222124221.30894-2-quic_youghand@quicinc.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221222124221.30894-1-quic_youghand@quicinc.com> References: <20221222124221.30894-1-quic_youghand@quicinc.com> MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: RGea825zRoHe3_Ml7V84IKaS5X6xfbqA X-Proofpoint-GUID: RGea825zRoHe3_Ml7V84IKaS5X6xfbqA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-22_06,2022-12-22_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 mlxlogscore=999 clxscore=1015 bulkscore=0 phishscore=0 impostorscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 spamscore=0 suspectscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2212220111 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752918897155874541?= X-GMAIL-MSGID: =?utf-8?q?1752918897155874541?= There are connection failures in hidden SSID case when the device is with default reg domain WW. For WW reg domain most of the 5 GHz channels are passive. When device listens to the beacon on that channel, the driver is updating its channel flag but firmware is not aware of it and firmware is not sending probes on that channels. Due to this, we are seeing connection failures when the device is trying to connect with hidden SSID AP. In the case of devices using the ath10k driver, it is required to update the change in channel flags to firmware as well. Therefore, we need a mechanism to notify the driver from the regulatory core regarding the channel flag changes. Adding a beacon hint notifier logic, so that drivers can register callbacks to get notified whenever there is a change in channel flags. Signed-off-by: Youghandhar Chintala --- include/net/cfg80211.h | 2 ++ net/wireless/reg.c | 5 ++++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h index 11a370e64143..07b2f2da77d6 100644 --- a/include/net/cfg80211.h +++ b/include/net/cfg80211.h @@ -5386,6 +5386,8 @@ struct wiphy { void (*reg_notifier)(struct wiphy *wiphy, struct regulatory_request *request); + void (*beacon_hint_notifier)(struct wiphy *wiphy); + /* fields below are read-only, assigned by cfg80211 */ const struct ieee80211_regdomain __rcu *regd; diff --git a/net/wireless/reg.c b/net/wireless/reg.c index c3d950d29432..6ea2455d4964 100644 --- a/net/wireless/reg.c +++ b/net/wireless/reg.c @@ -2219,8 +2219,11 @@ static void handle_reg_beacon(struct wiphy *wiphy, unsigned int chan_idx, channel_changed = true; } - if (channel_changed) + if (channel_changed) { nl80211_send_beacon_hint_event(wiphy, &chan_before, chan); + if (wiphy->beacon_hint_notifier) + wiphy->beacon_hint_notifier(wiphy); + } } /* From patchwork Thu Dec 22 12:42:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Youghandhar Chintala X-Patchwork-Id: 35748 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp306674wrn; Thu, 22 Dec 2022 04:55:55 -0800 (PST) X-Google-Smtp-Source: AMrXdXswHh/KrDNdSBf57RKzvVCF56vam8tnsMiM3EEpctO+Gk+cmlYrpZV4dzBzb6eCkYezcc04 X-Received: by 2002:a17:907:73c1:b0:7e7:4dd7:bc0c with SMTP id es1-20020a17090773c100b007e74dd7bc0cmr4454732ejc.66.1671713755174; Thu, 22 Dec 2022 04:55:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671713755; cv=none; d=google.com; s=arc-20160816; b=FE7QmG3Gb7Pg1nSIyvLwzTagEssdA1G1bPaTjV79j8cb526LeAEUWisr7CAL1eFYBl OU1zGKdt2ZIwYUGAEPfEo5D5FUPqSnO0LGCjIvxRLz3tVY/Vbia7T3ZQxFGF+Sd0YJ0s stqb+EnSHzCbtydhQpsTcWKoGsuDKT8q4NgO2j7lGLdRBNShuszhTPJ+heUG8YBBcEWE uSlR7qR3RLNOI8l7f6M6bc1gK9FIhDhoShPRAPCrKKD+UFVvB9eRemKIVdWIl3KBMAk5 mapOxRJvplAkaO2kJQbYiIGjsHdUq7THsxORRPmRSlZ9SAM9HdRE6GRSCB+rhdUSun5g fRvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=n4u0QORlDQIiNmr9PqyeFNaeaGjlinS5DG6hnZGlICQ=; b=XHXcFugpG2An0Pjy98TGHQMiuXcDvPRI7e3dSs+grExfSyK3qQGAPRUTycaNQ3/IMH sS5eVj4esGB3fpfaMFpUzSPy3vV6X0X7pi0gvtkoIoFAUDAW4oARyU2HG1RHYmRNDYCd Tapianu2zL5qQ3g4sVUqAnfOqg/EE210WrmRnZkfM5vDj5uAEtWgYHyXCUrTqraQOzIN +76uDpqwkmm0A2MedrPrDqLD1Vdear/gl5ZP0JyrK9+0rmZ6qS5IjTslr2tyio6CjGNJ HjSCS+mURpo47+EiPNgpDIM/Z33vSAgQ8Cpr+upVbaUzPv5QL6YWsyPy7KwwpBqZ0djC jdDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=J+QG8jkl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hw20-20020a170907a0d400b007c19ace9796si280841ejc.940.2022.12.22.04.55.29; Thu, 22 Dec 2022 04:55:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=J+QG8jkl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235408AbiLVMno (ORCPT + 99 others); Thu, 22 Dec 2022 07:43:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235650AbiLVMnh (ORCPT ); Thu, 22 Dec 2022 07:43:37 -0500 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 604AC22BF8; Thu, 22 Dec 2022 04:43:34 -0800 (PST) Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2BMAldat005760; Thu, 22 Dec 2022 12:43:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=qcppdkim1; bh=n4u0QORlDQIiNmr9PqyeFNaeaGjlinS5DG6hnZGlICQ=; b=J+QG8jkl5tAkYHMWziuti+rIE9AH2y+T52mw4Y+TSREMvfnAvrP5rGqEPy/ykrBVl5vC YCd6m98k0FGh9gLfBw5/L/KWOF42jyCZxJpNLHDqoLMH2Ll6DPUNHwyzLJN1mPhHZJT4 dwKpasRvXJgiCSpbKBT6JNzt+BTKrBlyuTn/I3TGZEjENQby9B7iWbcJx49DBfFDS5rd aSNVg483Ehx518NtLDwBDjiL7CHdUmmEkCQa50gvIcTpTf7daW8kz/d1mFNCyswLB4aJ CjICv0hZBW37CbF1OoLCVXunB6hW994k9Q/HlUZa1BSPGL07vpW2a0sBedLV4ehzc/Ju Sw== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3mm0wfjr21-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Dec 2022 12:43:22 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 2BMChL4R020922 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Dec 2022 12:43:21 GMT Received: from youghand-linux.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Thu, 22 Dec 2022 04:43:19 -0800 From: Youghandhar Chintala To: , CC: , , , Youghandhar Chintala Subject: [PATCH 2/2] wifi: ath10k: update the channel list if change in channel flags. Date: Thu, 22 Dec 2022 18:12:21 +0530 Message-ID: <20221222124221.30894-3-quic_youghand@quicinc.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221222124221.30894-1-quic_youghand@quicinc.com> References: <20221222124221.30894-1-quic_youghand@quicinc.com> MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: vaiGVMP9aUTPZOxXjkcOTheW1XDqGMo1 X-Proofpoint-GUID: vaiGVMP9aUTPZOxXjkcOTheW1XDqGMo1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-22_06,2022-12-22_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 clxscore=1015 spamscore=0 suspectscore=0 phishscore=0 malwarescore=0 impostorscore=0 priorityscore=1501 mlxscore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2212220111 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752918923033204835?= X-GMAIL-MSGID: =?utf-8?q?1752918923033204835?= There are connection failures in hidden SSID case when the device is with default reg domain WW. For WW reg domain most of the 5 GHz channels are passive. When device listens to the beacon on that channel, the driver is updating its channel flag but firmware is not aware of it and firmware is not sending probes on that channels. Due to this, we are seeing connection failures when a device is trying to connect with hidden SSID AP. Register beacon hint notifier to the regulatory core so that driver get notified when there is a change in channel flags. Driver's notifier callback will send the updated flags to the firmware. Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.2.2.c10-00754-QCAHLSWMTPL-1 Tested-on: QCA6174 hw3.2 SDIO WLAN.RMH.4.4.1-00174 Signed-off-by: Youghandhar Chintala --- drivers/net/wireless/ath/ath10k/mac.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index ec8d5b29bc72..91a957295456 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -3534,6 +3534,15 @@ static void ath10k_mac_update_channel_list(struct ath10k *ar, } } +static void ath10k_mac_beacon_notifier(struct wiphy *wiphy) +{ + struct ieee80211_hw *hw = wiphy_to_ieee80211_hw(wiphy); + struct ath10k *ar = hw->priv; + + if (ath10k_update_channel_list(ar)) + ath10k_warn(ar, "failed to update channel list\n"); +} + static void ath10k_reg_notifier(struct wiphy *wiphy, struct regulatory_request *request) { @@ -10286,6 +10295,8 @@ int ath10k_mac_register(struct ath10k *ar) goto err_unregister; } + ar->hw->wiphy->beacon_hint_notifier = ath10k_mac_beacon_notifier; + return 0; err_unregister: