From patchwork Thu Dec 22 05:10:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= X-Patchwork-Id: 35614 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp141694wrn; Wed, 21 Dec 2022 21:11:58 -0800 (PST) X-Google-Smtp-Source: AMrXdXtnUbCXg3A5hLXMOSBcpG0iWBqVV/Ry6ta+2kVwukyudSKeJjKXfZsLmkemljO85j6J1per X-Received: by 2002:a17:906:e2d3:b0:7c0:deb3:596a with SMTP id gr19-20020a170906e2d300b007c0deb3596amr4045746ejb.70.1671685918562; Wed, 21 Dec 2022 21:11:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671685918; cv=none; d=google.com; s=arc-20160816; b=BzQALemtegi1jeHrKxqbYki5R2oApJ/TgNGcLszMGJ68kGtz+S1XF+zn0w9fugbD3x fkCokDFRX7zSXmCwmG2c6U6mwSCc1PlDOCGFxhQUkMUapdhUWH1auDGHqJaCSKhEM9WE 34i7/0pGWdQCfZhOA8gxD2VEqqGCmfQuiAhnviqUOAvPx2izUByFHhzIKEhfMPKBThY2 nb5GPosejhCXr5tqCU5pvw7EMQMwX4jHwK74NzGpF1rJm+wgLOe0uULyRhP1ldtjL8a7 4PDvFYJk5wnSIpfZN6/L3m7hpRX/7mi/zyjuEKnkoeP9p6/pqBXVpGOIO9hQnP6pCmBy ZC0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:dkim-signature :from; bh=eH8M6w85+NLMp8m3weXqG66NWkeE3K2qLdjTpJMXR40=; b=JVdSgXaTRknycUkwv3V9smxHYCAZCpJ8GeJJTfoi38Zjkui3Go9R4TNyjeyvLdDzOL LVSvav0z6cO/yp24crmN5d4RviINXU7u064ehimfIm3UwIlMlo81mQzz2SSe0qRmJKYO +co5GwJivGZKxPS/xYINzsMKfLgzTiUE7vCvHiMYyVTCvHQsjTG7eVSG7zCMyl9P2vlw Y1Ps9+JM5ElKejKImlPatCKE8F9iMxABnepEqTv2aJYLFlooBTFfqIS4e+xRrAEE26sT 3SG+TrQeDvqlJt+WhDv8AFzAmstyvB9HlMYKIgxATaI0QlBhZ0B0rvW57tsutx4pS1/L TgDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@weissschuh.net header.s=mail header.b=dkHGyX+F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h17-20020a05640250d100b004571c47b13csi6723339edb.418.2022.12.21.21.11.34; Wed, 21 Dec 2022 21:11:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@weissschuh.net header.s=mail header.b=dkHGyX+F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229698AbiLVFLF (ORCPT + 99 others); Thu, 22 Dec 2022 00:11:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229561AbiLVFKw (ORCPT ); Thu, 22 Dec 2022 00:10:52 -0500 Received: from todd.t-8ch.de (todd.t-8ch.de [IPv6:2a01:4f8:c010:41de::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12ACD1705E; Wed, 21 Dec 2022 21:10:50 -0800 (PST) From: Thomas =?utf-8?q?Wei=C3=9Fschuh?= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=weissschuh.net; s=mail; t=1671685847; bh=+TwYUhNEMciEbKy4LBuWCzsBr/FmeYPjRzvFbPwU3T0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=dkHGyX+F319hDFe8JREAbJkgVdPhAr4CDz63BQACf6YbFBNMSaW7heWcM4okGjKAG OBKf9L99sesfe+Ip0v+vT3Q8tzrBjLPSxIYbFSG8JJVBMuF53J+cPWhdZ5zp82kOSl LZ3pBptvCET0wdj8JRs4FopuKnYTOapc1polxjus= Date: Thu, 22 Dec 2022 05:10:44 +0000 Subject: [PATCH 1/8] HID: letsketch: Use hid_is_usb() MIME-Version: 1.0 Message-Id: <20221222-hid-v1-1-f4a6c35487a5@weissschuh.net> References: <20221222-hid-v1-0-f4a6c35487a5@weissschuh.net> In-Reply-To: <20221222-hid-v1-0-f4a6c35487a5@weissschuh.net> To: Hans de Goede , Jiri Kosina , Benjamin Tissoires , David Rheinsberg , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, Thomas =?utf-8?q?Wei=C3=9Fschuh?= X-Mailer: b4 0.11.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1671685844; l=678; i=linux@weissschuh.net; s=20221212; h=from:subject:message-id; bh=+TwYUhNEMciEbKy4LBuWCzsBr/FmeYPjRzvFbPwU3T0=; b=ez9SDwFeWSSaEcM4FNhQ2nLrcWuyDgqqhikUkJqh92wXbyM7rYsccOS2kygfF76KfaUeMS6jE1Iz ZglXQ5nOBeq8iiv0o2fqnHwdmsPPpSmbESbRSY99mMGlo0AQyMBT X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=KcycQgFPX2wGR5azS7RhpBqedglOZVgRPfdFSPB1LNw= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752889733687733163?= X-GMAIL-MSGID: =?utf-8?q?1752889733687733163?= Don't open code existing functionality. Signed-off-by: Thomas Weißschuh --- drivers/hid/hid-letsketch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-letsketch.c b/drivers/hid/hid-letsketch.c index 74d17cf518ba..97f047f18136 100644 --- a/drivers/hid/hid-letsketch.c +++ b/drivers/hid/hid-letsketch.c @@ -238,7 +238,7 @@ static int letsketch_probe(struct hid_device *hdev, const struct hid_device_id * char buf[256]; int i, ret; - if (!hid_is_using_ll_driver(hdev, &usb_hid_driver)) + if (!hid_is_usb(hdev)) return -ENODEV; intf = to_usb_interface(hdev->dev.parent); From patchwork Thu Dec 22 05:10:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= X-Patchwork-Id: 35616 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp141956wrn; Wed, 21 Dec 2022 21:12:55 -0800 (PST) X-Google-Smtp-Source: AMrXdXtJPTn7bsaKLHPGcReUFZbojV8Uw3xGRgF/G2EwoFiN63Rup7tPTxw+BRiSipEr1qsVl0YL X-Received: by 2002:a05:6402:2a04:b0:47a:f54c:1ba4 with SMTP id ey4-20020a0564022a0400b0047af54c1ba4mr4047996edb.25.1671685975649; Wed, 21 Dec 2022 21:12:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671685975; cv=none; d=google.com; s=arc-20160816; b=BPE6tFtQjEsvI/SgTjfn1hTPwgoES9PBmTz2i7flHTrsJdbJMWkxWRTZ5OlyFhjjxS oXJaRVOWHzNv5VtptCFglB4vjYB2UjWXyosKoNjJrOMpqpPWHOgSAPwgtp8osJ6BLWUg 8F9zf1GuQWScVd6z8oCYQgq0ArNR/Vf4YkEbD6i3LMOdyJPmUgEKeEmBvVVRWhJK0WE1 w5TKlYee62NSDQCiJurKfa289SVQJl9EptMXeECOF7xHZbvzvXLA2RJIiSpsOfH1v+fl /Xzcw6K1cYm+eLT8vkMqA5/1V2D+mq3h3nyLQIvvMe6oKA2lo2hyWClXRF0fnHcrHxqZ S79A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:dkim-signature :from; bh=V/oBVH86SRkjWKao6wJd2l1gzjxrx/eI5q8XGZzGRCk=; b=0zb5Sh6NPtzVOa3iJlGc8WEIYWs8m21SAQ9UumpY7QjfLRo7Z5LGq1H/toBJv+WKb2 ZDl1oGPwNlMggY2vJHW1VtKo9B2k9SnVEuRLEO23P91om7uXXm3gK9zCnIGx3YTB5Xhe 3RmB7Wirog9aG7W7Xoy6+L2bQnHtj2p7QbUsCxqyCOQ/E8DiyW8BN+RDquj/y/WtOb9N B2+0zQFekRFqBKFPU2tLTZsfcEvv/V9mK3vdI2PEof9HXYJT3BkHWwB9rN7lrwgJ7MKk kp3dwPXmO2p8zf5FL7JZT72MLePRHNa2sS7LOrS93ChS3JYrs+rgFCQJvQ5Xv7rLmrBs E9wA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@weissschuh.net header.s=mail header.b=YHzejwL7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i29-20020a0564020f1d00b00479526794c6si2607766eda.15.2022.12.21.21.12.32; Wed, 21 Dec 2022 21:12:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@weissschuh.net header.s=mail header.b=YHzejwL7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235015AbiLVFL3 (ORCPT + 99 others); Thu, 22 Dec 2022 00:11:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234973AbiLVFK5 (ORCPT ); Thu, 22 Dec 2022 00:10:57 -0500 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E42F178A5; Wed, 21 Dec 2022 21:10:55 -0800 (PST) From: Thomas =?utf-8?q?Wei=C3=9Fschuh?= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=weissschuh.net; s=mail; t=1671685848; bh=FtucXeOqhf/uwSmZUOmwGhFgKFDCA9qaKfFhVklXs0M=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=YHzejwL7SuWZwjrhLR4DKptcjvIT0orp+tF+YwprS6dypbmp5pN0ErmSymXZ8rHaq b8qEunKXylgKdVCial+uCfm7rLoNo7q8xzz45BIpWTtgePfpw4VyOgJVJvCkOwN+9g yQ/FHPfOZM2uuJfFqb6bSYCIuDa3BOIqIjvhYnd4= Date: Thu, 22 Dec 2022 05:10:45 +0000 Subject: [PATCH 2/8] HID: usbhid: Make hid_is_usb() non-inline MIME-Version: 1.0 Message-Id: <20221222-hid-v1-2-f4a6c35487a5@weissschuh.net> References: <20221222-hid-v1-0-f4a6c35487a5@weissschuh.net> In-Reply-To: <20221222-hid-v1-0-f4a6c35487a5@weissschuh.net> To: Hans de Goede , Jiri Kosina , Benjamin Tissoires , David Rheinsberg , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, Thomas =?utf-8?q?Wei=C3=9Fschuh?= X-Mailer: b4 0.11.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1671685845; l=1506; i=linux@weissschuh.net; s=20221212; h=from:subject:message-id; bh=FtucXeOqhf/uwSmZUOmwGhFgKFDCA9qaKfFhVklXs0M=; b=UB9Y4WcNg/MqRsY8fH/mjN2XW796kfEfNDKTuo1LtScaZE8nN1kABWW19n6EWmxAjQoUxpyFCdsW iDklWEpCCfNE5urMvYanl8sjuNuTpr5lCp+bnHJVX94T5Pje9X+N X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=KcycQgFPX2wGR5azS7RhpBqedglOZVgRPfdFSPB1LNw= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752889793723384966?= X-GMAIL-MSGID: =?utf-8?q?1752889793723384966?= By making hid_is_usb() a non-inline function the lowlevel usbhid driver does not have to be exported anymore. Also mark the argument as const as it is not modified. Signed-off-by: Thomas Weißschuh --- drivers/hid/usbhid/hid-core.c | 6 ++++++ include/linux/hid.h | 5 +---- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c index be4c731aaa65..54b0280d0073 100644 --- a/drivers/hid/usbhid/hid-core.c +++ b/drivers/hid/usbhid/hid-core.c @@ -1334,6 +1334,12 @@ struct hid_ll_driver usb_hid_driver = { }; EXPORT_SYMBOL_GPL(usb_hid_driver); +bool hid_is_usb(const struct hid_device *hdev) +{ + return hdev->ll_driver == &usb_hid_driver; +} +EXPORT_SYMBOL_GPL(hid_is_usb); + static int usbhid_probe(struct usb_interface *intf, const struct usb_device_id *id) { struct usb_host_interface *interface = intf->cur_altsetting; diff --git a/include/linux/hid.h b/include/linux/hid.h index 8677ae38599e..e8400aa78522 100644 --- a/include/linux/hid.h +++ b/include/linux/hid.h @@ -864,10 +864,7 @@ static inline bool hid_is_using_ll_driver(struct hid_device *hdev, return hdev->ll_driver == driver; } -static inline bool hid_is_usb(struct hid_device *hdev) -{ - return hid_is_using_ll_driver(hdev, &usb_hid_driver); -} +extern bool hid_is_usb(const struct hid_device *hdev); #define PM_HINT_FULLON 1<<5 #define PM_HINT_NORMAL 1<<1 From patchwork Thu Dec 22 05:10:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= X-Patchwork-Id: 35618 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp142035wrn; Wed, 21 Dec 2022 21:13:12 -0800 (PST) X-Google-Smtp-Source: AMrXdXuvah7V1PKjkplvKA+V6HNdQIuu6YFk43AdoakBMP7TYPhJtJwtgFckHBUNmONIPplf9Sd4 X-Received: by 2002:a50:aa96:0:b0:46c:ecb8:e703 with SMTP id q22-20020a50aa96000000b0046cecb8e703mr3740144edc.22.1671685991972; Wed, 21 Dec 2022 21:13:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671685991; cv=none; d=google.com; s=arc-20160816; b=J1RBkPqXASbTj/nkh6FeOKiAXEVWS0yu9GWlFbr6AT5CFjzVbkzOatYyp1zW7z3dym pf3bFUOCU/obcAzR/rggsxhZp/N7sgZtRZS2Yu4MVHp9V4Y272EoVj1VbEkknbSYKztt dSju44UA6/Y+huZql5YV1rOVKOOicedQNnYsyTwN+ucT2QlNKULuS5UjfKNMVOn53Akk q+HKhhNKB9miXDSjO617cilkt8fLXMkDT2crQR+YcdYrcgp3L25vDzih6KPbfC5D4epC LFxIdezg/CvNw0nhTtfNkXf9zYOZWVF3wj13KcTaYxTvj2LW1x7J2LEofHdnTnKpvsBt nCDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:dkim-signature :from; bh=kngOKunYlTEn/5M8DJnKk2rlikKFLTIul0XejaAdECY=; b=qPIzpXucaJ5tvV4wQJ8Etw14o7mLMz9QWAgcrU87r0BQcdbG9bcWeeS+pzz5HFVha6 nzXH5tWrNRUeQgxuDC9VpLgD4oLww4sIElMywORixTQ1sZU3cAWKlMhwTpXNC145WreZ fgRx6rCVdu0QBEwdFsvX35jqSiGnmdwMx8FvBpjk0yo6G04Zb77lJBDlsCETQ5KQOAq8 OepK/agZJqHbC6M84i7lA15P+gxRNKnO8lDWejjF8oK2p7isQ5xOWg3bgYrxLMk3d8uM 63anMjBMSyKO7yHZsoHSPlmH2sOq17bUSOyfa1NYFYcGCvoCIaAlWbs1gk01D1kqSP6H uLRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@weissschuh.net header.s=mail header.b=nzvPq4V4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l12-20020a170906938c00b007c0a7286be2si12871771ejx.770.2022.12.21.21.12.48; Wed, 21 Dec 2022 21:13:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@weissschuh.net header.s=mail header.b=nzvPq4V4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235125AbiLVFLi (ORCPT + 99 others); Thu, 22 Dec 2022 00:11:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234968AbiLVFK5 (ORCPT ); Thu, 22 Dec 2022 00:10:57 -0500 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D39217067; Wed, 21 Dec 2022 21:10:55 -0800 (PST) From: Thomas =?utf-8?q?Wei=C3=9Fschuh?= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=weissschuh.net; s=mail; t=1671685848; bh=aJ7IVJ34rJu4bypYe1rv5vqdZ+Bmi73wBdQLIivw4ts=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=nzvPq4V4YM3yepefWrKQUEa+Nby91i6BGB4MbAPtZ9zCehBQTP7ZpumFTXCngMTPy b/oKA3a98bIv/t3N+WjrRDOIWjX0AM5Bteqs1FSAEd1sR+WrLz4MJY0m4sqxC8tKlc 3jCIbs3NbFjQ/GhUp0eDBxj0UZWf7KtbgF29MyM4= Date: Thu, 22 Dec 2022 05:10:46 +0000 Subject: [PATCH 3/8] HID: Remove unused function hid_is_using_ll_driver() MIME-Version: 1.0 Message-Id: <20221222-hid-v1-3-f4a6c35487a5@weissschuh.net> References: <20221222-hid-v1-0-f4a6c35487a5@weissschuh.net> In-Reply-To: <20221222-hid-v1-0-f4a6c35487a5@weissschuh.net> To: Hans de Goede , Jiri Kosina , Benjamin Tissoires , David Rheinsberg , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, Thomas =?utf-8?q?Wei=C3=9Fschuh?= X-Mailer: b4 0.11.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1671685845; l=761; i=linux@weissschuh.net; s=20221212; h=from:subject:message-id; bh=aJ7IVJ34rJu4bypYe1rv5vqdZ+Bmi73wBdQLIivw4ts=; b=CO/ajOHSL68RVBZncIxSRsKPvD1NB0gAon57+ErnZ3WV+3ZsBndBhdn4vhj39QQXFDdBmKBW3Fnl n/fw2GoHClUGZswPDlzct7sDSUC125wbm+rYgxjPxpSxQNl9uN37 X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=KcycQgFPX2wGR5azS7RhpBqedglOZVgRPfdFSPB1LNw= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752889811053514079?= X-GMAIL-MSGID: =?utf-8?q?1752889811053514079?= As the last user was removed we can delete this function. Signed-off-by: Thomas Weißschuh --- include/linux/hid.h | 6 ------ 1 file changed, 6 deletions(-) diff --git a/include/linux/hid.h b/include/linux/hid.h index e8400aa78522..7c5fce6a189e 100644 --- a/include/linux/hid.h +++ b/include/linux/hid.h @@ -858,12 +858,6 @@ extern struct hid_ll_driver hidp_hid_driver; extern struct hid_ll_driver uhid_hid_driver; extern struct hid_ll_driver usb_hid_driver; -static inline bool hid_is_using_ll_driver(struct hid_device *hdev, - struct hid_ll_driver *driver) -{ - return hdev->ll_driver == driver; -} - extern bool hid_is_usb(const struct hid_device *hdev); #define PM_HINT_FULLON 1<<5 From patchwork Thu Dec 22 05:10:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= X-Patchwork-Id: 35613 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp141594wrn; Wed, 21 Dec 2022 21:11:40 -0800 (PST) X-Google-Smtp-Source: AMrXdXvlNNKULXsaOiYotCkJXWjAHHv0URFlPHUlRO7nB00ECNRLVJ9Qy4AiJq/qJyZqxdiaMBwJ X-Received: by 2002:a17:906:1c89:b0:7c0:b3a3:9b70 with SMTP id g9-20020a1709061c8900b007c0b3a39b70mr3734810ejh.62.1671685900635; Wed, 21 Dec 2022 21:11:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671685900; cv=none; d=google.com; s=arc-20160816; b=Lu1VaKxKM56Qxb/9alujRPyVRMdisBkN1f7dIzKqUefsz4xLUJx9mIJdjsRNExlcSL bD3z3yYEnbwjHXzkdVbdgmZ1b4Mr7tk5MpjnuEe6k3T9XEY3MHpEksD4qAtLf3ZKtD1f sBXq0WStBgkUqbSGMfyquWQ5rYuazf6KyV5YlSsAj//t/8Rg+drmWm6J2HSOzMX2N3px RfQeq989DTH2VpFpHVFAFmF+YpnWuXVWcTsbGFkT4Md7womzSCANZ1mGnaAJ4MrDy+Wt r3xuD010qMvMpTPp6931430h0hm6n/1wiUIFtDLohxFCbPZDhOOMRCXaZ5Ik2VV7R5mt J/Ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:dkim-signature :from; bh=/FWFhopZct+X9aRhyei2rNNgdCrKMVpBmOjRgOYxprQ=; b=lwVGUOT+sIiSA2+3zkClnoGzAC+ZsVtQUPJFULpzO4ihZDQPYurhGpedrTNcoUHmpI nElhpn8ZBSVulwn7hY3zGPfFGAlK38Spk6SeMpA8JubnZHLsEL5bfrSzaor8QenTWkay YADD9CEK/P9m55bsg7NRGgi+wY1j3M5F82wJtToKGull0QPdaPf1f6vOFfFHK4HSGDtB Ar86PXqRLcAwboL35+Bzimq5pAdck5TSpghS1UvUMisQTmqAZK9x+/KYygDqfUCkv8BY qWklZqKYJHcJE6a5s4bOgNiR63pgFB5YrNttTZiiaOWhW/L9US3dmezDAhG2nd6m/MNo 3S0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@weissschuh.net header.s=mail header.b=B4KopxcG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sb25-20020a1709076d9900b0080de94d6270si4660907ejc.304.2022.12.21.21.11.16; Wed, 21 Dec 2022 21:11:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@weissschuh.net header.s=mail header.b=B4KopxcG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234949AbiLVFK4 (ORCPT + 99 others); Thu, 22 Dec 2022 00:10:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230417AbiLVFKw (ORCPT ); Thu, 22 Dec 2022 00:10:52 -0500 Received: from todd.t-8ch.de (todd.t-8ch.de [IPv6:2a01:4f8:c010:41de::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12268165B2; Wed, 21 Dec 2022 21:10:50 -0800 (PST) From: Thomas =?utf-8?q?Wei=C3=9Fschuh?= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=weissschuh.net; s=mail; t=1671685848; bh=RIY1KZguWJeqHeg13Dbz3EKLW3n5Yawly4C6fJX/LRo=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=B4KopxcGDKneLhdAvB+atbk/GeTqzo6ATdvLeucyapM3W/3YYRA4GH5o+Aa+jUqvr DsyaescBu1lPdwZen5tz3kT2577Fh2cp5C3B75c5tTBQfFMdE6YSMkbudcV3v/42nf 0mRODCEI7Tom4lYQPSvqzdcZijSAf7VZXJ4NEWcs= Date: Thu, 22 Dec 2022 05:10:47 +0000 Subject: [PATCH 4/8] HID: Unexport struct usb_hid_driver MIME-Version: 1.0 Message-Id: <20221222-hid-v1-4-f4a6c35487a5@weissschuh.net> References: <20221222-hid-v1-0-f4a6c35487a5@weissschuh.net> In-Reply-To: <20221222-hid-v1-0-f4a6c35487a5@weissschuh.net> To: Hans de Goede , Jiri Kosina , Benjamin Tissoires , David Rheinsberg , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, Thomas =?utf-8?q?Wei=C3=9Fschuh?= X-Mailer: b4 0.11.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1671685845; l=1454; i=linux@weissschuh.net; s=20221212; h=from:subject:message-id; bh=RIY1KZguWJeqHeg13Dbz3EKLW3n5Yawly4C6fJX/LRo=; b=Twlbh9MUsolPC82vCzevu0rgTC04hHdXtPIymvu1dlWN4lhliG2xZcHHYVBpMH7XO1SMuEjKKlp7 hpKtj9u4C3bfXOpPLVvR2NF9tVYHgzvL6IRNjQZRixgb8yX4EhSl X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=KcycQgFPX2wGR5azS7RhpBqedglOZVgRPfdFSPB1LNw= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752889714754038964?= X-GMAIL-MSGID: =?utf-8?q?1752889714754038964?= As no external users remain this implementation detail does not need to be exported anymore. Signed-off-by: Thomas Weißschuh --- drivers/hid/usbhid/hid-core.c | 3 +-- include/linux/hid.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c index 54b0280d0073..4143bab3380a 100644 --- a/drivers/hid/usbhid/hid-core.c +++ b/drivers/hid/usbhid/hid-core.c @@ -1318,7 +1318,7 @@ static bool usbhid_may_wakeup(struct hid_device *hid) return device_may_wakeup(&dev->dev); } -struct hid_ll_driver usb_hid_driver = { +static struct hid_ll_driver usb_hid_driver = { .parse = usbhid_parse, .start = usbhid_start, .stop = usbhid_stop, @@ -1332,7 +1332,6 @@ struct hid_ll_driver usb_hid_driver = { .idle = usbhid_idle, .may_wakeup = usbhid_may_wakeup, }; -EXPORT_SYMBOL_GPL(usb_hid_driver); bool hid_is_usb(const struct hid_device *hdev) { diff --git a/include/linux/hid.h b/include/linux/hid.h index 7c5fce6a189e..170cad696541 100644 --- a/include/linux/hid.h +++ b/include/linux/hid.h @@ -856,7 +856,6 @@ struct hid_ll_driver { extern struct hid_ll_driver i2c_hid_ll_driver; extern struct hid_ll_driver hidp_hid_driver; extern struct hid_ll_driver uhid_hid_driver; -extern struct hid_ll_driver usb_hid_driver; extern bool hid_is_usb(const struct hid_device *hdev); From patchwork Thu Dec 22 05:10:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= X-Patchwork-Id: 35615 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp141815wrn; Wed, 21 Dec 2022 21:12:28 -0800 (PST) X-Google-Smtp-Source: AMrXdXv8DiPKcU3Du99V3Goz+Iq8AIqqFnAkIQSa2kDwh9qa+amUQ9kV6Uo+onFWcTfQWWn9zR8L X-Received: by 2002:a05:6402:12d4:b0:461:6219:4b16 with SMTP id k20-20020a05640212d400b0046162194b16mr3677554edx.33.1671685948041; Wed, 21 Dec 2022 21:12:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671685948; cv=none; d=google.com; s=arc-20160816; b=1HzoOH782ZtWkd+otchHbiuZcvUgumpLwQLusnB2z6Txce3VShU/bl+B3r1xasyQtv wZe9DzwZGxtnsCDav7yu7qUAXiUq9MXDTItRER+DRXSMDM+VuBm2t7Kl4v6N/f+zCi3E U5ITUbyLt1LU4FaxQeJOYwKBswZRmNLXVVeEq1tFUYM+T+DP7Dgvg+uYiKSaZrAWyUg9 yS5SIiFmHNNv2cEOozcvIaCCv40FqAAwhL+yFRqAZI6SuvG7bQbg3u//uB/PwEj/M3fJ p9V6l2v2+q1iuJ02ipjNDfcbf8uJtCbLRdMwfhQ3PGJsRHiGKwJvkE7Cgod4f3g1VVr8 lcGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:dkim-signature :from; bh=m6ADRQEvLG5gQhC5hujnMjR/METQD6S0G7MdI4tWG98=; b=vLSwBTo6cfju2KAXMstPIGGqokDNVlF0sGwLYtmeCw8T5y4vbsY1aybkrwva+2K627 OACYMKQFvbZsk1ZSopMHjHynvLoW4jQN4DV4UV2WIDmBLVYD554NhbxegXdBn63CB4Q1 RIbz/ZkaxaygNcjM+IJ2NVscRZjHNA6ew49+LgDvOseCB+8DhNNfOi1cmlpg/9wtEaPa zPzfnx2cFwsEnCd3M/P3C996GZapy3PxA/Rpk8wJ8OAMmgOu6ao3mBDzOTa5QWFz199/ mwzRHYSbaoBvcW33XA8Dxq4FizOjb9Xf20Pvdpqq7g3vNnMacgCEYeg2WOUMiPLgXse9 OsiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@weissschuh.net header.s=mail header.b=q5AqM4c+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dz10-20020a0564021d4a00b0045cfb63a033si6752250edb.551.2022.12.21.21.12.03; Wed, 21 Dec 2022 21:12:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@weissschuh.net header.s=mail header.b=q5AqM4c+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235061AbiLVFLR (ORCPT + 99 others); Thu, 22 Dec 2022 00:11:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234939AbiLVFK4 (ORCPT ); Thu, 22 Dec 2022 00:10:56 -0500 Received: from todd.t-8ch.de (todd.t-8ch.de [IPv6:2a01:4f8:c010:41de::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E34F2165B2; Wed, 21 Dec 2022 21:10:54 -0800 (PST) From: Thomas =?utf-8?q?Wei=C3=9Fschuh?= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=weissschuh.net; s=mail; t=1671685851; bh=6D4t7+JXnsI1DZVJH2nKSPANnSWnoNUa6Jai4hAGGu0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=q5AqM4c+GY8WS6WkXYvHnj9n88nW4RLtbP/bIVz5vGdSs8bg194M4EbvKBEU34+F5 eUX/KtMRAmD3EjJtYDRO8hEBI0AOlzsvVkAI/L4duw0OhcHG4El57ywfk1T6s8PtnT PEVkRt8ZCYM/c7PiaPR1F/z+L1oXeVAw4Ff41bsY= Date: Thu, 22 Dec 2022 05:10:48 +0000 Subject: [PATCH 5/8] HID: Unexport struct uhid_hid_driver MIME-Version: 1.0 Message-Id: <20221222-hid-v1-5-f4a6c35487a5@weissschuh.net> References: <20221222-hid-v1-0-f4a6c35487a5@weissschuh.net> In-Reply-To: <20221222-hid-v1-0-f4a6c35487a5@weissschuh.net> To: Hans de Goede , Jiri Kosina , Benjamin Tissoires , David Rheinsberg , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, Thomas =?utf-8?q?Wei=C3=9Fschuh?= X-Mailer: b4 0.11.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1671685845; l=1385; i=linux@weissschuh.net; s=20221212; h=from:subject:message-id; bh=6D4t7+JXnsI1DZVJH2nKSPANnSWnoNUa6Jai4hAGGu0=; b=ueKsApjEc+dHlbV5vxODk6cHsdKukzb8/qpLEcck8VMUonrilUZkvyjDis9pnwrHNt9/RpmXQMV9 cQwA8HBrBT1Wf/ImQaWGcl8NtV+HDRASjrB+h5PYMZU+iR0qrbwa X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=KcycQgFPX2wGR5azS7RhpBqedglOZVgRPfdFSPB1LNw= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752889764555364541?= X-GMAIL-MSGID: =?utf-8?q?1752889764555364541?= As there are no external users this implementation detail does not need to be exported. Signed-off-by: Thomas Weißschuh --- drivers/hid/uhid.c | 3 +-- include/linux/hid.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/hid/uhid.c b/drivers/hid/uhid.c index 2a918aeb0af1..6cec0614fc98 100644 --- a/drivers/hid/uhid.c +++ b/drivers/hid/uhid.c @@ -387,7 +387,7 @@ static int uhid_hid_output_report(struct hid_device *hid, __u8 *buf, return uhid_hid_output_raw(hid, buf, count, HID_OUTPUT_REPORT); } -struct hid_ll_driver uhid_hid_driver = { +static struct hid_ll_driver uhid_hid_driver = { .start = uhid_hid_start, .stop = uhid_hid_stop, .open = uhid_hid_open, @@ -396,7 +396,6 @@ struct hid_ll_driver uhid_hid_driver = { .raw_request = uhid_hid_raw_request, .output_report = uhid_hid_output_report, }; -EXPORT_SYMBOL_GPL(uhid_hid_driver); #ifdef CONFIG_COMPAT diff --git a/include/linux/hid.h b/include/linux/hid.h index 170cad696541..3fcc47a9d0e8 100644 --- a/include/linux/hid.h +++ b/include/linux/hid.h @@ -855,7 +855,6 @@ struct hid_ll_driver { extern struct hid_ll_driver i2c_hid_ll_driver; extern struct hid_ll_driver hidp_hid_driver; -extern struct hid_ll_driver uhid_hid_driver; extern bool hid_is_usb(const struct hid_device *hdev); From patchwork Thu Dec 22 05:10:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= X-Patchwork-Id: 35620 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp142465wrn; Wed, 21 Dec 2022 21:14:44 -0800 (PST) X-Google-Smtp-Source: AMrXdXvLK8Lr3UaQuMFuEjzMkSHABGOALRuEAg1EgbmeppitUduEC2qdI5QkSRwqt7XhTj37M2aG X-Received: by 2002:a05:6402:2296:b0:478:b87d:94d0 with SMTP id cw22-20020a056402229600b00478b87d94d0mr3450461edb.17.1671686083969; Wed, 21 Dec 2022 21:14:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671686083; cv=none; d=google.com; s=arc-20160816; b=xIsMF5MjDAM2DSIZ3toPQ6vuFUAUxd05OJQZKs+5pDht9DiNTW4kJbo0voF9ag8UPR SlX7dMVb2ITHXrs1eysJ4tHlHSMTYxH1cpCiDtT7TkLGvk27ibp0UhW4nfmLrMrWfx5O GXSE1cvpiuHsLDFhR8OUDgVqWqyzw7ajPbW3y7OcDNMaevxrPPtDn5+LOWVo/YGJIts8 zV/nYwcy1Eieq1nHC+bEXm/txmYZrfy56ZQjKrTVtGp/k56/eB4yXJ1+UuN+7B6lMcYQ nwKyU9NIPrucVXb9IuihluFZ1BhLIsuH2X+qA3rkdMCFAql27ZPfD20fjGRrRJgV+xwj ipzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:dkim-signature :from; bh=SuwbiOUUHJpY0HgxxjE1sApyLz7ZuEPDDZAhUwXnaX4=; b=SutLzvUUlu7KS17aQBodPT/7YPhkNJ6BPAwtgzXJ/NUxWRdG0AIWkxMBEX8nTWZqOT g0gTfMfJARXiTCcZ/plL3O1XZzspJ9J9iSEznpn7Tt6+us+l7+OsfPIoZPSLdoBPcLoS KEKbGMzC8XXtBpZ4W24BXi/U6XzR/B7fpcCh0IUVQB5R6z7Xj5jNLFbaxSnCc7NZHaUY WvhViEqNCukR65FiWBg6nVaa5A7n9A6JEzw6uA60znvdfRjb4bHMkl5EbDf794x1JS9k Aytnb5lskYJ9M8q+uT+IXzACKw+PFQyfPVPe4FvKoEH90BfubGn5G48pDWu1Z121kbUV z0kQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@weissschuh.net header.s=mail header.b=n5IDgDSg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f13-20020a056402354d00b0046109fd5943si5394200edd.544.2022.12.21.21.14.20; Wed, 21 Dec 2022 21:14:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@weissschuh.net header.s=mail header.b=n5IDgDSg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235004AbiLVFLX (ORCPT + 99 others); Thu, 22 Dec 2022 00:11:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234942AbiLVFK4 (ORCPT ); Thu, 22 Dec 2022 00:10:56 -0500 Received: from todd.t-8ch.de (todd.t-8ch.de [IPv6:2a01:4f8:c010:41de::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8F22167EA; Wed, 21 Dec 2022 21:10:54 -0800 (PST) From: Thomas =?utf-8?q?Wei=C3=9Fschuh?= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=weissschuh.net; s=mail; t=1671685851; bh=KNDYF1vETUCv281B3wbscifz4EYdRKLnRT85P8QGRws=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=n5IDgDSgJ5Ft1nF8p7+fU1/gjFaYNms0ca7zuYALHWWAbIhrWhLcBASZkKCvQ0947 fYurq0cMzFzNMk96ev9jnrGRWWj4bd1BF26Ct/acvIpq0JAv+fYpVvGflq5o0vNbJR rUlHKN6n/c2XGX6Smjaq1ugRhTBew55yFB8lHujg= Date: Thu, 22 Dec 2022 05:10:49 +0000 Subject: [PATCH 6/8] HID: Unexport struct hidp_hid_driver MIME-Version: 1.0 Message-Id: <20221222-hid-v1-6-f4a6c35487a5@weissschuh.net> References: <20221222-hid-v1-0-f4a6c35487a5@weissschuh.net> In-Reply-To: <20221222-hid-v1-0-f4a6c35487a5@weissschuh.net> To: Hans de Goede , Jiri Kosina , Benjamin Tissoires , David Rheinsberg , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, Thomas =?utf-8?q?Wei=C3=9Fschuh?= X-Mailer: b4 0.11.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1671685845; l=1398; i=linux@weissschuh.net; s=20221212; h=from:subject:message-id; bh=KNDYF1vETUCv281B3wbscifz4EYdRKLnRT85P8QGRws=; b=/j3ygvhvFnOJULkdDMIiuq/c9IGI+in3/gju7WW3oMVJqQB8gWnhTYfiOIas7RwHuyv55bC8Ja/X MPkr7wWnAOo8Xb1xC5QrYW+9yzNGJOVrbkxXKNcJN6fTqBptKkmK X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=KcycQgFPX2wGR5azS7RhpBqedglOZVgRPfdFSPB1LNw= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752889907063468593?= X-GMAIL-MSGID: =?utf-8?q?1752889907063468593?= As there are no external users this implementation detail does not need to be exported. Signed-off-by: Thomas Weißschuh --- include/linux/hid.h | 1 - net/bluetooth/hidp/core.c | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/include/linux/hid.h b/include/linux/hid.h index 3fcc47a9d0e8..21017e1ddbdb 100644 --- a/include/linux/hid.h +++ b/include/linux/hid.h @@ -854,7 +854,6 @@ struct hid_ll_driver { }; extern struct hid_ll_driver i2c_hid_ll_driver; -extern struct hid_ll_driver hidp_hid_driver; extern bool hid_is_usb(const struct hid_device *hdev); diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c index cc20e706c639..c4a741f6ed5c 100644 --- a/net/bluetooth/hidp/core.c +++ b/net/bluetooth/hidp/core.c @@ -739,7 +739,7 @@ static void hidp_stop(struct hid_device *hid) hid->claimed = 0; } -struct hid_ll_driver hidp_hid_driver = { +static struct hid_ll_driver hidp_hid_driver = { .parse = hidp_parse, .start = hidp_start, .stop = hidp_stop, @@ -748,7 +748,6 @@ struct hid_ll_driver hidp_hid_driver = { .raw_request = hidp_raw_request, .output_report = hidp_output_report, }; -EXPORT_SYMBOL_GPL(hidp_hid_driver); /* This function sets up the hid device. It does not add it to the HID system. That is done in hidp_add_connection(). */ From patchwork Thu Dec 22 05:10:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= X-Patchwork-Id: 35619 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp142250wrn; Wed, 21 Dec 2022 21:13:57 -0800 (PST) X-Google-Smtp-Source: AMrXdXslDTrm7DUjB0qCp0taw3/xQzDJJ6rqzSY9ohOTIeYw/tSMLI1acTqPS/Busp/Dm6oo5cAk X-Received: by 2002:a05:6402:3706:b0:472:9af1:163f with SMTP id ek6-20020a056402370600b004729af1163fmr3580081edb.37.1671686037396; Wed, 21 Dec 2022 21:13:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671686037; cv=none; d=google.com; s=arc-20160816; b=jM+zEXUch1iUO2yYg/xawxQwXbiwqDIbVbeYzWBK5Gihnp165KeYCz6tt9epQC6TtI fNGz1sDK+PhikEGRfDoLCqHQ46BTQQd9wa7IdjDD8NxGGJNSOkwY7owduEPypORHCBeZ x0OQ4TEax1R5rJhLLdf8mb+TP0bL3K+5bALC735kvExEP+f1zTpp67BC+bNBpzmbQ7F2 8z6GnXuaDJ1iStjfRl7Uw16dp4ISWsgFdAYEI/cLwViUQbc5PrXOWfuTCslEzo1KyFbm h02mTSFXMdmCw01u6w3quIhFjMLcSGGwUY5GXUZ+3FR8m80aMLs4x+arm7d7d3ZjcdL0 tq0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:dkim-signature :from; bh=MMHpl1k6BqyJsKXmXM0PaWP9eJ+wd8dZs3I+DC10QiU=; b=w6Bt5mNSZxTC3Oow2R7EuafivZLSHhDsmlFpWg2pB3brzHydsUhxTjekIRDp1KoFs1 lXemmfXjApKv91Dg0eUmo/H4hcwDSia073OOFrWy0dpb7TTVUS79lEhA0mpTvxnffxIz rrNTPU2b6FbGJiHPdT+aV1ki8ZUcAyJ7RqwlLjLRHDFyCrNzN2YaOmaqMIyzPvksIuw9 /LKluoZOQ2SH6q+dSDlQBY477Ad9nUcwRWQ2oip0xV6gW1JHquxDkqcTSXWJYQ5Ebadc +53Lr57MEI/RG6oRbHX8zpSS3KhayEgypD7Rvrgl20OQTp1gdTWLV0gB5bIwPhmfLu7L ovCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@weissschuh.net header.s=mail header.b=epcg2+Bo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b11-20020a056402278b00b004619867344csi17522734ede.0.2022.12.21.21.13.33; Wed, 21 Dec 2022 21:13:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@weissschuh.net header.s=mail header.b=epcg2+Bo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235096AbiLVFLp (ORCPT + 99 others); Thu, 22 Dec 2022 00:11:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234935AbiLVFK4 (ORCPT ); Thu, 22 Dec 2022 00:10:56 -0500 Received: from todd.t-8ch.de (todd.t-8ch.de [IPv6:2a01:4f8:c010:41de::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 381B31658E; Wed, 21 Dec 2022 21:10:54 -0800 (PST) From: Thomas =?utf-8?q?Wei=C3=9Fschuh?= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=weissschuh.net; s=mail; t=1671685851; bh=3tt57RWBYX5CpuseBTCAV7ztLBfuQPQBKVNcrS3Coqo=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=epcg2+BoRcWGmGGExUkIbvMK3fOGUjiEpfuFMiP5Tk8cnxTRWIzvBWidu537lLYcD XHcmWj/niC/YYxHl2d9Tp0CCnRI/ez+gg1Vk9vrfKrMDW/6mLdadFHCPQe40DB5U0f LMgI6Wat2IpMhJynmRD6LU6BVfS5HjScNkZKUq7I= Date: Thu, 22 Dec 2022 05:10:50 +0000 Subject: [PATCH 7/8] HID: Unexport struct i2c_hid_ll_driver MIME-Version: 1.0 Message-Id: <20221222-hid-v1-7-f4a6c35487a5@weissschuh.net> References: <20221222-hid-v1-0-f4a6c35487a5@weissschuh.net> In-Reply-To: <20221222-hid-v1-0-f4a6c35487a5@weissschuh.net> To: Hans de Goede , Jiri Kosina , Benjamin Tissoires , David Rheinsberg , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, Thomas =?utf-8?q?Wei=C3=9Fschuh?= X-Mailer: b4 0.11.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1671685845; l=1468; i=linux@weissschuh.net; s=20221212; h=from:subject:message-id; bh=3tt57RWBYX5CpuseBTCAV7ztLBfuQPQBKVNcrS3Coqo=; b=osblnINoh9h3TCBJu+R5RiGx1YADyMfECKm+DAviSnAPrv2sUjAeix34W7wZKB3wMhcCKrZ6KPas ScB0DkgNAuPTRFqHvN9l+muu7v+WUErl0i20VnRMX4+88j1EYq/f X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=KcycQgFPX2wGR5azS7RhpBqedglOZVgRPfdFSPB1LNw= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752889858032778408?= X-GMAIL-MSGID: =?utf-8?q?1752889858032778408?= As there are no external users this implementation detail does not need to be exported. Signed-off-by: Thomas Weißschuh --- drivers/hid/i2c-hid/i2c-hid-core.c | 3 +-- include/linux/hid.h | 2 -- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c index b86b62f97108..fc5a0dd4eb92 100644 --- a/drivers/hid/i2c-hid/i2c-hid-core.c +++ b/drivers/hid/i2c-hid/i2c-hid-core.c @@ -842,7 +842,7 @@ static void i2c_hid_close(struct hid_device *hid) clear_bit(I2C_HID_STARTED, &ihid->flags); } -struct hid_ll_driver i2c_hid_ll_driver = { +static struct hid_ll_driver i2c_hid_ll_driver = { .parse = i2c_hid_parse, .start = i2c_hid_start, .stop = i2c_hid_stop, @@ -851,7 +851,6 @@ struct hid_ll_driver i2c_hid_ll_driver = { .output_report = i2c_hid_output_report, .raw_request = i2c_hid_raw_request, }; -EXPORT_SYMBOL_GPL(i2c_hid_ll_driver); static int i2c_hid_init_irq(struct i2c_client *client) { diff --git a/include/linux/hid.h b/include/linux/hid.h index 21017e1ddbdb..60a092150bc6 100644 --- a/include/linux/hid.h +++ b/include/linux/hid.h @@ -853,8 +853,6 @@ struct hid_ll_driver { bool (*may_wakeup)(struct hid_device *hdev); }; -extern struct hid_ll_driver i2c_hid_ll_driver; - extern bool hid_is_usb(const struct hid_device *hdev); #define PM_HINT_FULLON 1<<5 From patchwork Thu Dec 22 05:10:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= X-Patchwork-Id: 35617 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp141972wrn; Wed, 21 Dec 2022 21:12:59 -0800 (PST) X-Google-Smtp-Source: AMrXdXvARpPH/V664DktRILRh1bB0TJOm8OfM1yAf1jzsLevJ4QZriwRF9xpRHydvL8BO/9beVfD X-Received: by 2002:a50:ee8c:0:b0:47e:6b3c:931a with SMTP id f12-20020a50ee8c000000b0047e6b3c931amr2927144edr.10.1671685979190; Wed, 21 Dec 2022 21:12:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671685979; cv=none; d=google.com; s=arc-20160816; b=ybUAc+7uMEJU+YCX57ZJms7ns9dFQzaoyWfreIx2KlIY9i1gKzHkJGlfx/sfgyo5pO UMImdhpVvbxOLCf4nsNQ8S53jHM4CcQfqd6qE1Hr/SN3EOqHcJ2qM0p8sAG1koLiOf0Q w+pHV0MzTHraiWgbwsTrrcN0B/7OmfL1FqGKagsi4AxvsMLaz/YwD1lttBoP6/A9ukQU k21hhkpUNl7cenJloFOB7ZC/vNJSS3hkl+NcFyp/Ygwdl6Npz3gt3Bolj2HbEf43Q/73 KhyxQcEjCwEAR4VUulS9SzkINtrZCAiqpFevAMTQ8lmI+kbWO5m5pK/6vhm0GObtuJkg V6tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:dkim-signature :from; bh=L7fr2aMAIBnzgCyRjUmQnbeESlyNhpAn491dAA3Ro+Y=; b=A9Z9oRo8KxON5V25KmvQqQ0zxuxbsUfdxqg5bUFj9um1ApuGAFZ/Keuzfywp8eDRTH 1iEfHM8eva6D0gRljRBEhLfp0NMMQibKryEcVSCXyrV1NIwhRiGgkdsPbUCWSXWWQHrQ U1sBaaHL246ckboKflhdpsMb7yzJwkzAEpWfLcsPawyK8mjWZVYZNm1w3C6asxIFK+hQ eIb0L7/UkgqYTICiYJmYgY17eWmX1k7zbdvU0gp6ZJ0a05dQfLYnT45vPegEwLqVjFDp +BPu20XRukh2K/JCl7MZIVyOFy+rPJaNOIo5MJbJCH12MmcwY4kqzmKZwamHgrcBXpxc Q96A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@weissschuh.net header.s=mail header.b=G92vc5fD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v11-20020a056402348b00b0046649cd87c2si17921472edc.32.2022.12.21.21.12.35; Wed, 21 Dec 2022 21:12:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@weissschuh.net header.s=mail header.b=G92vc5fD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235116AbiLVFLe (ORCPT + 99 others); Thu, 22 Dec 2022 00:11:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234972AbiLVFK5 (ORCPT ); Thu, 22 Dec 2022 00:10:57 -0500 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E3131743F; Wed, 21 Dec 2022 21:10:56 -0800 (PST) From: Thomas =?utf-8?q?Wei=C3=9Fschuh?= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=weissschuh.net; s=mail; t=1671685851; bh=lmzuDjULh3kowLm3TMvFkxEVatyBx6FhtKbQzT2W7mU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=G92vc5fD4RJzAzO3nxwjQcNGLwYlPe5rQt5aoEUC4Yo5uPkn85VtzUGr7fATtFEao uJxAejwNs6/4m9WPN5CaaTGv2km78lm/0Uza7oi0s7DetP8qCgv+3gt00/NYnC6UGw N+WDQCC4KS4N8SL4GvqLAW5kV5hZxYUxfs9a4aIg= Date: Thu, 22 Dec 2022 05:10:51 +0000 Subject: [PATCH 8/8] HID: Make lowlevel driver structs const MIME-Version: 1.0 Message-Id: <20221222-hid-v1-8-f4a6c35487a5@weissschuh.net> References: <20221222-hid-v1-0-f4a6c35487a5@weissschuh.net> In-Reply-To: <20221222-hid-v1-0-f4a6c35487a5@weissschuh.net> To: Hans de Goede , Jiri Kosina , Benjamin Tissoires , David Rheinsberg , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, Thomas =?utf-8?q?Wei=C3=9Fschuh?= X-Mailer: b4 0.11.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1671685845; l=2830; i=linux@weissschuh.net; s=20221212; h=from:subject:message-id; bh=lmzuDjULh3kowLm3TMvFkxEVatyBx6FhtKbQzT2W7mU=; b=TrQRzvbiBIvM2hqcwA7qpilAY+5M4CjJABKmBOKmkVq49p7hE4I+VDC3iUmLrbzWhmg2T4XH45CP y6z/aG0rDAmHo/VUlI35Tx/LuQemT+fmoDni2btjQBfTBNztHI7S X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=KcycQgFPX2wGR5azS7RhpBqedglOZVgRPfdFSPB1LNw= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752889797433100962?= X-GMAIL-MSGID: =?utf-8?q?1752889797433100962?= Nothing is nor should be modifying these structs so mark them as const. Signed-off-by: Thomas Weißschuh --- drivers/hid/i2c-hid/i2c-hid-core.c | 2 +- drivers/hid/uhid.c | 2 +- drivers/hid/usbhid/hid-core.c | 2 +- include/linux/hid.h | 2 +- net/bluetooth/hidp/core.c | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c index fc5a0dd4eb92..af98ac31c8d4 100644 --- a/drivers/hid/i2c-hid/i2c-hid-core.c +++ b/drivers/hid/i2c-hid/i2c-hid-core.c @@ -842,7 +842,7 @@ static void i2c_hid_close(struct hid_device *hid) clear_bit(I2C_HID_STARTED, &ihid->flags); } -static struct hid_ll_driver i2c_hid_ll_driver = { +static const struct hid_ll_driver i2c_hid_ll_driver = { .parse = i2c_hid_parse, .start = i2c_hid_start, .stop = i2c_hid_stop, diff --git a/drivers/hid/uhid.c b/drivers/hid/uhid.c index 6cec0614fc98..f161c95a1ad2 100644 --- a/drivers/hid/uhid.c +++ b/drivers/hid/uhid.c @@ -387,7 +387,7 @@ static int uhid_hid_output_report(struct hid_device *hid, __u8 *buf, return uhid_hid_output_raw(hid, buf, count, HID_OUTPUT_REPORT); } -static struct hid_ll_driver uhid_hid_driver = { +static const struct hid_ll_driver uhid_hid_driver = { .start = uhid_hid_start, .stop = uhid_hid_stop, .open = uhid_hid_open, diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c index 4143bab3380a..257dd73e37bf 100644 --- a/drivers/hid/usbhid/hid-core.c +++ b/drivers/hid/usbhid/hid-core.c @@ -1318,7 +1318,7 @@ static bool usbhid_may_wakeup(struct hid_device *hid) return device_may_wakeup(&dev->dev); } -static struct hid_ll_driver usb_hid_driver = { +static const struct hid_ll_driver usb_hid_driver = { .parse = usbhid_parse, .start = usbhid_start, .stop = usbhid_stop, diff --git a/include/linux/hid.h b/include/linux/hid.h index 60a092150bc6..39a374c7fbac 100644 --- a/include/linux/hid.h +++ b/include/linux/hid.h @@ -595,7 +595,7 @@ struct hid_device { /* device report descriptor */ struct device dev; /* device */ struct hid_driver *driver; - struct hid_ll_driver *ll_driver; + const struct hid_ll_driver *ll_driver; struct mutex ll_open_lock; unsigned int ll_open_count; diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c index c4a741f6ed5c..bed1a7b9205c 100644 --- a/net/bluetooth/hidp/core.c +++ b/net/bluetooth/hidp/core.c @@ -739,7 +739,7 @@ static void hidp_stop(struct hid_device *hid) hid->claimed = 0; } -static struct hid_ll_driver hidp_hid_driver = { +static const struct hid_ll_driver hidp_hid_driver = { .parse = hidp_parse, .start = hidp_start, .stop = hidp_stop,