From patchwork Tue Oct 4 08:59:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tsukasa OI X-Patchwork-Id: 1673 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp28481wrs; Tue, 4 Oct 2022 02:01:09 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4XrES7K6rDkLxv1In2XZcF8m5hJ0nOnrLv/NG7mLksY7ng+CR5/NmqmCQYX/UgxiPcbrWe X-Received: by 2002:a17:907:3f04:b0:741:4bf4:fe42 with SMTP id hq4-20020a1709073f0400b007414bf4fe42mr18806388ejc.664.1664874068930; Tue, 04 Oct 2022 02:01:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664874068; cv=none; d=google.com; s=arc-20160816; b=gaoY/I0p8eG8DmUz7bJubxJ+1pTquStIoVkDbTJrLP+RMhgd4iM1NdChbRLS/6H0Di kzih5EL5YPRDQlruIW82m2gwXsCEvoeHkrFef/IvliB9J1iHQvCjT2cK65Dv3v/7tVVF HgAcydPHmvCiAEBPs/BQRE7Ss3Od4MmdF5vsNnfPCgUy/BhBMMsaDMsWkLClm2uqMDcs hYvof+rXjs3w1+lwcTPXCFTZF+psv6r0wYDdEzZ8AA3c7oAKpnz2hfR0VPMQ3rNk9i+s vu60sVyRph1x020kh2vS7H/xX9WjlKE9H9+nB1a3ING3SC1+Mx7Ix0IHEBbd4ELbwugs q9+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:reply-to:from:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:dmarc-filter:delivered-to:dkim-signature :dkim-filter; bh=pj7ALm8QnuORkwgHAG7vcZEuhafs3k5QklSGYuIMjaQ=; b=GGP9J+vlUa9llVziulFQ3wFvy2HE7Dq89xb5Rmy/hSQTyyS8xh1BS/fg9VmqehDM6X oS/wuIOIqMIcuxZ5sZ7XobzKqHX+fIoGA9bClm4bHSoOU8bWDsyVN3XLrkrNeMserEmi FKhlS4xohhdAFjObUMxMcCJNuRY0hNjSVbFKNtxUWVW+W9VBvECr2B59XdXokNAvt4u9 U8wyWl59kk84tCKP6gIanNA9BuZB1KwxS53ZtatPCt777mUw7qSYQEg25IEK9s8jKAvB X8Gn286+3yWxPp8quVoeHPpuYRS3jYXVXoaZkn7M10K6e+oBB1eRS2AoIHjMvoyhg3ZK rHzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=P9pYNF8S; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id hp4-20020a1709073e0400b00787b30fb920si11802656ejc.868.2022.10.04.02.01.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Oct 2022 02:01:08 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=P9pYNF8S; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3A8283850875 for ; Tue, 4 Oct 2022 09:00:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3A8283850875 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1664874036; bh=pj7ALm8QnuORkwgHAG7vcZEuhafs3k5QklSGYuIMjaQ=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=P9pYNF8SwnE50ng6iaaweh3hJLm5I4KV+ff71YEe9jwrVgJaJNOUhdMa6/QsFcItO thgRc3jJWCr4dG5qOhWAtsVMiLg6eWY/Xbt//yy6cA/YXdB6H37ki1Mecsdn9pwYf1 3KkVdRbt3XJxAEAcB7Hb9EMWSf9oV3fp20eBl2s4= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-sender-0.a4lg.com (mail-sender-0.a4lg.com [IPv6:2401:2500:203:30b:4000:6bfe:4757:0]) by sourceware.org (Postfix) with ESMTPS id 7D840385C32C; Tue, 4 Oct 2022 08:59:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7D840385C32C Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id ABA74300089; Tue, 4 Oct 2022 08:59:31 +0000 (UTC) To: Tsukasa OI , Nelson Chu , Kito Cheng , Palmer Dabbelt , Andrew Burgess , Jan Beulich Subject: [PATCH 1/2] RISC-V: Fix buffer overflow on print_insn_riscv Date: Tue, 4 Oct 2022 08:59:07 +0000 Message-Id: <0bc857d306bb7c8130e5328dbe6b9ed2fed3ef87.1664873933.git.research_trasio@irq.a4lg.com> In-Reply-To: References: Mime-Version: 1.0 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, KAM_MANYTO, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tsukasa OI via Binutils From: Tsukasa OI Reply-To: Tsukasa OI Cc: binutils@sourceware.org, gdb-patches@sourceware.org Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1745746991619630293?= X-GMAIL-MSGID: =?utf-8?q?1745746991619630293?= Because riscv_insn_length started to support instructions up to 176-bit, we need to increase packet buffer size to 176-bit in size. opcodes/ChangeLog: * riscv-dis.c (print_insn_riscv): Increase buffer size for max 176-bit length instructions. --- opcodes/riscv-dis.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/opcodes/riscv-dis.c b/opcodes/riscv-dis.c index 6ac69490b78..66643431429 100644 --- a/opcodes/riscv-dis.c +++ b/opcodes/riscv-dis.c @@ -999,7 +999,7 @@ riscv_disassemble_data (bfd_vma memaddr ATTRIBUTE_UNUSED, int print_insn_riscv (bfd_vma memaddr, struct disassemble_info *info) { - bfd_byte packet[8]; + bfd_byte packet[22]; insn_t insn = 0; bfd_vma dump_size; int status; From patchwork Tue Oct 4 08:59:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tsukasa OI X-Patchwork-Id: 1672 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp28033wrs; Tue, 4 Oct 2022 01:59:58 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5RnRqHKjK1RV71/8RsGOx3piiTxAnPRzNnETdkvlfWfT/KKBctZvh3pq9uzkdokqPjd+1g X-Received: by 2002:a17:906:4fc3:b0:72e:eab4:d9d7 with SMTP id i3-20020a1709064fc300b0072eeab4d9d7mr18407803ejw.599.1664873997966; Tue, 04 Oct 2022 01:59:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664873997; cv=none; d=google.com; s=arc-20160816; b=xICSlRqisomx3xyCnftL96y0O4vaPA1CvvuODG/uzbcTYiYG88DDbaErhPf8kn5IUn 8z7YgN2KOAcvXaO5LvJNsecV1XEZ8drLlUyfZ8FOC8S0WiGJnsjdV1edAlfD7rgkC3Q0 nv3KbV4QSEtrYHEtPND5JuyyH3J4wjJ3ptkbnHWsZD+7WEBOy3Re8oJ/CoKXbnDmXSax zGiMU8vSaRUXorCs+gMSXq+7KuTmtVMdf7d4jztSMhfOQi+WAPAjGPgN9A8Zr0MEOh6e ebriqanM+v1c6firdASlV1v6crxjDRX03htnnvrQZaM3XZp62hePrpWuD9afttmEWKuQ 1VSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:reply-to:from:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:dmarc-filter:delivered-to:dkim-signature :dkim-filter; bh=10RJpob7TsEpqZgz/da2hq7jdcBrovdJT3P2jfK5qUs=; b=ubHr69SixIrxlGvBH91JskVtXjBphCZ21TnAws0PkvBgWDlfgdkTrHRYVVufeNhcH0 C3cPMBb7V1UnCX5yqQ5gMxuR3EF7To0etPHCaqGTYtYOqOy5sHB9sHObPgIdebjrzw0F t6pbBQavmKgmcusyTJYUskHb8SP/Wg7HSx+MHGe6ydjL0HBPwmeunfR558wyC23SK55c 9dErIFvMLp/y0yqYI6+yjZ/S2MgO5ptnO9sF+5/2KY43+U5nq8pccGGYLif8EvCbd/DB fRX9285HKA2fu8sC+GSK80xHwjS6eqPT4jCLsCOKwLC2ygJMjzM8B1m6Z9kZ36J5brEf N1Mg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=tpnCcDNT; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id h22-20020a056402281600b0044f3b9ef98bsi12293800ede.27.2022.10.04.01.59.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Oct 2022 01:59:57 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=tpnCcDNT; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BD1C23854158 for ; Tue, 4 Oct 2022 08:59:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BD1C23854158 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1664873991; bh=10RJpob7TsEpqZgz/da2hq7jdcBrovdJT3P2jfK5qUs=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=tpnCcDNT25cnLquDiycF0kjMoF3NBFVxMOYkTk1MLIPvcTI/2PW9grMPvt6J8oVsM 75yhndnKKGT2SwKLUZ1JFKycpBKURG7r839bAHQtjbFhnoiKiDpnUfx7IWvtsN5RQ2 yOLMARic5YuomXbCVX+kEabVyL7D4ZODpJsqMHy4= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-sender-0.a4lg.com (mail-sender.a4lg.com [153.120.152.154]) by sourceware.org (Postfix) with ESMTPS id 03A53385C335; Tue, 4 Oct 2022 08:59:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 03A53385C335 Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 4294A300089; Tue, 4 Oct 2022 08:59:42 +0000 (UTC) To: Tsukasa OI , Nelson Chu , Kito Cheng , Palmer Dabbelt , Andrew Burgess , Jan Beulich Subject: [PATCH 2/2] gdb/riscv: Fix buffer overflow on riscv_insn::fetch_instruction Date: Tue, 4 Oct 2022 08:59:08 +0000 Message-Id: <89612fe01d902007bf84a7dfb0df5f85d5c166e4.1664873933.git.research_trasio@irq.a4lg.com> In-Reply-To: References: Mime-Version: 1.0 X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, KAM_MANYTO, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tsukasa OI via Binutils From: Tsukasa OI Reply-To: Tsukasa OI Cc: binutils@sourceware.org, gdb-patches@sourceware.org Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1745746917576060928?= X-GMAIL-MSGID: =?utf-8?q?1745746917576060928?= Because riscv_insn_length started to support instructions up to 176-bit, we need to increase packet buffer size to 176-bit in size. Note that this change will make the result of riscv_insn::fetch_instruction partial when the instruction is longer than 64-bits. To really support instructions longer than 64-bit, we need something more. --- gdb/riscv-tdep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/riscv-tdep.c b/gdb/riscv-tdep.c index 47d8f9e601b..99307bd2de1 100644 --- a/gdb/riscv-tdep.c +++ b/gdb/riscv-tdep.c @@ -1770,7 +1770,7 @@ riscv_insn::fetch_instruction (struct gdbarch *gdbarch, CORE_ADDR addr, int *len) { enum bfd_endian byte_order = gdbarch_byte_order_for_code (gdbarch); - gdb_byte buf[8]; + gdb_byte buf[22]; int instlen, status; /* All insns are at least 16 bits. */