From patchwork Mon Dec 19 17:19:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Gazzillo X-Patchwork-Id: 34665 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp2523814wrn; Mon, 19 Dec 2022 09:39:53 -0800 (PST) X-Google-Smtp-Source: AA0mqf6Qz1GM+iNW7MydNFd0ZkfFtbTiMhQMMnuYWOi1Rxb837t7Ogv3uAutLO+ElFj+zaImKws3 X-Received: by 2002:a17:902:f80e:b0:189:a520:2ff0 with SMTP id ix14-20020a170902f80e00b00189a5202ff0mr42521255plb.34.1671471593531; Mon, 19 Dec 2022 09:39:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671471593; cv=none; d=google.com; s=arc-20160816; b=wpLW+F9ohfxMEckUNNlGFSIG9zsHcWXCtRXwYlj6/Y/o2utg9L6UM7ypmrW2ls5BU2 qXA5ac7HToaZP2OaIdPPU+DqTLFqtTlYkL1w+vYbEcR7M1X7w4b5CCDNmWhnH1DSXSjx YZqMeTP91zyJ2D/76nFA1M8sZJZkemx4Su9RZgObgi2cDUthwLV7HG9F8D3UN9P7bgHq RQzwnM8eZOxUgvEvjSrqX2sOPEmaHvQ3sQtJJu2I5e5/XURsAuYu3yooGu0FfOumFo/W CJuV8duw8zO4gBnf+zvIazrCypG9pAwCkyO/4C9FN9XxcblU125lyVXMjNaW03jeMhTz 9zRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=/XohzGpmRSjINGfK1dS+OZeEMpnn9ty1uwaaqAHH2u4=; b=WFjAAiFkbnAi3cbFtkL7C7c1XbqTqsg5eMb1NiouPsXRFqNcxEs4cNd5Pd03esEJwl OduDOoIr+uMA2YDUps/2Exmtn0JC7vMaMbGs9pSqHa+zbmT6SaNPKnnj+gF/SkuxxgkY O/TckZHTgCKHfZ+EYJCyhVQoQWe5c3HMVin2LkliowgZ62EPA+b1ys1+eG4T464dptYP SF7gKLROJwoL3KESvBddKWYZOowp7RervLU76R9YIVIsT5eY4HnNWXGrjs3E9mgKDAG1 UMwG7f6CGCUd+lrv4Ju7jUQyg5raJ+haR/OEjpenLA7pr3PeiRKQutcMTMlx9yJg4A0C K68Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@pgazz.com header.s=mail header.b=GJQcaj2x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=pgazz.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n10-20020a65488a000000b00476e63d01a8si11766570pgs.570.2022.12.19.09.39.40; Mon, 19 Dec 2022 09:39:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@pgazz.com header.s=mail header.b=GJQcaj2x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=pgazz.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232326AbiLSRTv (ORCPT + 99 others); Mon, 19 Dec 2022 12:19:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231959AbiLSRTd (ORCPT ); Mon, 19 Dec 2022 12:19:33 -0500 Received: from box.opentheblackbox.net (box.opentheblackbox.net [IPv6:2600:3c02::f03c:92ff:fee2:82bc]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 165212FB; Mon, 19 Dec 2022 09:19:33 -0800 (PST) Received: from authenticated-user (box.opentheblackbox.net [172.105.151.37]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by box.opentheblackbox.net (Postfix) with ESMTPSA id EB7B83EA50; Mon, 19 Dec 2022 12:19:31 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=pgazz.com; s=mail; t=1671470372; bh=9bYAYnsF3sM0kY4DcqJgvSrfn3Yhvu5t4LsWQCVQ22c=; h=From:To:Cc:Subject:Date:From; b=GJQcaj2xzpKLi5sHc3YQsD6NWInQKxVlMsfPXGSd/qlRDRg1emOaEYSLxr5ZmnJuu XQ4rx/Vz1CIH56ag6NqmeL8WRtR3Bk2fyjPJ4egMEOwFnnBpVWrQt8Ww9mjkh7+JRX J7CckD7a3o3jwPpXwkeuQPKdKpAjYO3LYOrfUurdlNnSDmlqLLm1tXSJH7HBdNrR3r S+PRCP024baGQTjsdTe/BpCgi7ZSr9wY3G/By6PGl+RX9kLxWYEi+Mmni1pgYJBl4c wt2NNus2JCUUYtmiVxY+3LqFwectQVi1eghXHD6S8FTKeIhmDUjufdcXkpJGra7ejn t8DPptsHTOv0w== From: Paul Gazzillo To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Randy Dunlap , Yang Yingliang , Zheng Bin , Suman Ghosh , Sunil Goutham , Subbaraya Sundeep , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Paul Gazzillo Subject: [PATCH v2] octeontx2_pf: Select NET_DEVLINK when enabling OCTEONTX2_PF Date: Mon, 19 Dec 2022 12:19:11 -0500 Message-Id: <20221219171918.834772-1-paul@pgazz.com> MIME-Version: 1.0 X-Spam-Status: No, score=1.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_SBL_CSS,RCVD_IN_XBL, SPF_HELO_PASS,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752409612724020552?= X-GMAIL-MSGID: =?utf-8?q?1752664997910799461?= When using COMPILE_TEST, the driver controlled by OCTEONTX2_PF does not select NET_DEVLINK while the related OCTEONTX2_AF driver does. This means that when OCTEONTX2_PF is enabled from a default configuration, linker errors will occur due to undefined references to code controlled by NET_DEVLINK. 1. make.cross ARCH=x86_64 defconfig 2. make.cross ARCH=x86_64 menuconfig 3. Enable COMPILE_TEST General setup ---> Compile also drivers which will not load 4. Enable OCTEONTX2_PF Device Drivers ---> Network device support ---> Ethernet driver support ---> Marvell OcteonTX2 NIC Physical Function driver 5. Exit and save configuration. NET_DEVLINK will still be disabled. 6. make.cross ARCH=x86_64 several linker errors, for example, ld: drivers/net/ethernet/marvell/octeontx2/nic/otx2_devlink.o: in function `otx2_register_dl': otx2_devlink.c:(.text+0x142): undefined reference to `devlink_alloc_ns' This fix adds "select NET_DEVLINK" link to OCTEONTX2_PF's Kconfig specification to match OCTEONTX2_AF. Fixes: 2da489432747 ("octeontx2-pf: devlink params support to set mcam entry count") Signed-off-by: Paul Gazzillo --- v1 -> v2: Added the fixes tag drivers/net/ethernet/marvell/octeontx2/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/marvell/octeontx2/Kconfig b/drivers/net/ethernet/marvell/octeontx2/Kconfig index 3f982ccf2c85..639893d87055 100644 --- a/drivers/net/ethernet/marvell/octeontx2/Kconfig +++ b/drivers/net/ethernet/marvell/octeontx2/Kconfig @@ -31,6 +31,7 @@ config NDC_DIS_DYNAMIC_CACHING config OCTEONTX2_PF tristate "Marvell OcteonTX2 NIC Physical Function driver" select OCTEONTX2_MBOX + select NET_DEVLINK depends on (64BIT && COMPILE_TEST) || ARM64 depends on PCI depends on PTP_1588_CLOCK_OPTIONAL