From patchwork Fri Dec 16 12:05:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 33947 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp924015wrn; Fri, 16 Dec 2022 04:06:20 -0800 (PST) X-Google-Smtp-Source: AA0mqf4LUsAacvGpz2xajezOKMyIoiagA4/CFUz9Vnt4GOfDx7I+T4Fp1MnB+NgTmtb2vC7XxUao X-Received: by 2002:aa7:c94e:0:b0:467:5491:1e21 with SMTP id h14-20020aa7c94e000000b0046754911e21mr26272088edt.12.1671192380262; Fri, 16 Dec 2022 04:06:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671192380; cv=none; d=google.com; s=arc-20160816; b=dsTuGZUE0bP2GYMXlZMeb/1QzJkDRvv7acClyNvJQZ3UnFcx+O4kbhMw3SRM1kvXH8 NrgKuWwbxISusYhC0Yjr+nJyvy97umXA7LT4i54o8EEik+dBFMaMVGN7+qmNQLrmdAco j+BV+OOnFB+acmBmyN7YeDznYqF2YhZJM9iwgJhOO624OwTZxfm4ZJAP5bH0DxvBkXhK f6kOE8cNjydh8HVTASDmGWmmVFeHw9ka+pFodUB30PuCo8syoPZGvRqSeJ2QzdklgCPd 8oV9ngGoq+6i36+3aCypIipZP19qUP4yMIWLG2Tgj4ZpRYDkKnkG0Ivi75dvpOSNFezd vpsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:sender:errors-to:reply-to:from:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence :mime-version:user-agent:subject:cc:to:date:dmarc-filter :delivered-to:dkim-signature:dkim-filter; bh=eBQbdyLt3z+oFCEGmW4+R76PAWVEb6rmWgme4DQIm/E=; b=sbVg4O1Tpb/0K/5FP9o9CugUzl0Oeepbx0uZJ2ZtPF8s33NcmKQayLz1I3jmF9NPJr JsYE0r8p9DKNu95WuxRR2UWswtazz+MxWLXah3DPmT2ckyIV9nxvxbBHkdt5wrT3hQKH TEOq3i5ck0C173CFbucT8oa1H2a7vSn7mdN5gP5x9LcBg8LUwLhj3phDfyKHVGXMbneE ybOZ0Vp2HjVtHRadDiM3lwvajN9s0zNV4yS1ACo2qpnxAaBK7g3wQXFsAMNHJT1lCEgR nxsv+WgnxjQJVzOVp+KZEYx2eo5Fd8h4VK/nRukhmyy2wcjPS/yvaxLxK/Ec5jnUk7J8 UcaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=FGTCfG0H; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id l10-20020a056402254a00b00470095cc20fsi2725992edb.266.2022.12.16.04.06.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Dec 2022 04:06:20 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=FGTCfG0H; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1A7CB384D6C3 for ; Fri, 16 Dec 2022 12:06:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1A7CB384D6C3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1671192377; bh=eBQbdyLt3z+oFCEGmW4+R76PAWVEb6rmWgme4DQIm/E=; h=Date:To:cc:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=FGTCfG0HMytPsigGusZFmhtzudMU89vjTuGqPyOfPw3+Uzm7l9OOfYrb3FiD5ZO6X Hh97MZf3gQ9pyTonmI8BimDCvgItVTNwLAB6xOv3C6Tcq9GrH4V2Ut4WiGo7bmtmoA z4GLnHiaM+RQlbQubl72GQyusv4uWFfsJHmt5Do4= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id C3EE13856B70 for ; Fri, 16 Dec 2022 12:05:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C3EE13856B70 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id EA89533FFD; Fri, 16 Dec 2022 12:05:31 +0000 (UTC) Received: from wotan.suse.de (wotan.suse.de [10.160.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id DE2462C141; Fri, 16 Dec 2022 12:05:31 +0000 (UTC) Date: Fri, 16 Dec 2022 12:05:31 +0000 (UTC) To: gcc-patches@gcc.gnu.org cc: Jan Hubicka Subject: [PATCH] middle-end/108086 - avoid unshare_expr when remapping SSA names User-Agent: Alpine 2.22 (LSU 394 2020-01-19) MIME-Version: 1.0 X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Biener via Gcc-patches From: Richard Biener Reply-To: Richard Biener Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" Message-Id: <20221216120617.1A7CB384D6C3@sourceware.org> X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752372221408934957?= X-GMAIL-MSGID: =?utf-8?q?1752372221408934957?= r0-89280-g129a37fc319db8 added unsharing to remap_ssa_name but that wasn't in the version of the patch posted. That has some non-trivial cost through mostly_copy_tree_r and copy_tree_r but more importantly it doesn't seem to be necessary. I've successfully bootstrapped and tested with an assert we only get tree_node_can_be_shared trees here. Bootstrapped and tested on x86_64-unknown-linux-gnu with all languages. Pushed to trunk. PR middle-end/108086 * tree-inline.cc (remap_ssa_name): Do not unshare the result from the decl_map. --- gcc/tree-inline.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/tree-inline.cc b/gcc/tree-inline.cc index c802792fa07..b471774ce51 100644 --- a/gcc/tree-inline.cc +++ b/gcc/tree-inline.cc @@ -183,7 +183,7 @@ remap_ssa_name (tree name, copy_body_data *id) return name; } - return unshare_expr (*n); + return *n; } if (processing_debug_stmt)