From patchwork Fri Sep 30 08:54:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 1577 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp380615wrs; Fri, 30 Sep 2022 01:54:33 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7Bklz/LmUDJmF/+1MYgFQs4wVvhAx3EFPxT9Ib3Mn5yaVKHS1Uv36P1lgnWmQlSfqF99wy X-Received: by 2002:a05:6402:1014:b0:451:d2a1:236e with SMTP id c20-20020a056402101400b00451d2a1236emr7135432edu.212.1664528073133; Fri, 30 Sep 2022 01:54:33 -0700 (PDT) Received: from sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id cm12-20020a0564020c8c00b004573e23619esi1560403edb.91.2022.09.30.01.54.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Sep 2022 01:54:33 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=DwYbPClY; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DCB46385C33A for ; Fri, 30 Sep 2022 08:54:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DCB46385C33A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1664528071; bh=DnC0MqeRGgsKWrYZY4sZQ96yRBpZvqFGxfNJFSCY/Qk=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=DwYbPClY3oiIKpOqH25+3Y3Oay3tHcap8hXDvGX52p5QzL5sUxTTTZvUugPwC9ZDs v8+fLGGvbBsezyzlHoQRAAUyTaCzNezZMJss+WfP7FHDtqYUg/qIIQbXHRmc7JT3CW G1B8w+keNxESWNGBv+1eJn6bfB8Q5vCOrq09FNsQ= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2058.outbound.protection.outlook.com [40.107.21.58]) by sourceware.org (Postfix) with ESMTPS id 1935E3858430 for ; Fri, 30 Sep 2022 08:54:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1935E3858430 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CyodYAeoZKh3m1FShhNlwcBlQgco3QoXOHimeLGt2f97umEHMxVbJbFgwBI2wyuai58fHcdNDWH7mmblJOxj3j4vEW2AAzWUAjaYWoJoTR/OeK8bvuzG2BqhKbXorJ3RbG0imovTQPx93SKJgBzNfLJjC9nKN/X7fOLn/EW43r/fXeMqdMooFYEXZXGYFL438nOqQDUWuj3cnNyRnMVaYFMeHItGIwPMXeMMMuFh7KLFl6x8Xckhvb/Cu1yuuYNc0vx7bH58xIDS8znfKXxD5wIooIUuO819qhtv+BubcrdV5I8iTbIrtnehrdv6K0wWANnIN2uwn2dMhIMlrxtjbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DnC0MqeRGgsKWrYZY4sZQ96yRBpZvqFGxfNJFSCY/Qk=; b=H3kyKj0BqpoENV3M+jShNqAZE9xo1PjUgjSSDdjzgDQnNv6pRCiY8qedzvGdjYqdcBTA8zEZkvSMWJEHvuU2U1oWAOcrkeEWDhcO/7t2L9DWb2RpVPc73ZkW94EzeSgVEuqIt/76qRIASRbJgoYVWrYMz/TcDvAior5LyRlC3LHvEZfwy+1XEuCKpMo5BUuZi2W/rX2VZJbyOZIcKVtqQF8tc6/u+0Eh7cVdTSOojORj1Lztp64okNFHlqpebgmnydJ8JeBBgS39Kb2dclBFP86A/+JFfyiB6RRepN8rssgRVp82J1ViYRKnj7rp71Ul6Njcbx0M8YprIwVAyEXTkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB7948.eurprd04.prod.outlook.com (2603:10a6:10:1e6::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 08:54:19 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.023; Fri, 30 Sep 2022 08:54:19 +0000 Message-ID: <76fa0c3c-2303-ebdf-a765-ac4731581517@suse.com> Date: Fri, 30 Sep 2022 10:54:18 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Content-Language: en-US To: Binutils Subject: [PATCH] objcopy: avoid "shadowing" of remove() function name X-ClientProxiedBy: FR0P281CA0064.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB7948:EE_ X-MS-Office365-Filtering-Correlation-Id: 7dd47659-7682-4f03-2551-08daa2c15c91 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IWBG8uh+lmT9OyUT2+ul0aR4wDeVbxx/Ubp8EMMktA7GXBuZvktfcoLipDXKx8eKvfWh55OkzhKMMUo5+8rCFfBRRhfmw0C7eledpVtS1LM4qjTCXQzOurqo4GV+0juqbxtgqybiacScXtD8ttuXi/q7Vs+c5qM2ictfcDfxqew9B08dFhkwyVyi08uslyp3pK7yJyzcsKDeFFQT0bmCfK4ujTzNJkR6Ncr912fYR8MBfnglcMPQCgKCNyk+wP8OorEav1us3w03aNu6U0QoStdFbWwzTRkSixhN5pqyBFA2UDYzQPtVU2HGZd61rNpEsbE2n2+EypDkz7Tu3lvyj+ATN8bYfaFDnMc1fzuGuQIyNjSFp9GwIRkHdDcO1cOZqSztVI3RjnRqgKnL/oYtx7taklE/tw280g/BOj1OJ9U93U5mV5l00G9Vaq05MxcXbhdgeFFg4KCfOweGuOIMkYCVOipzJkjqsmkN+X+re331UuZ4Z6eg7I4VKbAASgDmdlEozi1IZK1NReUx79bRRmauTve3njjIzmT+CgvhdSzHTcIgaxMtC6lSt3C8sCWIro608RWoUPCMM32m3add5vdomtNzG1v+6gHeevdcwfHPQR7AL4xbcdJeaANOz1aQNsbFZYJtE/fmBHLZxX9LycTzpX3mLcvskktrzqNuYYXtd7L/vud5zVXPiI+yY4BaSt2JWz1lQHYQ2KGz1CB2dm4iWqby6JezN45oG8O/B8ArqJkSvQQCMo/HAeBwu+1VTTCCDjAtFjfZLv8+lh3crRKdpQZMsKdVBdiA1shCmGc= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(136003)(39860400002)(376002)(396003)(346002)(451199015)(2616005)(83380400001)(38100700002)(186003)(2906002)(5660300002)(8936002)(41300700001)(478600001)(6506007)(6486002)(6512007)(26005)(8676002)(66556008)(66946007)(66476007)(6916009)(316002)(36756003)(31686004)(86362001)(31696002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?MR/j6GlPvgQ73ZBMyfjRsRiJp0T3?= =?utf-8?q?JKflxbQ6bnKdtuVIQ7t93pUqUFZySP6p2qwbv8An8THR6W5985dNiybNFBV6v8UD9?= =?utf-8?q?NuUv9YjwiOOR61QXozmlmsSxVKKp/rXbUbzorjw2sNCWrMyCyG+J8o8WafOj0X/bB?= =?utf-8?q?7msuzc2am3QOFoKsw6WB54zBM99XCa1Bj+atrPiEdxQ/MwR7ix2Tiw+vbjBVv9URd?= =?utf-8?q?X7KPZa6P+be1IfCNiCFowLZvuT+b26hZjfkHFDkasEvGeyRj7L30RLzlGV6xGokpD?= =?utf-8?q?p3tEobc3HUrJ4pWlDzAQDJqR2VDUCdBQDOCnGNQn4xSPNkLBwwsWZaIfrJ6+jYBCD?= =?utf-8?q?W5E+FYh1PaA7TSkI06EGO4ZwC0aAR7GzAF93IQTrDI9O+uQgogO3jOKjF0iVrniPC?= =?utf-8?q?g/b9s4RcCvIHUHbtjCsZ4E4kxRxaHbjylFIebS+5nTNU+0W12PQ+pQNQ3FGs9Fa8l?= =?utf-8?q?YrQuPDAzXR4oVnn1DGk/KRYFWiFuNt2E7LX3udy9waaWzbhE4fL/ldQhZEfNfdn5z?= =?utf-8?q?rgz5IjvUmja0eknxoGq9rSWU9lKe3y4SLgrYq9fO+od8gs0Puk7MNoG6P+vFDSctR?= =?utf-8?q?Wp56lwAaecZxdwo+cl2cP3NBrDXkLh8nSAMjlQXXZMaYb1WIdcRvweB6OkKpcsu+B?= =?utf-8?q?QltI7EyadXjphlb4owTiGhXxJv5L44YwHpSdYpNoKkfHnuhlqxP6FBr6ZbjlyJ02j?= =?utf-8?q?X3ukDWRxyqcCdVftn+jwr50wWqHf5esXchugI+8oGZAR17ulTI4bt9HtHvmjsXzOl?= =?utf-8?q?4PvCvYJiHV6AXnZK4acf4bNYBD4G/Dui3K6ig0Mb68qrUcNz2R7T6oBvZgKsG50fQ?= =?utf-8?q?3vkbnN7zON/6627IzSQg3A5RF2d/7NMHULgLcvbEWT3+K8GRqCzujwbH+XHiTIWi4?= =?utf-8?q?H3Q++Y7raus8tJetovqsarC1BAq5hvRhCwJ0m0lxynssbfuoKPMixTc0Ei6gnWA14?= =?utf-8?q?lg5mfgx2TuecrP0SNbKyvqRFNTjkW4rLOxGkDp+nbJlsK0kqTfVzBzbMMS8+8DDeI?= =?utf-8?q?SshUWf2Udp89Qn1gdPrmj36yjxjVq9/ghsmsYsTrHs1amisy5P/6jSlCzKZmlA1dD?= =?utf-8?q?SNd2TJIG/MUZMxo7gymmgexKquux3zaJyXduNmHAvK3ADfZibkb2EaTxLmVOR/irO?= =?utf-8?q?5faMIvj8eSZvZ0wO0DA3gO1H7v39fQPHsMDRfIeFcyYeVWBtu4SHwBCXcZSle1yPZ?= =?utf-8?q?NxQl/RVFtZx2RK1R+S06zkxlaxfJpak61ZJ8F2AKtSZE1wjkgX9ZUbxoB/RCpV7bq?= =?utf-8?q?iLbgzPHI9oOLSucR3o3gw3E0K14aLpT/cKq3zqLxmZaocODunI9ozjNLaoubdlsR0?= =?utf-8?q?XDgCPZP0Kfkrii4j3ooEPszjQtLqDzYeoPdJSy3tqYKAtl+D3lqRPr6nsja9/PyEX?= =?utf-8?q?4MVibPehwxUvZLxQOX0OoAXGW30UsM2X1cE5l73gs3crHFdU+ha4Bh7PbOhxG9k50?= =?utf-8?q?VeAMf9TyOKKsbwmOwo50KkY8RB6HQMEX57W7901I9z9EfuoZhzTfFAO/txicFpdEX?= =?utf-8?q?iELFfSIBDVCr?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7dd47659-7682-4f03-2551-08daa2c15c91 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 08:54:19.3312 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lgpWntQ9CDs+9k6gVXx+qm7bmfsXleoXACb1Bj+rzr4WF9+SaAIMPAseFbASraw0DIEJacLyITNy+9VimryL5g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7948 X-Spam-Status: No, score=-3030.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jan Beulich via Binutils From: Jan Beulich Reply-To: Jan Beulich Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-LABELS: =?utf-8?b?IlxcSW1wb3J0YW50Ig==?= X-GMAIL-THRID: =?utf-8?q?1745384188421543703?= X-GMAIL-MSGID: =?utf-8?q?1745384188421543703?= remove() is a standard library function (declared in stdio.h), which triggers a "shadows a global declaration" warning with some gcc versions. --- a/binutils/objcopy.c +++ b/binutils/objcopy.c @@ -4091,7 +4091,7 @@ setup_section (bfd *ibfd, sec_ptr isecti && (flags & (SEC_ALLOC | SEC_GROUP)) != 0 && !is_nondebug_keep_contents_section (ibfd, isection)) { - flagword remove = SEC_HAS_CONTENTS | SEC_LOAD | SEC_GROUP; + flagword clr = SEC_HAS_CONTENTS | SEC_LOAD | SEC_GROUP; if (bfd_get_flavour (obfd) == bfd_target_elf_flavour) { @@ -4100,7 +4100,7 @@ setup_section (bfd *ibfd, sec_ptr isecti being used with GDB, if they were based upon files that originally contained groups. */ if (flags & SEC_GROUP) - remove = SEC_LOAD; + clr = SEC_LOAD; else make_nobits = true; @@ -4108,9 +4108,9 @@ setup_section (bfd *ibfd, sec_ptr isecti elf.c:copy_private_bfd_data that section flags have not changed between input and output sections. This hack prevents wholesale rewriting of the program headers. */ - isection->flags &= ~remove; + isection->flags &= ~clr; } - flags &= ~remove; + flags &= ~clr; } osection = bfd_make_section_anyway_with_flags (obfd, name, flags);