From patchwork Wed Dec 14 02:51:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiapeng Chong X-Patchwork-Id: 33024 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp499704wrn; Tue, 13 Dec 2022 18:54:44 -0800 (PST) X-Google-Smtp-Source: AA0mqf685fgJxxY2SVQcUPtyUYSLCOr1b+WJxvbqVI9tSFKNfsDiiWFTNsy9P2yZ6LCtJMfmc3Uc X-Received: by 2002:a17:902:76c1:b0:186:ad88:43a9 with SMTP id j1-20020a17090276c100b00186ad8843a9mr25309543plt.36.1670986483991; Tue, 13 Dec 2022 18:54:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670986483; cv=none; d=google.com; s=arc-20160816; b=zgSMWQprC/8dGDupj0Z+4WW0bX8W/tphIErA9IQo18ou9+0ho6PnAPyKWqQbvHm4MF gI/vpqJg44Hamuqdo97JG0+DhjuLvYoBfxXsyqfdWHwxF5SOOf7Wrq2mjRCGuD9EA6TE AuCLsybcmwmKQfJTUqW1MsCKHpT6TbdlHbTTxadEPJwtgOAI7H0hiCbos4hu+NN5yWTZ 7+B+l/x1EXfwwoxNdteJzJ8Aro2TWCpIzKuRXMK+YLicUwtqWlst3vD1POqDt3iNUO1p +PzZIiLYY86ECFkXqfn8wff2i6hQC/nRf4kzU+Ur4DRLPuVHDLqwC/NFuHhBwK1kMYmO BBcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=SHX9C81Ab6qWlmXm/AZnK66qcmzGZbcgjFNIu5c5vRM=; b=fWElBEzLyMBRJwN7vy5qF2cQFrG8HTTFPcAZrxET5bqjlMcbb7gVYQE6tnu4q4VFZm eeszVtkrlC9Oz7oaJqZkYAtndVGlqneyWpGeqqxozGoAU0tJCzgumLnt9q7FqUwXogN2 X0lABUNw7p9Xa4Vm6lrD8b7LEaWafsV3Vmr1t5E/+hwa7gtr3VehUiMd/CdAh5po+TEN HSZS6F+lAYAYYQfgsGdND9Tqqeo3gAd75lKiFJZuJK0SNJxe5s5+hmXtJx6pWxS5G2Sp W2B0u7pB02QtDsSm0QzCy+dOmEiRHcgNm922MGV8wXJ5qI7GqllAuGjHLQExOmPTh8TQ Sr1A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p21-20020a170902f09500b0017d52dbbcb0si1415617pla.55.2022.12.13.18.54.30; Tue, 13 Dec 2022 18:54:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236975AbiLNCwH (ORCPT + 99 others); Tue, 13 Dec 2022 21:52:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237143AbiLNCwD (ORCPT ); Tue, 13 Dec 2022 21:52:03 -0500 Received: from out30-45.freemail.mail.aliyun.com (out30-45.freemail.mail.aliyun.com [115.124.30.45]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F337726AFE for ; Tue, 13 Dec 2022 18:51:35 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R451e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046059;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0VXGK2Xz_1670986274; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0VXGK2Xz_1670986274) by smtp.aliyun-inc.com; Wed, 14 Dec 2022 10:51:33 +0800 From: Jiapeng Chong To: jani.nikula@linux.intel.com Cc: joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tvrtko.ursulin@linux.intel.com, airlied@gmail.com, daniel@ffwll.ch, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot Subject: [PATCH v3] drm/i915: Remove unnecessary doc from static engine_init_common() Date: Wed, 14 Dec 2022 10:51:12 +0800 Message-Id: <20221214025112.104595-1-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752156323563331018?= X-GMAIL-MSGID: =?utf-8?q?1752156323563331018?= The function engine_init_common() has changed to static and we don't need doc comment in the static function. No functional modification involved. drivers/gpu/drm/i915/gt/intel_engine_cs.c:1306: warning: expecting prototype for intel_engines_init_common(). Prototype was for engine_init_common() instead. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3442 Fixes: 019bf277634a ("drm/i915: Pull out some more common engine init code") Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- Changes in v3: -Modify the commit message and add a "Fixes:" tag. drivers/gpu/drm/i915/gt/intel_engine_cs.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c index c33e0d72d670..7c29b1504ae7 100644 --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c @@ -1291,17 +1291,6 @@ create_kernel_context(struct intel_engine_cs *engine) &kernel, "kernel_context"); } -/** - * intel_engines_init_common - initialize cengine state which might require hw access - * @engine: Engine to initialize. - * - * Initializes @engine@ structure members shared between legacy and execlists - * submission modes which do require hardware access. - * - * Typcally done at later stages of submission mode specific engine setup. - * - * Returns zero on success or an error code on failure. - */ static int engine_init_common(struct intel_engine_cs *engine) { struct intel_context *ce;