From patchwork Tue Dec 13 17:03:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 32893 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp245259wrn; Tue, 13 Dec 2022 09:06:32 -0800 (PST) X-Google-Smtp-Source: AA0mqf7i9JOhZVd2eCPpUUgiOdhPC7g/xG/ZubbLcf6a+adt8752U7z17yxuhWsw1tnq9jxj/jcy X-Received: by 2002:a17:90a:d984:b0:219:6619:848a with SMTP id d4-20020a17090ad98400b002196619848amr21650289pjv.36.1670951191698; Tue, 13 Dec 2022 09:06:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670951191; cv=none; d=google.com; s=arc-20160816; b=EcIbqFB4XIu8Ot1l+d3yxQeZhzoXpviFvnlkdI76yDsTremhGPkKjeR9QI9X43xMCu Qv2SNIND5ZZS930TRuFf0kLvn34WujcIA2Ktig2S7EFIh+xuco6odW8t2DnJJLSCAJCg 6jbCZJ69eCSP2j4GbNnaMXR7d+47EUPGZw3DuGVXRt/rTwz49Z8HdQJ9MQr7AOVKLKxN wfh0hlDMhcOAywir5M6+JIRKHfVh19a2fj+MO3zzKEqcShRXFsAB8uRp9kPxXSM8kg6h 0mpJvFk7XuUnGkgJS9cC9UgvTafAkibjzSd8jmQSCI1szJ4lcyAfEofcBV3v2/SI/7jc bkgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=9whwM05lxda1ZLYL23P+3imYfDYTBHNqamA4JNSFNFI=; b=Yq62GWxQ4i+13cz9hnO5u/1y9TLqnlTY2+aIxgLzEV1e8oji7jP5fz+cVH43f7qwrT eMg0j/wagKewYxFJIR+iuWLvQKI3sR7I4E9ryQ2b098nmrsGCxzK1pQfs3AcEtX4dS2B bCUzauu2LKWyUH1yG1Lt3vF2aOKGViBsSyklCdTQfIiteaFfW/KWk4AFSqF6wxwiRGs9 wVXShRPYYMuQSxLVqV2bwIKJJLekuKX24u58/6QTBLG4DsIoXHlSEf83KMJqWSuYa+sE iUFnwesdfLixWIZiEhgg26zZyzRkhfreG0k+R45AiPVBb/QBbNoQoluTwWBKfBoGwzln XJcQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=denNa49m; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id md13-20020a17090b23cd00b001f31da6b2d2si12388813pjb.154.2022.12.13.09.06.17; Tue, 13 Dec 2022 09:06:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=denNa49m; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236211AbiLMREo (ORCPT + 99 others); Tue, 13 Dec 2022 12:04:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236209AbiLMRDy (ORCPT ); Tue, 13 Dec 2022 12:03:54 -0500 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B05409C for ; Tue, 13 Dec 2022 09:03:53 -0800 (PST) Received: by mail-lf1-x129.google.com with SMTP id z26so5943862lfu.8 for ; Tue, 13 Dec 2022 09:03:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=9whwM05lxda1ZLYL23P+3imYfDYTBHNqamA4JNSFNFI=; b=denNa49m9X7502D9PP+mm3zEdhaFEkwFeb0OqDobKmiEJhPtkRw8O0sKZ2/3c7ocEq WwxlbFZafpNNrugpEnnjtsKX8GYHp6Zs6uBAQi7Qf2jEl5Vm8prDP1mUSUOL/cqfQiHo 0pZTN8lZscPgYcsvZvB05nVyUJl3SoY29FeiwMQAA3UE8LNMoyLaZhBNhWFAU/x3loe2 FXTK9w5ofKoZ1Mjz1BP/8rk6W4XLRNS5CvE/AfZFv39e/CGddqZBsP6mI3wq4KNwWlDJ D8oQDDldNe53tN2GLwxY+GCjiv+5VMVwhlP0XSMOy5Udrm7avwL+2MMBBeGUNwTlsTu0 re9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9whwM05lxda1ZLYL23P+3imYfDYTBHNqamA4JNSFNFI=; b=SGae/olAMO2IyZyORKNHHF/Zybd3LlfiLvp0OK3Z+WWlUFKMunLcqQGA1HL0MzRjVW TnTykQmAnP05qORV4z1aIotXmcjQ8jAtaWQeGDGBpoZu0D1n1bsZOAGWICpHE+3WcJ5n OKBn9LomtJONpfNOdWqKle7zAoIN654LQpvg6x3csz1+lVF99Q62vaMPKhkcbmq1mcoH d8LDZZEd/CEMFTKuBCcbWhaU2Lgi+M3synHYR7iCW8shnSLNLNJJkqLF/dcHLCdAv29p 28WAdI0xlMKW1poMVSVGZUaOACsbF7Pr4OkXnTcHI/OWoqGr7UQV7tzEJzmWZz9rLku0 EsJg== X-Gm-Message-State: ANoB5pmGWjCOsKmXatOMwdRkkALdLz1aJ5iKVXOnXxV4BlNV0EWiywkT OTECa7PagWzcriEiDqu/qzeU+Q== X-Received: by 2002:a05:6512:1512:b0:4b6:f647:a98f with SMTP id bq18-20020a056512151200b004b6f647a98fmr1381190lfb.62.1670951032070; Tue, 13 Dec 2022 09:03:52 -0800 (PST) Received: from localhost.localdomain (abxh44.neoplus.adsl.tpnet.pl. [83.9.1.44]) by smtp.gmail.com with ESMTPSA id e2-20020a05651236c200b004b56bebdc4esm446874lfs.14.2022.12.13.09.03.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Dec 2022 09:03:51 -0800 (PST) From: Konrad Dybcio To: linux-arm-msm@vger.kernel.org, andersson@kernel.org, agross@kernel.org, krzysztof.kozlowski@linaro.org Cc: marijn.suijten@somainline.org, Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] dt-bindings: reserved-memory: rmtfs: Document qcom,assign-to-nav Date: Tue, 13 Dec 2022 18:03:39 +0100 Message-Id: <20221213170340.456252-1-konrad.dybcio@linaro.org> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752119316932265243?= X-GMAIL-MSGID: =?utf-8?q?1752119316932265243?= Some SoCs mandate that the RMTFS is also assigned to the NAV VM, while others really don't want that. Since it has to be conditional, add a bool property to toggle this behavior. Signed-off-by: Konrad Dybcio --- .../devicetree/bindings/reserved-memory/qcom,rmtfs-mem.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/reserved-memory/qcom,rmtfs-mem.yaml b/Documentation/devicetree/bindings/reserved-memory/qcom,rmtfs-mem.yaml index 2998f1c8f0db..1d8c4621178a 100644 --- a/Documentation/devicetree/bindings/reserved-memory/qcom,rmtfs-mem.yaml +++ b/Documentation/devicetree/bindings/reserved-memory/qcom,rmtfs-mem.yaml @@ -31,6 +31,11 @@ properties: description: > vmid of the remote processor, to set up memory protection + qcom,assign-to-nav: + type: boolean + description: > + whether to also assign the region to the NAV VM + required: - qcom,client-id From patchwork Tue Dec 13 17:03:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 32891 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp244655wrn; Tue, 13 Dec 2022 09:05:39 -0800 (PST) X-Google-Smtp-Source: AA0mqf6DX0uS5J4HzN/PJOfGaR7G3sZNfn4HHDVNn8M756aCyodnmA7uoHEL1axeqMMt6QyEmdkl X-Received: by 2002:a62:4e96:0:b0:574:1d8a:d4f with SMTP id c144-20020a624e96000000b005741d8a0d4fmr20541686pfb.16.1670951138833; Tue, 13 Dec 2022 09:05:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670951138; cv=none; d=google.com; s=arc-20160816; b=0HhjAQduZIl8U4wHPb6DFeEuXeg1ds6J4pWQw2Wx295AXuqU5cx/jjHLMr4aLneI5n QnJJ6/u4E8KYgufgNJQHR2bNGhZZMQCV37PnR30zFtou1L0roQyHCz7NaCaI5/D9OWsi kG93n1fLmYM86mS4ro9eWtj8Uoc322Csk8QHMT/3VQTY9LL2BhZ0QsGVnV9fZI5iSFeq mGTTzQJ39ZrgHOv4B2pGjA+Ptb7rH8Qs8YOeL1NKptdr1sY+tPvwBtbG+fsGL0+ZPzUq p/e7eVQPVjDnqRUxRVR2Xz2DM3vQ8g4tM5wTQOJ4KzhToAB088yJDpcXoMipjqLeHYkJ 8/LA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=szYuQKkpwRTzwOk3epQzQRwK6PcLRVEX0v7Brg6XO+E=; b=SpDDedC53+lmgGMCHLp5P0zVIqUPJlYRwX2yJBrz9qdDoKMeulLkCjN1YfeeEGpJha QrKWSMlkK7UL4m8uN+KrSs7oUt3xgLYIUcaGmOWOdDqRZ25YDSY6AENFvbL0Soh3Ljhd el6JAUboAQpIa+JewwqydFabrb3FeayGHeczt+Zeogyp8Plfyuvd5PwNYJca9s70xy+X /Y1xZVe59lTLl6AevWbBn46WE3J2x4pyyIJ9SLnp4KVBHTlGZAjc/tM4lsza2XLZGf+A mQu2i1dtqHHkjvk2gTHesXOnu7Cde3DmNJSHrVHHAPCa6zG22BH3h7QTLBSphZp/6NSX 0eZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gR54zbVL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bd33-20020a056a0027a100b0057834955b50si9591581pfb.180.2022.12.13.09.05.25; Tue, 13 Dec 2022 09:05:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gR54zbVL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236061AbiLMREj (ORCPT + 99 others); Tue, 13 Dec 2022 12:04:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236135AbiLMRD6 (ORCPT ); Tue, 13 Dec 2022 12:03:58 -0500 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F9302C7 for ; Tue, 13 Dec 2022 09:03:57 -0800 (PST) Received: by mail-lf1-x12d.google.com with SMTP id b13so5962426lfo.3 for ; Tue, 13 Dec 2022 09:03:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=szYuQKkpwRTzwOk3epQzQRwK6PcLRVEX0v7Brg6XO+E=; b=gR54zbVLpSNZRO/CMCTifP4zMaW+8m+2Ct3vOe68Recyk7nDqclNm34byp7Vpd9vXN nbOXn6Hb5kQ2uW0cXgIdSrlp6vYbFc1JEieGCg9bYhds8ywG3xybVLsTr+QYsGT6UX37 bzghylyIBP1EVkjELY4pGkb3MAs5ryRH0+zKRSVgWjWcwiQaiB2ts0NXboQ+jAg2M4Jb j8ZC7McM2A3Na9LBMP7vIwsjMCuc2H/WhP0sgCnQgvGZIW+d//U7HD289jiN1NUBCRdC tSpMyolVctBUnmEGa3DvQNDGuAbzA1v+Oe2067Us65o3fkyTlXSRNUQhikpIzlIsUQC3 LvMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=szYuQKkpwRTzwOk3epQzQRwK6PcLRVEX0v7Brg6XO+E=; b=m5xSt/aGtujVLQwbE3ES2Q+wTjTa4koMB3NWJ5ZvmzPGcDx19XFjF5cuTTk+LTHIk+ DDj0VlCo0yIshtrXRLZ5+79Ef+1oTIJxFwnpufAR60ncMp2RoldhjMYXfPdCiB31EbwO NpLnmDVaIXtjt42mmyhUY9UFFsHMHsApL3zwOaUQsmVM3yZsx5/Ma1whBjWXuLE74VLz TDmGWkVcslOqzOeJAkGt9SFLHzzGkzAAv/T2awpQDq8R+5RJAYYJkZ/DtEa6wElxlq07 6jor5299LwKS/gSb3nYwLez1E7H3n+/Dk1i9heSX9+1VZ2S2vS2HX4r1Yt8E3yUu7rF2 idBw== X-Gm-Message-State: ANoB5plBzxFhtCtD6gJQKoxqixGwPBlzj8E8rwa8WmnnFy/qpmRCk1YT vpDWDDAHB5sZ5Dcc0vJqnPeF+w== X-Received: by 2002:a05:6512:1115:b0:4b5:b7ba:cae with SMTP id l21-20020a056512111500b004b5b7ba0caemr4116987lfg.48.1670951035718; Tue, 13 Dec 2022 09:03:55 -0800 (PST) Received: from localhost.localdomain (abxh44.neoplus.adsl.tpnet.pl. [83.9.1.44]) by smtp.gmail.com with ESMTPSA id e2-20020a05651236c200b004b56bebdc4esm446874lfs.14.2022.12.13.09.03.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Dec 2022 09:03:55 -0800 (PST) From: Konrad Dybcio To: linux-arm-msm@vger.kernel.org, andersson@kernel.org, agross@kernel.org, krzysztof.kozlowski@linaro.org Cc: marijn.suijten@somainline.org, Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Loic Poulain , AngeloGioacchino Del Regno , Stephan Gerhold Subject: [PATCH 2/2] soc: qcom: rmtfs: Optionally map RMTFS to NAV VM Date: Tue, 13 Dec 2022 18:03:40 +0100 Message-Id: <20221213170340.456252-2-konrad.dybcio@linaro.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20221213170340.456252-1-konrad.dybcio@linaro.org> References: <20221213170340.456252-1-konrad.dybcio@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752119261136881453?= X-GMAIL-MSGID: =?utf-8?q?1752119261136881453?= From: Loic Poulain Some SoCs require that RMTFS is also mapped to the NAV VM. Trying to power on the modem without that results in the whole platform crashing and forces a hard reboot within about 2 seconds. Signed-off-by: Loic Poulain [Konrad: reword, make conditional, add a define for NAV VMID] Signed-off-by: Konrad Dybcio --- drivers/soc/qcom/rmtfs_mem.c | 22 +++++++++++++++------- include/linux/qcom_scm.h | 1 + 2 files changed, 16 insertions(+), 7 deletions(-) diff --git a/drivers/soc/qcom/rmtfs_mem.c b/drivers/soc/qcom/rmtfs_mem.c index 0feaae357821..999f2c5b49b0 100644 --- a/drivers/soc/qcom/rmtfs_mem.c +++ b/drivers/soc/qcom/rmtfs_mem.c @@ -171,12 +171,13 @@ static void qcom_rmtfs_mem_release_device(struct device *dev) static int qcom_rmtfs_mem_probe(struct platform_device *pdev) { struct device_node *node = pdev->dev.of_node; - struct qcom_scm_vmperm perms[2]; + struct qcom_scm_vmperm perms[3]; struct reserved_mem *rmem; struct qcom_rmtfs_mem *rmtfs_mem; + bool assign_to_nav; u32 client_id; u32 vmid; - int ret; + int ret, cnt = 0; rmem = of_reserved_mem_lookup(node); if (!rmem) { @@ -191,6 +192,8 @@ static int qcom_rmtfs_mem_probe(struct platform_device *pdev) } + assign_to_nav = of_property_read_bool(node, "qcom,assign-to-nav"); + rmtfs_mem = kzalloc(sizeof(*rmtfs_mem), GFP_KERNEL); if (!rmtfs_mem) return -ENOMEM; @@ -236,14 +239,19 @@ static int qcom_rmtfs_mem_probe(struct platform_device *pdev) goto remove_cdev; } - perms[0].vmid = QCOM_SCM_VMID_HLOS; - perms[0].perm = QCOM_SCM_PERM_RW; - perms[1].vmid = vmid; - perms[1].perm = QCOM_SCM_PERM_RW; + perms[cnt].vmid = QCOM_SCM_VMID_HLOS; + perms[cnt++].perm = QCOM_SCM_PERM_RW; + perms[cnt].vmid = vmid; + perms[cnt++].perm = QCOM_SCM_PERM_RW; + + if (assign_to_nav) { + perms[cnt].vmid = QCOM_SCM_VMID_NAV; + perms[cnt++].perm = QCOM_SCM_PERM_RW; + } rmtfs_mem->perms = BIT(QCOM_SCM_VMID_HLOS); ret = qcom_scm_assign_mem(rmtfs_mem->addr, rmtfs_mem->size, - &rmtfs_mem->perms, perms, 2); + &rmtfs_mem->perms, perms, cnt); if (ret < 0) { dev_err(&pdev->dev, "assign memory failed\n"); goto remove_cdev; diff --git a/include/linux/qcom_scm.h b/include/linux/qcom_scm.h index f8335644a01a..150b72edb879 100644 --- a/include/linux/qcom_scm.h +++ b/include/linux/qcom_scm.h @@ -55,6 +55,7 @@ enum qcom_scm_ice_cipher { #define QCOM_SCM_VMID_MSS_MSA 0xF #define QCOM_SCM_VMID_WLAN 0x18 #define QCOM_SCM_VMID_WLAN_CE 0x19 +#define QCOM_SCM_VMID_NAV 0x2B #define QCOM_SCM_PERM_READ 0x4 #define QCOM_SCM_PERM_WRITE 0x2 #define QCOM_SCM_PERM_EXEC 0x1