From patchwork Tue Dec 13 04:07:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Golle X-Patchwork-Id: 32622 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2621878wrr; Mon, 12 Dec 2022 20:13:20 -0800 (PST) X-Google-Smtp-Source: AA0mqf5bXCLusoTgSkiie2zXZkFxq5Hy1G2v3PjmwpTJR5ht3k18og2pS3MR36hzGlWMxW2bqd5A X-Received: by 2002:a05:6402:3215:b0:470:362f:6ba9 with SMTP id g21-20020a056402321500b00470362f6ba9mr296528eda.41.1670904800131; Mon, 12 Dec 2022 20:13:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670904800; cv=none; d=google.com; s=arc-20160816; b=Wgi2IzjaLdxHnyMYZPDn06EaNqpgwYm+LwoZKLg3m8Q6GvA60KZ63+pdmck/+ybrjr cqcWM90nkum41F1FCqjCG7zoeaA/eyhrBlDvs9xQ3yXK4NFE1UmpXqtyQCa89pRS0fTt iSxNiSeHl0mSSN6QXwSAofQdVEY2F7FiNnK6yh51Segz6rOTjkdCholaTwccIeZas1pH r27h7AhwSOl/c++3lLLGfQoyE4uiD5FaMW98HtYRCtpDfSLqJsk226/lsKQps/jm8qxK uiQgsGZky7i4KUuASTF1NDmvjOVOG8ilB0cflFCSP6pa1KR5e+bwQ57ov9P2uzHE5xlw 3vMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date; bh=2QjV0OzaXewluvRV60JQ8aCzEswAOLfGSwPlQZNEryk=; b=bSl8nHM2Fxd4goK6MbTrFn6UORV2RFFEVzw8w5kogyOTGe0GlQAAMGPrQdoBMYvu8G VChhgVymuMlzQleRsKtOo2PMOdUqLMWn/uRrXULt+CdDQaI9g6a6/Zd6YO1X3jx0jZ+9 z/W8vf3zxn4XwanPuvEjiRgiXscRrjnN6yTCbaOoPcNP4xLpq95bNs5j8fP7wvnFPRYi Cvv9h/+AF4J9HotHM8Y9FyDVaYixFlQBTnmR6MC5NZlFj7SY5GAfEZme6MCNDB1xjS6B qM0URY3VQbEtUVZxohMyYDbxyoyH3cfux1YAeqW6AN4k9sL98tHtEHvetXSDYejS2Duf D72w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g27-20020a50d5db000000b0046b2b37ff70si8406804edj.631.2022.12.12.20.12.56; Mon, 12 Dec 2022 20:13:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233964AbiLMEIA (ORCPT + 99 others); Mon, 12 Dec 2022 23:08:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232336AbiLMEH4 (ORCPT ); Mon, 12 Dec 2022 23:07:56 -0500 Received: from fudo.makrotopia.org (fudo.makrotopia.org [IPv6:2a07:2ec0:3002::71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 354AB164BE; Mon, 12 Dec 2022 20:07:52 -0800 (PST) Received: from local by fudo.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.94.2) (envelope-from ) id 1p4wZz-0008NT-46; Tue, 13 Dec 2022 05:07:43 +0100 Date: Tue, 13 Dec 2022 04:07:35 +0000 From: Daniel Golle To: Russell King , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Sean Wang , Landen Chao , DENG Qingfang , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger Subject: [PATCH net-next] net: dsa: mt7530: remove reduntant assignment Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752070671538928276?= X-GMAIL-MSGID: =?utf-8?q?1752070671538928276?= Russell King correctly pointed out that the MAC_2500FD capability is already added for port 5 (if not in RGMII mode) and port 6 (which only supports SGMII) by mt7531_mac_port_get_caps. Remove the reduntant setting of this capability flag which was added by a previous commit. Fixes: e19de30d20 ("net: dsa: mt7530: add support for in-band link status") Reported-by: Russell King Signed-off-by: Daniel Golle Reviewed-by: Russell King (Oracle) --- drivers/net/dsa/mt7530.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c index e74c6b406172..908fa89444c9 100644 --- a/drivers/net/dsa/mt7530.c +++ b/drivers/net/dsa/mt7530.c @@ -2919,9 +2919,6 @@ static void mt753x_phylink_get_caps(struct dsa_switch *ds, int port, config->mac_capabilities = MAC_ASYM_PAUSE | MAC_SYM_PAUSE | MAC_10 | MAC_100 | MAC_1000FD; - if ((priv->id == ID_MT7531) && mt753x_is_mac_port(port)) - config->mac_capabilities |= MAC_2500FD; - /* This driver does not make use of the speed, duplex, pause or the * advertisement in its mac_config, so it is safe to mark this driver * as non-legacy.