From patchwork Mon Dec 12 15:37:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Seth Forshee (DigitalOcean)" X-Patchwork-Id: 32426 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2312098wrr; Mon, 12 Dec 2022 07:40:14 -0800 (PST) X-Google-Smtp-Source: AA0mqf775qEmAI3GL9Z6pkUbLnfaxXsBb3dAcPH0FvvIcn4w08EFbTS2BS8aX9qxGN/RD3Pb8fV5 X-Received: by 2002:a05:6402:5389:b0:461:5e1b:85b5 with SMTP id ew9-20020a056402538900b004615e1b85b5mr13378812edb.2.1670859614656; Mon, 12 Dec 2022 07:40:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670859614; cv=none; d=google.com; s=arc-20160816; b=wuoE7Cl9czZEjWW01MI3UwVcCoUHG2Zi89n/Nl7YPcJL6ac2/lwu1E4Ba2Yl/ciXCh wsWiBWp2cRRB4WesKL7zenVcvk54K9WZH9WWi010II+SCc7x0OD8iwTKqAGBAiks/P/C 1ZT8fmU9vu2zJVdtlVC0BYzMFXcI6Cf6pBilBJvktJXtgzwD5dkoT+yMXsBZh9lb/wu3 FQNmp0EzdrAVLiD5MreXe9Sf/PubUuI/njv+dnBTe8LwfPKQjaF630dvSU2UT3tXZvrH L6zId3WohCQzp2z9GWhWQfnyZjz6ZqHfr3SqWmY+yKKPHuaCS+vrPYiyy8kf97r3hvjO jmwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:dkim-signature; bh=2++pOegC58wf03E7MgRZSp/Od57ZeMFhNvdYJGOvbC8=; b=B1hz9vnsd9un7qFZ46yv+MGV2gK65MPw/v/6eOKnnh3BMfMsXhQCV9No/JllIM09P5 LYf3b29dgYaz/GGMQjh2YzytWkqrePIeciU2PbbgvqbMoi6le3vFduTefCexHo0hwpsV xg1lcvFNCAPz+S16ICyuePaV35MCOYBIJ0NN90fW85/G2JdMR3xsLVZkdGLB5DITlu+A GrEWjy0eA1muOtw2QtkBGHvmpTAqgPZLxs4vIgEmleoZVUdL6NSsxeG3SvsKPO4i3hrb uh7l4x+UDShd2q/GOQePOFPR2xCm0lu+if0IQlah5doJog7JrOMQW1d1dzzCkbFGtS6n Vfyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YDsQ85XQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s22-20020a056402521600b00458c130870esi8483913edd.385.2022.12.12.07.39.49; Mon, 12 Dec 2022 07:40:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YDsQ85XQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232128AbiLLPhq (ORCPT + 99 others); Mon, 12 Dec 2022 10:37:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232537AbiLLPhe (ORCPT ); Mon, 12 Dec 2022 10:37:34 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79805FAF2; Mon, 12 Dec 2022 07:37:33 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 30D85B80D8C; Mon, 12 Dec 2022 15:37:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B95C3C433EF; Mon, 12 Dec 2022 15:37:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670859450; bh=bQjHMEaKvjiDu5gcF5ghATIIUpXsdMD8g72o/V7Njb0=; h=Date:From:To:Cc:Subject:From; b=YDsQ85XQB6Mr86XiBFCvmb6vUdAjUkakzRQCA9XfMOXg7a4utz20UPR51SasSNGed NwaevPxWWVxwjCL67L36THQvYsa/0yYB+Hix0Q+b8OP03TbAb4zTUynEaHk0kXzRf3 D0hWY2LFzWYPG1MaDclrZUNNYb30gw5bhvg/UoY8ZlFg1bYRB82UtZ1wnJsMPo4MIT FfG3TQJjsLemi4OQhxMmGx7/IVX6/4HBcV9/fid6EB/y7S9yfa2qnydGJHlJxEWk5p kFHQ/IG+KiQ3I2Jor6Nngq07xYXYFwOl1GTsoPDo0oVrXEDc1QCnSYBOIAUjdHbUFZ i2w8kvxE6+BPg== Date: Mon, 12 Dec 2022 09:37:29 -0600 From: Seth Forshee To: Linus Torvalds Cc: Christian Brauner , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [GIT PULL] xattr audit fix for v6.2 Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752023291071747958?= X-GMAIL-MSGID: =?utf-8?q?1752023291071747958?= Hi Linus, /* Summary */ This is a single patch to remove auditing of the capability check in simple_xattr_list(). This check is done to check whether trusted xattrs should be included by listxattr(2). SELinux will normally log a denial when capable() is called and the task's SELinux context doesn't have the corresponding capability permission allowed, which can end up spamming the log. Since a failed check here cannot be used to infer malicious intent, auditing is of no real value, and it makes sense to stop auditing the capability check. /* Testing */ The patch is based off of 6.1-rc4 and has been sitting in linux-next. No build failures or warnings were observed and fstests, selftests, and LTP show no regressions. /* Conflicts */ At the time of creating this PR no merge conflicts were reported from linux-next. A test merge with current mainline also showed no conflicts. The following changes since commit f0c4d9fc9cc9462659728d168387191387e903cc: Linux 6.1-rc4 (2022-11-06 15:07:11 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/vfs/idmapping.git tags/fs.xattr.simple.noaudit.v6.2 for you to fetch changes up to e7eda157c4071cd1e69f4b1687b0fbe1ae5e6f46: fs: don't audit the capability check in simple_xattr_list() (2022-11-07 16:55:45 +0100) Please consider pulling these changes from the signed fs.xattr.simple.noaudit.v6.2. Thanks! Seth ---------------------------------------------------------------- fs.xattr.simple.noaudit.v6.2 ---------------------------------------------------------------- Ondrej Mosnacek (1): fs: don't audit the capability check in simple_xattr_list() fs/xattr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)