From patchwork Sun Jul 24 15:04:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Li, Pan2 via Gcc-patches" X-Patchwork-Id: 144 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:6a10:b5d6:b0:2b9:3548:2db5 with SMTP id v22csp1225893pxt; Sun, 24 Jul 2022 08:06:02 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tU5SRpaYU+BpWaUAnv+t2MznWdazBRjcVN7Osh2TtSvHwRQVDrx1YVUHH+UYrDWjQKEnyT X-Received: by 2002:a17:907:3d86:b0:72b:4b25:1031 with SMTP id he6-20020a1709073d8600b0072b4b251031mr6663492ejc.536.1658675162090; Sun, 24 Jul 2022 08:06:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658675162; cv=none; d=google.com; s=arc-20160816; b=c25W7zL1GZ32QFcQQvKTriX679U8QGW+oOUviDcAqjOSvLg97+PfVmj8aoK2D5xnzD iK7NjWq60dqmsMBmpIhl715v7a4bTGTVd+UFiYr++5XyrgQ80LIeCF6J7Z4zPbbvrEsC /+YS8uHNs4bAGd3ggk5TBGTysiMWXlPReQ0XXe14ZaAUY5krt5XIdt1SX7x2yRY17So0 qK0Tits6oIAPHK/9a05rer19UaRirmrckcqMXwJ/w4ONs+b1XWninLZ3B5w/tEm1tmJ3 BHtXzhAhGghLeJk9vaQCSL3qYRR9f8WI+adKq/1nnlGW78/44+Bc7z58k1t08XbJs+5K mN4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:dmarc-filter:delivered-to:dkim-signature :dkim-filter; bh=pJAGbHzeGE4jfn4E9e47ktODgvChK0MruxePydMsglU=; b=uUDefYPLGjXGt7Q+nrhQINv5jhc//OmhyhYvo9qtg+W1tFSmYkgt/wghpLNSJ9zQCn v6bC0pp/l2mfIFsfNeG0rmx+5Sag9cx0lG84UW4kENbDYYNBluCfxXBuSpol5BdfeaU3 zEigkpXvXg62XHS7hHrVQSi9clohuT45Fgee67YlsqzzJx8S6xkA75NxuJ9zUDZSxeOA wujzuJxVU5apI8UmrTntZfkhoHhT8vC6DpMf92ZoZ9Ye3jFPEdxd1rsLwpZQ+GO7ZjFW nYipvXIDDJsqVWZaV9kUm+EEocfZn+2NIYMZ3GDlzWUECCdzG4L7Fe02ge3tB8pC913q FQ+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=N6caWEsH; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id go12-20020a1709070d8c00b0071216d32d8dsi13792488ejc.673.2022.07.24.08.06.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Jul 2022 08:06:02 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=N6caWEsH; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DEF1E3854142 for ; Sun, 24 Jul 2022 15:05:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DEF1E3854142 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1658675123; bh=pJAGbHzeGE4jfn4E9e47ktODgvChK0MruxePydMsglU=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=N6caWEsHg1WnKVM57fpRWqx/S56fw+CcaRoayPYJ/KWMDse70cKurPBNv3+9GGgtT Fg+pr97WPoFg/Szp9D4G0w14aFj0fhH0c/KpShFH8XWXpA9raTjdEsFN8p6G/DuG2O gj9L1yi5oqCDLhK76GOecIbkcSomjwYavqD2iPmQ= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 047A03858428 for ; Sun, 24 Jul 2022 15:04:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 047A03858428 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-640-NCmQHvkiMzqxYTfIlVdgIg-1; Sun, 24 Jul 2022 11:04:39 -0400 X-MC-Unique: NCmQHvkiMzqxYTfIlVdgIg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2785A3804501 for ; Sun, 24 Jul 2022 15:04:39 +0000 (UTC) Received: from abulafia.quesejoda.com (unknown [10.39.192.85]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C0116141511F; Sun, 24 Jul 2022 15:04:38 +0000 (UTC) Received: from abulafia.quesejoda.com (localhost [127.0.0.1]) by abulafia.quesejoda.com (8.17.1/8.17.1) with ESMTPS id 26OF4bvs2010505 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Sun, 24 Jul 2022 17:04:37 +0200 Received: (from aldyh@localhost) by abulafia.quesejoda.com (8.17.1/8.17.1/Submit) id 26OF4bfi2010504; Sun, 24 Jul 2022 17:04:37 +0200 To: GCC patches Subject: [COMMITTED] Allow registering same SSA name relations in oracle. Date: Sun, 24 Jul 2022 17:04:29 +0200 Message-Id: <20220724150431.2010479-2-aldyh@redhat.com> In-Reply-To: <20220724150431.2010479-1-aldyh@redhat.com> References: <20220724150431.2010479-1-aldyh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Aldy Hernandez via Gcc-patches From: "Li, Pan2 via Gcc-patches" Reply-To: Aldy Hernandez Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1739246966566248371?= X-GMAIL-MSGID: =?utf-8?q?1739246966566248371?= Similarly to what we did for the relation oracle, but for the path oracle. This was found while working on frange, where we can test for x == x while checking for NANness. Tested on x86-64 Linux. gcc/ChangeLog: * value-relation.cc (value_relation::set_relation): Remove assert. (path_oracle::register_relation): Exit when trying to register same SSA name relations. --- gcc/value-relation.cc | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/gcc/value-relation.cc b/gcc/value-relation.cc index bd344253af3..a447021214f 100644 --- a/gcc/value-relation.cc +++ b/gcc/value-relation.cc @@ -667,8 +667,6 @@ private: inline void value_relation::set_relation (relation_kind r, tree n1, tree n2) { - gcc_checking_assert (SSA_NAME_VERSION (n1) != SSA_NAME_VERSION (n2) - || r == VREL_EQ); related = r; name1 = n1; name2 = n2; @@ -1449,6 +1447,11 @@ void path_oracle::register_relation (basic_block bb, relation_kind k, tree ssa1, tree ssa2) { + // If the 2 ssa_names are the same, do nothing. An equivalence is implied, + // and no other relation makes sense. + if (ssa1 == ssa2) + return; + if (dump_file && (dump_flags & TDF_DETAILS)) { value_relation vr (k, ssa1, ssa2);