From patchwork Mon Dec 12 01:38:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiufu Guo X-Patchwork-Id: 32224 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp1993475wrr; Sun, 11 Dec 2022 17:39:48 -0800 (PST) X-Google-Smtp-Source: AA0mqf7a2rqqo2iS30kwIxdoW11qVTSKe4rbUGcP4jb4fPQEEFJhqW1ejbrSLJ4LWVDoKbaOX9Gr X-Received: by 2002:a17:907:c716:b0:7c0:e7a7:50b with SMTP id ty22-20020a170907c71600b007c0e7a7050bmr12742236ejc.48.1670809188237; Sun, 11 Dec 2022 17:39:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670809188; cv=none; d=google.com; s=arc-20160816; b=sea1OkqUjewCG9fazZyDaKlecpGIIRbxLlN5hQ5gX5dpakm9PIbCPZE8D9ofHdmXJs Lv0WbyeuAWLByY39DDJ9CfYEQ8iqMdqj6etJMayjVI6BL+IKQlKdsxxIfGeaXlaCq8Nf QXtjZZMIDwJ9Q7X5twtsDRqR/8Q0+QYaQbt8ya6pbstc7qEc2Sp345wKRi49npj+nej0 wxNaBWePJF81h4FTUQZJhUzaJNrt7b0/URVg6Gx6R7bJ96qTax+FW/c8xSlSDFiwbWxT cGMOW+R/LYN0s25sHYzsgd+yRy6TMGZFdqdS4lVPlPnwGSVVe1WtVigdziBQkozxtADk 0V3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:mime-version :message-id:date:subject:cc:to:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=G+OJlydX3Kq8yaLY7TR6PGew9+PtJSHEt8Y+9MJ5gK4=; b=BoWPwM4t0yvXfUZkZeZ7HP3Ynm70XnnwPoAgXQIws1xlkCzBeIzt0zHBGJlYH9xk4J kHHyZqQGGsl97Hk2LLw/IpsE2IdErKaDcOeEnmwq67XKSz6VAVvthkaMTA+aHvbef9Jc 6VHNSJV1ld2e9jvP4Iq+O2zQDY9gpG+jEEXikq/ifUyo0mmKBgkl68+DUbldZogz0L7h HG2AH0LM58XAAMo+AF8KvSrofiJc3jfNXwqsV5oNLzNbsbKTiAMerR6P5BG3YJL3Sv47 j8UidjQZI4irb2k80QA4DXm7yCca0Nl81GXeznM8VAX3Z/xbrUPPcoXHB7j3ejEmw4DP 3o3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=XfUW1GYB; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id i5-20020a1709064fc500b007c1727f7c57si779886ejw.243.2022.12.11.17.39.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Dec 2022 17:39:48 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=XfUW1GYB; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0E6E73887CED for ; Mon, 12 Dec 2022 01:39:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0E6E73887CED DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1670809161; bh=G+OJlydX3Kq8yaLY7TR6PGew9+PtJSHEt8Y+9MJ5gK4=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=XfUW1GYBQgTPVJpr5bJ6dGzIZxf7wYgF095k4YhWthSJ/aVGlcZy+WccAeW7M8iNc G27wyL3d+CD72xOg8o0uU1Y50kybhBSbTsf9zd1Psm3L8/oTyrqYvbADsH1LgHBT9x uo+r+B2zmZRoN3yrfpsYH8G3waDzKkYoUa5E4NaQ= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 87195383B695; Mon, 12 Dec 2022 01:38:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 87195383B695 Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2BC1QImu009909; Mon, 12 Dec 2022 01:38:36 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3md3y73n6r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 12 Dec 2022 01:38:35 +0000 Received: from m0098421.ppops.net (m0098421.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 2BC1cMae014228; Mon, 12 Dec 2022 01:38:35 GMT Received: from ppma02fra.de.ibm.com (47.49.7a9f.ip4.static.sl-reverse.com [159.122.73.71]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3md3y73n67-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 12 Dec 2022 01:38:35 +0000 Received: from pps.filterd (ppma02fra.de.ibm.com [127.0.0.1]) by ppma02fra.de.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 2BBIViXH000725; Mon, 12 Dec 2022 01:38:33 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma02fra.de.ibm.com (PPS) with ESMTPS id 3mchr61cxk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 12 Dec 2022 01:38:33 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2BC1cVTj37421372 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 12 Dec 2022 01:38:31 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1A5A120043; Mon, 12 Dec 2022 01:38:31 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 07D4120040; Mon, 12 Dec 2022 01:38:30 +0000 (GMT) Received: from pike.rch.stglabs.ibm.com (unknown [9.5.12.127]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 12 Dec 2022 01:38:29 +0000 (GMT) To: gcc-patches@gcc.gnu.org Cc: segher@kernel.crashing.org, dje.gcc@gmail.com, linkw@gcc.gnu.org, guojiufu@linux.ibm.com Subject: [PATCH V4 1/2] rs6000: use li;x?oris to build constant Date: Mon, 12 Dec 2022 09:38:28 +0800 Message-Id: <20221212013829.111739-1-guojiufu@linux.ibm.com> X-Mailer: git-send-email 2.17.1 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: -L_bpyrIYJStd93oyH6xkWX0PTuC2YUL X-Proofpoint-ORIG-GUID: UE6UkGS3cDzJZWWqnM4snMJADY0Tt2tM X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-10_10,2022-12-08_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 mlxscore=0 malwarescore=0 spamscore=0 impostorscore=0 phishscore=0 mlxlogscore=999 adultscore=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2212120013 X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jiufu Guo via Gcc-patches From: Jiufu Guo Reply-To: Jiufu Guo Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751970414967622275?= X-GMAIL-MSGID: =?utf-8?q?1751970414967622275?= Hi, For constant C: If '(c & 0xFFFFFFFF00008000ULL) == 0xFFFFFFFF00008000ULL' or say: 32(1) || 16(x) || 1(1) || 15(x), using "li; xoris" would be ok. If '(c & 0xFFFFFFFF80008000ULL) == 0x80000000ULL' or say: 32(0) || 1(1) || 15(x) || 1(0) || 15(x), we could use "li; oris" to build constant 'C'. Here N(M) means N continuous bit M, x for M means it is ok for either 1 or 0; '||' means concatenation. This patch update rs6000_emit_set_long_const to support those constants. Compare with previous version, this patch fixes conflicts with trunk. and put li;x?oris as the first patch (lis;xoris as the second patch). Previous version: https://gcc.gnu.org/pipermail/gcc-patches/2022-December/607618.html Bootstrap and regtest pass on ppc64{,le}. Is this ok for trunk? BR, Jeff (Jiufu) PR target/106708 gcc/ChangeLog: * config/rs6000/rs6000.cc (rs6000_emit_set_long_const): Add using "li; x?oris" to build constant. gcc/testsuite/ChangeLog: * gcc.target/powerpc/pr106708.c: New test. --- gcc/config/rs6000/rs6000.cc | 36 +++++++++++++++--- gcc/testsuite/gcc.target/powerpc/pr106708.c | 41 +++++++++++++++++++++ 2 files changed, 71 insertions(+), 6 deletions(-) create mode 100644 gcc/testsuite/gcc.target/powerpc/pr106708.c diff --git a/gcc/config/rs6000/rs6000.cc b/gcc/config/rs6000/rs6000.cc index b3a609f3aa3..8c1192a10c8 100644 --- a/gcc/config/rs6000/rs6000.cc +++ b/gcc/config/rs6000/rs6000.cc @@ -10251,17 +10251,41 @@ rs6000_emit_set_long_const (rtx dest, HOST_WIDE_INT c) if (ud1 != 0) emit_move_insn (dest, gen_rtx_IOR (DImode, temp, GEN_INT (ud1))); } + else if (ud4 == 0xffff && ud3 == 0xffff && (ud1 & 0x8000)) + { + /* li; xoris */ + temp = !can_create_pseudo_p () ? dest : gen_reg_rtx (DImode); + emit_move_insn (temp, GEN_INT (sext_hwi (ud1, 16))); + emit_move_insn (dest, gen_rtx_XOR (DImode, temp, + GEN_INT ((ud2 ^ 0xffff) << 16))); + } else if (ud3 == 0 && ud4 == 0) { temp = !can_create_pseudo_p () ? dest : gen_reg_rtx (DImode); gcc_assert (ud2 & 0x8000); - emit_move_insn (temp, GEN_INT (sext_hwi (ud2 << 16, 32))); - if (ud1 != 0) - emit_move_insn (temp, gen_rtx_IOR (DImode, temp, GEN_INT (ud1))); - emit_move_insn (dest, - gen_rtx_ZERO_EXTEND (DImode, - gen_lowpart (SImode,temp))); + + if (ud1 == 0) + { + /* lis; rldicl */ + emit_move_insn (temp, GEN_INT (sext_hwi (ud2 << 16, 32))); + emit_move_insn (dest, + gen_rtx_AND (DImode, temp, GEN_INT (0xffffffff))); + } + else if (!(ud1 & 0x8000)) + { + /* li; oris */ + emit_move_insn (temp, GEN_INT (ud1)); + emit_move_insn (dest, + gen_rtx_IOR (DImode, temp, GEN_INT (ud2 << 16))); + } + else + { + emit_move_insn (temp, GEN_INT (sext_hwi (ud2 << 16, 32))); + emit_move_insn (temp, gen_rtx_IOR (DImode, temp, GEN_INT (ud1))); + emit_move_insn (dest, + gen_rtx_AND (DImode, temp, GEN_INT (0xffffffff))); + } } else if (ud1 == ud3 && ud2 == ud4) { diff --git a/gcc/testsuite/gcc.target/powerpc/pr106708.c b/gcc/testsuite/gcc.target/powerpc/pr106708.c new file mode 100644 index 00000000000..dc9ceda8367 --- /dev/null +++ b/gcc/testsuite/gcc.target/powerpc/pr106708.c @@ -0,0 +1,41 @@ +/* PR target/106708 */ +/* { dg-do run } */ +/* { dg-options "-O2 -mno-prefixed -save-temps" } */ +/* { dg-require-effective-target has_arch_ppc64 } */ + +long long arr[] + = {0xffffffff7cdeab55LL, 0x98765432LL, 0xabcd0000LL}; + +void __attribute__ ((__noipa__)) lixoris (long long *arg) +{ + *arg = 0xffffffff7cdeab55LL; +} +/* { dg-final { scan-assembler-times {\mli .*,-21675\M} 1 } } */ +/* { dg-final { scan-assembler-times {\mxoris .*0x8321\M} 1 } } */ + +void __attribute__ ((__noipa__)) lioris (long long *arg) +{ + *arg = 0x98765432LL; +} +/* { dg-final { scan-assembler-times {\mli .*,21554\M} 1 } } */ +/* { dg-final { scan-assembler-times {\moris .*0x9876\M} 1 } } */ + +void __attribute__ ((__noipa__)) lisrldicl (long long *arg) +{ + *arg = 0xabcd0000LL; +} +/* { dg-final { scan-assembler-times {\mlis .*,0xabcd\M} 1 } } */ +/* { dg-final { scan-assembler-times {\mrldicl .*,0,32\M} 1 } } */ + +int +main () +{ + long long a[sizeof (arr) / sizeof (arr[0])]; + + lixoris (a); + lioris (a + 1); + lisrldicl (a + 2); + if (__builtin_memcmp (a, arr, sizeof (arr)) != 0) + __builtin_abort (); + return 0; +} From patchwork Mon Dec 12 01:38:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiufu Guo X-Patchwork-Id: 32225 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp1993488wrr; Sun, 11 Dec 2022 17:39:49 -0800 (PST) X-Google-Smtp-Source: AA0mqf6JVrIsNCNbaaBnq0upbAgzdTy2kh8wEjHqOXj4d6WPt6R3jCcG8TKxxgy5LMMOHQLcNHkB X-Received: by 2002:a17:906:1356:b0:7c0:f216:cc14 with SMTP id x22-20020a170906135600b007c0f216cc14mr11944972ejb.11.1670809189641; Sun, 11 Dec 2022 17:39:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670809189; cv=none; d=google.com; s=arc-20160816; b=iS2DXhsMNnseWBpCY6HRhzpneDcDGzPX8poy39E8QmRjM5NoLiZ2VVagwe9gALREbl PDk1y5btJ1Hr7EgLAO2muO8p5UNAvnzYTE9Rkf1h0XnnnekMObl/rw33A4tv5zwklR4E nK5e0BnDFbb0Xx9SUAVNZ283mDuJ8UQJPemDlUbjKqP1/UIlYTNZyHqp+t33nKPNWn+q JZwwYGI1QwCAJLwfpjVqx7Vx8S/YmxPcDSe3IqC1I9z8u+dtN0RGBTqf3TRr3TVHDTyM fm1ErOIbppg0D8kRWEdl9GUS/tlEByc7bsf5626QwBJVaDC5za4mgKjnwjciDF3JqUdt z65g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:mime-version :references:in-reply-to:message-id:date:subject:cc:to:dmarc-filter :delivered-to:dkim-signature:dkim-filter; bh=nJ8VtuEbsozu4m/cB3cvpNZcw+tamSJEhTENCtGuMbo=; b=NLHHf1X11UOLR8SYEvP19j5OJuDjiELF/mvuF0WTxerKovSe5fFitp8MTiXerkCXQd VJgYJZnNy7WLHHE3bedGqlY/6ug/f6FI4eN7/hZFUe+ujsNhyqk1PKOmw1/ddPjaxKFs xemRvQFx6AtA+uZ+/+LJa6/+Bm+2EZ/zuY8bzZHrQZs1GrWbNfue43bRPdbzWbF99Iaz bfuS/viLTGJz6kWYK+BUr/XmLh3hUONkPiPp3rR8q2dzGtRO682Ech/dTXgvpe1JrfJ4 x5OaEmq1UV7u0PYuSsevEEYaht2BOcTkgous1RY6rZtu0OB14f7hocGH2oGLOCVDDvzv JNCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b="op8/uIU5"; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id nd39-20020a17090762a700b007adb388df38si5452942ejc.706.2022.12.11.17.39.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Dec 2022 17:39:49 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b="op8/uIU5"; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 56CBE3892B9D for ; Mon, 12 Dec 2022 01:39:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 56CBE3892B9D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1670809162; bh=nJ8VtuEbsozu4m/cB3cvpNZcw+tamSJEhTENCtGuMbo=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=op8/uIU5FikMgMaCpKrr+5GLdXe3snbLAHMXN2DlKDhIeSufT5FGzcd6zgUas4KRV YU+RWTuSiNZARj9gSpRTYrkpt61rouxHTt0ysNs8YGRY+z17K2ZZ/iE1XEOsd0M8vI oDOYtaDFrDIHcdQoBTGW2SwWmIvToJpZNIyYZSys= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 229953847580; Mon, 12 Dec 2022 01:38:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 229953847580 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2BBKCl4X017357; Mon, 12 Dec 2022 01:38:37 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3md491k9pf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 12 Dec 2022 01:38:37 +0000 Received: from m0098416.ppops.net (m0098416.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 2BC1cak2011242; Mon, 12 Dec 2022 01:38:36 GMT Received: from ppma02fra.de.ibm.com (47.49.7a9f.ip4.static.sl-reverse.com [159.122.73.71]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3md491k9p6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 12 Dec 2022 01:38:36 +0000 Received: from pps.filterd (ppma02fra.de.ibm.com [127.0.0.1]) by ppma02fra.de.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 2BB5v1sa004495; Mon, 12 Dec 2022 01:38:35 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma02fra.de.ibm.com (PPS) with ESMTPS id 3mchr61cxn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 12 Dec 2022 01:38:34 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2BC1cW3l40829412 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 12 Dec 2022 01:38:32 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7528C20043; Mon, 12 Dec 2022 01:38:32 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 62F3E20040; Mon, 12 Dec 2022 01:38:31 +0000 (GMT) Received: from pike.rch.stglabs.ibm.com (unknown [9.5.12.127]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 12 Dec 2022 01:38:31 +0000 (GMT) To: gcc-patches@gcc.gnu.org Cc: segher@kernel.crashing.org, dje.gcc@gmail.com, linkw@gcc.gnu.org, guojiufu@linux.ibm.com Subject: [PATCH V4 2/2] rs6000: use li;x?oris to build constant Date: Mon, 12 Dec 2022 09:38:29 +0800 Message-Id: <20221212013829.111739-2-guojiufu@linux.ibm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221212013829.111739-1-guojiufu@linux.ibm.com> References: <20221212013829.111739-1-guojiufu@linux.ibm.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: -XctY7sf4CY1ON_SaDtb5IWegpOWMgaO X-Proofpoint-GUID: mP6Hg-gmoxM-9gkdR9kVpa-dt0lm37Gs X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-10_10,2022-12-08_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 impostorscore=0 mlxlogscore=999 clxscore=1015 priorityscore=1501 malwarescore=0 bulkscore=0 adultscore=0 phishscore=0 spamscore=0 suspectscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2212120013 X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jiufu Guo via Gcc-patches From: Jiufu Guo Reply-To: Jiufu Guo Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751970414967622275?= X-GMAIL-MSGID: =?utf-8?q?1751970416977089958?= Hi, For constant C: If '(c & 0xFFFFFFFF0000FFFFULL) == 0xFFFFFFFF00000000' or say: 32(1) || 1(0) || 15(x) || 16(0), we could use "lis; xoris" to build. Here N(M) means N continuous bit M, x for M means it is ok for either 1 or 0; '||' means concatenation. This patch update rs6000_emit_set_long_const to support those constants. Compare with previous version: https://gcc.gnu.org/pipermail/gcc-patches/2022-December/607618.htm This patch fix conflicts with trunk. Bootstrap and regtest pass on ppc64{,le}. Is this ok for trunk? BR, Jeff (Jiufu) PR target/106708 gcc/ChangeLog: * config/rs6000/rs6000.cc (rs6000_emit_set_long_const): Add to build constants through "lis; xoris". gcc/testsuite/ChangeLog: * gcc.target/powerpc/pr106708.c: Add test function. --- gcc/config/rs6000/rs6000.cc | 7 +++++++ gcc/testsuite/gcc.target/powerpc/pr106708.c | 10 +++++++++- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/gcc/config/rs6000/rs6000.cc b/gcc/config/rs6000/rs6000.cc index 8c1192a10c8..1138d5e8cd4 100644 --- a/gcc/config/rs6000/rs6000.cc +++ b/gcc/config/rs6000/rs6000.cc @@ -10251,6 +10251,13 @@ rs6000_emit_set_long_const (rtx dest, HOST_WIDE_INT c) if (ud1 != 0) emit_move_insn (dest, gen_rtx_IOR (DImode, temp, GEN_INT (ud1))); } + else if (ud4 == 0xffff && ud3 == 0xffff && !(ud2 & 0x8000) && ud1 == 0) + { + /* lis; xoris */ + temp = !can_create_pseudo_p () ? dest : gen_reg_rtx (DImode); + emit_move_insn (temp, GEN_INT (sext_hwi ((ud2 | 0x8000) << 16, 32))); + emit_move_insn (dest, gen_rtx_XOR (DImode, temp, GEN_INT (0x80000000))); + } else if (ud4 == 0xffff && ud3 == 0xffff && (ud1 & 0x8000)) { /* li; xoris */ diff --git a/gcc/testsuite/gcc.target/powerpc/pr106708.c b/gcc/testsuite/gcc.target/powerpc/pr106708.c index dc9ceda8367..a015c71e630 100644 --- a/gcc/testsuite/gcc.target/powerpc/pr106708.c +++ b/gcc/testsuite/gcc.target/powerpc/pr106708.c @@ -4,7 +4,7 @@ /* { dg-require-effective-target has_arch_ppc64 } */ long long arr[] - = {0xffffffff7cdeab55LL, 0x98765432LL, 0xabcd0000LL}; += {0xffffffff7cdeab55LL, 0x98765432LL, 0xabcd0000LL, 0xffffffff65430000LL}; void __attribute__ ((__noipa__)) lixoris (long long *arg) { @@ -27,6 +27,13 @@ void __attribute__ ((__noipa__)) lisrldicl (long long *arg) /* { dg-final { scan-assembler-times {\mlis .*,0xabcd\M} 1 } } */ /* { dg-final { scan-assembler-times {\mrldicl .*,0,32\M} 1 } } */ +void __attribute__ ((__noipa__)) lisxoris (long long *arg) +{ + *arg = 0xffffffff65430000LL; +} +/* { dg-final { scan-assembler-times {\mlis .*,0xe543\M} 1 } } */ +/* { dg-final { scan-assembler-times {\mxoris .*0x8000\M} 1 } } */ + int main () { @@ -35,6 +42,7 @@ main () lixoris (a); lioris (a + 1); lisrldicl (a + 2); + lisxoris (a + 3); if (__builtin_memcmp (a, arr, sizeof (arr)) != 0) __builtin_abort (); return 0;