From patchwork Sat Dec 10 20:03:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 32091 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp1476940wrr; Sat, 10 Dec 2022 12:08:49 -0800 (PST) X-Google-Smtp-Source: AA0mqf5cHHyZrx90oYpfXPRP8yTW+NH/qypMCUpm2AwyDZIEI3wKIWmbHpvdKhGHLm6Nmtyvlyc2 X-Received: by 2002:a17:90b:3c0d:b0:219:10dd:a389 with SMTP id pb13-20020a17090b3c0d00b0021910dda389mr7777715pjb.31.1670702928860; Sat, 10 Dec 2022 12:08:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670702928; cv=none; d=google.com; s=arc-20160816; b=WvtaA19l2n7ZUMF47v8/Eg5gSADHBCnqayZTwEcfQP8eyQ8ZXRdtGeg2hAJObi+VBL r3H1nsPjqvBJrI9x7e8vruXdQ+jWhySmxWf6QHOqNGgwMDNbEB/9huMayf9sdQScfEd9 0+7J3ewY10LV1v/ls5WPjiuil5sT9JLbqCeRy2JF9WXdblwyncKf0S3vRHguXmVcimp9 aSXhT9SuGWGxF9B0L0TQ8xMglEXLDGSlvxR+bHx+yXCf9n+8m+vzmz8TudxvP3M2gSKN GYKMwhfvJdmL1wJrML/LbGNb0L6os1Y95tgJ4gwOfAyWr5Xd/9N47CgUY5XbrRYfwq8Y FITQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=OBRVlbrqRCLQh/hPYQMZj1j2VXHf/Xbb2WuXE+iQo4s=; b=YJbrZkDslyGNhFbjyZnd64PngPHtNK3zHNFqruRsUa4y+PQywGQqTbOUlj/n8vXp9w UgV8TuPswtXApIhQGL7jtx69SYkJOWSRU/ANO0AqMd3A05a7alrmcaW/pReOldHjCt0F LTOpC5MbHIJYDCVgUj3f3d8Yz+wr2FzobxUVXr1dR2xW8cNHO20a0VKQ9TaipQmofS4X u4W8Hc4rqvkrmH3gE7LHOz24CaNboKrE4k685LCC7Gt6Pkb07ufkR3YTz9n95tXXauXB f+AtRDIF5tGcJP4YtZj/PcHoLGY2tjG9lM606Hu5kr8X1gkCvWYswW46PwmiuJIRVYXV SgqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OVMoskt2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l11-20020a17090a598b00b00219738f4d3dsi5456755pji.136.2022.12.10.12.08.32; Sat, 10 Dec 2022 12:08:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OVMoskt2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229779AbiLJUEJ (ORCPT + 99 others); Sat, 10 Dec 2022 15:04:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229538AbiLJUEH (ORCPT ); Sat, 10 Dec 2022 15:04:07 -0500 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8AA8213F7E for ; Sat, 10 Dec 2022 12:04:06 -0800 (PST) Received: by mail-lf1-x132.google.com with SMTP id 1so12246763lfz.4 for ; Sat, 10 Dec 2022 12:04:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OBRVlbrqRCLQh/hPYQMZj1j2VXHf/Xbb2WuXE+iQo4s=; b=OVMoskt21DvWG921R245YlH5xYu83EndxKpsNu/6SOS9yo9CCQi3wHGEMVYI5vTed0 puCgJbz0X7tScfYkgR20KfO/Yf0tb6IPESJb0xLtaGV1h92nKfnLMVhZnMoTJn9JScJd QXPvZMXHQbdT0Im2MBVxm7UWsaov7Jg2ehM6yHAt+huRWeQTnBIOYyqaKGh9m5PI6zQ+ kmn/6S5tg/Y/CAcKgkab9HEuM6tdkeBm2ZP+VhshFUwNm+gZj+n3NivgcaJdcqihkLFx ihlptI/KB3kl6Ohr0MEeVUKX7ZRE7+KyI6OHmhK5mr9Ngd6UmjqYonEVx8qgbmJyyYFi RtSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OBRVlbrqRCLQh/hPYQMZj1j2VXHf/Xbb2WuXE+iQo4s=; b=Eyhitaa0PMExZe4N/CY4l88wuEetsJYdz2OOd48dPuY4MNpG6xFcBc+Q0S4pXl810K Eg0rvUDF41Mdm0QqY0868oIW+3HUPZJacNyPt0gt+HBiGbCt6qMmMVfoStO1FbZWU4+L aW8qZsar4BU7axVu8x8ZAlc2JALVn+/RUof9yvJV2knqYpdYjKYjtLXU/lix7cm7EsGj WFd9fk17fAZnBI5mt4+S9bYg1MG4TJ1fd4oWrllaDN8Xy8YdQGdWcd3EtMTTbCrMlTvr 6iDpLHWwTZOOecNfkekZpA/oiM8mDF4qbeqgMUv/vq9h12B9mToq32GfPiP9IkePNN8m nQXQ== X-Gm-Message-State: ANoB5pkU3yQItFBVpeilpgFIcZ0giRXrCdStKhKQe0QUqmWpVabmDQsv 6gHnUMwL8laeuioLFV1RaUhSJw== X-Received: by 2002:a05:6512:340c:b0:4b6:e22f:51a6 with SMTP id i12-20020a056512340c00b004b6e22f51a6mr529683lfr.53.1670702644949; Sat, 10 Dec 2022 12:04:04 -0800 (PST) Received: from localhost.localdomain (abxh44.neoplus.adsl.tpnet.pl. [83.9.1.44]) by smtp.gmail.com with ESMTPSA id h28-20020ac2597c000000b004b4f1ea713csm839628lfp.73.2022.12.10.12.04.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Dec 2022 12:04:04 -0800 (PST) From: Konrad Dybcio To: linux-arm-msm@vger.kernel.org, andersson@kernel.org, agross@kernel.org, krzysztof.kozlowski@linaro.org Cc: marijn.suijten@somainline.org, Konrad Dybcio , Georgi Djakov , Rob Herring , Krzysztof Kozlowski , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/5] dt-bindings: interconnect: Add UFS clocks to MSM8996 A2NoC Date: Sat, 10 Dec 2022 21:03:49 +0100 Message-Id: <20221210200353.418391-2-konrad.dybcio@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221210200353.418391-1-konrad.dybcio@linaro.org> References: <20221210200353.418391-1-konrad.dybcio@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751858993900717770?= X-GMAIL-MSGID: =?utf-8?q?1751858993900717770?= MSM8996 A2NoC contains a UFS master, which means the UFS hardware is accessed every time sync_state is called within the interconnect framework. It's all good on devices where this clock is already enabled (most likely from the bootloader), but devices with eMMC storage are rather unlikely to have it like that. Add the missing 2 clocks to the binding. Signed-off-by: Konrad Dybcio Acked-by: Krzysztof Kozlowski --- .../bindings/interconnect/qcom,rpm.yaml | 24 ++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml b/Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml index 4b37aa88a375..5e6be4e79201 100644 --- a/Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml +++ b/Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml @@ -84,7 +84,6 @@ allOf: - qcom,msm8939-pcnoc - qcom,msm8939-snoc - qcom,msm8996-a1noc - - qcom,msm8996-a2noc - qcom,msm8996-bimc - qcom,msm8996-cnoc - qcom,msm8996-pnoc @@ -186,6 +185,29 @@ allOf: required: - power-domains + - if: + properties: + compatible: + contains: + enum: + - qcom,msm8996-a2noc + + then: + properties: + clock-names: + items: + - const: bus + - const: bus_a + - const: aggre2_ufs_axi + - const: ufs_axi + + clocks: + items: + - description: Bus Clock + - description: Bus A Clock + - description: Aggregate2 NoC UFS AXI Clock + - description: UFS AXI Clock + - if: properties: compatible: From patchwork Sat Dec 10 20:03:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 32092 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp1478188wrr; Sat, 10 Dec 2022 12:12:38 -0800 (PST) X-Google-Smtp-Source: AA0mqf6q9tCUHRFmoaCGKJui1d0C1IwRtokk41nU5IeLNW61gFr7ArTDSra2Mhh6sxN5w2bLIMRf X-Received: by 2002:a17:906:4a56:b0:7c1:4a3:10b6 with SMTP id a22-20020a1709064a5600b007c104a310b6mr8928127ejv.53.1670703158121; Sat, 10 Dec 2022 12:12:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670703158; cv=none; d=google.com; s=arc-20160816; b=FVvEGkd8moDPWf02KqVxh4oYAOjsPtofsxH+8/wi3Z4fxWSyk7DHhCJ91N2OrPqbQZ A/UoDnjiHRKzkmHOMPrIQioT4WLOdS3YLN2nqbvuZcxbq2VM4lvgw7wGm/M6pTEZ321J aCgMujlkvL3+8+Q+XqMiEysP9XtolDezFT5z7WZSuCbQi2Lm9CIsAqBkpW8AZUjycOxr YScXCXgPRHhaXmvnGjYaLu0n8Yu13zWiLWSDGoTtxWHYHs7hBs1kvyUSYBXfcJHYq95m zUleVC18OxbUE55CSwGysWuBN6XoOuHbgOBSJWAfkemYBWgp6FJdgCkIOkqc6e2RAExG 5baQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=xDt+cVjkMFpQCr4WbA0njzIJ8/m0OvNyfOzyjmNYhSc=; b=c467ClikTAqBy5nXSpBva0f9o9QcDoTXUNZNiPOXWMHBQBoWSnDMYGGdhAyEx95LPs ncFstQKXe8Kfpijqa3WvQ/MHYhnn3I8bzWH0nfyrGrKP9xsyvv8YhSlQNXgNv/uSaxcf Spbz2aIJSyVWGXxahsL23JzWV0EKrECVuueaMI8T3J1T7bU4D6KBd/rEahdWLQGH/5g8 X0PtagBRaC0G5U2FuJnLc9BBxBpNqRjn8DPKX+uqxIuocax0DliXErHnYB+5fw9saqF4 EmvDbkHaaEixF84vvyG/LcBDqbGaBwibigfLmd/+9D2QXlOerzEMHUhV0BWUDeZ09Ybm t9jg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cbdwYWpT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ne12-20020a1709077b8c00b007c10ac7fe46si3095722ejc.19.2022.12.10.12.12.15; Sat, 10 Dec 2022 12:12:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cbdwYWpT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229934AbiLJUEU (ORCPT + 99 others); Sat, 10 Dec 2022 15:04:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229720AbiLJUEJ (ORCPT ); Sat, 10 Dec 2022 15:04:09 -0500 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D72A213F7E for ; Sat, 10 Dec 2022 12:04:08 -0800 (PST) Received: by mail-lf1-x132.google.com with SMTP id p8so12219151lfu.11 for ; Sat, 10 Dec 2022 12:04:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xDt+cVjkMFpQCr4WbA0njzIJ8/m0OvNyfOzyjmNYhSc=; b=cbdwYWpTVw/hWlTtSfZCil7N39WfC6Re7YQhOq8oVz4Wgsdfk1RJ+g/mY+MmANfWFM q4tzxHGHwDwr14gOPiMZ871Upc/blWpRVMZtOLHEpeo2h7lbqkl2tUwZepD/OB06f5dV k7cB8jMOMdh5pqEqmplIEYVWKCqTCUHTrOKfa2wwxIbvTKUO5R8TAhGf2shaMiG0wOZg OvybJUYi7HcIZUOE+qA0VVr+VwFf5Up49lY+4QyfSy/sWOet7OmynllwyYwtgSoUg3zx 6xubhTJmuQ7+Pj5OIrM0ar9FBGTMzBPLQtk31sp1HChXFvrM1qRl9pr2QaqXTmry9fuh fc+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xDt+cVjkMFpQCr4WbA0njzIJ8/m0OvNyfOzyjmNYhSc=; b=ZTWc8BmGMV1rMmdevawuTFEqJ3d4FG2AD+3iSDMD3sFWRFW88Y9c8AnNcQWhwBEuBs bPDmOq6ZcTah20ey64eBkYCfX1kDg85GIDNRg4a7TqYzvAKK5AytkDHM+K/3Yu5kCzHS N1rsJa2k7aRYmYD2Xwv20V/K9CH5IV+l/n754uho257XQBLC80H3ACsfRWapzq2Gvima mqk6nTw+6OWVID2d5RmEzO0V3AowVxs/f9TV/uWrYY+usO3RaOwY5vsyDvtQV68KwkP2 gF4AJ7D5gWYDJ4you9un/ytUeF7BorwPr2e9Eo3EqqOQ86Gw5oCnatzucMx8DrR2T0KE hJ/Q== X-Gm-Message-State: ANoB5pkbz5ZmSYQK/aj9ezYWbYhCSmjbLvNYGv+BUpCyfDzi0Hxervik 9a+IWT6bqqKxo8a7XL1tGu37TA== X-Received: by 2002:ac2:5a1d:0:b0:4a7:9e45:4cd0 with SMTP id q29-20020ac25a1d000000b004a79e454cd0mr2801113lfn.13.1670702647248; Sat, 10 Dec 2022 12:04:07 -0800 (PST) Received: from localhost.localdomain (abxh44.neoplus.adsl.tpnet.pl. [83.9.1.44]) by smtp.gmail.com with ESMTPSA id h28-20020ac2597c000000b004b4f1ea713csm839628lfp.73.2022.12.10.12.04.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Dec 2022 12:04:06 -0800 (PST) From: Konrad Dybcio To: linux-arm-msm@vger.kernel.org, andersson@kernel.org, agross@kernel.org, krzysztof.kozlowski@linaro.org Cc: marijn.suijten@somainline.org, Konrad Dybcio , Georgi Djakov , Yassine Oudjana , Dmitry Baryshkov , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/5] interconnect: qcom: msm8996: Provide UFS clocks to A2NoC Date: Sat, 10 Dec 2022 21:03:50 +0100 Message-Id: <20221210200353.418391-3-konrad.dybcio@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221210200353.418391-1-konrad.dybcio@linaro.org> References: <20221210200353.418391-1-konrad.dybcio@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751859234661966189?= X-GMAIL-MSGID: =?utf-8?q?1751859234661966189?= On eMMC devices the bootloader has no business enabling UFS clocks. That results in a platform hang and hard reboot when trying to vote on paths including MASTER_UFS and since sync_state guarantees that it's done at boot time, this effectively prevents such devices from booting. Fix that. Fixes: 7add937f5222 ("interconnect: qcom: Add MSM8996 interconnect provider driver") Signed-off-by: Konrad Dybcio Reviewed-by: Dmitry Baryshkov --- drivers/interconnect/qcom/msm8996.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/interconnect/qcom/msm8996.c b/drivers/interconnect/qcom/msm8996.c index c2903ae3b3bc..7ddb1f23fb2a 100644 --- a/drivers/interconnect/qcom/msm8996.c +++ b/drivers/interconnect/qcom/msm8996.c @@ -33,6 +33,13 @@ static const char * const bus_a0noc_clocks[] = { "aggre0_noc_mpu_cfg" }; +static const char * const bus_a2noc_clocks[] = { + "bus", + "bus_a", + "aggre2_ufs_axi", + "ufs_axi" +}; + static const u16 mas_a0noc_common_links[] = { MSM8996_SLAVE_A0NOC_SNOC }; @@ -1859,6 +1866,8 @@ static const struct qcom_icc_desc msm8996_a2noc = { .type = QCOM_ICC_NOC, .nodes = a2noc_nodes, .num_nodes = ARRAY_SIZE(a2noc_nodes), + .clocks = bus_a2noc_clocks, + .num_clocks = ARRAY_SIZE(bus_a2noc_clocks), .regmap_cfg = &msm8996_a2noc_regmap_config }; From patchwork Sat Dec 10 20:03:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 32090 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp1476048wrr; Sat, 10 Dec 2022 12:06:47 -0800 (PST) X-Google-Smtp-Source: AA0mqf6/KV5OUVo752kTpWADitn8TJYStKDE+mR0DzxT5Bl4kdPiyWxSpi0/KRVgPuLmurvd2MO2 X-Received: by 2002:a05:6a20:2d20:b0:a4:c6e5:65b8 with SMTP id g32-20020a056a202d2000b000a4c6e565b8mr14103251pzl.28.1670702806971; Sat, 10 Dec 2022 12:06:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670702806; cv=none; d=google.com; s=arc-20160816; b=bobSPgP2LsPWze6Fgbw1dur0ESu9+v9h8SQ4d4rBw8kTgzZbzBzmuj71uvtsQaw3vj eGCtZJreIp1tziD4J9Cm0o5mUGgevdEO/sxYRtXzXlUBmZPtNZGbf1fNs1XWP6yAm6JS gMIJYF3q4K4mQbhooGJkgTsUjKkn1oFISq9/M+s92bLYKsv5dM1DafjEMtbHje0QexdP D41a+4ffBxcC6n5uLMyZjUIy64XindZn0Zppxkwtpq/5IwB0OtyrcFYeKanaS6Wut5tG 2E+2n1FcVYyTja7W/ierOVsDiaDsGbyyRViQd/gDrEOEyG3I06hmtauXZrE/x52Idny9 PBHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=F70X0h1gEhZbNZjzSbofbLgELtxej/JOcL3nmVN4Az4=; b=Awg/Jn4MVug/NtbQk5yhZoLLD8MS9sjHwsfdbw/vvL8Clec9H1vEWE8yMnccI6E8oq OCYyiSRN+gigYQGNVMBtBLDyED/y1o7wlRQhPAiLM2Sp85Li4UUqo/2xYfjFESPdIdKp +UMkj66zOYop8U+OiZQk6tO7ZncxGfv1WcBV3Gzl65slFz0R+MGGDeivgMCEM3xIbhRn PPeI207wGSSfvMz7zA3MVVdzHO0skhhYfzXFq7neZEEv6enQJAi206B4X4/34w3XF5JY 6kOVBHQtyCPLa9GQWc0K/FUgR9m/RWtRswUI/40d2iDKy9v+6xUXn5kArxjx7YZmjIbJ XXFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VnlJ64RR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 19-20020a630113000000b0047917a0efb5si5038874pgb.230.2022.12.10.12.06.34; Sat, 10 Dec 2022 12:06:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VnlJ64RR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229876AbiLJUER (ORCPT + 99 others); Sat, 10 Dec 2022 15:04:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229854AbiLJUEM (ORCPT ); Sat, 10 Dec 2022 15:04:12 -0500 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78F4114027 for ; Sat, 10 Dec 2022 12:04:11 -0800 (PST) Received: by mail-lf1-x130.google.com with SMTP id b13so12256514lfo.3 for ; Sat, 10 Dec 2022 12:04:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=F70X0h1gEhZbNZjzSbofbLgELtxej/JOcL3nmVN4Az4=; b=VnlJ64RRCWzDKIto7yzRZOPNx02NENlNPq+D7IcdtNHcHY6i9XFs003Bpn5i8F/q+0 TBcBTDmPgKBgwHNMs7oZrwj2VWOwecYuinfcarY8ODviqBW/O8NrGC7i96YZ9iUEr0uX DDcSpxRSdoailKGYOr8RckqaPjr52R6BJnk2PL2M2LW7mqTBtusEAHxIRda99LNVMDlk UjOf2eWMxp2RzvGobCtt1Rox78AFINvtPTP3Mj7rb+GOmjXRHR/84b123FWRV0aohhKu qHkRusMEJSHtYRAl57u28hImiZlolPs9ZN6MATKNQLnEHn+mZunLZUTgs7cmv6n5kcPn nbig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=F70X0h1gEhZbNZjzSbofbLgELtxej/JOcL3nmVN4Az4=; b=TedZN7Dk0vGWKPGV3Ciz63EFBoelceAEchOqLjs5qwHtrPHnMUNnq6JJqMgDnKOu7g f0ft3B+Cu4S5mnJ7v5tIBy77wfcjuL2SwSpFkYTkpGSl2BA1638/75SUwg3phW0l48aF kUHspAs0eWI7T5ppbwtj7Qtk833BnjiuS/+52Mz5+fxJLMGbqpmGVBUugsWZBxf9xpFB aSCmFrCOP2/PhVBjHnRwxy0ArQfRegN0qGi4lNdsOMVT5s/haWmjwL4MypOybiOy7Ltf YuA68HOa8Pgrt7q+lTGpMMyYeTliMVbNzGNRc1MniZa9S4ZYDHjLRU1PVBq2jj4HLhl2 Q8PA== X-Gm-Message-State: ANoB5pm+tAOUtyhrp2pn4Q3dicLxP6hmYAp6qn8FrPKz18iQBFqD+oke pApZ8sEAihv6wfz9YJPS31B/WA== X-Received: by 2002:a05:6512:32ce:b0:4a4:8044:9b8 with SMTP id f14-20020a05651232ce00b004a4804409b8mr3063830lfg.9.1670702649853; Sat, 10 Dec 2022 12:04:09 -0800 (PST) Received: from localhost.localdomain (abxh44.neoplus.adsl.tpnet.pl. [83.9.1.44]) by smtp.gmail.com with ESMTPSA id h28-20020ac2597c000000b004b4f1ea713csm839628lfp.73.2022.12.10.12.04.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Dec 2022 12:04:09 -0800 (PST) From: Konrad Dybcio To: linux-arm-msm@vger.kernel.org, andersson@kernel.org, agross@kernel.org, krzysztof.kozlowski@linaro.org Cc: marijn.suijten@somainline.org, Konrad Dybcio , Georgi Djakov , Dmitry Baryshkov , Yassine Oudjana , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/5] interconnect: qcom: msm8996: Fix regmap max_register values Date: Sat, 10 Dec 2022 21:03:51 +0100 Message-Id: <20221210200353.418391-4-konrad.dybcio@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221210200353.418391-1-konrad.dybcio@linaro.org> References: <20221210200353.418391-1-konrad.dybcio@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751858866120409526?= X-GMAIL-MSGID: =?utf-8?q?1751858866120409526?= The device tree reg starts at BUS_BASE + QoS_OFFSET, but the regmap configs in the ICC driver had values suggesting the reg started at BUS_BASE. Shrink them down (where they haven't been already, so for providers where QoS_OFFSET = 0) to make sure they stay within their window. Fixes: 7add937f5222 ("interconnect: qcom: Add MSM8996 interconnect provider driver") Signed-off-by: Konrad Dybcio Reviewed-by: Dmitry Baryshkov --- drivers/interconnect/qcom/msm8996.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/interconnect/qcom/msm8996.c b/drivers/interconnect/qcom/msm8996.c index 7ddb1f23fb2a..25a1a32bc611 100644 --- a/drivers/interconnect/qcom/msm8996.c +++ b/drivers/interconnect/qcom/msm8996.c @@ -1813,7 +1813,7 @@ static const struct regmap_config msm8996_a0noc_regmap_config = { .reg_bits = 32, .reg_stride = 4, .val_bits = 32, - .max_register = 0x9000, + .max_register = 0x6000, .fast_io = true }; @@ -1837,7 +1837,7 @@ static const struct regmap_config msm8996_a1noc_regmap_config = { .reg_bits = 32, .reg_stride = 4, .val_bits = 32, - .max_register = 0x7000, + .max_register = 0x5000, .fast_io = true }; @@ -1858,7 +1858,7 @@ static const struct regmap_config msm8996_a2noc_regmap_config = { .reg_bits = 32, .reg_stride = 4, .val_bits = 32, - .max_register = 0xa000, + .max_register = 0x7000, .fast_io = true }; @@ -1886,7 +1886,7 @@ static const struct regmap_config msm8996_bimc_regmap_config = { .reg_bits = 32, .reg_stride = 4, .val_bits = 32, - .max_register = 0x62000, + .max_register = 0x5a000, .fast_io = true }; @@ -1997,7 +1997,7 @@ static const struct regmap_config msm8996_mnoc_regmap_config = { .reg_bits = 32, .reg_stride = 4, .val_bits = 32, - .max_register = 0x20000, + .max_register = 0x1c000, .fast_io = true }; From patchwork Sat Dec 10 20:03:52 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 32093 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp1482174wrr; Sat, 10 Dec 2022 12:25:30 -0800 (PST) X-Google-Smtp-Source: AA0mqf4K0gV/32Z2SAdA7HvMvuG8w4OxmP3wzhBJw3qchuyzSQ692/tLY5Ys7ZGDKYsvXPWH/2oe X-Received: by 2002:a17:907:c787:b0:7ae:126a:99b8 with SMTP id tz7-20020a170907c78700b007ae126a99b8mr10120400ejc.61.1670703930464; Sat, 10 Dec 2022 12:25:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670703930; cv=none; d=google.com; s=arc-20160816; b=akoGoBQ8L7yVDAAuhmiLZnfXMF4FcuLrVPE5zWLFxiqz//4+WKrbUPFjjC5ZVFQh1W lNudlq7a+h3JeXvxSkx67th3ivUIVM1Z1+cRoIUX8RoWD8qhDbjAG3sSMZM3Ptek37pp IX5hIPdQH0ix+CdzZ2T7iWdNC50OGHnYe+vXfxcvb91K2B51Dyn0IHvT5RQZwLDtxAyC L1/lGWNC8L0evBZzf6yKHBS899oOHxBz2S5aR99yKdSrf9n9RPafUtw3jjTbpyshvrrC 7wnwjmK0up5qXYMacN1uenKTXDhitt0Q0VuFyfgxFznDAfzL09wcZNHOPdvmjEr8/UgE j5CQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Xj0jB4AhzYQNXspmImuMXL7HzHFtFIdHtKGTYSzQnq0=; b=vVk/myYKLQUw5PbmBYZCb+AWw0uDdsumJ6EsVoOhdnrW/0Vrd6/Nhhu1NbMH2SXh+H cC1bz4rLw8dPOoSlYVX1s+9gFPWptOVEN5zWwnAEB7QuugM0EZWesK0dr3dehF4ISlNN v3n5dnEYJREwsIlpP5L/+ffr4rHjG2T111yX5E14mHd/nOayTLnFDZgywHOG1FrHJLHp q8fDElNlc/5XcsCbo24cHZx+NCNRTKTSs89jnnoA1kCRxTzjysFtSN1Z+IQ3aa2LhZYg U+3FCxuYKtm5UUf2bf7fOFJePSNB7QUih6v+fgeHFpr7z1y1XYp+B5W+G/dJEBw2tmvA ShGQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=q3LIslAF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ji5-20020a170907980500b007c0c2ec3683si2887963ejc.106.2022.12.10.12.25.03; Sat, 10 Dec 2022 12:25:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=q3LIslAF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229961AbiLJUEY (ORCPT + 99 others); Sat, 10 Dec 2022 15:04:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229888AbiLJUEP (ORCPT ); Sat, 10 Dec 2022 15:04:15 -0500 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 741311403E for ; Sat, 10 Dec 2022 12:04:13 -0800 (PST) Received: by mail-lf1-x133.google.com with SMTP id c1so12244480lfi.7 for ; Sat, 10 Dec 2022 12:04:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Xj0jB4AhzYQNXspmImuMXL7HzHFtFIdHtKGTYSzQnq0=; b=q3LIslAF2wRgh8DspOIqNEL5gxAzBjGzT1d0OFAjbzlOaSF6aIcUPKMgV6CNdRTYjT BPyhBbUunkkujEuf24tjFN2s0DyYsbiyUuWTIkJPg89nduDRd43gnPE77ozTe1n2AILd nFj4xP3Fqfyc/kK+EpUbBwP8ZPCi3yBZ/NMBMxcJGtSjNDODRSoj6/h+hFobDpnyNkhU iRcPyHpd+nyjT5hyqqplBO5HJd8CJKw+76tvmYgKLlmqZY6KKZLFj91bZYOz7yzxnzQm dhTNd8UUnewDyt8ns8Z8jMVro9FXj/+bcXyTUriQjoSRaTz2XC3Eh10/fU4R6PPLON4o vRYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Xj0jB4AhzYQNXspmImuMXL7HzHFtFIdHtKGTYSzQnq0=; b=Ta527S5z+37jiREKzxtgGsgv70eJTy1yjpzxi6XjmEcL5BoKpKBQGCOwNiUadGCWg8 8Mvna+lbBJIxJCqs0JKXTdML6a06znvlPLOiGA1J7OFBUty0V4vqoP1xQE0lTUpxEk69 JPP51jvDDx/hJMOZPNGzhZyySZAvg/nunpzwuRImsfEvKnXDnT3DHWgI4t4OROOHikQL c4gfX1MCrpiIO4YnQkhfcDNELTLYtImCf70wwVHdR6FfrWY4XqHT7uKV5uuFv3xr9voG 3u4fEqHI74U/dEX1DvXUCqA7yI1iyD8SmTM9yuFlRt6dBlt/ODEIokEpi3LW8x/03m3x oNug== X-Gm-Message-State: ANoB5plpbF10RIuXJte6hYZNtoy5dLNZss0pfdfD//zQqZTAER3lFnXR 5ZhzOFpTNtANVCPfh4BAs5VuQA== X-Received: by 2002:a05:6512:3d0e:b0:4b5:9043:2530 with SMTP id d14-20020a0565123d0e00b004b590432530mr4008272lfv.68.1670702653080; Sat, 10 Dec 2022 12:04:13 -0800 (PST) Received: from localhost.localdomain (abxh44.neoplus.adsl.tpnet.pl. [83.9.1.44]) by smtp.gmail.com with ESMTPSA id h28-20020ac2597c000000b004b4f1ea713csm839628lfp.73.2022.12.10.12.04.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Dec 2022 12:04:12 -0800 (PST) From: Konrad Dybcio To: linux-arm-msm@vger.kernel.org, andersson@kernel.org, agross@kernel.org, krzysztof.kozlowski@linaro.org Cc: marijn.suijten@somainline.org, Konrad Dybcio , Georgi Djakov , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/5] interconnect: qcom: rpm: Use _optional func for provider clocks Date: Sat, 10 Dec 2022 21:03:52 +0100 Message-Id: <20221210200353.418391-5-konrad.dybcio@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221210200353.418391-1-konrad.dybcio@linaro.org> References: <20221210200353.418391-1-konrad.dybcio@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751860044981781394?= X-GMAIL-MSGID: =?utf-8?q?1751860044981781394?= It turned out that - very unfortunately - msm8996 needs a binding update, adding 2 more clocks to the A2NoC node. Use the _optional variant of devm_clk_get to make sure old DTs will still probe with newer versions of the driver. Signed-off-by: Konrad Dybcio Reviewed-by: Dmitry Baryshkov --- drivers/interconnect/qcom/icc-rpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/interconnect/qcom/icc-rpm.c b/drivers/interconnect/qcom/icc-rpm.c index ba6781f54ab7..df3196f72536 100644 --- a/drivers/interconnect/qcom/icc-rpm.c +++ b/drivers/interconnect/qcom/icc-rpm.c @@ -488,7 +488,7 @@ int qnoc_probe(struct platform_device *pdev) } regmap_done: - ret = devm_clk_bulk_get(dev, qp->num_clks, qp->bus_clks); + ret = devm_clk_bulk_get_optional(dev, qp->num_clks, qp->bus_clks); if (ret) return ret; From patchwork Sat Dec 10 20:03:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 32094 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp1482175wrr; Sat, 10 Dec 2022 12:25:30 -0800 (PST) X-Google-Smtp-Source: AA0mqf5M2V/rjLsWo2W7kJBTOUR1qDw6EHUskgmW+FrFi2B6G2mfXkYvMTYmiK8iCexri1+2EDBF X-Received: by 2002:a17:906:c2d3:b0:7c0:ff72:e828 with SMTP id ch19-20020a170906c2d300b007c0ff72e828mr8638794ejb.54.1670703930467; Sat, 10 Dec 2022 12:25:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670703930; cv=none; d=google.com; s=arc-20160816; b=HQ8XSbPdXHUr0cl81fnPeAS7bpYHEMD2lqhSfVaX6sC/aqyqdX3u1jq3KsyGe+Lh5U K0HiC8UuDxXr6UbYiLk7GSKsQTYyR4Keq9cujIye9A9OCl3oX0iheEHAWppWIobvxGDa P1KL0qMt/DoGVBV0WXd5H5BLV+fwiP9eGfbWzaWIKQ53hUuMS5F+6LRucQkT7KU7Bfg+ tOsZ7JZxhcwG5fsfylFu4hSAQqfLhs0J76CS6hX06uTw+Pw6nW69S2scWGyhXIeFT+77 um7LxXx7jCr4qglSrSB1Is2zw0CpKwL7yBtfWjrAaEXSDi7i/xzPrvLi6jemXczYMGml wIEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=iI0a0GEkM+OEMminGresAON2Q/s+/NfY86fzKXWDTVw=; b=Kg24I7SThLcA2G+Md/TyQoqBQ5Vcp1/PJf2s4bKDqKqJXSI8wzKwCQ53kx6iJMStRx K3IRomkbVMJWhsGaon9A1+2B1rYx8i6c4Pfdz/UoIzXeZN6Ud6zboLIuKAj6JXWb+vOd d2wwq6sWXK9EK2Wad/P2XV6DQHvVwTjN5dA7Wre3tgn5gjLVeQvVArT2IMmvAfK0wiCe LGqGvfhWpDHB9i5f4UopeDfmpAFy8/RoakO+FcbyB7TBigcJ3fUHwlHzvgB555WElAWX kvxUa8R0nUk0U4Y9q2n5sRvarpEOO20W8vemE2UK/P8vw0AxGxNymrPqV3WFybOWiKIA hNWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=morpBfXA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hg4-20020a1709072cc400b007b299051a9fsi2698713ejc.192.2022.12.10.12.25.03; Sat, 10 Dec 2022 12:25:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=morpBfXA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229793AbiLJUE1 (ORCPT + 99 others); Sat, 10 Dec 2022 15:04:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229854AbiLJUES (ORCPT ); Sat, 10 Dec 2022 15:04:18 -0500 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A94714028 for ; Sat, 10 Dec 2022 12:04:17 -0800 (PST) Received: by mail-lf1-x131.google.com with SMTP id bp15so12199852lfb.13 for ; Sat, 10 Dec 2022 12:04:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iI0a0GEkM+OEMminGresAON2Q/s+/NfY86fzKXWDTVw=; b=morpBfXAf66+6TMe3djDbtuV9+H4QQE2nu/zabEQ3yhmBHe+zwSaaq2svVix8I7WTe mEaiiBlObLnTB8VjMFjpWlcI64j2iEdr/03DSgNd7c7gvb4ezZH/jWUOG30jL5BGRuiZ RuLn4acdY3NsnKU2GFFq/dpljzLK9SFkFzfWYgW+7VBRQjOjsaeN4j6oxaC0tdibaHVk w/7y7dN/UHUJIMxxJGsnEmLe9C+y54rqroF5rON0Eze6hnRFXYTzbmnDkNrgRt4qYizX sF4BuxzwlZdYEq/BJFyJpxRgKb/jB8qWOpWpMNb8qBpSoy4Yzys9/smvCQNm1h4teRBh cWlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iI0a0GEkM+OEMminGresAON2Q/s+/NfY86fzKXWDTVw=; b=kCBL22dM48dhPq8BJTKsKr7Z8bDYbFV4sFemWqmIBS1LuBJmR8CPqGa8vZcHna8A3h 6A6uQYZAMCgAjUQDqkTl2NOXfDxtgJwA0H8/4i9Ycx+dpxl3LYMLDEWlcQUiQzgIgAw/ Te4tX3piABsyzdc0OLX6cwdZgNhvE7GoQtYJYYJMx2du9vrymYJG24DxodERIu/Z5m1V XT/SRmLDqf9oKTK73/UTrwWuFfUaREncewinStpPBKzVtY5y6BeLwo93zceGPprMCItv O/pDnbmAksmlAB6IG1/Gmrccu+iOlSa39+HgJijgNGBwR0jktmkNITfOc3w0a+0fGpZJ l6cQ== X-Gm-Message-State: ANoB5plLdIS15Sst+6/OUAw9XfJEB5cn5rjGhGDRijIzXg9/sFwskw1Y KcWBzRNOZ7eXVWc09qW2ZRPLZQ== X-Received: by 2002:a05:6512:261d:b0:4b5:d:efb2 with SMTP id bt29-20020a056512261d00b004b5000defb2mr3978255lfb.14.1670702657093; Sat, 10 Dec 2022 12:04:17 -0800 (PST) Received: from localhost.localdomain (abxh44.neoplus.adsl.tpnet.pl. [83.9.1.44]) by smtp.gmail.com with ESMTPSA id h28-20020ac2597c000000b004b4f1ea713csm839628lfp.73.2022.12.10.12.04.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Dec 2022 12:04:16 -0800 (PST) From: Konrad Dybcio To: linux-arm-msm@vger.kernel.org, andersson@kernel.org, agross@kernel.org, krzysztof.kozlowski@linaro.org Cc: marijn.suijten@somainline.org, Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/5] arm64: dts: qcom: msm8996: Add additional A2NoC clocks Date: Sat, 10 Dec 2022 21:03:53 +0100 Message-Id: <20221210200353.418391-6-konrad.dybcio@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221210200353.418391-1-konrad.dybcio@linaro.org> References: <20221210200353.418391-1-konrad.dybcio@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751860044604666100?= X-GMAIL-MSGID: =?utf-8?q?1751860044604666100?= On eMMC devices, the UFS clocks aren't started in the bootloader (or well, at least it should not be, as that would just leak power..), which results in platform reboots when trying to access the unclocked UFS hardware, which unfortunately happens on each and every boot, as interconnect calls sync_state and goes over each and every path. Signed-off-by: Konrad Dybcio Reviewed-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi index 95dc10a1deb2..616b5b1b1fb0 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi @@ -826,9 +826,11 @@ a2noc: interconnect@583000 { compatible = "qcom,msm8996-a2noc"; reg = <0x00583000 0x7000>; #interconnect-cells = <1>; - clock-names = "bus", "bus_a"; + clock-names = "bus", "bus_a", "aggre2_ufs_axi", "ufs_axi"; clocks = <&rpmcc RPM_SMD_AGGR2_NOC_CLK>, - <&rpmcc RPM_SMD_AGGR2_NOC_A_CLK>; + <&rpmcc RPM_SMD_AGGR2_NOC_A_CLK>, + <&gcc GCC_AGGRE2_UFS_AXI_CLK>, + <&gcc GCC_UFS_AXI_CLK>; }; mnoc: interconnect@5a4000 {