From patchwork Fri Dec 9 15:56:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 31861 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp853933wrr; Fri, 9 Dec 2022 07:57:43 -0800 (PST) X-Google-Smtp-Source: AA0mqf42V0veAvu5uvA8GUOX+Kdhg2caxlYPn8Jvh2RVmN0R+kX45WqQAfzszU9zhgAQfLHg/g4W X-Received: by 2002:a05:6a20:1024:b0:aa:6efd:1883 with SMTP id a36-20020a056a20102400b000aa6efd1883mr11853964pzd.37.1670601462987; Fri, 09 Dec 2022 07:57:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670601462; cv=none; d=google.com; s=arc-20160816; b=T5lVVk2MwfIzW1ot4+btcfL529CkjFgFFj+xMngs6VlicYI0wRsEb/I8asIHFiWc7M dRUgU7/nUaU1eTVXIOMx1kMGdyYgOe9ZqD7bHiOxeW4bx7/XiRF/17aW0QXAIPRM0vcU o9PPbz8r1zdyS12hzpQrAVVqtnF4G32T5F3oEtvddWsr3m4TWS+o9qNu3gGvEOqWZTbC jPok80zCnOgjAhcartrzu69yeALRlYD//4VzF8Wh6QOIWfkNdtPnC0XivnjCF/Ae2Th0 1CC64Tl95GJwGOUjJ+M0WJeV9bkdVveP+Z0sDTEH7sJwDR+nIlJ2fnapUz4Dyli0h3mN RcZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:subject:cc:to:from:date; bh=97jDA2PEAmc7f7GBZdfthh3H4TPqohduJIUyyiVPm/g=; b=jLoMssk4ATL1/X2AO8lxQJ3YArm5wcShVWizEK6WAZjMApdX/ixaMqsBo8YqoaTn9E Ghr6odOMRWBBF57b6Oxqls6Fud8r25aTIe4aDFYaKOG9VtBtSpR5aIc/q8gHZcOqBRNN AFJQ2XvwA9QHEvwxje61Ux2S/GeQZKj1NTKWFK+V8muDpbF4JKiK/BB8G9VQm8HDL1XJ 2buaEtamIQeovWH7hpDoNcD/VK7CZpIXoFKWv3umy5TqNNOPo/iLLmxq68UdCopLTQYA foNOzIpRsLtICkV+ui3L5gAwovZsMxY6nO4iCDjz7Z+QSGfmOBsvqOqu4e3QQqcSAoZh TSNg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w64-20020a636243000000b004774a855372si1639548pgb.694.2022.12.09.07.57.29; Fri, 09 Dec 2022 07:57:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229957AbiLIP4t (ORCPT + 99 others); Fri, 9 Dec 2022 10:56:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230320AbiLIP4q (ORCPT ); Fri, 9 Dec 2022 10:56:46 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28D4520F41; Fri, 9 Dec 2022 07:56:45 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BCED7B82896; Fri, 9 Dec 2022 15:56:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9F96C433D2; Fri, 9 Dec 2022 15:56:41 +0000 (UTC) Date: Fri, 9 Dec 2022 10:56:40 -0500 From: Steven Rostedt To: LKML , Linux Trace Kernel Cc: Masami Hiramatsu , Andrew Morton Subject: [PATCH] ftrace: Fix print_ip_ins() to print only two digits per byte Message-ID: <20221209105640.6d5eda0e@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751752599693724858?= X-GMAIL-MSGID: =?utf-8?q?1751752599693724858?= From: "Steven Rostedt (Google)" Fix print_ip_ins() to use unsigned char, as: e9:2b:b6:0d:18 is easier to understand than ffffffe9:2b:ffffffb6:0d:18 Link: https://lore.kernel.org/all/CA+wXwBQ-VhK+hpBtYtyZP-NiX4g8fqRRWithFOHQW-0coQ3vLg@mail.gmail.com/ Cc: stable@vger.kernel.org Fixes: 6c14133d2d3f7 ("ftrace: Do not blindly read the ip address in ftrace_bug()") Signed-off-by: Steven Rostedt (Google) --- kernel/trace/ftrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c index d04552c0c275..32fc1600d596 100644 --- a/kernel/trace/ftrace.c +++ b/kernel/trace/ftrace.c @@ -2028,7 +2028,7 @@ static int ftrace_hash_ipmodify_update(struct ftrace_ops *ops, static void print_ip_ins(const char *fmt, const unsigned char *p) { - char ins[MCOUNT_INSN_SIZE]; + unsigned char ins[MCOUNT_INSN_SIZE]; if (copy_from_kernel_nofault(ins, p, MCOUNT_INSN_SIZE)) { printk(KERN_CONT "%s[FAULT] %px\n", fmt, p);