From patchwork Wed Dec 7 12:41:34 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Li,Rongqing" X-Patchwork-Id: 30825 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp156946wrr; Wed, 7 Dec 2022 04:44:03 -0800 (PST) X-Google-Smtp-Source: AA0mqf7ihKSdRacEZigJgplwrFk51G2PRHpRngRwWPUKH5WD3KEbVMn9jIYftZSkMcNn/akuxATw X-Received: by 2002:a50:fd08:0:b0:46c:7117:3cae with SMTP id i8-20020a50fd08000000b0046c71173caemr15612546eds.195.1670417043595; Wed, 07 Dec 2022 04:44:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670417043; cv=none; d=google.com; s=arc-20160816; b=D5VS0kpuHjcHLn0O0ZqLxmxJQoCb+64m6C2hz9onbNA68HIsfpFbNXnp3rsxZ+8O0j DoFCFhqPkJIOskma7cKsU1t+VAe0OjKjAFkVdmMO9Ps2XKIM6ifKL0TUQRCISBjFxUdi bi1NvhbkOoIqCB9ddcQ/V3utoTW4z1ZD8TMdJtuS1eKklLNHkVLHxFIsJJf81roZr/q9 yBqhCxSA+6/bOuR+xmnBX4MmvoqffS5KAm9xIpicpjYjcslWAsNIm7nvyuGKYyQyIGKd PE94r35XsxF1ProfDQyXHf8sKp5/XLRLXPdEQnSk6d/U3JCQbaFYCslGIe1wNge8YUxn HpXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:to:from; bh=cxH0z7PyTfXWjJ8SJyP9knDtYade4KeHPvBjYjlJnJ4=; b=SvdVzSL19UYgUXjVT8lT0YI9yrCYyoaz4/LI1JdcWvB8ohcpO3Ktov//5CSkgA05zN UbePGNoCr5jhR9ynKH2VKJo/4QuDq3ovJI1Vza/8p9i2finZCWBdxuMK5Ted/oWBy+5K 7An+W/DcTPUYR/U+YFNSmJ+hbPb6YHlqnXMW6e/XvZeQVW9xjNuqox5mJJzGF851NusS EdZOzRDns5DismCHEQpxtqP1SnvqgBtheoFzEIswPeFmWgBZcOEFgytzS8ujeYmfUT81 4ke0sEYy+cgL3+I0WXNJ2j4X4sZmXJp9W/tnxxRkqI1ifxnDwdviUcYZ5MkqMUmYcXlo /eBg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u1-20020a1709064ac100b007adb868f102si12691032ejt.476.2022.12.07.04.43.39; Wed, 07 Dec 2022 04:44:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229865AbiLGMmc (ORCPT + 99 others); Wed, 7 Dec 2022 07:42:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229674AbiLGMm2 (ORCPT ); Wed, 7 Dec 2022 07:42:28 -0500 Received: from bddwd-sys-mailin01.bddwd.baidu.com (mx402.baidu.com [124.64.201.15]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C6E76391C2; Wed, 7 Dec 2022 04:42:27 -0800 (PST) Received: from bjhw-sys-rpm015653cc5.bjhw.baidu.com (bjhw-sys-rpm015653cc5.bjhw.baidu.com [10.227.53.39]) by bddwd-sys-mailin01.bddwd.baidu.com (Postfix) with ESMTP id 6087A11980033; Wed, 7 Dec 2022 20:41:35 +0800 (CST) Received: from localhost (localhost [127.0.0.1]) by bjhw-sys-rpm015653cc5.bjhw.baidu.com (Postfix) with ESMTP id 59702D9932; Wed, 7 Dec 2022 20:41:35 +0800 (CST) From: lirongqing@baidu.com To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, rafael@kernel.org, daniel.lezcano@linaro.org, peterz@infradead.org, akpm@linux-foundation.org, tony.luck@intel.com, jpoimboe@kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH 1/2][v2] cpuidle-haltpoll: Replace default_idle with arch_cpu_idle Date: Wed, 7 Dec 2022 20:41:34 +0800 Message-Id: <1670416895-50172-1-git-send-email-lirongqing@baidu.com> X-Mailer: git-send-email 1.7.1 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751559222235810278?= X-GMAIL-MSGID: =?utf-8?q?1751559222235810278?= From: Li RongQing When KVM guest has MWAIT and mwait_idle is used as default idle function, but once cpuidle-haltpoll is loaded, default_idle in default_enter_idle is used, which is using HLT, and cause a performance regression. As the commit aebef63cf7ff ("x86: Remove vendor checks from prefer_mwait_c1_over_halt") explains that mwait is preferred so replace default_idle with arch_cpu_idle which can using MWAIT optimization. latency of sockperf ping-pong localhost test is reduced by more 20% unixbench has 5% performance improvements for single core Suggested-by: Thomas Gleixner Suggested-by: Rafael J. Wysocki Signed-off-by: Li RongQing --- arch/x86/kernel/process.c | 1 + drivers/cpuidle/cpuidle-haltpoll.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c index c21b734..303afad 100644 --- a/arch/x86/kernel/process.c +++ b/arch/x86/kernel/process.c @@ -721,6 +721,7 @@ void arch_cpu_idle(void) { x86_idle(); } +EXPORT_SYMBOL(arch_cpu_idle); /* * We use this if we don't have any better idle routine.. diff --git a/drivers/cpuidle/cpuidle-haltpoll.c b/drivers/cpuidle/cpuidle-haltpoll.c index 3a39a7f..e66df22 100644 --- a/drivers/cpuidle/cpuidle-haltpoll.c +++ b/drivers/cpuidle/cpuidle-haltpoll.c @@ -32,7 +32,7 @@ static int default_enter_idle(struct cpuidle_device *dev, local_irq_enable(); return index; } - default_idle(); + arch_cpu_idle(); return index; } From patchwork Wed Dec 7 12:41:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Li,Rongqing" X-Patchwork-Id: 30827 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp157742wrr; Wed, 7 Dec 2022 04:45:45 -0800 (PST) X-Google-Smtp-Source: AA0mqf7z7cIKTf0EJ4KsozArdOgdyrscWBXJoKHsrcSqvpB8bO3XQuqB+OUMHVquYiDPSGl9fshp X-Received: by 2002:a17:906:86ca:b0:7c0:fa2d:bc49 with SMTP id j10-20020a17090686ca00b007c0fa2dbc49mr9880361ejy.438.1670417145484; Wed, 07 Dec 2022 04:45:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670417145; cv=none; d=google.com; s=arc-20160816; b=gtQ38JzI+4sNgytV6xKvu5s4PK/UH81OGYvtda3AMyxLIuxMYZ0+iDL32yeK3Nciow Y1i5q8UJjDO08weqFse5p9mCatfdjuAmx/mlEKpWVJLZLV8j1AHrF2VcKi8X63G6idzR lafD3yj5w8zaB4rZrygI0ktGKvgrpSPRUP3ygDVdCGMdRvvwEGkwpD/Uf7U4YN9vJl4x 6JxdrwgU5GJlWVPqoVyMMUAgsUkOYV9DmFXLgmVDfTx2pZ8mocaimGmplidDOI3TfdGj IdD1tpJqA87zHJUVYfJqVdwRvy36A8Htxpqnj1QRO8g02i7odCoTxnzxvn2jRSHSjOiO ai0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :to:from; bh=zitN1nSb68QVyEGrtJoIx2L/iU+xTthOqxQslhoAa4U=; b=I+yHCICtHQ4mba8elyN98OEZMs5CnYLHPC5f7hihKcx8uXWVm5dWIcykwIvEIq9HL9 MAn+/V4bwB3TfTX7RkdChl73kLObiLns/OBYYDjwcL/AKQT3Op2nxkfn5e2PzepZyhxw PXUcPiCbWOMHPL83RRiqAfgJVl15w0skQkJ66z9D0UfAzFqETKLbsJ9noYVjGfg6p+xw b8nJiSR3SbyUTnfm0d+avOpDcddR9FCQOjbni/heQpRFLaMOpPZfKOufNhuBlHrhkaz8 42ZlXFNyNfK9VGnnT6LsH35MF/iy9V61bQC/HHDDZikdbFWd5acmQVvzZfzwt5eaitDO GwIg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b10-20020aa7d48a000000b00469e7011949si3856874edr.508.2022.12.07.04.45.21; Wed, 07 Dec 2022 04:45:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229643AbiLGMll (ORCPT + 99 others); Wed, 7 Dec 2022 07:41:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229566AbiLGMlj (ORCPT ); Wed, 7 Dec 2022 07:41:39 -0500 X-Greylist: delayed 107896 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Wed, 07 Dec 2022 04:41:37 PST Received: from mx405.baidu.com (mx414.baidu.com [124.64.201.133]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D173929C9D; Wed, 7 Dec 2022 04:41:37 -0800 (PST) Received: from bjhw-sys-rpm015653cc5.bjhw.baidu.com (bjhw-sys-rpm015653cc5.bjhw.baidu.com [10.227.53.39]) by mx405.baidu.com (Postfix) with ESMTP id 628521C100053; Wed, 7 Dec 2022 20:41:35 +0800 (CST) Received: from localhost (localhost [127.0.0.1]) by bjhw-sys-rpm015653cc5.bjhw.baidu.com (Postfix) with ESMTP id 5AA83D9933; Wed, 7 Dec 2022 20:41:35 +0800 (CST) From: lirongqing@baidu.com To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, rafael@kernel.org, daniel.lezcano@linaro.org, peterz@infradead.org, akpm@linux-foundation.org, tony.luck@intel.com, jpoimboe@kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH 2/2][v2] cpuidle-haltpoll: Build as module by default Date: Wed, 7 Dec 2022 20:41:35 +0800 Message-Id: <1670416895-50172-2-git-send-email-lirongqing@baidu.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1670416895-50172-1-git-send-email-lirongqing@baidu.com> References: <1670416895-50172-1-git-send-email-lirongqing@baidu.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751559329083794109?= X-GMAIL-MSGID: =?utf-8?q?1751559329083794109?= From: Li RongQing Allow user to unload it in running Signed-off-by: Li RongQing --- drivers/cpuidle/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cpuidle/Kconfig b/drivers/cpuidle/Kconfig index ff71dd6..43ddb84 100644 --- a/drivers/cpuidle/Kconfig +++ b/drivers/cpuidle/Kconfig @@ -74,7 +74,7 @@ endmenu config HALTPOLL_CPUIDLE tristate "Halt poll cpuidle driver" depends on X86 && KVM_GUEST - default y + default m help This option enables halt poll cpuidle driver, which allows to poll before halting in the guest (more efficient than polling in the