From patchwork Tue Dec 6 04:07:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 30074 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2625042wrr; Mon, 5 Dec 2022 20:28:17 -0800 (PST) X-Google-Smtp-Source: AA0mqf7D9wi7uZ7pWwOWN1RhijKzxvJZy08yEFzx0KmdBWFq6RKOzpujmv08YpaCvMq30qyaU519 X-Received: by 2002:a17:90a:9402:b0:219:6c4d:ba9d with SMTP id r2-20020a17090a940200b002196c4dba9dmr27768745pjo.175.1670300897041; Mon, 05 Dec 2022 20:28:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670300897; cv=none; d=google.com; s=arc-20160816; b=JsxbEwKCPMooet5Et2myV6okJqPvgHlPLWS7yds2efY3mwiSdQyGiyhVZ9NZh3XgT4 dZSzjH9OJrBc3B/Ws/XJP7uB7L5IAYkVAxui9PzvFuHHNADucQi4Ljyx2BbHaIhJGTr1 nbJL++Dup9vhOgIU0fVkaacImBKdB+Qw4MYjn6gEfbTd6WhJJrh1P05WXdqARbIwWVmF Wxm6eb14TGBP0p1xx7Xq0inP7XjJZ5p3shfZaloAU7NGe4u7nnru0m6oZTwCDSxVTA5A MvqSv0LOsmPu+djzcG8r9kJRpz55sDXq7DXZ0ve8mjk6kMKCw2NvKzyGBNwF/HO5nbfx V+rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=G8MciaSDVisVg/UgNCoTkeshC0v7sTsEAPQMcwWFeCw=; b=uD9reEsxQnmqDh/AGlZumc/xpLn9PJBJT5ahB9LUltbKq0D2F6RKmQ9OCFLWcU9ZNp 9TH6VGClnwsxFgG6JBFlIYS6wIycFqM/DuhA5eCsQ5c5vPlk9oGTP4bah3goEbV7foSQ 9PWoybwRHSDAMg+i9JTq1b/n2Yn9vUAyQF12VozBwkD283xxsZXErZxBaVPLLyxb2qaU mbenpqRkT32DL+2DH78B6d05sjHHuNDBCBWNV40Gx2+nOsfEXtia6jW4+49WkLRhxmll XoctePwr+Ef/fqzPG7MLVCUm4JNYY+L2JxcKJiKsPNk3Q39iF47GJP2fSxcxwTo1fvKA ODXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gTgkS23L; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 21-20020a630415000000b0047060a55c40si3511149pge.712.2022.12.05.20.28.03; Mon, 05 Dec 2022 20:28:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gTgkS23L; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232323AbiLFEHs (ORCPT + 99 others); Mon, 5 Dec 2022 23:07:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231737AbiLFEHm (ORCPT ); Mon, 5 Dec 2022 23:07:42 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BEAE825F0; Mon, 5 Dec 2022 20:07:39 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6206E6154E; Tue, 6 Dec 2022 04:07:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 849F2C433C1; Tue, 6 Dec 2022 04:07:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670299658; bh=xMuxZCae0szPGAJBhjSo4T2NR8ZPREZDgVVh/yx9ZQY=; h=From:To:Cc:Subject:Date:From; b=gTgkS23LO53e9ZXwSI8myw+UnXHo138gf3ao7r8gpyPpDn8KGHtIIatSMjBU6SFM1 wcnf8nk53H9p19I3XY/w6KCoeLakXRgXvo5BYzLcRoI+nhJpTUuH/hHOhmo8YVJacu FO9olYX74DbjsL2XuY+Rd0OAOPH7W0wUWx+ZcO1gUiYO8/MDeFufTyLpYBijHiuaTr H2MLBc4wwSqrVI7PPgiyMeEXCRZJCxkolFhhgiv/eSHzatxtva7gDwHX1vH1jFBlXg YMogoNE3RK19Pdl+rIJbgHeGxPmzYvb045iOqE8lvuo5O+9k+bZHQMfWY8buHsQOUR SswN4twsvD0Ew== From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Masahiro Yamada , Nick Desaulniers , Nathan Chancellor , Nicolas Schier Subject: [PATCH 1/2] kbuild: move -Werror from KBUILD_CFLAGS to KBUILD_CPPFLAGS Date: Tue, 6 Dec 2022 13:07:30 +0900 Message-Id: <20221206040731.442499-1-masahiroy@kernel.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751437433474583198?= X-GMAIL-MSGID: =?utf-8?q?1751437433474583198?= CONFIG_WERROR turns warnings into errors, which happens only for *.c files because -Werror is added to KBUILD_CFLAGS. Adding it to KBUILD_CPPFLAGS makes more sense because preprocessors understand the -Werror option. For example, you can put a #warning directive in any preprocessed code. warning: #warning "this is a warning message" [-Wcpp] If -Werror is added, it is promoted to an error. error: #warning "this is a warning message" [-Werror=cpp] This commit moves -Werror to KBUILD_CPPFLAGS so it works in the same way for *.c, *.S, *.lds.S or whatever needs preprocessing. Signed-off-by: Masahiro Yamada Reviewed-by: Nick Desaulniers Reviewed-by: Nathan Chancellor --- Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 53fa1a9fba8a..f84b57910667 100644 --- a/Makefile +++ b/Makefile @@ -869,7 +869,8 @@ stackp-flags-$(CONFIG_STACKPROTECTOR_STRONG) := -fstack-protector-strong KBUILD_CFLAGS += $(stackp-flags-y) -KBUILD_CFLAGS-$(CONFIG_WERROR) += -Werror +KBUILD_CPPFLAGS-$(CONFIG_WERROR) += -Werror +KBUILD_CPPFLAGS += $(KBUILD_CPPFLAGS-y) KBUILD_CFLAGS-$(CONFIG_CC_NO_ARRAY_BOUNDS) += -Wno-array-bounds KBUILD_RUSTFLAGS-$(CONFIG_WERROR) += -Dwarnings From patchwork Tue Dec 6 04:07:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 30073 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2623435wrr; Mon, 5 Dec 2022 20:22:46 -0800 (PST) X-Google-Smtp-Source: AA0mqf4xzdR7g+bhvzUbSSCjHw5Llt0WVWtfGMWp7Qzbn85nWcT+xNz40YGQD7B5IB2xL2w/twfp X-Received: by 2002:a17:90a:73c2:b0:200:a7b4:6511 with SMTP id n2-20020a17090a73c200b00200a7b46511mr89840883pjk.101.1670300565694; Mon, 05 Dec 2022 20:22:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670300565; cv=none; d=google.com; s=arc-20160816; b=a1K+vhBcZ5XaKcO1qLplfzYxQBgHNC06EaEcLySZOvnI6v8LSdoRV/rJ1Ya7qa3W+0 U/6PTvjjGt4moKYa/2PouOvJYP4/srgSsV4uE9y4LNZ78bzBdhzOfHLDe5gT1EVnW24k K91UcGsVz3L9pdM235fxzLFWDO0qU+QROnxwN/qP6kpB3r+wIwqgjqRytORb2Y3LzHDj Aumzb5uj8Epx+BHdGItTpGJpQzzO9lsBW0FlnWOJFI0kO7Sqos5SD1GonbH0/1lUb3K6 uqyZVt8k4D7OxOyE4pQ4TL8ropykYMP4/fSDr88a1vVR9a+iGRQe1+D2Uf1pLtyH/WGs cogQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=dJhxJ6JKRQFmLoSMZYsJTdoi4wCGAfrwmw71rTlo8DM=; b=07AmZvlf/g792nXPre19vhirjw5nOEgWsj/x2taw7TIp4XrmlMNhZoFF8vPWCW3J2n 38nXSx2k/7O9HjDjwzLx+W0k23HKdDbZjvtvey6kn4BhF+mvQ9Vg+QKI7jxpuceaUC4d r44jLw8IGr4KGVHu0AHoyzupOc9qG4iNBSd40EpS9fdwSbP8y/LAQa23NLEzoGVpqk0t hLI3fKfSYKwHLqVZNaFoo0nl5ji2H85dSfRJpPgyhVckNG9di1rSc4FV2BWpFeDLwzXk BIhSRoG25c/WlqBMDBO554z2b2JD4yuH9/CSu7N3dHHfG7b0HTMDhuIRn3yIQA6Mg8V1 p5yA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Z/+oCTGS"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v202-20020a6361d3000000b004786a03b872si3146954pgb.761.2022.12.05.20.22.31; Mon, 05 Dec 2022 20:22:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Z/+oCTGS"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232490AbiLFEHz (ORCPT + 99 others); Mon, 5 Dec 2022 23:07:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233006AbiLFEHq (ORCPT ); Mon, 5 Dec 2022 23:07:46 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A23206154; Mon, 5 Dec 2022 20:07:43 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 27639B8168D; Tue, 6 Dec 2022 04:07:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E515C433D6; Tue, 6 Dec 2022 04:07:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670299660; bh=ePwjPaI2Z6T7+0xFbhATrAqsXtn51i/sOFs2gwoBkh8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Z/+oCTGSagCfjGAIgH9+UYCJW1OKq8vlJaL5kbq/ZnnKXgkfwk9/zQTLXJyZdRKxk eEQmGiUT3lQumFi0ji8UYtKXTQfqjJToSGxnXy6MNC3gHbX3s740fBSbV70tk87Rm4 3O2vK2HGubIzFLj2LwlASkA//z32xHyhQPf3EpepSpkRjZ+7BiM+4mph/qRsThkVhx lnI3ag0+KWG4IolR8lgxBRxV0YjWvnEM0TOMWnmB7+vcCYkhGx9H10xrlVAX1Egig6 nXwkV4kfU1vkWNcLDjzT37GIYGqsM/LkqJnb/rQMzuqEVqJXSnJsJ8LoezJjDe6SRg 6lfBRAZZ5IQ3Q== From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Masahiro Yamada , Nathan Chancellor , Nick Desaulniers , Nicolas Schier Subject: [PATCH 2/2] kbuild: add -Wundef to KBUILD_CPPFLAGS for W=1 builds Date: Tue, 6 Dec 2022 13:07:31 +0900 Message-Id: <20221206040731.442499-2-masahiroy@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221206040731.442499-1-masahiroy@kernel.org> References: <20221206040731.442499-1-masahiroy@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751437085928185115?= X-GMAIL-MSGID: =?utf-8?q?1751437085928185115?= The use of an undefined macro in an #if directive is warned, but only in *.c files. No warning from other files such as *.S, *.lds.S. Since -Wundef is a preprocessor-related warning, it should be added to KBUILD_CPPFLAGS instead of KBUILD_CFLAGS. My previous attempt [1] uncovered several warnings, and could not finish fixing them all. This commit adds -Wundef to KBUILD_CPPFLAGS for W=1 builds in order to block new breakages. (The kbuild test robot tests with W=1) We can fix the warnings one by one. After we fix all of them, we can make this default in the top Makefile, and remove -Wundef from KBUILD_CFLAGS. [1]: https://lore.kernel.org/all/20221012180118.331005-2-masahiroy@kernel.org/ Signed-off-by: Masahiro Yamada Reviewed-by: Nathan Chancellor Reviewed-by: Nick Desaulniers --- scripts/Makefile.extrawarn | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn index 6bbba36c5969..40cd13eca82e 100644 --- a/scripts/Makefile.extrawarn +++ b/scripts/Makefile.extrawarn @@ -38,6 +38,7 @@ KBUILD_CFLAGS += -Wno-sign-compare KBUILD_CFLAGS += -Wno-type-limits KBUILD_CFLAGS += -Wno-shift-negative-value +KBUILD_CPPFLAGS += -Wundef KBUILD_CPPFLAGS += -DKBUILD_EXTRA_WARN1 else