From patchwork Mon Dec 5 18:56:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rafael J. Wysocki" X-Patchwork-Id: 29883 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2422610wrr; Mon, 5 Dec 2022 10:59:20 -0800 (PST) X-Google-Smtp-Source: AA0mqf41aY7T6MeZcz4yr6nFovywRvi6kiMTM5ICZxqrCaXMn5ETnu8nT8mVHrNgVoEBvGz06jHQ X-Received: by 2002:a17:907:2387:b0:7c0:d6b2:1fd4 with SMTP id vf7-20020a170907238700b007c0d6b21fd4mr9878667ejb.703.1670266759943; Mon, 05 Dec 2022 10:59:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670266759; cv=none; d=google.com; s=arc-20160816; b=MDKeUmBKlzi2cK19ICj8438XAXmcNUVdjCqcexyDfBzd6myGpigIbxjUb9OR0LYl6C TU4HpcBKNK/mIqCpw/I2fi2GMX2m60h3a48bsSIJJzWS9cwHFaOeprwzpV1eaHFjPCw5 /aMtbWjnlAeawdlbkQNgBP1/siOqam+C+R3rOMu9PTGntCuO33zzf7rXDrGY0dDLZqnX vTr52uyq7TQeDbWqxdjriTivTpFAR/JhOX55ES45nmlZBrdfiK8MwocMaasvbtWrJww+ gzSLMU3iN3iATKB0zeUS42VYGbQH9VvUbNEb2+PsOdBpKv1FSh+tfaZ+i8LWctmdFtfp o+DA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=jut67/9BLZhhYa3TAMq3cFBx7bVgvwsTsa2z6yjRyPE=; b=G+/lQQgQK68YBc8ChTgBaDqO/JDf8o9abSV9zEkZrqWKkcDGG0YZGu/iOheJleuPRv 92sTc+1RVqPsp505990nKy9Ugf1T2LUsH2q72t2O8bJhhwEaaoHcg27mV9XvyO+ujSMw yArBOVvgDQ0SpfTtY+JZb/KyXb5CDjEIFmWA1Wq9orNi8Lilf9lJR9cwHRgEKZ2b6jjd vy3OK++Dr6jX4yom+NS/1fhKvBEv/6bgNPCqDuuYGAw+HOO37Ie6ekXsZwq45XmtZ9ZY drxbJw1SaMSS74k2pJFtDpFolv3DoG5kqxquOjeDvdVFeRtrMbYXJ/b+Dsc6lRd87rhL bhaA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dr12-20020a170907720c00b0078dcf17c084si12079532ejc.728.2022.12.05.10.58.57; Mon, 05 Dec 2022 10:59:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232762AbiLES4v (ORCPT + 99 others); Mon, 5 Dec 2022 13:56:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233496AbiLES4e (ORCPT ); Mon, 5 Dec 2022 13:56:34 -0500 Received: from cloudserver094114.home.pl (cloudserver094114.home.pl [79.96.170.134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B10182228F; Mon, 5 Dec 2022 10:56:17 -0800 (PST) Received: from localhost (127.0.0.1) (HELO v370.home.net.pl) by /usr/run/smtp (/usr/run/postfix/private/idea_relay_lmtp) via UNIX with SMTP (IdeaSmtpServer 5.1.0) id 9598059e2c2966bd; Mon, 5 Dec 2022 19:56:16 +0100 Received: from kreacher.localnet (unknown [213.134.188.181]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by v370.home.net.pl (Postfix) with ESMTPSA id 7DF5A2801DDF; Mon, 5 Dec 2022 19:56:15 +0100 (CET) Authentication-Results: v370.home.net.pl; dmarc=none (p=none dis=none) header.from=rjwysocki.net Authentication-Results: v370.home.net.pl; spf=fail smtp.mailfrom=rjwysocki.net From: "Rafael J. Wysocki" To: Linux ACPI Cc: LKML , Linux PM , Zhang Rui , Srinivas Pandruvada Subject: [PATCH] ACPI: thermal: Adjust critical.flags.valid check Date: Mon, 05 Dec 2022 19:56:14 +0100 Message-ID: <5883789.lOV4Wx5bFT@kreacher> MIME-Version: 1.0 X-CLIENT-IP: 213.134.188.181 X-CLIENT-HOSTNAME: 213.134.188.181 X-VADE-SPAMSTATE: clean X-VADE-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrudeggdduudelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecujffqoffgrffnpdggtffipffknecuuegrihhlohhuthemucduhedtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufffkfgggfgtsehtufertddttdejnecuhfhrohhmpedftfgrfhgrvghlucflrdcuhgihshhotghkihdfuceorhhjfiesrhhjfiihshhotghkihdrnhgvtheqnecuggftrfgrthhtvghrnhepffffffekgfehheffleetieevfeefvefhleetjedvvdeijeejledvieehueevueffnecukfhppedvudefrddufeegrddukeekrddukedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepvddufedrudefgedrudekkedrudekuddphhgvlhhopehkrhgvrggthhgvrhdrlhhotggrlhhnvghtpdhmrghilhhfrhhomhepfdftrghfrggvlhculfdrucghhihsohgtkhhifdcuoehrjhifsehrjhifhihsohgtkhhirdhnvghtqedpnhgspghrtghpthhtohephedprhgtphhtthhopehlihhnuhigqdgrtghpihesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopehlihhnuhigqdhpmhesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopehruhhirdiihhgrnhhgsehinhhtvghlrdgtohhmpdhrtghpthhtohep shhrihhnihhvrghsrdhprghnughruhhvrggurgeslhhinhhugidrihhnthgvlhdrtghomh X-DCC--Metrics: v370.home.net.pl 1024; Body=5 Fuz1=5 Fuz2=5 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751401637911163572?= X-GMAIL-MSGID: =?utf-8?q?1751401637911163572?= From: Rafael J. Wysocki It is not necessary to compare critical.flags.valid to 1 in acpi_thermal_trips_update() and doing so is also inconsistent with other similar checks in that code, so simply check if the flag is not 0 instead. No expected functional impact. Signed-off-by: Rafael J. Wysocki --- drivers/acpi/thermal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-pm/drivers/acpi/thermal.c =================================================================== --- linux-pm.orig/drivers/acpi/thermal.c +++ linux-pm/drivers/acpi/thermal.c @@ -291,7 +291,7 @@ static int acpi_thermal_trips_update(str "Found critical threshold [%lu]\n", tz->trips.critical.temperature); } - if (tz->trips.critical.flags.valid == 1) { + if (tz->trips.critical.flags.valid) { if (crt == -1) { tz->trips.critical.flags.valid = 0; } else if (crt > 0) {