From patchwork Mon Dec 5 09:19:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: ye.xingchen@zte.com.cn X-Patchwork-Id: 29620 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2153672wrr; Mon, 5 Dec 2022 01:49:10 -0800 (PST) X-Google-Smtp-Source: AA0mqf4EmbGirQSlBj/TUpCKrdnHW+6d9JTpsa3ZxaZiP+2qYKvVxrJh0RIyds/oFjoARNXWU+Xr X-Received: by 2002:a63:5d58:0:b0:476:ffc7:f7b with SMTP id o24-20020a635d58000000b00476ffc70f7bmr56406375pgm.271.1670233750205; Mon, 05 Dec 2022 01:49:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670233750; cv=none; d=google.com; s=arc-20160816; b=Ixxty8wzyMzqsha1uk3nsV04FXobmS9JIwOOgmxl6urxwFA9MKJ/TXf5S3DSIqQbrQ EwvaRDec7dVCXNDa1I4DlwEIjJ+8liCfz9gjVI4GZlXQUL6yQj2W5BzwklCUKm13V/lN Z6NC0lZbKpMUXuMh0VqFCmEgdfroZCLj+mazwOxShCDEFq5AX3xnBcJpSwv4RofRUJAI PDdvtF3nio1jux+8fONcZf0NqdL1l7QlklLavEt8ONxL/oOK5dbLHTBw/Y78WKpOXDmo J02rEmXI5Zak4CCLpwu2Ytn7nN1JSb503QCLPiYSPPOtM/e9p73U+ucxITTylvlk4Yoa P2wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:mime-version:message-id:date; bh=q3kleL7i0tyTRIwwkR8XLthZVnA3THJP+O57MVA8Ai0=; b=zhR6b8zfpZdipKwYxsgE9GJ3qVXAdOskNDpHdImlTmIYUQWgaQ5PDp3fdemOnOQFDt WgKDKO/FDwoXyq2oNOHuqmszqpCGDclqNH8sjmE+ZNuh1RjCKD47vKdJ5EBFnxu7q4+7 /eN0c0zom/4rCWFNbSjGcAEmSf53jioVYxb51SeyFkrX/0VmimfKjhXIXwKiQlXRJZAC WV7Uw9MCF5ye5zwhP3WYEoQuwfQOh8f3WbXUuU/DaBEF0NGQue6cixTDaL/v1ewRFz74 8/7Vdw8P8IAOkqVqCvesGS9INRRhChX0jn5VtbONrIFxN0NWC4pnBCS3c9uMsveDvQKH li8g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q34-20020a63f962000000b00473d2108701si13045504pgk.198.2022.12.05.01.48.57; Mon, 05 Dec 2022 01:49:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230400AbiLEJTz (ORCPT + 99 others); Mon, 5 Dec 2022 04:19:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230478AbiLEJTf (ORCPT ); Mon, 5 Dec 2022 04:19:35 -0500 Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [63.216.63.35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB34612D32; Mon, 5 Dec 2022 01:19:31 -0800 (PST) Received: from mse-fl2.zte.com.cn (unknown [10.5.228.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxhk.zte.com.cn (FangMail) with ESMTPS id 4NQdKZ1c5Sz4xVng; Mon, 5 Dec 2022 17:19:30 +0800 (CST) Received: from xaxapp01.zte.com.cn ([10.88.40.50]) by mse-fl2.zte.com.cn with SMTP id 2B59JEZ4022117; Mon, 5 Dec 2022 17:19:14 +0800 (+08) (envelope-from ye.xingchen@zte.com.cn) Received: from mapi (xaxapp01[null]) by mapi (Zmail) with MAPI id mid31; Mon, 5 Dec 2022 17:19:16 +0800 (CST) Date: Mon, 5 Dec 2022 17:19:16 +0800 (CST) X-Zmail-TransId: 2af9638db79465f1e0a1 X-Mailer: Zmail v1.0 Message-ID: <202212051719169589575@zte.com.cn> Mime-Version: 1.0 From: To: Cc: , , Subject: =?utf-8?q?=5BPATCH=5D_fs=3A_nfs=3A_sysfs=3A_use_sysfs=5Femit=28=29_?= =?utf-8?q?to_instead_of_scnprintf=28=29?= X-MAIL: mse-fl2.zte.com.cn 2B59JEZ4022117 X-Fangmail-Gw-Spam-Type: 0 X-FangMail-Miltered: at cgslv5.04-192.168.250.138.novalocal with ID 638DB7A2.000 by FangMail milter! X-FangMail-Envelope: 1670231970/4NQdKZ1c5Sz4xVng/638DB7A2.000/10.5.228.133/[10.5.228.133]/mse-fl2.zte.com.cn/ X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 638DB7A2.000/4NQdKZ1c5Sz4xVng X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751367024851297473?= X-GMAIL-MSGID: =?utf-8?q?1751367024851297473?= From: ye xingchen Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: ye xingchen --- fs/nfs/sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfs/sysfs.c b/fs/nfs/sysfs.c index 67a87800b3a9..0cbcd2dfa732 100644 --- a/fs/nfs/sysfs.c +++ b/fs/nfs/sysfs.c @@ -82,7 +82,7 @@ static ssize_t nfs_netns_identifier_show(struct kobject *kobj, ssize_t ret; rcu_read_lock(); - ret = scnprintf(buf, PAGE_SIZE, "%s\n", rcu_dereference(c->identifier)); + ret = sysfs_emit(buf, "%s\n", rcu_dereference(c->identifier)); rcu_read_unlock(); return ret; }