From patchwork Mon Dec 5 07:56:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: ye.xingchen@zte.com.cn X-Patchwork-Id: 29576 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2120171wrr; Mon, 5 Dec 2022 00:03:28 -0800 (PST) X-Google-Smtp-Source: AA0mqf5D+ib2Onn1REPhgWjFDH7nvRXWtZqmmh2Ird+S6o4uDNIYmVoRD5teVgbP6hF1NSUBQKI8 X-Received: by 2002:a17:906:383:b0:7be:bf2f:f7f with SMTP id b3-20020a170906038300b007bebf2f0f7fmr31709318eja.270.1670227408316; Mon, 05 Dec 2022 00:03:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670227408; cv=none; d=google.com; s=arc-20160816; b=g8gWzdhZLWNCv+ZMdCb+YXHgxuYWu+GGOEP+fKLplE+wnlP4ijdRiQu3ay39DwCE0Q dWHnFzdscplgtelGnW0mXKPjCPZAmmlpQ3PSBsHkfW3ScrQ5P45/ZHp6jhbG/pNb+HvS SB9wY+YLxeAJOmH3+mXf7BiJEnPvBVHCKbkc81JhzbkI+GVPLs9SMSsl5hda+2Db703r xv/3m3E95Btq/YJKDFLxx/QBbj7GT7nPpIHjrvbewyG63Et4yjHE5fL+0W8PN5f5jqeB +DaKlhOErF4V2PYvxsLMHRkp3wWyBcfZ+/ItEt/mbDnkKhwzpy5xj7dH79qnzm67ULtA /DlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:mime-version:message-id:date; bh=4QxLixnon4m4dMvla9EEHV20SloCxj2o+LhRvez7Zho=; b=aI0k1bio+bsz4Yi+fUG46A4D9hAB18K5SdX8fK9HKLd1gjNswaT7TQqlxlZk8x2Rry 0yQziIwBPhwIyvdefiaYbs3gP6tTwA7JmKf5wDp0GB7IvW7TyAT30e5e1g0ZUb3G6peR dIJTHwhCqKjGINV/hNAXBfIj2TMGIGNdluFdzvER+xsE9QkbQPfK4DFuee0IxfIii05T +PCZ0BJ9fH2jJI9qEUWxUh0Hzs5pN/CKJ6v8xR1svmeZpzMXHgIEy2mCjDX8hikFHpBk OAfS2UZbpmkVY5mifhn1KPGHFYex1iBu9OoUTKuHeRYV0uHnGZ3IAcvnThOqz17fIvGE uxfQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ji13-20020a170907980d00b007c098f5e5f4si13189446ejc.233.2022.12.05.00.03.02; Mon, 05 Dec 2022 00:03:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231805AbiLEH5G (ORCPT + 99 others); Mon, 5 Dec 2022 02:57:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231186AbiLEH5E (ORCPT ); Mon, 5 Dec 2022 02:57:04 -0500 Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [63.216.63.35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 139B51144B; Sun, 4 Dec 2022 23:57:01 -0800 (PST) Received: from mse-fl2.zte.com.cn (unknown [10.5.228.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxhk.zte.com.cn (FangMail) with ESMTPS id 4NQbVN46vkz5BNRf; Mon, 5 Dec 2022 15:57:00 +0800 (CST) Received: from xaxapp01.zte.com.cn ([10.88.40.50]) by mse-fl2.zte.com.cn with SMTP id 2B57ukZw098774; Mon, 5 Dec 2022 15:56:46 +0800 (+08) (envelope-from ye.xingchen@zte.com.cn) Received: from mapi (xaxapp01[null]) by mapi (Zmail) with MAPI id mid31; Mon, 5 Dec 2022 15:56:47 +0800 (CST) Date: Mon, 5 Dec 2022 15:56:47 +0800 (CST) X-Zmail-TransId: 2af9638da43fffffffff9e6764cf X-Mailer: Zmail v1.0 Message-ID: <202212051556478226726@zte.com.cn> Mime-Version: 1.0 From: To: , Cc: , , , , Subject: =?utf-8?q?=5BPATCH_linux-next=5D_backlight=3A_use_sysfs=5Femit=28?= =?utf-8?q?=29_to_instead_of_scnprintf=28=29?= X-MAIL: mse-fl2.zte.com.cn 2B57ukZw098774 X-Fangmail-Gw-Spam-Type: 0 X-FangMail-Miltered: at cgslv5.04-192.168.250.138.novalocal with ID 638DA44C.000 by FangMail milter! X-FangMail-Envelope: 1670227020/4NQbVN46vkz5BNRf/638DA44C.000/10.5.228.133/[10.5.228.133]/mse-fl2.zte.com.cn/ X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 638DA44C.000/4NQbVN46vkz5BNRf X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751360374546152840?= X-GMAIL-MSGID: =?utf-8?q?1751360374546152840?= From: ye xingchen Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: ye xingchen Reviewed-by: Daniel Thompson --- drivers/video/backlight/lm3533_bl.c | 10 +++++----- drivers/video/backlight/lp855x_bl.c | 4 ++-- drivers/video/backlight/lp8788_bl.c | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/video/backlight/lm3533_bl.c b/drivers/video/backlight/lm3533_bl.c index 1df1b6643c0b..5e2ce9285245 100644 --- a/drivers/video/backlight/lm3533_bl.c +++ b/drivers/video/backlight/lm3533_bl.c @@ -66,7 +66,7 @@ static ssize_t show_id(struct device *dev, { struct lm3533_bl *bl = dev_get_drvdata(dev); - return scnprintf(buf, PAGE_SIZE, "%d\n", bl->id); + return sysfs_emit(buf, "%d\n", bl->id); } static ssize_t show_als_channel(struct device *dev, @@ -75,7 +75,7 @@ static ssize_t show_als_channel(struct device *dev, struct lm3533_bl *bl = dev_get_drvdata(dev); unsigned channel = lm3533_bl_get_ctrlbank_id(bl); - return scnprintf(buf, PAGE_SIZE, "%u\n", channel); + return sysfs_emit(buf, "%u\n", channel); } static ssize_t show_als_en(struct device *dev, @@ -95,7 +95,7 @@ static ssize_t show_als_en(struct device *dev, mask = 1 << (2 * ctrlbank); enable = val & mask; - return scnprintf(buf, PAGE_SIZE, "%d\n", enable); + return sysfs_emit(buf, "%d\n", enable); } static ssize_t store_als_en(struct device *dev, @@ -147,7 +147,7 @@ static ssize_t show_linear(struct device *dev, else linear = 0; - return scnprintf(buf, PAGE_SIZE, "%x\n", linear); + return sysfs_emit(buf, "%x\n", linear); } static ssize_t store_linear(struct device *dev, @@ -190,7 +190,7 @@ static ssize_t show_pwm(struct device *dev, if (ret) return ret; - return scnprintf(buf, PAGE_SIZE, "%u\n", val); + return sysfs_emit(buf, "%u\n", val); } static ssize_t store_pwm(struct device *dev, diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c index bd0bdeae23a4..fafc1a9e76ef 100644 --- a/drivers/video/backlight/lp855x_bl.c +++ b/drivers/video/backlight/lp855x_bl.c @@ -293,7 +293,7 @@ static ssize_t lp855x_get_chip_id(struct device *dev, { struct lp855x *lp = dev_get_drvdata(dev); - return scnprintf(buf, PAGE_SIZE, "%s\n", lp->chipname); + return sysfs_emit(buf, "%s\n", lp->chipname); } static ssize_t lp855x_get_bl_ctl_mode(struct device *dev, @@ -307,7 +307,7 @@ static ssize_t lp855x_get_bl_ctl_mode(struct device *dev, else if (lp->mode == REGISTER_BASED) strmode = "register based"; - return scnprintf(buf, PAGE_SIZE, "%s\n", strmode); + return sysfs_emit(buf, "%s\n", strmode); } static DEVICE_ATTR(chip_id, S_IRUGO, lp855x_get_chip_id, NULL); diff --git a/drivers/video/backlight/lp8788_bl.c b/drivers/video/backlight/lp8788_bl.c index ba42f3fe0c73..00d79c0cfee9 100644 --- a/drivers/video/backlight/lp8788_bl.c +++ b/drivers/video/backlight/lp8788_bl.c @@ -240,7 +240,7 @@ static ssize_t lp8788_get_bl_ctl_mode(struct device *dev, else strmode = "Invalid mode"; - return scnprintf(buf, PAGE_SIZE, "%s\n", strmode); + return sysfs_emit(buf, "%s\n", strmode); } static DEVICE_ATTR(bl_ctl_mode, S_IRUGO, lp8788_get_bl_ctl_mode, NULL);