From patchwork Fri Dec 2 08:32:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: ye.xingchen@zte.com.cn X-Patchwork-Id: 28776 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp716492wrr; Fri, 2 Dec 2022 00:36:23 -0800 (PST) X-Google-Smtp-Source: AA0mqf4mvoHqb/tpzLA5NF2AspfgOMaxogjTtKJ23dP7w+vrl194YGVqRk6Tvgbkw5DZfwYL6M1d X-Received: by 2002:a17:902:b48f:b0:189:8b6:95f6 with SMTP id y15-20020a170902b48f00b0018908b695f6mr52092182plr.71.1669970183035; Fri, 02 Dec 2022 00:36:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669970183; cv=none; d=google.com; s=arc-20160816; b=0UPCLwMLzO506s8av4EQ8yHkvDdbTEkg26PMJHC/vRLzlYPwrT30Q66Fu68mQRps8y qcb570GkRTTSxfM1Wa5SgQPLl0F90BiVWhOZaXzv1vcxdEhzfrY8Z4bXykNitscjipLI RnrpaDAYyBVMxx7wZrgiplzaLnKCwURW8h6pEPE/pbELmVPFvmtf6HJsf2ZTP5EPgI54 Fg+/2vtPoA6ATG4pykimUbVz0I8zrYuujTFRjVe5ZEUt9kCNSd/pXNr8amDbOogP1BNf AFZ7j25TD1S3PRavICrr0YFsm3jegj609BIyd2X+y19QexkujPT+hTAvKVolk3yniHd0 P8dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:mime-version:message-id:date; bh=+JfXedFMse5B/esNMZSyYd+dHIYACB/cSnbH0iegTCc=; b=oqtiUzmd/7tvsprgepQJWQyE3cQU9Lwz3LXxBaM914CSCfZsoROGJbTO1+Q/YWbaKX F30TSR5PMf5CvBwmhcnmq6mo9IgnOat8wwcGfObBWj0tyWw0IbKQH/yWMgPHFk9lqioB PwuvoZ3p1pYxA0ji1PleBdDAv2H2Fh4DOwuEiCwQDG2dvX34UMdQx65C0DIfIsEe2bOo AOQLaF7JvfKO+E53vaTwHrQZD+iy9lnmvsA8uzrQv6a51IUo4TkeCSF1jC+hATVLe9At /FIh1n/3rh0wU0nzqdKxpvJHnhTxZrLRbCG2s7C83s9nkQQv/Rz/J44hIh4ccrdCm5MY b09Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q14-20020a170902f78e00b00186fb907e27si6623331pln.552.2022.12.02.00.36.09; Fri, 02 Dec 2022 00:36:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232988AbiLBIfD (ORCPT + 99 others); Fri, 2 Dec 2022 03:35:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231775AbiLBIeG (ORCPT ); Fri, 2 Dec 2022 03:34:06 -0500 Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [63.216.63.35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5DEDC2A; Fri, 2 Dec 2022 00:32:33 -0800 (PST) Received: from mse-fl1.zte.com.cn (unknown [10.5.228.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxhk.zte.com.cn (FangMail) with ESMTPS id 4NNmQk5jq3z5BNRf; Fri, 2 Dec 2022 16:32:30 +0800 (CST) Received: from xaxapp01.zte.com.cn ([10.88.40.50]) by mse-fl1.zte.com.cn with SMTP id 2B28WIvG038639; Fri, 2 Dec 2022 16:32:18 +0800 (+08) (envelope-from ye.xingchen@zte.com.cn) Received: from mapi (xaxapp01[null]) by mapi (Zmail) with MAPI id mid31; Fri, 2 Dec 2022 16:32:20 +0800 (CST) Date: Fri, 2 Dec 2022 16:32:20 +0800 (CST) X-Zmail-TransId: 2af96389b814fffffffffe9e185a X-Mailer: Zmail v1.0 Message-ID: <202212021632208664419@zte.com.cn> Mime-Version: 1.0 From: To: Cc: , , , , , , , , , , Subject: =?utf-8?q?=5BPATCH=5D_sfc=3A_use_sysfs=5Femit=28=29_to_instead_of_s?= =?utf-8?q?cnprintf=28=29?= X-MAIL: mse-fl1.zte.com.cn 2B28WIvG038639 X-Fangmail-Gw-Spam-Type: 0 X-FangMail-Miltered: at cgslv5.04-192.168.250.138.novalocal with ID 6389B81E.001 by FangMail milter! X-FangMail-Envelope: 1669969950/4NNmQk5jq3z5BNRf/6389B81E.001/10.5.228.132/[10.5.228.132]/mse-fl1.zte.com.cn/ X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 6389B81E.001/4NNmQk5jq3z5BNRf X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751090654506494357?= X-GMAIL-MSGID: =?utf-8?q?1751090654506494357?= From: ye xingchen Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: ye xingchen --- drivers/net/ethernet/sfc/efx_common.c | 2 +- drivers/net/ethernet/sfc/siena/efx_common.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/sfc/efx_common.c b/drivers/net/ethernet/sfc/efx_common.c index c2224e41a694..cc30524c2fe4 100644 --- a/drivers/net/ethernet/sfc/efx_common.c +++ b/drivers/net/ethernet/sfc/efx_common.c @@ -1164,7 +1164,7 @@ static ssize_t mcdi_logging_show(struct device *dev, struct efx_nic *efx = dev_get_drvdata(dev); struct efx_mcdi_iface *mcdi = efx_mcdi(efx); - return scnprintf(buf, PAGE_SIZE, "%d\n", mcdi->logging_enabled); + return sysfs_emit(buf, "%d\n", mcdi->logging_enabled); } static ssize_t mcdi_logging_store(struct device *dev, diff --git a/drivers/net/ethernet/sfc/siena/efx_common.c b/drivers/net/ethernet/sfc/siena/efx_common.c index 1fd396b00bfb..e4b294b8e9ac 100644 --- a/drivers/net/ethernet/sfc/siena/efx_common.c +++ b/drivers/net/ethernet/sfc/siena/efx_common.c @@ -1178,7 +1178,7 @@ static ssize_t mcdi_logging_show(struct device *dev, struct efx_nic *efx = dev_get_drvdata(dev); struct efx_mcdi_iface *mcdi = efx_mcdi(efx); - return scnprintf(buf, PAGE_SIZE, "%d\n", mcdi->logging_enabled); + return sysfs_emit(buf, "%d\n", mcdi->logging_enabled); } static ssize_t mcdi_logging_store(struct device *dev,