From patchwork Fri Dec 2 07:28:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: ye.xingchen@zte.com.cn X-Patchwork-Id: 28732 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp699748wrr; Thu, 1 Dec 2022 23:41:27 -0800 (PST) X-Google-Smtp-Source: AA0mqf68y7Oa8JY8pfJpAofr/ZmAZLPGYty7/7EOyHVfxhDOkvaefYI0Xtvn2SvIAmUUMp+VNsEG X-Received: by 2002:a17:90a:f18c:b0:219:756b:ec14 with SMTP id bv12-20020a17090af18c00b00219756bec14mr8250347pjb.30.1669966887453; Thu, 01 Dec 2022 23:41:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669966887; cv=none; d=google.com; s=arc-20160816; b=GAJmP3OHMM16Exd6OhCNojZutV+Brny2i36wU/U6LPQDUPzaTCjAxlFRVJ41AML1sz a+serKfBEmg8yeS8gvBZwRpm0bx/zgWEHYjsImJ0QL36YHyC3E0kEcl2Y6v5hQnBKnVl Ozog2GXTZESpMF+8eZ1EzimuWgvYIqEyrmLeo/Iy+f74an0GjkccYwP6vJ3+lT+RI3iw QnAyltOH+2FsfI8AUYP4nHStJfekytzDehxwJtyosyVe0KSHuk+zT2TUH0L8S4ST5y8Y JZBdPA1DnZdX6npTmGqaaG0v2PxIJJyCiPWj5Om8maJLBrs9p7DVU5DowWNfkIZ+ChS2 okCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:mime-version:message-id:date; bh=hiMTSwaJ14rtPLTM+wISxeHIPMaTfa87XbC9LitPiKQ=; b=kopadGYCXbOYllmylJyGlHjdIO0rwjhzNEL7Wsd0wabrxrAa3461XWKMUVVPkMao8f 73FCf9Ne6dgj2z2WVo/wdfnbjdjqGOJDD01NmMGn9NNQw93tlKV1jmPcEpC7JdoJlYcB xyKnU1Uzm0EVEUjNBwdAqdEiPuWecUMVwPeJfH6J4J9cyKIsaHdvvc+GYv8NfkNMWuPA XXe982tqCcTps8C+uLLo988xp0X1zIaxKUIzV8PzXvq1toMmqyWVOqbf17yDaX7wPgeP XBIkKEhUNdfy4Fz8oiLFRryUeHugKx7lLsaK3nRk+yYqkoqf4M4l3H4E5ejs3VlDnCii LbFw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ng4-20020a17090b1a8400b002130c156ee5si7367217pjb.152.2022.12.01.23.41.14; Thu, 01 Dec 2022 23:41:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232486AbiLBH2p (ORCPT + 99 others); Fri, 2 Dec 2022 02:28:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232151AbiLBH2n (ORCPT ); Fri, 2 Dec 2022 02:28:43 -0500 Received: from mxct.zte.com.cn (mxct.zte.com.cn [183.62.165.209]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12E318B181 for ; Thu, 1 Dec 2022 23:28:42 -0800 (PST) Received: from mse-fl1.zte.com.cn (unknown [10.5.228.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxct.zte.com.cn (FangMail) with ESMTPS id 4NNl143nJnz501Qh; Fri, 2 Dec 2022 15:28:40 +0800 (CST) Received: from xaxapp01.zte.com.cn ([10.88.40.50]) by mse-fl1.zte.com.cn with SMTP id 2B27SYq9055125; Fri, 2 Dec 2022 15:28:34 +0800 (+08) (envelope-from ye.xingchen@zte.com.cn) Received: from mapi (xaxapp01[null]) by mapi (Zmail) with MAPI id mid31; Fri, 2 Dec 2022 15:28:36 +0800 (CST) Date: Fri, 2 Dec 2022 15:28:36 +0800 (CST) X-Zmail-TransId: 2af96389a92462a65f16 X-Mailer: Zmail v1.0 Message-ID: <202212021528368292334@zte.com.cn> Mime-Version: 1.0 From: To: Cc: Subject: =?utf-8?q?=5BPATCH=5D_mfd=3A_use_sysfs=5Femit=28=29_to_instead_of_s?= =?utf-8?q?cnprintf=28=29?= X-MAIL: mse-fl1.zte.com.cn 2B27SYq9055125 X-Fangmail-Gw-Spam-Type: 0 X-FangMail-Miltered: at cgslv5.04-192.168.251.13.novalocal with ID 6389A928.000 by FangMail milter! X-FangMail-Envelope: 1669966120/4NNl143nJnz501Qh/6389A928.000/10.5.228.132/[10.5.228.132]/mse-fl1.zte.com.cn/ X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 6389A928.000/4NNl143nJnz501Qh X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751087199000765002?= X-GMAIL-MSGID: =?utf-8?q?1751087199000765002?= From: ye xingchen Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: ye xingchen --- drivers/mfd/kempld-core.c | 7 +++---- drivers/mfd/lm3533-core.c | 2 +- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/mfd/kempld-core.c b/drivers/mfd/kempld-core.c index bb26241c73bd..33c6cfe9fe42 100644 --- a/drivers/mfd/kempld-core.c +++ b/drivers/mfd/kempld-core.c @@ -349,7 +349,7 @@ static ssize_t pld_version_show(struct device *dev, { struct kempld_device_data *pld = dev_get_drvdata(dev); - return scnprintf(buf, PAGE_SIZE, "%s\n", pld->info.version); + return sysfs_emit(buf, "%s\n", pld->info.version); } static ssize_t pld_specification_show(struct device *dev, @@ -357,8 +357,7 @@ static ssize_t pld_specification_show(struct device *dev, { struct kempld_device_data *pld = dev_get_drvdata(dev); - return scnprintf(buf, PAGE_SIZE, "%d.%d\n", pld->info.spec_major, - pld->info.spec_minor); + return sysfs_emit(buf, "%d.%d\n", pld->info.spec_major, pld->info.spec_minor); } static ssize_t pld_type_show(struct device *dev, @@ -366,7 +365,7 @@ static ssize_t pld_type_show(struct device *dev, { struct kempld_device_data *pld = dev_get_drvdata(dev); - return scnprintf(buf, PAGE_SIZE, "%s\n", kempld_get_type_string(pld)); + return sysfs_emit(buf, "%s\n", kempld_get_type_string(pld)); } static DEVICE_ATTR_RO(pld_version); diff --git a/drivers/mfd/lm3533-core.c b/drivers/mfd/lm3533-core.c index be32ffc5af38..b353d93b0939 100644 --- a/drivers/mfd/lm3533-core.c +++ b/drivers/mfd/lm3533-core.c @@ -286,7 +286,7 @@ static ssize_t show_output(struct device *dev, val = (val & mask) >> shift; - return scnprintf(buf, PAGE_SIZE, "%u\n", val); + return sysfs_emit(buf, "%u\n", val); } static ssize_t store_output(struct device *dev,