From patchwork Fri Dec 2 07:04:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: ye.xingchen@zte.com.cn X-Patchwork-Id: 28728 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp690094wrr; Thu, 1 Dec 2022 23:12:16 -0800 (PST) X-Google-Smtp-Source: AA0mqf5FSZ8+3MXsd0uu6hFqV3huhKOdXrsKX9PiynTZr5OJIO+iIL5O3qQiW6AdttXGpleNTc8t X-Received: by 2002:aa7:c144:0:b0:46b:badf:882c with SMTP id r4-20020aa7c144000000b0046bbadf882cmr9266679edp.233.1669965135916; Thu, 01 Dec 2022 23:12:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669965135; cv=none; d=google.com; s=arc-20160816; b=m6O3i/f9ry01p6IwKfx/sCImDt4DTTBP5iOFe430gkDSGmIkal7bsD2NW51gVh+0Ht +qxNMA9RzS5X19MiQNeIBJAbztp+JhfxReO+qCzcL1yBkBFWtIz2vA6TGxuPX4ZUEbL7 Rzn491PCJFUZeCdRTxPULN5nh9uOhrag5PzZ1NHLevshC+pOGJjGiPisSbU962xhcsqP Fwj0vKgP7i5QTSJzxERJDw2i5huPsHGEV+hU4Exer/BAkaP5vX8Qg4O6pS6MrD7KZaPT 6uI9a+JgZanQ4vnisktoa/t4FQMTPyfFFUGKzv1oTzKmhM8CuVcq7Q/XPDXfGrG0W83G EK1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:mime-version:message-id:date; bh=pv+ET/BSPndJmBFIueW8Ma1hgq/M9LaBM2XtXk5tLE8=; b=AEg3K/Iq5D9rg2RB/0wzLN7KdGo1I4I556OlQZ35j33CDGEFGjTFrJQ/EdAU8bHznE XaOta62wxNEOmAkF/LycgdaXb0eumob4qZqN0LvMrgI3+Wpsf0i4QVGx2hbYEVZJ0Wz0 AJavavBz9Doqw6ns5KPNhRdqXzTDQ5dP+XbIo9vxOOmjoX/BbeiP29ag1/4cf2wv17JL WDDtnO6ITwaKp/Wanz27vbooqI7R0JLpYtjoyJYGiGBQfLqBdMtxXqhKmNJ3F6cPYDF/ ZRWOTnIBjGr/uGlAxNA/bCF0AQr6OpKZTMu60k6ohv61UOSmqJf8sX+eb9sz2K85NF2S bbSQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n11-20020a05640206cb00b0045d189ac612si5408845edy.402.2022.12.01.23.11.52; Thu, 01 Dec 2022 23:12:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232461AbiLBHEM (ORCPT + 99 others); Fri, 2 Dec 2022 02:04:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230163AbiLBHEL (ORCPT ); Fri, 2 Dec 2022 02:04:11 -0500 Received: from mxct.zte.com.cn (mxct.zte.com.cn [183.62.165.209]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFC4EBEE36; Thu, 1 Dec 2022 23:04:09 -0800 (PST) Received: from mse-fl1.zte.com.cn (unknown [10.5.228.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxct.zte.com.cn (FangMail) with ESMTPS id 4NNkSm1BnXz501Qh; Fri, 2 Dec 2022 15:04:08 +0800 (CST) Received: from xaxapp01.zte.com.cn ([10.88.40.50]) by mse-fl1.zte.com.cn with SMTP id 2B2743YH020599; Fri, 2 Dec 2022 15:04:04 +0800 (+08) (envelope-from ye.xingchen@zte.com.cn) Received: from mapi (xaxapp01[null]) by mapi (Zmail) with MAPI id mid31; Fri, 2 Dec 2022 15:04:06 +0800 (CST) Date: Fri, 2 Dec 2022 15:04:06 +0800 (CST) X-Zmail-TransId: 2af96389a36634a2bc70 X-Mailer: Zmail v1.0 Message-ID: <202212021504062431427@zte.com.cn> Mime-Version: 1.0 From: To: Cc: , , Subject: =?utf-8?q?=5BPATCH_v2=5D_Input=3A_rmi4=3A_use_sysfs=5Femit=28=29_to?= =?utf-8?q?_instead_of_scnprintf=28=29?= X-MAIL: mse-fl1.zte.com.cn 2B2743YH020599 X-Fangmail-Gw-Spam-Type: 0 X-FangMail-Miltered: at cgslv5.04-192.168.251.13.novalocal with ID 6389A368.000 by FangMail milter! X-FangMail-Envelope: 1669964648/4NNkSm1BnXz501Qh/6389A368.000/10.5.228.132/[10.5.228.132]/mse-fl1.zte.com.cn/ X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 6389A368.000/4NNkSm1BnXz501Qh X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751085362489451241?= X-GMAIL-MSGID: =?utf-8?q?1751085362489451241?= From: ye xingchen Replace the open-code with sysfs_emit() to simplify the code. Signed-off-by: ye xingchen --- v1 -> v2 Fix the code style. drivers/input/rmi4/rmi_f01.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/input/rmi4/rmi_f01.c b/drivers/input/rmi4/rmi_f01.c index d7603c50f864..29f3ba1599e8 100644 --- a/drivers/input/rmi4/rmi_f01.c +++ b/drivers/input/rmi4/rmi_f01.c @@ -267,8 +267,7 @@ static ssize_t rmi_driver_manufacturer_id_show(struct device *dev, struct rmi_driver_data *data = dev_get_drvdata(dev); struct f01_data *f01 = dev_get_drvdata(&data->f01_container->dev); - return scnprintf(buf, PAGE_SIZE, "%d\n", - f01->properties.manufacturer_id); + return sysfs_emit(buf, "%d\n", f01->properties.manufacturer_id); } static DEVICE_ATTR(manufacturer_id, 0444, @@ -280,7 +279,7 @@ static ssize_t rmi_driver_dom_show(struct device *dev, struct rmi_driver_data *data = dev_get_drvdata(dev); struct f01_data *f01 = dev_get_drvdata(&data->f01_container->dev); - return scnprintf(buf, PAGE_SIZE, "%s\n", f01->properties.dom); + return sysfs_emit(buf, "%s\n", f01->properties.dom); } static DEVICE_ATTR(date_of_manufacture, 0444, rmi_driver_dom_show, NULL); @@ -292,7 +291,7 @@ static ssize_t rmi_driver_product_id_show(struct device *dev, struct rmi_driver_data *data = dev_get_drvdata(dev); struct f01_data *f01 = dev_get_drvdata(&data->f01_container->dev); - return scnprintf(buf, PAGE_SIZE, "%s\n", f01->properties.product_id); + return sysfs_emit(buf, "%s\n", f01->properties.product_id); } static DEVICE_ATTR(product_id, 0444, rmi_driver_product_id_show, NULL); @@ -304,7 +303,7 @@ static ssize_t rmi_driver_firmware_id_show(struct device *dev, struct rmi_driver_data *data = dev_get_drvdata(dev); struct f01_data *f01 = dev_get_drvdata(&data->f01_container->dev); - return scnprintf(buf, PAGE_SIZE, "%d\n", f01->properties.firmware_id); + return sysfs_emit(buf, "%d\n", f01->properties.firmware_id); } static DEVICE_ATTR(firmware_id, 0444, rmi_driver_firmware_id_show, NULL); @@ -318,8 +317,8 @@ static ssize_t rmi_driver_package_id_show(struct device *dev, u32 package_id = f01->properties.package_id; - return scnprintf(buf, PAGE_SIZE, "%04x.%04x\n", - package_id & 0xffff, (package_id >> 16) & 0xffff); + return sysfs_emit(buf, "%04x.%04x\n", + package_id & 0xffff, (package_id >> 16) & 0xffff); } static DEVICE_ATTR(package_id, 0444, rmi_driver_package_id_show, NULL);