From patchwork Thu Dec 1 19:30:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naresh Solanki X-Patchwork-Id: 28518 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp447121wrr; Thu, 1 Dec 2022 11:32:22 -0800 (PST) X-Google-Smtp-Source: AA0mqf72y+rHfXD3WVkg3odg7pobSxRemHZUm2OT3jZ5+7G746TiBKnUMlNMkLILMYPfESGBCmY8 X-Received: by 2002:a05:6402:1117:b0:46b:6da7:e8a9 with SMTP id u23-20020a056402111700b0046b6da7e8a9mr13630974edv.401.1669923142550; Thu, 01 Dec 2022 11:32:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669923142; cv=none; d=google.com; s=arc-20160816; b=PXESUuUiG/oWla97Jo93QP/7fnNG5XphUrJvc2OdJu3rVbZ1+Qf7rrAfZ1BMn85uzM X4+aD48wYioHEvJyWVjpS8bYhxQOqBwCcVa2kKaprCdZqj5Dcbtg9Dz0S3kMQWKijdhc yte3BsZtQCoudSW30RT5psMuUNQybe9GBK6nR5iA3JT4dmUP7F/FGbZb31H6Ir5TpKkA jU0g7EL/LWsTVtX7gkT+UyQjXNXPomSvdcu/GpjXGMwcGhDCcd2aVNe61WqP+8Wn0a1j zvBIRS7DZihzjtDm23vs9H34m4lXO2eh3TgO/AWrYs6DbPUCmYHvmESZfhRRHTsA5RAi gkLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=9fKvZImztyAGYKm8N5WHEv0DzFDUrZgSaslqn8pXCp4=; b=TH4NoaMp7lCohhzsjvXVwKRSQyJ58OjDihaBJd2LtR0Bkfo8cyBH5P3tp0xKqJU8e0 rPjtxApsIZp5Cn5vbjYAVukdSJRgrjwaVrUMs2zfKTa9boJXHKLng55l3iyQjflKkGPm iRoOs4aDRTBj/3dBDfniSEUq6ABxsSebtcV1s4TNQ9NZmjd3xXuTMubfDSy88/2KDb2q NGr2QfJPcoJPe4B6Y589Nq+AEZ5Sz6h5bddeOS9ghSQxJ+yurfSSrsRoWgyY0fKEsGsK pDBkteXAVFj9fW6qeSuvU3BbQP4TEfozOXd56vaiE2hx1YGu0006h0KQTcW5/+CsSIGW h/XQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b=EnlxFW2o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s21-20020a056402521500b00457263f9ee0si4402777edd.93.2022.12.01.11.31.57; Thu, 01 Dec 2022 11:32:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b=EnlxFW2o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231273AbiLATbT (ORCPT + 99 others); Thu, 1 Dec 2022 14:31:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230483AbiLATak (ORCPT ); Thu, 1 Dec 2022 14:30:40 -0500 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 453BFC8D25 for ; Thu, 1 Dec 2022 11:30:32 -0800 (PST) Received: by mail-ej1-x62f.google.com with SMTP id e27so6576032ejc.12 for ; Thu, 01 Dec 2022 11:30:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=9fKvZImztyAGYKm8N5WHEv0DzFDUrZgSaslqn8pXCp4=; b=EnlxFW2of+UDwHxryW+kMpzqGXuxTDwAoNmcTHslWecr9SBkZJdHuMHWFI08pKCaug 1vntP/acflKa9IY5WkpTy7G5Mcv2izHZGHe6BPpGPSxCG/+eyzE8f3wJEoXjNZ/QsSr+ VEtbfeSCQYFJwxPkqbb8gOICofHTknEtCusDwm6YpYDoy48e/MInC2BPOF4oNQ8dSvzw SG+q4W/qWaSoqaadUcg51bK6Ba1y6+PtskkmmZ1ujxihHD8Q42mMektfENTMx9PrMyUk cBgMwyLOauec7NlPc7jnpoUJQr7RUytiE+/uaBM0AN1VRsjJfzqgeW2qj0SSd8xBePRn pv7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9fKvZImztyAGYKm8N5WHEv0DzFDUrZgSaslqn8pXCp4=; b=FPc6x7kOYrwKov7sSQL+jQK85/TQ/usgARgdjN+i/Jor4RCfjx+BKXc9z5ewHg2ofj RC9FitYwcZbRvQ/CLrPxJDjIUqzmgScAA8jdKC/TwMEl+xGJHDOImwPOwrk8X6XmObV2 A4aRJqYBRzeVhaPtwJKmOjhnxehSLyMbWlIVctmdcT5XigstZp/LGcqhp8NfUKHZcQRp j62s6pVkkbP16k/D4+l7jUxswdddv5O/1hSxQaTo9LGSHYiQc+t25lvxchOpcpZqVx89 i11OZL3h14vC7s7hZomwcozQCqjn1MAsMdahG3trCZKE+TeiijBbACPWDxyDoCWAmkOB AjdA== X-Gm-Message-State: ANoB5plqwqn4kuuZdhaIpeDo12x21iOZwfLwGUSXgY49bkMF1X2moRSD 5tIF4ff0cWcJl0HpaVSdg4LrPg== X-Received: by 2002:a17:906:f8cc:b0:7ad:92fa:589e with SMTP id lh12-20020a170906f8cc00b007ad92fa589emr40140822ejb.668.1669923030836; Thu, 01 Dec 2022 11:30:30 -0800 (PST) Received: from stroh80.sec.9e.network (ip-078-094-000-051.um19.pools.vodafone-ip.de. [78.94.0.51]) by smtp.gmail.com with ESMTPSA id g15-20020aa7c84f000000b004619f024864sm2054110edt.81.2022.12.01.11.30.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Dec 2022 11:30:30 -0800 (PST) From: Naresh Solanki X-Google-Original-From: Naresh Solanki To: devicetree@vger.kernel.org, Guenter Roeck , Jean Delvare , Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, Patrick Rudolph , Naresh Solanki Subject: [PATCH v5 1/5] hwmon: (pmbus/core): Add rdev in pmbus_data struct Date: Thu, 1 Dec 2022 20:30:20 +0100 Message-Id: <20221201193025.1584365-1-Naresh.Solanki@9elements.com> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751040235029339764?= X-GMAIL-MSGID: =?utf-8?q?1751041329101989274?= Add regulator device in pmbus_data & initialize the same during PMBus regulator register. Signed-off-by: Naresh Solanki --- Change in V5: - Fix error check for rdev --- drivers/hwmon/pmbus/pmbus_core.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) base-commit: 9494c53e1389b120ba461899207ac8a3aab2632c diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c index 95e95783972a..a95f998ca247 100644 --- a/drivers/hwmon/pmbus/pmbus_core.c +++ b/drivers/hwmon/pmbus/pmbus_core.c @@ -81,6 +81,7 @@ struct pmbus_label { struct pmbus_data { struct device *dev; struct device *hwmon_dev; + struct regulator_dev **rdevs; u32 flags; /* from platform data */ @@ -3050,9 +3051,13 @@ static int pmbus_regulator_register(struct pmbus_data *data) struct device *dev = data->dev; const struct pmbus_driver_info *info = data->info; const struct pmbus_platform_data *pdata = dev_get_platdata(dev); - struct regulator_dev *rdev; int i; + data->rdevs = devm_kzalloc(dev, sizeof(struct regulator_dev *) * info->num_regulators, + GFP_KERNEL); + if (!data->rdevs) + return -ENOMEM; + for (i = 0; i < info->num_regulators; i++) { struct regulator_config config = { }; @@ -3062,10 +3067,10 @@ static int pmbus_regulator_register(struct pmbus_data *data) if (pdata && pdata->reg_init_data) config.init_data = &pdata->reg_init_data[i]; - rdev = devm_regulator_register(dev, &info->reg_desc[i], + data->rdevs[i] = devm_regulator_register(dev, &info->reg_desc[i], &config); - if (IS_ERR(rdev)) - return dev_err_probe(dev, PTR_ERR(rdev), + if (IS_ERR(data->rdevs[i])) + return dev_err_probe(dev, PTR_ERR(data->rdevs[i]), "Failed to register %s regulator\n", info->reg_desc[i].name); } From patchwork Thu Dec 1 19:30:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naresh Solanki X-Patchwork-Id: 28520 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp447290wrr; Thu, 1 Dec 2022 11:32:45 -0800 (PST) X-Google-Smtp-Source: AA0mqf6+OedpE9a5ucVkIL2XLly3NdRamGPq1O1SDeTOuAN8HALc11vfBCMkiJPtsawjHE9XN149 X-Received: by 2002:a17:906:2594:b0:7c0:8d06:33f8 with SMTP id m20-20020a170906259400b007c08d0633f8mr11100154ejb.150.1669923165300; Thu, 01 Dec 2022 11:32:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669923165; cv=none; d=google.com; s=arc-20160816; b=zMjNlsCfyoUhwh/Qmt9RktX7q/7/Utgy09VcjjbpRnrlGiRJgOtRhu4fkQRCO3HwBH F+qPISvxB23/pCfP1/72hhxDuoyZp2BsHarBx1ifTbvYCpnxbqWWnAtzOJDw6SzuY39v igQFKfbaeHxBC56lRHzFltoUHC2sqr6CX2FSsSnf/aM2X5SOTttnSc9ngLHzdV6GchD2 KiDTpc+H0nXp1gT7qlLDPuLpIIa82UbLUwE0MzJiFhp+PAK5jQzslBDr/ewoMPNYEeUG fPlqs9kMPscvYpbG4qdJyjZgOxz7ge9vhMZCKFMBx5lcqD9ezmNOep0Y1Xxy3GL7YXma m3Iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=O0CtKLNMhWrok1R+TOMY2EUaClmC34YMD2M3K60n2nM=; b=mvtavCvWNCZzer3gCn4gRJH4/fbp2PnFrvJ2QLvqRK6ib5dKr+m/GQEJhrC0ZW1ski olXaDi0I6TQHg7tLX+fplUbfQmarQYVy6zV6zzNz15y3OhLEY7RFAZIYpL4yPl6InPow Ra1twIMhDoJ4Ct0cZu8u8agZVuAY2x6SaZX/9TnyZGj/LWNNbRBfdTUVGVoCSd5T1khM WbfjRduXcn9NSpQlvD7fEYQfZwZGx1O5Moej2Esf4+VuJ8YJdPANDUKRGdRJH9S/Ls79 1VgVDjkR1Yb/TQFpBSA/UaTK6YI9JqGhHkLwe5OmLe29qn+EW+RjnfXObOwzlKBQ587n BTvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b=F1pPgi7U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nb31-20020a1709071c9f00b0078db6f488c2si4929718ejc.56.2022.12.01.11.32.21; Thu, 01 Dec 2022 11:32:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b=F1pPgi7U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231162AbiLATbW (ORCPT + 99 others); Thu, 1 Dec 2022 14:31:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231142AbiLATak (ORCPT ); Thu, 1 Dec 2022 14:30:40 -0500 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80024C8D3E for ; Thu, 1 Dec 2022 11:30:33 -0800 (PST) Received: by mail-ej1-x634.google.com with SMTP id vv4so6627737ejc.2 for ; Thu, 01 Dec 2022 11:30:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=O0CtKLNMhWrok1R+TOMY2EUaClmC34YMD2M3K60n2nM=; b=F1pPgi7Uhwoarw955/oDAtxbz42b53K8lIGgjZVnemqfuG8jAOEG9F7KdRks0/ic/b +O4s03AAjPn2XY3Y3O5J7cr/rSoFkagood2sy+VxJL6q3mkZvsai33XWw2E22DQ6sYnr QL8BCkS2f3EInBlKGTL47tCTpbDWMuiSpaSZHR5DhOM4W9c4BcNiIhcD45FWYNtwLEU9 02U1UFVZRanSGlxr57rvmGcoMCOmsNfPw9BtwJJUcoZWdrpJhq4KOKHv4vod5903v80s 67wq2bxcM9RryATSqS2XxwZCeNUYVJCxKwqt4ZsKmO3Gxf2ubUw5d6gqLYJ2klyhMt6+ ivhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=O0CtKLNMhWrok1R+TOMY2EUaClmC34YMD2M3K60n2nM=; b=dLKov846+DOjP6PXavLzGZKF8bs98WnebKdGD6CLg98u4NGuAk7YQUozWN52dLzliz ajVlI2EuPK2HxGyDsQvigLZQsOS+P8l/Zc2k8Gvkf5JhEt84Bq2u09iO7UEUF8UKp2M3 EmHf5VYiRIskby4YEYdyLIld9mlVSAVOw/9d4FrkEbpHzFcq1Czk+dbAs6ABvHJn7x+p XRX7rkS8gdOWEUp955nFY7Yg+MnjnlhB+QdCbmwu5Wgn+gWUkkwLCRAplVAmazVb9XVU zLLLti2hgpTtAithPfVfV9r2UlJDVtVp6H+/v7i+A/yOej9q3O7mE9jPgVjB/UKBSUQR 3yRQ== X-Gm-Message-State: ANoB5pnu90vAjOEr/UCOkSLbQsVNKUaF/3NANZQHzM1AwxMn9g2rXqm4 uEvcT2FJqePYIJPf59mbjBPEHwC8RJWPtv+u X-Received: by 2002:a17:906:9c89:b0:7c0:7ab4:3715 with SMTP id fj9-20020a1709069c8900b007c07ab43715mr8634863ejc.343.1669923031914; Thu, 01 Dec 2022 11:30:31 -0800 (PST) Received: from stroh80.sec.9e.network (ip-078-094-000-051.um19.pools.vodafone-ip.de. [78.94.0.51]) by smtp.gmail.com with ESMTPSA id g15-20020aa7c84f000000b004619f024864sm2054110edt.81.2022.12.01.11.30.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Dec 2022 11:30:31 -0800 (PST) From: Naresh Solanki X-Google-Original-From: Naresh Solanki To: devicetree@vger.kernel.org, Guenter Roeck , Jean Delvare , Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, Patrick Rudolph , Naresh Solanki Subject: [PATCH v5 2/5] hwmon: (pmbus/core): Add interrupt support Date: Thu, 1 Dec 2022 20:30:21 +0100 Message-Id: <20221201193025.1584365-2-Naresh.Solanki@9elements.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221201193025.1584365-1-Naresh.Solanki@9elements.com> References: <20221201193025.1584365-1-Naresh.Solanki@9elements.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751041353000564112?= X-GMAIL-MSGID: =?utf-8?q?1751041353000564112?= From: Patrick Rudolph Implement PMBUS irq handler. Signed-off-by: Patrick Rudolph Signed-off-by: Naresh Solanki --- drivers/hwmon/pmbus/pmbus.h | 2 +- drivers/hwmon/pmbus/pmbus_core.c | 89 ++++++++++++++++++++++++++++++++ 2 files changed, 90 insertions(+), 1 deletion(-) diff --git a/drivers/hwmon/pmbus/pmbus.h b/drivers/hwmon/pmbus/pmbus.h index 10fb17879f8e..6b2e6cf93b19 100644 --- a/drivers/hwmon/pmbus/pmbus.h +++ b/drivers/hwmon/pmbus/pmbus.h @@ -26,7 +26,7 @@ enum pmbus_regs { PMBUS_CAPABILITY = 0x19, PMBUS_QUERY = 0x1A, - + PMBUS_SMBALERT_MASK = 0x1B, PMBUS_VOUT_MODE = 0x20, PMBUS_VOUT_COMMAND = 0x21, PMBUS_VOUT_TRIM = 0x22, diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c index a95f998ca247..6a3a3fd59b8e 100644 --- a/drivers/hwmon/pmbus/pmbus_core.c +++ b/drivers/hwmon/pmbus/pmbus_core.c @@ -3077,11 +3077,94 @@ static int pmbus_regulator_register(struct pmbus_data *data) return 0; } + +static int pmbus_write_smbalert_mask(struct i2c_client *client, u8 page, u8 reg, u8 val) +{ + return pmbus_write_word_data(client, page, PMBUS_SMBALERT_MASK, reg | (val << 8)); +} + +static irqreturn_t pmbus_fault_handler(int irq, void *pdata) +{ + struct pmbus_data *data = pdata; + struct i2c_client *client = to_i2c_client(data->dev); + int i, status; + u8 page; + + for (i = 0; i < data->info->num_regulators; i++) { + + if (!data->rdevs[i]) + continue; + + page = rdev_get_id(data->rdevs[i]); + mutex_lock(&data->update_lock); + status = pmbus_read_status_word(client, page); + if (status < 0) { + mutex_unlock(&data->update_lock); + return status; + } + + if (status & ~(PB_STATUS_OFF | PB_STATUS_BUSY | PB_STATUS_POWER_GOOD_N)) + pmbus_clear_fault_page(client, page); + + mutex_unlock(&data->update_lock); + } + + return IRQ_HANDLED; +} + +static int pmbus_irq_setup(struct i2c_client *client, struct pmbus_data *data) +{ + struct device *dev = &client->dev; + const struct pmbus_regulator_status_category *cat; + const struct pmbus_regulator_status_assoc *bit; + int i, j, err, ret, func; + u8 mask; + + for (i = 0; i < data->info->pages; i++) { + func = data->info->func[i]; + + for (j = 0; j < ARRAY_SIZE(pmbus_regulator_flag_map); j++) { + cat = &pmbus_regulator_flag_map[j]; + if (!(func & cat->func)) + continue; + mask = 0; + for (bit = cat->bits; bit->pflag; bit++) + mask |= bit->pflag; + + err = pmbus_write_smbalert_mask(client, i, cat->reg, ~mask); + if (err) + dev_err(dev, "Failed to set smbalert for reg 0x%02x\n", cat->reg); + } + + pmbus_write_smbalert_mask(client, i, PMBUS_STATUS_CML, 0xff); + pmbus_write_smbalert_mask(client, i, PMBUS_STATUS_OTHER, 0xff); + pmbus_write_smbalert_mask(client, i, PMBUS_STATUS_MFR_SPECIFIC, 0xff); + if (data->info->func[i] & PMBUS_HAVE_FAN12) + pmbus_write_smbalert_mask(client, i, PMBUS_STATUS_FAN_12, 0xff); + if (data->info->func[i] & PMBUS_HAVE_FAN34) + pmbus_write_smbalert_mask(client, i, PMBUS_STATUS_FAN_34, 0xff); + } + + /* Register notifiers - can fail if IRQ is not given */ + ret = devm_request_threaded_irq(dev, client->irq, NULL, pmbus_fault_handler, + 0, "pmbus-irq", data); + if (ret) { + dev_warn(dev, "IRQ disabled %d\n", ret); + return ret; + } + + return 0; +} + #else static int pmbus_regulator_register(struct pmbus_data *data) { return 0; } +static int pmbus_irq_setup(struct i2c_client *client, struct pmbus_data *data) +{ + return 0; +} #endif static struct dentry *pmbus_debugfs_dir; /* pmbus debugfs directory */ @@ -3446,6 +3529,12 @@ int pmbus_do_probe(struct i2c_client *client, struct pmbus_driver_info *info) if (ret) return ret; + if (client->irq > 0) { + ret = pmbus_irq_setup(client, data); + if (ret) + return ret; + } + ret = pmbus_init_debugfs(client, data); if (ret) dev_warn(dev, "Failed to register debugfs\n"); From patchwork Thu Dec 1 19:30:22 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naresh Solanki X-Patchwork-Id: 28522 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp447503wrr; Thu, 1 Dec 2022 11:33:19 -0800 (PST) X-Google-Smtp-Source: AA0mqf5KTbzjgyzx6v35DLvoA2eRiM7nQE6zWviMuPrSO/Ao/3EtrSS56+b5KMXd8ixvUUFElHSb X-Received: by 2002:a17:906:1b4a:b0:7c0:a9de:18dc with SMTP id p10-20020a1709061b4a00b007c0a9de18dcmr5210247ejg.15.1669923198820; Thu, 01 Dec 2022 11:33:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669923198; cv=none; d=google.com; s=arc-20160816; b=xj78gfO+izS/NxWRzwvVciY6l39WjWpFc60JM4uHWCtctbiFMV5Mffv2rvwayFiYEz DnkJtTW9fLJuq0JTZrQpnOFhFYG7EFGyge856QBr6vqKY9/9g4Io85ce1jrKNiyOBdmq fA8RlKqIYNjIbjVeCNk0kb/CZaTTnCX0PKcOe17BipT9McC/0Vf5KmxkXg3EedOwBn3K zGGZrktgysdqSCvll+EdsxouovgPFKtWWtHozwrr+PjlnbeVJQVpq2uQzmXPO1US20Yz +fzdfXB+I4cViMrT4Y7c4rTU9TKcwJbP4hXLpW8qXLKrMMneHwLTD0BJYU1nJDMXHrsx H2Bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=/RnyrrQe9Eok5DqIvUFEy0a61qYm6BHFyKDyCC1oYjg=; b=s6WtgHyKGcesMP6kjwva5RlcLN78CXASIo7xnnwJExOq309kbjLghj66GTzfOyaKX9 FIqvng5dVPTQWEE2klTl02Ty/+/VtesCIAHLbTG21T/cl+wEijgJ+PM32P3XtDM5VfCe 4Qiedqarf12a034JQnbvFbwAOvTFRXQsC5AutiXH5vJ44KjbGPdE7izb5Gv6PKpQe+kP g+QDehql+uTV6pzsveD+xSMhg2VQfyRiwjNGDPlIkV/kqS8/bIetnHyiQuyf+BcIVUY4 m05cLKlx1XVVPI75xrGmAQa6ln+3hw2Fou0DWaWn1BrNChWmV2zSLN3bNDYuitBchgg2 eBSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b=e+bLOFon; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sc14-20020a1709078a0e00b007c0905bab0asi1845653ejc.311.2022.12.01.11.32.55; Thu, 01 Dec 2022 11:33:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b=e+bLOFon; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231296AbiLATb0 (ORCPT + 99 others); Thu, 1 Dec 2022 14:31:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230339AbiLATal (ORCPT ); Thu, 1 Dec 2022 14:30:41 -0500 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 442E5CA16D for ; Thu, 1 Dec 2022 11:30:34 -0800 (PST) Received: by mail-ej1-x62e.google.com with SMTP id ml11so6617503ejb.6 for ; Thu, 01 Dec 2022 11:30:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/RnyrrQe9Eok5DqIvUFEy0a61qYm6BHFyKDyCC1oYjg=; b=e+bLOFonetP2HdOnP8n/c6Gm+QqVqCobaEemCltMt4hyrSppEym5opqSZWjSrB98HO jEZSTNd1YtCWlfMCrTm9ARtqrrvc8U7tu7lgiCT5ITLd0eCw74M+5EZ4wjCrq4EStIfQ TGJrUEkZhbfttV255uU/UK3mkt2OGcnopFdjtpdJhhwFSVWIEfglhbUCtanOPQ/scqG3 qoSb3KhFWAUMf9O7xRq3LbeARzzNY2C8jZBkuVOfkgAIijxNZz/VHLk3oNqOfTy1t37B mTsWU+Kq2LJyrU5bn/YGN7QqAkSYspqx9ps43Yq5z0ZVQnHB4KLB22ch/wV0Cpj4iaan D3fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/RnyrrQe9Eok5DqIvUFEy0a61qYm6BHFyKDyCC1oYjg=; b=x1oID3WX5VbF/yps6+JnEO+LjTVJEwvmPq/xvgnS7EQy7N+QHB1ZjIsp8GKeBknIvY wj3Uzi1UTAVoHT/TNLh6G63z6whELZphB92l/SoBanlkktMiA/ABJ+MmP0MYnH2+e/vk OEvupwPSPVia9FCBrCkPFLdRu3OClubr4GbJ4OZi3TQwBHGP58BFS8MGLFSuMFVUnjeJ FQUtvdXXt0H7v4mU7SpMjpDrBURukcIlQtuQYsU7mntP/dlxDXgD4vmsFfNXyl98YCIR lzm8FBmEgNPrA4V+GA2Z13f7m5v0zvGzbewEXeXACxawmtu11eZhpwpI8RmJT2SsdmUR h0Aw== X-Gm-Message-State: ANoB5pn+kkAdzwZLykeuXBfrUwr1i92nfuxV6AQl6t+E4R01Zf0SqOMd IfSyLmbAj2NGuSwsyk4hu5vT9A== X-Received: by 2002:a17:906:6c86:b0:78d:4ba6:f65a with SMTP id s6-20020a1709066c8600b0078d4ba6f65amr58210840ejr.186.1669923032873; Thu, 01 Dec 2022 11:30:32 -0800 (PST) Received: from stroh80.sec.9e.network (ip-078-094-000-051.um19.pools.vodafone-ip.de. [78.94.0.51]) by smtp.gmail.com with ESMTPSA id g15-20020aa7c84f000000b004619f024864sm2054110edt.81.2022.12.01.11.30.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Dec 2022 11:30:32 -0800 (PST) From: Naresh Solanki X-Google-Original-From: Naresh Solanki To: devicetree@vger.kernel.org, Guenter Roeck , Jean Delvare , Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, Patrick Rudolph , Naresh Solanki Subject: [PATCH v5 3/5] hwmon: (pmbus/core): Notify hwmon events Date: Thu, 1 Dec 2022 20:30:22 +0100 Message-Id: <20221201193025.1584365-3-Naresh.Solanki@9elements.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221201193025.1584365-1-Naresh.Solanki@9elements.com> References: <20221201193025.1584365-1-Naresh.Solanki@9elements.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751041387777290452?= X-GMAIL-MSGID: =?utf-8?q?1751041387777290452?= Notify hwmon events using the pmbus irq handler. Signed-off-by: Naresh Solanki --- drivers/hwmon/pmbus/pmbus_core.c | 46 +++++++++++++++++++++++++++++--- 1 file changed, 43 insertions(+), 3 deletions(-) diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c index 6a3a3fd59b8e..ad3c0cc884a4 100644 --- a/drivers/hwmon/pmbus/pmbus_core.c +++ b/drivers/hwmon/pmbus/pmbus_core.c @@ -2782,7 +2782,35 @@ static const struct pmbus_regulator_status_category pmbus_regulator_flag_map[] = }, }; -static int pmbus_regulator_get_error_flags(struct regulator_dev *rdev, unsigned int *flags) +#define to_dev_attr(_dev_attr) \ + container_of(_dev_attr, struct device_attribute, attr) + +static void pmbus_notify(struct pmbus_data *data, int page, int reg, int flags) +{ + int i; + + for (i = 0; i < data->num_attributes; i++) { + struct device_attribute *da = to_dev_attr(data->group.attrs[i]); + struct sensor_device_attribute *attr = to_sensor_dev_attr(da); + int index = attr->index; + u16 smask = pb_index_to_mask(index); + u8 spage = pb_index_to_page(index); + u16 sreg = pb_index_to_reg(index); + + if (reg == sreg && page == spage && (smask & flags)) { + dev_dbg(data->dev, "sysfs notify: %s", da->attr.name); + sysfs_notify(&data->dev->kobj, NULL, da->attr.name); + kobject_uevent(&data->dev->kobj, KOBJ_CHANGE); + flags &= ~smask; + } + + if (!flags) + break; + } +} + +static int pmbus_regulator_get_flags(struct regulator_dev *rdev, unsigned int *error, + bool notify) { int i, status; const struct pmbus_regulator_status_category *cat; @@ -2812,6 +2840,9 @@ static int pmbus_regulator_get_error_flags(struct regulator_dev *rdev, unsigned if (status & bit->pflag) *flags |= bit->rflag; } + + if (notify && status) + pmbus_notify(data, page, cat->reg, status); } /* @@ -2856,6 +2887,11 @@ static int pmbus_regulator_get_error_flags(struct regulator_dev *rdev, unsigned return 0; } +static int pmbus_regulator_get_error_flags(struct regulator_dev *rdev, unsigned int *flags) +{ + return pmbus_regulator_get_flags(rdev, flags, false); +} + static int pmbus_regulator_get_status(struct regulator_dev *rdev) { struct device *dev = rdev_get_dev(rdev); @@ -3087,7 +3123,7 @@ static irqreturn_t pmbus_fault_handler(int irq, void *pdata) { struct pmbus_data *data = pdata; struct i2c_client *client = to_i2c_client(data->dev); - int i, status; + int i, ret = IRQ_NONE, status; u8 page; for (i = 0; i < data->info->num_regulators; i++) { @@ -3095,6 +3131,10 @@ static irqreturn_t pmbus_fault_handler(int irq, void *pdata) if (!data->rdevs[i]) continue; + ret = pmbus_regulator_get_flags(data->rdevs[i], &status, true); + if (ret) + return ret; + page = rdev_get_id(data->rdevs[i]); mutex_lock(&data->update_lock); status = pmbus_read_status_word(client, page); @@ -3109,7 +3149,7 @@ static irqreturn_t pmbus_fault_handler(int irq, void *pdata) mutex_unlock(&data->update_lock); } - return IRQ_HANDLED; + return ret; } static int pmbus_irq_setup(struct i2c_client *client, struct pmbus_data *data) From patchwork Thu Dec 1 19:30:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naresh Solanki X-Patchwork-Id: 28524 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp447641wrr; Thu, 1 Dec 2022 11:33:37 -0800 (PST) X-Google-Smtp-Source: AA0mqf7nC4MV7WmaXBGjxN2A9L0mEwUwlJwJCTtfL0jJbF07p9VBDRX1+aZtX6sV4e/Dqjy3a+Cf X-Received: by 2002:a05:6402:22ab:b0:46a:abc8:8018 with SMTP id cx11-20020a05640222ab00b0046aabc88018mr30117012edb.369.1669923216990; Thu, 01 Dec 2022 11:33:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669923216; cv=none; d=google.com; s=arc-20160816; b=qeaA0TblBXzucTgcbnr9dnPFBtTix4QnKPLpofz0XgTkRXa7wQlexRjxczdKwRMfzL caydbGAgxigoLF08nibV/X9FmPNIBhk2fqb9ntPRGsyluOvTMUE5qaqBhY4ZeRIoa+34 hBaHglJyibnsmkYUNWwYhcSzpG+kcxZIefMomuLg6enhlb0UCxJ0SNIeZiH0pHdqGvsZ 4zyNTMxLxSMXyzwwY+XsfzAsIp4g9B1ckIhlpcNFCiekus+/7Hr15cXVmil1A16qefZM +FuMxulRoyGjLPji043/mG7X6CPyEGMIWr8f7wuJqRLbaMnougIPZmwsf4If815V90pi RSUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=MyxbmFSxj/AXTjphRUVPQX24S9JjJw2tXi7TXeZi100=; b=g2dOMIcdgpjdl6e77zz4HDHjOiJD3tRZ9kV2jLGavhTLyAsR6H0o2Vttkxayb5+mqh QpoUaw8n1xDjdnfboWOrO3GW1jHPSdEv0r0JXiTt9G4Q/HKQKJjcCobD1xZWiDUDZ0mk 3pNgUR5B3grcvlxcX+n7uiGVEHo6Hft/YT/tmdnESS7dgtNPPjOeGfVM5oFZhSJp5eDN 3HxocQlUQLVbtVM8Uavo7Xpy3Jp+gWtanGSqHi16wyowB3cYqrgN/Z+g8yiSqgRjaYHf 0JC22ba+0tWIReOHCTwOkYbppC+rFamUwFOzRELBYT3LI5S17NNazD78w2IWvXwsCVCv AOag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b=UzwyrrYp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p5-20020a056402154500b00468468cd389si4372514edx.205.2022.12.01.11.33.13; Thu, 01 Dec 2022 11:33:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b=UzwyrrYp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231314AbiLATbd (ORCPT + 99 others); Thu, 1 Dec 2022 14:31:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230440AbiLATap (ORCPT ); Thu, 1 Dec 2022 14:30:45 -0500 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 490FCCAB44 for ; Thu, 1 Dec 2022 11:30:35 -0800 (PST) Received: by mail-ed1-x52f.google.com with SMTP id v8so3751621edi.3 for ; Thu, 01 Dec 2022 11:30:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MyxbmFSxj/AXTjphRUVPQX24S9JjJw2tXi7TXeZi100=; b=UzwyrrYptELQKDXnQO+KEb6NKg7boJ3UHfqukBvz6WtDqK66R+BhnXI+ppaZSHmWKv fe4rZ2+N02mGkWsRN+4Q5CeT3mgVcK48TV2VICSygn9FU1iHMM1x97BAwsUCK7wpJ1Bp MwaHF3aP/F5UDpTv+uwACOf33TZ27CcDMUi7hK+yo+dhQTawl2s+x91ZohtRWklZ80Ql JWHeCNpqFn7GojHIHRwb8N7C1j3779hiwywc0rAO/k0UMPo+4x1JpveEa07I5W1d09tD ZDmH+CTA2pe/ZF4e2BtF+DG8pvFI5WqeVnrrAH3GWmS7qMLW+VG4UhdGUsI1DFC0jEJp 2uZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MyxbmFSxj/AXTjphRUVPQX24S9JjJw2tXi7TXeZi100=; b=HyUc4LP+fbwxC7PNJlq/NvSpB4NxGu/vpb0yUTe5X6cS8jMPKaDXgqtYhXymevMVar bl2XIE8fxW20BAe+wTjmRi+VqoXBE9aX5VIHEWPfnXVciMfssKUWlB66F5pzGNa3CbHG vM3H0iJdWkIy9SA6LYePpekD9YSUtqRLdJHqZte73DHZx0wK7JDjfp9MJJQbCHOemaI3 KyVJjyTWLOW7Xka9JzXiV0dILUVs9ZYvMby2bZmE/UVO4ltwZHOdifO89SO/fZMoGBde 4zWwmztgGgsHbXiW8B10p4DeICpi43xXTJK1FF2rLe7KWSzuZC25npU6ZYiXwlflc1PP W+BA== X-Gm-Message-State: ANoB5plqJxuhjs/iKEt94jJp36jaIePHW3TFBnS/jVIJ5kbEjmZrsPuB oJlfA6vDSBt0oItnW+WmcPbdog== X-Received: by 2002:aa7:c756:0:b0:46b:7038:b1f9 with SMTP id c22-20020aa7c756000000b0046b7038b1f9mr13754809eds.306.1669923033839; Thu, 01 Dec 2022 11:30:33 -0800 (PST) Received: from stroh80.sec.9e.network (ip-078-094-000-051.um19.pools.vodafone-ip.de. [78.94.0.51]) by smtp.gmail.com with ESMTPSA id g15-20020aa7c84f000000b004619f024864sm2054110edt.81.2022.12.01.11.30.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Dec 2022 11:30:33 -0800 (PST) From: Naresh Solanki X-Google-Original-From: Naresh Solanki To: devicetree@vger.kernel.org, Guenter Roeck , Jean Delvare , Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, Patrick Rudolph , Naresh Solanki Subject: [PATCH v5 4/5] hwmon: (pmbus/core): Add regulator event support Date: Thu, 1 Dec 2022 20:30:23 +0100 Message-Id: <20221201193025.1584365-4-Naresh.Solanki@9elements.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221201193025.1584365-1-Naresh.Solanki@9elements.com> References: <20221201193025.1584365-1-Naresh.Solanki@9elements.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751041407242918502?= X-GMAIL-MSGID: =?utf-8?q?1751041407242918502?= From: Patrick Rudolph Add regulator events corresponding to regulator error in regulator flag map. Also capture the same in pmbus_regulator_get_flags. Signed-off-by: Patrick Rudolph Signed-off-by: Naresh Solanki --- drivers/hwmon/pmbus/pmbus_core.c | 85 ++++++++++++++++++++------------ 1 file changed, 54 insertions(+), 31 deletions(-) diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c index ad3c0cc884a4..caefcb99aadf 100644 --- a/drivers/hwmon/pmbus/pmbus_core.c +++ b/drivers/hwmon/pmbus/pmbus_core.c @@ -2739,9 +2739,9 @@ static int pmbus_regulator_disable(struct regulator_dev *rdev) return _pmbus_regulator_on_off(rdev, 0); } -/* A PMBus status flag and the corresponding REGULATOR_ERROR_* flag */ +/* A PMBus status flag and the corresponding REGULATOR_ERROR_* and REGULATOR_EVENTS_* flag */ struct pmbus_regulator_status_assoc { - int pflag, rflag; + int pflag, rflag, eflag; }; /* PMBus->regulator bit mappings for a PMBus status register */ @@ -2756,27 +2756,36 @@ static const struct pmbus_regulator_status_category pmbus_regulator_flag_map[] = .func = PMBUS_HAVE_STATUS_VOUT, .reg = PMBUS_STATUS_VOUT, .bits = (const struct pmbus_regulator_status_assoc[]) { - { PB_VOLTAGE_UV_WARNING, REGULATOR_ERROR_UNDER_VOLTAGE_WARN }, - { PB_VOLTAGE_UV_FAULT, REGULATOR_ERROR_UNDER_VOLTAGE }, - { PB_VOLTAGE_OV_WARNING, REGULATOR_ERROR_OVER_VOLTAGE_WARN }, - { PB_VOLTAGE_OV_FAULT, REGULATOR_ERROR_REGULATION_OUT }, + { PB_VOLTAGE_UV_WARNING, REGULATOR_ERROR_UNDER_VOLTAGE_WARN, + REGULATOR_EVENT_UNDER_VOLTAGE_WARN }, + { PB_VOLTAGE_UV_FAULT, REGULATOR_ERROR_UNDER_VOLTAGE, + REGULATOR_EVENT_UNDER_VOLTAGE }, + { PB_VOLTAGE_OV_WARNING, REGULATOR_ERROR_OVER_VOLTAGE_WARN, + REGULATOR_EVENT_OVER_VOLTAGE_WARN }, + { PB_VOLTAGE_OV_FAULT, REGULATOR_ERROR_REGULATION_OUT, + REGULATOR_EVENT_OVER_VOLTAGE_WARN }, { }, }, }, { .func = PMBUS_HAVE_STATUS_IOUT, .reg = PMBUS_STATUS_IOUT, .bits = (const struct pmbus_regulator_status_assoc[]) { - { PB_IOUT_OC_WARNING, REGULATOR_ERROR_OVER_CURRENT_WARN }, - { PB_IOUT_OC_FAULT, REGULATOR_ERROR_OVER_CURRENT }, - { PB_IOUT_OC_LV_FAULT, REGULATOR_ERROR_OVER_CURRENT }, + { PB_IOUT_OC_WARNING, REGULATOR_ERROR_OVER_CURRENT_WARN, + REGULATOR_EVENT_OVER_CURRENT_WARN }, + { PB_IOUT_OC_FAULT, REGULATOR_ERROR_OVER_CURRENT, + REGULATOR_EVENT_OVER_CURRENT }, + { PB_IOUT_OC_LV_FAULT, REGULATOR_ERROR_OVER_CURRENT, + REGULATOR_EVENT_OVER_CURRENT }, { }, }, }, { .func = PMBUS_HAVE_STATUS_TEMP, .reg = PMBUS_STATUS_TEMPERATURE, .bits = (const struct pmbus_regulator_status_assoc[]) { - { PB_TEMP_OT_WARNING, REGULATOR_ERROR_OVER_TEMP_WARN }, - { PB_TEMP_OT_FAULT, REGULATOR_ERROR_OVER_TEMP }, + { PB_TEMP_OT_WARNING, REGULATOR_ERROR_OVER_TEMP_WARN, + REGULATOR_EVENT_OVER_TEMP_WARN }, + { PB_TEMP_OT_FAULT, REGULATOR_ERROR_OVER_TEMP, + REGULATOR_EVENT_OVER_TEMP }, { }, }, }, @@ -2810,7 +2819,7 @@ static void pmbus_notify(struct pmbus_data *data, int page, int reg, int flags) } static int pmbus_regulator_get_flags(struct regulator_dev *rdev, unsigned int *error, - bool notify) + unsigned int *event, bool notify) { int i, status; const struct pmbus_regulator_status_category *cat; @@ -2821,7 +2830,8 @@ static int pmbus_regulator_get_flags(struct regulator_dev *rdev, unsigned int *e u8 page = rdev_get_id(rdev); int func = data->info->func[page]; - *flags = 0; + *error = 0; + *event = 0; mutex_lock(&data->update_lock); @@ -2836,10 +2846,11 @@ static int pmbus_regulator_get_flags(struct regulator_dev *rdev, unsigned int *e return status; } - for (bit = cat->bits; bit->pflag; bit++) { - if (status & bit->pflag) - *flags |= bit->rflag; - } + for (bit = cat->bits; bit->pflag; bit++) + if (status & bit->pflag) { + *error |= bit->rflag; + *event |= bit->eflag; + } if (notify && status) pmbus_notify(data, page, cat->reg, status); @@ -2860,36 +2871,48 @@ static int pmbus_regulator_get_flags(struct regulator_dev *rdev, unsigned int *e return status; if (pmbus_regulator_is_enabled(rdev)) { - if (status & PB_STATUS_OFF) - *flags |= REGULATOR_ERROR_FAIL; + if (status & PB_STATUS_OFF) { + *error |= REGULATOR_ERROR_FAIL; + *event |= REGULATOR_EVENT_FAIL; + } - if (status & PB_STATUS_POWER_GOOD_N) - *flags |= REGULATOR_ERROR_REGULATION_OUT; + if (status & PB_STATUS_POWER_GOOD_N) { + *error |= REGULATOR_ERROR_REGULATION_OUT; + *event |= REGULATOR_EVENT_REGULATION_OUT; + } } /* * Unlike most other status bits, PB_STATUS_{IOUT_OC,VOUT_OV} are * defined strictly as fault indicators (not warnings). */ - if (status & PB_STATUS_IOUT_OC) - *flags |= REGULATOR_ERROR_OVER_CURRENT; - if (status & PB_STATUS_VOUT_OV) - *flags |= REGULATOR_ERROR_REGULATION_OUT; + if (status & PB_STATUS_IOUT_OC) { + *error |= REGULATOR_ERROR_OVER_CURRENT; + *event |= REGULATOR_EVENT_OVER_CURRENT; + } + if (status & PB_STATUS_VOUT_OV) { + *error |= REGULATOR_ERROR_REGULATION_OUT; + *event |= REGULATOR_EVENT_FAIL; + } /* * If we haven't discovered any thermal faults or warnings via * PMBUS_STATUS_TEMPERATURE, map PB_STATUS_TEMPERATURE to a warning as * a (conservative) best-effort interpretation. */ - if (!(*flags & (REGULATOR_ERROR_OVER_TEMP | REGULATOR_ERROR_OVER_TEMP_WARN)) && - (status & PB_STATUS_TEMPERATURE)) - *flags |= REGULATOR_ERROR_OVER_TEMP_WARN; + if (!(*error & (REGULATOR_ERROR_OVER_TEMP | REGULATOR_ERROR_OVER_TEMP_WARN)) && + (status & PB_STATUS_TEMPERATURE)) { + *error |= REGULATOR_ERROR_OVER_TEMP_WARN; + *event |= REGULATOR_EVENT_OVER_TEMP_WARN; + } return 0; } static int pmbus_regulator_get_error_flags(struct regulator_dev *rdev, unsigned int *flags) { - return pmbus_regulator_get_flags(rdev, flags, false); + int event; + + return pmbus_regulator_get_flags(rdev, flags, &event, false); } static int pmbus_regulator_get_status(struct regulator_dev *rdev) @@ -3123,7 +3146,7 @@ static irqreturn_t pmbus_fault_handler(int irq, void *pdata) { struct pmbus_data *data = pdata; struct i2c_client *client = to_i2c_client(data->dev); - int i, ret = IRQ_NONE, status; + int i, ret = IRQ_NONE, status, event; u8 page; for (i = 0; i < data->info->num_regulators; i++) { @@ -3131,7 +3154,7 @@ static irqreturn_t pmbus_fault_handler(int irq, void *pdata) if (!data->rdevs[i]) continue; - ret = pmbus_regulator_get_flags(data->rdevs[i], &status, true); + ret = pmbus_regulator_get_flags(data->rdevs[i], &status, &event, true); if (ret) return ret; From patchwork Thu Dec 1 19:30:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naresh Solanki X-Patchwork-Id: 28527 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp448166wrr; Thu, 1 Dec 2022 11:34:47 -0800 (PST) X-Google-Smtp-Source: AA0mqf6HVRhkXYrnHrCfTBzFJ86gqAf86MutMbtoQk2rSbjkEGcMHWsfDXeFq+w8kCnqCXBIfwi5 X-Received: by 2002:a05:6402:360b:b0:468:f365:dca with SMTP id el11-20020a056402360b00b00468f3650dcamr24744548edb.41.1669923287496; Thu, 01 Dec 2022 11:34:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669923287; cv=none; d=google.com; s=arc-20160816; b=D4EcXOjoQYPX0qZHaCh1UpD5XcnpOuqLMXvMSd2L8XLINvnQsMloR5c/WcIwAUvEQJ qlAlhx2+1LXYCfLpCo2VAZw8Pe/ir1mYKJm/az02nN1U9UVbCOElAPb1LBzpz6JZu1SI /aNnllQXwpvQMge1HWtf2BvmqENRbn6zR9vFtW75uW6Ka7vzcbLXV49Sxh95dR2KUn2J OCQkZwJ40UzTbwvexgCBaHZ/A3AOz5s/eqyxekB5qqWjQdmpZGKJb/q367nAd4kzEsel Q67cQtSF8YFomi/s214ypFXncXp25tYA0Oip+15NcyjPwAZiMaGkrYq5xIVFwx76vH5e 2LsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=JHC6ytZAHLrNLiHuUN2hc1jXap++ZHEcJiLjtBPhfto=; b=Sf8kOQQzSjCCV6+zmChHzUZdyzVe2mnBqJBVp/lxHDLgZ8HqNHOIxz7KEcKq6cyGJm IJae0qdeAt3FmpAO4H9rYKvJNxHLfr8NyDr2hsXfRqxhpPQtat4y1LdeFH7ZvU2YIMY4 R7jJ9icrJntRbYvPqGimKYrJx6Hde4i7bbeYgsAXWp9kouFiWfzh++TBaj/iQ9N4K2++ qbriap1eVErY0Da7uOaCohzPXtdLrnqd2Hn/NwB8GelUXCf+HQId9ZhMAzbA58TPEIE5 WnhvDJv74DNPk0nbJ/HAHpiQUwHV7tjYZFJACUPZBH3zyofMQL5VqMxipyB8aqoVGYxP +IgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b=AUxf8Xm6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ho18-20020a1709070e9200b0078e063fc78csi5123943ejc.576.2022.12.01.11.34.23; Thu, 01 Dec 2022 11:34:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b=AUxf8Xm6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231169AbiLATb3 (ORCPT + 99 others); Thu, 1 Dec 2022 14:31:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230106AbiLATao (ORCPT ); Thu, 1 Dec 2022 14:30:44 -0500 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 342CECAB51 for ; Thu, 1 Dec 2022 11:30:36 -0800 (PST) Received: by mail-ej1-x62e.google.com with SMTP id vv4so6628031ejc.2 for ; Thu, 01 Dec 2022 11:30:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JHC6ytZAHLrNLiHuUN2hc1jXap++ZHEcJiLjtBPhfto=; b=AUxf8Xm6UpCWhAeGDcR+3W5Z4SnIFEAv3fiL9oHqUJoa5WoxIlahHfcmR9mvTQCvZ0 MlvtW/BT2XFgh4zIhtnqE+P3QGK1LZrWRLAWuey+2v/ozgM9UmK15XA09InVz968DA1F kT7FMPmrydaUJcVh/AKcj5HbAMRaK9NyoDKXhAS792EyNFsK2D2UA39aKXmifavWBdnm 6aOlCGYV7P/sdQGEXYj8JBDtAk0aJSnSBW2DeD8ycmiGmITghzLW7rFRl5ur9GtNrLku rbCusZH9cwlRfbGeKpTG+rw7aAWE8/e27NPrO9MuW4vLQIu2veBTwc6E45+umqQE4IhO Cc4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JHC6ytZAHLrNLiHuUN2hc1jXap++ZHEcJiLjtBPhfto=; b=St5eb7iXr9eZmFUviDwL7RUr99DOT66Ug/r5UGMRiqnXAoxIdS2N4V7SMtA28fZFAo j7lUE9iTO1tZoXlXrn6nY5sVcEm4b81C35v1LbdpkLUtzgK7GvaG7SJglAZVw8blXXeY BGe0THVfV9dYp9vcBhwHF3vjMhI/X0u+SyFeLiCXFKWepC5hcubtIbuV6fu525/KGmkA T4QCkpU+Nx/b6ddseig/lDHKdzvqRvfDFY/Imau4PuRbV2AU9M7SFbSnnovc26gxmiwD zHraDJ/mRV1mHaNy5BV/dV6r3CMdQnjdlaPOFgng6rg41Yw/XEsy0E+7Mbei1Um3jrA/ GftA== X-Gm-Message-State: ANoB5pkEod7iYcCv5f0bdnDJima9UTjM0PINRUT1CmCimY+rGC5+gC5J cPvU9Qw/SvQPSpjl1XsMo0PAeA== X-Received: by 2002:a17:906:cc8f:b0:78b:8ce7:fe3c with SMTP id oq15-20020a170906cc8f00b0078b8ce7fe3cmr57197229ejb.557.1669923034733; Thu, 01 Dec 2022 11:30:34 -0800 (PST) Received: from stroh80.sec.9e.network (ip-078-094-000-051.um19.pools.vodafone-ip.de. [78.94.0.51]) by smtp.gmail.com with ESMTPSA id g15-20020aa7c84f000000b004619f024864sm2054110edt.81.2022.12.01.11.30.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Dec 2022 11:30:34 -0800 (PST) From: Naresh Solanki X-Google-Original-From: Naresh Solanki To: devicetree@vger.kernel.org, Guenter Roeck , Jean Delvare , Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, Patrick Rudolph , Naresh Solanki Subject: [PATCH v5 5/5] hwmon: (pmbus/core): Notify regulator events Date: Thu, 1 Dec 2022 20:30:24 +0100 Message-Id: <20221201193025.1584365-5-Naresh.Solanki@9elements.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221201193025.1584365-1-Naresh.Solanki@9elements.com> References: <20221201193025.1584365-1-Naresh.Solanki@9elements.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751041481063100264?= X-GMAIL-MSGID: =?utf-8?q?1751041481063100264?= Notify regulator events in PMBus irq handler. Signed-off-by: Naresh Solanki --- drivers/hwmon/pmbus/pmbus_core.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c index caefcb99aadf..5241a3c9bd21 100644 --- a/drivers/hwmon/pmbus/pmbus_core.c +++ b/drivers/hwmon/pmbus/pmbus_core.c @@ -3158,6 +3158,11 @@ static irqreturn_t pmbus_fault_handler(int irq, void *pdata) if (ret) return ret; + if (event) { + regulator_notifier_call_chain(data->rdevs[i], event, NULL); + ret = IRQ_HANDLED; + } + page = rdev_get_id(data->rdevs[i]); mutex_lock(&data->update_lock); status = pmbus_read_status_word(client, page);