From patchwork Thu Dec 1 01:49:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kim Phillips X-Patchwork-Id: 28136 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp18500wrr; Wed, 30 Nov 2022 17:53:29 -0800 (PST) X-Google-Smtp-Source: AA0mqf7GFwXv0P4/PROEiY6ihWbtAUDT4IF8qQ/J+w7b8mvlx1E22ZuAl91yCqlJvd59ybmNEx9+ X-Received: by 2002:a17:906:6417:b0:7ae:937f:2c38 with SMTP id d23-20020a170906641700b007ae937f2c38mr38731971ejm.201.1669859609319; Wed, 30 Nov 2022 17:53:29 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1669859609; cv=pass; d=google.com; s=arc-20160816; b=ZKj+4alxFPhbn0MEvuWt/odHQblpTlgOdC0o0qIBrlbDQDPrCLS44e09bAzcVJbIb9 +XNG2DRP8JOusmJ4hY7DNs0EwwOm+bvj/xOmxz3JZBiAGwxTay4wxkBNC3kwjy6pehZ/ JIpz3urPjS+HBLBLsk0/gvtnmafMSERWMGCQ/b+lXbPCFAqm349tAvY5ciD/3Z4lLvwT gIQmdiLKWeYF/tUqV+zDazfWHvW215OwE0JizWwqohgksh+tahZB9M5VQZmT+ZGH0Vya CaYrtfW7WB6lzmasEg55ZspLo1aV9P13PkB82+XN4CUmAitjbEpOeRFGEwb0p+UEHlgJ +r0Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=HQpTsS8xT1UW1HpQcwngMfc8dUWozRXsDFyQfd9txEE=; b=vNZRhTh7wkf/Nc4jtFksQ2ccibgeS4S3+f8N8ngnYwA/65wXdyMUVXB6qbN8yrYTYI HWClgyH+ZRwwLpZiwcyoVL6iNxrWmozmHbTee9YYYAie76lT0z+3QmZd/s1q7w4P0IDu uVSe4VH/MNy8LK55ytrzq/+y/H3Chgg604ooBCmfhpDumXVbXmtEOkbLEqTLeo+IvH6+ aLtnpqnFF0AztYbwMOmmw7OfGoqYO6YM1e5NfCVkGVSEHOQU9yeXYVlnt9hsq8jRgPj/ iry9yZGZbkPrO0Ggmaea+jXUShNDsHLm7Ie8fnwZTbKwbNAIJl1ZFupQEbZhgMjFtui2 9CUw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=octtsGmD; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y8-20020a056402270800b0046b32882b04si2588964edd.440.2022.11.30.17.53.05; Wed, 30 Nov 2022 17:53:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=octtsGmD; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229679AbiLABul (ORCPT + 99 others); Wed, 30 Nov 2022 20:50:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229900AbiLABug (ORCPT ); Wed, 30 Nov 2022 20:50:36 -0500 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2079.outbound.protection.outlook.com [40.107.102.79]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 301D79AE1B; Wed, 30 Nov 2022 17:50:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fQoFvtS8bik7LQdSx3isG9pVbGkRCmdFZ1xYAtN5uNsWntqolMsem41csOOBOspXm346JZ6BT5g/Eh42RP9NvC8lbXEx2T3j9Pohd8s9c9+nGOWepsMhKrOsY5+CZMXA7k3FWSO3usxbDHKTMhbcNloHtCqm/K7qh6sigZ+lEZ7ZnOxkBhROh2Uxq3OK4Ihgwdm0Bl3sbw4r8nOv5NovKMzpWzUxji58ZwexB56Ze3sZdLvMIqUVB9j9bMBBk2WATgXJoI2mA7sE/ZdTnyGoElnLcP8ZB4Ifx1D/Qk6s7hD/GdaicjmCVp27JdheCQ6s/fycbBF9E0niv/iClCu2Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HQpTsS8xT1UW1HpQcwngMfc8dUWozRXsDFyQfd9txEE=; b=RSz+CqFFlHvlVEtZsNTJkJzhvtnD705CzJbNQuozatwtQaXUggIuKI914vOB2pA7Go2ZZJCI+u7H40/xK78ifxBYcWZnjnimGXhfWXBcxxNu0W/HF/0NZsy7OZ4ss+fIF6rvoIXQdpGBNC41OhDYZiOBM92FA/CCXwolUWemjecjoOVzGUMA0lOeRdz9HyMXMnGFGLadqdz63b4LkiLT5y/oLncID75tPf7/r8LugR8aamZ5u7OINAZ9PdH/fkU40nb4AOMO+v8FG8z5Cq4b85hIe3DOuh7UbhgUpTCiYvi4/HpZHmv1k7QWMC5YrO/98P6aFhOMRPR3UnmoaVQfsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HQpTsS8xT1UW1HpQcwngMfc8dUWozRXsDFyQfd9txEE=; b=octtsGmDombSHS2V9X/xAVoKsRGyELMgtsGO7kXMm4+QeAleABaNc/DwiNe5qvWFvyxSm+paTkGc3iioIgIJAn4ih82RvlVK8+pNIK7n/QuR0Q1TK+8RDCGY4k4qBiS/P/qeqn3eYZ+LLglm7EFiKOKOmDYpwO1MNtN7Y6VE8qo= Received: from MN2PR19CA0052.namprd19.prod.outlook.com (2603:10b6:208:19b::29) by CH3PR12MB8186.namprd12.prod.outlook.com (2603:10b6:610:129::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Thu, 1 Dec 2022 01:50:30 +0000 Received: from BL02EPF0000EE3C.namprd05.prod.outlook.com (2603:10b6:208:19b:cafe::d9) by MN2PR19CA0052.outlook.office365.com (2603:10b6:208:19b::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.18 via Frontend Transport; Thu, 1 Dec 2022 01:50:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BL02EPF0000EE3C.mail.protection.outlook.com (10.167.241.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5880.8 via Frontend Transport; Thu, 1 Dec 2022 01:50:30 +0000 Received: from fritz.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 30 Nov 2022 19:50:28 -0600 From: Kim Phillips To: CC: Kim Phillips , Babu Moger , Borislav Petkov , Borislav Petkov , Boris Ostrovsky , Dave Hansen , "H. Peter Anvin" , Ingo Molnar , Joao Martins , Jonathan Corbet , "Konrad Rzeszutek Wilk" , Paolo Bonzini , Sean Christopherson , Thomas Gleixner , David Woodhouse , Greg Kroah-Hartman , Juergen Gross , Peter Zijlstra , Tony Luck , Tom Lendacky , Alexey Kardashevskiy , , , Subject: [PATCH v4 1/7] x86/cpu: Define a scattered No Nested Data Breakpoints feature bit Date: Wed, 30 Nov 2022 19:49:57 -0600 Message-ID: <20221201015003.295769-2-kim.phillips@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221201015003.295769-1-kim.phillips@amd.com> References: <20221201015003.295769-1-kim.phillips@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0000EE3C:EE_|CH3PR12MB8186:EE_ X-MS-Office365-Filtering-Correlation-Id: f5fae657-f354-467e-1597-08dad33e6d83 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YBlIM8e0Eo/NYBfbFDCCPmUDszAhHvtukK2kYjRX5uArBj27OSG9yEY692BxyvpdhmLzHjaqeF6z8fEmgxUSkxgLhByYW56AspkmYEj/YgeedXTnZLJ3gIvU0xkE2FAigm82o6F35YVGIwumrULkOExssSI+xZ8ZteOkBHrQQYefSeUo8rL3r+ZktF8sE0F4POqpyO7AK0KQ3GPEd7y/2ooDpFFXGyn8fCmppEInyOY/OmZBm4Vne3JeDFiSq0qvKgJXt0tukHjlyoq1WlC1jPsgyajNrKgNtzfsMn2mYT1f80Imf2A5MJVqQVIMXdhubxREnticnl6cM8C/SrZipJ8N1p+sZnBxu2p1FM06lB86zhoc/U30pUXsUKBUw/lyZlywZDftfIo0x7rLW9KT4XBMAcn92P6EbF3DYtTJVYVUeMEBvy65/XKKaNgbNXMpfC2qAy47D3qtnfRYnxArcJODnpGGc0EHWM7fN4RatD6XFW9nJNALLHyn9Rpqa6U44+YmuImy/Chm17ozTxvK1avPUPLT+tMa+yMUxdigcEzOBpW4TYkVm1hfv3E+pXiL1MoSacNFhA/8WuQ82lcq6WU7ZDtBQvghlil6rN7MllLHbD0Kr5CEP63KLRZsn0U4AWMqJqIwBbyYpP4fQwD03YqE0t54PFCVK/Lu23Mv5h6i83Up84d+A+ZMVmY5kybeTcnUny4V4/hEyflolbbPixYps/Aog1Bld3k+1bU1bEc= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(376002)(346002)(136003)(451199015)(46966006)(36840700001)(40470700004)(356005)(82740400003)(86362001)(82310400005)(36860700001)(81166007)(2906002)(40460700003)(8936002)(44832011)(40480700001)(8676002)(4326008)(41300700001)(5660300002)(7416002)(70586007)(316002)(70206006)(6916009)(54906003)(47076005)(36756003)(7696005)(16526019)(2616005)(26005)(1076003)(186003)(478600001)(426003)(336012)(6666004)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2022 01:50:30.4305 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f5fae657-f354-467e-1597-08dad33e6d83 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0000EE3C.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8186 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750974709717778060?= X-GMAIL-MSGID: =?utf-8?q?1750974709717778060?= It's a part of the CPUID 0x80000021 leaf, and this allows us to group this and other CPUID 0x80000021 EAX feature bits to being propagated via kvm_set_cpu_caps instead of open-coding them in __do_cpuid_func(). Signed-off-by: Kim Phillips --- arch/x86/include/asm/cpufeatures.h | 1 + arch/x86/kernel/cpu/scattered.c | 1 + 2 files changed, 2 insertions(+) diff --git a/arch/x86/include/asm/cpufeatures.h b/arch/x86/include/asm/cpufeatures.h index 11a0e06362e4..b16fdcedc2b5 100644 --- a/arch/x86/include/asm/cpufeatures.h +++ b/arch/x86/include/asm/cpufeatures.h @@ -307,6 +307,7 @@ #define X86_FEATURE_SGX_EDECCSSA (11*32+18) /* "" SGX EDECCSSA user leaf function */ #define X86_FEATURE_CALL_DEPTH (11*32+19) /* "" Call depth tracking for RSB stuffing */ #define X86_FEATURE_MSR_TSX_CTRL (11*32+20) /* "" MSR IA32_TSX_CTRL (Intel) implemented */ +#define X86_FEATURE_NO_NESTED_DATA_BP (11*32+21) /* "" AMD No Nested Data Breakpoints */ /* Intel-defined CPU features, CPUID level 0x00000007:1 (EAX), word 12 */ #define X86_FEATURE_AVX_VNNI (12*32+ 4) /* AVX VNNI instructions */ diff --git a/arch/x86/kernel/cpu/scattered.c b/arch/x86/kernel/cpu/scattered.c index f53944fb8f7f..079e253e1049 100644 --- a/arch/x86/kernel/cpu/scattered.c +++ b/arch/x86/kernel/cpu/scattered.c @@ -45,6 +45,7 @@ static const struct cpuid_bit cpuid_bits[] = { { X86_FEATURE_CPB, CPUID_EDX, 9, 0x80000007, 0 }, { X86_FEATURE_PROC_FEEDBACK, CPUID_EDX, 11, 0x80000007, 0 }, { X86_FEATURE_MBA, CPUID_EBX, 6, 0x80000008, 0 }, + { X86_FEATURE_NO_NESTED_DATA_BP,CPUID_EAX, 0, 0x80000021, 0 }, { X86_FEATURE_PERFMON_V2, CPUID_EAX, 0, 0x80000022, 0 }, { X86_FEATURE_AMD_LBR_V2, CPUID_EAX, 1, 0x80000022, 0 }, { 0, 0, 0, 0, 0 } From patchwork Thu Dec 1 01:49:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kim Phillips X-Patchwork-Id: 28141 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp19142wrr; Wed, 30 Nov 2022 17:55:33 -0800 (PST) X-Google-Smtp-Source: AA0mqf4TYrjUMvRw+5JOalQczYDuspW9f9wg3QxklN/akVH6OqJVJL2xiQUfxNPuwF3x3gocCnT9 X-Received: by 2002:a05:6a00:22c8:b0:575:b3f2:5523 with SMTP id f8-20020a056a0022c800b00575b3f25523mr9075386pfj.82.1669859733621; Wed, 30 Nov 2022 17:55:33 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1669859733; cv=pass; d=google.com; s=arc-20160816; b=eIV9Rta8+PDAcZSI0ITNbf0mWotpmfRkVqAE+1mipdon4zzqWgak08pwX2WPedI9g4 I2JAgS3cZqRXajq00t1y5memBrzQTtSdB8ZxmLPnnS4Jr4e0kW4PQWWVBN9vbEhL85CC whDJfRxmPrCydBwaODjWKnm/q2YOSJrwJefI1GGLFs5yBO6RRGjAAWBwh9kjF7hmB7Oi 9PaBDYoww2GZD5fDgIR7UjaEFmAv0BxUgrJABMW8trPzTQfeEqbKAXVp/eaCurzuIH94 Y9goDqHKQPY7Ewy5YGjZ4RVizxrrcIbLOWrBU61jCFKEwC/t4FQqaSY3R3xUSm7w6OS7 o5gg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=oZh06G+UMQkT5MIp5hrgE1kDExWORTtidp6tHLKxO0w=; b=KNMANRFyKbYMB7uZChez08iIZgkow35rTI2jfHoK6zJv/x26MjeR2V1edYHxEL0Bzc M8vruyt7ENTxUxA+AlRSWZZ0ioEhOqo4o2WbnywHHy5ua7R4Wjr6HFWJbXzmam0LxX7J ZDj5MadqQjcfKwynPiy8dP/fWh4zKBp2fgVjaSw3MnBX/O0h7zEKlEwedvpaOEPS0UNY uoBnnPXoRSqlIfTCaZX8aq6tWBJajLY+3gbnDvdx0L0yYGl2ZNfzBuii3tUEO1e3xLOT +53NZRmfzP3u7BkK6EpEHe/1iyXLvIe7GErpNqGq7jxpkJwAr6M45+zMdlMM4Vdt3XFX LPGw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=zHvOeK0W; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j3-20020a170903028300b00178b5e035fcsi3068877plr.496.2022.11.30.17.55.20; Wed, 30 Nov 2022 17:55:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=zHvOeK0W; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229632AbiLABuw (ORCPT + 99 others); Wed, 30 Nov 2022 20:50:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229897AbiLABus (ORCPT ); Wed, 30 Nov 2022 20:50:48 -0500 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2086.outbound.protection.outlook.com [40.107.212.86]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9369B9AE1E; Wed, 30 Nov 2022 17:50:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iTp60CmpEMNlysKtlQ2WJ26mo4x42oqLpr9aO3qkcXG97u3UvXgs4bXW54g8tZqCmfDpcEo15FOKkULIMWZ3WH39tABaE4xWurgSc0Um1xgBskap3RkpG7pOcD55aJyZ55Tm0ZY3Yt1G8g+Lk0vY8ULjcQK0dxtvSLWLKMcmkZlOmoa4Y4HfwFSBTOrrzX3nGNwFfZYN5RKvta0ySl/76KuCf6oY7iuICkdVbY5hwW9shnrmz5Iaxk72ljkRVLqYBfslLLQv/9mRzlvw47Vi1PIZzcjXZNYkH4WEh6Ba1RuxLfTRFbOHv6ntQZ3q+rCLhjPH/XbWSPoAvhXKL+VA7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oZh06G+UMQkT5MIp5hrgE1kDExWORTtidp6tHLKxO0w=; b=dKmDrfDZjY352qbSpGy7a91jEYGXLI5meyBHvw4mnwGSbKp8cCSEe3C6NhFiaTJpSoMj3AbQ9GxhS8ZvbGODzaY76bHWQ2vAMAfadYml2k7xtS+81VTLYTcBzi+E3P8FReKHuwRwCa77IhKSOoRolZZ33NNp+O7GXybWMLoWC4jzXKtAPVCJCRlRKiSFCbyuU+TPtzha34rudJb5WWUcgByWeaw6gByPlrqJG8+AA+L/D1pXa01s6oeqtrI0z/Ov6yvl/rAza9F0VTMVfgVuUMPuFiuxi6tGKSU1RQBMQKhVcQs/XMmEh9g+XXDxb7GiN7Bd8MaUY/UaVmWEi/D2UA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oZh06G+UMQkT5MIp5hrgE1kDExWORTtidp6tHLKxO0w=; b=zHvOeK0Wjrpa3K/JNdlxOKlFtk3GWif4yR2jZpy3AMsjSL1Td0qZbRu/qQlAO6a9qIXONZMVvPlnO5Zyd6XEjKJLPe9hkKTa1qgPHX5NzX3SL73OJ6eMmPfpuhDzkEYUXnLEmc3NCQ9idE3WE887cZZR9ngp4gIB9/cRf8zFgP8= Received: from BN9PR03CA0196.namprd03.prod.outlook.com (2603:10b6:408:f9::21) by PH7PR12MB7426.namprd12.prod.outlook.com (2603:10b6:510:201::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Thu, 1 Dec 2022 01:50:42 +0000 Received: from BL02EPF0000EE3F.namprd05.prod.outlook.com (2603:10b6:408:f9:cafe::55) by BN9PR03CA0196.outlook.office365.com (2603:10b6:408:f9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23 via Frontend Transport; Thu, 1 Dec 2022 01:50:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BL02EPF0000EE3F.mail.protection.outlook.com (10.167.241.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5857.17 via Frontend Transport; Thu, 1 Dec 2022 01:50:42 +0000 Received: from fritz.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 30 Nov 2022 19:50:40 -0600 From: Kim Phillips To: CC: Kim Phillips , Babu Moger , Borislav Petkov , Borislav Petkov , Boris Ostrovsky , Dave Hansen , "H. Peter Anvin" , Ingo Molnar , Joao Martins , Jonathan Corbet , "Konrad Rzeszutek Wilk" , Paolo Bonzini , Sean Christopherson , Thomas Gleixner , David Woodhouse , Greg Kroah-Hartman , Juergen Gross , Peter Zijlstra , Tony Luck , Tom Lendacky , Alexey Kardashevskiy , , , Subject: [PATCH v4 2/7] x86/cpu: Define a scattered Null Selector Clears Base feature bit Date: Wed, 30 Nov 2022 19:49:58 -0600 Message-ID: <20221201015003.295769-3-kim.phillips@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221201015003.295769-1-kim.phillips@amd.com> References: <20221201015003.295769-1-kim.phillips@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0000EE3F:EE_|PH7PR12MB7426:EE_ X-MS-Office365-Filtering-Correlation-Id: 495e7954-cfcd-4868-10ab-08dad33e748e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QvEhnC96ob7c4cb1TSlcnhg+kRm6UBDPfe15ch7dqYzGyJM58/GM78DhstwfIUqv8WVxtaWmaPS3TYLC+edZ3mW2OwjAkTvHXal4h6edSy12Q9rvVoPuQnF5DcLw3XI+ncVa68ZlU1DqSgLxOwr2SKkaMdymnIoXifKXODktLozGDQsQpBfTyKlA8oxOr6lMhPDcUZ0nJNvQYiw6ldz3dovB2eznT4ZgYwtYuS3NRjRoWACLya1rC5m9YLWxScj8tOPE1wmageESsEHuYXQW1/BEsWus4KedThiClNP9tFoVaXguRqcnYiBOiCbAYl32mCEQ/k1W50KUsntN3eEOnEw+E8S0afvhAPY9gFsj4y0OLkoBSoA2OV8Ww7KuZBsEqD3RVl0vn2cmm/qDByK1CjSAHasxHwn3iiRZyN0Dd02CB0WCqfO6PD6zInqBl31X7RmJj8QTI30+FmpXTNI//5MLCF4V5yvhallIaS/tZu/t+UNwyeZvQjMGW9f5uW/N8zeHT7qXvA4usZ12lUBuPFUqeei2yDQbf70iZGBqjdKcPyQmSumsIk5mKK9JEYrHKUbK+XFSKNzg6EYiHcpvWZgY4bJfhmCm2fNPn/K1sQXScDvF53Gl3o+P2Epg4EjR0PN5ga1b2SyMcHQSbG8IOQnlNSLQw3pE489TD/KPuNFux1xj0LXCwWQXBnSConQI1K11W+fVhVhSZKdcJPZtobNaJT6mqNtjKZF100PGEkY= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(376002)(346002)(136003)(451199015)(46966006)(40470700004)(36840700001)(7416002)(7696005)(5660300002)(1076003)(6666004)(4326008)(478600001)(83380400001)(70206006)(8936002)(2616005)(70586007)(186003)(47076005)(336012)(16526019)(8676002)(36860700001)(426003)(44832011)(2906002)(41300700001)(82740400003)(86362001)(82310400005)(26005)(316002)(54906003)(6916009)(36756003)(40460700003)(40480700001)(81166007)(356005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2022 01:50:42.2621 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 495e7954-cfcd-4868-10ab-08dad33e748e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0000EE3F.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7426 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750974840003664126?= X-GMAIL-MSGID: =?utf-8?q?1750974840003664126?= It's a part of the CPUID 0x80000021 leaf, and this allows us to group this and other CPUID 0x80000021 EAX feature bits to being propagated via kvm_set_cpu_caps() instead of open-coding them in __do_cpuid_func(). Also use the feature bit definition in check_null_seg_clears_base() instead of open-coding it. Signed-off-by: Kim Phillips --- arch/x86/include/asm/cpufeatures.h | 1 + arch/x86/kernel/cpu/common.c | 3 +-- arch/x86/kernel/cpu/scattered.c | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/asm/cpufeatures.h b/arch/x86/include/asm/cpufeatures.h index b16fdcedc2b5..5ddde18c1ae8 100644 --- a/arch/x86/include/asm/cpufeatures.h +++ b/arch/x86/include/asm/cpufeatures.h @@ -308,6 +308,7 @@ #define X86_FEATURE_CALL_DEPTH (11*32+19) /* "" Call depth tracking for RSB stuffing */ #define X86_FEATURE_MSR_TSX_CTRL (11*32+20) /* "" MSR IA32_TSX_CTRL (Intel) implemented */ #define X86_FEATURE_NO_NESTED_DATA_BP (11*32+21) /* "" AMD No Nested Data Breakpoints */ +#define X86_FEATURE_NULL_SEL_CLR_BASE (11*32+22) /* "" AMD Null Selector Clears Base */ /* Intel-defined CPU features, CPUID level 0x00000007:1 (EAX), word 12 */ #define X86_FEATURE_AVX_VNNI (12*32+ 4) /* AVX VNNI instructions */ diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c index 73cc546e024d..8d28cd7c9072 100644 --- a/arch/x86/kernel/cpu/common.c +++ b/arch/x86/kernel/cpu/common.c @@ -1683,8 +1683,7 @@ void check_null_seg_clears_base(struct cpuinfo_x86 *c) return; /* Zen3 CPUs advertise Null Selector Clears Base in CPUID. */ - if (c->extended_cpuid_level >= 0x80000021 && - cpuid_eax(0x80000021) & BIT(6)) + if (cpu_has(c, X86_FEATURE_NULL_SEL_CLR_BASE)) return; /* diff --git a/arch/x86/kernel/cpu/scattered.c b/arch/x86/kernel/cpu/scattered.c index 079e253e1049..d0734cc19d37 100644 --- a/arch/x86/kernel/cpu/scattered.c +++ b/arch/x86/kernel/cpu/scattered.c @@ -46,6 +46,7 @@ static const struct cpuid_bit cpuid_bits[] = { { X86_FEATURE_PROC_FEEDBACK, CPUID_EDX, 11, 0x80000007, 0 }, { X86_FEATURE_MBA, CPUID_EBX, 6, 0x80000008, 0 }, { X86_FEATURE_NO_NESTED_DATA_BP,CPUID_EAX, 0, 0x80000021, 0 }, + { X86_FEATURE_NULL_SEL_CLR_BASE,CPUID_EAX, 6, 0x80000021, 0 }, { X86_FEATURE_PERFMON_V2, CPUID_EAX, 0, 0x80000022, 0 }, { X86_FEATURE_AMD_LBR_V2, CPUID_EAX, 1, 0x80000022, 0 }, { 0, 0, 0, 0, 0 } From patchwork Thu Dec 1 01:49:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kim Phillips X-Patchwork-Id: 28137 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp18632wrr; Wed, 30 Nov 2022 17:53:58 -0800 (PST) X-Google-Smtp-Source: AA0mqf7hDbWTXnXvmGi9pn5bkK3GMB2kLI4PNN48DbTKuAVkrFWtKbzpD8h1p+F7qxqKXCj1SSnS X-Received: by 2002:a17:902:f243:b0:189:8046:4335 with SMTP id j3-20020a170902f24300b0018980464335mr21502423plc.152.1669859638548; Wed, 30 Nov 2022 17:53:58 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1669859638; cv=pass; d=google.com; s=arc-20160816; b=LGr6DOFvT7lc0FaoN9v+Om5t0PLwGSUNYREouJPB1Tuoyc3ssTTdC7uk4uReFDZpy2 FEXizMGqJhHicDNP0aYJIUNpeOVppIvTse0fD6C8so0ApE4YyKULTAOxRhgCOiGmy8dV 4mR0AeJB7qr/WiYMHg0sBvcJX7a+2vSwOkMKlF8nBxiMZJP1OYqmCmyX1SO6MDFCc2kQ JaVukb/0UiKWpamuRz/+8ma5OBS/dKetIZ1p+BN4CjevHN/636ndAv8hX8tnuKtbI6JC CuxkeMGuFT0iDyJ/a+80XTuQzxcIVHMErAZOOn4OwQKywtb6YpZMUT8eMqqxz3sLpv1a h0ZQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=30CI6/Z+JHcW+AqhKQWtRpUMNnWwm4nj/Hsi3VKx3X4=; b=PHNHaw6RSSRRS0GK2gQ6E9bs+hnG6Sz+N2G8pS7vyEIppmRyXoW0qWMp72fIWnjPPD LylHnWX3Fj+3axl65OjY1wqetUM8V9+fYt+87L0+Z5nZzKVdlxXPtOKAgD5SYI1yHhUn 6Tyk6YmQKg6AwNPwTMQPS788vVsDd8FYT8em+rapcGBi9YtzR9x9fxziyikJ/i7YPrNs HvBvuylwUSqcBGYxWXvmad0CRkgirpV6w122okn8J+X5lbhwqFTkAXhoy8lVSclf/BBU paeTVeur9+dqm0wENN20nTnXo6FhMiJawPabyin+tJsqNqUMzDLsb+s4gz67yDRR560g 7m3Q== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=cVpmgREh; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 187-20020a6308c4000000b004404162e5e0si2752356pgi.593.2022.11.30.17.53.45; Wed, 30 Nov 2022 17:53:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=cVpmgREh; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229602AbiLABvG (ORCPT + 99 others); Wed, 30 Nov 2022 20:51:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229780AbiLABu6 (ORCPT ); Wed, 30 Nov 2022 20:50:58 -0500 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2051.outbound.protection.outlook.com [40.107.237.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C1489802E; Wed, 30 Nov 2022 17:50:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mq4cA8MlnTOCjdLj8PocxzX0t0Xj/3Al0JCGN5+TKQNlYppdO8KU2jue3RXicfYfERwYzq5/XnVdBYjSdYxpxClyRHM+oz10vPwbF8G0aPgWOHP5bSbRS7Tb2OEyJV6QJb6H3DaQ7M6pM5uj6JaTRj32rvY6WyXlJ7vyVLSTl6/3plOcet5jfdM7mZo8VdwMtJddub/RfbKplv7U+2bv5hTokiQb20CkLjlRwc4nJIc6D1+6LH4UkC5wnFTMMN1M3vvVjOfkXNUo5Hs85/VHP7jVgk5w0BIJhMRN6y9CKMIyOcYZMPfPfXGSDaOnT9OieTtLwkkmEVEMREju7diUAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=30CI6/Z+JHcW+AqhKQWtRpUMNnWwm4nj/Hsi3VKx3X4=; b=CC3SAJSI7B+w6k0U5KCx8w3EgNDZ6GZKktrkXed3ZQt11lIulqP9SRC5JWxzqJf1IovQMtkmNE/AY2trV3yXbM71fVvDLhzaOFKVx/3rAmCZmvYqCyh4dm+oXvVVHyhPQSqybvPc6MdQoM4ubA4+0BhNoreOI94Z7dYtdlkyUvv5dqOKl2XMnl8xuHQB5LnotzvePmVvi58ZEp78nPcsxAQI9ePi7MmMasllx+uFIkD5anReQsoPugi3QUSepVvHMGNuIE6W3SIMU0564t8QcSVfflzd7/cY6uJXNLqvM9GXxag6IK2ClyMBAEDNwnJ77aboPy4Cpa3w8NW7tliL0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=30CI6/Z+JHcW+AqhKQWtRpUMNnWwm4nj/Hsi3VKx3X4=; b=cVpmgREhKEKzafUBXvki78Y6CNOw29NhpnyhVhzjqHeIz9irbGbmPlf8wfIawnoaVM2nPL7Xl5w9GK6bmPU2zqWWW8F9fGMUGVUQ/C0dP9gD/2plLFSV5rU7HrkH5b9Zo5WkT0WzDGyWNHrBjGsyrk59DMjuM8V9uH9tDWXvxyc= Received: from MN2PR07CA0001.namprd07.prod.outlook.com (2603:10b6:208:1a0::11) by DM4PR12MB7576.namprd12.prod.outlook.com (2603:10b6:8:10c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Thu, 1 Dec 2022 01:50:54 +0000 Received: from BL02EPF0000EE3C.namprd05.prod.outlook.com (2603:10b6:208:1a0:cafe::69) by MN2PR07CA0001.outlook.office365.com (2603:10b6:208:1a0::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23 via Frontend Transport; Thu, 1 Dec 2022 01:50:54 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BL02EPF0000EE3C.mail.protection.outlook.com (10.167.241.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5880.8 via Frontend Transport; Thu, 1 Dec 2022 01:50:54 +0000 Received: from fritz.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 30 Nov 2022 19:50:52 -0600 From: Kim Phillips To: CC: Kim Phillips , Babu Moger , Borislav Petkov , Borislav Petkov , Boris Ostrovsky , Dave Hansen , "H. Peter Anvin" , Ingo Molnar , Joao Martins , Jonathan Corbet , "Konrad Rzeszutek Wilk" , Paolo Bonzini , Sean Christopherson , Thomas Gleixner , David Woodhouse , Greg Kroah-Hartman , Juergen Gross , Peter Zijlstra , Tony Luck , Tom Lendacky , Alexey Kardashevskiy , , , Subject: [PATCH v4 3/7] x86/cpu: Make X86_FEATURE_LFENCE_RDTSC a scattered feature bit Date: Wed, 30 Nov 2022 19:49:59 -0600 Message-ID: <20221201015003.295769-4-kim.phillips@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221201015003.295769-1-kim.phillips@amd.com> References: <20221201015003.295769-1-kim.phillips@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0000EE3C:EE_|DM4PR12MB7576:EE_ X-MS-Office365-Filtering-Correlation-Id: f9945591-f67b-4183-0428-08dad33e7b98 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xyTsVFCF/iCTtmYsxAw2anKuNSh9qaMzoZkyV2X9hsEP8XA3rVUVW9XiBEiBv84ZQAqPzw1rGp1+nP8wxHZSVzRgSmInt1W5byOu/whs5rR/sq8Zr8aqXUvwBH5fy1pzLebReJW2Q002NVPE7Trz6eYcjThG7FrziEYfKkViBiAmrQL8erwsRTSsgR3Kc38rE+z5E/uw+dCdEMKPmy8b8kSND2odSbuWWSC++or52wtLhG95SlRhtKocPfgd3Izpsmle9RIRYmteUABSNrlOkXO6mB42w9lwUgKDa2Er9hpX3mEsb7jaKPLLT59JQ9wfeeOAEwYmRay0HKpVBaGQUrlGRs1oneHT2OdzmYR2duGrx2Lpknq3xu+KSgu+DBUQKFEXSYJ9I32eHeC/d9vbmJ4T1gDHADO+4fDBzmWPxlRzAqcYA/ql1hBbUlbggtG/UJfaECK3NsSBZ7xjadAiBMFXWJubKSpWZ/PFHXuIGNadBzo1PjCPYdU6bVoDHbgSv/u/QnGnx1rgtIDlvo221OIG3JIDjpyBP/HbOUsER2tzRALeNcrnLIPXfe+LoJ4er+rEM6l4jhIVn5+su49rFkj3eRd7F5nESyvVwj/O1a1y2cziwEag5zJUO2KVLOcGBC8MCzdD5q7cyU3eArat5jFyQagbrbPRvPgucZMpfPdx8veJDl6QOvViqjPJssTfUo52GmVAZ/bg4YtFaOn8V+OC6BA7FmdC1UVDXwi8AQ0= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(39860400002)(346002)(136003)(451199015)(40470700004)(36840700001)(46966006)(70586007)(186003)(5660300002)(8936002)(86362001)(36756003)(4326008)(26005)(54906003)(8676002)(36860700001)(316002)(40460700003)(356005)(40480700001)(82740400003)(426003)(81166007)(47076005)(82310400005)(2616005)(7416002)(70206006)(1076003)(336012)(41300700001)(16526019)(478600001)(7696005)(6916009)(2906002)(44832011)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2022 01:50:54.0714 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f9945591-f67b-4183-0428-08dad33e7b98 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0000EE3C.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7576 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750974740085347934?= X-GMAIL-MSGID: =?utf-8?q?1750974740085347934?= It's a part of the CPUID 0x80000021 leaf, and this allows us to group this and other CPUID 0x80000021 EAX feature bits to being propagated via kvm_set_cpu_caps() instead of open-coding them in __do_cpuid_func(). Unlike the other CPUID 0x80000021 EAX feature bits, X86_FEATURE_LFENCE_RDTSC already had an entry in cpufeatures.h. Signed-off-by: Kim Phillips --- arch/x86/kernel/cpu/scattered.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/kernel/cpu/scattered.c b/arch/x86/kernel/cpu/scattered.c index d0734cc19d37..caa03466cd9e 100644 --- a/arch/x86/kernel/cpu/scattered.c +++ b/arch/x86/kernel/cpu/scattered.c @@ -46,6 +46,7 @@ static const struct cpuid_bit cpuid_bits[] = { { X86_FEATURE_PROC_FEEDBACK, CPUID_EDX, 11, 0x80000007, 0 }, { X86_FEATURE_MBA, CPUID_EBX, 6, 0x80000008, 0 }, { X86_FEATURE_NO_NESTED_DATA_BP,CPUID_EAX, 0, 0x80000021, 0 }, + { X86_FEATURE_LFENCE_RDTSC, CPUID_EAX, 2, 0x80000021, 0 }, { X86_FEATURE_NULL_SEL_CLR_BASE,CPUID_EAX, 6, 0x80000021, 0 }, { X86_FEATURE_PERFMON_V2, CPUID_EAX, 0, 0x80000022, 0 }, { X86_FEATURE_AMD_LBR_V2, CPUID_EAX, 1, 0x80000022, 0 }, From patchwork Thu Dec 1 01:50:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kim Phillips X-Patchwork-Id: 28138 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp18751wrr; Wed, 30 Nov 2022 17:54:22 -0800 (PST) X-Google-Smtp-Source: AA0mqf55wHcK6DtKmmp1x9Ethwk1zaxpQVMNs25HJijnkWaQF6UYIaGJydbU8Oh3W5fHlVtK1+uj X-Received: by 2002:a17:906:cedc:b0:7ad:e8dd:837c with SMTP id si28-20020a170906cedc00b007ade8dd837cmr57395721ejb.264.1669859662015; Wed, 30 Nov 2022 17:54:22 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1669859662; cv=pass; d=google.com; s=arc-20160816; b=ymSLeUq4mmqp2BRNw3vB6IP+YUi2KQkkHushFh2+5WGR55eNsBdmRs5AG0aXeEX6Ej d+SwJOx/GDd83nrTPsdybQsoU02pgyfCCgnnleZIKI0XKP0ugOHOrvOfghsZqSSoY249 36FvzCan48THRUrMvwJZqYIFAnWfGxlWk/kQzLVQ6WdHg4c8itOPUsbiqS4yfcQc90GQ DQP6nTUPd6pTsBx8ZLdArn0GSvt/v+mquI8wofRHNSB4Wyqoii9wGJ43pTxi3EFG5nNL /Ls4ezb0CSW5rgTAsfhrTe2C3aYAf5ca/CGXT09FqNbJ39JFoUArsE+yrK5nyz8SEFGf WPYg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=aJNYRfHM869rcVG5ek02QXWp90OIOOF7VmnPInzVI0g=; b=NWLvXQRUVArzFVrbD4Jt/J/YBWSk52QKyQ6r8RUC9LS32CqlbkSjZVnLsSl+d3FyIb EmwfWZpOCKxwxzyp3KTCtemSWVexIyVgaIv9voLWXOLTa451rnXxzA5PywDBZXKaJNXD b9zeRYW6fic1SypI/8HIFmUAM+p6SiShZPdAMCswgIsT4M9ACP4mjfOpUXRovQqSoTuk R1sBOyOh0MbUPv96QPVLS6F8ULiwQpocIa3gY4u52PPXlu7Ufr3DFi/1v8KwPzb2mItL gAM+fmV4ssTmrtGHrRixd5HBGnqhfhlSuU3/uhKlRz4Aikx3cpbzkT2HfH189fLnl0mk drCw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=eldlJrZp; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v7-20020a056402348700b0046a7049ade5si2844185edc.55.2022.11.30.17.53.59; Wed, 30 Nov 2022 17:54:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=eldlJrZp; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229900AbiLABvV (ORCPT + 99 others); Wed, 30 Nov 2022 20:51:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229923AbiLABvL (ORCPT ); Wed, 30 Nov 2022 20:51:11 -0500 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2075.outbound.protection.outlook.com [40.107.96.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D5AC93A62; Wed, 30 Nov 2022 17:51:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H2biLp6udQsbYfSlD/lh1Wh6yvBrQ8wnZIMqfoN3ke2E4YU7TJOMmPC9TLrJui5Wnak+Eh7CDz/0n8w3vTRp55hi35VlISzEb+IKdnOrAJ2ItnurWjxvXXlJ+1m0mokTUXQOyAnm5fOh49CKTh4WgMqwhTrlajQODryn1Ie5/Ek8ryY27qKTB485pN/VFgNPPdkQZz1dna/V1/1fpEjiP4R/umcM6BfLuuVKROVhvUK1EFOhTwKr4hIKaZ7M5CeLUUGoIdLqCKfzFQvjRUY4wjMIMg9010Pkbx8r0//2Gil1PNB5h/c4BumJpGOqY1K3nmtoF2iibY3iTE+Mz3ypFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aJNYRfHM869rcVG5ek02QXWp90OIOOF7VmnPInzVI0g=; b=fueTe1czpB9Lw1aHGTpI6NCW/WXLrWZ0EsPN7UwQveNeCJrCfH9BXC8D5/2TcJd2XW5JEVydpfqwBwHuYVP8fe2MqdUv+F7SoutXVT2vQmc/DBT2xh0eBjAQjHfmaxCpcmEoZJ7/tInWhqCWOR14YtcNa8MSdoUFtVhbWLmag+pxZyUqXJHMl+NX6HJJ1EqcqNRwp8QztZqW3morD9YXyfN9lwPUgrKkKL7HtLvKNA4la3x7hY400VYw2VqFqJ/ynGX6FsxW7A7OmB2iSdbqHbOwth0H7s6ATLG12MIvZ0u6KvCtgR/dAe8FmDdEO3W2XEuAK5EcKNM4MAOXvGt6Jg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aJNYRfHM869rcVG5ek02QXWp90OIOOF7VmnPInzVI0g=; b=eldlJrZp/OkVgIVLbenXi3PU1bft1vbBqEid42qMcTHwXZlFwMj1nVgntF8FHU/bud8IGrci6yZWGxlcDbSdHfuKkGn0/VX0/Yo5MN5INiqt0B2igeDerhqedYxvtdvcuOhiSz7llmkc2HSy7dqTlysNdbLmbJUVpST3pT1zFCw= Received: from BN9PR03CA0852.namprd03.prod.outlook.com (2603:10b6:408:13d::17) by SA1PR12MB6919.namprd12.prod.outlook.com (2603:10b6:806:24e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Thu, 1 Dec 2022 01:51:07 +0000 Received: from BN8NAM11FT116.eop-nam11.prod.protection.outlook.com (2603:10b6:408:13d:cafe::7b) by BN9PR03CA0852.outlook.office365.com (2603:10b6:408:13d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23 via Frontend Transport; Thu, 1 Dec 2022 01:51:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT116.mail.protection.outlook.com (10.13.176.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5880.8 via Frontend Transport; Thu, 1 Dec 2022 01:51:06 +0000 Received: from fritz.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 30 Nov 2022 19:51:04 -0600 From: Kim Phillips To: CC: Kim Phillips , Babu Moger , Borislav Petkov , Borislav Petkov , Boris Ostrovsky , Dave Hansen , "H. Peter Anvin" , Ingo Molnar , Joao Martins , Jonathan Corbet , "Konrad Rzeszutek Wilk" , Paolo Bonzini , Sean Christopherson , Thomas Gleixner , David Woodhouse , Greg Kroah-Hartman , Juergen Gross , Peter Zijlstra , Tony Luck , Tom Lendacky , Alexey Kardashevskiy , , , Subject: [PATCH v4 4/7] x86/cpu, kvm: Move CPUID 0x80000021 EAX feature bits propagation to kvm_set_cpu_caps() Date: Wed, 30 Nov 2022 19:50:00 -0600 Message-ID: <20221201015003.295769-5-kim.phillips@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221201015003.295769-1-kim.phillips@amd.com> References: <20221201015003.295769-1-kim.phillips@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT116:EE_|SA1PR12MB6919:EE_ X-MS-Office365-Filtering-Correlation-Id: 34d1213c-f6d1-4e2d-4889-08dad33e832c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EKNunCbiyLIZGJ0UKQxHfP+jG/MdA5LMQ9qTIDavxIfsAzjL+6n9/zWVWbIAwU0LNJihJ0AEi9XOUp6ERSxlX3qQuPaDZavDG7Whyjs1AJY6IHvxfnyEjJk01GvPFYoN4OBwXiEkqh7IQG3DrgqpnqgP/SUI6lNEMeWV2iukqUT19rP4neBju+7d/9+O2G30zJqVZiFxJHzUNB7GyPIW+HRpF/5YEXTBUycLyxIdaCt3tz8DsdP6hsORXC211h8ZTNfaFZrE3SJUOJuFjegm5aASwkYT5PZrZ8WgWTwRZmpMNRjC/4OEB5NzXzTUPvo5khCEpla9xyB7daJp+NyptBbAQeRNeIx3NjBb3XcIAjkQQXPIWrJC/8em1axDf2H8Lesr38LQXf8otteV7EZXtBydXVvKFif9ZUM3jjH2yRDPbBP1C9u1EmG4Vu1X6dxXETWOd+y4t7IuFG07QiUm/cP4qBRz0lILyXlgDoWHIXbJMnILtK4l0F67Wlcb73QdvT+WH4HcY8B3pIyHtD+zgoIlcjJ7a7NTTHidg1IVEbSwieyMAnJxwBOEsuCyUchvKhr+a+1/u2G8SWpAn1J9ChRVKitmVCHYQUWsnFTHqGQGvISgrOQDnXYGEAWtgtUw3p4aKk96iWxhaqDfV/Hn9MhFtq9QX8PKL0wmKi3i9vm/glqX9DGmpVfpsI2EKrmY4FKNLN9BdzBiBKKDK93X5lrFonUt3A6hVhrbBVdh4Fc= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(346002)(136003)(39860400002)(451199015)(40470700004)(36840700001)(46966006)(41300700001)(86362001)(36756003)(40460700003)(6916009)(40480700001)(5660300002)(1076003)(2616005)(83380400001)(8676002)(316002)(70206006)(16526019)(26005)(7696005)(4326008)(70586007)(47076005)(6666004)(426003)(186003)(478600001)(82740400003)(336012)(356005)(54906003)(82310400005)(36860700001)(8936002)(7416002)(44832011)(2906002)(81166007)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2022 01:51:06.8028 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 34d1213c-f6d1-4e2d-4889-08dad33e832c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT116.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6919 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750974765132923435?= X-GMAIL-MSGID: =?utf-8?q?1750974765132923435?= Move CPUID 0x80000021 EAX feature bits guest propagation to kvm_set_cpu_caps() instead of open-coding them in __do_cpuid_func(). Drop the bit description comments now the code is more self-describing. Whilst there, switch to using the more efficient cpu_feature_enabled() instead of static_cpu_has(). Signed-off-by: Kim Phillips --- arch/x86/kvm/cpuid.c | 25 ++++++++++--------------- arch/x86/kvm/reverse_cpuid.h | 22 ++++++++++++++++------ 2 files changed, 26 insertions(+), 21 deletions(-) diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c index c92c49a0b35b..dd0fe79521eb 100644 --- a/arch/x86/kvm/cpuid.c +++ b/arch/x86/kvm/cpuid.c @@ -730,6 +730,15 @@ void kvm_set_cpu_caps(void) 0 /* SME */ | F(SEV) | 0 /* VM_PAGE_FLUSH */ | F(SEV_ES) | F(SME_COHERENT)); + kvm_cpu_cap_init_scattered(CPUID_8000_0021_EAX, + SF(NO_NESTED_DATA_BP) | SF(LFENCE_RDTSC) | 0 /* SmmPgCfgLock */ | + SF(NULL_SEL_CLR_BASE) | 0 /* PrefetchCtlMsr */ + ); + if (cpu_feature_enabled(X86_FEATURE_LFENCE_RDTSC)) + kvm_cpu_cap_set(X86_FEATURE_LFENCE_RDTSC); + if (!static_cpu_has_bug(X86_BUG_NULL_SEG)) + kvm_cpu_cap_set(X86_FEATURE_NULL_SEL_CLR_BASE); + kvm_cpu_cap_mask(CPUID_C000_0001_EDX, F(XSTORE) | F(XSTORE_EN) | F(XCRYPT) | F(XCRYPT_EN) | F(ACE2) | F(ACE2_EN) | F(PHE) | F(PHE_EN) | @@ -1211,21 +1220,7 @@ static inline int __do_cpuid_func(struct kvm_cpuid_array *array, u32 function) break; case 0x80000021: entry->ebx = entry->ecx = entry->edx = 0; - /* - * Pass down these bits: - * EAX 0 NNDBP, Processor ignores nested data breakpoints - * EAX 2 LAS, LFENCE always serializing - * EAX 6 NSCB, Null selector clear base - * - * Other defined bits are for MSRs that KVM does not expose: - * EAX 3 SPCL, SMM page configuration lock - * EAX 13 PCMSR, Prefetch control MSR - */ - entry->eax &= BIT(0) | BIT(2) | BIT(6); - if (static_cpu_has(X86_FEATURE_LFENCE_RDTSC)) - entry->eax |= BIT(2); - if (!static_cpu_has_bug(X86_BUG_NULL_SEG)) - entry->eax |= BIT(6); + cpuid_entry_override(entry, CPUID_8000_0021_EAX); break; /*Add support for Centaur's CPUID instruction*/ case 0xC0000000: diff --git a/arch/x86/kvm/reverse_cpuid.h b/arch/x86/kvm/reverse_cpuid.h index 4e5b8444f161..184614e27d5b 100644 --- a/arch/x86/kvm/reverse_cpuid.h +++ b/arch/x86/kvm/reverse_cpuid.h @@ -13,6 +13,7 @@ */ enum kvm_only_cpuid_leafs { CPUID_12_EAX = NCAPINTS, + CPUID_8000_0021_EAX, NR_KVM_CPU_CAPS, NKVMCAPINTS = NR_KVM_CPU_CAPS - NCAPINTS, @@ -25,6 +26,11 @@ enum kvm_only_cpuid_leafs { #define KVM_X86_FEATURE_SGX2 KVM_X86_FEATURE(CPUID_12_EAX, 1) #define KVM_X86_FEATURE_SGX_EDECCSSA KVM_X86_FEATURE(CPUID_12_EAX, 11) +/* AMD-defined Extended Feature 2 EAX, CPUID level 0x80000021 (EAX) */ +#define KVM_X86_FEATURE_NO_NESTED_DATA_BP KVM_X86_FEATURE(CPUID_8000_0021_EAX, 0) +#define KVM_X86_FEATURE_LFENCE_RDTSC KVM_X86_FEATURE(CPUID_8000_0021_EAX, 2) +#define KVM_X86_FEATURE_NULL_SEL_CLR_BASE KVM_X86_FEATURE(CPUID_8000_0021_EAX, 6) + struct cpuid_reg { u32 function; u32 index; @@ -49,6 +55,7 @@ static const struct cpuid_reg reverse_cpuid[] = { [CPUID_7_1_EAX] = { 7, 1, CPUID_EAX}, [CPUID_12_EAX] = {0x00000012, 0, CPUID_EAX}, [CPUID_8000_001F_EAX] = {0x8000001f, 0, CPUID_EAX}, + [CPUID_8000_0021_EAX] = {0x80000021, 0, CPUID_EAX}, }; /* @@ -75,12 +82,15 @@ static __always_inline void reverse_cpuid_check(unsigned int x86_leaf) */ static __always_inline u32 __feature_translate(int x86_feature) { - if (x86_feature == X86_FEATURE_SGX1) - return KVM_X86_FEATURE_SGX1; - else if (x86_feature == X86_FEATURE_SGX2) - return KVM_X86_FEATURE_SGX2; - else if (x86_feature == X86_FEATURE_SGX_EDECCSSA) - return KVM_X86_FEATURE_SGX_EDECCSSA; + switch (x86_feature) { + case X86_FEATURE_SGX1: return KVM_X86_FEATURE_SGX1; + case X86_FEATURE_SGX2: return KVM_X86_FEATURE_SGX2; + case X86_FEATURE_SGX_EDECCSSA: return KVM_X86_FEATURE_SGX_EDECCSSA; + case X86_FEATURE_NO_NESTED_DATA_BP: return KVM_X86_FEATURE_NO_NESTED_DATA_BP; + case X86_FEATURE_LFENCE_RDTSC: return KVM_X86_FEATURE_LFENCE_RDTSC; + case X86_FEATURE_NULL_SEL_CLR_BASE: return KVM_X86_FEATURE_NULL_SEL_CLR_BASE; + default: break; + } return x86_feature; } From patchwork Thu Dec 1 01:50:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kim Phillips X-Patchwork-Id: 28139 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp18816wrr; Wed, 30 Nov 2022 17:54:36 -0800 (PST) X-Google-Smtp-Source: AA0mqf4DUw/wcPrZ24TP+K4Q90fff0JQHKq98fMG6hDzrSQ/tA+6psZbXJvtuswq5ef3YJAHvFCC X-Received: by 2002:a50:fc0b:0:b0:46b:5812:a03a with SMTP id i11-20020a50fc0b000000b0046b5812a03amr12358437edr.91.1669859675901; Wed, 30 Nov 2022 17:54:35 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1669859675; cv=pass; d=google.com; s=arc-20160816; b=xbOWRwy4w5FpkAlddQl+W4MZ4iVX4UDIbVDDiFphGL2Y3lVjablbw6jVj3bq2MowD4 P4+ahxZ8FjrAZ2He3fA0lB5GLb1eo4vNlNOewS7ep14JEHy5XAXVbM/jsE/mA5ELkeE6 sbl5npeXha5GYQp66sVPR3WS2FkcWBQghzNV8KbqpgsUeqlZ/Vt60suOkX9CAjG8Tlai RaPRzA/DP9pO9cQZ/WkV90tamGzHSili7th8CWLKrHy5xGnhjZ423zQnr0wAxKyXYmdM WHfil2kORa/3QugAAmuqBZZx7SReIpadpvaX7N7jEyWqAnaWIoCikh0TNmvBEikG+l/y l6xg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=nLPAgpLB0LB1NW30EwhKp8uwdbTzlYuf2+gh4q0kInA=; b=zfo1+kb7/WJvx3Q0oU3RJ9Nxa2hE9wHPWFqqE+biB/Cn9yDcF/7tiDUIa69AjnhDn/ p437X3aq7gxARTmToELnluPh4xkn3J6uMnN920vca5yFOo4UIus9PQTpkw832Me/iR8s KR2uhLbrVKP/qcb3qdzZZLG338XA9LVLPd0VdQstMfIj98UvGgeVVooCzEIHf/S9FfcR f3WqGbnCCNqAm8prQWSpsgoxv3sOqdS3MCu5eF+5XlTXGA0MaNUy00dD3UUr2FWdak+0 aZ4GihwQ1kvRuZH2E/lxA6rI4+igBP4OX8XXEIFBJOxge6Kg975pN2aUtsRNDcnZS+mr GmXQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=CmJulSZj; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s14-20020a05640217ce00b0046453c36c4csi2505833edy.513.2022.11.30.17.54.13; Wed, 30 Nov 2022 17:54:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=CmJulSZj; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229966AbiLABvw (ORCPT + 99 others); Wed, 30 Nov 2022 20:51:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229680AbiLABvi (ORCPT ); Wed, 30 Nov 2022 20:51:38 -0500 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2054.outbound.protection.outlook.com [40.107.223.54]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F60A9AE2A; Wed, 30 Nov 2022 17:51:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=htDxSX6W9bylxNXpVzKhForjnFHV7+LB0XrjdqH6UrFOcRYe16pWHiYRFIB78KbKGExkEGjqOqZJSpXnEsNSb8vENfP97fKUepVNtl0UIGTcooVAPXzPqSdCKRv2iKBjJPXEe5C50RnWjUedHm+AAuhpB91U2q2rbS6kYDZ8mSKDAQVGBW4rwl5ViY9J1YFlTg+oLFGzJwKI1wY1rMJRbboEgKi9FQnQGzZN/rz21XhU9YhEVGg2laEHZYnorS3zYu5JfvW6K2Agq+o8Fmkckg/ggJ1Z1DyBhUf7nKLpDBWt3mg4zVZLorotWX4pnReWqVqGwmX/+1YbZnzfCOGwTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nLPAgpLB0LB1NW30EwhKp8uwdbTzlYuf2+gh4q0kInA=; b=YBfWWVfGr38ZRpzPmXQnbUAXOe892Ek1B/h3Rq9YTp5xFI7Q7MAo5L5/pkJUlUbJFONBpXsFnBClUyDIwS0MH0UzPYJ92Rx74r4R/jc9j6P8kKFbwI/7COcHXo4yUObuMu4GXpYLRJsuzCIb9jvtJTGZT2WejrgkpVnZP9dL85K70xd6AfpeyWQFJAgSHlhMKvkRo8S8RRsazK8vL5sj3htOXxATFQBs25gJW747MaXUu3+txgIVlwFsI1u8LtN7fW9+E3C+UabC1rW6I7rrcfSpGDnvSacebL+IgODE8RiC/HLvB6LELbe+x5O4JYFm7QFUGLA//sYd4IymXjrq3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nLPAgpLB0LB1NW30EwhKp8uwdbTzlYuf2+gh4q0kInA=; b=CmJulSZjEt4I5q6IzrD435WpAyXPF37Svpc8w6TlM/bO7ft5RRlLT1PvG+fb5XEL3WOvZPSwPWtNDMC4PK2GpGQoVSfxAu2KH8o7XDpMHzOaJteNLDiyVIBIRs40nmAzX65pJmEQZvBvH4zyPeZL47F3W43oofNDrP9ADeiOpI0= Received: from BN8PR16CA0004.namprd16.prod.outlook.com (2603:10b6:408:4c::17) by DS7PR12MB5959.namprd12.prod.outlook.com (2603:10b6:8:7e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Thu, 1 Dec 2022 01:51:34 +0000 Received: from BN8NAM11FT025.eop-nam11.prod.protection.outlook.com (2603:10b6:408:4c:cafe::8a) by BN8PR16CA0004.outlook.office365.com (2603:10b6:408:4c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17 via Frontend Transport; Thu, 1 Dec 2022 01:51:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT025.mail.protection.outlook.com (10.13.177.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5857.17 via Frontend Transport; Thu, 1 Dec 2022 01:51:34 +0000 Received: from fritz.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 30 Nov 2022 19:51:32 -0600 From: Kim Phillips To: CC: Kim Phillips , Babu Moger , Borislav Petkov , Borislav Petkov , Boris Ostrovsky , Dave Hansen , "H. Peter Anvin" , Ingo Molnar , Joao Martins , Jonathan Corbet , "Konrad Rzeszutek Wilk" , Paolo Bonzini , Sean Christopherson , Thomas Gleixner , David Woodhouse , Greg Kroah-Hartman , Juergen Gross , Peter Zijlstra , Tony Luck , Tom Lendacky , Alexey Kardashevskiy , , , Subject: [PATCH v4 5/7] x86/cpu: Define a scattered AMD Automatic IBRS feature bit Date: Wed, 30 Nov 2022 19:50:01 -0600 Message-ID: <20221201015003.295769-6-kim.phillips@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221201015003.295769-1-kim.phillips@amd.com> References: <20221201015003.295769-1-kim.phillips@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT025:EE_|DS7PR12MB5959:EE_ X-MS-Office365-Filtering-Correlation-Id: 32834dd2-295f-4ac9-8014-08dad33e93b9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PXmMy+SaTmF3dkWPmiZ4as4uM+G/mCSqy7ETFPBgK9n8+rZuoo4XQrQDhzqSufEGmjmyUCBWY46rN/hx8mgpHLYhkDfCwGNESVBhWRGm6jQG2zFKGjFS/v7u5NMWQirnzEAmahbZizzdo2mxh63CrrP8M8v87Gxk9hyF4JlgOQi9ZCr2QgA/QMYIoXJONfGq3ISPcXXZ7I0W9XkX/1BxSAK4uywf0+LzXYT5BHfFyFBI55pWjoKoD7oknWNO8SQ7jQyriTt3dVDkKRLdVgX7eGDA9MpvYN3zPi3Y8+I7CegCd3ZnSLNLMcPQHqrH2GjP4R07zYuYSBduxfB4P3HW0N3kVEqUrgBkzyVwK5R1wqBRfvFp+11WYuJTv+Sbn5PZe5RB+R4EnDO6Q34NK5DEKzFJt1KZ16qfK5vkjb6KNMeWxZ3VNPPBMBSx/llCHrAPMuCYLxNsXbhuknExofqZuTKpz1Jn10+PnIxwhDYrAjEd6qqivd+Gb7IWCMStpGiTAxaTqFL47XpR9qOvj7q1NjgGkS/2G70oQuYBejrDeHPPtX997B+uk0s1BrsCOgGYlYLwetyKlsEfEsAv0YjGcYVmB8ih9zrcDW88UcvbdWzILuNhn1hVOLvcH7358zxiGTxmjSDSr8uXWhHPjWa6iYve1rHzGQdPt10KESWXXRh8F7NjPxtm9mDT4Qy5PPCnPUh3nMqv7QFLNzi3LHIpjwrFTuNFpSE4+5T6gGnn+0s= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(136003)(396003)(376002)(451199015)(40470700004)(36840700001)(46966006)(82740400003)(478600001)(36756003)(82310400005)(40480700001)(26005)(6666004)(7696005)(81166007)(41300700001)(40460700003)(70586007)(356005)(70206006)(8676002)(86362001)(316002)(4326008)(426003)(44832011)(54906003)(7416002)(6916009)(8936002)(5660300002)(336012)(47076005)(2616005)(16526019)(186003)(1076003)(2906002)(36860700001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2022 01:51:34.5718 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 32834dd2-295f-4ac9-8014-08dad33e93b9 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT025.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5959 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750974779437202857?= X-GMAIL-MSGID: =?utf-8?q?1750974779437202857?= It's bit 8 of the hardware CPUID 0x80000021 EAX leaf. Signed-off-by: Kim Phillips --- arch/x86/include/asm/cpufeatures.h | 1 + arch/x86/kernel/cpu/scattered.c | 1 + 2 files changed, 2 insertions(+) diff --git a/arch/x86/include/asm/cpufeatures.h b/arch/x86/include/asm/cpufeatures.h index 5ddde18c1ae8..961eb49532b7 100644 --- a/arch/x86/include/asm/cpufeatures.h +++ b/arch/x86/include/asm/cpufeatures.h @@ -309,6 +309,7 @@ #define X86_FEATURE_MSR_TSX_CTRL (11*32+20) /* "" MSR IA32_TSX_CTRL (Intel) implemented */ #define X86_FEATURE_NO_NESTED_DATA_BP (11*32+21) /* "" AMD No Nested Data Breakpoints */ #define X86_FEATURE_NULL_SEL_CLR_BASE (11*32+22) /* "" AMD Null Selector Clears Base */ +#define X86_FEATURE_AUTOIBRS (11*32+23) /* AMD Automatic IBRS */ /* Intel-defined CPU features, CPUID level 0x00000007:1 (EAX), word 12 */ #define X86_FEATURE_AVX_VNNI (12*32+ 4) /* AVX VNNI instructions */ diff --git a/arch/x86/kernel/cpu/scattered.c b/arch/x86/kernel/cpu/scattered.c index caa03466cd9e..7ae7203cd410 100644 --- a/arch/x86/kernel/cpu/scattered.c +++ b/arch/x86/kernel/cpu/scattered.c @@ -48,6 +48,7 @@ static const struct cpuid_bit cpuid_bits[] = { { X86_FEATURE_NO_NESTED_DATA_BP,CPUID_EAX, 0, 0x80000021, 0 }, { X86_FEATURE_LFENCE_RDTSC, CPUID_EAX, 2, 0x80000021, 0 }, { X86_FEATURE_NULL_SEL_CLR_BASE,CPUID_EAX, 6, 0x80000021, 0 }, + { X86_FEATURE_AUTOIBRS, CPUID_EAX, 8, 0x80000021, 0 }, { X86_FEATURE_PERFMON_V2, CPUID_EAX, 0, 0x80000022, 0 }, { X86_FEATURE_AMD_LBR_V2, CPUID_EAX, 1, 0x80000022, 0 }, { 0, 0, 0, 0, 0 } From patchwork Thu Dec 1 01:50:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kim Phillips X-Patchwork-Id: 28142 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp19199wrr; Wed, 30 Nov 2022 17:55:39 -0800 (PST) X-Google-Smtp-Source: AA0mqf6lnDw1ZpKlp4w1bm6cqGKzBEwjvMK+ZrqNz4GdO+3p8bPQPlI8uKwSm6oTaQlmuDXk5MkQ X-Received: by 2002:a62:65c3:0:b0:562:ce80:1417 with SMTP id z186-20020a6265c3000000b00562ce801417mr44902854pfb.19.1669859739021; Wed, 30 Nov 2022 17:55:39 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1669859739; cv=pass; d=google.com; s=arc-20160816; b=By9bdw8ZQ40ztL/0OoDZASJw/dWZpmQ03MVoreZYPKP3yvHT64JSsfaK1Odo2McSVk EUx6p+J89xYD25Qw2k+RlUU58Zjj93ek03iFPobuPWrGmP98cPG1QGPRqJwowEb2gbvl i3PT6m2JlHCcWQ0h8eKe8tajTVkvC8F/rGau5tQEI6MGZzHIhxecsKUnaEVylde4/q8p MrzfiCrJs+YnGWgUlBo5eFCmlKTubGKaP1Vx6WJ3Ktkdq0ftlpdErqpVd+pb1zOUN+HI XRxuWtem/jK3kzC32/lZzfC+Q1wkYJhtQ75aBW4wHXUv2IQJCatM7VlX4+CccplxRc55 pfDA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=hEW5AcBM0fkpDmw3OScjt3JwsuZITjrvbv29y76pQO0=; b=ZEQVbl0HQEjb5NWZD5I0LxOZTFjEggA+j4617mTE1bG1TvqBfTM51SzTKi0lalGKlb 4YJf/UGxxWsEoFoSjvPEI+cjpcQgXGfR0MeyeSuhGnRDfM6Wf/+GQ0vAXCPQhu+8n82Z dXLAd6lXyglnKC+nWE7CSx1WSrBI1VCJOr/DRO/Ztg8SMPjwHzwDMN/C/fg1A/XoGmdh P6ZzGqySnLtPHNvn2m4MwOV2uKuDbEnSeReCtQuXlwGTr56QfUVs59Tij/wa3aBITFGH 8GJ+WSXk/ZPaRpGaWv6P82mJxHE3gPzngf83pPXpAcVPKB0UbBGdd5vOxgQDqWzm2fA2 rjhA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=3oT02xKT; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f8-20020a056a001ac800b00565a581ecc0si3637415pfv.11.2022.11.30.17.55.25; Wed, 30 Nov 2022 17:55:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=3oT02xKT; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229948AbiLABwF (ORCPT + 99 others); Wed, 30 Nov 2022 20:52:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229957AbiLABvu (ORCPT ); Wed, 30 Nov 2022 20:51:50 -0500 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9F289C617; Wed, 30 Nov 2022 17:51:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gNto2HLq/7CT5pd4PJFBjgApknIEj8s4uHqVAUL9a5wtx3BfVJWYgEv32og7RsOJvkoHSAVUMuTuIr1/uO/j11hyZaJr4SLemHSdLKwi9RNXIL0qbpoUsZL6x1bFYuWAz2CO83QUfHCwgacllkSWZV/PYWKqODAEV3DfJRvVk180G94tmTdApnhyy1c5LN6WObg2iJv0TFBBj5qBG8lnVTbsybsUbTueTl1H3WedOuWAoKUqbfNhqOhjxpca5jJxasKpf482qo86hvoJeoX5/ezrN4dDVF+9PihodHiuGvF21iQlnbcz8v+zsY5bdxEEcnnNgqmX2/fjSDyAJOnZrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hEW5AcBM0fkpDmw3OScjt3JwsuZITjrvbv29y76pQO0=; b=On9hdGBACjx7DCG8P3FBfIQ54xq+Cx0KUX/5+TakLpWsJLzNlmSaa9xKTfWhXIFo52yN6r+SchLMPm4xqo+Xbm7yHbEJkweTZi4RDq253cRKCZSWIRrsyb3JXd+AA+ANw4k6uzwEcEO1MGs1vCLtl0gpkkP2IJFeU6/J4WxZS/z9v69wG5hPh087eMzrQqaWc5aX1SoTs8dsCUo6SBdnYAClgpPOqgDWvFxn3nYfkQLEUtyD22Cbcb+C2tY6Fg597Qsqqam24ZFPRxY++4/IzL4PdEQgNp2tAE2n4iaRR2JOOQkDl0mf0+9+nAvSs2Da1g+8rGEJXfAJBIvnpastvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hEW5AcBM0fkpDmw3OScjt3JwsuZITjrvbv29y76pQO0=; b=3oT02xKT0LfLw8sGwdNHEMmFrDzJgxWbKhsL4jKmMGDmN95fZNBfVB3/OoUgiM4TwK7/oUH0m4KjpsXVCcevTh1PT0OB40G3mu9WVd16ttJUVvPGOvWl7LuunH4MB34WNB/ZnEe3ueEk+Mn12xaY+DR02sfFCy1JL5TI3Yf4/v0= Received: from BN0PR03CA0050.namprd03.prod.outlook.com (2603:10b6:408:e7::25) by PH8PR12MB7112.namprd12.prod.outlook.com (2603:10b6:510:22c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Thu, 1 Dec 2022 01:51:46 +0000 Received: from BN8NAM11FT061.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e7:cafe::69) by BN0PR03CA0050.outlook.office365.com (2603:10b6:408:e7::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23 via Frontend Transport; Thu, 1 Dec 2022 01:51:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT061.mail.protection.outlook.com (10.13.177.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5857.18 via Frontend Transport; Thu, 1 Dec 2022 01:51:45 +0000 Received: from fritz.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 30 Nov 2022 19:51:44 -0600 From: Kim Phillips To: CC: Kim Phillips , Babu Moger , Borislav Petkov , Borislav Petkov , Boris Ostrovsky , Dave Hansen , "H. Peter Anvin" , Ingo Molnar , Joao Martins , Jonathan Corbet , "Konrad Rzeszutek Wilk" , Paolo Bonzini , Sean Christopherson , Thomas Gleixner , David Woodhouse , Greg Kroah-Hartman , Juergen Gross , Peter Zijlstra , Tony Luck , Tom Lendacky , Alexey Kardashevskiy , , , Subject: [PATCH v4 6/7] x86/cpu: Support AMD Automatic IBRS Date: Wed, 30 Nov 2022 19:50:02 -0600 Message-ID: <20221201015003.295769-7-kim.phillips@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221201015003.295769-1-kim.phillips@amd.com> References: <20221201015003.295769-1-kim.phillips@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT061:EE_|PH8PR12MB7112:EE_ X-MS-Office365-Filtering-Correlation-Id: c37ae3d7-ff96-49e0-e614-08dad33e9a55 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: E5OhBqF9diVCxuc74T576GFrKFjfNll2L8Sc2TvHU2cd3eAbtDEnJz/wOXAGPpQnzHGxEszrn5qHZF6i8oUTTod3/sdRcWvP77h8jkGdEwDGNRk+GfR0WK/0Bai0vL5yBWwR96e8LD06SV8yyqT5ZT2bPNh/D+vPlwzPxQcz8zjzuqv3H8nQeJrZ6z/2xTLBZRBV/+/nG9W1YllnyiekiXzmtYFvY8RELH5QjFWrQ3Hc+MyYs36MNioJ/3o9E0yVOEIAYPyHuSfV+6boSqTu+Q/ohEML3Lg/UjMYLorXwpfwSVugQBAVmJ56+hv0QYg6Lz2bcEOw4BNagBnnLVd+LI831/B/H/tdeSoqY/YRZDz/03zjT/ZiLPSZTxVUKaLZZx4ZkzGqw6oysJq3hZrKxL+3z4hCVrB3dzBuy6ncxlQN42wEuh3UMIWWLzeYIeZrjcTQTcUYzi8R90udpoU9SDND1tPDJ6f88F5+I5Q/6LcwKOkd759j77YRnCqX6NXzVjzvUj9z653CwI72CfOrOMHKWUsLZJWM/n67HwcDQBS9xny9l2w8SQkg0d2vAQ6zQBFJCV1k6w87xMf5fK8Rhi9OlUYVNIyDPwV3cd4bkJF0k7wzvB278TU8ezplQpBy+P1i5jrmntEJn6iqIuyx0k0HOKYQCPsE2sYq0+QEZtspZ1fwFdFMZ7hkmBfeRRyiX+jeWDsuvey00dopVCD3V3GdH7uz8iXLH0MtPrS15X4= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(136003)(396003)(376002)(451199015)(40470700004)(36840700001)(46966006)(82740400003)(478600001)(36756003)(82310400005)(40480700001)(26005)(6666004)(7696005)(81166007)(41300700001)(40460700003)(70586007)(356005)(70206006)(8676002)(86362001)(316002)(4326008)(426003)(44832011)(54906003)(7416002)(6916009)(8936002)(5660300002)(336012)(47076005)(2616005)(16526019)(186003)(1076003)(83380400001)(2906002)(36860700001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2022 01:51:45.6631 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c37ae3d7-ff96-49e0-e614-08dad33e9a55 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT061.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7112 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750974845616203342?= X-GMAIL-MSGID: =?utf-8?q?1750974845616203342?= The AMD Zen4 core supports a new feature called Automatic IBRS. It is a "set-and-forget" feature that means that, like Intel's Enhanced IBRS, h/w manages its IBRS mitigation resources automatically across CPL transitions. The feature is advertised by CPUID_Fn80000021_EAX bit 8 and is enabled by setting MSR C000_0080 (EFER) bit 21. Enable Automatic IBRS by default if the CPU feature is present. It typically provides greater performance over the incumbent generic retpolines mitigation. Reuse the SPECTRE_V2_EIBRS spectre_v2_mitigation enum. AMD Automatic IBRS and Intel Enhanced IBRS have similar bugs.c enablement. Add NO_EIBRS_PBRSB to cpu_vuln_whitelist, since AMD Automatic IBRS isn't affected by PBRSB-eIBRS. Also allow for spectre_v2=autoibrs on the kernel command line. 'spectre_v2=autoibrs,retpoline' and 'autoibrs,lfence' are honoured but not required. AutoIBRS will also be enabled if the =eibrs[,{lfence,retpoline}] variants are specified. Signed-off-by: Kim Phillips --- .../admin-guide/kernel-parameters.txt | 9 +++++--- arch/x86/include/asm/msr-index.h | 2 ++ arch/x86/kernel/cpu/bugs.c | 23 ++++++++++++------- arch/x86/kernel/cpu/common.c | 17 ++++++++------ 4 files changed, 33 insertions(+), 18 deletions(-) diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt index a465d5242774..880016d06a8a 100644 --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -5698,9 +5698,12 @@ retpoline,generic - Retpolines retpoline,lfence - LFENCE; indirect branch retpoline,amd - alias for retpoline,lfence - eibrs - enhanced IBRS - eibrs,retpoline - enhanced IBRS + Retpolines - eibrs,lfence - enhanced IBRS + LFENCE + eibrs - Enhanced/Auto IBRS + autoibrs - Enhanced/Auto IBRS + eibrs,retpoline - Enhanced/Auto IBRS + Retpolines + autoibrs,retpoline- Enhanced/Auto IBRS + Retpolines + eibrs,lfence - Enhanced/Auto IBRS + LFENCE + autoibrs,lfence - Enhanced/Auto IBRS + LFENCE ibrs - use IBRS to protect kernel Not specifying this option is equivalent to diff --git a/arch/x86/include/asm/msr-index.h b/arch/x86/include/asm/msr-index.h index 37ff47552bcb..6843d6241203 100644 --- a/arch/x86/include/asm/msr-index.h +++ b/arch/x86/include/asm/msr-index.h @@ -25,6 +25,7 @@ #define _EFER_SVME 12 /* Enable virtualization */ #define _EFER_LMSLE 13 /* Long Mode Segment Limit Enable */ #define _EFER_FFXSR 14 /* Enable Fast FXSAVE/FXRSTOR */ +#define _EFER_AUTOIBRS 21 /* Enable Automatic IBRS */ #define EFER_SCE (1<<_EFER_SCE) #define EFER_LME (1<<_EFER_LME) @@ -33,6 +34,7 @@ #define EFER_SVME (1<<_EFER_SVME) #define EFER_LMSLE (1<<_EFER_LMSLE) #define EFER_FFXSR (1<<_EFER_FFXSR) +#define EFER_AUTOIBRS (1<<_EFER_AUTOIBRS) /* Intel MSRs. Some also available on other CPUs */ diff --git a/arch/x86/kernel/cpu/bugs.c b/arch/x86/kernel/cpu/bugs.c index 84c14e11db90..b17786d87b40 100644 --- a/arch/x86/kernel/cpu/bugs.c +++ b/arch/x86/kernel/cpu/bugs.c @@ -1222,9 +1222,9 @@ static const char * const spectre_v2_strings[] = { [SPECTRE_V2_NONE] = "Vulnerable", [SPECTRE_V2_RETPOLINE] = "Mitigation: Retpolines", [SPECTRE_V2_LFENCE] = "Mitigation: LFENCE", - [SPECTRE_V2_EIBRS] = "Mitigation: Enhanced IBRS", - [SPECTRE_V2_EIBRS_LFENCE] = "Mitigation: Enhanced IBRS + LFENCE", - [SPECTRE_V2_EIBRS_RETPOLINE] = "Mitigation: Enhanced IBRS + Retpolines", + [SPECTRE_V2_EIBRS] = "Mitigation: Enhanced / Automatic IBRS", + [SPECTRE_V2_EIBRS_LFENCE] = "Mitigation: Enhanced / Automatic IBRS + LFENCE", + [SPECTRE_V2_EIBRS_RETPOLINE] = "Mitigation: Enhanced / Automatic IBRS + Retpolines", [SPECTRE_V2_IBRS] = "Mitigation: IBRS", }; @@ -1240,8 +1240,11 @@ static const struct { { "retpoline,lfence", SPECTRE_V2_CMD_RETPOLINE_LFENCE, false }, { "retpoline,generic", SPECTRE_V2_CMD_RETPOLINE_GENERIC, false }, { "eibrs", SPECTRE_V2_CMD_EIBRS, false }, + { "autoibrs", SPECTRE_V2_CMD_EIBRS, false }, { "eibrs,lfence", SPECTRE_V2_CMD_EIBRS_LFENCE, false }, + { "autoibrs,lfence", SPECTRE_V2_CMD_EIBRS_LFENCE, false }, { "eibrs,retpoline", SPECTRE_V2_CMD_EIBRS_RETPOLINE, false }, + { "autoibrs,retpoline", SPECTRE_V2_CMD_EIBRS_RETPOLINE, false }, { "auto", SPECTRE_V2_CMD_AUTO, false }, { "ibrs", SPECTRE_V2_CMD_IBRS, false }, }; @@ -1293,7 +1296,7 @@ static enum spectre_v2_mitigation_cmd __init spectre_v2_parse_cmdline(void) cmd == SPECTRE_V2_CMD_EIBRS_LFENCE || cmd == SPECTRE_V2_CMD_EIBRS_RETPOLINE) && !boot_cpu_has(X86_FEATURE_IBRS_ENHANCED)) { - pr_err("%s selected but CPU doesn't have eIBRS. Switching to AUTO select\n", + pr_err("%s selected but CPU doesn't have Enhanced or Automatic IBRS. Switching to AUTO select\n", mitigation_options[i].option); return SPECTRE_V2_CMD_AUTO; } @@ -1479,8 +1482,12 @@ static void __init spectre_v2_select_mitigation(void) pr_err(SPECTRE_V2_EIBRS_EBPF_MSG); if (spectre_v2_in_ibrs_mode(mode)) { - x86_spec_ctrl_base |= SPEC_CTRL_IBRS; - write_spec_ctrl_current(x86_spec_ctrl_base, true); + if (boot_cpu_has(X86_FEATURE_AUTOIBRS)) { + msr_set_bit(MSR_EFER, _EFER_AUTOIBRS); + } else { + x86_spec_ctrl_base |= SPEC_CTRL_IBRS; + write_spec_ctrl_current(x86_spec_ctrl_base, true); + } } switch (mode) { @@ -1564,8 +1571,8 @@ static void __init spectre_v2_select_mitigation(void) /* * Retpoline protects the kernel, but doesn't protect firmware. IBRS * and Enhanced IBRS protect firmware too, so enable IBRS around - * firmware calls only when IBRS / Enhanced IBRS aren't otherwise - * enabled. + * firmware calls only when IBRS / Enhanced / Automatic IBRS aren't + * otherwise enabled. * * Use "mode" to check Enhanced IBRS instead of boot_cpu_has(), because * the user might select retpoline on the kernel command line and if diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c index 8d28cd7c9072..965596433e81 100644 --- a/arch/x86/kernel/cpu/common.c +++ b/arch/x86/kernel/cpu/common.c @@ -1226,7 +1226,7 @@ static const __initconst struct x86_cpu_id cpu_vuln_whitelist[] = { VULNWL_AMD(0x12, NO_MELTDOWN | NO_SSB | NO_L1TF | NO_MDS | NO_SWAPGS | NO_ITLB_MULTIHIT | NO_MMIO), /* FAMILY_ANY must be last, otherwise 0x0f - 0x12 matches won't work */ - VULNWL_AMD(X86_FAMILY_ANY, NO_MELTDOWN | NO_L1TF | NO_MDS | NO_SWAPGS | NO_ITLB_MULTIHIT | NO_MMIO), + VULNWL_AMD(X86_FAMILY_ANY, NO_MELTDOWN | NO_L1TF | NO_MDS | NO_SWAPGS | NO_ITLB_MULTIHIT | NO_MMIO | NO_EIBRS_PBRSB), VULNWL_HYGON(X86_FAMILY_ANY, NO_MELTDOWN | NO_L1TF | NO_MDS | NO_SWAPGS | NO_ITLB_MULTIHIT | NO_MMIO), /* Zhaoxin Family 7 */ @@ -1338,8 +1338,16 @@ static void __init cpu_set_bug_bits(struct cpuinfo_x86 *c) !cpu_has(c, X86_FEATURE_AMD_SSB_NO)) setup_force_cpu_bug(X86_BUG_SPEC_STORE_BYPASS); - if (ia32_cap & ARCH_CAP_IBRS_ALL) + /* + * AMD's AutoIBRS is equivalent to Intel's eIBRS - use the Intel feature + * flag and protect from vendor-specific bugs via the whitelist. + */ + if ((ia32_cap & ARCH_CAP_IBRS_ALL) || cpu_has(c, X86_FEATURE_AUTOIBRS)) { setup_force_cpu_cap(X86_FEATURE_IBRS_ENHANCED); + if (!cpu_matches(cpu_vuln_whitelist, NO_EIBRS_PBRSB) && + !(ia32_cap & ARCH_CAP_PBRSB_NO)) + setup_force_cpu_bug(X86_BUG_EIBRS_PBRSB); + } if (!cpu_matches(cpu_vuln_whitelist, NO_MDS) && !(ia32_cap & ARCH_CAP_MDS_NO)) { @@ -1401,11 +1409,6 @@ static void __init cpu_set_bug_bits(struct cpuinfo_x86 *c) setup_force_cpu_bug(X86_BUG_RETBLEED); } - if (cpu_has(c, X86_FEATURE_IBRS_ENHANCED) && - !cpu_matches(cpu_vuln_whitelist, NO_EIBRS_PBRSB) && - !(ia32_cap & ARCH_CAP_PBRSB_NO)) - setup_force_cpu_bug(X86_BUG_EIBRS_PBRSB); - if (cpu_matches(cpu_vuln_whitelist, NO_MELTDOWN)) return; From patchwork Thu Dec 1 01:50:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kim Phillips X-Patchwork-Id: 28140 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp19020wrr; Wed, 30 Nov 2022 17:55:12 -0800 (PST) X-Google-Smtp-Source: AA0mqf55wuwGIxGfkA4qOLzgHQ4We6ttNoQznMfp3vyYfytY18tmlmxTcz1XaHXBF+trCIcF4OMk X-Received: by 2002:a63:e404:0:b0:477:f6be:b65b with SMTP id a4-20020a63e404000000b00477f6beb65bmr21690202pgi.362.1669859712466; Wed, 30 Nov 2022 17:55:12 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1669859712; cv=pass; d=google.com; s=arc-20160816; b=qXmYqug46qFq4tPqHvtC+nCcCNqU8S0aqREAXt8KPYj3GSJ7u+AuHbQuokypd7qB/w 82BaR08X1MzZuurFuYYGnjGKQAj9U5bvrKoCbJr1KQUVmaIDCEpjfKYvb4cHIY4yZ6E4 zn2B7/iw1qWXjkpWIrLfshA1GMcXB66IWS47busRv1XMcsRueojS09qXGd3prkppJtGv wtR5Yt+sgWfNLU8rcvDRF+5nW7lKnHofjAJ2wZf8fKLrc5WX/jIab9i+yook98ch1L1y jU4dZ6lBQGa/m7mhCN2qgHb4rtnYNX5/zA3BE59vPp+zRxfsDuLijOhP0paISkQHwqwn 9fAA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=v5yn4H32ZvqdpqIu7ciQSfsvPTxyx1+k4NA+Q6Ls32E=; b=TfVLCz3dxdjgmaxqeem51Nb1k1yd+ECvgAtjwjAPxOOuD38dDkHmsTGIDF0aTneAFn RX5S5pfJYZh6weeMdrh9K3FdI79U2bHO/rDUak//6gDCAcvUYXLVwy1RszHbEMxpr2JI hLQzYoI519HR2LxJlqMW7Q5QWmNTfygc8TgX+dBJ4Kk99DFKfHuuhRpMohrrJXPDlyDm na6/ZJToAwjMXLStZ5t2IIvtaN4gwvFsWGG5+FVHeiZgippVd/N7TTpOUVJZpCF9ZehO nQ23XSwN1Vurv5N71wN5jAwdq1AQdyqTVimIwVkKXN8Ri/UJ3ihYgLZsYPIV+Eccswfe Uvag== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=3W2DfRvJ; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 195-20020a6302cc000000b004767bc4252csi3008976pgc.519.2022.11.30.17.54.56; Wed, 30 Nov 2022 17:55:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=3W2DfRvJ; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229932AbiLABwL (ORCPT + 99 others); Wed, 30 Nov 2022 20:52:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229580AbiLABwD (ORCPT ); Wed, 30 Nov 2022 20:52:03 -0500 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2048.outbound.protection.outlook.com [40.107.212.48]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1356C9B78B; Wed, 30 Nov 2022 17:52:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FKX1ClBrWdT+0ntj1u8WmLMjKi1PHlDmUUPWko6EaCo7hfKMGDDxfzIKvGUBPUlpstEub/+dM+zhTt84dMrb0oAfH2c356mwv+8E/uAVu0oZ9D1H6rHzQa6cOUXSJlPHrXBBAsyzPSULSMztW51zHRZPwLRzDiiZKOkDjRmt8693hn+CpUcyDZKr5GBHwO3a0iaqYYo0hyAVNEO6jof8PY7faJX5Mv5M06d8EIN3BvIhWTX5VjabsKfbDqEL3eZ5I5SvGWb0k7M/WNGuJTdSNHeNQ06ugF48bN4ANzNhP2jQg8GcUPbTwd41zIaS3U99eryjlbwbE04SU6u0ha5kGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v5yn4H32ZvqdpqIu7ciQSfsvPTxyx1+k4NA+Q6Ls32E=; b=RGJVEMO/jMDTvXDcKpn86svYRjV4TicYmAzZxvQnjbrJ2tC3O2lDuhxzdI+viZ/0LB0jy2z+Pf8u0tQ02IyyKvVL54RBtG9QwNI9rrYK/GGo1fqHYWo1TnFxI3vp9fvuCnN1TyLWs2nunGOQIgeIlh3qnszuK8QslluhNnvjgiQifcp2K/Pvb6hIxu76OZDFWijlSnvszQkAEAD+KHc6UgXjq0mM+DdAs8xDEliDYultDAYF+OiRJgGqByrAFWmMJaZfTYlS2F1DP111mhhlHwMen0XOX7lmUZ6wE9c+15J/s4Q6REjEiGL/vzf/FQ31qeIsx5Dmh8pWrAvOtSS01A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v5yn4H32ZvqdpqIu7ciQSfsvPTxyx1+k4NA+Q6Ls32E=; b=3W2DfRvJ71dXrni1No0GaePL0DUFtcHVdG3Mp8aansSJx8Q9Pwh6cSdwqN+EZHSWp/83rlVr/ta+QJG8MlnmvoXEn8PLcGsyUVtRX+y6FO+XbRc283CupHfGq/kqBl4Mlej3p2+mktEz7TgiogEln+ThC9z/ioJZUwi0MLiC5f4= Received: from BN9PR03CA0225.namprd03.prod.outlook.com (2603:10b6:408:f8::20) by DM6PR12MB4188.namprd12.prod.outlook.com (2603:10b6:5:215::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Thu, 1 Dec 2022 01:51:57 +0000 Received: from BN8NAM11FT094.eop-nam11.prod.protection.outlook.com (2603:10b6:408:f8:cafe::cf) by BN9PR03CA0225.outlook.office365.com (2603:10b6:408:f8::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.8 via Frontend Transport; Thu, 1 Dec 2022 01:51:57 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT094.mail.protection.outlook.com (10.13.176.131) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5880.8 via Frontend Transport; Thu, 1 Dec 2022 01:51:57 +0000 Received: from fritz.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 30 Nov 2022 19:51:56 -0600 From: Kim Phillips To: CC: Kim Phillips , Babu Moger , Borislav Petkov , Borislav Petkov , Boris Ostrovsky , Dave Hansen , "H. Peter Anvin" , Ingo Molnar , Joao Martins , Jonathan Corbet , "Konrad Rzeszutek Wilk" , Paolo Bonzini , Sean Christopherson , Thomas Gleixner , David Woodhouse , Greg Kroah-Hartman , Juergen Gross , Peter Zijlstra , Tony Luck , Tom Lendacky , Alexey Kardashevskiy , , , Subject: [PATCH v4 7/7] x86/cpu, kvm: Propagate the AMD Automatic IBRS feature to the guest Date: Wed, 30 Nov 2022 19:50:03 -0600 Message-ID: <20221201015003.295769-8-kim.phillips@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221201015003.295769-1-kim.phillips@amd.com> References: <20221201015003.295769-1-kim.phillips@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT094:EE_|DM6PR12MB4188:EE_ X-MS-Office365-Filtering-Correlation-Id: 7d9001e8-fd08-4790-6bfc-08dad33ea176 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ILfn7DiucaIT4zbpN12X2zbbMeYqdM1z0nHVhHfGpaPN+lWLDgoYqWdAIxU11RRdppFOvFFwbFf3yfr8hKENlqxNmuRJUUIxbw21H2fTwFPMu3aoxxULSGF3ToCOVHR3vWTNbyDpzemIGRfVWVVY4tViMFOF6sMFPFcGCY/UsTjsdCZM4AoNHnGMWeNYWqQXUba/gLLAJvXMmCjenLxDr8dYEr3Dzmw2mRBnlBm0nhb08FlLLe5cEpHBLPI8hQ6wcrQv53uZxwngegqjxY2yciBsNX/ttqYAkvUyuVhFpQFm0aIzBkzHsjY1i1pkfGuSqzImGQ+Z761IgSwv3/BMMxgstcplp1v/r6axM8raVMAGfW1i7JkUPYBrOBr48L9p1xaZOTf9h8ZvlK0p0z024z2aZXfATaQ7LPBqZkyjsCEiWOZCQoBOHNL0a4PCErqBnbV6aFnvIveKb1l9N1Du3ZQtXH3MsSNMAqKYgdUhSknE1fyNdT/9m1RMCXh9jBVXU/RuGk0Biy05neIU1Hm0t8AagY+Q6ANep62vcBupGe4P8ekF2SNVTHV1r3k8GA/sxQco2h8P0rcDyfIpc3YkCForhPs0/xggj8JWU+a1qn58Rt+/+cXGUMvLmyLbaz7c+xSJNk07XyVcDsqy5+3hB0K33QdkBPhOupdMt+jg9dm86qQG0+zq+KY0bJX1vTWUHN9UlH/6wB47gkI8FzdQ3d9SEUUGqCLlsM1UgSW56b8= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(396003)(136003)(346002)(451199015)(40470700004)(46966006)(36840700001)(316002)(70586007)(478600001)(1076003)(70206006)(2906002)(40460700003)(81166007)(356005)(54906003)(36756003)(82740400003)(83380400001)(426003)(47076005)(26005)(6666004)(82310400005)(40480700001)(16526019)(2616005)(86362001)(336012)(36860700001)(7696005)(186003)(6916009)(7416002)(44832011)(5660300002)(41300700001)(8936002)(4326008)(8676002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2022 01:51:57.6203 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7d9001e8-fd08-4790-6bfc-08dad33ea176 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT094.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4188 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750974817567418161?= X-GMAIL-MSGID: =?utf-8?q?1750974817567418161?= Add the AMD Automatic IBRS feature bit to those being propagated to the guest, and enable the guest EFER bit. Signed-off-by: Kim Phillips --- arch/x86/kvm/cpuid.c | 2 +- arch/x86/kvm/reverse_cpuid.h | 2 ++ arch/x86/kvm/svm/svm.c | 3 +++ arch/x86/kvm/x86.c | 3 +++ 4 files changed, 9 insertions(+), 1 deletion(-) diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c index dd0fe79521eb..0ed3ad3e9341 100644 --- a/arch/x86/kvm/cpuid.c +++ b/arch/x86/kvm/cpuid.c @@ -732,7 +732,7 @@ void kvm_set_cpu_caps(void) kvm_cpu_cap_init_scattered(CPUID_8000_0021_EAX, SF(NO_NESTED_DATA_BP) | SF(LFENCE_RDTSC) | 0 /* SmmPgCfgLock */ | - SF(NULL_SEL_CLR_BASE) | 0 /* PrefetchCtlMsr */ + SF(NULL_SEL_CLR_BASE) | SF(AUTOIBRS) | 0 /* PrefetchCtlMsr */ ); if (cpu_feature_enabled(X86_FEATURE_LFENCE_RDTSC)) kvm_cpu_cap_set(X86_FEATURE_LFENCE_RDTSC); diff --git a/arch/x86/kvm/reverse_cpuid.h b/arch/x86/kvm/reverse_cpuid.h index 184614e27d5b..0bf02c02bb0a 100644 --- a/arch/x86/kvm/reverse_cpuid.h +++ b/arch/x86/kvm/reverse_cpuid.h @@ -30,6 +30,7 @@ enum kvm_only_cpuid_leafs { #define KVM_X86_FEATURE_NO_NESTED_DATA_BP KVM_X86_FEATURE(CPUID_8000_0021_EAX, 0) #define KVM_X86_FEATURE_LFENCE_RDTSC KVM_X86_FEATURE(CPUID_8000_0021_EAX, 2) #define KVM_X86_FEATURE_NULL_SEL_CLR_BASE KVM_X86_FEATURE(CPUID_8000_0021_EAX, 6) +#define KVM_X86_FEATURE_AUTOIBRS KVM_X86_FEATURE(CPUID_8000_0021_EAX, 8) struct cpuid_reg { u32 function; @@ -89,6 +90,7 @@ static __always_inline u32 __feature_translate(int x86_feature) case X86_FEATURE_NO_NESTED_DATA_BP: return KVM_X86_FEATURE_NO_NESTED_DATA_BP; case X86_FEATURE_LFENCE_RDTSC: return KVM_X86_FEATURE_LFENCE_RDTSC; case X86_FEATURE_NULL_SEL_CLR_BASE: return KVM_X86_FEATURE_NULL_SEL_CLR_BASE; + case X86_FEATURE_AUTOIBRS: return KVM_X86_FEATURE_AUTOIBRS; default: break; } diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c index 4b6d2b050e57..3ac3d4cfce24 100644 --- a/arch/x86/kvm/svm/svm.c +++ b/arch/x86/kvm/svm/svm.c @@ -4960,6 +4960,9 @@ static __init int svm_hardware_setup(void) tsc_aux_uret_slot = kvm_add_user_return_msr(MSR_TSC_AUX); + if (boot_cpu_has(X86_FEATURE_AUTOIBRS)) + kvm_enable_efer_bits(EFER_AUTOIBRS); + /* Check for pause filtering support */ if (!boot_cpu_has(X86_FEATURE_PAUSEFILTER)) { pause_filter_count = 0; diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 490ec23c8450..db0f522fd597 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -1682,6 +1682,9 @@ static int do_get_msr_feature(struct kvm_vcpu *vcpu, unsigned index, u64 *data) static bool __kvm_valid_efer(struct kvm_vcpu *vcpu, u64 efer) { + if (efer & EFER_AUTOIBRS && !guest_cpuid_has(vcpu, X86_FEATURE_AUTOIBRS)) + return false; + if (efer & EFER_FFXSR && !guest_cpuid_has(vcpu, X86_FEATURE_FXSR_OPT)) return false;