From patchwork Wed Nov 30 16:59:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naresh Solanki X-Patchwork-Id: 27914 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp1043425wrr; Wed, 30 Nov 2022 09:06:58 -0800 (PST) X-Google-Smtp-Source: AA0mqf6eZhZGL2izreg8L7kHvM9vsCeSRs/V0C7bn4gI26KFmkpF6sFI9OOdxEoo+irL+YSfY41o X-Received: by 2002:a17:906:89a0:b0:7bf:ca7b:49de with SMTP id gg32-20020a17090689a000b007bfca7b49demr14013889ejc.296.1669828018632; Wed, 30 Nov 2022 09:06:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669828018; cv=none; d=google.com; s=arc-20160816; b=yy2cXIekAfP4SDOEtCzEXwvpwbvqS9l4oJUmfEDK3GqSBSTpOtrV/6J0DkyfOB2vl+ LSXhRcfifnFVAdf6fGai2oi+m15xTUAuFZxCXdRYwAsNV73vHBhueOyt3l2ydP/c1y+u YZzqv3ZrgiQiM19E/EaXtLvwzv4YhjJwyZ5bgWMDPtgnmn8uKX7fzh7ZBlOoYgDX9oRM TUH/LJuQfimtVv3YcMlFIIM58vv25nUPvsGCu9aenjkRfebbIF+f8z3IutZnZ8jLnXxM aSdUl18hxcFx4vq5CUlHmo9a/fN+lBpIfmn09QJ3XFjCozcnhenfuBQ/N1cEVw5KtCnH gKeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=xm/vpmwhJgDMht8f1OqkuJQbgIo2XHirTX9u59ErmCw=; b=cAH1mFCXkFqmnEnoZEKkxSOHh+BKrxCtdwzrNc4tgneYPSUJ1tfsGQj305BnzfEQgN XqWtfQSzSxuoL8746GMOwzTvkXnIzlaGmhwffnqaM5di0q6Vy8GeO9oSmdjyL9afWYVG kecp4WIAl87FE5H5yLSboO86P9lI+ESsSc43HZhUtxWU1sQfEMQ+RoYwYW9QDqAWgmmb bpmFKMYxVQr6RuByk/aY6lF6c2e8KuTYV3qIgdV8gyc9MFDNq8Xf7t51kW8/+Q81xi8j ikFbIZ/vyf6Heu7UnkylfzW9Ew0pjE4Vb5r5m0V1+caKz4BBXmU2So2tyPsY3sMnrYVo j88Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b=YRIWNKwO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dm21-20020a170907949500b007986956bd8esi1813812ejc.472.2022.11.30.09.06.32; Wed, 30 Nov 2022 09:06:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b=YRIWNKwO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230494AbiK3RFn (ORCPT + 99 others); Wed, 30 Nov 2022 12:05:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230361AbiK3RFB (ORCPT ); Wed, 30 Nov 2022 12:05:01 -0500 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 596AA70634 for ; Wed, 30 Nov 2022 09:00:04 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id ay14-20020a05600c1e0e00b003cf6ab34b61so1915442wmb.2 for ; Wed, 30 Nov 2022 09:00:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=xm/vpmwhJgDMht8f1OqkuJQbgIo2XHirTX9u59ErmCw=; b=YRIWNKwOKtKOAVADiQlwkkGbVDhFN7bL0mUA71LmY+JBSjuKhPOxzeLxkgQFb6m3rM Pu60RTcJEOLceyYrS6ugloVBqiNKuUzY5HPYruWg0jSoMi7Z+8TPrT/o2jYkvRB2Tqq0 YTxs3ZIO2YNYJ9UerVamih6zqCzRT5qwSSuWzmrjrQmFsZZ5QC/dseAn1rd36uUQMwCZ qJfIPiQhoxCZJi/9QuxwY9P/847Vm8Xl+6w7qG3z1ZGuapVsXynsTngIbVRtir3LNXyD aG08Js6Ilnmj3PA9PjK6Uh1YNJC7MJP7HQXTCuslXY3ALapPSN/w0qLvLNAGHTMIhDUH IY8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xm/vpmwhJgDMht8f1OqkuJQbgIo2XHirTX9u59ErmCw=; b=a94a3erza+/TNOvl56wI9RkpK+0eQvTeXoAS5YVc/PybjqkSMXeAKkpofqRdwjRKWg pZgGAcy7eC3SqcrQvz+rqLgcOSBj9FDnL25XBMmix87mobHZ5HedbyS7/qpNHTmh38y+ DxLBL73lrbMR6TzQtii4o0I3Bl4rTis49ia3ydNOiJtbLydByASdHqv6GnB5gIDn53Gf wTR22KmXBetDR3BiQL7MJ3x5dNLozpcGkp3xo3vGrFWMq5t0ujcwuiWBHuRxHj+2NYBm K101dfkdwFloRTnYAgVB+V0YmNYfOE3p/VntMZL5NjaXboIzVSMRsLKwbBtJ3ecwPgN2 6qYA== X-Gm-Message-State: ANoB5pmO2PoKNG4OP4yJVBlb+TrwYJuPBRwHZussa70QvaGXJNXVd3ju SRDTNAhfQcC87j2kZtB8b+8JSQ== X-Received: by 2002:a1c:6a04:0:b0:3cf:77cc:5f65 with SMTP id f4-20020a1c6a04000000b003cf77cc5f65mr39421824wmc.25.1669827602880; Wed, 30 Nov 2022 09:00:02 -0800 (PST) Received: from stroh80.sec.9e.network (ip-078-094-000-051.um19.pools.vodafone-ip.de. [78.94.0.51]) by smtp.gmail.com with ESMTPSA id fn7-20020a05600c688700b003c6b70a4d69sm2457159wmb.42.2022.11.30.09.00.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Nov 2022 09:00:02 -0800 (PST) From: Naresh Solanki X-Google-Original-From: Naresh Solanki To: devicetree@vger.kernel.org, Guenter Roeck , Jean Delvare , Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, Patrick Rudolph , Naresh Solanki Subject: [PATCH v3 1/4] hwmon: (pmbus/core): Add status byte to regulator flag map Date: Wed, 30 Nov 2022 17:59:51 +0100 Message-Id: <20221130165955.3479143-1-Naresh.Solanki@9elements.com> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750941448348658109?= X-GMAIL-MSGID: =?utf-8?q?1750941584085555715?= Add PMBus status byte to regulator flag map. Signed-off-by: Naresh Solanki --- Changes: - Remove status input - Add comment for PMBUS status byte. --- drivers/hwmon/pmbus/pmbus_core.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) base-commit: 9494c53e1389b120ba461899207ac8a3aab2632c diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c index 95e95783972a..a7b4ae0f1f3b 100644 --- a/drivers/hwmon/pmbus/pmbus_core.c +++ b/drivers/hwmon/pmbus/pmbus_core.c @@ -2751,7 +2751,16 @@ struct pmbus_regulator_status_category { }; static const struct pmbus_regulator_status_category pmbus_regulator_flag_map[] = { - { + { /* STATUS byte is always present. */ + .func = -1, + .reg = PMBUS_STATUS_BYTE, + .bits = (const struct pmbus_regulator_status_assoc[]) { + { PB_STATUS_IOUT_OC, REGULATOR_ERROR_OVER_CURRENT }, + { PB_STATUS_VOUT_OV, REGULATOR_ERROR_REGULATION_OUT }, + { PB_STATUS_VIN_UV, REGULATOR_ERROR_UNDER_VOLTAGE }, + { }, + }, + }, { .func = PMBUS_HAVE_STATUS_VOUT, .reg = PMBUS_STATUS_VOUT, .bits = (const struct pmbus_regulator_status_assoc[]) { @@ -2768,6 +2777,7 @@ static const struct pmbus_regulator_status_category pmbus_regulator_flag_map[] = { PB_IOUT_OC_WARNING, REGULATOR_ERROR_OVER_CURRENT_WARN }, { PB_IOUT_OC_FAULT, REGULATOR_ERROR_OVER_CURRENT }, { PB_IOUT_OC_LV_FAULT, REGULATOR_ERROR_OVER_CURRENT }, + { PB_POUT_OP_FAULT, REGULATOR_ERROR_FAIL }, { }, }, }, { @@ -2834,14 +2844,6 @@ static int pmbus_regulator_get_error_flags(struct regulator_dev *rdev, unsigned if (status & PB_STATUS_POWER_GOOD_N) *flags |= REGULATOR_ERROR_REGULATION_OUT; } - /* - * Unlike most other status bits, PB_STATUS_{IOUT_OC,VOUT_OV} are - * defined strictly as fault indicators (not warnings). - */ - if (status & PB_STATUS_IOUT_OC) - *flags |= REGULATOR_ERROR_OVER_CURRENT; - if (status & PB_STATUS_VOUT_OV) - *flags |= REGULATOR_ERROR_REGULATION_OUT; /* * If we haven't discovered any thermal faults or warnings via From patchwork Wed Nov 30 16:59:52 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naresh Solanki X-Patchwork-Id: 27915 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp1044087wrr; Wed, 30 Nov 2022 09:08:01 -0800 (PST) X-Google-Smtp-Source: AA0mqf4Oi+3O9zU8uldvRrHXC3gu8M1ttLtGJ7Ym7H35Q18ab5RlaNEiNjk8eZDuVDfACkj4UM+y X-Received: by 2002:a17:906:3e47:b0:7c0:7c6c:e2c1 with SMTP id t7-20020a1709063e4700b007c07c6ce2c1mr10944905eji.428.1669828080799; Wed, 30 Nov 2022 09:08:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669828080; cv=none; d=google.com; s=arc-20160816; b=CJP3Hl3g1zCs7z48rbAyEprk1TxBpx6yW/FdXiobabS1iUEQTqNhHdQVNSxM/9zE3d MPE6XF7QnTbP0zcAQ4Lq1V+qLaaBScM2/4gLE3j5pBgSjzvVWAO4e5mM9td+4AO+9H0A D2aGVt2idFN7DHYey+2/Z2B6yMpmaL5QbInrUj82VcuWlPB+RhQkaex8YmMDe85/6ZrO pLE+yPAx46M+gUl4KSsTvqtdJqaD9urZWLMJ9PRTYQsYdJjxUz+OHut64NCLgIpnVN/o qTo/T7GKtJwjm1kLkBSls+95SLwjr6g+b6+2jl9M26cZF8ai7DbAuqdZNr4LJGqjb1W8 XDrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=LsjaiNcbOnAPHJfNdou87+1m3ymlwlqqUN1bnFhs+to=; b=jLLkUfs3PS553+IaLPDMpBEDRmmWHmHntfz8y9aic0lki88xj/uZVI5/t9mQhdCT/a sexzS5DMvOquaat7o4fdIdFClWqR/Ud+XsVKVKLZNAniO48QqaIIlxGx/Y/ViU3Ff+Dx szfa6B5XXiYqZlTC1RrMbR8Tvqmp4wBWsw4OU/wgt4lmjkDfOpNar4/CA4hHYt4/Jp5c WQiYm0pS/sH2Wd+2q2CF+TKos6ESSmMas9Zi7QOJ1n0q9xe15wqO+OrhX0KIUKP9TFRP kW1QvxoQaJlU4MZiJkC+NmwpuJpRDAes0wCMZstTOgGBY2M7EGXhSX+mbmr3ezwXXDGW ZqNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b=VXKfm9GT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k8-20020a17090627c800b007c0a7286afesi586995ejc.946.2022.11.30.09.07.36; Wed, 30 Nov 2022 09:08:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b=VXKfm9GT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229901AbiK3RFu (ORCPT + 99 others); Wed, 30 Nov 2022 12:05:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230514AbiK3RFK (ORCPT ); Wed, 30 Nov 2022 12:05:10 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BCA593A57 for ; Wed, 30 Nov 2022 09:00:10 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id d1so28122823wrs.12 for ; Wed, 30 Nov 2022 09:00:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LsjaiNcbOnAPHJfNdou87+1m3ymlwlqqUN1bnFhs+to=; b=VXKfm9GT2RJzMcTd5Yh71vxzbz1fYLOCc5qdLGU/SCeTHAiHg5CzxhCRCxz0399dlt d3JBLqRT7mMJnCi/YBGBD+kpG6e5RbkBmbIwgBcerkD4k/EYvS8dDLOOUxWsc40Shup4 cWoUfZsx/kCnGrxvwlMe5Va4xahmmvb+jFI6kDHi8dIUJROqaNGEPoDSOVb8lz/O3hC4 PE6kzym7tFV72p0mrSUnUOINR6+dBO67gi4JSwpRl73a2ZbdXnaoVrvxQqvJXVU/Ux7x 7BJfXerl4jeuIniDS2pDCaUmZippD0w/H8Lh+5ZKTAyA/HN49ic6eX4wQ0nsWaKJO+LK kAOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LsjaiNcbOnAPHJfNdou87+1m3ymlwlqqUN1bnFhs+to=; b=dmWZoREU2faO+t2mZYDNVtknXGPq/2PGU2wkmZXnBOjXyrcNVs5PnMFFp7lLe6BlEH hwCBwxYXoRH+FGpjGEVlYsDyWatxxi99csb/O+DuzgHKxUkRfvICrpjQGX7B3IghmiIA pBzKXiaNVZdJ3ySYSHVs7Z/FNXpyEHbscyzLVjfwPaxNUQbeDFtjEwlNeE3/f8vkJvQ7 Xqv0Y1HhNMFOc5vL5sBEosmdxpB7mRe28t6qACJlDYkFDv2+j80yQnxKtsTzU02BPETV lq4XS6I494icsxe0KsUvvwOugeCbS24zV7ZGfKJUEDaNROFldmPsKNT2/6iYte8R+oJ8 3XOA== X-Gm-Message-State: ANoB5plImAbR44BB9/C/JJuSRAwOJBqVz3nRiCpDuljr2azEW1GoRMHE bVeLtj3xwHNmaRc98nW4xrmk4XIX1O4a4vb4 X-Received: by 2002:a05:6000:70f:b0:22e:41c5:7ef7 with SMTP id bs15-20020a056000070f00b0022e41c57ef7mr1079565wrb.332.1669827609089; Wed, 30 Nov 2022 09:00:09 -0800 (PST) Received: from stroh80.sec.9e.network (ip-078-094-000-051.um19.pools.vodafone-ip.de. [78.94.0.51]) by smtp.gmail.com with ESMTPSA id fn7-20020a05600c688700b003c6b70a4d69sm2457159wmb.42.2022.11.30.09.00.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Nov 2022 09:00:08 -0800 (PST) From: Naresh Solanki X-Google-Original-From: Naresh Solanki To: devicetree@vger.kernel.org, Guenter Roeck , Jean Delvare , Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, Patrick Rudolph , Naresh Solanki Subject: [PATCH v3 2/4] hwmon: (pmbus/core): Add events to regulator flag map Date: Wed, 30 Nov 2022 17:59:52 +0100 Message-Id: <20221130165955.3479143-2-Naresh.Solanki@9elements.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221130165955.3479143-1-Naresh.Solanki@9elements.com> References: <20221130165955.3479143-1-Naresh.Solanki@9elements.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,UPPERCASE_50_75 autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750941649908238110?= X-GMAIL-MSGID: =?utf-8?q?1750941649908238110?= From: Patrick Rudolph Add regulator events corresponding to regulator error in regulator flag map. Signed-off-by: Patrick Rudolph Signed-off-by: Naresh Solanki --- drivers/hwmon/pmbus/pmbus_core.c | 43 +++++++++++++++++++++----------- 1 file changed, 28 insertions(+), 15 deletions(-) diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c index a7b4ae0f1f3b..9a9e380acc23 100644 --- a/drivers/hwmon/pmbus/pmbus_core.c +++ b/drivers/hwmon/pmbus/pmbus_core.c @@ -2738,9 +2738,9 @@ static int pmbus_regulator_disable(struct regulator_dev *rdev) return _pmbus_regulator_on_off(rdev, 0); } -/* A PMBus status flag and the corresponding REGULATOR_ERROR_* flag */ +/* A PMBus status flag and the corresponding REGULATOR_ERROR_* and REGULATOR_EVENTS_* flag */ struct pmbus_regulator_status_assoc { - int pflag, rflag; + int pflag, rflag, eflag; }; /* PMBus->regulator bit mappings for a PMBus status register */ @@ -2755,37 +2755,50 @@ static const struct pmbus_regulator_status_category pmbus_regulator_flag_map[] = .func = -1, .reg = PMBUS_STATUS_BYTE, .bits = (const struct pmbus_regulator_status_assoc[]) { - { PB_STATUS_IOUT_OC, REGULATOR_ERROR_OVER_CURRENT }, - { PB_STATUS_VOUT_OV, REGULATOR_ERROR_REGULATION_OUT }, - { PB_STATUS_VIN_UV, REGULATOR_ERROR_UNDER_VOLTAGE }, + { PB_STATUS_IOUT_OC, REGULATOR_ERROR_OVER_CURRENT, + REGULATOR_EVENT_OVER_CURRENT }, + { PB_STATUS_VOUT_OV, REGULATOR_ERROR_REGULATION_OUT, + REGULATOR_EVENT_OVER_VOLTAGE_WARN }, + { PB_STATUS_VIN_UV, REGULATOR_ERROR_UNDER_VOLTAGE, + REGULATOR_EVENT_UNDER_VOLTAGE }, { }, }, }, { .func = PMBUS_HAVE_STATUS_VOUT, .reg = PMBUS_STATUS_VOUT, .bits = (const struct pmbus_regulator_status_assoc[]) { - { PB_VOLTAGE_UV_WARNING, REGULATOR_ERROR_UNDER_VOLTAGE_WARN }, - { PB_VOLTAGE_UV_FAULT, REGULATOR_ERROR_UNDER_VOLTAGE }, - { PB_VOLTAGE_OV_WARNING, REGULATOR_ERROR_OVER_VOLTAGE_WARN }, - { PB_VOLTAGE_OV_FAULT, REGULATOR_ERROR_REGULATION_OUT }, + { PB_VOLTAGE_UV_WARNING, REGULATOR_ERROR_UNDER_VOLTAGE_WARN, + REGULATOR_EVENT_UNDER_VOLTAGE_WARN }, + { PB_VOLTAGE_UV_FAULT, REGULATOR_ERROR_UNDER_VOLTAGE, + REGULATOR_EVENT_UNDER_VOLTAGE }, + { PB_VOLTAGE_OV_WARNING, REGULATOR_ERROR_OVER_VOLTAGE_WARN, + REGULATOR_EVENT_OVER_VOLTAGE_WARN }, + { PB_VOLTAGE_OV_FAULT, REGULATOR_ERROR_REGULATION_OUT, + REGULATOR_EVENT_OVER_VOLTAGE_WARN }, { }, }, }, { .func = PMBUS_HAVE_STATUS_IOUT, .reg = PMBUS_STATUS_IOUT, .bits = (const struct pmbus_regulator_status_assoc[]) { - { PB_IOUT_OC_WARNING, REGULATOR_ERROR_OVER_CURRENT_WARN }, - { PB_IOUT_OC_FAULT, REGULATOR_ERROR_OVER_CURRENT }, - { PB_IOUT_OC_LV_FAULT, REGULATOR_ERROR_OVER_CURRENT }, - { PB_POUT_OP_FAULT, REGULATOR_ERROR_FAIL }, + { PB_IOUT_OC_WARNING, REGULATOR_ERROR_OVER_CURRENT_WARN, + REGULATOR_EVENT_OVER_CURRENT_WARN }, + { PB_IOUT_OC_FAULT, REGULATOR_ERROR_OVER_CURRENT, + REGULATOR_EVENT_OVER_CURRENT }, + { PB_IOUT_OC_LV_FAULT, REGULATOR_ERROR_OVER_CURRENT, + REGULATOR_EVENT_OVER_CURRENT }, + { PB_POUT_OP_FAULT, REGULATOR_ERROR_FAIL, + REGULATOR_EVENT_FAIL }, { }, }, }, { .func = PMBUS_HAVE_STATUS_TEMP, .reg = PMBUS_STATUS_TEMPERATURE, .bits = (const struct pmbus_regulator_status_assoc[]) { - { PB_TEMP_OT_WARNING, REGULATOR_ERROR_OVER_TEMP_WARN }, - { PB_TEMP_OT_FAULT, REGULATOR_ERROR_OVER_TEMP }, + { PB_TEMP_OT_WARNING, REGULATOR_ERROR_OVER_TEMP_WARN, + REGULATOR_EVENT_OVER_TEMP_WARN }, + { PB_TEMP_OT_FAULT, REGULATOR_ERROR_OVER_TEMP, + REGULATOR_EVENT_OVER_TEMP }, { }, }, }, From patchwork Wed Nov 30 16:59:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naresh Solanki X-Patchwork-Id: 27916 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp1044573wrr; Wed, 30 Nov 2022 09:08:45 -0800 (PST) X-Google-Smtp-Source: AA0mqf4GTo2e+PTxrIH3qAJgT7XcVUYtV0agw4r6tAARqm782NWdPtZdfmRhxXWbJ4L5c77AZKOA X-Received: by 2002:a05:6402:f91:b0:469:82f7:5013 with SMTP id eh17-20020a0564020f9100b0046982f75013mr45066052edb.234.1669828125563; Wed, 30 Nov 2022 09:08:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669828125; cv=none; d=google.com; s=arc-20160816; b=tZWGVdyfeAvUuy2RzyxJpcgx8NBBeEZZUmFnVZ9oci4z2WMMrmr20p1YDrCp1SXeVr AXueOa0KiRixfakhQY11vKxkpXfK+7GuFflQH+YWWwWYQgz/UdMoRzXODC4P2StCLBZu Tf08llDI2E/UZ9+ApuhtaF4lWqay6FHvoZ6wqAcRVfS2uxPox4GZ9Q6hB65SJIFz9TJp ayGtvsQ+HFTm+8mYM3kxA5sTaepIbSK0zteYfErespxTG/M/fwWdtb8/1KCY/bhw3Qxi KGJjwOYd50lB+Tf9r+JxK9Dfnrxs5LXKS4llZapbZZZUxWbhMe8Vpyq1+llsxVFZLKfT 0Lfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=5CXiZlD2TyqZ7MaMRJu4QFyk6ysF3bJp4l380A/oYl4=; b=Odolcl0GUumC9MVknmoQbelGYUNq+2ETStkmAu5X1RsQ241U1GkI2quY0/h6J8u3Y7 dMnCQuLRThK+1m74Z2HcPZozW9Dd+ZgWefgvBcZiW1zqGPH6fccgiBNt2u4MfPtc4oTb j61UXOv1UH1otdcPQhkW5jrHwR7G7t5+vRvcdqkJWkvXbd6wd2XKm826lPTgF4BOk9XS RD94U7r+3HxnGVi0Y1uxY7zXN1HbbLQbabruNsL6DcKkekRdpGor9/tet0X8eedtY0zi zh5evQTD4q67VxGJgHKpNKOHnlbDPrCYeqQ6k3UhsOaKKoD5iDPvqMX4PZdRI7/WK5x5 UJqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b=Vk1g9N5M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l15-20020a170906794f00b007aa5e6c4b5bsi1925232ejo.164.2022.11.30.09.08.22; Wed, 30 Nov 2022 09:08:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b=Vk1g9N5M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231276AbiK3RF7 (ORCPT + 99 others); Wed, 30 Nov 2022 12:05:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231219AbiK3RFP (ORCPT ); Wed, 30 Nov 2022 12:05:15 -0500 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D81C98967 for ; Wed, 30 Nov 2022 09:00:13 -0800 (PST) Received: by mail-wr1-x434.google.com with SMTP id h11so20832472wrw.13 for ; Wed, 30 Nov 2022 09:00:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5CXiZlD2TyqZ7MaMRJu4QFyk6ysF3bJp4l380A/oYl4=; b=Vk1g9N5MtEmS/1qfopQRw1TNtmQiSTBfJ2vUuBLKjdXeRtVwEkWZ2h/9BTjFu5E8er 4mGUak187PqBT9S8JdjxDQocH+rUGaX33U9iHJwnYPU6teL17Y/B2jQqQPbip0TqWZMC DJ741gVu3bdXB+579W6oYTkP2crp+51EerD2N76DvHGh/gTVkZzPu+qICcOVF3ZlzneR CmRWcanxe527GsstQ7KMfwhguIceygpMTHTDXGIKuIFUc5jTqNj5EIk9PclOuVGIt1D4 cFu+n3rcUbN+gW7J4uKh0oxLUtL3R0oyk42dRNSkWxKyudKHu4Qr+x6JSEI2Muqsvlue gsEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5CXiZlD2TyqZ7MaMRJu4QFyk6ysF3bJp4l380A/oYl4=; b=HFngznaLGYg1FSlh9eP5rDGfg1MPMWwd9KoULM1y2rWa81seWQfp3KBaOLZJQPy6uF wPjMicOvgNRM9mZsFtsCdBfOVUCbb1gLKP796ubBo6oRYpCCqiqgFjyPO6ebK32HUR/s foi9DiRpmaByrb4aPjrrHXfoPsuSPuahex4TlUYzkRmOxrFUx4thf9lv70J6ASfBmt/d wPv/J8IthE+gj5p6eL/jfUH7W4ylp+xfgiHmH5Z0Dx1bkiO5E/Vz7jMwNq7vDIYsljIp U7i0Z2fDLWVLqEbyZO9fhhqeBX4qaNv0bHS0MFXr3fZxqqN9yKlwO55HWHxzFLs6s4iF ZtIw== X-Gm-Message-State: ANoB5pkUk++GdZI5r5LzZShMoMl4yOHa01OJSotgrLcY6vFkQ7USx5VZ U8YYsspfXYJu8d596Wmhb9i0tMB6oQCKgn3u X-Received: by 2002:adf:9b84:0:b0:242:2f5d:e27f with SMTP id d4-20020adf9b84000000b002422f5de27fmr2029177wrc.54.1669827612102; Wed, 30 Nov 2022 09:00:12 -0800 (PST) Received: from stroh80.sec.9e.network (ip-078-094-000-051.um19.pools.vodafone-ip.de. [78.94.0.51]) by smtp.gmail.com with ESMTPSA id fn7-20020a05600c688700b003c6b70a4d69sm2457159wmb.42.2022.11.30.09.00.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Nov 2022 09:00:11 -0800 (PST) From: Naresh Solanki X-Google-Original-From: Naresh Solanki To: devicetree@vger.kernel.org, Guenter Roeck , Jean Delvare , Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, Patrick Rudolph , Naresh Solanki Subject: [PATCH v3 3/4] hwmon: (pmbus/core): Implement irq support Date: Wed, 30 Nov 2022 17:59:53 +0100 Message-Id: <20221130165955.3479143-3-Naresh.Solanki@9elements.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221130165955.3479143-1-Naresh.Solanki@9elements.com> References: <20221130165955.3479143-1-Naresh.Solanki@9elements.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750941696198118031?= X-GMAIL-MSGID: =?utf-8?q?1750941696198118031?= From: Patrick Rudolph Implement PMBUS irq handler to notify regulator events. Signed-off-by: Patrick Rudolph Signed-off-by: Naresh Solanki --- drivers/hwmon/pmbus/pmbus.h | 2 +- drivers/hwmon/pmbus/pmbus_core.c | 151 ++++++++++++++++++++++++++++--- 2 files changed, 137 insertions(+), 16 deletions(-) diff --git a/drivers/hwmon/pmbus/pmbus.h b/drivers/hwmon/pmbus/pmbus.h index 10fb17879f8e..6b2e6cf93b19 100644 --- a/drivers/hwmon/pmbus/pmbus.h +++ b/drivers/hwmon/pmbus/pmbus.h @@ -26,7 +26,7 @@ enum pmbus_regs { PMBUS_CAPABILITY = 0x19, PMBUS_QUERY = 0x1A, - + PMBUS_SMBALERT_MASK = 0x1B, PMBUS_VOUT_MODE = 0x20, PMBUS_VOUT_COMMAND = 0x21, PMBUS_VOUT_TRIM = 0x22, diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c index 9a9e380acc23..613e2e484a0f 100644 --- a/drivers/hwmon/pmbus/pmbus_core.c +++ b/drivers/hwmon/pmbus/pmbus_core.c @@ -81,6 +81,7 @@ struct pmbus_label { struct pmbus_data { struct device *dev; struct device *hwmon_dev; + struct regulator_dev **rdevs; u32 flags; /* from platform data */ @@ -2804,7 +2805,8 @@ static const struct pmbus_regulator_status_category pmbus_regulator_flag_map[] = }, }; -static int pmbus_regulator_get_error_flags(struct regulator_dev *rdev, unsigned int *flags) +static int pmbus_regulator_get_flags(struct regulator_dev *rdev, unsigned int *error, + unsigned int *event) { int i, status; const struct pmbus_regulator_status_category *cat; @@ -2815,7 +2817,8 @@ static int pmbus_regulator_get_error_flags(struct regulator_dev *rdev, unsigned u8 page = rdev_get_id(rdev); int func = data->info->func[page]; - *flags = 0; + *error = 0; + *event = 0; mutex_lock(&data->update_lock); @@ -2831,8 +2834,10 @@ static int pmbus_regulator_get_error_flags(struct regulator_dev *rdev, unsigned } for (bit = cat->bits; bit->pflag; bit++) { - if (status & bit->pflag) - *flags |= bit->rflag; + if (status & bit->pflag) { + *error |= bit->rflag; + *event |= bit->eflag; + } } } @@ -2851,11 +2856,15 @@ static int pmbus_regulator_get_error_flags(struct regulator_dev *rdev, unsigned return status; if (pmbus_regulator_is_enabled(rdev)) { - if (status & PB_STATUS_OFF) - *flags |= REGULATOR_ERROR_FAIL; + if (status & PB_STATUS_OFF) { + *error |= REGULATOR_ERROR_FAIL; + *event |= REGULATOR_EVENT_FAIL; + } - if (status & PB_STATUS_POWER_GOOD_N) - *flags |= REGULATOR_ERROR_REGULATION_OUT; + if (status & PB_STATUS_POWER_GOOD_N) { + *error |= REGULATOR_ERROR_REGULATION_OUT; + *event |= REGULATOR_EVENT_REGULATION_OUT; + } } /* @@ -2863,13 +2872,22 @@ static int pmbus_regulator_get_error_flags(struct regulator_dev *rdev, unsigned * PMBUS_STATUS_TEMPERATURE, map PB_STATUS_TEMPERATURE to a warning as * a (conservative) best-effort interpretation. */ - if (!(*flags & (REGULATOR_ERROR_OVER_TEMP | REGULATOR_ERROR_OVER_TEMP_WARN)) && - (status & PB_STATUS_TEMPERATURE)) - *flags |= REGULATOR_ERROR_OVER_TEMP_WARN; + if (!(*error & (REGULATOR_ERROR_OVER_TEMP | REGULATOR_ERROR_OVER_TEMP_WARN)) && + (status & PB_STATUS_TEMPERATURE)) { + *error |= REGULATOR_ERROR_OVER_TEMP_WARN; + *event |= REGULATOR_EVENT_OVER_TEMP_WARN; + } return 0; } +static int pmbus_regulator_get_error_flags(struct regulator_dev *rdev, unsigned int *flags) +{ + unsigned int event; + + return pmbus_regulator_get_flags(rdev, flags, &event); +} + static int pmbus_regulator_get_status(struct regulator_dev *rdev) { struct device *dev = rdev_get_dev(rdev); @@ -3060,14 +3078,61 @@ const struct regulator_ops pmbus_regulator_ops = { }; EXPORT_SYMBOL_NS_GPL(pmbus_regulator_ops, PMBUS); +static int pmbus_write_smbalert_mask(struct i2c_client *client, u8 page, u8 reg, u8 val) +{ + return pmbus_write_word_data(client, page, PMBUS_SMBALERT_MASK, reg | (val << 8)); +} + +static irqreturn_t pmbus_fault_handler(int irq, void *pdata) +{ + struct pmbus_data *data = pdata; + struct i2c_client *client = to_i2c_client(data->dev); + int i, ret = IRQ_NONE, status, event; + u8 page; + + for (i = 0; i < data->info->num_regulators; i++) { + + if (!data->rdevs[i]) + continue; + + ret = pmbus_regulator_get_flags(data->rdevs[i], &status, &event); + if (ret) + return ret; + + if (event) { + regulator_notifier_call_chain(data->rdevs[i], event, NULL); + ret = IRQ_HANDLED; + } + + page = rdev_get_id(data->rdevs[i]); + mutex_lock(&data->update_lock); + status = pmbus_read_status_word(client, page); + if (status < 0) { + mutex_unlock(&data->update_lock); + return status; + } + + if (status & ~(PB_STATUS_OFF | PB_STATUS_BUSY | PB_STATUS_POWER_GOOD_N)) + pmbus_clear_fault_page(client, page); + + mutex_unlock(&data->update_lock); + } + + return ret; +} + static int pmbus_regulator_register(struct pmbus_data *data) { struct device *dev = data->dev; const struct pmbus_driver_info *info = data->info; const struct pmbus_platform_data *pdata = dev_get_platdata(dev); - struct regulator_dev *rdev; int i; + data->rdevs = devm_kzalloc(dev, sizeof(struct regulator_dev *) * info->num_regulators, + GFP_KERNEL); + if (!data->rdevs) + return -ENOMEM; + for (i = 0; i < info->num_regulators; i++) { struct regulator_config config = { }; @@ -3077,21 +3142,71 @@ static int pmbus_regulator_register(struct pmbus_data *data) if (pdata && pdata->reg_init_data) config.init_data = &pdata->reg_init_data[i]; - rdev = devm_regulator_register(dev, &info->reg_desc[i], + data->rdevs[i] = devm_regulator_register(dev, &info->reg_desc[i], &config); - if (IS_ERR(rdev)) - return dev_err_probe(dev, PTR_ERR(rdev), + if (IS_ERR(data->rdevs[i])) + return dev_err_probe(dev, PTR_ERR(data->rdevs[i]), "Failed to register %s regulator\n", info->reg_desc[i].name); } return 0; } + +static int pmbus_irq_setup(struct i2c_client *client, struct pmbus_data *data) +{ + struct device *dev = &client->dev; + const struct pmbus_regulator_status_category *cat; + const struct pmbus_regulator_status_assoc *bit; + int i, j, err, ret; + u8 mask; + int func; + + for (i = 0; i < data->info->pages; i++) { + func = data->info->func[i]; + + for (j = 0; j < ARRAY_SIZE(pmbus_regulator_flag_map); j++) { + cat = &pmbus_regulator_flag_map[i]; + if (!(func & cat->func)) + continue; + mask = 0; + for (bit = cat->bits; bit->pflag; bit++) + mask |= bit->pflag; + + err = pmbus_write_smbalert_mask(client, i, cat->reg, ~mask); + if (err) + dev_err(dev, "Failed to set smbalert for reg 0x%02x\n", cat->reg); + } + + pmbus_write_smbalert_mask(client, i, PMBUS_STATUS_CML, 0xff); + pmbus_write_smbalert_mask(client, i, PMBUS_STATUS_OTHER, 0xff); + pmbus_write_smbalert_mask(client, i, PMBUS_STATUS_MFR_SPECIFIC, 0xff); + if (data->info->func[i] & PMBUS_HAVE_FAN12) + pmbus_write_smbalert_mask(client, i, PMBUS_STATUS_FAN_12, 0xff); + if (data->info->func[i] & PMBUS_HAVE_FAN34) + pmbus_write_smbalert_mask(client, i, PMBUS_STATUS_FAN_34, 0xff); + + } + + /* Register notifiers - can fail if IRQ is not given */ + ret = devm_request_threaded_irq(dev, client->irq, NULL, pmbus_fault_handler, + 0, "pmbus-irq", data); + if (ret) { + dev_warn(dev, "IRQ disabled %d\n", ret); + return ret; + } + + return 0; +} #else static int pmbus_regulator_register(struct pmbus_data *data) { return 0; } +static int pmbus_irq_setup(struct i2c_client *client, struct pmbus_data *data) +{ + return 0; +} #endif static struct dentry *pmbus_debugfs_dir; /* pmbus debugfs directory */ @@ -3456,6 +3571,12 @@ int pmbus_do_probe(struct i2c_client *client, struct pmbus_driver_info *info) if (ret) return ret; + if (client->irq > 0) { + ret = pmbus_irq_setup(client, data); + if (ret) + return ret; + } + ret = pmbus_init_debugfs(client, data); if (ret) dev_warn(dev, "Failed to register debugfs\n"); From patchwork Wed Nov 30 16:59:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naresh Solanki X-Patchwork-Id: 27917 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp1044934wrr; Wed, 30 Nov 2022 09:09:17 -0800 (PST) X-Google-Smtp-Source: AA0mqf5nzLWxS7XIB2vqhI5n0QIajeIgvXCzZc361Ii+4DkW53rWRzOWl+xIB4BZP13Q9+7+Lmvd X-Received: by 2002:a17:906:d7ad:b0:7bc:e98e:2d50 with SMTP id pk13-20020a170906d7ad00b007bce98e2d50mr23012020ejb.743.1669828157784; Wed, 30 Nov 2022 09:09:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669828157; cv=none; d=google.com; s=arc-20160816; b=0KWwQLni5TDsJUlQZ0bTFWOO6xZOVTfJxyX5MZ5nVwqkAt+fogway31lPzHYBk2Kul v5ZySi3ED8zwiri3887ubrGhA91gNnn/GswifojAf+KilTnCV4Oi92jy7zM3Yn0inKyZ frphnmG7SeCpZeZFheee/+z5W0h3A199bXoF2mdxNtwSzi1xB0KxYyR2gouusLlfMhXt GzBig+PL64IJluAsqvLbNZjf71eZVG2XPrFbp6W/X6z3kFsnrfpz+hw6u4J+ufoPV3y6 51InFkJPzb68pcVQWiwbaeqslkmXeFsFjMLxLLHLLW2ReU8AKpIvPZ+TQTUPDLGsPbb7 ej4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ADo04tg+16fhlHcXEalyoHswqSIikOudDCDm6c2e17k=; b=n5N7f2t5Llz7qKsPXaQ75VNHuhS6xE0N0uXUXsxci9/jKWGCjU4KIJdq9LWJSupyd7 Dl04COnvyBZrpK3KcvNs836zZbX7ZZAwDszZOzr0/0rL4M2uxyKnaxRKA0dZq14iIM2B WTuJz0gSZpabjEGUHpezms+WyWtCnKMs0pj/hJz7twq6T8juWAtmWEPftiV8NjK343/A hyt31k3wyU7Oo+9P2hawoy18HjXWOMzOD1ZFK3fXwaLLvv2/1gg3+iYD/fgYf4jqrKy6 G6MZ+A2Xcu7J5ku1JB1uFPsH/lM6nYCw81EmsJrGNlSaT/srurJedUyN/3FjLiucdDdX CxXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b="NKu8S/HW"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s21-20020a056402521500b00457263f9ee0si1728911edd.93.2022.11.30.09.08.49; Wed, 30 Nov 2022 09:09:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b="NKu8S/HW"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231277AbiK3RGC (ORCPT + 99 others); Wed, 30 Nov 2022 12:06:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231229AbiK3RFS (ORCPT ); Wed, 30 Nov 2022 12:05:18 -0500 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7FC698941 for ; Wed, 30 Nov 2022 09:00:15 -0800 (PST) Received: by mail-wm1-x334.google.com with SMTP id m19so4492500wms.5 for ; Wed, 30 Nov 2022 09:00:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ADo04tg+16fhlHcXEalyoHswqSIikOudDCDm6c2e17k=; b=NKu8S/HWybo5iLmhXLOZ4iQ/6NF9zExmhhZ1XuHdPAD/XvPsE3cuPkUcIXqhhFqoOs OoEcvaa3CZvsbEkiSDX7yopx8HyxBwO+ItxHGrrTl8bUJGSvt8/Db73li2ej+DNKGafy n5mrkCQlx23Nt4KWd8WppTeaPRO/VMy93SeqNgQp5WYIGrKwXvHm2lZoN8JLuJ74QwYV ZtRToEQ+QCegU3LS+1Q29y7fAY8nphbWSnatkHvqR9YCIBSM3ig37Hn2uA1RvMziG+sb Gp9lO+F4CoNkX+tIMhHY7XpmUawd5os3UzmsnnCHsLACgg4whAxz6KJwh5aB2j+NH3jo R0vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ADo04tg+16fhlHcXEalyoHswqSIikOudDCDm6c2e17k=; b=HcJfLaoYEeEK2693FMI6x4f/xDrmH6lf/AZ0/+aQvo159rinTW65lmdZCptG7wEkMc VRwOx2z9D9b24n3tLoPv+cDoBP5NHD5QE+09XT1daBQRqh2h+1f9f4sZq4DJC0gVmNCT B+7DDrttx29YhmOrh39UwGQgMu1UVi6jnwUKVDq/AEcE0+Wf5boGrorg69uVu/6ZGifM Wsf6tGLpZ7gw+QJjvga6g2rjYA9E6L8xedmt3BzYSwMTg2wEgsfHU+tVD0Yo5H/twzg+ ht8tnVpkSvJp14p4vYRis2pTrBWYzKsYLF7rXuiT7BR8WYSyK7vGpLHrAdI6KPqtFgy/ rAhw== X-Gm-Message-State: ANoB5pmFD6kGjuatrCDo7Hdb7lO2q4nM1/fk9s4CzQ62kpGthRbYpPBS Iv7Q66X07YkSReppbvsUqSsllw== X-Received: by 2002:a05:600c:1e25:b0:3d0:31c9:1d77 with SMTP id ay37-20020a05600c1e2500b003d031c91d77mr29100295wmb.113.1669827614406; Wed, 30 Nov 2022 09:00:14 -0800 (PST) Received: from stroh80.sec.9e.network (ip-078-094-000-051.um19.pools.vodafone-ip.de. [78.94.0.51]) by smtp.gmail.com with ESMTPSA id fn7-20020a05600c688700b003c6b70a4d69sm2457159wmb.42.2022.11.30.09.00.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Nov 2022 09:00:14 -0800 (PST) From: Naresh Solanki X-Google-Original-From: Naresh Solanki To: devicetree@vger.kernel.org, Guenter Roeck , Jean Delvare , Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, Patrick Rudolph , Naresh Solanki Subject: [PATCH v3 4/4] hwmon: (pmbus/core): Notify hwmon events Date: Wed, 30 Nov 2022 17:59:54 +0100 Message-Id: <20221130165955.3479143-4-Naresh.Solanki@9elements.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221130165955.3479143-1-Naresh.Solanki@9elements.com> References: <20221130165955.3479143-1-Naresh.Solanki@9elements.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750941730402464248?= X-GMAIL-MSGID: =?utf-8?q?1750941730402464248?= Notify hwmon events using the pmbus irq handler. Signed-off-by: Naresh Solanki --- drivers/hwmon/pmbus/pmbus_core.c | 37 +++++++++++++++++++++++++++++--- 1 file changed, 34 insertions(+), 3 deletions(-) diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c index 613e2e484a0f..da92a08484c9 100644 --- a/drivers/hwmon/pmbus/pmbus_core.c +++ b/drivers/hwmon/pmbus/pmbus_core.c @@ -2805,8 +2805,36 @@ static const struct pmbus_regulator_status_category pmbus_regulator_flag_map[] = }, }; +#define to_dev_attr(_dev_attr) \ + container_of(_dev_attr, struct device_attribute, attr) + +static void pmbus_notify(struct pmbus_data *data, int page, int reg, int flags) +{ + int i; + + for (i = 0; i < data->num_attributes; i++) { + struct device_attribute *da = to_dev_attr(data->group.attrs[i]); + struct sensor_device_attribute *attr = to_sensor_dev_attr(da); + int index = attr->index; + u16 smask = pb_index_to_mask(index); + u8 spage = pb_index_to_page(index); + u16 sreg = pb_index_to_reg(index); + + if (reg == sreg && page == spage && (smask & flags)) { + dev_dbg(data->dev, "sysfs notify: %s", da->attr.name); + sysfs_notify(&data->dev->kobj, NULL, da->attr.name); + kobject_uevent(&data->dev->kobj, KOBJ_CHANGE); + } + + flags &= ~smask; + + if (!flags) + break; + } +} + static int pmbus_regulator_get_flags(struct regulator_dev *rdev, unsigned int *error, - unsigned int *event) + unsigned int *event, bool notify) { int i, status; const struct pmbus_regulator_status_category *cat; @@ -2833,6 +2861,9 @@ static int pmbus_regulator_get_flags(struct regulator_dev *rdev, unsigned int *e return status; } + if (notify && status) + pmbus_notify(data, page, cat->reg, status); + for (bit = cat->bits; bit->pflag; bit++) { if (status & bit->pflag) { *error |= bit->rflag; @@ -2885,7 +2916,7 @@ static int pmbus_regulator_get_error_flags(struct regulator_dev *rdev, unsigned { unsigned int event; - return pmbus_regulator_get_flags(rdev, flags, &event); + return pmbus_regulator_get_flags(rdev, flags, &event, false); } static int pmbus_regulator_get_status(struct regulator_dev *rdev) @@ -3095,7 +3126,7 @@ static irqreturn_t pmbus_fault_handler(int irq, void *pdata) if (!data->rdevs[i]) continue; - ret = pmbus_regulator_get_flags(data->rdevs[i], &status, &event); + ret = pmbus_regulator_get_flags(data->rdevs[i], &status, &event, true); if (ret) return ret;