From patchwork Wed Nov 30 13:48:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 27811 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp936199wrr; Wed, 30 Nov 2022 05:55:11 -0800 (PST) X-Google-Smtp-Source: AA0mqf6nbhesLAS/4Y73fqhQUDRgdXZBZBcnSLS5HKNaZo2E+dhAWGzQP3ErPxMXInqF6uqwZsg6 X-Received: by 2002:a17:906:a18c:b0:7ad:9629:fb96 with SMTP id s12-20020a170906a18c00b007ad9629fb96mr5013265ejy.751.1669816511019; Wed, 30 Nov 2022 05:55:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669816511; cv=none; d=google.com; s=arc-20160816; b=zjR5doZbOgAwLFyYdmQd0g/vI529DJ4J7Z3mXyJknjBDvuDWlHj0jDCCTTEAShBxOT 8YF1ysjJbnWZL0P1TW5N0LpOQIwAO/B3mCzDY4ZfQg2mREa9XmysNDlNJDLutEHZGqxj FRCcKHJUn/g0ecjCVDEGC5XiI5iStILAa4d3ny/KirFJil4hRkWZBDMNcK1KMaAunEt1 393y2lRzG+z58K7tE+dAV7eeZBCjesaZbukWnzvqigITLIw8b5fnJgznLni9MI9Hz5hS mf5Vbq9kusYStULbpbz2sqLlQKggsgtjLF1P7i+Kp7D0/wm+SfQYO/WGU1zjeuCOyikQ bkmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=UECGrYn/e7lxZkLCgCozV+XlWnUZmP5cKgd6yXqScW8=; b=Vj3sjw3GLhKNsIT/sWv/Yrak7zu36bB8bABTJqYqVqNU6uroYeqXHdSrhLxM9Nr7t0 aBvdLHmvozBqeq4K64YIPOuXSygEdkbfwlgmxeRIVF9YNyZafKAAI02SKhmZGZjyiro2 wkBFp46xn7w2iDnn0mXhY4tFOnnxo8L8+czkh0I6txS3RJ3MuPOZeD/10okow1/4Ifw3 DmDMDpA+9iO59uJTwyJ0fWlwL20ALfTYSIQEVwbXO7lZFmt6aOYZkUvuH0G0rq2K5Is3 1u3OwDJzEDT0n7T6+ij7uJBLnlCNCepTGqPCkZ7z9gaIMKjeEOCh3ia/Qg6JfyvZQV3X Pulg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=W6k2S1Pg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k7-20020a05640212c700b0046b2966d088si1228971edx.502.2022.11.30.05.54.46; Wed, 30 Nov 2022 05:55:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=W6k2S1Pg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230187AbiK3NtR (ORCPT + 99 others); Wed, 30 Nov 2022 08:49:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230011AbiK3NtL (ORCPT ); Wed, 30 Nov 2022 08:49:11 -0500 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81DE3218BB; Wed, 30 Nov 2022 05:49:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669816150; x=1701352150; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=EyJFPG6PhV/AwdfzlcYIAHQ0QmtsikwhVNregiJywak=; b=W6k2S1Pgs1JtmKpFI2qJvzwzACxulY1RmXNqcm0O432WGIjGJiTwpTCm 3qoKfHEdNRtiMMRQGecDTwMUvH5V5W5iamVmmwMwr5G2QW2J5g/hTe+0N My3LmaUn2/a0sLhNO0/KiyjXGYcshaYI4HMjDXdpvvXkl8sSMo2Ko9nAX q5v8u4IOJti8jGo8qwRy+7l9HT/P721xThXq5cVJVoA/9pAIetyt80oz3 1GK+tcFM/n+QzSsKWh5he2UFdDVsnF2Veob2/hksuqbUpAX5yoHpozUrg lk806IluZOfM2L4iUMP/H9+h//MOf/EAr/B6YXLDCC0yfvFQ3WQUyl1sQ w==; X-IronPort-AV: E=McAfee;i="6500,9779,10547"; a="298769783" X-IronPort-AV: E=Sophos;i="5.96,206,1665471600"; d="scan'208";a="298769783" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2022 05:48:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10546"; a="676825898" X-IronPort-AV: E=Sophos;i="5.96,206,1665471600"; d="scan'208";a="676825898" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga001.jf.intel.com with ESMTP; 30 Nov 2022 05:48:12 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 89D29179; Wed, 30 Nov 2022 15:48:39 +0200 (EET) From: Andy Shevchenko To: Greg Kroah-Hartman , Andy Shevchenko , Mathias Nyman , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Kevin Cernekee , Mathias Nyman , Lucas De Marchi , Jani Nikula Subject: [PATCH v5 1/4] i915: Move list_count() to list.h as list_count_nodes() for broader use Date: Wed, 30 Nov 2022 15:48:35 +0200 Message-Id: <20221130134838.23805-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750929518251590602?= X-GMAIL-MSGID: =?utf-8?q?1750929518251590602?= Some of the existing users, and definitely will be new ones, want to count existing nodes in the list. Provide a generic API for that by moving code from i915 to list.h. Reviewed-by: Lucas De Marchi Acked-by: Jani Nikula Signed-off-by: Andy Shevchenko --- v5: added tag (Lucas), renamed API to list_count_nodes() (LKP) v4: fixed prototype when converting to static inline v3: added tag (Jani), changed to be static inline (Mike) v2: dropped the duplicate code in i915 (LKP) drivers/gpu/drm/i915/gt/intel_engine_cs.c | 15 ++------------- include/linux/list.h | 15 +++++++++++++++ 2 files changed, 17 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c index 1f7188129cd1..370164363b0d 100644 --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c @@ -2004,17 +2004,6 @@ static void print_request_ring(struct drm_printer *m, struct i915_request *rq) } } -static unsigned long list_count(struct list_head *list) -{ - struct list_head *pos; - unsigned long count = 0; - - list_for_each(pos, list) - count++; - - return count; -} - static unsigned long read_ul(void *p, size_t x) { return *(unsigned long *)(p + x); @@ -2189,8 +2178,8 @@ void intel_engine_dump(struct intel_engine_cs *engine, spin_lock_irqsave(&engine->sched_engine->lock, flags); engine_dump_active_requests(engine, m); - drm_printf(m, "\tOn hold?: %lu\n", - list_count(&engine->sched_engine->hold)); + drm_printf(m, "\tOn hold?: %zu\n", + list_count_nodes(&engine->sched_engine->hold)); spin_unlock_irqrestore(&engine->sched_engine->lock, flags); drm_printf(m, "\tMMIO base: 0x%08x\n", engine->mmio_base); diff --git a/include/linux/list.h b/include/linux/list.h index 61762054b4be..f10344dbad4d 100644 --- a/include/linux/list.h +++ b/include/linux/list.h @@ -655,6 +655,21 @@ static inline void list_splice_tail_init(struct list_head *list, !list_is_head(pos, (head)); \ pos = n, n = pos->prev) +/** + * list_count_nodes - count nodes in the list + * @head: the head for your list. + */ +static inline size_t list_count_nodes(struct list_head *head) +{ + struct list_head *pos; + size_t count = 0; + + list_for_each(pos, head) + count++; + + return count; +} + /** * list_entry_is_head - test if the entry points to the head of the list * @pos: the type * to cursor From patchwork Wed Nov 30 13:48:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 27809 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp935367wrr; Wed, 30 Nov 2022 05:53:02 -0800 (PST) X-Google-Smtp-Source: AA0mqf43wWUALedUb+yOgxegRLSmG2R2Nx69+8XmP/6pNFvGviiFfmb6ucXkhvO0TGh6/cTdMVlU X-Received: by 2002:a17:906:3897:b0:7c0:911e:199a with SMTP id q23-20020a170906389700b007c0911e199amr4775152ejd.689.1669816381927; Wed, 30 Nov 2022 05:53:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669816381; cv=none; d=google.com; s=arc-20160816; b=diedDVzbps/zLPE85F1+7s3bPofrM53TYUhLAX3nok/OauKRav8LoUbzAug7CdcvtX F4sQgQjZS40fz9NR6PWY1j8DNt33l2vQuPqqmVKF4J3u1rDd0kYyCuaNMDw64dbA2H9y Jyh41xMywJE28bfxuTjQ4gJEVUKwWdJ3S9EHhj+tXhsk8MoGpa4NRdKUivxgF9ACBZ4L 2OA76dW8nUYYiBCmapqPeVTP/+h3gqFRuMfvX61q6rjRJ3Jo+OjB2wCXaNDtChzPflUA XRYOa4nyJ/j2hRRI8hkyWxO/SpPPvW351ypmMz3HzyqKsGEtxq48sCKovnOAjsFmDVGD teXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=0mmBSOzUANgD3m4pGsF1NeRtzgGQ1cxIGY7XY5Tq81M=; b=avvOC8Y/3aMOspdAs6+O0Y/ylVqmxgCqZLMgc1rFDAN6pSbHWr/goFAXspsZwanEop IntNDydVcn7ZMrqxvi27DgWhv5I5okEVr7D4AIjuoV6ASyMg++8sAldmPI9nynuyckhW qZ0MwkFAkTs+3AQLsQrmeGZo2qZjliaZcDc77wMp33t+I3emWxUbbzliaIEezfYU3UxV 1GWmqFQCH5hCh7/2j7BVlVAJgBrJnvp2xJn6/XjQlbwHkXNV2FMD+e2wbWQgnBUo/zEK KoeUIAcMefyZq3Qdkvq3bOu4C8tt25SyJpwVzJV5r4wya9J1Xtc3a3LvhQy3ZAuesgpl 57MA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=VCpuxzyZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qa10-20020a170907868a00b00773db351c39si1462381ejc.64.2022.11.30.05.52.38; Wed, 30 Nov 2022 05:53:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=VCpuxzyZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230057AbiK3NtO (ORCPT + 99 others); Wed, 30 Nov 2022 08:49:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230013AbiK3NtL (ORCPT ); Wed, 30 Nov 2022 08:49:11 -0500 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25AF328726; Wed, 30 Nov 2022 05:49:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669816150; x=1701352150; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=IUyB0aYfzgdGPjnanaYtbllUXw0rFzNVl+2IWpnEV3s=; b=VCpuxzyZ6hKVk0u2cGz4ZSMZJA7OYzv56wMZD7BPbtqXat/AdnTBVFgG /en3STEemBbE5qQbI7vVFP8DzDtZ86WZVCK3kFnVXDOA40hDlMzWldHvQ b11vx5wIv7CiNwk4MhQ9dfe9HiRAQ6p+LGsJGJakbtM3YvJnUAQBTN3g2 1EQI3mNC5ZWsUE5TDwB+Hmf0FWm6YooDqEy7NPWPXcLhdZNCp3zL7GQLO ZjZlWqJlq2KWqaxYwNK7WoSr6ISi3YgOWVuSwK4lorndcyKnbHTH+6Wbm 4+hJu7QD61AmCHTST/4Czz2y6pat/MeffvSKN5orIhMWagmfDElB/akC+ w==; X-IronPort-AV: E=McAfee;i="6500,9779,10547"; a="298769766" X-IronPort-AV: E=Sophos;i="5.96,206,1665471600"; d="scan'208";a="298769766" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2022 05:48:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10546"; a="676825894" X-IronPort-AV: E=Sophos;i="5.96,206,1665471600"; d="scan'208";a="676825894" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga001.jf.intel.com with ESMTP; 30 Nov 2022 05:48:12 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 984BA10E; Wed, 30 Nov 2022 15:48:39 +0200 (EET) From: Andy Shevchenko To: Greg Kroah-Hartman , Andy Shevchenko , Mathias Nyman , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Kevin Cernekee , Mathias Nyman Subject: [PATCH v5 2/4] usb: gadget: hid: Convert to use list_count_nodes() Date: Wed, 30 Nov 2022 15:48:36 +0200 Message-Id: <20221130134838.23805-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221130134838.23805-1-andriy.shevchenko@linux.intel.com> References: <20221130134838.23805-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750929382511801989?= X-GMAIL-MSGID: =?utf-8?q?1750929382511801989?= The list API provides the list_count_nodes() to help with counting existing nodes in the list. Utilise it. Signed-off-by: Andy Shevchenko --- v5: used renamed API (LKP) v4: no change v3: fixed typo in the commit message (Fabio) v2: no change drivers/usb/gadget/legacy/hid.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/usb/gadget/legacy/hid.c b/drivers/usb/gadget/legacy/hid.c index 1187ee4f316a..133daf88162e 100644 --- a/drivers/usb/gadget/legacy/hid.c +++ b/drivers/usb/gadget/legacy/hid.c @@ -133,14 +133,11 @@ static struct usb_configuration config_driver = { static int hid_bind(struct usb_composite_dev *cdev) { struct usb_gadget *gadget = cdev->gadget; - struct list_head *tmp; struct hidg_func_node *n = NULL, *m, *iter_n; struct f_hid_opts *hid_opts; - int status, funcs = 0; - - list_for_each(tmp, &hidg_func_list) - funcs++; + int status, funcs; + funcs = list_count_nodes(&hidg_func_list); if (!funcs) return -ENODEV; From patchwork Wed Nov 30 13:48:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 27808 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp934684wrr; Wed, 30 Nov 2022 05:51:33 -0800 (PST) X-Google-Smtp-Source: AA0mqf4wOuODCXNjkvAWKVco6PUsnaJpM9jDRC+9w7vifpzVO/Bk9WPhND+spWjBOqYHRM7O9fSx X-Received: by 2002:aa7:cb03:0:b0:46a:a12a:4dcd with SMTP id s3-20020aa7cb03000000b0046aa12a4dcdmr26793708edt.338.1669816293304; Wed, 30 Nov 2022 05:51:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669816293; cv=none; d=google.com; s=arc-20160816; b=iEF3fBtVFUAvbMnX2TDvQX2KQNIYMSdD6q5w5LowYPaDnQvnKpQiTDmprwQxxw547m g3mdjjXRRqJZ1JDXO1d2aUSdxOG9vAWcNLAQnmNcvKo8RNCSQfoIZ6dmXv9FCrl7Drc6 okbVM8Q/hQ7EkImOMqutAY6KhwJ4DXjhiHGubIYR/o/w9rh96ChdBpfOV+tYIEqYGFQ8 z8L2mfy9lZCDZz14rDahr7JmBNYQr5uijQXULySjpGiobtZOtQ2knmsGFcgCq7h99iS6 +ADUL7qQNtcvHQ7bARV67Cv9Yf6o2VLwgRwx5I67rCGxP4qrCzLSwRmv7F5ZL7f5TpWc c7qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=/xUzDDwXF6c96bO3pJUx19srVFCaExJQNi/1k4EEBpU=; b=tewze5+s9lee8K+FfbkkM01gngaRol8qnTycurReZyL8y6aO11VE2YZjWy/eZJtejD 10PId9h/nJwJdVmJhuXY3+TBUiL3DK+n7rJbwzqqUIAIi4UnoyS7zSdCyFl/5hiPddEf s2XWyh1wYVzcLBIX32HKSe7BRXpmyioDXC6WVaVwX36/5IAs6K1CTm2Ey70C4HT82Ql7 Zf62IANQ+vrEQkJsH7wOHvMqQK2IJuovqpDr9FzHi8JkCkHex5dxB5t0UIJMwlCIPcjd aTx1TG2pLeiXw5hAIKzsPhD0/V6aiH2krdne8eowvO65kuK1ERGK4j7vMj6i+AFpv1IF wi3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="Ug/JaiJ7"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qa10-20020a170907868a00b00773db351c39si1459297ejc.64.2022.11.30.05.51.09; Wed, 30 Nov 2022 05:51:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="Ug/JaiJ7"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230082AbiK3NtM (ORCPT + 99 others); Wed, 30 Nov 2022 08:49:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229633AbiK3NtK (ORCPT ); Wed, 30 Nov 2022 08:49:10 -0500 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BA2825C67; Wed, 30 Nov 2022 05:49:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669816149; x=1701352149; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=HI3mIdGxpwMNpBOCxwOqAfT9zwwhndChIxh60vJ//mU=; b=Ug/JaiJ7dPdDlQVJE+lIompSA1RpmrbkKyKqQnJHrua9qN6ytONMlwJ0 KVPNX0U0uRiapcP4zVqz48iQIUgRqEkR/Kn+8vU+yGpjpMWtCHajrNqnL g3yM2E59EIjqF9P3qPhZ40Xfz+hh+Va/Vgi3mJAUug4WIRU4gzoB/YJoB +6qpEXwLTZ6bl3cSvpOW4Z2KR8Wt9/sxCX1r2mTq4pBx8QJxA0pHtxjh/ BXovfc/A6CqCbOVT/9c9XlAaQFEYZFw70lb9yHd3/z7gnd+xCEwlZv1oI VQqJmc5N9DnjPn2G+HI7zo2rnTotqCwSpeCQwLpBZ/5GAHB+BbUc9oE8Y w==; X-IronPort-AV: E=McAfee;i="6500,9779,10547"; a="298769771" X-IronPort-AV: E=Sophos;i="5.96,206,1665471600"; d="scan'208";a="298769771" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2022 05:48:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10546"; a="676825895" X-IronPort-AV: E=Sophos;i="5.96,206,1665471600"; d="scan'208";a="676825895" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga001.jf.intel.com with ESMTP; 30 Nov 2022 05:48:12 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id ABBE73B3; Wed, 30 Nov 2022 15:48:39 +0200 (EET) From: Andy Shevchenko To: Greg Kroah-Hartman , Andy Shevchenko , Mathias Nyman , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Kevin Cernekee , Mathias Nyman Subject: [PATCH v5 3/4] usb: gadget: udc: bcm63xx: Convert to use list_count_nodes() Date: Wed, 30 Nov 2022 15:48:37 +0200 Message-Id: <20221130134838.23805-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221130134838.23805-1-andriy.shevchenko@linux.intel.com> References: <20221130134838.23805-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750929289608625469?= X-GMAIL-MSGID: =?utf-8?q?1750929289608625469?= The list API provides the list_count_nodes() to help with counting existing nodes in the list. Utilise it. Signed-off-by: Andy Shevchenko --- v5: used renamed API (LKP) v4: no change v3: no change v2: no change drivers/usb/gadget/udc/bcm63xx_udc.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/usb/gadget/udc/bcm63xx_udc.c b/drivers/usb/gadget/udc/bcm63xx_udc.c index 2cdb07905bde..771ba1ffce95 100644 --- a/drivers/usb/gadget/udc/bcm63xx_udc.c +++ b/drivers/usb/gadget/udc/bcm63xx_udc.c @@ -2172,7 +2172,6 @@ static int bcm63xx_iudma_dbg_show(struct seq_file *s, void *p) for (ch_idx = 0; ch_idx < BCM63XX_NUM_IUDMA; ch_idx++) { struct iudma_ch *iudma = &udc->iudma[ch_idx]; - struct list_head *pos; seq_printf(s, "IUDMA channel %d -- ", ch_idx); switch (iudma_defaults[ch_idx].ep_type) { @@ -2205,14 +2204,10 @@ static int bcm63xx_iudma_dbg_show(struct seq_file *s, void *p) seq_printf(s, " desc: %d/%d used", iudma->n_bds_used, iudma->n_bds); - if (iudma->bep) { - i = 0; - list_for_each(pos, &iudma->bep->queue) - i++; - seq_printf(s, "; %d queued\n", i); - } else { + if (iudma->bep) + seq_printf(s, "; %zu queued\n", list_count_nodes(&iudma->bep->queue)); + else seq_printf(s, "\n"); - } for (i = 0; i < iudma->n_bds; i++) { struct bcm_enet_desc *d = &iudma->bd_ring[i]; From patchwork Wed Nov 30 13:48:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 27806 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp934077wrr; Wed, 30 Nov 2022 05:50:13 -0800 (PST) X-Google-Smtp-Source: AA0mqf7FtqIcTqlrH7fCXQGe9nH3CQpqbvSDI/Bw8c73flMVwdefaTmoYbt2ShfzdEnUgNTwtc+s X-Received: by 2002:a05:6402:1d87:b0:459:41fa:8e07 with SMTP id dk7-20020a0564021d8700b0045941fa8e07mr38721080edb.140.1669816213121; Wed, 30 Nov 2022 05:50:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669816213; cv=none; d=google.com; s=arc-20160816; b=PkW7DT4Hp+1jqEHRyajRz8cm8fIC8yD7lQZl4GXCGxalSCTvlHEK6qg5tNuQBB6wDr TY3FbfEE+WfiYoi6d6Ae5sXj91MHO+YPbb9VPD/50in/89ZNVJGNNL1hCVppJd6bldtN lBbzBe7fQ45Sokcwq8Z0mdz6RY6cs8DpMFZCuhrrTvdcguSPvlcoMf9aX2SmvONkaAmZ unGQdBpCUHHpNcxL/8LKiIFyP3ZeaJo3KFSi6o0PAxonBnFrDAI/5Ffdp5euGqYHQOAx GjJE40vQQaO1r6f9UKZu/g4hdyAIK203eHNuOD/YnfyXJkYsP4m3zuDZmC2S8SNrXWL/ mWfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=rNTNWBu39OUMpZfilbwhd2iuzr+FhBSiNGsNpSm1+T4=; b=B6WW+37XHrSYXqS7EgGWn9fnbgD48rnZvwbJj66Vm+nzRkYqFKAhWBIOPdPgvbZtV9 nwmMErpXyzmkhNm6yKGzctt/jVQ5zeVAnX9cX/Y0qrnZRixEqy37PosbXOsrOnhXjOQI ppfMMeDFMyg6bh+oS0pad91RXt6bG5akWWc9/qvRFkyySvUyx3xonn9v1oVmS1ezByVy BrV22UOy/b5n3rBrsk1B3EbMXZI5BM37HXmEzyjR3YN2+lWRw9MSTfFZgEfJu7lbiMx/ LxXsTqQVNBHsH4doLb35LgyMr/WTfBWMhas0FAwaiWjCL4eh/ovYnJjPw9kXGy7V32p5 gBSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=LgvrD5zQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lg15-20020a170906f88f00b007adf6f0f962si1043207ejb.291.2022.11.30.05.49.50; Wed, 30 Nov 2022 05:50:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=LgvrD5zQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229973AbiK3NsX (ORCPT + 99 others); Wed, 30 Nov 2022 08:48:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229633AbiK3NsV (ORCPT ); Wed, 30 Nov 2022 08:48:21 -0500 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09E1C5F48; Wed, 30 Nov 2022 05:48:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669816101; x=1701352101; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=I2235I6+qL/ul/8hqTNNkG+zjnVNh7zDAoRuFikuV88=; b=LgvrD5zQb0ocysQASAYDCx17e3g9SqkHqFkwDP7cEfTaRxbauVpDeweM BuUmaZnXMGwRMZ1wuZOg8d1JuEx7YZ7kQkNLziPm9J1DHq0Ee9f4IWhw1 ezNwsKMAaNu48Q5XtDMFO9AxZuJZDEagTrkS6azEcIetvZKcYZmBaxp9T IvEDPFns8Yg6ZSoJwE61E3ZwLJcxAep81bFW4UFk60n6bD5yIY5Bu6j8R THcliaLzmXdcv0NK9Y+pzZnyscCf4a/O3zThNQv5vKCLB7x9ByaMNFlEW LXnk9zIgcxVM4bFfNlu/aBGLlfKCA5M96AShL5frIIwREP9C6NIrASZsQ Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10546"; a="317244867" X-IronPort-AV: E=Sophos;i="5.96,206,1665471600"; d="scan'208";a="317244867" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2022 05:48:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10546"; a="973108894" X-IronPort-AV: E=Sophos;i="5.96,206,1665471600"; d="scan'208";a="973108894" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga005.fm.intel.com with ESMTP; 30 Nov 2022 05:48:12 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id B1E6E184; Wed, 30 Nov 2022 15:48:39 +0200 (EET) From: Andy Shevchenko To: Greg Kroah-Hartman , Andy Shevchenko , Mathias Nyman , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Kevin Cernekee , Mathias Nyman Subject: [PATCH v5 4/4] xhci: Convert to use list_count_nodes() Date: Wed, 30 Nov 2022 15:48:38 +0200 Message-Id: <20221130134838.23805-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221130134838.23805-1-andriy.shevchenko@linux.intel.com> References: <20221130134838.23805-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750929205397322099?= X-GMAIL-MSGID: =?utf-8?q?1750929205397322099?= The list API provides the list_count_nodes() to help with counting existing nodes in the list. Utilise it. Acked-by: Mathias Nyman Signed-off-by: Andy Shevchenko --- v5: used renamed API (LKP) v4: added tag (Mathias) v3: no change v2: no change drivers/usb/host/xhci-ring.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index ddc30037f9ce..aa4d34efecd2 100644 --- a/drivers/usb/host/xhci-ring.c +++ b/drivers/usb/host/xhci-ring.c @@ -2528,7 +2528,6 @@ static int handle_tx_event(struct xhci_hcd *xhci, union xhci_trb *ep_trb; int status = -EINPROGRESS; struct xhci_ep_ctx *ep_ctx; - struct list_head *tmp; u32 trb_comp_code; int td_num = 0; bool handling_skipped_tds = false; @@ -2582,10 +2581,8 @@ static int handle_tx_event(struct xhci_hcd *xhci, } /* Count current td numbers if ep->skip is set */ - if (ep->skip) { - list_for_each(tmp, &ep_ring->td_list) - td_num++; - } + if (ep->skip) + td_num += list_count_nodes(&ep_ring->td_list); /* Look for common error cases */ switch (trb_comp_code) {