From patchwork Tue Nov 29 19:17:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Cercueil X-Patchwork-Id: 27421 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp523379wrr; Tue, 29 Nov 2022 11:19:03 -0800 (PST) X-Google-Smtp-Source: AA0mqf56q+HAj5TiudLfGpN+qTvsQSb41aH+flBphxiZtnGiQOS7K/YB1ZRJcPud6kY0vQ9f/xJ8 X-Received: by 2002:a17:906:dfc1:b0:78d:894d:e123 with SMTP id jt1-20020a170906dfc100b0078d894de123mr32014081ejc.112.1669749543612; Tue, 29 Nov 2022 11:19:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669749543; cv=none; d=google.com; s=arc-20160816; b=ZCEGBeolmpFV+iaMnHUAvTqtqcwd51kpTfY+T0PrKz/y4XiM3udPbBxYpyQx8ORUCd ghdoMgo3FajqJ9dPpbacGf3xCR5bO9PxhmWdq9NTpqjcgAz0wkhqS7/SnIWPCarnidSF LReWaSSqoHCaAmqldw/hUMtnFCyBT3mZ2Fd+JChN6+mKLVuE5hQL2ZmonY4Ayw+eDQNu nnptLMWkk/U43haOatRJmOZtaN5rK5G1cJ+FQfOA6JzQd/2ryEv5eDAzTAgTexCqdc8b 0xhaONj+tk8yY0zI+dan7v3MSHLSMynkzIy8hVYy6eBPl2PgtdesNw7AkDfbxSY3gfQQ dyPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=7gAnxaoVqEWoM5vi/BaBgxdiGzKVxjjTsGqnEeIglYs=; b=xhYkYfoFk/P3LBHp248NJPBRrjdasuwc31rOhUBkgrCoMWz4P9yWwRqz+y4YwucwfG 0PU/KV028bq8xc3QqSKEe4ITwWgpYzbHmx6k6zjU0v2xMV9nmiWrcGmZKl83jLR36C5s 7v3SafwOdoEgIJNktSN5W1p6BpXI1+CR6FT7bYS3uQ/oHfD6LcyKX5DQiwPI/gCD84SU Upj/Q2dwyCyaxsgysAH7Xrw2cc/lUrcT25Gh8UWy68919WuPcoxOVQg+ta3rUJ+S3bPZ pBj83Bbv9t5dHlKTZid6rPEiQ20sMNJk1d1po1QamWx/hmu5VEqq1PkrwdMPKCaUs4QO K8rw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@crapouillou.net header.s=mail header.b=Lb3U8DMa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hr28-20020a1709073f9c00b007bedd130080si6720536ejc.231.2022.11.29.11.18.34; Tue, 29 Nov 2022 11:19:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@crapouillou.net header.s=mail header.b=Lb3U8DMa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236345AbiK2TSB (ORCPT + 99 others); Tue, 29 Nov 2022 14:18:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235356AbiK2TR7 (ORCPT ); Tue, 29 Nov 2022 14:17:59 -0500 Received: from aposti.net (aposti.net [89.234.176.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26CEB20198 for ; Tue, 29 Nov 2022 11:17:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1669749469; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7gAnxaoVqEWoM5vi/BaBgxdiGzKVxjjTsGqnEeIglYs=; b=Lb3U8DMaMv86BzMM+cDyhB6ZOmgECsaSU4wa2llVOeq8427YF/e+LM6bLEc1eB2cFI1SR4 cHxQpiRDgnycev9zdcpVoeoXS8zV88XDwRPGji+L3Mg5C3mOXy4zBHGWVfl5/M/4DS7Aw9 BVcFIFgpdnmmm+0yq9xtiNKl35K8Sfs= From: Paul Cercueil To: David Airlie , Daniel Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Paul Cercueil Subject: [PATCH v2 01/26] drm: modeset-helper: Add DEFINE_DRM_MODE_CONFIG_HELPER_PM_OPS macro Date: Tue, 29 Nov 2022 19:17:08 +0000 Message-Id: <20221129191733.137897-2-paul@crapouillou.net> In-Reply-To: <20221129191733.137897-1-paul@crapouillou.net> References: <20221129191733.137897-1-paul@crapouillou.net> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750859297328900434?= X-GMAIL-MSGID: =?utf-8?q?1750859297328900434?= This macro can be used with simple drivers, which have their "struct drm_device" registered as their "struct device"'s drvdata, and only call drm_mode_config_pm_{suspend,resume}. The macro will define a "struct dev_pm_ops" with the name passed as argument. This object cannot be referenced directly; instead, the pm_sleep_ptr() macro should be used, like this: DEFINE_DRM_MODE_CONFIG_HELPER_PM_OPS(foo_pm_ops); static struct platform_driver foo_driver = { .driver.pm = pm_sleep_ptr(&foo_pm_ops), ... }; This ensures that the generated code will be dropped by the compiler in the case where CONFIG_PM has been disabled in the config. v2: instead of exporting a dev_pm_ops, introduce the DEFINE_DRM_MODE_CONFIG_HELPER_PM_OPS() macro. Signed-off-by: Paul Cercueil --- include/drm/drm_modeset_helper.h | 38 ++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/include/drm/drm_modeset_helper.h b/include/drm/drm_modeset_helper.h index 995fd981cab0..2ecf0e5c2e16 100644 --- a/include/drm/drm_modeset_helper.h +++ b/include/drm/drm_modeset_helper.h @@ -41,4 +41,42 @@ int drm_crtc_init(struct drm_device *dev, struct drm_crtc *crtc, int drm_mode_config_helper_suspend(struct drm_device *dev); int drm_mode_config_helper_resume(struct drm_device *dev); +/** + * DEFINE_DRM_MODE_CONFIG_HELPER_PM_OPS - Generate simple PM callbacks + * + * This macro can be used by simple drivers that would otherwise only call + * drm_mode_config_helper_suspend / drm_mode_config_helper_resume in their PM + * callbacks. It will generate a struct dev_pm_ops of the given name, that can + * then be referenced in the device_driver structure. + * + * Note that it is only valid if the driver's drm_device has been registered as + * the struct device's drvdata. + * + * Additionally, the generated dev_pm_ops structure should not be referenced + * directly; instead, the pm_sleep_ptr() macro should be used, like this: + * + * DEFINE_DRM_MODE_CONFIG_HELPER_PM_OPS(foo_pm_ops); + * + * static struct platform_driver foo_driver = { + * .driver.pm = pm_sleep_ptr(&foo_pm_ops), + * ... + * }; + * + * This ensures that the generated code will be dropped by the compiler in the + * case where CONFIG_PM has been disabled in the config. ++ */ + +#define DEFINE_DRM_MODE_CONFIG_HELPER_PM_OPS(_name) \ + static int __##_name##_drm_mode_config_pm_suspend(struct device *dev) \ + { \ + return drm_mode_config_helper_suspend(dev_get_drvdata(dev)); \ + } \ + static int __##_name##_drm_mode_config_pm_resume(struct device *dev) \ + { \ + return drm_mode_config_helper_resume(dev_get_drvdata(dev)); \ + } \ + static DEFINE_SIMPLE_DEV_PM_OPS(_name, \ + __##_name##_drm_mode_config_pm_suspend, \ + __##_name##_drm_mode_config_pm_resume) + #endif From patchwork Tue Nov 29 19:17:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Cercueil X-Patchwork-Id: 27431 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp524323wrr; Tue, 29 Nov 2022 11:21:36 -0800 (PST) X-Google-Smtp-Source: AA0mqf6WIg6qQjqaynhiIEtn9lZ40Eg/yibS7tqY4RK+G4IYGDtQVbn+JFKWLZntSZMWCyTCMCRT X-Received: by 2002:a17:906:1106:b0:7be:833e:d242 with SMTP id h6-20020a170906110600b007be833ed242mr13426428eja.405.1669749696533; Tue, 29 Nov 2022 11:21:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669749696; cv=none; d=google.com; s=arc-20160816; b=qEtE1yFTq915hp560KggC8piPVqV5h5R89c+BV7z2MB7mYDRrKhealwoSxitlXYrEy NQZNH3seANe4Vc5DM0Oym2dS/SGw9lXHNxJAvxxAH2tS+wWxO86HRJAKawXrYi2oY0Bw W5ptA/796wL1rDIPBmzDTZ0axZ911p+29nvwIEsJ4w2K2oEPnaDHQcCklc/YZssA+A/7 EtCQ1ERyizGCkzkryJNqBCrtWaIdi4Mh/+oxMrdn0AbVccpJdfJH9OTBHQ/DM4WsPpUV ZUzK8GxbeL3pH4knBppSw4yMwY5yddMWd2ivMWkR4T/w4kyU4AE68wYrtTP3KeOZ5BXw ybOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=dIthVPfRqMzRLHonB9Z3+9yNKc8FhZTyJnewRLDcrPs=; b=bJVI/rb/6bszG9dyHNhpJdBzQNhXhDxtNmTxjB7kubMfDLdYr/ra260oWVrQD2sNRT BvGuGCKuoq+U+zj72dlqBTaN2lE4W87Xu7DCNqErwFErkX/pk9je7/LdxRe4Ge7rKIJ5 K1CW0YFovVrApd3e9uB1MUIrD+VS0niM40LVnchCfv5qU30JpTjauYiBjQq1IWDjP9Zm H37DPqY/+b411hFvvI/5JyufgE++GUukgr7d/B4XXsKz7fpsBxc5MszPVAEL+WJIXkXR CIn389CUCSi3ZL+oILwyKJK0+FoOfFKH/M/sUEIxviGXvtZplDqKIpRx/T1PudzIs+Yu OcKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@crapouillou.net header.s=mail header.b=v6cI95cK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jg8-20020a170907970800b0078dcddc1b8csi13655993ejc.788.2022.11.29.11.21.11; Tue, 29 Nov 2022 11:21:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@crapouillou.net header.s=mail header.b=v6cI95cK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236651AbiK2TSN (ORCPT + 99 others); Tue, 29 Nov 2022 14:18:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236680AbiK2TSJ (ORCPT ); Tue, 29 Nov 2022 14:18:09 -0500 Received: from aposti.net (aposti.net [89.234.176.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C493D5B5A9 for ; Tue, 29 Nov 2022 11:18:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1669749470; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dIthVPfRqMzRLHonB9Z3+9yNKc8FhZTyJnewRLDcrPs=; b=v6cI95cKHZF7JRsW6yCZyviPrYgL1hUQg6mGKb3+uSwSQT68AJ3ZblHdt2FXdYjVdF2lxU YhUSzbi1grVPHthQtkb3JWgqIRU8fEVCYtMlY3+3ITbHhcGY6uZfFk5LsBbEBlxgN4TgmX 0FTfc9J1QbkFBazrASWsvhNoZ8uol00= From: Paul Cercueil To: David Airlie , Daniel Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Paul Cercueil , Gerd Hoffmann , virtualization@lists.linux-foundation.org Subject: [PATCH v2 02/26] drm: bochs: Define and use generic PM ops Date: Tue, 29 Nov 2022 19:17:09 +0000 Message-Id: <20221129191733.137897-3-paul@crapouillou.net> In-Reply-To: <20221129191733.137897-1-paul@crapouillou.net> References: <20221129191733.137897-1-paul@crapouillou.net> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750859457987412963?= X-GMAIL-MSGID: =?utf-8?q?1750859457987412963?= Use the new DEFINE_DRM_MODE_CONFIG_HELPER_PM_OPS() macro to create a "struct dev_pm_ops" that can be used by this driver, instead of using custom PM callbacks with the same behaviour. v2: Use the DEFINE_DRM_MODE_CONFIG_HELPER_PM_OPS() macro instead of an exported dev_pm_ops. Signed-off-by: Paul Cercueil --- Cc: Gerd Hoffmann Cc: virtualization@lists.linux-foundation.org --- drivers/gpu/drm/tiny/bochs.c | 29 ++++------------------------- 1 file changed, 4 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/tiny/bochs.c b/drivers/gpu/drm/tiny/bochs.c index 024346054c70..598488905607 100644 --- a/drivers/gpu/drm/tiny/bochs.c +++ b/drivers/gpu/drm/tiny/bochs.c @@ -2,6 +2,7 @@ #include #include +#include #include #include @@ -610,30 +611,6 @@ static const struct drm_driver bochs_driver = { DRM_GEM_VRAM_DRIVER, }; -/* ---------------------------------------------------------------------- */ -/* pm interface */ - -#ifdef CONFIG_PM_SLEEP -static int bochs_pm_suspend(struct device *dev) -{ - struct drm_device *drm_dev = dev_get_drvdata(dev); - - return drm_mode_config_helper_suspend(drm_dev); -} - -static int bochs_pm_resume(struct device *dev) -{ - struct drm_device *drm_dev = dev_get_drvdata(dev); - - return drm_mode_config_helper_resume(drm_dev); -} -#endif - -static const struct dev_pm_ops bochs_pm_ops = { - SET_SYSTEM_SLEEP_PM_OPS(bochs_pm_suspend, - bochs_pm_resume) -}; - /* ---------------------------------------------------------------------- */ /* pci interface */ @@ -716,12 +693,14 @@ static const struct pci_device_id bochs_pci_tbl[] = { { /* end of list */ } }; +DEFINE_DRM_MODE_CONFIG_HELPER_PM_OPS(bochs_pm_ops); + static struct pci_driver bochs_pci_driver = { .name = "bochs-drm", .id_table = bochs_pci_tbl, .probe = bochs_pci_probe, .remove = bochs_pci_remove, - .driver.pm = &bochs_pm_ops, + .driver.pm = pm_sleep_ptr(&bochs_pm_ops), }; /* ---------------------------------------------------------------------- */ From patchwork Tue Nov 29 19:17:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Cercueil X-Patchwork-Id: 27428 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp524171wrr; Tue, 29 Nov 2022 11:21:13 -0800 (PST) X-Google-Smtp-Source: AA0mqf6OnCZEn3/RiOrbAYjTuR+bSLtdeVLAtGvfPaUdOhN/WkeMyIGaxv0fMLK1v60ypmyaDG24 X-Received: by 2002:a17:906:99c8:b0:7b5:ff35:6715 with SMTP id s8-20020a17090699c800b007b5ff356715mr31192608ejn.255.1669749673339; Tue, 29 Nov 2022 11:21:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669749673; cv=none; d=google.com; s=arc-20160816; b=zVhMj+UibgoCLv02kBHvn0+3MPAvoxmwq07ap0DSUrqQaX/Z9NNT21TTs1iq9nLvg1 ir6ZC6ieofIOp5vpLct75UORlhzb7R4CvVEc2Xjy1s8IUL/Jg/HoVNX1ha8FHbgiSVT1 AU3Clg8LNc3HgI/hw0Wmzv53BQP1eIg8vygPfb0PBbBa1jTSR/slDYQwVmXAlAaxT2AB f0OL/6u+8kX6RkZ7Nv8+grHPCwc/LmpGXth0IZ6hr1U9VsHQR9lrGhGJ45yWkD1ufX9r wD3MHCirddjcgYC07lAB5EuqPZsvTxhA35eRgJJRBHNf2L3x2GeAF4mXsnxcpr2A1hs+ mVOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=bRwIBP3Bd5yyj8tKvu5xEITLhoIAEXi+VXTuD8Wv1kk=; b=kDoVRgkxpFIxcaUT1y4QnxFYwAe2BkM7AWRL/rLE4gvgPlmHSrLBgEAU6Bs1D7vUPg fCoryWZwYF5l6yX/sOKhexd8MtoxxnkYnjvMywo9L4DX75zyo9sJpW+PBe7JBAVCqSuv u4ixph0cuZmoYlrhmC8eSGWrZBVSr5HWMVYFA6gREdRS/QuJi3XKKM2wQZv+oZhE5tPz SuR1H93nVihmu0mhKR+8wrBOKU5yqYIWkX+G+2QgOaHFLE8IeMq37x/kxD9K47Vmr+r+ /2Wzp/XdGqytCXtGYNRtAwYGrbDA1F3s1VYNI5zois72HHiujhPtl1rSce+vWH4p6ggV sYhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@crapouillou.net header.s=mail header.b=LIYDR5Ed; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cy15-20020a0564021c8f00b004627741e339si11634534edb.113.2022.11.29.11.20.46; Tue, 29 Nov 2022 11:21:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@crapouillou.net header.s=mail header.b=LIYDR5Ed; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236636AbiK2TST (ORCPT + 99 others); Tue, 29 Nov 2022 14:18:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236689AbiK2TSO (ORCPT ); Tue, 29 Nov 2022 14:18:14 -0500 Received: from aposti.net (aposti.net [89.234.176.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 886AB5A6DF for ; Tue, 29 Nov 2022 11:18:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1669749471; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bRwIBP3Bd5yyj8tKvu5xEITLhoIAEXi+VXTuD8Wv1kk=; b=LIYDR5EdYELj9tAH4IuzuOM34Lt9KwUFjWmnyL2ak9lFDTvcYqbLtlj8VsqXP1bXZfRWeD rns4LoHYtbq2AR5UPz7tQDJBGBgx93ELO4GKjErLZHroxhGXxC851HhhBoI1A5RYzrpBlP Mdv1vzV1x+ZlR21rdec8icpTZR6gL6s= From: Paul Cercueil To: David Airlie , Daniel Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Paul Cercueil , Philipp Zabel , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 03/26] drm: imx: Define and use generic PM ops Date: Tue, 29 Nov 2022 19:17:10 +0000 Message-Id: <20221129191733.137897-4-paul@crapouillou.net> In-Reply-To: <20221129191733.137897-1-paul@crapouillou.net> References: <20221129191733.137897-1-paul@crapouillou.net> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750859433092094939?= X-GMAIL-MSGID: =?utf-8?q?1750859433092094939?= Use the new DEFINE_DRM_MODE_CONFIG_HELPER_PM_OPS() macro to create a "struct dev_pm_ops" that can be used by this driver, instead of using custom PM callbacks with the same behaviour. v2: Use the DEFINE_DRM_MODE_CONFIG_HELPER_PM_OPS() macro instead of an exported dev_pm_ops. Signed-off-by: Paul Cercueil --- Cc: Philipp Zabel Cc: Shawn Guo Cc: Sascha Hauer Cc: Pengutronix Kernel Team Cc: Fabio Estevam Cc: NXP Linux Team Cc: linux-arm-kernel@lists.infradead.org --- drivers/gpu/drm/imx/imx-drm-core.c | 23 ++++------------------- 1 file changed, 4 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c index e060fa6cbcb9..1992934034e0 100644 --- a/drivers/gpu/drm/imx/imx-drm-core.c +++ b/drivers/gpu/drm/imx/imx-drm-core.c @@ -10,6 +10,7 @@ #include #include #include +#include #include