From patchwork Tue Nov 29 14:31:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhen Lei X-Patchwork-Id: 27282 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp379483wrr; Tue, 29 Nov 2022 06:42:28 -0800 (PST) X-Google-Smtp-Source: AA0mqf5RPlQCjmGLmw1i5ZkYDuUFKcI2QzEipI4p/X60byWHFusoj8fqd0vbe1mC6UcJc0o10A4v X-Received: by 2002:a17:903:491:b0:17f:73d6:4375 with SMTP id jj17-20020a170903049100b0017f73d64375mr37752349plb.24.1669732947961; Tue, 29 Nov 2022 06:42:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669732947; cv=none; d=google.com; s=arc-20160816; b=wq1OZE2RZKZQvTtUVA5kuttEVNH7EcpqBRpTJIXVoYpqEGUKNPRIqv86aarH8KVgoZ Ov+GOTxPKADHLg89q1bX1NPq83jbwKYijla3ID5kS/HnI56WhSFbHOloIdwsXWX+oMAH SmdR7QQm83KqlaPcziab/8yu5+tBfkB0onjZ+3QrLURODpPbaV0w66IT+T17aNWEV7mu Uk7ZG/W/aBaCGrsqG8rAz1QpgjYGHr1ByVS5Yw4NHV1LRP2ZC5sO031E/7couXrFY2Vd MeLUCm7z1MwqAhFwmnXVHkqJBhtN37MpPSw9tJ2qWEY5/4PN2uvWB6Ixd+SKxkVpwNAm Yq/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=YXCJsOfdFkCA19TLfZd3DCM4pig6OaCwi5Ajq3QQGf4=; b=LtipRPg3eRlag8BcodGOAe3HKfE/rao8zG9QIz9U3zJGDEexGn7sgbKhTso5q5eckV +aM8/FprpacSVgaRSG50Rqb/YSSITw2RqsHDjqdOlYnkigAfgXfqvF9Kd14rcT8+PR4U EAt2uos4kuqcmI3Zsv/RrxHHX81M66eLarGPfJyjNQQUL6yzE02kSnieWaOrGea7E+9k YUncAzS4hIMdJ5iWarzmvKLU4MIBj2u7qV0Ftebhrkk7qCL6s+6CfSHTIvvtS+9+FPq1 Nolr/hjRpcylvRuj0x9jQmw8RNX8ES7of6mhkMspQd1/P99I5ndI9NpLYKSzi4YmtUjf dzAg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 195-20020a6306cc000000b0043c01032729si15757280pgg.666.2022.11.29.06.41.50; Tue, 29 Nov 2022 06:42:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235408AbiK2Ocd (ORCPT + 99 others); Tue, 29 Nov 2022 09:32:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235385AbiK2Oca (ORCPT ); Tue, 29 Nov 2022 09:32:30 -0500 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 845825800E; Tue, 29 Nov 2022 06:32:24 -0800 (PST) Received: from dggpemm500022.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4NM4XZ45JMzmVJq; Tue, 29 Nov 2022 22:31:42 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggpemm500022.china.huawei.com (7.185.36.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 29 Nov 2022 22:32:22 +0800 Received: from thunder-town.china.huawei.com (10.174.178.55) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 29 Nov 2022 22:32:21 +0800 From: Zhen Lei To: Andy Gross , Bjorn Andersson , Konrad Dybcio , , , CC: Zhen Lei , Wolfram Sang , Vinod Koul Subject: [PATCH] i2c: qcom-geni: Fix error return code in geni_i2c_gpi_xfer() Date: Tue, 29 Nov 2022 22:31:45 +0800 Message-ID: <20221129143145.2067-1-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.37.3.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.174.178.55] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750841895549987161?= X-GMAIL-MSGID: =?utf-8?q?1750841895549987161?= Function geni_i2c_gpi_xfer() returns 'ret' to the upper function instead of gi2c->err. Fixes: d8703554f4de ("i2c: qcom-geni: Add support for GPI DMA") Signed-off-by: Zhen Lei --- drivers/i2c/busses/i2c-qcom-geni.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c index 84a77512614d9fb..8fce98bb77ff974 100644 --- a/drivers/i2c/busses/i2c-qcom-geni.c +++ b/drivers/i2c/busses/i2c-qcom-geni.c @@ -626,7 +626,6 @@ static int geni_i2c_gpi_xfer(struct geni_i2c_dev *gi2c, struct i2c_msg msgs[], i dev_err(gi2c->se.dev, "I2C timeout gpi flags:%d addr:0x%x\n", gi2c->cur->flags, gi2c->cur->addr); gi2c->err = -ETIMEDOUT; - goto err; } if (gi2c->err) {