From patchwork Tue Nov 29 09:45:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 27130 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp236565wrr; Tue, 29 Nov 2022 01:52:55 -0800 (PST) X-Google-Smtp-Source: AA0mqf7vf1nE/4RZzyNCIdBUn/88lj8lTGow/t6IIAsrhmyqsQ5tDhF6hX5u3qv2S+Ui6VPaBVsB X-Received: by 2002:a17:906:c011:b0:778:f9b6:6fc with SMTP id e17-20020a170906c01100b00778f9b606fcmr47583385ejz.580.1669715575796; Tue, 29 Nov 2022 01:52:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669715575; cv=none; d=google.com; s=arc-20160816; b=u73y6kfVLN3Netr8oWdLoGBQ3krjLqPDJNWbh1MmevUmllhBYn/nhiDRYKXxf3OqeQ ULw1kiAS1qDfn65z7k+M3UKX+IN4ZtnRrDntRnKafALl0Q7HN98GloFUE4aSX4fXdVNb eilJ21RHtocri82+i8QRYacFU45bFXjGtEc6Z/tIy9P6B/tBusV2JUPfkPJrFdnM1J0l Q/iq2CeDKE5B3o8MX0Ki0JswhlwqkHR2EXmI+AqQbsUARJugu5KTIoi6i+YHfsL6wuCY qUUDqcdsC41P5HsyiRmKuomMkYxZ7264nrSPN2tlad6G/8095KECK/rGTfnJAHQ/afqT YZew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:dkim-signature; bh=vEjMM0ABy7i3UMzUbAY0TsEEBbd6pZsT6MyfoMMngkU=; b=B5MqRvzZeF8NeDZZZ3WpmIRXFTMS0y1oHNpKieVHYE1d0GgBru7Nsa/FvGuT7mJ9cp gatu9Mnfn8wx7MPhreY3O3rOv09H4D5v7CAY2xTIupyi18m9jNnd5rYqYnDl1XnwVtaZ MBDLq3/cu1zbLfED0+iHY4FIdTZsBtBycbrK3CPfYidusV5q+lWocfyT12hMSsgFGo3v jk4Otut2EfbwrXS22UG4Nf3DgZfSPiDW6tIfPys/66tpT/F88tlpz3eiRaG6kCdstzWL PURvrWLV5MGhh+cov65c1s0LTBJ0GTpYh9j1lS92WY76hpshUtA9OvT+E8RD5e0ZFpU8 f+PA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=YAZRv4bI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qa9-20020a170907868900b007bddb7980f9si7884961ejc.100.2022.11.29.01.52.31; Tue, 29 Nov 2022 01:52:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=YAZRv4bI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230311AbiK2Jp3 (ORCPT + 99 others); Tue, 29 Nov 2022 04:45:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229630AbiK2Jp1 (ORCPT ); Tue, 29 Nov 2022 04:45:27 -0500 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF07220F43; Tue, 29 Nov 2022 01:45:25 -0800 (PST) Received: by mail-wm1-x32b.google.com with SMTP id p16so10437202wmc.3; Tue, 29 Nov 2022 01:45:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=vEjMM0ABy7i3UMzUbAY0TsEEBbd6pZsT6MyfoMMngkU=; b=YAZRv4bIBDi32Cyw324lJeX2UbEFkrfXrwdj7G95NwVVnmS/rnzfdVNW0MHlYFf8Nn dY7aKmYp58nNAmBJBtap0o3UGHp9x9JQZ2VcDWdt/SeDlVzKCj0TR5/DS6YJdX3WEPlv jreok8gX/NaShpnra/vVvwzDk51GXz1iZyWTXWLbGQqpwaHxWbViTpDmvsfHZDqh8w8V tvcfsCfRfskvjFvIG0iIL0r+6axjYsoHHbt+KOR+cwqL2jhEnj+lW9fF9ra7XvEjvrF8 zcVdIPXBIGtzXIz4h/npMthncN93Y00T/7q/sXjB1AnqxctvkhNO2CKmgSU/inzPpTkq Xa+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vEjMM0ABy7i3UMzUbAY0TsEEBbd6pZsT6MyfoMMngkU=; b=u0iC6GRU+K8MZWvP7B7R3Y7pmrL75+VTPsgR2OGStKEllrCRvW/xubD4/adw9yDMIT rj9DEUwcnPg1RmCvViNt/e4oej/oYSVN3y/MY3xkn/i4xn2u2g0taRMWIftcN48Wg0XD fp4vNmQfsUoS+49qQ6vidmxfGXr03n2BJJIAJDSJGPXwdu8mLJxDfLKItEkn4EqGXSS0 OjJhf7rhosi0lxc9067hRiLvL7Fl+oXQmgeVdLFFOStLoGvL6T6jvtg1U6Zo5zS+9xT5 dAOaMQ4z+Ib4DADnm3/dBC5xcdGQ8UUjgAICp87U8PK7JEcfwZxWydZL4vvHt2idnDgZ zayw== X-Gm-Message-State: ANoB5pmyxPIponCR38wEw1AFI8eWxdPWiv+JHcurxb7DjFIJrPH0LvMK GaAysNLUAYKFOaRye23A4JI= X-Received: by 2002:a05:600c:3507:b0:3cf:8e62:f907 with SMTP id h7-20020a05600c350700b003cf8e62f907mr31984552wmq.7.1669715124533; Tue, 29 Nov 2022 01:45:24 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id p7-20020a5d4587000000b0022ae0965a8asm13003997wrq.24.2022.11.29.01.45.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Nov 2022 01:45:23 -0800 (PST) Date: Tue, 29 Nov 2022 12:45:16 +0300 From: Dan Carpenter To: Srinivas Kandagatla , Abel Vesa Cc: Amol Maheshwari , Arnd Bergmann , Greg Kroah-Hartman , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] misc: fastrpc: fix error code in fastrpc_req_mmap() Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750823679253992008?= X-GMAIL-MSGID: =?utf-8?q?1750823679253992008?= The "err" variable shadows an earlier global variable so this code returns success instead of a negative error code. Fixes: 532ad70c6d44 ("misc: fastrpc: Add mmap request assigning for static PD pool") Signed-off-by: Dan Carpenter --- drivers/misc/fastrpc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index c9902a1dcf5d..876f0f146b16 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -1894,7 +1894,6 @@ static int fastrpc_req_mmap(struct fastrpc_user *fl, char __user *argp) /* Add memory to static PD pool, protection thru hypervisor */ if (req.flags != ADSP_MMAP_REMOTE_HEAP_ADDR && fl->cctx->vmcount) { struct qcom_scm_vmperm perm; - int err = 0; perm.vmid = QCOM_SCM_VMID_HLOS; perm.perm = QCOM_SCM_PERM_RWX;