From patchwork Tue Nov 29 00:16:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Kaehlcke X-Patchwork-Id: 26989 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp26739wrr; Mon, 28 Nov 2022 16:20:00 -0800 (PST) X-Google-Smtp-Source: AA0mqf6s9yHqShoISzsvolJ9Bw9Fq1IjovyGmY5s0Y8eBIXxMKfGviRHG9J/RnQ+w9Iq/1OxPcHX X-Received: by 2002:a17:902:d58d:b0:17f:72a4:30a1 with SMTP id k13-20020a170902d58d00b0017f72a430a1mr37430559plh.124.1669681200489; Mon, 28 Nov 2022 16:20:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669681200; cv=none; d=google.com; s=arc-20160816; b=h+6k9KZcqM/BWUdxxEzOjcm4HfoW1EqR0b4bP/cKK3mQKrsPOjIQzW3+70S/572Uol Tl0BrB8rNmFlk1T4BK76XemsatYkRo8NgbsEOxQEkayA+dFz3ptstt+F5K+hLkPaWX+F yPwumQb+0jbtFUmbzetGsfCLai/QDAEhwbr9TYJfPbwh8LsLX2YtDNAM+6s1DBnAZw0h UJwfWjjAHSM5Q0VGuFa1zx9ousREla5Jk8h8cnvGGvDtATyKkD6123axjnSaRt2U9wD3 R4FX+VOVmlqnFtWHhe4iifzAP6Op+/QF3+g90KOaqJTBfRDZC+qb+utMkYOIIH+fwrKG mP+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=gA7jpYl6yV6P4juXicdMOmof7r1j/N5hUrukqrPzGdk=; b=zeS3sBGVylYxrheW9wsm32R+SeRh8AhzM0AKLdBXOysWf6gHOaffV52utI3B6cRUum thQj8utYUgL7agdepmKXv9u6GctqVxA6Wz9QeMxNLyrVcGYmlsnkGp/xxmXPN+HemILy VvODfidN/0CzXsqez4KGLkGWiS2ONW/sq7/Bu0Fk1Dx0Ou5InBfX5tyvKPztJPw5JBKZ pcJQsy0Kpw81YdPQkXxYQ0WgI5Y5lpuFaX1IwR2UrRjSqzvD3U+v/xKUjitI81loe6lP brZTsbVdrOCfcJGvsz68lsLXr89W5zvmoVlIkhXdVEOmYkZtsiHhwKHNDEVt5qLCLIu7 8mAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=DQs1Hqu7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i5-20020a17090a650500b001f2757da25asi147863pjj.91.2022.11.28.16.19.25; Mon, 28 Nov 2022 16:20:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=DQs1Hqu7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234681AbiK2ARG (ORCPT + 99 others); Mon, 28 Nov 2022 19:17:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234807AbiK2AQ7 (ORCPT ); Mon, 28 Nov 2022 19:16:59 -0500 Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45C042B19F for ; Mon, 28 Nov 2022 16:16:58 -0800 (PST) Received: by mail-io1-xd2d.google.com with SMTP id z3so8936485iof.3 for ; Mon, 28 Nov 2022 16:16:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=gA7jpYl6yV6P4juXicdMOmof7r1j/N5hUrukqrPzGdk=; b=DQs1Hqu73bNAJW0k4CHMP/GFzfmwIUvzkUhQZaJ16ASZJ+TVA84Uz1ZP4lfZD1yEpm KGFsQvcP4ne79puTyiCDAu2YusMevht3J9nQCgk5pWCogA/prSxN+g1dt8YrLpRHll0O 8D3SjMY5yHIP9U9huqa3c15zkiE1NJbD9ihwE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gA7jpYl6yV6P4juXicdMOmof7r1j/N5hUrukqrPzGdk=; b=ld3q57NsvX8O2rIDnXTvbL6z5n6jFkfxOKb+8AOSuGrchhYS9A2rWEkj78hiy36xip a5VIIZ41jamAuJXc7j4+huxjCrvoKltM05Oo6jMbcNlbh+oMCbJ9hhHTJPfpPSBdX1dA Vk4sLYOqA7RatO1egvxbMJ+JxGHFysBcWY086pHtS3TW/p6QwpZ20NtmYnW83aHbNoK/ RDax27fNgsWTnkU3MDP863Yn0LXZUn5wlV82XhZCo/GsFjXKQkrAfJF0zPQIi62x2T7F g/YexhnTCeRPi4g+8vZ68uLio0Vc+C46gb6Cw+zRWFjFOiTn4PRP7G1QyBh2+X2hcoyH 6qYg== X-Gm-Message-State: ANoB5pmiHSp4QkzVD6Ud2BYdycyo1F+elWoJvVlSixiD0Mqe5hSX0Vrv RScH0yVZqcHotltMwghzv3WITWdSfTiF8g== X-Received: by 2002:a05:6638:535:b0:375:b7f:daec with SMTP id j21-20020a056638053500b003750b7fdaecmr6888722jar.154.1669681017666; Mon, 28 Nov 2022 16:16:57 -0800 (PST) Received: from localhost (30.23.70.34.bc.googleusercontent.com. [34.70.23.30]) by smtp.gmail.com with UTF8SMTPSA id m12-20020a02a14c000000b003636cb862d0sm4884318jah.42.2022.11.28.16.16.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Nov 2022 16:16:57 -0800 (PST) From: Matthias Kaehlcke To: Srinivas Kandagatla , Banajit Goswami , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: Srinivasa Rao Mandadapu , linux-kernel@vger.kernel.org, Douglas Anderson , alsa-devel@alsa-project.org, Judy Hsiao , Matthias Kaehlcke , Banajit Goswami Subject: [PATCH v2] ASoC: qcom: lpass-sc7180: Delete redundant error log from _resume() Date: Tue, 29 Nov 2022 00:16:54 +0000 Message-Id: <20221129001633.v2.1.I8d1993f41f0da1eac0ecba321678ac489f9c0b9b@changeid> X-Mailer: git-send-email 2.38.1.584.g0f3c55d4c2-goog MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750787634247873928?= X-GMAIL-MSGID: =?utf-8?q?1750787634247873928?= sc7180_lpass_dev_resume() logs an error if clk_bulk_prepare_enable() fails. The clock framework already generates error logs if anything goes wrong, so the logging in _resume() is redundant, drop it. Signed-off-by: Matthias Kaehlcke Reviewed-by: Douglas Anderson --- Changes in v2: - removed the log in the error path (requested by Doug) - updated subject (was "ASoC: qcom: lpass-sc7180: Return 0 instead of 'ret' at the end of _resume()") and commit message sound/soc/qcom/lpass-sc7180.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/sound/soc/qcom/lpass-sc7180.c b/sound/soc/qcom/lpass-sc7180.c index 6ad1c5b5f2de..db3be15cf14c 100644 --- a/sound/soc/qcom/lpass-sc7180.c +++ b/sound/soc/qcom/lpass-sc7180.c @@ -162,15 +162,9 @@ static int sc7180_lpass_exit(struct platform_device *pdev) static int sc7180_lpass_dev_resume(struct device *dev) { - int ret = 0; struct lpass_data *drvdata = dev_get_drvdata(dev); - ret = clk_bulk_prepare_enable(drvdata->num_clks, drvdata->clks); - if (ret) { - dev_err(dev, "sc7180 clk prepare and enable failed\n"); - return ret; - } - return ret; + return clk_bulk_prepare_enable(drvdata->num_clks, drvdata->clks); } static int sc7180_lpass_dev_suspend(struct device *dev)