From patchwork Sun Nov 27 20:32:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 26413 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp5281602wrr; Sun, 27 Nov 2022 12:41:38 -0800 (PST) X-Google-Smtp-Source: AA0mqf6tXHtD5InDikUqE4w4Qd0lfc+TiDV+/FYu3eMSQaFIA3nMjilacaoncIPZI0QXHxjees+r X-Received: by 2002:a17:906:9da4:b0:7ae:100a:8dc0 with SMTP id fq36-20020a1709069da400b007ae100a8dc0mr38883193ejc.424.1669581698404; Sun, 27 Nov 2022 12:41:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669581698; cv=none; d=google.com; s=arc-20160816; b=kK2UU7qa2syMuC7n5VLPAbBbfDo95F7Ztb0EkDr2Pp4g+k8zN1jsd9GW963N1Q/bhK TVyT4lTAkTnLVXmbt9fRqnDmxSRR2aC9RW9NaYTBlQqnm855nvSe6Q5aVMrM42L65W0A 9nZcwIs5jZBNwHhEW8myvGJUD88ymSeLTBJV3lWdF34Eo57KnuH/0IagUHO+crFe2SKC q7+qUCjO6eZm/Cdj6FzVHQOgKe7EjZ8COg7lCsvloKuo1LwaBwQIyH9EUs1x1a+ioYWz sy0KorVVxgBBo2cjgeB9ZsykMvQcVKi2RwtaxpA73Sr5mgT4GoXziOfSB7Nnr+SwABdy qklA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=5wctFOz/nSpTN4OSDfsZrkfnC9lhpWkR8Iis9Z6iKT0=; b=ARWGhxcWcrNWaRN8aSL2oOMqJWkrX5z1WSOxT8mf1GZpMtka71iGNZG0bjsfKSucng XFF5RAMZpEGY5qujYcXnxe85PvBbYmtuBX8idyW5Z1cFjOhFLmreYMLuXHwOquYUeQoP +hX0mI2jLvJcSJ8BYw/JZrIB+NMI2WTwOsebuRVHClvvOum1hWKiqlMrFV0qGgXgZThj qG1VzJpP6DxD71jsW8rq19Mx+PmSkFJ6NkBsvOckj8hkHo8csccdSUZx9zlePhL3Qa07 BQzCafQWrYqiFVYzjUHv3Z+++ttzk27RRk70hFhBoRrwU6n2j/UHxeT/MHsCO8Ygjts+ hGTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Sx86bGCO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hr40-20020a1709073fa800b007417040d1c5si9116510ejc.823.2022.11.27.12.41.12; Sun, 27 Nov 2022 12:41:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Sx86bGCO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229681AbiK0Ucs (ORCPT + 99 others); Sun, 27 Nov 2022 15:32:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229513AbiK0Ucq (ORCPT ); Sun, 27 Nov 2022 15:32:46 -0500 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D58DB64EE for ; Sun, 27 Nov 2022 12:32:44 -0800 (PST) Received: by mail-lf1-x12b.google.com with SMTP id b3so14548285lfv.2 for ; Sun, 27 Nov 2022 12:32:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=5wctFOz/nSpTN4OSDfsZrkfnC9lhpWkR8Iis9Z6iKT0=; b=Sx86bGCOyWNaKmj5BPxdr9MyKwyQeijbpW8Jh7pLwHSF4soVXVHaaz4Pgj7qDi1Yhm KmkzySjj2FCvHeWKPEW5H/U4WZ1XQN/8IBKWXd73E7kqAFB8es02kv4D9lGhIyN9igWm MyvtD8fn0zADpHPbJzZJ9kibX3TgwlMFWh69MoB4HSUtL/Sp3dAOGTjg/9ANgDQUL2Jb S8pYC5H5p+gOUrnxTtGGruMFlU5yFtfTbEumGfggG2q497HUSef7+E5UadoxSZeHPFJn bjW2lN3nO49L3Ve035LI+dCoIDzzF6qd1R95re4Lcpe92FypHGH+RHa8mK7jEOk+9V7X zd5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5wctFOz/nSpTN4OSDfsZrkfnC9lhpWkR8Iis9Z6iKT0=; b=zA51Q358tUeJjI5MzzRa6cwSF9SUP3RbTBth7Uo8SseqwMypJitMZNK3uGwFOVv87m 3cHC2sZtMdzN2o7GjL66ONCzEQE8Q68aHFGqJM9NNUkWjuX0z9Db4C4DolzuDF744dzB 9nzPNhV/QxgyPz9vLKUnQf1GNwT+AlhoAX/5As80VMUbiGegzGlw4coMS/PyYZL81JDL 7n0Tm1oiQqvbtXEfEWzr8F742TVS9/+087GZezwNGym65F1t8hiCbNWZ3G4Ka4l/unYP leZLMSqv7Und9ze35hAdGW4gYvOeEQoB5AKlKMpDJlxoim77WI8PAdlJ1jhJfBhvD04E YDMQ== X-Gm-Message-State: ANoB5pmFpbX6XMKUNYfzHjG8L7cSJveqxC/IvRx8YDGaxZ3SsLnzH1Gm rOR6gPTI1I9hNs6qhas41sr12u74Nocom2Aq X-Received: by 2002:ac2:51cc:0:b0:4b5:a72:1a8 with SMTP id u12-20020ac251cc000000b004b50a7201a8mr2665413lfm.391.1669581163254; Sun, 27 Nov 2022 12:32:43 -0800 (PST) Received: from krzk-bin.NAT.warszawa.vectranet.pl (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id w10-20020a05651234ca00b00494942bec60sm1412827lfr.17.2022.11.27.12.32.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Nov 2022 12:32:42 -0800 (PST) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 1/3] arm64: dts: qcom: msm8996-xiaomi-gemini: use preferred enable-gpios for LP5562 LED Date: Sun, 27 Nov 2022 21:32:38 +0100 Message-Id: <20221127203240.54955-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750683299092415494?= X-GMAIL-MSGID: =?utf-8?q?1750683299092415494?= The preferred name suffix for properties with single and multiple GPIOs is "gpios". Linux GPIO core code supports both. Bindings are going to expect the "gpios" one: qcom/msm8996-xiaomi-gemini.dtb: lp5562@30: 'enable-gpio' does not match any of the regexes: '^led@[0-8]$', '^multi-led@[0-8]$', 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- Changes since v1: 1. New patch --- arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts index d8734913482f..dbd5f7e2df65 100644 --- a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts +++ b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts @@ -54,7 +54,7 @@ lp5562@30 { reg = <0x30>; #address-cells = <1>; #size-cells = <0>; - enable-gpio = <&pm8994_gpios 7 1>; + enable-gpios = <&pm8994_gpios 7 1>; clock-mode = /bits/8 <2>; label = "button-backlight"; From patchwork Sun Nov 27 20:32:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 26414 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp5281984wrr; Sun, 27 Nov 2022 12:42:50 -0800 (PST) X-Google-Smtp-Source: AA0mqf4as2lFY20tb+6KlIx/zc3HTLh7aw/5hk8Ij8MyZ3eCblgIMJ8PxnnL3TY8K0nFjwmBcanX X-Received: by 2002:a17:906:a2da:b0:7ad:84d1:5b56 with SMTP id by26-20020a170906a2da00b007ad84d15b56mr42156532ejb.205.1669581770670; Sun, 27 Nov 2022 12:42:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669581770; cv=none; d=google.com; s=arc-20160816; b=1BHgG5E7S9StnzoWjMF4I41m6umpPSgKGqF7M4X8X47tDrmG+4yVYqkhraGLY1+MV/ tCpAeYni4mkj4GToIeoycQl5+vNDzAiHgEvVAbPAzNl8Gw1dzW5phgbBIET+sse2Puaz o2Pu2nkDGUJAOrbvMCvsavjxUvoXj7fYr18RpOroWAL0CpzyzZsXrFB2q1j39HJuupnA eEKgr7o+4TmEpASO+QC5c4ui50txV9RjBlF1Pu/j5xLvO3Q9uE6vfYIGSbA7lxXdsG+d iO1L63zCXdISI037JydbWr7Eto+PLjNYE5eVwPVjiK2F3I5RH6ozHHcWcI/uoibrYPOW IwYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=i0gDo/HIJ5ncVUDYrkarKtCKmDOnSIZfAfAl1w/MHgI=; b=y9QXLzIGmMNuG79ev2YmArxFvQPWhz3AwM5Gm/EGR4DcJ6fGw3R8e/RP/1Dpso15Mt 4sP0t9pyj+ap9ulKX+LuXEZTUBu0IHGezONiLXF2Lk8wfdM64hh01cNpZsBNngUw8LUc +z2/YA3zPB5uH+0sUV+Y6KPBUvSIAcgjVEVIthXJpbfvIfmVq5pv2nepKiHLj1DBnfLB EjUW77CfN2svX52m+LZJcsX14Znp3FIjs4Wf4V2RWF2xlQMiBMCl+9goDdg23beVI4PW pUD8JVtmQgt8KwnBUqEpcT/pMKMIrx46pkDL0Q4AGcNFQYD1JYDqNQ5ar+HYqPOJRwvH uYPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KYpkDM4Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x6-20020aa7d386000000b004571c47b13csi6983486edq.418.2022.11.27.12.42.26; Sun, 27 Nov 2022 12:42:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KYpkDM4Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229706AbiK0Ucv (ORCPT + 99 others); Sun, 27 Nov 2022 15:32:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229632AbiK0Ucr (ORCPT ); Sun, 27 Nov 2022 15:32:47 -0500 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D54D9B1EE for ; Sun, 27 Nov 2022 12:32:45 -0800 (PST) Received: by mail-lf1-x136.google.com with SMTP id p8so14510408lfu.11 for ; Sun, 27 Nov 2022 12:32:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=i0gDo/HIJ5ncVUDYrkarKtCKmDOnSIZfAfAl1w/MHgI=; b=KYpkDM4QzkKiN1zXSO8kX6iIO1yF3HwGSWAOnjTkOOs7DunEAYL2hUO1p1MAC51Ty2 iy4cweeM6mt9wlfpeESmyPB7rve4LOA0lt4GAxU5K/BxZ9syKVkVOspRQBoEyk/m/O8+ UBwj9Vf68KfLBolMlgBSL7MwSBpxnlsq8I7lOz+aQwAMHMl7/jL5GGRB75hQqFZoXpMO rvsIL5VDWimXfKDca2KzuUORI4ff4Cwv943SLpab+b3sJ36ZETbB7XrLforQIDktc9Ve 5qE7MjYXI80kDzUcjLj0MZDqywrpkLvuzSd2gyWaVNgbRUzYOcIoJnHZyR8cC76/r/jO X3SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i0gDo/HIJ5ncVUDYrkarKtCKmDOnSIZfAfAl1w/MHgI=; b=oHuA+tKSEyNQ+LvirUs2RJDu5tE/D9doks77kOzGlINSRkJQS7+JJABRBD1BYEJWnO 7OJkDkGeTlQAugfy2o02ps5Gez11B1xMQtH3XAHl1+n9lNGb+xVCM+nU6CaXsCvgcSaB d2CdYTjNn+po9mewlOG13ftFUw6XChlzlgRfrwCYnZ1w5IcrFypXVxZwIgD2b458r+9s rHFy665wu2bV01HZAjt+xZAesfdW9wxPssTFEdKum6kko/+F/fmvowiWsoqc1Qq96RRd S3FzxnBIgWM1nH0wniOWFMTy0NxG+Iv1ZWwpCvjxZW5fdbn1QZzclGaASOkUPrvZb9UB /9bw== X-Gm-Message-State: ANoB5pnyxQM6ZVRTrStMiVRE526HNFJ2uKtHjhs3HdDsqTeEyMvbAbTc vzJx3ag7JJd6+LdCkBA3baDR3A== X-Received: by 2002:a05:6512:1681:b0:4a2:683d:3ba4 with SMTP id bu1-20020a056512168100b004a2683d3ba4mr18735394lfb.238.1669581164261; Sun, 27 Nov 2022 12:32:44 -0800 (PST) Received: from krzk-bin.NAT.warszawa.vectranet.pl (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id w10-20020a05651234ca00b00494942bec60sm1412827lfr.17.2022.11.27.12.32.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Nov 2022 12:32:43 -0800 (PST) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 2/3] arm64: dts: qcom: align LED node names with dtschema Date: Sun, 27 Nov 2022 21:32:39 +0100 Message-Id: <20221127203240.54955-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221127203240.54955-1-krzysztof.kozlowski@linaro.org> References: <20221127203240.54955-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750683374693307158?= X-GMAIL-MSGID: =?utf-8?q?1750683374693307158?= The node names should be generic and DT schema expects certain pattern: qcom/msm8998-oneplus-cheeseburger.dtb: leds: 'button-backlight' does not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+' qcom/sc7180-trogdor-coachz-r1.dtb: pwmleds: 'keyboard-backlight' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- Changes since v1: 1. Add Rb --- arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts | 2 +- arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 2 +- arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts b/arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts index b951f98d1b7b..9fb1fb9b8529 100644 --- a/arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts +++ b/arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts @@ -22,7 +22,7 @@ leds { pinctrl-names = "default"; pinctrl-0 = <&button_backlight_default>; - button-backlight { + led-keypad-backlight { gpios = <&pmi8998_gpio 5 GPIO_ACTIVE_HIGH>; color = ; function = LED_FUNCTION_KBD_BACKLIGHT; diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi index 65601bea0797..74a90948db6b 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi @@ -354,7 +354,7 @@ max98360a: audio-codec-0 { pwmleds { compatible = "pwm-leds"; - keyboard_backlight: keyboard-backlight { + keyboard_backlight: led-0 { status = "disabled"; label = "cros_ec::kbd_backlight"; function = LED_FUNCTION_KBD_BACKLIGHT; diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi index 448da9794722..27f479ff9d80 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi @@ -307,7 +307,7 @@ max98360a: audio-codec-0 { pwmleds: pwmleds { compatible = "pwm-leds"; status = "disabled"; - keyboard_backlight: keyboard-backlight { + keyboard_backlight: led-0 { label = "cros_ec::kbd_backlight"; function = LED_FUNCTION_KBD_BACKLIGHT; pwms = <&cros_ec_pwm 0>; From patchwork Sun Nov 27 20:32:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 26412 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp5281589wrr; Sun, 27 Nov 2022 12:41:37 -0800 (PST) X-Google-Smtp-Source: AA0mqf76f09hyK5OvOquSnC0t8+0WjfeMt24yLg3+12UqBT+SC67+VE0vMhF4iGvwgp9llxdJHV/ X-Received: by 2002:a17:907:c314:b0:78c:2b55:59be with SMTP id tl20-20020a170907c31400b0078c2b5559bemr1603317ejc.2.1669581697038; Sun, 27 Nov 2022 12:41:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669581697; cv=none; d=google.com; s=arc-20160816; b=UzX3mfL9KG65P55jqKiGelgfOzKclgZchjaBFABLpCGGw1KFt8K7cvgfdO5mtKX3Bg qupJLIeGJrbStCaCFR4JGnCt9Zvxu3HjwHkndke/n3ucwZc5gg/++aOI4AqlUDMZxUsv hT3s5s4vZaXaA2AG7n8hu/mW5vJLt/nhsCj9hXoptyLv4YGivQxyvPx/q7/5dLuUNCad yk4Pj0LPC6ZoYAFYcbCFcZbgJaCggmdOOD0TXeaRMS7mXgnCYQzDWjPZz+bcPUf6PfAF /2AnCpPjLESbafnM0rI6b5Qegp/esYM606LR6EsbjTHUoHPQf6HGNn1vKZiiVko6WBvi JlUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=jDF3wtVae7sFV7RHSN3RWyepCJgWam189Cxle5ELR+0=; b=Jqz8Z2rvskGjf9oyTLTwaX0ety8wuKgFwD5+x9zj8QCHh8LF7SoHq+aR5E9oZBtlD1 lnlc1AI9LMSlV/Jkd6jT6A06zk4qSOivD6bwmlxu8jgu7ynsKV06E8HOJkxaES3O4Q9b wD8Zfs2TNp3ydPAH0o7ebc5+XKLkxRTlehZfbRg1yUduA27Cekna0fXRCoEmhjw59Ck2 8jmy6gi+jGbuVEnZT280+fa2+aE/V91+thJ25kIJeVWfeacJ1ehKzyYR0TPWeVleyqp2 y+A4ZIT7F9S8N4v+3Yv8M/I1nk9k9cd9zU5Mdv649iu2Yl/wZFHeL7Y/BNfNL4qi5+Pt TjDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=svDjpxjG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id xf9-20020a17090731c900b007b28c65347esi8655486ejb.695.2022.11.27.12.41.12; Sun, 27 Nov 2022 12:41:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=svDjpxjG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229717AbiK0Ucy (ORCPT + 99 others); Sun, 27 Nov 2022 15:32:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229682AbiK0Uct (ORCPT ); Sun, 27 Nov 2022 15:32:49 -0500 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05A19B1E5 for ; Sun, 27 Nov 2022 12:32:47 -0800 (PST) Received: by mail-lj1-x231.google.com with SMTP id l8so10994015ljh.13 for ; Sun, 27 Nov 2022 12:32:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jDF3wtVae7sFV7RHSN3RWyepCJgWam189Cxle5ELR+0=; b=svDjpxjGgEYAtvQEU782VlP0v8qkhnR89/c3bV98qc+sPcuYmy9NlECraEuztBL/H9 +yagQWGEQ/Jf8d/SQYlAIBd0n+O3WBKmJLe5oOMOTUp0D9g88+KGpgCUUa/uf62AVFN2 dCu7gd/D6fE4sDMCIBbYe154EjfgAfuaNAjBskpzwYc8btoBwA/rBDquUqwI5X2h58R9 3HaBeJDl/UoPVioW8vEWJHuf8JRmk+NUST/cfGJdJr3yqj6D3SgneiYIViChc3zn11Hf Dv4EiUbNrfW3S7ubpc0YQ9tXPlX2DMroWqgwW6BmsTlFR7od2U5hbylBAKoHFQ4m+0ny fhig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jDF3wtVae7sFV7RHSN3RWyepCJgWam189Cxle5ELR+0=; b=O5tw0aeATng3iaQVaECNzy8p/lBNLe1Mv0uDYCt5l5GfustHuVHF/YxYyvPRZcGmkb YYIcjOnoJtktrWAYzH+SScYmBKmRZyNe76zeOf8I9Ywn//sOFadsAERU4Kv5XtCHmyGY u7lUxvzB6dtRWnuwSESGHfshjdiwJuLVYAv26EwpW0n3QTW+bHKrUIwTGxZu9GPjXRko s+YhCNJoQ9zeBPrba8pXr16VtczqC4uHflx4rTN5G6wjhvrIWQFQ2DYJyVM25fKMhgKi 9EkeBKQ0yzK7oij1RrS9gmmPmBWz55JUPcCDlvX+NAxJ5zCLw/hLo+CHzSMJVAtaN6N/ vGxw== X-Gm-Message-State: ANoB5pnD5i6wzMP1PKJke2PrRo5mDHC4vHpGKsjqN80izkN6VcmLlvAd JPAI9huh2svqI1M51CY1Yahqmw== X-Received: by 2002:a2e:3e17:0:b0:279:96c4:2c2d with SMTP id l23-20020a2e3e17000000b0027996c42c2dmr3088855lja.153.1669581165273; Sun, 27 Nov 2022 12:32:45 -0800 (PST) Received: from krzk-bin.NAT.warszawa.vectranet.pl (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id w10-20020a05651234ca00b00494942bec60sm1412827lfr.17.2022.11.27.12.32.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Nov 2022 12:32:44 -0800 (PST) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 3/3] ARM: dts: qcom: align LED node names with dtschema Date: Sun, 27 Nov 2022 21:32:40 +0100 Message-Id: <20221127203240.54955-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221127203240.54955-1-krzysztof.kozlowski@linaro.org> References: <20221127203240.54955-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750683298069666071?= X-GMAIL-MSGID: =?utf-8?q?1750683298069666071?= The node names should be generic and DT schema expects certain pattern: qcom-ipq4018-ap120c-ac.dtb: leds: 'wlan2g', 'wlan5g' do not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- Changes since v1: 1. Add Rb --- arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dts | 6 +++--- arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dts | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dts b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dts index cf7da1ab177c..1b27edce9d4f 100644 --- a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dts +++ b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dts @@ -9,7 +9,7 @@ / { leds { compatible = "gpio-leds"; - power { + led-power { label = "ap120c-ac:green:power"; function = LED_FUNCTION_POWER; color = ; @@ -17,14 +17,14 @@ power { default-state = "on"; }; - wlan { + led-wlan { label = "ap120c-ac:green:wlan"; function = LED_FUNCTION_WLAN; color = ; gpios = <&tlmm 3 GPIO_ACTIVE_HIGH>; }; - support { + led-support { label = "ap120c-ac:green:support"; color = ; gpios = <&tlmm 2 GPIO_ACTIVE_HIGH>; diff --git a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dts b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dts index c4f89b712fd9..a707057c887d 100644 --- a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dts +++ b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dts @@ -7,7 +7,7 @@ / { leds { compatible = "gpio-leds"; - status: status { + status: led-status { label = "ap120c-ac:blue:status"; function = LED_FUNCTION_STATUS; color = ; @@ -15,7 +15,7 @@ status: status { default-state = "keep"; }; - wlan2g { + led-wlan2g { label = "ap120c-ac:green:wlan2g"; function = LED_FUNCTION_WLAN; color = ; @@ -23,7 +23,7 @@ wlan2g { linux,default-trigger = "phy0tpt"; }; - wlan5g { + led-wlan5g { label = "ap120c-ac:red:wlan5g"; function = LED_FUNCTION_WLAN; color = ;