From patchwork Sat Nov 26 14:18:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 26251 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp4654848wrr; Sat, 26 Nov 2022 06:18:20 -0800 (PST) X-Google-Smtp-Source: AA0mqf6cZmGxKHJZUjROggPvjo6SrppfUQ642DeB5dPXAbtn29t3H4fj7E+G8VSUIWyzSj/2xpNo X-Received: by 2002:a17:906:728f:b0:7be:a164:9cde with SMTP id b15-20020a170906728f00b007bea1649cdemr347014ejl.681.1669472300674; Sat, 26 Nov 2022 06:18:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669472300; cv=none; d=google.com; s=arc-20160816; b=P0Pde0L1fnIhR4YmtehJFT/pNFNzIJFIM8heCvT46bpL21K3IWEM0Nm8PBZlHJEyt1 qW8LJeSDGV/dl5d/Gxe6Lctwd3su2Wu9Xk7+DnuyGjVDFZyUjqfLQzlr3ClshysQRyx5 tJREXNqRHtTpN5hTm04nT4vHn7gwLiY2YskH/7EWBiqCpUsLhsxCCDpQcyzy7WHrjfht seiYQG1wqdyBcC1avF+B/oxCDRpAjTtf6rCsWTe4ObSbOIAMBU7C3i8zZnY9ZNEUYkVl O1g8q4QZ23987mZq306eTAPPRerrGKc7BUiWbeoUMROnX6jhojbI+Po9QDw0hBhaWxWp 7D+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=sG+m0718Xu+7vjJBz5BBE14ORZJLHLinJeVOcELff6g=; b=URVAAd/OEpFCvpLIVYThZ9qMhj4btEPMioY0ps55MO+gWNL4rQ+aACv5Tbt9zSEKhe xh0CvIIa1fvNOz2JZiSouVspro7FB/9TgwivF7OCO6dMK1ZdViZIJm7FQf7LSUNIL6Dy P7xbIujy/vmXisMTzDYm+L2DH3uAwnr2gr/w9WXyw2DMVY/OtlQ28PyB2wformtnLpfU Z3ZtwpX4MdmxhFXTDwjCjuckRZLctIC0yDP1hYKKSg6/7sATQKVqUUjux6sBGEEon+fk 3wPl9iRBvn6SiW+IVP71ppIFp5kbPAGOa6VDd5ea2JRIH5KIHZ5WJdIg8bjc69o3Bv8X t9fQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="VqUTw/hJ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id tb21-20020a1709078b9500b007b8d4fbca9fsi6282864ejc.899.2022.11.26.06.17.56; Sat, 26 Nov 2022 06:18:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="VqUTw/hJ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229543AbiKZORv (ORCPT + 99 others); Sat, 26 Nov 2022 09:17:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229464AbiKZORt (ORCPT ); Sat, 26 Nov 2022 09:17:49 -0500 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF17D12601; Sat, 26 Nov 2022 06:17:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669472267; x=1701008267; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=MQc84tABIklxiwjd/JnPm2AoEMxnQw6t0O2sj0eZ5D4=; b=VqUTw/hJzygvYM2uqZxoRAkXgP9ajRa/2tM1WyOBIjw8dyKIoUnVqPEm GxbtRruMnjXjgDU6ulBkeDOTl1drUPKwYgwXRkeGemcV9g8BeQrdSFue9 NjNVxYeqAY56xwPheDqa7g/ZldrUn/V6J8W4ykqUk+C+ncrQij3RITJ19 5J612ePgqew1HSjbJugLLr4N6lUeGLJ6+waKxSVy+AmUG21GE70Mo106+ oEYuTDVjxYE5ma8wJ8EM55YLe/IjYLH8X2y/Yk4cpsW620rXAGvDZMmKe m/COFIB0O+jkWZT2hXP77kDlmzJ/k29Uu9Lr01rA98e+l4P+IEMr55GZt w==; X-IronPort-AV: E=McAfee;i="6500,9779,10543"; a="315755383" X-IronPort-AV: E=Sophos;i="5.96,196,1665471600"; d="scan'208";a="315755383" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Nov 2022 06:17:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10543"; a="971800593" X-IronPort-AV: E=Sophos;i="5.96,196,1665471600"; d="scan'208";a="971800593" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga005.fm.intel.com with ESMTP; 26 Nov 2022 06:17:44 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 007F710E; Sat, 26 Nov 2022 16:18:10 +0200 (EET) From: Andy Shevchenko To: Rasmus Villemoes , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org Cc: Alessandro Zummo , Alexandre Belloni , Jean Delvare , Guenter Roeck , Andy Shevchenko Subject: [PATCH v1 1/5] rtc: isl12022: Get rid of unneeded private struct isl12022 Date: Sat, 26 Nov 2022 16:18:02 +0200 Message-Id: <20221126141806.62205-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750568587475542868?= X-GMAIL-MSGID: =?utf-8?q?1750568587475542868?= First of all, the struct rtc_device pointer is kept in the managed resources, no need to keep it outside (no users in the driver). Second, replace private struct isl12022 with a regmap. Signed-off-by: Andy Shevchenko Acked-by: Rasmus Villemoes --- drivers/rtc/rtc-isl12022.c | 56 ++++++++++++++------------------------ 1 file changed, 21 insertions(+), 35 deletions(-) diff --git a/drivers/rtc/rtc-isl12022.c b/drivers/rtc/rtc-isl12022.c index a3b0de3393f5..44058fa27277 100644 --- a/drivers/rtc/rtc-isl12022.c +++ b/drivers/rtc/rtc-isl12022.c @@ -46,11 +46,6 @@ static struct i2c_driver isl12022_driver; -struct isl12022 { - struct rtc_device *rtc; - struct regmap *regmap; -}; - static umode_t isl12022_hwmon_is_visible(const void *data, enum hwmon_sensor_types type, u32 attr, int channel) @@ -67,8 +62,7 @@ static umode_t isl12022_hwmon_is_visible(const void *data, */ static int isl12022_hwmon_read_temp(struct device *dev, long *mC) { - struct isl12022 *isl12022 = dev_get_drvdata(dev); - struct regmap *regmap = isl12022->regmap; + struct regmap *regmap = dev_get_drvdata(dev); u8 temp_buf[2]; int temp, ret; @@ -115,23 +109,21 @@ static const struct hwmon_chip_info isl12022_hwmon_chip_info = { static void isl12022_hwmon_register(struct device *dev) { - struct isl12022 *isl12022; + struct regmap *regmap = dev_get_drvdata(dev); struct device *hwmon; int ret; if (!IS_REACHABLE(CONFIG_HWMON)) return; - isl12022 = dev_get_drvdata(dev); - - ret = regmap_update_bits(isl12022->regmap, ISL12022_REG_BETA, + ret = regmap_update_bits(regmap, ISL12022_REG_BETA, ISL12022_BETA_TSE, ISL12022_BETA_TSE); if (ret) { dev_warn(dev, "unable to enable temperature sensor\n"); return; } - hwmon = devm_hwmon_device_register_with_info(dev, "isl12022", isl12022, + hwmon = devm_hwmon_device_register_with_info(dev, "isl12022", regmap, &isl12022_hwmon_chip_info, NULL); if (IS_ERR(hwmon)) @@ -144,8 +136,7 @@ static void isl12022_hwmon_register(struct device *dev) */ static int isl12022_rtc_read_time(struct device *dev, struct rtc_time *tm) { - struct isl12022 *isl12022 = dev_get_drvdata(dev); - struct regmap *regmap = isl12022->regmap; + struct regmap *regmap = dev_get_drvdata(dev); uint8_t buf[ISL12022_REG_INT + 1]; int ret; @@ -190,8 +181,7 @@ static int isl12022_rtc_read_time(struct device *dev, struct rtc_time *tm) static int isl12022_rtc_set_time(struct device *dev, struct rtc_time *tm) { - struct isl12022 *isl12022 = dev_get_drvdata(dev); - struct regmap *regmap = isl12022->regmap; + struct regmap *regmap = dev_get_drvdata(dev); int ret; uint8_t buf[ISL12022_REG_DW + 1]; @@ -218,8 +208,7 @@ static int isl12022_rtc_set_time(struct device *dev, struct rtc_time *tm) buf[ISL12022_REG_DW] = tm->tm_wday & 0x07; - return regmap_bulk_write(isl12022->regmap, ISL12022_REG_SC, - buf, sizeof(buf)); + return regmap_bulk_write(regmap, ISL12022_REG_SC, buf, sizeof(buf)); } static const struct rtc_class_ops isl12022_rtc_ops = { @@ -235,34 +224,31 @@ static const struct regmap_config regmap_config = { static int isl12022_probe(struct i2c_client *client) { - struct isl12022 *isl12022; + struct rtc_device *rtc; + struct regmap *regmap; if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) return -ENODEV; - isl12022 = devm_kzalloc(&client->dev, sizeof(struct isl12022), - GFP_KERNEL); - if (!isl12022) - return -ENOMEM; - dev_set_drvdata(&client->dev, isl12022); - - isl12022->regmap = devm_regmap_init_i2c(client, ®map_config); - if (IS_ERR(isl12022->regmap)) { + regmap = devm_regmap_init_i2c(client, ®map_config); + if (IS_ERR(regmap)) { dev_err(&client->dev, "regmap allocation failed\n"); - return PTR_ERR(isl12022->regmap); + return PTR_ERR(regmap); } + dev_set_drvdata(&client->dev, regmap); + isl12022_hwmon_register(&client->dev); - isl12022->rtc = devm_rtc_allocate_device(&client->dev); - if (IS_ERR(isl12022->rtc)) - return PTR_ERR(isl12022->rtc); + rtc = devm_rtc_allocate_device(&client->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); - isl12022->rtc->ops = &isl12022_rtc_ops; - isl12022->rtc->range_min = RTC_TIMESTAMP_BEGIN_2000; - isl12022->rtc->range_max = RTC_TIMESTAMP_END_2099; + rtc->ops = &isl12022_rtc_ops; + rtc->range_min = RTC_TIMESTAMP_BEGIN_2000; + rtc->range_max = RTC_TIMESTAMP_END_2099; - return devm_rtc_register_device(isl12022->rtc); + return devm_rtc_register_device(rtc); } #ifdef CONFIG_OF From patchwork Sat Nov 26 14:18:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 26253 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp4655049wrr; Sat, 26 Nov 2022 06:18:42 -0800 (PST) X-Google-Smtp-Source: AA0mqf5aJDHEkAGcjpDnQTduFLkF7g4S7AkD3Lf1izSA2kCFIUMf0xqffbPetTxOSZ9rs8VOySgG X-Received: by 2002:a17:906:381:b0:78c:b8b0:9d35 with SMTP id b1-20020a170906038100b0078cb8b09d35mr28465636eja.586.1669472322471; Sat, 26 Nov 2022 06:18:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669472322; cv=none; d=google.com; s=arc-20160816; b=PaZ0xnuos4TJdtG2k9dGi7g0Ij6ka47z0rQumxwxWa8q7674mDOnt+ZBp5Cww065E/ 0Uh9xyBGktW5UPteAuel+j1WAe7cInBL7AUpthQK25XuDsZpZT6x2sCpYtyziUDQnYff 5J9nDiZ0A/G4SB9RcO8flZGs767F4o68LiDaHOcJQJoL0NOb+hzpUHwEWOISO8An4z6j WmRL5kG/ph+OVY537odNLsrJrIOxNTwVKSNyN3BdvlH2tvHOyAhjk+SzCXGdSHqI2RFV 6QPTidh3ua7ELNftnubblnLrx24ZDGyzuWhbufmJAKMFQtmbQk5+Ne9727rCI+BAJW4n nURw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=qlGGkSHrXtusSXd8xa8kBsqj6lC7wEJ6B7BSx6vNvN0=; b=AsXpUmWNEmfsSPkzFg6dsTO7JZ0vHZiIu6GqivkVZTMsx6n7KL1yO7pf2iZFfd1SDZ PWoFjmB0zzsGq/yNdKaXVi7CHGulg4VRzMOtLTi3Q4FcRzhhCdgJbQqAYP8CiqyuDtcs LN1g0cOrDTaKKQuYlQmqBvSXpxowy4IC9GluumxwwggABXpCGKFvKHOT3g/Yf01UQvLK u5gXZaNiCdBmteFXjN2cbXO/3VTXLBX0S3NpByNxaEtjT8FHvEqT8zD7Pv+jRDMdk5IZ H5zV+E9p1JKZK9NQmlwmHD6+su39OnBXqVz8l9QMTdKghHobrdgpX7kn0JqfZWM2iDQN E+PQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=FY8AE7KU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id br13-20020a170906d14d00b00783c42d2da1si4782713ejb.425.2022.11.26.06.18.19; Sat, 26 Nov 2022 06:18:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=FY8AE7KU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229595AbiKZOR6 (ORCPT + 99 others); Sat, 26 Nov 2022 09:17:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229546AbiKZORv (ORCPT ); Sat, 26 Nov 2022 09:17:51 -0500 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 215F118E23; Sat, 26 Nov 2022 06:17:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669472271; x=1701008271; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Ll+1FVMo/UXGN2SeeyQhin6WVr2RA2XTjdyAG4/biUo=; b=FY8AE7KUgRk7HOwBqmFh2USuaOx4AjWGqjVElFnjZJaODgh4kJlCw1en qLmXynFBR1a4XU5s2Ml7ACxpYDcziXC7VINOraMRAQ6H6XKuRtP33atXw SqgnjRnGnMxv8EQtvFkLlmFCw9FcmGHVjbxKmlol5yCRg3rGs1P40pIya v8NehovDAJZmorWm5+/6Co6xQGGbY1wN8V3M75m/JqTGSCJYOaUib+BId Kjp6kv93rzP/v+XI/OGXM/ddPe5i8iikdvZD8BWk9rBFuJXdVDYGffEHy tB0+/z2HV4qpW87yvDr57SimH/4g7xSqsO2fhRER8kpTGlWyxFBQzaJrG Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10543"; a="315755386" X-IronPort-AV: E=Sophos;i="5.96,196,1665471600"; d="scan'208";a="315755386" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Nov 2022 06:17:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10543"; a="971800597" X-IronPort-AV: E=Sophos;i="5.96,196,1665471600"; d="scan'208";a="971800597" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga005.fm.intel.com with ESMTP; 26 Nov 2022 06:17:44 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 0BA05B7; Sat, 26 Nov 2022 16:18:11 +0200 (EET) From: Andy Shevchenko To: Rasmus Villemoes , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org Cc: Alessandro Zummo , Alexandre Belloni , Jean Delvare , Guenter Roeck , Andy Shevchenko Subject: [PATCH v1 2/5] rtc: isl12022: Explicitly use __le16 type for ISL12022_REG_TEMP_L Date: Sat, 26 Nov 2022 16:18:03 +0200 Message-Id: <20221126141806.62205-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221126141806.62205-1-andriy.shevchenko@linux.intel.com> References: <20221126141806.62205-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750568609820845706?= X-GMAIL-MSGID: =?utf-8?q?1750568609820845706?= We are reading 10-bit value in a 16-bit register in LE format. Make this explicit by using __le16 type for it and corresponding conversion function. Signed-off-by: Andy Shevchenko Acked-by: Rasmus Villemoes --- drivers/rtc/rtc-isl12022.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-isl12022.c b/drivers/rtc/rtc-isl12022.c index 44058fa27277..bf1aa6f6560d 100644 --- a/drivers/rtc/rtc-isl12022.c +++ b/drivers/rtc/rtc-isl12022.c @@ -19,6 +19,8 @@ #include #include +#include + /* ISL register offsets */ #define ISL12022_REG_SC 0x00 #define ISL12022_REG_MN 0x01 @@ -63,17 +65,16 @@ static umode_t isl12022_hwmon_is_visible(const void *data, static int isl12022_hwmon_read_temp(struct device *dev, long *mC) { struct regmap *regmap = dev_get_drvdata(dev); - u8 temp_buf[2]; int temp, ret; + __le16 buf; - ret = regmap_bulk_read(regmap, ISL12022_REG_TEMP_L, - temp_buf, sizeof(temp_buf)); + ret = regmap_bulk_read(regmap, ISL12022_REG_TEMP_L, &buf, sizeof(buf)); if (ret) return ret; /* * Temperature is represented as a 10-bit number, unit half-Kelvins. */ - temp = (temp_buf[1] << 8) | temp_buf[0]; + temp = le16_to_cpu(buf); temp *= 500; temp -= 273000; From patchwork Sat Nov 26 14:18:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 26254 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp4655431wrr; Sat, 26 Nov 2022 06:19:24 -0800 (PST) X-Google-Smtp-Source: AA0mqf56LYI9q4uGNyM+dVgwK9q8F9P1y7VLfrSy0G7nxzQmaIPRtRuhiq6IhMLHbVYKCeRx2Y16 X-Received: by 2002:a17:906:1d14:b0:7ad:79c0:46f4 with SMTP id n20-20020a1709061d1400b007ad79c046f4mr36192839ejh.363.1669472364287; Sat, 26 Nov 2022 06:19:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669472364; cv=none; d=google.com; s=arc-20160816; b=DOSLRJImFFvV+fSMxtJsYEO9xSdM7LwVG4XERHOS5QWw8tyNmzzhS7Ttb+FIoo6jxe KOxGdcp+77G8m4oRvT/el9iaOvDnehtCMmEmCT8agnFdcMe6V+pBUPjQ+bx+m7eEvYxI WqJsDIIZbE8cb38QEsnnSxxp2cIPQwgkoT2BIAtRTx8YH3VGdGyjDJMCwusabKm7otkR 3cR6YvGZZ6RbfRZiD/KZg0eJY9hHMrYpNbF9vAVxfOfWvOy9UzNOZOOCU4G6cs017PNX L+xWuGbKY1J/btA0iaM5wskd8aKtmsIY9JFfTM8NgiYGvA1zjJQ9D63b/rt+DumDSOQk WU9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=8WyitQTpDJ3VD7jjLUPXjqiSeGPc+6q/OnOwmUEbV2I=; b=0guYNZ1vk2RtWlawFe6meApRKsOzTW11vMC4ky+Y7L9OM6FFNMUwEjnfrXVsNUSntP 7+2ppO2+hyQc2FX4o+Epw95mzgtwi2tuikVfBbnfg2DA3wWKe34/Lqog8gLQ4gBVe9+n NHJjmP2R3SwFfPsBgL2a0YKk6fvoTKLBIHnOBQYbI13M1R8w1NK4hw5psDcLqaTADcye VhUUU1wy8oTHvYDYpKOl47Ke5vLr7qhZJ3ZbAMeG5GO2Fkwc7rc6hUv9gW89b1j2t7kb I2f15oqXav8lyxfUxo+Pw41SuHMyW/z2Y3c10CgUNYPtzjFesHY+PoiuPe5RAeY9+9Pq F6ZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=F9jugEsT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id xh13-20020a170906da8d00b0078df185078esi6401562ejb.663.2022.11.26.06.18.59; Sat, 26 Nov 2022 06:19:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=F9jugEsT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229590AbiKZOR4 (ORCPT + 99 others); Sat, 26 Nov 2022 09:17:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229538AbiKZORv (ORCPT ); Sat, 26 Nov 2022 09:17:51 -0500 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A09F920341; Sat, 26 Nov 2022 06:17:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669472269; x=1701008269; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=XCP49we+GzcR7CAEn/BKujEcmW+ItDZgyYbuqmySPzI=; b=F9jugEsTP4gvGTi28CYrEuKgn8CDdyN6h8/+SdsCz13CI39hg1dHgW25 Qj/u0xlPB2HresxXVdCyMm5HT5sK+0hda5QyvycC/uEtqyyEL9iotjcJ3 bpLyRNjM08ICv07H+D8/aaU88EbLA4pAOV3mO5ecZxUunhsDJCGMWCHiE H1KZK903Re/6O+jf67zb9I+28frl/1DRVy2WKYXuJbx3sfegY7AqWqjnF NYsHyaHsDYhFZxwdukyVKXal1LlcSgeeB4aH/eOz66lpnA1+Xc6Cxi0aS Q3RuFps0DPaKa/gxUgG8uK/GKhB1pEEOq72cGpautq6PGj/8FqNPwZ6rh g==; X-IronPort-AV: E=McAfee;i="6500,9779,10543"; a="315755385" X-IronPort-AV: E=Sophos;i="5.96,196,1665471600"; d="scan'208";a="315755385" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Nov 2022 06:17:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10543"; a="971800595" X-IronPort-AV: E=Sophos;i="5.96,196,1665471600"; d="scan'208";a="971800595" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga005.fm.intel.com with ESMTP; 26 Nov 2022 06:17:44 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 181CD179; Sat, 26 Nov 2022 16:18:11 +0200 (EET) From: Andy Shevchenko To: Rasmus Villemoes , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org Cc: Alessandro Zummo , Alexandre Belloni , Jean Delvare , Guenter Roeck , Andy Shevchenko Subject: [PATCH v1 3/5] rtc: isl12022: Drop unneeded OF guards and of_match_ptr() Date: Sat, 26 Nov 2022 16:18:04 +0200 Message-Id: <20221126141806.62205-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221126141806.62205-1-andriy.shevchenko@linux.intel.com> References: <20221126141806.62205-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750568653805637168?= X-GMAIL-MSGID: =?utf-8?q?1750568653805637168?= Drop unneeded OF guards and of_match_ptr(). This allows use of the driver with other types of firmware such as ACPI PRP0001 based probing. Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-isl12022.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/rtc/rtc-isl12022.c b/drivers/rtc/rtc-isl12022.c index bf1aa6f6560d..77b4763f2a70 100644 --- a/drivers/rtc/rtc-isl12022.c +++ b/drivers/rtc/rtc-isl12022.c @@ -14,8 +14,6 @@ #include #include #include -#include -#include #include #include @@ -46,8 +44,6 @@ #define ISL12022_BETA_TSE (1 << 7) -static struct i2c_driver isl12022_driver; - static umode_t isl12022_hwmon_is_visible(const void *data, enum hwmon_sensor_types type, u32 attr, int channel) @@ -252,14 +248,12 @@ static int isl12022_probe(struct i2c_client *client) return devm_rtc_register_device(rtc); } -#ifdef CONFIG_OF static const struct of_device_id isl12022_dt_match[] = { { .compatible = "isl,isl12022" }, /* for backward compat., don't use */ { .compatible = "isil,isl12022" }, { }, }; MODULE_DEVICE_TABLE(of, isl12022_dt_match); -#endif static const struct i2c_device_id isl12022_id[] = { { "isl12022", 0 }, @@ -270,9 +264,7 @@ MODULE_DEVICE_TABLE(i2c, isl12022_id); static struct i2c_driver isl12022_driver = { .driver = { .name = "rtc-isl12022", -#ifdef CONFIG_OF - .of_match_table = of_match_ptr(isl12022_dt_match), -#endif + .of_match_table = isl12022_dt_match, }, .probe_new = isl12022_probe, .id_table = isl12022_id, From patchwork Sat Nov 26 14:18:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 26255 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp4660468wrr; Sat, 26 Nov 2022 06:30:50 -0800 (PST) X-Google-Smtp-Source: AA0mqf64sISREf4ziLDZYunbnwn1vGtWgqyYBRDX6dNKZUwMMe4xrmE497ZD57NULma+MPQ4U1y8 X-Received: by 2002:a17:906:2345:b0:7ad:adfe:1ceb with SMTP id m5-20020a170906234500b007adadfe1cebmr28602601eja.89.1669473049686; Sat, 26 Nov 2022 06:30:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669473049; cv=none; d=google.com; s=arc-20160816; b=AnIIibUIOiL4UUWoWwIUc9EkVD2znTyuMw8ajggMs/pNuPBu+O8Kq0/TZH3tpF+SWs zq01vEeimPR2yqGbWyqpFzIp4fkPZdhVzMaU4e+Ahbx545NIiv7NylEde2+Ge8UB4h3b H5vVLVRzu+MDRjCetPaZCOci2lWd8p6vs1HFMFADzDtMs+kpO6vg1bZjrh3fD0MibzyF Zp30FEso7mOwSc8Y2ih1qpihnt50s4u4cxv30i5bBItgU9JG4bp0c9Ix5m8gaDOWWFN8 p3Jl0/tm+4z1hD1z7sGtpsUb9BaoLgR6sExq0X97qcU+ifWjpJNUvI1r/mWk5tV5Hn9K 46Lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=NGFuESZydqqmqGXuVkYld3KE3dgqgqhhOSlGXowiVKk=; b=ZMdn3vnx0aCzaj8/OdAU2pdzhMEQcTg1Dr6tPq4dSRqHzdiAikEiHVkX+0etpQVIbs N0DY+tNs7rWPh3B4J7P5YOGG44xuScooK3UK6fhPU3v2Sb2WpICrYbKgjNE/hl0iF3h6 E8mCuisMEIiFZ/PYVKXocUW6WPWC4cAXXzS2qnf64/9dbjfce/0pslVQr/DtDHeas/Jx tvjaaHo23lncf201Yglu2ic+shmBiFLrlxeyzB7df93nsWhmpNFEc/itbAIbZ4s7zyL1 PNFnkVmjYLJcprSmnbphhjVMtC7mo6qLBwksoTNWoyFOtwJySjgGjwUgQFbj6O4GI0pD UVRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="n0R/em1l"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m9-20020a170906848900b007ae186b15f9si4583491ejx.597.2022.11.26.06.30.26; Sat, 26 Nov 2022 06:30:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="n0R/em1l"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229612AbiKZOSB (ORCPT + 99 others); Sat, 26 Nov 2022 09:18:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229534AbiKZORv (ORCPT ); Sat, 26 Nov 2022 09:17:51 -0500 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21F2B18E3B; Sat, 26 Nov 2022 06:17:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669472271; x=1701008271; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=tzQvOKWf3TMH/Dd1rfQ3NBBo0TXSVQc4zhcPWFce9AM=; b=n0R/em1l38MVw5om6c33CY5DdL3jzuP5MyoXvcM0onYB+NKGbZDneGPI LTR7GQST1iow0kvbmrGkR6q+/MD1V6ZtXqvMsFfUkbwhSWA4klMxmLC6r S5BTqD3CY8YivGVAadEJjnM7KZvRNt2jDlPeU7d5Si/dTn6FZBPy8ZK2C z/8Keq8qZSe1M2CMi70sG1kFs03tHgawcQvgtwUb4qAdMz0QCOdYFPEJF byBes19Q5sZzqjFNpXkKZdxyLOPiCI1ckss2q29GZz9U+Tt8vWYB36NpV iiosdMv7FyR9ZlbFGv1gdCGxhyISlfBo1hq7EZN81wotF0KtCSZfTWtCq A==; X-IronPort-AV: E=McAfee;i="6500,9779,10543"; a="315755387" X-IronPort-AV: E=Sophos;i="5.96,196,1665471600"; d="scan'208";a="315755387" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Nov 2022 06:17:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10543"; a="971800596" X-IronPort-AV: E=Sophos;i="5.96,196,1665471600"; d="scan'208";a="971800596" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga005.fm.intel.com with ESMTP; 26 Nov 2022 06:17:44 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 29EC03B3; Sat, 26 Nov 2022 16:18:11 +0200 (EET) From: Andy Shevchenko To: Rasmus Villemoes , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org Cc: Alessandro Zummo , Alexandre Belloni , Jean Delvare , Guenter Roeck , Andy Shevchenko Subject: [PATCH v1 4/5] rtc: isl12022: Join string literals back Date: Sat, 26 Nov 2022 16:18:05 +0200 Message-Id: <20221126141806.62205-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221126141806.62205-1-andriy.shevchenko@linux.intel.com> References: <20221126141806.62205-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750569372966049707?= X-GMAIL-MSGID: =?utf-8?q?1750569372966049707?= For easy grepping on debug purposes join string literals back in the messages. While at it, drop __func__ parameter from unique enough dev_dbg() message as Dynamic Debug can retrieve this at run time. Signed-off-by: Andy Shevchenko Acked-by: Rasmus Villemoes --- drivers/rtc/rtc-isl12022.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-isl12022.c b/drivers/rtc/rtc-isl12022.c index 77b4763f2a70..ee38c5067ea8 100644 --- a/drivers/rtc/rtc-isl12022.c +++ b/drivers/rtc/rtc-isl12022.c @@ -143,16 +143,12 @@ static int isl12022_rtc_read_time(struct device *dev, struct rtc_time *tm) if (buf[ISL12022_REG_SR] & (ISL12022_SR_LBAT85 | ISL12022_SR_LBAT75)) { dev_warn(dev, - "voltage dropped below %u%%, " - "date and time is not reliable.\n", + "voltage dropped below %u%%, date and time is not reliable.\n", buf[ISL12022_REG_SR] & ISL12022_SR_LBAT85 ? 85 : 75); } dev_dbg(dev, - "%s: raw data is sec=%02x, min=%02x, hr=%02x, " - "mday=%02x, mon=%02x, year=%02x, wday=%02x, " - "sr=%02x, int=%02x", - __func__, + "raw data is sec=%02x, min=%02x, hr=%02x, mday=%02x, mon=%02x, year=%02x, wday=%02x, sr=%02x, int=%02x", buf[ISL12022_REG_SC], buf[ISL12022_REG_MN], buf[ISL12022_REG_HR], From patchwork Sat Nov 26 14:18:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 26252 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp4654882wrr; Sat, 26 Nov 2022 06:18:24 -0800 (PST) X-Google-Smtp-Source: AA0mqf4BzH9bWM4762zoA5IKIMDn4xs33CopVzltd0wfTqL/WsCgkGbYTa5HeU4DIQVuy1I/asfb X-Received: by 2002:a17:906:5f85:b0:7bc:6bb7:41c1 with SMTP id a5-20020a1709065f8500b007bc6bb741c1mr7558156eju.353.1669472304070; Sat, 26 Nov 2022 06:18:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669472304; cv=none; d=google.com; s=arc-20160816; b=EZAI2F7GZ3J/MaRBm7Tyxt3Tx9WnUc1R08K+5OAi58lWG1HEzeiJm+vL6RcJm55x1G KCp9DGsBLcjl6hBR7Azip1NgXgE24CujAsauASe+beUZtFePvCFecO4GWpoQttfe2dnl kod/PYCU1h7ZcANxCoQqxVEXIfCQOM2vIrVYi37mbpQYRZBwaGs8JbYCDI+VI+TEP2mr U8ESmxciKbETehrPmmPZdf9c3He19iJhKTo+Wlu+AHKyCY8Y4mzQGq2yu38uUNLbCPOl JlzCq07vu8FD57wTA5X1hxH0RFcFgsJPJ5f/eFzc4YKuakm4VtMPdH3BIzcshtGVeOPG 4+rQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=9R/6GWzdr3dvwkpfsKfAdH3mdYChZfOBU6GodWvXx7Q=; b=gtt6it2Er87qgDTtx5W2HTwZjFFef8DWrXATIMcRtQWsLEkMqxh1clcnVlpOSAy4wB Hp2P8GolwYuVxdt35jvjwphAoYUDcBZodIr0ZAyzIh0ZrkHntC+5nWlc38xeZSHnHGFQ PeenWKkzKmNBV51M97PkFh8Lul6PWU0DqkGFZDNjVQNIbrukYuWBaD8b6+YPPOg+89gh XP6hRmr7XWtoPOxTsPe98HWZRvqQ1UuqY08ptFZgLDS2gz1t66Bf7mw8ihJuhj0Pxb9a guN6yEojI4634OsItuBPQHcbie/nN8C0f+BTW+gbTkF1dOpjesneqGr8UzrUEBdIQz9b myzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=P4zKFPbz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k8-20020a17090627c800b0078e11e9286csi4749757ejc.195.2022.11.26.06.18.00; Sat, 26 Nov 2022 06:18:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=P4zKFPbz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229583AbiKZORx (ORCPT + 99 others); Sat, 26 Nov 2022 09:17:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229536AbiKZORv (ORCPT ); Sat, 26 Nov 2022 09:17:51 -0500 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75BC020340; Sat, 26 Nov 2022 06:17:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669472269; x=1701008269; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=9dgWdr0fMMMvj7yoBb+AISsyHcjZYsN6cesstQv37Zk=; b=P4zKFPbzKKze27TfI+fLaFB1YKyXsdjKEB2jELB/apvU2PCSBsRtRfjV Nzz6OWKYgB0twMtD2GlHMB+sCkWHSz95dyZO2255wjcpXuJyUxEkBx5mD sSjPvfCHkbY1B4WjhoBqdxACHJHJVs81Vn9cc607rw8swWzrHua1+ZBLH 7c8Wn5njEDifILL9sAnlyxOf3jLoFl2S5pvVvz1N32bCoS2HL1M0l6Dcv ja4xIicvOLTou6g335J64bNIHbuw8E96Ba3h/mEPLx807DsAytVrR+lV+ tCsoKqBl4T2OlbgvATsSq/c9sHSnqYmi2OBfbcylGHnjSXPj99RlkbQQ2 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10543"; a="315755384" X-IronPort-AV: E=Sophos;i="5.96,196,1665471600"; d="scan'208";a="315755384" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Nov 2022 06:17:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10543"; a="971800594" X-IronPort-AV: E=Sophos;i="5.96,196,1665471600"; d="scan'208";a="971800594" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga005.fm.intel.com with ESMTP; 26 Nov 2022 06:17:44 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 33573184; Sat, 26 Nov 2022 16:18:11 +0200 (EET) From: Andy Shevchenko To: Rasmus Villemoes , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org Cc: Alessandro Zummo , Alexandre Belloni , Jean Delvare , Guenter Roeck , Andy Shevchenko Subject: [PATCH v1 5/5] rtc: isl12022: sort header inclusion alphabetically Date: Sat, 26 Nov 2022 16:18:06 +0200 Message-Id: <20221126141806.62205-5-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221126141806.62205-1-andriy.shevchenko@linux.intel.com> References: <20221126141806.62205-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750568590496672462?= X-GMAIL-MSGID: =?utf-8?q?1750568590496672462?= Sort header inclusion alphabetically for better maintenance. Signed-off-by: Andy Shevchenko Acked-by: Rasmus Villemoes --- drivers/rtc/rtc-isl12022.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/rtc/rtc-isl12022.c b/drivers/rtc/rtc-isl12022.c index ee38c5067ea8..e68a79b5e00e 100644 --- a/drivers/rtc/rtc-isl12022.c +++ b/drivers/rtc/rtc-isl12022.c @@ -8,14 +8,14 @@ * by Alessandro Zummo . */ -#include #include -#include -#include -#include #include -#include #include +#include +#include +#include +#include +#include #include