From patchwork Tue Sep 13 08:30:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Sandiford X-Patchwork-Id: 1176 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5044:0:0:0:0:0 with SMTP id h4csp2247255wrt; Tue, 13 Sep 2022 01:30:58 -0700 (PDT) X-Google-Smtp-Source: AA6agR7c/6hfXse8hORM2udpsytcz7+UsZkVa8ZfV7RJchV8N0iTXxF3towX4FY7e/RDQiqXWESV X-Received: by 2002:a17:907:7d9e:b0:771:db66:7b7c with SMTP id oz30-20020a1709077d9e00b00771db667b7cmr18948915ejc.393.1663057858746; Tue, 13 Sep 2022 01:30:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663057858; cv=none; d=google.com; s=arc-20160816; b=g/9XvEopEsFdOUaj6rRD6Aak4OXjmo0kh8fOjyBJcdh3HbL58MFcI/PkxiuSFHmPj2 2tqp718CmNNUl2+HKbqkFNkgAU7+SpP+MugV6N+M0c9RqmbYsWqdZv0UHZT1SDa01FjR MoCoVe3Dt2FXUHLfqPWCLyudB5XWNy8WIbZ4L8KhVTBJLRqpRrvp7691pvuUfXvSzAqd kecK5nBgt/M19WXqo6l3I3dvmb9YobZzZIYEpMaYj6ZvPugPjG4JcTSvdmz/5TZiIHDT iUg/pZQa+/VN+WemCXcJgv0F1A1lX9iXhYmy4zOOMByPRxNjtxzdDs64tMtxs4ur8F5p uO2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:mime-version :user-agent:message-id:date:subject:mail-followup-to:to:dmarc-filter :delivered-to:dkim-signature:dkim-filter; bh=vRK32uHukaR9Qava9b4yt75RAUTRp4j8C4eHRjcGkYs=; b=CRgJrzfmtgMb+iBxnguWqlFjgnwBITUxUSqAi3WgqZvGPe1Fz/J2h9EAYJaWx2Aoc9 5SrryQ4Yg5lqXU6GqSmbn8bL9mib6J/Uv5T5tBUp2n909kZu/JO+ZJ10ExQuTXDV3z0p fMv3lBwxGnqG/XSUhUbOCjj7aY7hEUpFh394RI0VlPilteB4T+1QHAOFPRkSnh0oFrFT qeFIASqqyppSMK05uLR/5As0/3SchIf235xmCCjhbv6+mCc1eS1+Nu3Co9qTgrrrnjS/ HISVw+H69WIA/NQ+uHcuf9v5M5gIOYNM5nnSKwV7BIo+LS/v16gARdOHjumXLg+hCjDe Xm6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=l4y2hxPE; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id q23-20020a50cc97000000b004479e9c138dsi7939699edi.447.2022.09.13.01.30.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Sep 2022 01:30:58 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=l4y2hxPE; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A4FC638515F8 for ; Tue, 13 Sep 2022 08:30:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A4FC638515F8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1663057856; bh=vRK32uHukaR9Qava9b4yt75RAUTRp4j8C4eHRjcGkYs=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=l4y2hxPEj0oKHj+UAko2JahuNM5WTY84bNozFFwNpf7aIDkjzhkSHrC5GKIwB4FpM /crC8rE7osE7YF2UQxp6+p6sqw6QCdFmdO8ZYGm+z7gKX8gbc3XjdoFtbs2cto1eAE 72LYzhQbdLUSOI47Sqe27a8KeK0Qvphg6u/GOdrU= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 14D41385841D for ; Tue, 13 Sep 2022 08:30:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 14D41385841D Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 15EA0D6E for ; Tue, 13 Sep 2022 01:30:14 -0700 (PDT) Received: from localhost (e121540-lin.manchester.arm.com [10.32.98.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 509C03F73B for ; Tue, 13 Sep 2022 01:30:07 -0700 (PDT) To: gcc-patches@gcc.gnu.org Mail-Followup-To: gcc-patches@gcc.gnu.org, richard.sandiford@arm.com Subject: [pushed] aarch64: Disassociate ls64 from simd Date: Tue, 13 Sep 2022 09:30:06 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Spam-Status: No, score=-48.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_NONE, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, KAM_SHORT, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Sandiford via Gcc-patches From: Richard Sandiford Reply-To: Richard Sandiford Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1743842557442874510?= X-GMAIL-MSGID: =?utf-8?q?1743842557442874510?= The ls64-related move expanders and splits required TARGET_SIMD. That isn't necessary, since the 64-byte values are stored entirely in GPRs. (The associated define_insn was already correct.) I wondered about moving the patterns to aarch64.md, but it wasn't clear-cut. Tested on aarch64-linux-gnu & pushed. Richard gcc/ * config/aarch64/aarch64-simd.md (movv8di): Remove TARGET_SIMD condition. Likewise for the related define_split. Tweak formatting. gcc/testsuite/ * gcc.target/aarch64/acle/ls64_asm_2.c: New test. --- gcc/config/aarch64/aarch64-simd.md | 18 +++++++++--------- .../gcc.target/aarch64/acle/ls64_asm_2.c | 9 +++++++++ 2 files changed, 18 insertions(+), 9 deletions(-) create mode 100644 gcc/testsuite/gcc.target/aarch64/acle/ls64_asm_2.c diff --git a/gcc/config/aarch64/aarch64-simd.md b/gcc/config/aarch64/aarch64-simd.md index 587a45d7772..d4662c76a58 100644 --- a/gcc/config/aarch64/aarch64-simd.md +++ b/gcc/config/aarch64/aarch64-simd.md @@ -7087,7 +7087,7 @@ (define_expand "mov" (define_expand "movv8di" [(set (match_operand:V8DI 0 "nonimmediate_operand") (match_operand:V8DI 1 "general_operand"))] - "TARGET_SIMD" + "" { if (can_create_pseudo_p () && MEM_P (operands[0])) operands[1] = force_reg (V8DImode, operands[1]); @@ -7479,7 +7479,7 @@ (define_split (define_split [(set (match_operand:V8DI 0 "nonimmediate_operand") (match_operand:V8DI 1 "general_operand"))] - "TARGET_SIMD && reload_completed" + "reload_completed" [(const_int 0)] { if (register_operand (operands[0], V8DImode) @@ -7489,15 +7489,15 @@ (define_split DONE; } else if ((register_operand (operands[0], V8DImode) - && memory_operand (operands[1], V8DImode)) - || (memory_operand (operands[0], V8DImode) - && register_operand (operands[1], V8DImode))) + && memory_operand (operands[1], V8DImode)) + || (memory_operand (operands[0], V8DImode) + && register_operand (operands[1], V8DImode))) { for (int offset = 0; offset < 64; offset += 16) - emit_move_insn (simplify_gen_subreg (TImode, operands[0], - V8DImode, offset), - simplify_gen_subreg (TImode, operands[1], - V8DImode, offset)); + emit_move_insn (simplify_gen_subreg (TImode, operands[0], + V8DImode, offset), + simplify_gen_subreg (TImode, operands[1], + V8DImode, offset)); DONE; } else diff --git a/gcc/testsuite/gcc.target/aarch64/acle/ls64_asm_2.c b/gcc/testsuite/gcc.target/aarch64/acle/ls64_asm_2.c new file mode 100644 index 00000000000..1b4277180a6 --- /dev/null +++ b/gcc/testsuite/gcc.target/aarch64/acle/ls64_asm_2.c @@ -0,0 +1,9 @@ +/* { dg-do compile } */ +/* { dg-options "-O" } */ + +#pragma GCC target "+ls64+nofp" + +#include "ls64_asm.c" + +/* { dg-final { scan-assembler-times {\tldp\t} 12 } } */ +/* { dg-final { scan-assembler-times {\tstp\t} 4 } } */