From patchwork Fri Nov 25 17:03:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arseniy Krasnov X-Patchwork-Id: 26104 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp4169913wrr; Fri, 25 Nov 2022 09:12:26 -0800 (PST) X-Google-Smtp-Source: AA0mqf72WPZV3ZyDiuU3MywJxFu+1gaZjzqUNWjOLoGpQs/d8IWhu5we30I0trsQ/xnvTqKIhSGn X-Received: by 2002:a17:902:f313:b0:186:8518:6c97 with SMTP id c19-20020a170902f31300b0018685186c97mr32757701ple.94.1669396345828; Fri, 25 Nov 2022 09:12:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669396345; cv=none; d=google.com; s=arc-20160816; b=GpaTLr9nyzMtab7cE27YEzm8qmRHQkvATDjPdyLgno5KLYF7Tb6CRxiJCNovP10R0D BF5y0FmYYqpV0NwYRpx2qPNuJ7MPogHDt+ltzYUM5yT3eNfKDmyJW2Hx34oRKQkoVtvZ ExSwgTg2z8il0XMzee/5uLyonuMzmkX+WYuqif7YkwjzuJ1ykhsHVcfRRsl4jziNrAQM sqhK7hS+o2F3u+DWWV/BI0v4Fpw4BuL9x1LVIz/364DPbNdxdPXhiJmkLb2X5AC9XBOn gTC5ZVERecKHCOVxUf7l5pgeJKZ5XzvMFTuKqUoZ4Kc2iiuhF9KMkDIsOzkGHUDJFLo4 wmqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :content-id:content-language:accept-language:in-reply-to:message-id :date:thread-index:thread-topic:subject:cc:to:from:dkim-signature; bh=hIsvyQKroiddHpaTVR2wY29J7IQ5VqM86kcghxyeuSM=; b=Ag365DiA1ENV80i+koJL5c32UJm9fbZY0NFFrjY+8DvWLv8+SgGvPT/4g4/79i+aTf 0cpvtJ/axXmEnaSJu3G1lXxjdNfzod0AnGeo6h/U3NcVypOyHfBUbv2h3EUAiNUCh5ck ZflawxQfrCABxBzGAnfTs5c/OPRl6qXM6j3akZjt/DXy4UIdVcpWkLsnUwJlI77HFH4H txOmF09i0EZiyfC60wt2PPcGefUtJ8NF4RtTKEObqRwm3Iaju3w2Nvh6G4yhfSDxtb/L iuYVb9QIIhFYf78qga3ej/+YJxncLZMl5GxS0HKRosWS5aJ7GtGaFxnscteUt43xC9CP Y6aw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b=ggMFBYRO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t23-20020a170902b21700b00186f1ccf36bsi4031947plr.45.2022.11.25.09.12.09; Fri, 25 Nov 2022 09:12:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b=ggMFBYRO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229607AbiKYRDN (ORCPT + 99 others); Fri, 25 Nov 2022 12:03:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229902AbiKYRDL (ORCPT ); Fri, 25 Nov 2022 12:03:11 -0500 Received: from mx.sberdevices.ru (mx.sberdevices.ru [45.89.227.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A073A26AC8; Fri, 25 Nov 2022 09:03:09 -0800 (PST) Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mx.sberdevices.ru (Postfix) with ESMTP id 0D0AA5FD0B; Fri, 25 Nov 2022 20:03:08 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1669395788; bh=hIsvyQKroiddHpaTVR2wY29J7IQ5VqM86kcghxyeuSM=; h=From:To:Subject:Date:Message-ID:Content-Type:MIME-Version; b=ggMFBYROTK0lyPJPUDAbCu1X+1e9Jl/HQMoliWUPNJ9lwXOXNhitBph374CaykvuH ZRMqCFhCoB+56aaTIZHL3KF0ePPKNERNkUQWsJM2+OQxn07+H490NxHzR164UTUTv3 EyQP9n2Sz0hl76z4HTBPDhuc3jI7LcaPWgwdaQBCmQiqi0tntWgOOk2olsN0+fsBX+ TXTMSAk0YLxVxPQj9doIYlVU879LRh01P1kYS6gRnui5LnVEGlEN7wUwk6URQ8BiX7 jaKSY1/LyXv/rAPnP9k/SH4nHGBP+seWTTHqlcIB7lPZtpCyMNearrL9nV2N1eKKNV uO0j+weZ1Rv7A== Received: from S-MS-EXCH02.sberdevices.ru (S-MS-EXCH02.sberdevices.ru [172.16.1.5]) by mx.sberdevices.ru (Postfix) with ESMTP; Fri, 25 Nov 2022 20:03:06 +0300 (MSK) From: Arseniy Krasnov To: Stefano Garzarella , "David S. Miller" , "edumazet@google.com" , "Jakub Kicinski" , Paolo Abeni , "kys@microsoft.com" , "haiyangz@microsoft.com" , "wei.liu@kernel.org" , "Dexuan Cui" , Bryan Tan , Vishnu Dasa , Arseniy Krasnov , "Krasnov Arseniy" , Bobby Eshleman , Bobby Eshleman CC: "linux-kernel@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "netdev@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , kernel Subject: [RFC PATCH v2 1/6] vsock: return errors other than -ENOMEM to socket Thread-Topic: [RFC PATCH v2 1/6] vsock: return errors other than -ENOMEM to socket Thread-Index: AQHZAO/JdW+nx2oM60ahOLF9t/m+FQ== Date: Fri, 25 Nov 2022 17:03:06 +0000 Message-ID: <84f44358-dd8b-de8f-b782-7b6f03e0a759@sberdevices.ru> In-Reply-To: <9d96f6c6-1d4f-8197-b3bc-8957124c8933@sberdevices.ru> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.1.12] Content-ID: <816FF44AD1235C4FAB598C4AD43152C1@sberdevices.ru> MIME-Version: 1.0 X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2022/11/25 14:59:00 #20610704 X-KSMG-AntiVirus-Status: Clean, skipped X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750488942681887392?= X-GMAIL-MSGID: =?utf-8?q?1750488942681887392?= From: Bobby Eshleman This removes behaviour, where error code returned from any transport was always switched to ENOMEM. Signed-off-by: Bobby Eshleman Signed-off-by: Arseniy Krasnov --- net/vmw_vsock/af_vsock.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.25.1 diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c index 884eca7f6743..61ddab664c33 100644 --- a/net/vmw_vsock/af_vsock.c +++ b/net/vmw_vsock/af_vsock.c @@ -1862,8 +1862,9 @@ static int vsock_connectible_sendmsg(struct socket *sock, struct msghdr *msg, written = transport->stream_enqueue(vsk, msg, len - total_written); } + if (written < 0) { - err = -ENOMEM; + err = written; goto out_err; } From patchwork Fri Nov 25 17:05:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arseniy Krasnov X-Patchwork-Id: 26103 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp4169380wrr; Fri, 25 Nov 2022 09:11:41 -0800 (PST) X-Google-Smtp-Source: AA0mqf43cwHAfFd2Mw0Tg8QLuAJMRZJ+oNQ1+D9hjhr4xQ2+WA9qGtn7qphg7Hbv6pjt9OOjQ3Fr X-Received: by 2002:a63:d049:0:b0:470:71df:a6c3 with SMTP id s9-20020a63d049000000b0047071dfa6c3mr16481675pgi.447.1669396300800; Fri, 25 Nov 2022 09:11:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669396300; cv=none; d=google.com; s=arc-20160816; b=Jt6vRx5ljbirTkYauwjzivciyJPbKUbbLOybVYlVVA6DqcECBUGws+3rRgxqXAdEfm WuUW/jz/6/T9AQzMwOrxXCvUdOQ7gMMrORZCJupmwVvs0Gqv1fSgrImiSMmZbJojjb5W p07NrUkCvwcZ/TI+6V+SRU9Uu/kuvgjvR98+NiF5p054C25qKrkd7YjxFC38xrYYpJ4Y Wk/zHjhGcr5FOfnhEmKduPjQXzqx8VpCmEm2HLG05sIUqeCYu7nMHHws1xDS4R0RCZQg OgTZE1ZmCR7fYaDMe1YLoVyAdOqnNoaIhKVBNqBdGnj/kZaPTz17Km7nD99u8IyrVXlj JSQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :content-id:content-language:accept-language:in-reply-to:message-id :date:thread-index:thread-topic:subject:cc:to:from:dkim-signature; bh=6S4rZ+E4xI3yfUr3aYJ38SvqnWz2eVSuw2pv6/QpiK8=; b=SOutaNJOuR6f8VDVcrHYpQ6EAkaennG+HGOJJ3dQXbmdMR+wqF8rSkeiAgAA1iv9lL 0AtXuVR5Y0aDX0BZhBP8aQ9KP5rdyST5CP5FEWg1VygbsqhPcW6izcunCpCmJvhOJvs5 ll1+PRiPyTnj44516hKCsd3maGPmFAHkTa95ENrWch+7QFlcNnYoX74yXmL3AfY+DupA T/gKPHK6kxM1Fms1zivMNuI9kVOdQviK3jgF4NpK/Mw88FPYA90HH5FNwzGjJ5VJ96Ia ywu3OrfegJnsIJy/quUBLqyFqtB0CwNAKs8wmu0oN/C6C6iQ96+pr/weGSfKAIl2bgoN cdmA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b=r1T5ehDx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d2-20020a170902cec200b00179f69eae64si4735405plg.620.2022.11.25.09.11.22; Fri, 25 Nov 2022 09:11:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b=r1T5ehDx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230041AbiKYRF7 (ORCPT + 99 others); Fri, 25 Nov 2022 12:05:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230031AbiKYRF5 (ORCPT ); Fri, 25 Nov 2022 12:05:57 -0500 Received: from mx.sberdevices.ru (mx.sberdevices.ru [45.89.227.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C12C64509E; Fri, 25 Nov 2022 09:05:56 -0800 (PST) Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mx.sberdevices.ru (Postfix) with ESMTP id 216685FD0B; Fri, 25 Nov 2022 20:05:55 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1669395955; bh=6S4rZ+E4xI3yfUr3aYJ38SvqnWz2eVSuw2pv6/QpiK8=; h=From:To:Subject:Date:Message-ID:Content-Type:MIME-Version; b=r1T5ehDxv8YVZlA5nOFJ9LzIPKkiUXT6333nm/rTdPH0LX6W+e6PF1fd7LkHxMrMr XFDB3pYhv3VmidVeaO6vnGnLNUqbreGVaj2XORwqIUfzKzPzCIX/RnymjWD33ItOVA WmwDxpNNuFUQ+Jsz/10mza82fn4fAcoTsC1WxNO2e+hOhB+aJIuqndSzM6utWc5ISN SofdJbAVTmrMV4JarvyPSPMN+/cyTbySixH3NXETMZMxqM8alurRANZMLadUE4aVGl Ti82ieK4EGFcnvg0OHOcRNKqGgVx4lMZmsWJYz9uxGw/+6zg5MCBcXrx0FEd/57LRM it8WNLdzEEn3Q== Received: from S-MS-EXCH01.sberdevices.ru (S-MS-EXCH01.sberdevices.ru [172.16.1.4]) by mx.sberdevices.ru (Postfix) with ESMTP; Fri, 25 Nov 2022 20:05:54 +0300 (MSK) From: Arseniy Krasnov To: Stefano Garzarella , "David S. Miller" , "edumazet@google.com" , "Jakub Kicinski" , Paolo Abeni , "kys@microsoft.com" , "haiyangz@microsoft.com" , "wei.liu@kernel.org" , "Dexuan Cui" , Bryan Tan , Vishnu Dasa , Arseniy Krasnov , "Krasnov Arseniy" , Bobby Eshleman , Bobby Eshleman CC: "linux-kernel@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "netdev@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , kernel Subject: [RFC PATCH v2 2/6] hv_sock: always return ENOMEM in case of error Thread-Topic: [RFC PATCH v2 2/6] hv_sock: always return ENOMEM in case of error Thread-Index: AQHZAPAtTYc9d9ztWkmT9FbeEy5mXA== Date: Fri, 25 Nov 2022 17:05:53 +0000 Message-ID: In-Reply-To: <9d96f6c6-1d4f-8197-b3bc-8957124c8933@sberdevices.ru> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.1.12] Content-ID: <77BCA4140E868A459BF33144BC93E2B5@sberdevices.ru> MIME-Version: 1.0 X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2022/11/25 14:59:00 #20610704 X-KSMG-AntiVirus-Status: Clean, skipped X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750488895154439489?= X-GMAIL-MSGID: =?utf-8?q?1750488895154439489?= From: Bobby Eshleman This saves original behaviour from af_vsock.c - switch any error code returned from transport layer to ENOMEM. Signed-off-by: Bobby Eshleman Signed-off-by: Arseniy Krasnov --- net/vmw_vsock/hyperv_transport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1 diff --git a/net/vmw_vsock/hyperv_transport.c b/net/vmw_vsock/hyperv_transport.c index 59c3e2697069..fbbe55133da2 100644 --- a/net/vmw_vsock/hyperv_transport.c +++ b/net/vmw_vsock/hyperv_transport.c @@ -687,7 +687,7 @@ static ssize_t hvs_stream_enqueue(struct vsock_sock *vsk, struct msghdr *msg, if (bytes_written) ret = bytes_written; kfree(send_buf); - return ret; + return ret < 0 ? -ENOMEM : ret; } static s64 hvs_stream_has_data(struct vsock_sock *vsk) From patchwork Fri Nov 25 17:08:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arseniy Krasnov X-Patchwork-Id: 26105 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp4171903wrr; Fri, 25 Nov 2022 09:15:25 -0800 (PST) X-Google-Smtp-Source: AA0mqf5q7vpGnvsI5HXnvrbgJxwdJGda1mAj6jmcJc16Ah4lYM72ieSO9iS3MnknxaXhWwC4PWXd X-Received: by 2002:a63:1e5b:0:b0:477:3c62:49ba with SMTP id p27-20020a631e5b000000b004773c6249bamr16772553pgm.446.1669396524657; Fri, 25 Nov 2022 09:15:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669396524; cv=none; d=google.com; s=arc-20160816; b=ksYRfMXDdhFI7Aa6+ztfGz+pJQlMRt0l0t7ZxDsRDGEYyHpG+td73ze+bfi1rJacwt nXZA1mB45pXV2sz7ZoSq8bZ7EYVGRGtx04Sa3MPe84dRTqDMWqmN1fC1O+MnVc2XHRNH YWMzVEGO2Ca7/gCapC1C14dELSEnMBC2hr2yE7RJGjbemH4fyEF5RncYHqsGkTciBmAI D3DdmczR4kUUMuz1+07sW/4ysvRWWzQHw5kCTjxnVGj7SLO1bLm2AeR90EjjFQcAE1O1 mryTmHuC/hPS61wo+9WSKJFdwu39c2MBlNTrjsNrmMwo54hybzaUNkjfieWS92TYJP4M Czlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :content-id:content-language:accept-language:in-reply-to:message-id :date:thread-index:thread-topic:subject:cc:to:from:dkim-signature; bh=KXyYR4VF9sCYOsS3NPi6MuVELIEouxGMJZ8BpfDIAZo=; b=r0xtBw7MSDyrCAL9/dnbQl/cbgeIyj2yUFYoBEDlxF3WeCi2RBCzJ21tRkAfoeaQdZ +fYegH6GrY5CaK+bEO3AOnaJl6i8uYnY7629u3gK8PEQzoaDQEy93KlTx/IRDw07V0Jl e1H06/csR3aRu+09sDnfu/f1N+d1DorARhFzSMdya41Cny0i+XU3F6D6i9VWtCTwvqge LiHT7n4Zjny+1Lky4NYezDrbunW5YxDsahuEySaFWUsWe2J7lGboA2Vl0Fj3YUycjJNB AjXTGcdvjtALhcYETpezud3RImsnverB+9BObbUKxHXrvxACUpwfciFdYSVlIYH7bi5i vy0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b=cyQDFrMQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s8-20020a632c08000000b004772bd99e54si5103276pgs.32.2022.11.25.09.15.09; Fri, 25 Nov 2022 09:15:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b=cyQDFrMQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229687AbiKYRIN (ORCPT + 99 others); Fri, 25 Nov 2022 12:08:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229518AbiKYRIM (ORCPT ); Fri, 25 Nov 2022 12:08:12 -0500 Received: from mx.sberdevices.ru (mx.sberdevices.ru [45.89.227.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0852165A8; Fri, 25 Nov 2022 09:08:09 -0800 (PST) Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mx.sberdevices.ru (Postfix) with ESMTP id 1E46B5FD0C; Fri, 25 Nov 2022 20:08:08 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1669396088; bh=KXyYR4VF9sCYOsS3NPi6MuVELIEouxGMJZ8BpfDIAZo=; h=From:To:Subject:Date:Message-ID:Content-Type:MIME-Version; b=cyQDFrMQ8vzelcVlsjJps0cLRUAWlLytI/uP3q6P9R+5SdbJCbaQvZ9W5CFsZinZG oXPE+FxBfkfA98sqOGxND2adWai2xXOoqJxype2JDn4RvKQ0WGTSJa1cf+OVxwXPET M7YLm1wFzcDzkew3sNVRvf+RyL+RAbqVYmWFM0MSMhEvqEOMrde3dVBKl4Tf27CLQo fAXA2NWFMrHZ+0U1q5MHQAtZHnXADT3RRDanIbKJyB8kssS7BzHVmKps4/A8tK+Lrp lHgpvnTbrkVVYuoDx1KVWlDcinJwCV5u/awtMa2LCkStr7Egyuas+d0Azb3kQchsPn ddqI560AwAOHQ== Received: from S-MS-EXCH01.sberdevices.ru (S-MS-EXCH01.sberdevices.ru [172.16.1.4]) by mx.sberdevices.ru (Postfix) with ESMTP; Fri, 25 Nov 2022 20:08:06 +0300 (MSK) From: Arseniy Krasnov To: Stefano Garzarella , "David S. Miller" , "edumazet@google.com" , "Jakub Kicinski" , Paolo Abeni , "kys@microsoft.com" , "haiyangz@microsoft.com" , "wei.liu@kernel.org" , "Dexuan Cui" , Bryan Tan , Vishnu Dasa , Arseniy Krasnov , "Krasnov Arseniy" , Bobby Eshleman , Bobby Eshleman CC: "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "linux-hyperv@vger.kernel.org" , kernel Subject: [RFC PATCH v2 3/6] vsock/vmci: always return ENOMEM in case of error Thread-Topic: [RFC PATCH v2 3/6] vsock/vmci: always return ENOMEM in case of error Thread-Index: AQHZAPB8vpTNk9Cz/UiwVhA3FAXi7Q== Date: Fri, 25 Nov 2022 17:08:06 +0000 Message-ID: <675b1f93-dc07-0a70-0622-c3fc6236c8bb@sberdevices.ru> In-Reply-To: <9d96f6c6-1d4f-8197-b3bc-8957124c8933@sberdevices.ru> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.1.12] Content-ID: MIME-Version: 1.0 X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2022/11/25 14:59:00 #20610704 X-KSMG-AntiVirus-Status: Clean, skipped X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750489130535125962?= X-GMAIL-MSGID: =?utf-8?q?1750489130535125962?= From: Bobby Eshleman This saves original behaviour from af_vsock.c - switch any error code returned from transport layer to ENOMEM. Signed-off-by: Bobby Eshleman Signed-off-by: Arseniy Krasnov --- net/vmw_vsock/vmci_transport.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) -- 2.25.1 diff --git a/net/vmw_vsock/vmci_transport.c b/net/vmw_vsock/vmci_transport.c index 842c94286d31..289a36a203a2 100644 --- a/net/vmw_vsock/vmci_transport.c +++ b/net/vmw_vsock/vmci_transport.c @@ -1838,7 +1838,14 @@ static ssize_t vmci_transport_stream_enqueue( struct msghdr *msg, size_t len) { - return vmci_qpair_enquev(vmci_trans(vsk)->qpair, msg, len, 0); + int err; + + err = vmci_qpair_enquev(vmci_trans(vsk)->qpair, msg, len, 0); + + if (err < 0) + err = -ENOMEM; + + return err; } static s64 vmci_transport_stream_has_data(struct vsock_sock *vsk) From patchwork Fri Nov 25 17:10:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arseniy Krasnov X-Patchwork-Id: 26106 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp4172230wrr; Fri, 25 Nov 2022 09:15:52 -0800 (PST) X-Google-Smtp-Source: AA0mqf7ksPM84xfZdXPo8p7TCNvu85dOfJ/5xhf3DT5Kj7J357U3ywy5X88dX3nX/9jtZH3VBE4M X-Received: by 2002:a63:e44b:0:b0:476:f69c:2304 with SMTP id i11-20020a63e44b000000b00476f69c2304mr36760141pgk.77.1669396551812; Fri, 25 Nov 2022 09:15:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669396551; cv=none; d=google.com; s=arc-20160816; b=Dq04zn8CvzHTfOKozVnmiD6XJ3lk/a/nEGUgQJdq6Qe64wlmtC380SW36DRzyMrZVu /2HAGbl9WVjyKqcMnZbl1SbHAPeIAuVw3JtPKvcPxDU1BoPYiqyzEtIv6mVByqQsiJKI cxaU6RF2zRReDHDAZbDEBtZb8xa8SeL4hJC+qeuAVU1UXxRX5zEoJ13bhloMl/xjz3wh fULUWqJ+o8erli0K7lvedUzVWOgLrGCWUhSrEyeGbAOHxj7TfJpddmV063JNBFVSexgo MODe7CZgl11N0msJDvU9SUjUnhYWOHK9MLjDdtMN72AOXh2LMrAHX3smZOQhhQKUbrRA T62w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :content-id:content-language:accept-language:in-reply-to:message-id :date:thread-index:thread-topic:subject:cc:to:from:dkim-signature; bh=TbfqY0U08CBmZ07Mj9iWXW5NhW/QFZHOkT6OdCmAJ2s=; b=P48se2n2jDJlW3ytBp/dqyhuzifBUco13oAJqUqcqAqBgrS6N9NjbvUIpTAVR5jXgp UfOL+5lq3EQJILm4Xw0wUzJ1PQMrbfBXAa8JWEsHrMwFWEjUfB2TqsnkovZzHHPiGXL8 Pj9b8+o9KOIQCLowM3iGYkgzGIDQ/IbmdMp+YO9t6CiiTOfuPdscejHnqsG3WAyPIgp3 SSAkvOMEwXNJlL7Uky5MEDB/EP15+mI+wm9b+JdTY/9/gXbxDLtAn3akJ8fCUY0R2+Qf jhacSagWgApHoHO5W9NePtNwDaSr2EDh2C+haowdCQJ0lXKWWmDs8T6vaMZjzzQmTd8/ dhXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b=HYfVgMfN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u7-20020a17090341c700b00176d5b20ebesi4994263ple.355.2022.11.25.09.15.38; Fri, 25 Nov 2022 09:15:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b=HYfVgMfN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229894AbiKYRKn (ORCPT + 99 others); Fri, 25 Nov 2022 12:10:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229572AbiKYRKk (ORCPT ); Fri, 25 Nov 2022 12:10:40 -0500 Received: from mx.sberdevices.ru (mx.sberdevices.ru [45.89.227.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 757A41D335; Fri, 25 Nov 2022 09:10:38 -0800 (PST) Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mx.sberdevices.ru (Postfix) with ESMTP id CE3705FD0B; Fri, 25 Nov 2022 20:10:36 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1669396236; bh=TbfqY0U08CBmZ07Mj9iWXW5NhW/QFZHOkT6OdCmAJ2s=; h=From:To:Subject:Date:Message-ID:Content-Type:MIME-Version; b=HYfVgMfNEwn9QmE88aX5wZyP4W8zIRyxTlCAKtmpsTxfH8yEPDCM6GPPA+o7zibjA YtQ5fjQ2gQlSVMSqZAeyyFPnGrwhcCSgnLcNTin0Fr2EMTLgCi+b+yfDT/9D5xQmWt +NdBkw94pSpzGjPQ8PFaKLLS8R8E8/f8kPH/suMMheJ36BmwuqNufKLTvtZQkwQvCf ZWnbGI9HIw0EcJ7fVQNdsMZQ5j1elr8KZ+b+jsu5gKW4eusXmIAqyhz2R3LClnPCQm fkDKdKrv1FfXURUcw6G+5QysKXOE0oFlL+kyLaQkMfLutDhwHA2pfn6XBP2BUI8C6N 8CvmaBiR+qebw== Received: from S-MS-EXCH01.sberdevices.ru (S-MS-EXCH01.sberdevices.ru [172.16.1.4]) by mx.sberdevices.ru (Postfix) with ESMTP; Fri, 25 Nov 2022 20:10:35 +0300 (MSK) From: Arseniy Krasnov To: Stefano Garzarella , "David S. Miller" , "edumazet@google.com" , "Jakub Kicinski" , Paolo Abeni , "kys@microsoft.com" , "haiyangz@microsoft.com" , "wei.liu@kernel.org" , "Dexuan Cui" , Bryan Tan , Vishnu Dasa , Arseniy Krasnov , "Krasnov Arseniy" , Bobby Eshleman , Bobby Eshleman CC: "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "linux-hyperv@vger.kernel.org" , kernel Subject: [RFC PATCH v2 4/6] test/vsock: rework message bounds test Thread-Topic: [RFC PATCH v2 4/6] test/vsock: rework message bounds test Thread-Index: AQHZAPDVjHyum7GlNEe8zXRCLJKxfg== Date: Fri, 25 Nov 2022 17:10:35 +0000 Message-ID: In-Reply-To: <9d96f6c6-1d4f-8197-b3bc-8957124c8933@sberdevices.ru> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.1.12] Content-ID: MIME-Version: 1.0 X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2022/11/25 14:59:00 #20610704 X-KSMG-AntiVirus-Status: Clean, skipped X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750489158648309432?= X-GMAIL-MSGID: =?utf-8?q?1750489158648309432?= This updates message bound test making it more complex. Instead of sending 1 bytes messages with one MSG_EOR bit, it sends messages of random length(one half of messages are smaller than page size, second half are bigger) with random number of MSG_EOR bits set. Receiver also don't know total number of messages. Signed-off-by: Arseniy Krasnov --- tools/testing/vsock/control.c | 28 +++++++ tools/testing/vsock/control.h | 2 + tools/testing/vsock/util.c | 13 ++++ tools/testing/vsock/util.h | 1 + tools/testing/vsock/vsock_test.c | 124 +++++++++++++++++++++++++++---- 5 files changed, 155 insertions(+), 13 deletions(-) -- 2.25.1 diff --git a/tools/testing/vsock/control.c b/tools/testing/vsock/control.c index 4874872fc5a3..d2deb4b15b94 100644 --- a/tools/testing/vsock/control.c +++ b/tools/testing/vsock/control.c @@ -141,6 +141,34 @@ void control_writeln(const char *str) timeout_end(); } +void control_writeulong(unsigned long value) +{ + char str[32]; + + if (snprintf(str, sizeof(str), "%lu", value) >= sizeof(str)) { + perror("snprintf"); + exit(EXIT_FAILURE); + } + + control_writeln(str); +} + +unsigned long control_readulong(void) +{ + unsigned long value; + char *str; + + str = control_readln(); + + if (!str) + exit(EXIT_FAILURE); + + value = strtoul(str, NULL, 10); + free(str); + + return value; +} + /* Return the next line from the control socket (without the trailing newline). * * The program terminates if a timeout occurs. diff --git a/tools/testing/vsock/control.h b/tools/testing/vsock/control.h index 51814b4f9ac1..c1f77fdb2c7a 100644 --- a/tools/testing/vsock/control.h +++ b/tools/testing/vsock/control.h @@ -9,7 +9,9 @@ void control_init(const char *control_host, const char *control_port, void control_cleanup(void); void control_writeln(const char *str); char *control_readln(void); +unsigned long control_readulong(void); void control_expectln(const char *str); bool control_cmpln(char *line, const char *str, bool fail); +void control_writeulong(unsigned long value); #endif /* CONTROL_H */ diff --git a/tools/testing/vsock/util.c b/tools/testing/vsock/util.c index 2acbb7703c6a..01b636d3039a 100644 --- a/tools/testing/vsock/util.c +++ b/tools/testing/vsock/util.c @@ -395,3 +395,16 @@ void skip_test(struct test_case *test_cases, size_t test_cases_len, test_cases[test_id].skip = true; } + +unsigned long hash_djb2(const void *data, size_t len) +{ + unsigned long hash = 5381; + int i = 0; + + while (i < len) { + hash = ((hash << 5) + hash) + ((unsigned char *)data)[i]; + i++; + } + + return hash; +} diff --git a/tools/testing/vsock/util.h b/tools/testing/vsock/util.h index a3375ad2fb7f..fb99208a95ea 100644 --- a/tools/testing/vsock/util.h +++ b/tools/testing/vsock/util.h @@ -49,4 +49,5 @@ void run_tests(const struct test_case *test_cases, void list_tests(const struct test_case *test_cases); void skip_test(struct test_case *test_cases, size_t test_cases_len, const char *test_id_str); +unsigned long hash_djb2(const void *data, size_t len); #endif /* UTIL_H */ diff --git a/tools/testing/vsock/vsock_test.c b/tools/testing/vsock/vsock_test.c index bb6d691cb30d..12ef0cca6f93 100644 --- a/tools/testing/vsock/vsock_test.c +++ b/tools/testing/vsock/vsock_test.c @@ -284,10 +284,14 @@ static void test_stream_msg_peek_server(const struct test_opts *opts) close(fd); } -#define MESSAGES_CNT 7 -#define MSG_EOR_IDX (MESSAGES_CNT / 2) +#define SOCK_BUF_SIZE (2 * 1024 * 1024) +#define MAX_MSG_SIZE (32 * 1024) + static void test_seqpacket_msg_bounds_client(const struct test_opts *opts) { + unsigned long curr_hash; + int page_size; + int msg_count; int fd; fd = vsock_seqpacket_connect(opts->peer_cid, 1234); @@ -296,18 +300,78 @@ static void test_seqpacket_msg_bounds_client(const struct test_opts *opts) exit(EXIT_FAILURE); } - /* Send several messages, one with MSG_EOR flag */ - for (int i = 0; i < MESSAGES_CNT; i++) - send_byte(fd, 1, (i == MSG_EOR_IDX) ? MSG_EOR : 0); + /* Wait, until receiver sets buffer size. */ + control_expectln("SRVREADY"); + + curr_hash = 0; + page_size = getpagesize(); + msg_count = SOCK_BUF_SIZE / MAX_MSG_SIZE; + + for (int i = 0; i < msg_count; i++) { + ssize_t send_size; + size_t buf_size; + int flags; + void *buf; + + /* Use "small" buffers and "big" buffers. */ + if (i & 1) + buf_size = page_size + + (rand() % (MAX_MSG_SIZE - page_size)); + else + buf_size = 1 + (rand() % page_size); + + buf = malloc(buf_size); + + if (!buf) { + perror("malloc"); + exit(EXIT_FAILURE); + } + + /* Set at least one MSG_EOR + some random. */ + if (i == (msg_count / 2) || (rand() & 1)) { + flags = MSG_EOR; + curr_hash++; + } else { + flags = 0; + } + + send_size = send(fd, buf, buf_size, flags); + + if (send_size < 0) { + perror("send"); + exit(EXIT_FAILURE); + } + + if (send_size != buf_size) { + fprintf(stderr, "Invalid send size\n"); + exit(EXIT_FAILURE); + } + + /* + * Hash sum is computed at both client and server in + * the same way: H = hash(H + 'message length'). Idea + * is simple: such hash "accumulates" length and order + * of every sent/received message. After data exchange, + * both sums are compared using control socket, and if + * message bounds wasn't broken - two values must be + * equal. + */ + curr_hash += send_size; + curr_hash = hash_djb2(&curr_hash, sizeof(curr_hash)); + } control_writeln("SENDDONE"); + control_writeulong(curr_hash); close(fd); } static void test_seqpacket_msg_bounds_server(const struct test_opts *opts) { + unsigned long sock_buf_size; + unsigned long remote_hash; + unsigned long curr_hash; int fd; - char buf[16]; + char buf[MAX_MSG_SIZE]; struct msghdr msg = {0}; struct iovec iov = {0}; @@ -317,25 +381,58 @@ static void test_seqpacket_msg_bounds_server(const struct test_opts *opts) exit(EXIT_FAILURE); } + sock_buf_size = SOCK_BUF_SIZE; + + if (setsockopt(fd, AF_VSOCK, SO_VM_SOCKETS_BUFFER_MAX_SIZE, + &sock_buf_size, sizeof(sock_buf_size))) { + perror("getsockopt"); + exit(EXIT_FAILURE); + } + + if (setsockopt(fd, AF_VSOCK, SO_VM_SOCKETS_BUFFER_SIZE, + &sock_buf_size, sizeof(sock_buf_size))) { + perror("getsockopt"); + exit(EXIT_FAILURE); + } + + /* Ready to receive data. */ + control_writeln("SRVREADY"); + /* Wait, until peer sends whole data. */ control_expectln("SENDDONE"); iov.iov_base = buf; iov.iov_len = sizeof(buf); msg.msg_iov = &iov; msg.msg_iovlen = 1; - for (int i = 0; i < MESSAGES_CNT; i++) { - if (recvmsg(fd, &msg, 0) != 1) { - perror("message bound violated"); - exit(EXIT_FAILURE); - } + curr_hash = 0; - if ((i == MSG_EOR_IDX) ^ !!(msg.msg_flags & MSG_EOR)) { - perror("MSG_EOR"); + while (1) { + ssize_t recv_size; + + recv_size = recvmsg(fd, &msg, 0); + + if (!recv_size) + break; + + if (recv_size < 0) { + perror("recvmsg"); exit(EXIT_FAILURE); } + + if (msg.msg_flags & MSG_EOR) + curr_hash++; + + curr_hash += recv_size; + curr_hash = hash_djb2(&curr_hash, sizeof(curr_hash)); } close(fd); + remote_hash = control_readulong(); + + if (curr_hash != remote_hash) { + fprintf(stderr, "Message bounds broken\n"); + exit(EXIT_FAILURE); + } } #define MESSAGE_TRUNC_SZ 32 @@ -837,6 +934,7 @@ int main(int argc, char **argv) .peer_cid = VMADDR_CID_ANY, }; + srand(time(NULL)); init_signals(); for (;;) { From patchwork Fri Nov 25 17:13:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arseniy Krasnov X-Patchwork-Id: 26107 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp4172722wrr; Fri, 25 Nov 2022 09:16:36 -0800 (PST) X-Google-Smtp-Source: AA0mqf4rJdjztTHADjhY4bDa9HkCYndyJAnAhqn2a67jo02sc1lk711EDwE2nx7hR5khZ9F9QKHA X-Received: by 2002:a17:90b:3d0d:b0:1fd:5b5d:f09d with SMTP id pt13-20020a17090b3d0d00b001fd5b5df09dmr42286407pjb.69.1669396595752; Fri, 25 Nov 2022 09:16:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669396595; cv=none; d=google.com; s=arc-20160816; b=p8qvjf55B5eoooS0NP1V+6Puk2wiUOaB7sBWDDBD3FJRY4/EepKhfRGSJXYbFVXm/W PBItYmC3DVe5lJQdZkVPqu1HbGLU3ihTp8MycoWscss2RlC26l7duTf28jvN8fRgsNK8 feOedRpdeojylAthH4pS7MmQHnXbnM6/VeRFSyRD3zyfbUcioCxtq+BqSSKX3MZ4slto SMt22AjQSs88W7Z04j/a6XCZpHS2z9QoSeIxbTG/98jybkRYnZptB+iGVNsgQbHd0E2h M+qUnCa+3NFXpqQ0ea9PEUVHUweiuN4fIYZBJ+lBK3WPhptSZnUA2gl8MTICkKkynUw6 5UfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :content-id:content-language:accept-language:in-reply-to:message-id :date:thread-index:thread-topic:subject:cc:to:from:dkim-signature; bh=9qv6bo2BORlnQt0hKuzAdwsTbynOYqadbQRmTr/uw78=; b=uWWHWneklu7OuIKnlez8WrTVxuCGI3mJObKXvd8XSsoZbilKpztYRZE7HNXq8GZerO bQS9cgFViAGdIVpJabXhyzDZLfTLxmRYHJkyKNUCByDFodwEtbsLBH0sne65JntBFhUY L3E8DCliutzv5Zh4EpPbFMA149HBOGhAIRakZwXCyVErUqfqTPsJqMWt5iCTDBvWHou9 5AeDmnLe0SzDKLmcZZRsn3RqvDOQXQ0n0+PBJvLAfLnZDRnNX6yH0w2bnRCv6xvRHFGh 7QV2qG0jd0QSCcKr8SVsiVzG3DQA9VFWUU5CG7kJWgonplaccBpNjtiBxlRnec1/onsp 7M8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b=XAN887WP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d14-20020a63a70e000000b00457f4e8e21esi4527540pgf.731.2022.11.25.09.16.21; Fri, 25 Nov 2022 09:16:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b=XAN887WP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229930AbiKYRNM (ORCPT + 99 others); Fri, 25 Nov 2022 12:13:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229570AbiKYRNK (ORCPT ); Fri, 25 Nov 2022 12:13:10 -0500 Received: from mx.sberdevices.ru (mx.sberdevices.ru [45.89.227.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7EB0C3F073; Fri, 25 Nov 2022 09:13:09 -0800 (PST) Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mx.sberdevices.ru (Postfix) with ESMTP id E2CBF5FD0B; Fri, 25 Nov 2022 20:13:07 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1669396387; bh=9qv6bo2BORlnQt0hKuzAdwsTbynOYqadbQRmTr/uw78=; h=From:To:Subject:Date:Message-ID:Content-Type:MIME-Version; b=XAN887WPNw/WZTQECWA0tJS6ZC8TreX2FcfssiPfd65oGed1tp5Igaou7ePYJOZUv g+Bms8P1KaCIJaX7pzu4r0rlPpTNJzxDPi+djic0BUD7Y1euoCG+Q8KO+meqLVieAS kdmlYDi8KO9NgwH7ieqzLJCfm3j7XXY9Hylj5d79dw7zD3cZfX4eCLWVzO9GJR9E1/ ENzt7Wi3ScAGVRuciHB+vvIighb1Zb9wuajme0xjA6ni4Lmn8BGuT7UgI99EhP2vz7 seT0VkT1HZkHZ722u2kNNULrx+wUTOfklZ+2uZGej5SY6mgvwfRTb87aSgUDlwQmGt iHnL8LhE6CE6g== Received: from S-MS-EXCH01.sberdevices.ru (S-MS-EXCH01.sberdevices.ru [172.16.1.4]) by mx.sberdevices.ru (Postfix) with ESMTP; Fri, 25 Nov 2022 20:13:06 +0300 (MSK) From: Arseniy Krasnov To: Stefano Garzarella , "David S. Miller" , "edumazet@google.com" , "Jakub Kicinski" , Paolo Abeni , "kys@microsoft.com" , "haiyangz@microsoft.com" , "wei.liu@kernel.org" , "Dexuan Cui" , Bryan Tan , Vishnu Dasa , Arseniy Krasnov , "Krasnov Arseniy" , Bobby Eshleman , Bobby Eshleman CC: "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "linux-hyperv@vger.kernel.org" , kernel Subject: [RFC PATCH v2 5/6] test/vsock: add big message test Thread-Topic: [RFC PATCH v2 5/6] test/vsock: add big message test Thread-Index: AQHZAPEvcSVoxBim/0CJACwJhEWdyw== Date: Fri, 25 Nov 2022 17:13:06 +0000 Message-ID: <2634ad7f-b462-5c69-8aa1-2f200a6beb20@sberdevices.ru> In-Reply-To: <9d96f6c6-1d4f-8197-b3bc-8957124c8933@sberdevices.ru> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.1.12] Content-ID: <3B4C91B9914E1D4FA437F630D9DDFF05@sberdevices.ru> MIME-Version: 1.0 X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2022/11/25 14:59:00 #20610704 X-KSMG-AntiVirus-Status: Clean, skipped X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750489205176940257?= X-GMAIL-MSGID: =?utf-8?q?1750489205176940257?= This adds test for sending message, bigger than peer's buffer size. For SOCK_SEQPACKET socket it must fail, as this type of socket has message size limit. Signed-off-by: Arseniy Krasnov Reviewed-by: Stefano Garzarella --- tools/testing/vsock/vsock_test.c | 69 ++++++++++++++++++++++++++++++++ 1 file changed, 69 insertions(+) -- 2.25.1 diff --git a/tools/testing/vsock/vsock_test.c b/tools/testing/vsock/vsock_test.c index 12ef0cca6f93..a8e43424fb32 100644 --- a/tools/testing/vsock/vsock_test.c +++ b/tools/testing/vsock/vsock_test.c @@ -569,6 +569,70 @@ static void test_seqpacket_timeout_server(const struct test_opts *opts) close(fd); } +static void test_seqpacket_bigmsg_client(const struct test_opts *opts) +{ + unsigned long sock_buf_size; + ssize_t send_size; + socklen_t len; + void *data; + int fd; + + len = sizeof(sock_buf_size); + + fd = vsock_seqpacket_connect(opts->peer_cid, 1234); + if (fd < 0) { + perror("connect"); + exit(EXIT_FAILURE); + } + + if (getsockopt(fd, AF_VSOCK, SO_VM_SOCKETS_BUFFER_SIZE, + &sock_buf_size, &len)) { + perror("getsockopt"); + exit(EXIT_FAILURE); + } + + sock_buf_size++; + + data = malloc(sock_buf_size); + if (!data) { + perror("malloc"); + exit(EXIT_FAILURE); + } + + send_size = send(fd, data, sock_buf_size, 0); + if (send_size != -1) { + fprintf(stderr, "expected 'send(2)' failure, got %zi\n", + send_size); + exit(EXIT_FAILURE); + } + + if (errno != EMSGSIZE) { + fprintf(stderr, "expected EMSGSIZE in 'errno', got %i\n", + errno); + exit(EXIT_FAILURE); + } + + control_writeln("CLISENT"); + + free(data); + close(fd); +} + +static void test_seqpacket_bigmsg_server(const struct test_opts *opts) +{ + int fd; + + fd = vsock_seqpacket_accept(VMADDR_CID_ANY, 1234, NULL); + if (fd < 0) { + perror("accept"); + exit(EXIT_FAILURE); + } + + control_expectln("CLISENT"); + + close(fd); +} + #define BUF_PATTERN_1 'a' #define BUF_PATTERN_2 'b' @@ -851,6 +915,11 @@ static struct test_case test_cases[] = { .run_client = test_stream_poll_rcvlowat_client, .run_server = test_stream_poll_rcvlowat_server, }, + { + .name = "SOCK_SEQPACKET big message", + .run_client = test_seqpacket_bigmsg_client, + .run_server = test_seqpacket_bigmsg_server, + }, {}, }; From patchwork Fri Nov 25 17:15:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arseniy Krasnov X-Patchwork-Id: 26108 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp4172804wrr; Fri, 25 Nov 2022 09:16:42 -0800 (PST) X-Google-Smtp-Source: AA0mqf74+pFpaY2vTMwdUCYueLEUG8t6gjomyEXZlEGU03whfhvMcYIipjRjGTpuB5/rJJyd1IdD X-Received: by 2002:a63:f91a:0:b0:477:8109:ccea with SMTP id h26-20020a63f91a000000b004778109cceamr20286015pgi.376.1669396602391; Fri, 25 Nov 2022 09:16:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669396602; cv=none; d=google.com; s=arc-20160816; b=iK7EjDLb/ts+Km0/vv+usVWQjvN+KME/oYQlLu3sTdO4r1J7T1l26pwRxdEhye8Rtu sY0iXultil+8MnJMzl34A2IF2mIiZBxmSA2EI1ZUJJ7C7RnAj+S9oCJEoenR2N7nInxi MB/4/UpapJ87Hd8Z+iHKzHfu0uiDOtS2jjOiHVnNSqtvoWUzAh67NQFHymJ43F8YY09K ucV2hoy8tyhej4OdQWN3LLmiiYDBHx18lWeg+9t09Beq+2UJw0yXp8XP7yj/h3Wrojm9 TtzCtPw7ajj5QUZlfhEC5/vhnsaRrKWeXvovmq94L4RuRo5MM6sT0xBBSOrYEUZtSHR0 uAqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :content-id:content-language:accept-language:in-reply-to:message-id :date:thread-index:thread-topic:subject:cc:to:from:dkim-signature; bh=ql77uGu/Palxfhx5tOIxZcAYn3XCSN8xPcKIUYuh8t8=; b=ebUhgbEB4V2k9WBnsQI08XDEtD3g1boO+pqhukH76zWlbqZlAymbQrhdHObr1bUHlI 1e99IDkl+JgUrBp/BBRIiYUps7pGczMmIw2SexqKVHhKMzk39KkS6WDJwPuG2pmTzgAr 3Hc8lpTyQ04Loed5gyZDX3UVhELfsFndkohFaiMcQqMkJyYgnNMZimwbQNV/IqjRwKCL QDw7UJRPX/qHa/ziDgAINwA3o84l3GsgFffFgCmzCR2r2f46FfmrFQM5tzYw9vcnpqpU jnzlwnrWzRmEjE6SDO1LHNPxHTfWNQompqEtr+SLVkY63S7E5YV+lLr43xRpNRt+ckTa 6ZWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b=FDBiDEeO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c7-20020a656187000000b0043aebb63fc9si4475707pgv.732.2022.11.25.09.16.29; Fri, 25 Nov 2022 09:16:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b=FDBiDEeO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230026AbiKYRPP (ORCPT + 99 others); Fri, 25 Nov 2022 12:15:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229487AbiKYRPM (ORCPT ); Fri, 25 Nov 2022 12:15:12 -0500 Received: from mx.sberdevices.ru (mx.sberdevices.ru [45.89.227.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E702651325; Fri, 25 Nov 2022 09:15:10 -0800 (PST) Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mx.sberdevices.ru (Postfix) with ESMTP id 418EA5FD0B; Fri, 25 Nov 2022 20:15:09 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1669396509; bh=ql77uGu/Palxfhx5tOIxZcAYn3XCSN8xPcKIUYuh8t8=; h=From:To:Subject:Date:Message-ID:Content-Type:MIME-Version; b=FDBiDEeOS2k6hDA1qGlNX/3DzsK8GoWCLEst8zAU5Krmzwg0kabLhIU7CYaIgugZM uow4bkx6KB4iQmhrTUS2Uwp4aEWipuLNMnw2Q+CyEEbxiVI+7R3EqAhlpwc2p47/6k jjrzisgIXUghk7rvpDZ4UaFLfhPZWFvjerWzY66Bt0PJkZiw9cGTGtjNF2ldb4o0Ql jGX4pCa55Xb66sWfxdwCXR/5HQUV0IRCPhzeJYRhMWZdkPpXTuQ8e7ttf92hwjT7U8 rvSD5sclqD3o2sNqX0NHVrrm7brcip/OObd+zXkHXDipI8jM+8LQVwzHMPpmUPb0h4 cKyGmbTVmf+4w== Received: from S-MS-EXCH01.sberdevices.ru (S-MS-EXCH01.sberdevices.ru [172.16.1.4]) by mx.sberdevices.ru (Postfix) with ESMTP; Fri, 25 Nov 2022 20:15:08 +0300 (MSK) From: Arseniy Krasnov To: Stefano Garzarella , "David S. Miller" , "edumazet@google.com" , "Jakub Kicinski" , Paolo Abeni , "kys@microsoft.com" , "haiyangz@microsoft.com" , "wei.liu@kernel.org" , "Dexuan Cui" , Bryan Tan , Vishnu Dasa , Arseniy Krasnov , "Krasnov Arseniy" , Bobby Eshleman , Bobby Eshleman CC: "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "linux-hyperv@vger.kernel.org" , kernel Subject: [RFC PATCH v2 6/6] test/vsock: vsock_perf utility Thread-Topic: [RFC PATCH v2 6/6] test/vsock: vsock_perf utility Thread-Index: AQHZAPF3e7KytiwPOk+Ft+TrN7czrQ== Date: Fri, 25 Nov 2022 17:15:08 +0000 Message-ID: <93a19249-e3f3-c1f8-c58a-0f549b94f1b5@sberdevices.ru> In-Reply-To: <9d96f6c6-1d4f-8197-b3bc-8957124c8933@sberdevices.ru> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.1.12] Content-ID: MIME-Version: 1.0 X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2022/11/25 14:59:00 #20610704 X-KSMG-AntiVirus-Status: Clean, skipped X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750489212035427854?= X-GMAIL-MSGID: =?utf-8?q?1750489212035427854?= This adds utility to check vsock rx/tx performance. Usage as sender: ./vsock_perf -p -m -p -r Signed-off-by: Arseniy Krasnov --- tools/testing/vsock/Makefile | 1 + tools/testing/vsock/README | 34 +++ tools/testing/vsock/vsock_perf.c | 400 +++++++++++++++++++++++++++++++ 3 files changed, 435 insertions(+) create mode 100644 tools/testing/vsock/vsock_perf.c -- 2.25.1 diff --git a/tools/testing/vsock/Makefile b/tools/testing/vsock/Makefile index f8293c6910c9..d36fdd59fe2e 100644 --- a/tools/testing/vsock/Makefile +++ b/tools/testing/vsock/Makefile @@ -3,6 +3,7 @@ all: test test: vsock_test vsock_diag_test vsock_test: vsock_test.o timeout.o control.o util.o vsock_diag_test: vsock_diag_test.o timeout.o control.o util.o +vsock_perf: vsock_perf.o CFLAGS += -g -O2 -Werror -Wall -I. -I../../include -I../../../usr/include -Wno-pointer-sign -fno-strict-overflow -fno-strict-aliasing -fno-common -MMD -U_FORTIFY_SOURCE -D_GNU_SOURCE .PHONY: all test clean diff --git a/tools/testing/vsock/README b/tools/testing/vsock/README index 4d5045e7d2c3..dbeba1d62016 100644 --- a/tools/testing/vsock/README +++ b/tools/testing/vsock/README @@ -35,3 +35,37 @@ Invoke test binaries in both directions as follows: --control-port=$GUEST_IP \ --control-port=1234 \ --peer-cid=3 + +vsock_perf utility +------------------- +'vsock_perf' is simple tool to measure vsock performance. It works in +sender/receiver modes: sender waits for connection at specified port, +and after accept, starts data transmission to receiver. After data +processing is done, it prints several metrics(see below). + +Usage: +# run as sender +# listen port 1234, tx buffer size is 1MB, send of data 1G +./vsock_perf -s -p 1234 -b 1MB -m 1G + +Output: +tx performance: A Gb/s + +Output explanation: +A is calculated as "number of bytes to send" / "time in tx loop" + +# run as receiver +# connect to CID 2, port 1234, rx buffer size is 1MB, peer buf is 1G, SO_RCVLOWAT is 65536 +./vsock_perf -c 2 -p 1234 -b 1MB -v 1G -r 65536 + +Output: +rx performance: A Gb/s +total in 'read()': B sec +POLLIN wakeups: C +average in 'read()': D ns + +Output explanation: +A is calculated as "number of received bytes" / "time in rx loop". +B is time, spent in 'read()' system call(excluding 'poll()') +C is number of 'poll()' wake ups with POLLIN bit set. +D is B / C, e.g. average amount of time, spent in single 'read()'. diff --git a/tools/testing/vsock/vsock_perf.c b/tools/testing/vsock/vsock_perf.c new file mode 100644 index 000000000000..bca2027de52d --- /dev/null +++ b/tools/testing/vsock/vsock_perf.c @@ -0,0 +1,400 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * vsock_perf - benchmark utility for vsock. + * + * Copyright (C) 2022 SberDevices. + * + * Author: Arseniy Krasnov + */ +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define DEFAULT_BUF_SIZE_BYTES (128 * 1024) +#define DEFAULT_TO_SEND_BYTES (64 * 1024) +#define DEFAULT_VSOCK_BUF_BYTES (256 * 1024) +#define DEFAULT_RCVLOWAT_BYTES 1 +#define DEFAULT_PORT 1234 +#define DEFAULT_CID 2 + +#define BYTES_PER_GB (1024 * 1024 * 1024ULL) +#define NSEC_PER_SEC (1000000000ULL) + +static unsigned int port = DEFAULT_PORT; +static unsigned long buf_size_bytes = DEFAULT_BUF_SIZE_BYTES; +static unsigned long vsock_buf_bytes = DEFAULT_VSOCK_BUF_BYTES; + +static inline time_t current_nsec(void) +{ + struct timespec ts; + + if (clock_gettime(CLOCK_REALTIME, &ts)) { + perror("clock_gettime"); + exit(EXIT_FAILURE); + } + + return (ts.tv_sec * NSEC_PER_SEC) + ts.tv_nsec; +} + +/* From lib/cmdline.c. */ +static unsigned long memparse(const char *ptr) +{ + char *endptr; + + unsigned long long ret = strtoull(ptr, &endptr, 0); + + switch (*endptr) { + case 'E': + case 'e': + ret <<= 10; + case 'P': + case 'p': + ret <<= 10; + case 'T': + case 't': + ret <<= 10; + case 'G': + case 'g': + ret <<= 10; + case 'M': + case 'm': + ret <<= 10; + case 'K': + case 'k': + ret <<= 10; + endptr++; + default: + break; + } + + return ret; +} + +static void vsock_increase_buf_size(int fd) +{ + if (setsockopt(fd, AF_VSOCK, SO_VM_SOCKETS_BUFFER_MAX_SIZE, + &vsock_buf_bytes, sizeof(vsock_buf_bytes))) { + perror("setsockopt"); + exit(EXIT_FAILURE); + } + + if (setsockopt(fd, AF_VSOCK, SO_VM_SOCKETS_BUFFER_SIZE, + &vsock_buf_bytes, sizeof(vsock_buf_bytes))) { + perror("setsockopt"); + exit(EXIT_FAILURE); + } +} + +static int vsock_connect(unsigned int cid, unsigned int port) +{ + union { + struct sockaddr sa; + struct sockaddr_vm svm; + } addr = { + .svm = { + .svm_family = AF_VSOCK, + .svm_port = port, + .svm_cid = cid, + }, + }; + int fd; + + fd = socket(AF_VSOCK, SOCK_STREAM, 0); + + if (fd < 0) + return -1; + + vsock_increase_buf_size(fd); + + if (connect(fd, &addr.sa, sizeof(addr.svm)) < 0) { + close(fd); + return -1; + } + + return fd; +} + +static float get_gbps(unsigned long bytes, time_t ns_delta) +{ + return ((float)bytes / BYTES_PER_GB) / + ((float)ns_delta / NSEC_PER_SEC); +} + +static void run_sender(unsigned long to_send_bytes) +{ + time_t tx_begin_ns; + size_t total_send; + int client_fd; + char *data; + int fd; + union { + struct sockaddr sa; + struct sockaddr_vm svm; + } addr = { + .svm = { + .svm_family = AF_VSOCK, + .svm_port = port, + .svm_cid = VMADDR_CID_ANY, + }, + }; + union { + struct sockaddr sa; + struct sockaddr_vm svm; + } clientaddr; + + socklen_t clientaddr_len = sizeof(clientaddr.svm); + + printf("Run as sender\n"); + printf("Listen port %u\n", port); + printf("Send %lu bytes\n", to_send_bytes); + printf("TX buffer %lu bytes\n", buf_size_bytes); + printf("Peer buffer %lu bytes\n", vsock_buf_bytes); + + fd = socket(AF_VSOCK, SOCK_STREAM, 0); + + if (fd < 0) { + perror("socket"); + exit(EXIT_FAILURE); + } + + if (bind(fd, &addr.sa, sizeof(addr.svm)) < 0) { + perror("bind"); + exit(EXIT_FAILURE); + } + + if (listen(fd, 1) < 0) { + perror("listen"); + exit(EXIT_FAILURE); + } + + client_fd = accept(fd, &clientaddr.sa, &clientaddr_len); + + if (client_fd < 0) { + perror("accept"); + exit(EXIT_FAILURE); + } + + vsock_increase_buf_size(client_fd); + + data = malloc(buf_size_bytes); + + if (!data) { + printf("malloc failed\n"); + exit(EXIT_FAILURE); + } + + memset(data, 0, buf_size_bytes); + total_send = 0; + tx_begin_ns = current_nsec(); + + while (total_send < to_send_bytes) { + ssize_t sent; + + sent = write(client_fd, data, buf_size_bytes); + + if (sent <= 0) { + perror("write"); + exit(EXIT_FAILURE); + } + + total_send += sent; + } + + printf("tx performance: %f Gb/s\n", + get_gbps(total_send, current_nsec() - tx_begin_ns)); + + close(client_fd); + close(fd); + + free(data); +} + +static void run_receiver(int peer_cid, unsigned long rcvlowat_bytes) +{ + unsigned int read_cnt; + time_t rx_begin_ns; + time_t in_read_ns; + size_t total_recv; + void *data; + int fd; + + printf("Run as receiver\n"); + printf("Connect to %i:%u\n", peer_cid, port); + printf("RX buffer %lu bytes\n", buf_size_bytes); + printf("Peer buffer %lu bytes\n", vsock_buf_bytes); + printf("SO_RCVLOWAT %lu bytes\n", rcvlowat_bytes); + + fd = vsock_connect(peer_cid, port); + + if (fd < 0) { + perror("socket"); + exit(EXIT_FAILURE); + } + + if (setsockopt(fd, SOL_SOCKET, SO_RCVLOWAT, + &rcvlowat_bytes, + sizeof(rcvlowat_bytes))) { + perror("setsockopt"); + exit(EXIT_FAILURE); + } + + data = mmap(NULL, buf_size_bytes, PROT_READ | PROT_WRITE, + MAP_ANONYMOUS | MAP_PRIVATE | MAP_POPULATE, -1, 0); + + if (data == MAP_FAILED) { + perror("mmap"); + exit(EXIT_FAILURE); + } + + read_cnt = 0; + in_read_ns = 0; + total_recv = 0; + rx_begin_ns = current_nsec(); + + while (1) { + struct pollfd fds = { 0 }; + + fds.fd = fd; + fds.events = POLLIN | POLLERR | POLLHUP | + POLLRDHUP | POLLNVAL; + + if (poll(&fds, 1, -1) < 0) { + perror("poll"); + exit(EXIT_FAILURE); + } + + if (fds.revents & POLLERR) { + printf("'poll()' error\n"); + exit(EXIT_FAILURE); + } + + if (fds.revents & POLLIN) { + ssize_t bytes_read; + time_t t; + + t = current_nsec(); + bytes_read = read(fd, data, buf_size_bytes); + in_read_ns += (current_nsec() - t); + read_cnt++; + + if (!bytes_read) + break; + + if (bytes_read < 0) { + perror("recv"); + exit(EXIT_FAILURE); + } + + total_recv += bytes_read; + } + + if (fds.revents & (POLLHUP | POLLRDHUP)) + break; + } + + printf("rx performance: %f Gb/s\n", + get_gbps(total_recv, current_nsec() - rx_begin_ns)); + printf("total in 'read()': %f sec\n", (float)in_read_ns / NSEC_PER_SEC); + printf("POLLIN wakeups: %i\n", read_cnt); + printf("average in 'read()': %f ns\n", (float)in_read_ns / read_cnt); + + munmap(data, buf_size_bytes); + close(fd); +} + +static void usage(void) +{ + printf("Help:\n" + "\n" + "This is benchmarking utility, to test vsock performance.\n" + "It runs in two modes: sender or receiver. In sender mode, it waits\n" + "connection from receiver, and when established, sender starts data\n" + "transmission.\n" + "\n" + "Options:\n" + " -h This help message\n" + " -s Sender mode(receiver default)\n" + " -p Port (%d)\n" + " -c CID of the peer (%d)\n" + " -m Bytes to send (%d)\n" + " -b Rx/Tx buffer size (%d). In sender mode\n" + " it is size of buffer passed to 'write()'.\n" + " In receiver mode it is size of buffer passed\n" + " to 'read()'.\n" + " -v Peer buffer size (%d)\n" + " -r SO_RCVLOWAT (%d)\n" + "\n", DEFAULT_PORT, DEFAULT_CID, DEFAULT_TO_SEND_BYTES, + DEFAULT_BUF_SIZE_BYTES, DEFAULT_VSOCK_BUF_BYTES, + DEFAULT_RCVLOWAT_BYTES); + exit(EXIT_FAILURE); +} + +static long strtolx(const char *arg) +{ + long value; + char *end; + + value = strtol(arg, &end, 10); + + if (end != arg + strlen(arg)) + usage(); + + return value; +} + +int main(int argc, char **argv) +{ + unsigned long to_send_bytes = DEFAULT_TO_SEND_BYTES; + unsigned long rcvlowat_bytes = DEFAULT_RCVLOWAT_BYTES; + bool receiver_mode = true; + int peer_cid = DEFAULT_CID; + int c; + + while ((c = getopt(argc, argv, "v:r:c:p:m:b:sh")) != -1) { + switch (c) { + case 'v': /* Peer buffer size. */ + vsock_buf_bytes = memparse(optarg); + break; + case 'r': /* SO_RCVLOWAT value. */ + rcvlowat_bytes = memparse(optarg); + break; + case 'c': /* CID to connect to. */ + peer_cid = strtolx(optarg); + break; + case 'p': /* Port to connect to. */ + port = strtolx(optarg); + break; + case 'm': /* Bytes to send. */ + to_send_bytes = memparse(optarg); + break; + case 'b': /* Size of rx/tx buffer. */ + buf_size_bytes = memparse(optarg); + break; + case 's': /* Sender mode. */ + receiver_mode = false; + break; + case 'h': /* Help. */ + usage(); + break; + default: + usage(); + } + } + + if (receiver_mode) + run_receiver(peer_cid, rcvlowat_bytes); + else + run_sender(to_send_bytes); + + return 0; +}