From patchwork Fri Nov 25 16:23:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Keeping X-Patchwork-Id: 26091 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp4140419wrr; Fri, 25 Nov 2022 08:24:44 -0800 (PST) X-Google-Smtp-Source: AA0mqf7ojL6GD+jck4B+n6RnRsgpF0fYx0fLzZbfYzwqnbfNovk0gE6rC1jhbLUsHDu3QJkjaEDa X-Received: by 2002:a17:90a:bd86:b0:213:8cf1:4d9d with SMTP id z6-20020a17090abd8600b002138cf14d9dmr42087611pjr.5.1669393483936; Fri, 25 Nov 2022 08:24:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669393483; cv=none; d=google.com; s=arc-20160816; b=ciJHiaKjsl5ZBzygfFEAHwnPEQo7QAsdzOFaMXWEHNAHDFPZmJ37iljcKrdqCzQuXw euY1e3hD7d5LMU+4BXua7Nfem+6S6hanhwD1d/Q5BZkzwZ/jh49G7NNCoRqydJHsBG06 hsjMEv8EhTguTElZOPRVXxUIHf5FtXWcqgXo48v6BMh5zZ1kyUWLqm+gcmf6R2CRjGAa GcsC65TCkLabVnjQWrqhdEcMdR+fNe0z4ooqAhGHK6Qvs+dyVdsvFsNEaP1HMp69eNSa wEz3HpfWTxg07ClEqr4z5FlniYwMsV39z6MM0NcQbS0JI3XteaK/4J/wYc+FFeVASIeb WgSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=1Xj0qjpg+yYr8OjlhmKxIIj96tMZd7CEOEmBe02j11k=; b=ZL6ipNKOAYkTVv9sHsDiCert4Ghii7Hw5+fJbhBmV0auqpesbp8TizVDGrGOYPjkks zX5V8RTUuiSml+SZgg8z/tMSWHYoUfVoS8FmmKJmMz2aFbbiDJsQfQUWxTVNhqvEwhO3 Nx2KWREzvi0Ba3eajZY/nItI99uP7e5lqZcI6qD2iS18QtUZ0+jCpzBau6/YIu4qP7rh 6IuQTbCeImWphDhUNgyPEpJRKYEd9iIoX//cD2H1TYqzGJcAnbf44PCNefMUaw4tGswF Mw9oDnZwKb2/1C2mAR2EsASY24Oi2WRdYSj10iq+zQmjwgxsAIM2dvoUAX8jYdVHjWMn IRsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@metanate.com header.s=stronger header.b=6HbA3xg3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=metanate.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i29-20020a63221d000000b004705618bd69si4171027pgi.343.2022.11.25.08.24.29; Fri, 25 Nov 2022 08:24:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@metanate.com header.s=stronger header.b=6HbA3xg3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=metanate.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229597AbiKYQXn (ORCPT + 99 others); Fri, 25 Nov 2022 11:23:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229477AbiKYQXl (ORCPT ); Fri, 25 Nov 2022 11:23:41 -0500 Received: from metanate.com (unknown [IPv6:2001:8b0:1628:5005::111]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 708614A068 for ; Fri, 25 Nov 2022 08:23:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=metanate.com; s=stronger; h=Content-Transfer-Encoding:Message-Id:Date: Subject:Cc:To:From:Content-Type:Reply-To:Content-ID:Content-Description: In-Reply-To:References; bh=1Xj0qjpg+yYr8OjlhmKxIIj96tMZd7CEOEmBe02j11k=; b=6H bA3xg3vdbdYp5Yh9noPb0H6/F1luuPvfrxfMy4ClgzliniIhcPYhAgerJ5Oca2lP35GacrYuO+cWR q72o9ENIITLIzi6BDYVK7H1/murC2nK7UPBPWHS0+U25Gw6/sXiBtymyKt9nHp3FBc7ADRQdNRUqB exGE0V0YxmdVK9PUDQ7aX3gTnMlN3U3xBUSoLj9MQsLTm0Y1SEblvxjvQPBAzHyxHM4uKMrinRlfu 8MrMyfi8u8R2XwvmDYQ3R4QHTm8XSJp5RPUrknnYMB96k3Zh1SciIZELkaTl0Msx7UQQltUvlT2vz W8izeRcwyXbWSq56Bn9DYD6rDY8RKIOg==; Received: from [81.174.171.191] (helo=donbot.metanate.com) by email.metanate.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oybUD-0002ir-Ud; Fri, 25 Nov 2022 16:23:34 +0000 From: John Keeping To: alsa-devel@alsa-project.org Cc: John Keeping , Jaroslav Kysela , Takashi Iwai , linux-kernel@vger.kernel.org Subject: [PATCH] ALSA: pcm: fix tracing reason in hw_ptr_error Date: Fri, 25 Nov 2022 16:23:26 +0000 Message-Id: <20221125162327.297440-1-john@metanate.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 X-Authenticated: YES X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RDNS_NONE,SPF_HELO_PASS, SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750485941967084192?= X-GMAIL-MSGID: =?utf-8?q?1750485941967084192?= Strings need to be specially marked in trace events to ensure the content is captured, othewise the trace just shows the value of the pointer. Signed-off-by: John Keeping Reviewed-by: Takashi Sakamoto --- sound/core/pcm_trace.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/core/pcm_trace.h b/sound/core/pcm_trace.h index f18da2050772..350b40b906ca 100644 --- a/sound/core/pcm_trace.h +++ b/sound/core/pcm_trace.h @@ -88,19 +88,19 @@ TRACE_EVENT(hw_ptr_error, __field( unsigned int, device ) __field( unsigned int, number ) __field( unsigned int, stream ) - __field( const char *, reason ) + __string( reason, why ) ), TP_fast_assign( __entry->card = (substream)->pcm->card->number; __entry->device = (substream)->pcm->device; __entry->number = (substream)->number; __entry->stream = (substream)->stream; - __entry->reason = (why); + __assign_str(reason, why); ), TP_printk("pcmC%dD%d%s/sub%d: ERROR: %s", __entry->card, __entry->device, __entry->stream == SNDRV_PCM_STREAM_PLAYBACK ? "p" : "c", - __entry->number, __entry->reason) + __entry->number, __get_str(reason)) ); TRACE_EVENT(applptr,