From patchwork Fri Nov 25 10:19:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sherry Sun X-Patchwork-Id: 25917 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp3917737wrr; Fri, 25 Nov 2022 02:45:55 -0800 (PST) X-Google-Smtp-Source: AA0mqf5M0bzUaZyFXoblm+Fm3mf+mF94uuljcY235FfYhNzJW5+kfelUtXRcVfyx77+Ii1eQBfWJ X-Received: by 2002:a17:90a:a012:b0:20d:7c09:c92d with SMTP id q18-20020a17090aa01200b0020d7c09c92dmr39368680pjp.95.1669373155420; Fri, 25 Nov 2022 02:45:55 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1669373155; cv=pass; d=google.com; s=arc-20160816; b=tH63vpjFQ3H0c0vF4eS3611i58Ul4ly0Lji2XOTwnvZYzbaluC6x1geAWh6CXBpI8h iKxYawh4QPzDk43raOkjV3Z4AJ9bqsg+LV0VVT71cvvcyo/Y00l0K9eTgkrOeknlBjfT iM3IuUavbk3rC/L2Vt7uNHU3F/WirvsvZTmCtvs8NVV7tVMz7yEhJvhGOLxsE/UZBJxU RORL7EHyEN0ZCD2Kf0ga5Tbtkak2EZxieiMGqvod2dMyG7645scOk6kmrlrow5cTSgZh y6HJx0HsVKZcROMrNhy4WfD+/tOrkTuzUaZZ3GHpZIVayOhC60GIbHPOUyqEWv1MzIQN tCtQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=lmMgmnR5BPlOyaBJyIvJi5N09JYSTiOO8T5t81J2LhA=; b=izUKcqChmPNf6dScUguQK34YislufrcaOASzsEb9jl8Mph/PJC9bHDiAjtxpTrrn1P qDTVWS/HK+Ws9ViDISJJFRW3PF10ICjQu2XC+4Ab81gAXi57M3zb6/+x9KFqmjsX6j4c FD1QoJS6W5A5boMxqrJiCg/iqbWblD5cVdB/XeAw8XGexNhOREVsnyJbRiIrcr7XtvcZ 7v8uujFVv2tAYCs0ft13BXw4MdEIUzeB9Ai0cah0UC5DLUQnNsfOKCwWjEQl2m1a0/73 CA++o9OoEQOrsKkYhjqvYwuXXF0cvTcuCp+jJOCvRv3F/SFYECGkd1rXz1dqmrzV3eGG B39A== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=J2O3BqV2; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e5-20020a17090a9a8500b00218f2d6af26si3780991pjp.75.2022.11.25.02.45.42; Fri, 25 Nov 2022 02:45:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=J2O3BqV2; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230190AbiKYKXy (ORCPT + 99 others); Fri, 25 Nov 2022 05:23:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230161AbiKYKXt (ORCPT ); Fri, 25 Nov 2022 05:23:49 -0500 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2058.outbound.protection.outlook.com [40.107.21.58]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 498FE209AE; Fri, 25 Nov 2022 02:23:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BPL4K6gbkfg/CikBGrwUfQkN567S16evDWMKHxr4YnB4HBjteYtLSz6Rty/CjDSAkbB2NihXqsu45Dp22+DnL5TyA+NqlsHt4fKTro8kW2ZaI97c5Jv+h1YNQvWCpjiaNscmHebzperGMamgCTs1VBnHYGMUo5f22QNfQW+qGq7/IklNRWBnfdQp0KzLLFHsrfIMA5+3OlnH9Gr3fUSdvuOJxf9aowzG8GUmgJslD7+5QhKe8u26CEAyoH5ng7KB4ril+7BvOkIfaK7QokVVaDaWlyCjxsxxnNNZhAF0FxbjLW0PPXlrWPkVu1BXncRLSgOFpVSFSpiv52H38+3/ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lmMgmnR5BPlOyaBJyIvJi5N09JYSTiOO8T5t81J2LhA=; b=WstZzhXKKFlHIb6GKw5947FT7QZKZ9OH4rR9DjlD3gxkRDKDX/QIBfvpOkRp+KpsodOj/tS9QudPIggm3U8H3lzAywNtKEBRX7kyXLICyBknME4whIUoT3Mg2WgrB66NZIJKpDCEhjwqC7IF3JRxRQiI3R8RngWlymC+lC0D3BqqBiHEsXMFP/gYHXtk0oTvPcq/GCt39WwJB3R+7xmko1dJWZ+e1iSDrfvEagHGv/iMwYrcubOs/v9xvucIUal8bDQ27EVhWbAeULh0ZoHjPh4Ia5DiWPIjy2AvJY1w+8SsqKxcBJJf3G9v2oyzwoiykpwCpH0ckMWS3ghASGHV/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lmMgmnR5BPlOyaBJyIvJi5N09JYSTiOO8T5t81J2LhA=; b=J2O3BqV2TmeN/kawS1kOHkzb0r9kAkuGmmTCJxfRc8ABosFySaAmSxh72gz58Sjg7C54tdEgXkjq/imxPXDng7ehjINYX1fy1aixj8GaP1AHcGNgrMGydE6iP34KLP3vugdKeGw96EIWhi06l1nDSqqqSjPzq4rZCvI+4xrMHhU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8404.eurprd04.prod.outlook.com (2603:10a6:20b:3f8::7) by VI1PR04MB6927.eurprd04.prod.outlook.com (2603:10a6:803:139::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.19; Fri, 25 Nov 2022 10:23:43 +0000 Received: from AS8PR04MB8404.eurprd04.prod.outlook.com ([fe80::aaa8:55c6:bc8b:6bd1]) by AS8PR04MB8404.eurprd04.prod.outlook.com ([fe80::aaa8:55c6:bc8b:6bd1%4]) with mapi id 15.20.5834.015; Fri, 25 Nov 2022 10:23:43 +0000 From: Sherry Sun To: gregkh@linuxfoundation.org, jirislaby@kernel.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com, atsushi.nemoto@sord.co.jp, tomonori.sakita@sord.co.jp Subject: [PATCH V3 1/3] tty: serial: fsl_lpuart: only enable Idle Line Interrupt for non-dma case Date: Fri, 25 Nov 2022 18:19:51 +0800 Message-Id: <20221125101953.18753-2-sherry.sun@nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221125101953.18753-1-sherry.sun@nxp.com> References: <20221125101953.18753-1-sherry.sun@nxp.com> X-ClientProxiedBy: SI2PR02CA0042.apcprd02.prod.outlook.com (2603:1096:4:196::19) To AS8PR04MB8404.eurprd04.prod.outlook.com (2603:10a6:20b:3f8::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8404:EE_|VI1PR04MB6927:EE_ X-MS-Office365-Filtering-Correlation-Id: c088ad8d-9402-4608-8d9e-08dacecf20b9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BkrIFvZP742K5RaWAsvhwYezu8l9rYbT8P5pu0jKK6A+sd83nnGmj1gY0CH/lTxxylkMXpVxdkCwI59cb3QOaXZdVmJkjxuLjHC3HUSwK/VsBvBv2NQ50hiWiQCOiBtgiY9psWvZSVmkDsyP6jrXOnQnjCzasyyqF0z2JI676Hrcf3xtNBFHRb0xkQPDsMXHk2dEqmyXM0ZCZFB+C0+h9vrOL2dN7ZSmXlCmwD/e0lG5gqXoPLafd8qvZiwi3UB9H1s90rx8VHNT1MZhoEn6vktsUxHtdIBMteiKGPUYI+4hI6/Ndojfvp/rVaSx0cEmwY9K3tcX7y+c0vkLSjNxXl0rENwY3ZYA0KkwQl8gQTu5la8KNzT9wCWshcONlZ0yjbxmWuwsZ0QKQQ1upcNileddz7KjlqRmpNzeaxt1EJmg35fDLE8eeDgJMJfzejY6Hfjd8BVnQo9QZkA4WcXx8X0hUy/Y3aqKd2yWZabRSZhI8FZY8RrcfDVdoOjotPK6O576fW3sJf3RJQna53ZdtfnhOVhQV7Ts2O96Rn100zJjE4eReHLudLbzjauLv7vuVohU7sBvGkeA3Lrvj0lZFNjmVrXNx+0gQHoRMr3DsTyC4GUUCIGe7oXxDo+oBb2VCyXQCjJBzlFUcHExm//RwSaDoMh7nTP1OjYYJs3pAanGmBEB8T98FvPDjaKbr6CBm5k0vY/UZXT2UhU7vMuaMQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8404.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(366004)(136003)(396003)(39860400002)(376002)(451199015)(6666004)(66556008)(36756003)(6506007)(316002)(52116002)(6512007)(66946007)(66476007)(26005)(83380400001)(2906002)(38100700002)(38350700002)(4326008)(186003)(86362001)(41300700001)(1076003)(8676002)(44832011)(2616005)(8936002)(5660300002)(6486002)(478600001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 0ymxXAl8i8TbLJCClH6nM9vaIlNOGwiz2TeKQUDAYB3nFPGLCPDV/b5aWTsnCqwnT/yQIxbMZ9lN2BkoU6jEEg6vtISlPLdHes2s656EYxbtKRk/tgyAHwVAbvgFWIw79psiiKgkkp8NOTdqodNF84YwuekoBD57bgqmjJBa5I4tBfSZgvCguf4I+yEKvqZJOMaAL7EER1oaBiFWrG30z3ybbQuUWpqHqKVavBMGL2UzSnkcHBl5yvOh11TMtepoiKBJds9/5gZHSIXWbcxxCCRxo2VATpC7ZYMFbkNQiu7l+kYQ1e2WFM5XQAMQN66ZLODnqKV6Q+n7FKRKi7270jc3CPut5n/E2B5pchgmsEa7OObJu5XLcfVpugxZMsr//C2DUnsDQVBR3E4ywcO/Wa2WiaxlX6DQ0GNuq7W3Q/FQHiIeEVKPaQUAalHvn/D+WVK+5yCzdN+fukWrd9bzqynRhAa1ieMNMjnxWRdQmxF6FdRdh7uJBstrvhLlgsRmV6f6RzpvmvtItueRcw6ug3n8HaagGpPcQ1dpvXBYKzs3+3uQ+O/wiQtlmm9hCZxQ+Ujkje7RbYz5RBUKf8t5K6Vux6vc1qd9gzDGzith+Mgl2fo2Wr/onZS0P0wT+ZtA4yCfmEcUN+be0nCqRU9XjH+uQNED7WyeGuuP+8Q+LkMNWQdieuxjSPNxDyNlrvD2hAPiCoGnlbXFeTnWQBIS83Zllo7FicfGBiI9v4ZTQ26kCbZhCrCYIG82QIwyqhckL8aW/CBye3BaUy97QRXFCKdf8JGImurHA+RHkW+4nqgkV78/mL3GlCUTncVaY4ofq559TSMIWTV8R3GaEtItXc/rNG4wVMdoHQUjv0oO3/M8XDfjPGS7IE53z865YcDPOxTEbFIjed2SpjkIbTSRpy9JfYPBV/7t5jIubUjF0hxBiY21jvQpXa+DdYLDubdsimLsv8LL8l6AMbkIOerKL89NR6QT4FRfqT5PehC1C+cHU/B9/EBjX4lKtU/+k9aQxtsyyA6RaY+7MGrEYHnBTu6dXWzjn2oijOxnAvtKbc6oAitHGJl0egOYkLjKMS9+ZvpWfLuwYjNBRd2Zmv/IV5/r1VdXXoteBO704G1ZK4oYYVWZgr06RM/mMTJ+iK8LQOfZC283+x+BeuawdE8HQJWPU/yDQ+SwEiWF6cG5MysJh3d/MLnkBZzVv5I3/TOy3k5Q0VC5TNNs0Bam85iSnm0dMexHi539tRY0SSNBYcnb2u5jBmJn4/ImeCcHuwO/AaDTUukGu1z73DVPVc7DOGcWxC53KSqtZ9CnsOk4dOhSCqvEkAW5sFSyVkSthjhsn6Ri5L5CiXejNNQr5qvbH+WSIqjlBiN+4NQ12ySns0nU2jy8nqva9DQR/nw94c2G3X66xRPI+gaRf9QNpEXnwO+0LKZH+Pkv4dlM8OjWXOMsH7nFwmA5A7/0Rk2Ix2JLnYqzWMw2/4I8qIl507yokQHpyd7wIyQ22aAT4fdzSUwgsEmbt6UMKIRU5aU8Ix1n0qmv6QnwXIce+9o+PHy3LIryxtq0SalpnIqN5M7sZKLJJ48cSCblqbCwFWqQbdHW X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c088ad8d-9402-4608-8d9e-08dacecf20b9 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8404.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2022 10:23:43.0989 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cHEPv5TMqre258gcvMsCeDtOuJixSuMHz9uK6NES/yeXrMJWsWnpJYk8olrrCMwRIIuf9WmHeJw8BNnE2oP9Vw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6927 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750464625950239038?= X-GMAIL-MSGID: =?utf-8?q?1750464625950239038?= For the lpuart driver, the Idle Line Interrupt Enable now is only needed for the CPU mode, so enable the UARTCTRL_ILIE at the correct place, and clear it when shutdown. Also need to configure the suitable UARTCTRL_IDLECFG, now the value is 0x7, represent 128 idle characters will trigger the Idle Line Interrupt. Signed-off-by: Sherry Sun --- drivers/tty/serial/fsl_lpuart.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c index 5e69fb73f570..9b8d32262f1e 100644 --- a/drivers/tty/serial/fsl_lpuart.c +++ b/drivers/tty/serial/fsl_lpuart.c @@ -5,6 +5,8 @@ * Copyright 2012-2014 Freescale Semiconductor, Inc. */ +#include +#include #include #include #include @@ -181,7 +183,7 @@ #define UARTCTRL_SBK 0x00010000 #define UARTCTRL_MA1IE 0x00008000 #define UARTCTRL_MA2IE 0x00004000 -#define UARTCTRL_IDLECFG 0x00000100 +#define UARTCTRL_IDLECFG GENMASK(10, 8) #define UARTCTRL_LOOPS 0x00000080 #define UARTCTRL_DOZEEN 0x00000040 #define UARTCTRL_RSRC 0x00000020 @@ -1523,7 +1525,7 @@ static void lpuart32_setup_watermark(struct lpuart_port *sport) ctrl = lpuart32_read(&sport->port, UARTCTRL); ctrl_saved = ctrl; ctrl &= ~(UARTCTRL_TIE | UARTCTRL_TCIE | UARTCTRL_TE | - UARTCTRL_RIE | UARTCTRL_RE); + UARTCTRL_RIE | UARTCTRL_RE | UARTCTRL_ILIE); lpuart32_write(&sport->port, ctrl, UARTCTRL); /* enable FIFO mode */ @@ -1547,7 +1549,8 @@ static void lpuart32_setup_watermark_enable(struct lpuart_port *sport) lpuart32_setup_watermark(sport); temp = lpuart32_read(&sport->port, UARTCTRL); - temp |= UARTCTRL_RE | UARTCTRL_TE | UARTCTRL_ILIE; + temp |= UARTCTRL_RE | UARTCTRL_TE; + temp |= FIELD_PREP(UARTCTRL_IDLECFG, 0x7); lpuart32_write(&sport->port, temp, UARTCTRL); } @@ -1691,7 +1694,7 @@ static void lpuart32_configure(struct lpuart_port *sport) } temp = lpuart32_read(&sport->port, UARTCTRL); if (!sport->lpuart_dma_rx_use) - temp |= UARTCTRL_RIE; + temp |= UARTCTRL_RIE | UARTCTRL_ILIE; if (!sport->lpuart_dma_tx_use) temp |= UARTCTRL_TIE; lpuart32_write(&sport->port, temp, UARTCTRL); @@ -1798,7 +1801,7 @@ static void lpuart32_shutdown(struct uart_port *port) /* disable Rx/Tx and interrupts */ temp = lpuart32_read(port, UARTCTRL); - temp &= ~(UARTCTRL_TE | UARTCTRL_RE | + temp &= ~(UARTCTRL_TE | UARTCTRL_RE | UARTCTRL_ILIE | UARTCTRL_TIE | UARTCTRL_TCIE | UARTCTRL_RIE); lpuart32_write(port, temp, UARTCTRL); From patchwork Fri Nov 25 10:19:52 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sherry Sun X-Patchwork-Id: 25918 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp3917740wrr; Fri, 25 Nov 2022 02:45:56 -0800 (PST) X-Google-Smtp-Source: AA0mqf606o84vOtnzmXPQUG+uNRvT7am5dE3mNyVCcOU8U6j8hz+fUHKbyU+iyV7f9LBSYshG7Rf X-Received: by 2002:a63:5e46:0:b0:477:d01a:ab4f with SMTP id s67-20020a635e46000000b00477d01aab4fmr5852266pgb.378.1669373155863; Fri, 25 Nov 2022 02:45:55 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1669373155; cv=pass; d=google.com; s=arc-20160816; b=JlEehVgfoS09LHDtad5B7i0ceE9CoAglDpo0ve+t5tqYs+QQdqcndEOyDX/gDU+rwm f2FFNd3adhWGOQQcP6FLpGESFgXeYK/C1zZyCESlLCgfhLo5trdAF6wg4Mml/hgLpGn3 VDG0AKLsmvaAAtVxndW8Q6MzJs6rBt6oHI3YduFdC8A9H9bPkNtFW7QzZuKlwGP9lg// h5t52N22mkemUQMmmx6anoEdYQVBN0L1GDvEpPfNbF3wy8Ch8THCS6G/2F5uFWMiTDdR QNtzNuMofIJ1v5m0UXzPKD0MJmr2qz81ahARlXn5KLpUve+RmJXKS/oMkuLfXLWjeo68 E1Sw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=pR9XO/rjSdD3h8ydWemhdF1l8LqZeekBPDfF4XzmGOw=; b=E1D0cI6+qyke05uaSl7AYGFi/9uFUA6Cpricrx8zArXinyo8KcPFdNlIcUMEAZfG+I cGOaOzzL36YmmLCN18gPl1LAS0Su6qkqTYnczKJtOzqsfiaoQs3NiPuV59UvDlBiXGCC UlZJcTsOiQYWDvkYlNiwXFeaZw5rnPuFblxFu/lcQgnW++Zj0A3+iIpZKBv7F736H5/M hsUQw/DBnHVo/qSqk6eRbUQLyFLqCtx0yyrcE1g1vnbvAFxlqUecLk+tyOcalJiuF/tz 2D5nynqyM27AygFxSI49fNJzJYaU0OMghrldH5sYxOh+rYW3oIRAjOuTHCjqtIaJs2zK OcDA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=NdgL2cBa; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id on16-20020a17090b1d1000b00218de7c19efsi3685223pjb.108.2022.11.25.02.45.43; Fri, 25 Nov 2022 02:45:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=NdgL2cBa; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230204AbiKYKX4 (ORCPT + 99 others); Fri, 25 Nov 2022 05:23:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230177AbiKYKXu (ORCPT ); Fri, 25 Nov 2022 05:23:50 -0500 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2058.outbound.protection.outlook.com [40.107.21.58]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B1E941982; Fri, 25 Nov 2022 02:23:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e+xxXvJyuhy16Y4Awp/och3iJnQpTtARWFPqgmBqK5OVio16pFQ0GtAe3hrw6UOEX1WPJEhDVODtDl7rWU6nRKrbxCAgDca/X4qradk6JmxtNhOM9OW0CHXGlys7it8+HES1a6/V61Vp9Tx5MiDOoYwS6uf5CT0HOtbcyLXP4Zw0mwQgZK2ioD5oBJ4rUfWikL7Vy6ijcKGDkD+d9XuAmyXLLliOFaThDWKixXCA4K/BKBuMGOqTx+0YQQc9oEoDIP0U1k4Dk6o1StuqR4i6qUCdmdisSurLEQBqznkXiXc/zzkZbVoO5HfX3fWMFW+uXdMCMDSe6hW6x08feCoTWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pR9XO/rjSdD3h8ydWemhdF1l8LqZeekBPDfF4XzmGOw=; b=DZh4erEu5YTVZcWbfgUZ/npjFp5/EXWIasAcsEY3k/Ql0qouuejkmWqGuOZpIx4HJLb6vvU8O4RxHKeVBUrRYxXDSomkyZzyYBDJ5AhbtkA4koM6rzXIRN9sGCCEPnqRi7uHlwPSfGwL8JglXC4V1UkInZrf3+BAHB4WeE9vl0oUtXkdMzPE7nhKkrddZftBerFEteLzi3qLcjp4SEtZ6JITpg1zQ79tPKLe5A3DXHVvCxi+rt/EyfOjZkSeHLLNbWGtQhJbaQlr1+luANLMdgCPluchY4wj3W5BfahNR/mk4DnrfiVF6avO36N2x/JmlSwZFcNOLnFUqg9cYxa9BQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pR9XO/rjSdD3h8ydWemhdF1l8LqZeekBPDfF4XzmGOw=; b=NdgL2cBa60eGMqRomC6s3cFcrAR4hcmWZ0eLBbvmZpNCVQMSZQH07fVpEVEzzAxU/KGKOyjxNtyNUhBVAkWn8kWMyKLNPC/gpt0Qi90b5BSlitt+JSi+wJGmLUyxhPy5jo9E77Bs+qO/RYfP0JacgCXOzbYJKyn4lw2GSWri9VI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8404.eurprd04.prod.outlook.com (2603:10a6:20b:3f8::7) by VI1PR04MB6927.eurprd04.prod.outlook.com (2603:10a6:803:139::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.19; Fri, 25 Nov 2022 10:23:47 +0000 Received: from AS8PR04MB8404.eurprd04.prod.outlook.com ([fe80::aaa8:55c6:bc8b:6bd1]) by AS8PR04MB8404.eurprd04.prod.outlook.com ([fe80::aaa8:55c6:bc8b:6bd1%4]) with mapi id 15.20.5834.015; Fri, 25 Nov 2022 10:23:47 +0000 From: Sherry Sun To: gregkh@linuxfoundation.org, jirislaby@kernel.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com, atsushi.nemoto@sord.co.jp, tomonori.sakita@sord.co.jp Subject: [PATCH V3 2/3] tty: serial: fsl_lpuart: disable Rx/Tx DMA in lpuart32_shutdown() Date: Fri, 25 Nov 2022 18:19:52 +0800 Message-Id: <20221125101953.18753-3-sherry.sun@nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221125101953.18753-1-sherry.sun@nxp.com> References: <20221125101953.18753-1-sherry.sun@nxp.com> X-ClientProxiedBy: SI2PR02CA0042.apcprd02.prod.outlook.com (2603:1096:4:196::19) To AS8PR04MB8404.eurprd04.prod.outlook.com (2603:10a6:20b:3f8::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8404:EE_|VI1PR04MB6927:EE_ X-MS-Office365-Filtering-Correlation-Id: 30e48755-a469-4bf9-0ab8-08dacecf2302 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TZd35gmEQyEY7WCSaLh0KfdFaa+Zviv+etDz62faWWBjrjDydJeZKVZCxsacpkEhIWgYyylHWDN17rr0OVaf19bUIlnD8+q2hueYI0Y40V5xl3tpgvaC7hFrNHG7GZL77xs5xQ7CGU3P/rpF8d+g92bAAF9x61kORYbom2h8I9LTUw8ld+oXFhZtdmx6esSFkQ2J+j2SfPTsfq/LJ6575YC5ZH5HNayie00NoLvkwEZFHeXU/B7GKZ0U2S1ASOtXCYYds1kqB6OTRHpbGD7bVqLeK3EE3KEeVESc4MMFKDNtdK6sKq0KsCOD/t0gbIQx9mJdmIt9yeXuMwTvLUOjfgxnJk3s74AQ9lPfVZ7dlq5e3Px4qhcScDRUAcgDDcqGI1EubCp7H7TOMiGkFk9s2ULX35lzxHBxafG3DcWK2Qhy58D7/UJRYDvzuXIOYG5uqtqSwULJxJRhh/0P4FcJdHMOruvY2jeo8fF8LVN9lv4U6JnGRTVrQGdIr7SDD8bofw0jf7OGrNIUms/mOfFkQhB8W+L2An5BR6cRYwYKMowVSloldwKAMPLzNRgk6ffsBTo6Zguu4weZ301HA718BlZYoE6niK86NNsOlZgFPTExGZWMfUghfLW4wVykk5CeOrO0Dz1rSANYCVXF5PpWC2zZ6drEVpSIDLXu6UbO4v3b0MfX2vfwA66/Z7g9XKKTxNYb5P8Nu8N/eSjc04T2MA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8404.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(366004)(136003)(396003)(39860400002)(376002)(451199015)(6666004)(66556008)(36756003)(6506007)(316002)(52116002)(6512007)(66946007)(66476007)(26005)(83380400001)(2906002)(38100700002)(38350700002)(4326008)(186003)(86362001)(41300700001)(1076003)(8676002)(44832011)(2616005)(8936002)(5660300002)(6486002)(478600001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: JTo2DVud1fL1TO2w3owc7WGT60FrOHdqX0plzxC7auOrv2Y4f5LeJf3J0ORF2jLP2JNpukS/+ktXzn8K95Te6xLswAWuy9pBsHPASsUmODvr/7BngKw7DPL9dSDaDFkzk+9AwBlMrtLhofMsR07ItkR4m84nQDHOP25bLKEUyEtADgrdTz4UzoMqHkRPQfoNPdCMUIEplPXuoe1/s1SmixbQb2QS0Xz6kGyFJKPiX8k9CRzblEgXxt7lNC803c2VllYNsza9alsiWQEoGpFPG4xb6sEuQVS5gf6QrCCxl7Gv/etPFmpJMf0dTHiOmYJZs8FiNpy/VkRxrXa6lOnlR23U8kNioxjFvUQ7XJiwg53gpyd/oElQtD9tZdf+N5tAxp4TEoOr+XNSWEJYDWPujTCL2zwLVNg9CWSkQwghaVKsZ8gnyhEWlDplI13CtqkWPMe6EL5toS5lxjSUtT3MIVWyc+WnHtuZCL6Ld9UTBe2zbeA9S+7Zd7F4YpsV6aDcDr8CFPROjtAM1KBzLac8jrdsPqyRyzc0OEEY2GikNjeWxIJGjF3yJo4Z8pPrGookF9q3VTLCeo8ACdNOZZVGhLy/KitwmPXrPpri1phIb0jn0Frv7blwP3QGjTGZHYSgrSI+4kFPGHThkBxUUiyEiG5cyFhw3NNW94vkirF2ylVfijsr3go0ch0yO9e5Fr7rrdPcAy44VuIsETQLFraoadzPjI4gcVKXASasK4dk7POvDpNWdxNLCVid4HQz/U+UgW1l18/tIUq9eUjxDO+xSlvpnes1FwX78t7FA7lCuMe1/loIPe4BBUikdT/tRhv0b1SCMTI8qSzlNLvzoaY7UqK59lHLAipltggXoUkDzL9ZlLTe6cFL717Cm9G0Lki6vxz4nuU/8o4FwFjIYlV/53JLJ8rVc5O1BBG7UJXYkhAIc/qrqrn0+3zzaFPhvIWDlypCup31u1NSt2Y2dB5Ht+0bQyfu3VQEQD0fh7VD5aOuakqu3w+mc5TlMNf+M0ky2Id4/4wYCsH9H7mZOEZ6WnSZE6nwmh/99xm02IrneFnyJl2RtIxrPws1wcBEpSztjDLk/iE4w+nPs4QJWt9A9gDvHyU/FkJpmqHePQL83hyMk9X9oN2TiC4NrYUFR6ZeXbFJdZDijpCuOjRo7plZ10e9Se3JGVj5nlOPNMsufKu7Aq0nD4R420diaOEdMqOm9NIN7QEixe8v2zCPlztmi3iW9qInCPbQU/La3qHDi2iI3rDy15WCcPNs8S+QNUSnxHlhW1JilFPQFThpu0q4g5OyWSBvv2YhKma4LoLBRYbFKD3c5l/umuvilTPN5tsdh4VzfHsSb0RQ4twbpAgQcQSYSvztyAvkPP2Ky09qiX6SJF5FpEmwyf+miquzsKRCy2FQ3aK0IoY6jqHRVOB13tJDKc9Xwmei95zFsAxtGM0nMJJK5N1epyrhwLmZxrAUAoa5obCol/n6EYAm+6aLPn0tS2zzj6Cf8M7mdYJKt5oLPz7wa0GxA/blxfgl3C+v1u9L8xwk7TYg4MPdfLq0owWla85bpv5vWIyYMRz4u7MSVmBdqrnQejl3Kvd+Te8W X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 30e48755-a469-4bf9-0ab8-08dacecf2302 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8404.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2022 10:23:47.0059 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CpjBYtH7ZJ2BxHDTfQjytZQFBvSaL7BUI0faNZZoJsp64Gy4Y49v+GKBAogNM4wfmDNKlk/37bj7tYvnGJV73w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6927 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750464626765643766?= X-GMAIL-MSGID: =?utf-8?q?1750464626765643766?= UARTBAUD_RDMAE and UARTBAUD_TDMAE are enabled in lpuart32_startup(), but lpuart32_shutdown() not disable them, only free the dma ring buffer and release the dma channels, so here disable the Rx/Tx DMA first in lpuart32_shutdown(). Fixes: 42b68768e51b ("serial: fsl_lpuart: DMA support for 32-bit variant") Signed-off-by: Sherry Sun --- drivers/tty/serial/fsl_lpuart.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c index 9b8d32262f1e..88697ddcd8c4 100644 --- a/drivers/tty/serial/fsl_lpuart.c +++ b/drivers/tty/serial/fsl_lpuart.c @@ -1799,6 +1799,11 @@ static void lpuart32_shutdown(struct uart_port *port) spin_lock_irqsave(&port->lock, flags); + /* disable Rx/Tx DMA */ + temp = lpuart32_read(port, UARTBAUD); + temp &= ~(UARTBAUD_TDMAE | UARTBAUD_RDMAE); + lpuart32_write(port, temp, UARTBAUD); + /* disable Rx/Tx and interrupts */ temp = lpuart32_read(port, UARTCTRL); temp &= ~(UARTCTRL_TE | UARTCTRL_RE | UARTCTRL_ILIE | From patchwork Fri Nov 25 10:19:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sherry Sun X-Patchwork-Id: 25919 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp3918258wrr; Fri, 25 Nov 2022 02:47:06 -0800 (PST) X-Google-Smtp-Source: AA0mqf6jn4sqt9cbG3Ke6g09llr6ZUE68/KTZ7BxVkTq+jCbDjhBBntwy1UXhxJXdePZkMztYJO/ X-Received: by 2002:a17:906:b14b:b0:78d:cede:91f4 with SMTP id bt11-20020a170906b14b00b0078dcede91f4mr31211557ejb.764.1669373226416; Fri, 25 Nov 2022 02:47:06 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1669373226; cv=pass; d=google.com; s=arc-20160816; b=n/Y4zRObV0XTngoeF+x/pDyt8p9/04DEBPrCmhGeCAJwTyOrLgLhoU5brOsrhVHvaH 9gySc/jdBrp6pa2xuJDC6IRA1tEWRJyPncllO24cv+vPUOqK4DpbTxNEja17bQGQ4EIp JbUaDsVG1Nv8r6G1FcqVie0lCYApE3UE7dfPhEqVlLPfCnXjAIDYGnZa5/FRtCbL4RJs 43xD/AO+U6wr/eTMoKR0tM4FUhDFAsxwuwqCY2eSLM+lHxxgd3iGf8PYTVnnO3SbC86v z3qJOunnyXFA/HIi3jFWTOUyqgzmz7puRd/8aOLgd9qcAclEVYoxgYTdEOMEotwW3L35 pEtQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=BnIMUkbp0my6Hu28wLzDBKuIilcpbwCPevUq3Vbw9mc=; b=DZgrpCD+hiF+8oXID8mNiIQEixqeSytZomMzs0HLGUeitgLRpS6xz3v1dGHbkqJf73 1KSv+c0dDXnlwXPr3v6k++7OrviDLMNSvGKa05NWt3b511kIdcJjyUvK64/lYhC35Dby 6tCHOq/FoU4v7uSnXfpofYMQ2EZohD3yTpz5c5w/xu200yM8oI1ZI14gJg9OXHKRsaLX EyTbfvR6eH7/Lw+nRWzceiIAOSnAtdr39YbV8KNlymHPrcCqgyISCFjSeAbYqjkBecTQ ElKj12x95q+t9SzcUTl2Icn2xX1y07dgNtCbu7TnVem2PjhAdTPdG2raof9HXaBayB6P 63GQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=fW1HJ8P4; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d12-20020a170906640c00b007ae545e330dsi2460442ejm.210.2022.11.25.02.46.43; Fri, 25 Nov 2022 02:47:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=fW1HJ8P4; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230210AbiKYKYK (ORCPT + 99 others); Fri, 25 Nov 2022 05:24:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230207AbiKYKX5 (ORCPT ); Fri, 25 Nov 2022 05:23:57 -0500 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2045.outbound.protection.outlook.com [40.107.21.45]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 237F0429A3; Fri, 25 Nov 2022 02:23:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I0/HJoKThkGa98/EdClVrur5a2DhGYeQNMeyrcUx5S9tLK+wPrIDOdy3pKPu94XazhwVLFkVbNeuyVPm+PZie8KOd3j/o60xg7nvWhE9Kp8JiBS4crHvLT2wJcPt4qxrz77F2J21yppeOdi+NcSh8XEBvvVFHhUneS3AeP6VdSNzqz263nRXhBo30ChEUur3myzLO+pseXJf3TcT7rJN8YFEgt5k2DOiarZ6GdFqlrrqVwv1N4cTk8emHLN6Fy/LXJMhn9+GB1b2fIN9AikzCQfMLN5P+27nJ42ryi0KpCnldSSo57bJTgFWxGC1ZBHEs+6T6lMw4VWJcZ35jgKV2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BnIMUkbp0my6Hu28wLzDBKuIilcpbwCPevUq3Vbw9mc=; b=oR7wigRH01glU/RTOqhB8losuZi/y4hP83q0pES25YuOYBBK25uQBEcjgS8ZuXqs5ubXkWr1GiZEgtAIKLC3xfxnPfcRDehz78FIAQIHZ1mwp5BThQmbaxZK3t/zKrdw0oxn38wg64e4LdYazyQVPr/trcZfyMVa3+gDzlpjZ4wbTwlgs/+pncTO9uSFvVWPvdfpg161aXiEEQ+jp6vzwZIGs6hZMUHJNoyxznGooYoLBb8aiJiNGRlfk12XF3HFxafpigmhEobgIOmQLqbgs2j02+39tl221NJM2WgslITTMk+LabEFt5MuJFXaKTc2teAjqoqnnIESN/rdv9xGtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BnIMUkbp0my6Hu28wLzDBKuIilcpbwCPevUq3Vbw9mc=; b=fW1HJ8P4TJBW78VI5DzEoiN6V14WgLI7u9rqu6IdvRTnHKGKLfY0yOEDCfPtxVGxNVdF7P9sSOEUm3OT/XlDZVMYT//z3XpZHFX4r2uJ8dgPQo7JGEpJtJONJ7w3VMkKno/fcG4kPwHDLtu+SMzrPaZc/XNmALV86hFXVPryubY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8404.eurprd04.prod.outlook.com (2603:10a6:20b:3f8::7) by VI1PR04MB6927.eurprd04.prod.outlook.com (2603:10a6:803:139::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.19; Fri, 25 Nov 2022 10:23:51 +0000 Received: from AS8PR04MB8404.eurprd04.prod.outlook.com ([fe80::aaa8:55c6:bc8b:6bd1]) by AS8PR04MB8404.eurprd04.prod.outlook.com ([fe80::aaa8:55c6:bc8b:6bd1%4]) with mapi id 15.20.5834.015; Fri, 25 Nov 2022 10:23:51 +0000 From: Sherry Sun To: gregkh@linuxfoundation.org, jirislaby@kernel.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com, atsushi.nemoto@sord.co.jp, tomonori.sakita@sord.co.jp Subject: [PATCH V3 3/3] tty: serial: fsl_lpuart: clear LPUART Status Register in lpuart32_shutdown() Date: Fri, 25 Nov 2022 18:19:53 +0800 Message-Id: <20221125101953.18753-4-sherry.sun@nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221125101953.18753-1-sherry.sun@nxp.com> References: <20221125101953.18753-1-sherry.sun@nxp.com> X-ClientProxiedBy: SI2PR02CA0042.apcprd02.prod.outlook.com (2603:1096:4:196::19) To AS8PR04MB8404.eurprd04.prod.outlook.com (2603:10a6:20b:3f8::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8404:EE_|VI1PR04MB6927:EE_ X-MS-Office365-Filtering-Correlation-Id: 6b046075-1771-444b-4234-08dacecf25b0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YqMfR3NIMdt6DryqCOeiycjV+/i9GDBs+gOjHLBPu6WzVbbOdOSf9UzOAE96vUedbipr6WcZ8nXPDq/9xon3HmsRerr8viuTWhyfYQyiGfII5udjHOfcTmGROha8r55aYlYsl90SatxpJQeJfMtkPGO7L6kfTNv4kiZCuxUSLdtxpcBR4azuc5sftfm+bBLAa/Jfjz3ysDw4j9qaBw4wBdvkVNNKcN61Lpeui/7FCe/5saYfB27NwU6xMZXAFWWDTrnq3RvvM5ZuUKoIeATiVXctRcPHQFTpgQegbw9Zb9SCrZtUZ91fiTdmiAfu9J/M6V2uWxgR4L4Rmy+iN9D8x7FE9cFk57pKVhiEaXT/Sik8RK66LP4x+SZv1Hg7EPLEgMFzJ9yIAGcieKJ1Pr5t0pgnWWxusIMmvUGOWg0jaMfTcwixwQiFFcRSS6mmpKsG+8YhQK+YolagsJqfcileSIlYbq9w5loJbvKu+wJdmwCyzzSFfOYONwLgXayPjpTa7t4UEd8Y7pS7afMSAUj1LglN7jlG/Z/536POYOHe7Q6Lf/9lWO9/zqMEn0CtBp3nJrbG8kQtoWi0u2TiNZwAQ9KPshzDP0P+w3sHbW3mvTSI2KmmzFWjsCKQqILPQmKpNgh4ItBGykK96JCS5ALDSNnjCuozr2a12oEYmPqtq4MTcfemoy7b/fKh+lJxn80IiuT4s/hhlSggvql3ak3X/Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8404.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(366004)(136003)(396003)(39860400002)(376002)(451199015)(66556008)(36756003)(6506007)(316002)(52116002)(6512007)(66946007)(66476007)(26005)(83380400001)(2906002)(38100700002)(38350700002)(4326008)(186003)(86362001)(41300700001)(1076003)(8676002)(44832011)(2616005)(8936002)(5660300002)(6486002)(4744005)(478600001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ZMYYkWa35Hc1lGic2HQiH3qO9XNot9/OaDvmjsL8Oopn1NIqkFX+n5/DSBfuojeroxmFl9YcNDnjlDAfvEei0CJ6YUGMhYB3K+GDhiXSa80odqFF2ukIUuqBHz8N2r7clGTtyJu0Opr7IpDVmroO2VID0ojfVIIp84xmtLpoC90cX2oN3bO3O0QcbWuzTPX7WU0Au/bTaRtgOIIbWr1T8Az9hgqWYbGCv8d9mLiVc3DiZ5w5ww5bYifHcOnVLd9qzQpsV5FyKMklBsZIlxDuk4RyfxzGroHfxA3VZKidJYMH40+loUJz2kR26VhMvRzR1VBMWiL2KYF7SVT+9IZffmUkqJMJGIw+GpJa7WCBuYG++Jh5xyCLALMPiBpoYogwbuYLaB0eHaulW7VgaVRChE66S+aLjouLu5BKD8CgbXEQhDeCoG3VDh+oAdwiMioa8zvP8LJstDbVsbGZUn6wnQ6vdNFzmGy4u0Nh6jy8R+gRE5XoCSzFNIH3Y5H+d0eA8vp/bk/b++Nmz7AANl6aGyaPt4bA0rH1cnH8rkSdwXn73n3xZwpwRXBOd/2MWPzox/NjVnIb4UvlkOcMcNmmaSw7tkS45f3AMqZAHyKO3XN6ClHYocISabo1qkWkwMLpKIcWTpkAG/jB9NrrQc/9td6XvXr7QxGqWVAUxYW/iSjYeZf6BFSeWYoNgJX9k39HsCGlTrTtuFVkvdHV+lEipbYKwpv37OzUzqylOW073eodZdccph9Xl64OX8m4VGB6Iq8H5tmdCMSuedfVkw64DA2iPr79z25TZBxV7T7OBEVtGL7rsX7UQ5iQOvmDt+ux9+2Ir3DPRnmUctvzcbog6fWcCYtVBOtO50Y2Ep2Z6vPoH3V5PcpZ9YKyZerIdaHyFD1nQniTddcHHgCyLriodyq+JhwgnIqCsK3k7N16R6TkEqIgK53/h3eAQr+VAIwWEQzfmBGxM/p9m4yww4pvu4qW6YMcvm7OEkgCKosjjPh4IakXy0mevJDRsNVx0YPcNLn6EehxRsNPg55spKEbDQb1locf4ME1kbBJsD4WegVZSnURReYoECyJj6BUp/BNeh2I04eTUMz9vUaTl7QLMHzUkme7YBzd8ehYUg7z5Sp7Vjqso9DifMrO+jFTwIrQPXC3lXZZ/OWrBp3ORZSBK9gGj+B0x9uO4SFkDC4ucuiy0DP67GL0fhYBxED9UkUwvCW5elTcBy41545VuT+DqDbdc2fnhhOmXQg3A+gQJ7cACA3rWRsVptWnz7x/oPQU1EBMsuoL9xlRdsl4j4PRndzBYVeYNw/n8SLcCotlNV9vc0elXArq7kka8XB7HBiogZX8Z/Gfgotvaqw8L34YzxqroceDfg8gAoVnW3RMoa0wmE3xufpHn6ndr1fiZoBPSU1hjARpSij7bXOWioRlziuQzmqZCj5KHhgBmF9ZmnejG6dUgzG62VxihaMM0pYVkLID5FD2qVZrkKILnIL2hyiQrkLtDlfqadlpVVv8FR5ml0PaA8E5gRb2sbBuHtzp0WODQQsrI4FI0msLrORnlJVlbeBWHHhiOsmxfoNbbce7k/CK3ydKOQz2SiERVoNT X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b046075-1771-444b-4234-08dacecf25b0 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8404.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2022 10:23:51.5800 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SLvqDS/nQwLtUk7+yxQnkeOYuordR8FK3dIsa/z1w5yOnjX992e0l8fM2rFtTraPohGGRfrkB03DtOKwlVeKgA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6927 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750464700113855911?= X-GMAIL-MSGID: =?utf-8?q?1750464700113855911?= The LPUART Status Register needs to be cleared when closing the uart port to get a clean environment when reopening the uart. Fixes: 380c966c093e ("tty: serial: fsl_lpuart: add 32-bit register interface support") Signed-off-by: Sherry Sun --- drivers/tty/serial/fsl_lpuart.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c index 88697ddcd8c4..8918e08bb19e 100644 --- a/drivers/tty/serial/fsl_lpuart.c +++ b/drivers/tty/serial/fsl_lpuart.c @@ -1799,6 +1799,10 @@ static void lpuart32_shutdown(struct uart_port *port) spin_lock_irqsave(&port->lock, flags); + /* clear status */ + temp = lpuart32_read(&sport->port, UARTSTAT); + lpuart32_write(&sport->port, temp, UARTSTAT); + /* disable Rx/Tx DMA */ temp = lpuart32_read(port, UARTBAUD); temp &= ~(UARTBAUD_TDMAE | UARTBAUD_RDMAE);