From patchwork Fri Nov 25 05:08:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: shravan chippa X-Patchwork-Id: 25818 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp3775796wrr; Thu, 24 Nov 2022 21:10:36 -0800 (PST) X-Google-Smtp-Source: AA0mqf4BAhS5YjXvcDNpOsWYKzAEHBGrPJ4xhKWPawCzaQgfQdjN3U+P+AOSKRqAkqT2sIN8uish X-Received: by 2002:a17:90b:1e0f:b0:213:c5ae:55ec with SMTP id pg15-20020a17090b1e0f00b00213c5ae55ecmr37719708pjb.182.1669353036673; Thu, 24 Nov 2022 21:10:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669353036; cv=none; d=google.com; s=arc-20160816; b=SLpRuek+GkkhhG0JXfysmCcWj9jZwdVRMPHEbxppEfS7zUxP4ENc0tS+RdLjLSL8D0 AIk4rqMebACisYCa/a/NnVsacySpiBP7UT5rQ6F9tZDMDRZO/+yDOBd/6D7U+6UZw8oZ lyV1fSfQbSYwF5A8bK0zKSkEY1anF6bQTh+GRIhsE5ULCcrCaUuZSnkrwYY3BVab/RP1 M24XrLjFf65jUjjeptW8PFkaPOqOGipZAaIafKtQ4OWfTSbLvG0AcxcPnhnWpmk7kF/N ZkCP5BrLICvYiB1dhCDDXZTm2kGqXScAyYdjbdb8n/4Y0bovwCEfO/at9XiTHrgzvcDT 8DmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=RApTeIt/6Ok1d1cNQXE/itXeDpVDvtFnB8173Z6m/qg=; b=fiBd0kTzZNGFgKXW0R+7ja5RmAg620drHdEzBGSWVjZ3YeDdpmUR7qOCLfqnGpBZ5W /m4vlYXatbFBmaySj+Ic6gVSdDFQvAk9WmK08KnyeayQqpVHc6kVEc4a0Q53pAlCF5IK Yj7jKLDTet/JmwVNs7HgEhyFyX4VTvvbRk+AtV7HATbOKrRX+UGJVyf2xo5bem5O1h5z gHwBhaUmJxST61VmGEsrRJvyn9CcEExX6wfn+Jt0fbdT79+WS6LYqiF2ggvcnoCAOGfb NE9kYzNkWK8OS4nrPL3pNAnTMIy65QyqiON3TxaTvHFG1JbcDOIMhlUCVcX2H+lV6wXE 95vQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=Bnv02nNp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w64-20020a623043000000b005731d316830si2556656pfw.23.2022.11.24.21.10.23; Thu, 24 Nov 2022 21:10:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=Bnv02nNp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229641AbiKYFIe (ORCPT + 99 others); Fri, 25 Nov 2022 00:08:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229624AbiKYFIa (ORCPT ); Fri, 25 Nov 2022 00:08:30 -0500 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47E8E28E35; Thu, 24 Nov 2022 21:08:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1669352908; x=1700888908; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=V1OMSs+r2Vdaq4EgRP9UUqO3OShybYjzPFVxY3dHlKs=; b=Bnv02nNpyF8pY6pZ7cvb01gWcqVMd7IfFtAEAF91+Fwq/J0Zz9poEs0W on52ZdYqhiFx8qM+LFgJl+YXl4rD0CqtqlNSt+S5JuxbUmaVVAogVby1I 4NPLckF+kQi1M1A0+nzaFx+41J7ARAL7bElEfe5gScyR3+seATEI9l+r0 L+0kHn+gyaS1nCKdvVQI0YkwTrqfk2CbbisP5msvVHdsEhDHx1ENX5+Uh oaA+dkbDsCXI4Wr3Yfln+vF2odSGVmHDViKVxAllZ3tgCtvIM5unM7xkQ yf/GR1u/l73ppGhDdnqV4jy2WcsFh4Lj3is/Etw2sOyNfefOUGPWeInip g==; X-IronPort-AV: E=Sophos;i="5.96,192,1665471600"; d="scan'208";a="125044667" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 24 Nov 2022 22:08:27 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Thu, 24 Nov 2022 22:08:27 -0700 Received: from microchip1-OptiPlex-9020.microchip.com (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Thu, 24 Nov 2022 22:08:25 -0700 From: shravan kumar To: , , CC: , , "Shravan Chippa" Subject: [PATCH v5 1/6] dt-bindings: imx334: modify link frequency in examples Date: Fri, 25 Nov 2022 10:38:02 +0530 Message-ID: <20221125050807.1857479-2-shravan.chippa@microchip.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221125050807.1857479-1-shravan.chippa@microchip.com> References: <20221125050807.1857479-1-shravan.chippa@microchip.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750443529683319954?= X-GMAIL-MSGID: =?utf-8?q?1750443529683319954?= From: Shravan Chippa -imx334 sensor is configured to 1782Mbps/lane for 3840x2160@60. -But in device tree bindings exapmple we are passing 891Mbps/lane so modified to 1782Mbps Signed-off-by: Shravan Chippa --- Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml index f5055b9db693..ea3c93f97d65 100644 --- a/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml @@ -82,7 +82,7 @@ examples: imx334: endpoint { remote-endpoint = <&cam>; data-lanes = <1 2 3 4>; - link-frequencies = /bits/ 64 <891000000>; + link-frequencies = /bits/ 64 <1782000000>; }; }; }; From patchwork Fri Nov 25 05:08:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: shravan chippa X-Patchwork-Id: 25822 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp3776198wrr; Thu, 24 Nov 2022 21:11:36 -0800 (PST) X-Google-Smtp-Source: AA0mqf5RVXWJWoz4ahCVBnGsW2xwKgtA3d0BTWCWtbxCew5sXOTlr1HitLwQaXD4Ru4cX6fBOyL/ X-Received: by 2002:a17:902:cf0e:b0:186:6723:9217 with SMTP id i14-20020a170902cf0e00b0018667239217mr16783297plg.160.1669353096288; Thu, 24 Nov 2022 21:11:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669353096; cv=none; d=google.com; s=arc-20160816; b=OOOhxZc+3XkCorZ0/TIIBUMGHgiBfFG9WLJq4IitWr3HEtEu4YZdR115iJxNcnaYxs vLQfTKFSyPhMi2aNq55DM1sCA/zLYn+rvtd8hsOc0Os2bJ86Kf1zVpwcdSPzFDeLFJIQ wK1xUKx37g/2EIMEDOOWYjouXDzwt+8MH+D8bURi4m3ahi9+MfEMhKxJpThMuf4h//Cu f+LKBcIHfgQfIV2IwlnPqYaX230IbS05jR2I1raf9CI0gvCs2aENmhKRZPqTcTtNC1Tx 52spofXxsKJNmc/OAseuUqLvDH1hT708CecL3R406hSgBKpPUXvECxpUx+nLcPesCABD W/JQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=wU0fYVKCErHsCZDdaerzmxhNEscsOXV8DlGrpOShjGw=; b=OLos3DL7MtESCmcOyOFVIhIJmNbh6NffAR86qHwAbx7bI1MVSrkMmzuy/ONg0/RSvD HTokN741f+JQv+8oDdcFaznhfl5Hrgb3BLZDVa9/tD9h8BsrvwA9HH97XWI+DXFOqkfO eUrSitkYjSYpnf01BoQv0WNT2LSxDPEGpdksZ2w0g1KXmCbG5wpNYvPk+cb42g/MGjQG 9tf4rjUbZHN0wyjsJdH+IDBnK8rG2MBixAkxbBydo5gx4BXQyrvuqUNwdovAaG4s22Le ASktmNVcNhxqaJSBPOiqA/Y1xNZCePm/D6N3O1lav7nlZhzmrgMCN2llMvOAu7s4XO0h mCQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=CiRwem05; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h8-20020a056a001a4800b0056618176fd4si1744829pfv.148.2022.11.24.21.11.23; Thu, 24 Nov 2022 21:11:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=CiRwem05; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229680AbiKYFIj (ORCPT + 99 others); Fri, 25 Nov 2022 00:08:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229624AbiKYFIh (ORCPT ); Fri, 25 Nov 2022 00:08:37 -0500 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B621027CCD; Thu, 24 Nov 2022 21:08:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1669352916; x=1700888916; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=+D0/Fxfae05FKfgOGGCgFaFjNNeek2oUT39t1A4j0HI=; b=CiRwem05DSaXKwDx07xWhVc7fugqYPHhOD1i44PGeFozKt3ddaXJEb0E uI29f8eDRqhPw9+tq7lG5TSu7iGqTavhlznECa9m5CnwUMXDDowRJeNRt /zr0DUxyDrbgSvDl0bBt6k5VxcxD1bOKNHcLsDjkTzQFdp+y+69/Q646W /EHQvlSUwd9G+cp+fcFnXZRpRBEMUxXDWYeqYDCQ9o3WM+LZEta0cprp9 KH73kKgVPg2QTvcPqkkLXU/KMMLYXNX2wf4VcG8+G6CCOoa3gUYOibEuY 69oCyhaWwf1SmOGFoDsv8J+ts/UuFR3OLRRUBt8P0sITW09kEE4XfUvde Q==; X-IronPort-AV: E=Sophos;i="5.96,192,1665471600"; d="scan'208";a="188604155" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 24 Nov 2022 22:08:36 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Thu, 24 Nov 2022 22:08:33 -0700 Received: from microchip1-OptiPlex-9020.microchip.com (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Thu, 24 Nov 2022 22:08:31 -0700 From: shravan kumar To: , , CC: , , "Shravan Chippa" Subject: [PATCH v5 2/6] media: i2c: imx334: modify link frequency as for the configureation Date: Fri, 25 Nov 2022 10:38:03 +0530 Message-ID: <20221125050807.1857479-3-shravan.chippa@microchip.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221125050807.1857479-1-shravan.chippa@microchip.com> References: <20221125050807.1857479-1-shravan.chippa@microchip.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750443592496041538?= X-GMAIL-MSGID: =?utf-8?q?1750443592496041538?= From: Shravan Chippa -Imx334 camera is configured for 1782Mbps/lane for 3840x2160@60 resolution. but the imx334_parse_hw_config() function comparing with IMX334_LINK_FREQ(891Mbpa/lane) link frequency -The 3840x2160@60 mode values for 1782Mbps/lane -Updated Macro IMX334_LINK_FREQ to 1782Mbps/lane -The same value is populated in the userspce also Signed-off-by: Shravan Chippa --- drivers/media/i2c/imx334.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/imx334.c b/drivers/media/i2c/imx334.c index 7b0a9086447d..acc9f9f15e47 100644 --- a/drivers/media/i2c/imx334.c +++ b/drivers/media/i2c/imx334.c @@ -49,7 +49,7 @@ #define IMX334_INCLK_RATE 24000000 /* CSI2 HW configuration */ -#define IMX334_LINK_FREQ 891000000 +#define IMX334_LINK_FREQ 1782000000 #define IMX334_NUM_DATA_LANES 4 #define IMX334_REG_MIN 0x00 From patchwork Fri Nov 25 05:08:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: shravan chippa X-Patchwork-Id: 25819 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp3775891wrr; Thu, 24 Nov 2022 21:10:50 -0800 (PST) X-Google-Smtp-Source: AA0mqf4djZAUhIbUMN05tn9uoxtah8xla71B4SiYVoHS3318sXv0IafJnhBGeCHIAosHYRVp7+Fw X-Received: by 2002:a17:90b:f06:b0:218:d86a:3cda with SMTP id br6-20020a17090b0f0600b00218d86a3cdamr13382228pjb.99.1669353050119; Thu, 24 Nov 2022 21:10:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669353050; cv=none; d=google.com; s=arc-20160816; b=qRA/vvKeRCjdxOvI/6qlD3D2bMVYwS/4H0u4pBOvYCWOvxxVHoFRkOpZ2ZX5D5+Pyh /x9U+mFr0EKEwbJ8wyLBr05QWgyzTV1QlvuOqny3EUtbnCnWxr6fdFhMUvWSfPfW8T2x FKlS/4eJZPeUEsS5oxdfbWClrIfMmUevtzuhi3mjDe/Q+CDTZWrAdkWkJCFyt3WK1lDH mxZGlT7yOl9qTCr5JsG5wh9jLOCsoq8QF2fIRh0HH/Zh3reb+UMVkMcY3gxqy1hTNBa4 htzU+q9+GARAc++v0ksQ+ykmS34P+llnYxvaRKITKO5kK50tSthiuQAam5X6Z47IXR2w 3Rtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=cqPi0yZ9whQVbfwrfddEpRM9BQY1bmhG8OqwExUt4pQ=; b=Jk4cPj9YQz/72EU82CVCHz4qenq+xDdu8orpgzGnayxrchl5WNVNwm5233ZLnwy1sB 6qfgogs9FqJsq0npBBWc1cFFHvqTwqBIXqEiG00ORWfYWP3O3asmuyivYssGc0Zhb6tK FqkJVT+kK8SlA6QVkka7LBodtkpaHjIztgt9oXI5AT9AaOZGZ3Kael1R70YAWCUh0m72 tqMtuQJxr/N33Mx3E0zHEYMIBYhtfaoPuneTa+cvU9g3bMkmennTqB7mr6K7BXuFo6zg rskWQxy6jngJR64IuBUHuieQIvTt/A3Qtr3OpT9wd9TFWdE1cG5hQvLR0/bY0HUReQyc xDZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=GMvvG71F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bn10-20020a056a02030a00b004772cf9ae7esi3359066pgb.284.2022.11.24.21.10.37; Thu, 24 Nov 2022 21:10:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=GMvvG71F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229646AbiKYFIp (ORCPT + 99 others); Fri, 25 Nov 2022 00:08:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229695AbiKYFIl (ORCPT ); Fri, 25 Nov 2022 00:08:41 -0500 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7231128E1C; Thu, 24 Nov 2022 21:08:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1669352920; x=1700888920; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=g8OBmYIK6Fvoc7i+MI8M2i9rEaNDQ9Z3VGMaSA83cJM=; b=GMvvG71FK+QVXIIRt+Z3hivGLSSO4z+Sbr7u9ha4f8LXk58qR3kBH+Ms cqyJrpQjvYz2xb5kYBcDjPtOfvBIm2ubuaej0oIbP/0LPBVKwYUKRnuQb ABiuqKaNVOYhRm3v3PxzU1wyCRSUOQ55+CGHNJ+NMkk8PI+xcb/wVPRLf u/09SowJBwkCGgUTiqNDC4VVSThx1RdNK2ByEEXc4zWMtQkS2tPqZV7CA MlbTbj9G9nfThr3zE5E0N1t1hsmDWR7TGBLi3yVvsN9LUWP0mk9motuk+ /Vhww7uV40RtJ5lRsYeRNy6QNiTWCSK5D64L+QxdPR6hawuQFCXC7KDZy g==; X-IronPort-AV: E=Sophos;i="5.96,192,1665471600"; d="scan'208";a="188604162" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 24 Nov 2022 22:08:38 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Thu, 24 Nov 2022 22:08:38 -0700 Received: from microchip1-OptiPlex-9020.microchip.com (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Thu, 24 Nov 2022 22:08:36 -0700 From: shravan kumar To: , , CC: , , "Shravan Chippa" , Jacopo Mondi Subject: [PATCH v5 3/6] media: i2c: imx334: hblank set function modify Date: Fri, 25 Nov 2022 10:38:04 +0530 Message-ID: <20221125050807.1857479-4-shravan.chippa@microchip.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221125050807.1857479-1-shravan.chippa@microchip.com> References: <20221125050807.1857479-1-shravan.chippa@microchip.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750443543840137692?= X-GMAIL-MSGID: =?utf-8?q?1750443543840137692?= From: Shravan Chippa -If we one modes hblank will not change and it is readonly -If we have multipull modes and if we do mode switch, hblank value will change and __v4l2_ctrl_s_ctrl() returns error, so modified function from __v4l2_ctrl_s_ctrl() to __v4l2_ctrl_modify_range() will updated all values max, min default it is not showing any error while changing the mode and update value Suggested-by: Jacopo Mondi Signed-off-by: Shravan Chippa --- drivers/media/i2c/imx334.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/imx334.c b/drivers/media/i2c/imx334.c index acc9f9f15e47..d3bb62c162b3 100644 --- a/drivers/media/i2c/imx334.c +++ b/drivers/media/i2c/imx334.c @@ -382,7 +382,8 @@ static int imx334_update_controls(struct imx334 *imx334, if (ret) return ret; - ret = __v4l2_ctrl_s_ctrl(imx334->hblank_ctrl, mode->hblank); + ret = __v4l2_ctrl_modify_range(imx334->hblank_ctrl, IMX334_REG_MIN, + IMX334_REG_MAX, 1, mode->hblank); if (ret) return ret; From patchwork Fri Nov 25 05:08:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: shravan chippa X-Patchwork-Id: 25821 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp3776090wrr; Thu, 24 Nov 2022 21:11:19 -0800 (PST) X-Google-Smtp-Source: AA0mqf6/GDC1qJBOyKKMJ7EVTkM1HpddQooccJdP72Nks0lH445D5d3S4ZEezciQQyC8XIZJW1uM X-Received: by 2002:a63:e54b:0:b0:46f:8e45:8da1 with SMTP id z11-20020a63e54b000000b0046f8e458da1mr14463251pgj.71.1669353079145; Thu, 24 Nov 2022 21:11:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669353079; cv=none; d=google.com; s=arc-20160816; b=ptY5y3llGt6xfV7M9DIG2eh5pLslWZ4BgeKvVPgnAMKrhZiGpg8zS4ZTP6hHubxaPK zcVPhHA66lu/qTb43DJVeOsBuRd7XMivoal/WK9/aL5zH2foyPmbM3yXU0VFMXaIDz9X Mk0aQfyZVo8IB0Q/W36smz2YBUlSn0Mk5t0mfuT9kjk+lt3vphgfKVUXocmKDeStkqBu ZJtC1xJm55xz78YWdPcuYpwSpj8FsNe6rZrAjTl/9hom2iP4/MEvrTUkscZSHD1X9C81 VNYe9SBgALHMf49zUUHTfpFAnLDgAtDWZ6D3Urfo5ty8fh6kpJHkaJTqH5tPMz5lQG8L cS5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=DHV3P/OR2A7FDqAECp8ua+jqGSj1p5gToWOnrBS9ymU=; b=ec/PX69CYqGtcjljJGNfWQqOKlq5w8Kx1O9UWprrcHeSZxv0Juo0yGN1InXMbizKwj Pk0quHXG5FDx6PlGgp67xDp2VWcdeUNNYj1Th4VRuQNXsCS3gnehqn3zdoeWa4cLjOSk ZiXny29Zj30EkLqLzaHyVVbgzWy0qM3cuH2BeQ0MKlOxxk+F41BttUqZvcb7G5IgWZd+ 2K61ES/wDKAkdq9IZULx5qvTfB3UqiH7WYWh8rUlW1sH7+Pa3Yzng9gl6/cT1PLZq9r3 oV/V9e9C5h018O6a6jsW+MOdHG/dDeNG/9IKro223zTr2y7tDJIL+TB7sDWw9bVKdaSQ v7hQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=MWCO7a0S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j11-20020a170902690b00b001868ee3e594si2616330plk.409.2022.11.24.21.11.06; Thu, 24 Nov 2022 21:11:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=MWCO7a0S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229726AbiKYFJE (ORCPT + 99 others); Fri, 25 Nov 2022 00:09:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229716AbiKYFI5 (ORCPT ); Fri, 25 Nov 2022 00:08:57 -0500 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 648972A71F; Thu, 24 Nov 2022 21:08:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1669352933; x=1700888933; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=l6s5Zo+bMjQdENg18YdbOTnMLlT3vOWv+B9rkhLd0QQ=; b=MWCO7a0SelLB4W0ySwbdbesEd6hYVd2kpD1vJcRLta3cnsLdAjT4n9Dd OeEOVvVDDZMyL9YKxSKWT+ONtLy0903hfGOd9dKVzMxgg6rViIN46Mwgd +ArpYNXspVNqxoYPP0FQBSfTbSnyUhVaBqz0iDs56obp4Ca7QJ0RbIUpT i1CygVS618mqUqFnpostD/EIZI4t9E/AOvqYi3F3mAygE1U7REM4xDRad 2EALES/x9NKVqbU0qRmOo0pLYMbRVQXkaFWHaTUfdEfxfAdxVUubIJKkS JOMNQprkdYIqRN1zqGVjr3LDS9icTIbHjSRnUMgxa9cHfOzouVFQyun/o w==; X-IronPort-AV: E=Sophos;i="5.96,192,1665471600"; d="scan'208";a="185123055" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa4.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 24 Nov 2022 22:08:53 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Thu, 24 Nov 2022 22:08:42 -0700 Received: from microchip1-OptiPlex-9020.microchip.com (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Thu, 24 Nov 2022 22:08:40 -0700 From: shravan kumar To: , , CC: , , "Shravan Chippa" Subject: [PATCH v5 4/6] media: i2c: imx334: add default values in 3840x2160@60 array Date: Fri, 25 Nov 2022 10:38:05 +0530 Message-ID: <20221125050807.1857479-5-shravan.chippa@microchip.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221125050807.1857479-1-shravan.chippa@microchip.com> References: <20221125050807.1857479-1-shravan.chippa@microchip.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750443574117037254?= X-GMAIL-MSGID: =?utf-8?q?1750443574117037254?= From: Shravan Chippa -If we have only one mode there is no need to update camera reset(default) values when we initialize the camera -If we have mutipull modes in this case we need all value to write while camera initializing, so i will not effect other modes while shifting dynamically -All default values for 3840x2160@60 updated becouse if we change the mode we will not be able to recover the values, so add in mode_3840x2160_regs[] array Signed-off-by: Shravan Chippa --- drivers/media/i2c/imx334.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/drivers/media/i2c/imx334.c b/drivers/media/i2c/imx334.c index d3bb62c162b3..cd41df56ab7d 100644 --- a/drivers/media/i2c/imx334.c +++ b/drivers/media/i2c/imx334.c @@ -166,6 +166,7 @@ static const struct imx334_reg mode_3840x2160_regs[] = { {0x3288, 0x21}, {0x328a, 0x02}, {0x302c, 0x3c}, + {0x302d, 0x00}, {0x302e, 0x00}, {0x302f, 0x0f}, {0x3076, 0x70}, @@ -240,7 +241,26 @@ static const struct imx334_reg mode_3840x2160_regs[] = { {0x3794, 0x7a}, {0x3796, 0xa1}, {0x3e04, 0x0e}, + {0x319e, 0x00}, {0x3a00, 0x01}, + {0x3A18, 0xBF}, + {0x3A19, 0x00}, + {0x3A1A, 0x67}, + {0x3A1B, 0x00}, + {0x3A1C, 0x6F}, + {0x3A1D, 0x00}, + {0x3A1E, 0xD7}, + {0x3A1F, 0x01}, + {0x3A20, 0x6F}, + {0x3A21, 0x00}, + {0x3A22, 0xCF}, + {0x3A23, 0x00}, + {0x3A24, 0x6F}, + {0x3A25, 0x00}, + {0x3A26, 0xB7}, + {0x3A27, 0x00}, + {0x3A28, 0x5F}, + {0x3A29, 0x00}, }; /* Supported sensor mode configurations */ From patchwork Fri Nov 25 05:08:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: shravan chippa X-Patchwork-Id: 25820 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp3776070wrr; Thu, 24 Nov 2022 21:11:16 -0800 (PST) X-Google-Smtp-Source: AA0mqf4GEVU69ZjHGcxEoDfApLX7yDmA/PHLYe+R5llA52PClrk9M99oik4ajMOUS8BOMqJtGBvr X-Received: by 2002:a17:902:e886:b0:185:4ec3:c703 with SMTP id w6-20020a170902e88600b001854ec3c703mr18225348plg.165.1669353075926; Thu, 24 Nov 2022 21:11:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669353075; cv=none; d=google.com; s=arc-20160816; b=nnylbNA3WnCjWaUMfIqiaS8Cvk70izkEDsEfjugYaPSK6bfhEn6iQP2kYZjjGU1zLY M6xgHUYHiW5Y0WeqyUCSObQQqqRV+lM+UMxnNdvOnL3iXbLEXzC15t5o7efAuXUns6yb 14JXzWFi+GgDr7Qhh/LCcE03K6cEswbmbmQl8GNF/ul4twKn9q91J+S56WbGDxyt9Sbm MUvkjqNQ+D+RGIWYjOaEBpkJwoDj2+tJmVNWbhEEhBf4lzJolvvLpy0BXTQOiqzl5N1U IR68jH70akKb4zvqp9JAStN8FGWBgBUUOgy3j6WmQAfhU+2yBZys9VKGMqVm8yUZp8sn UDzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=WWgeP1Wr/XTMjiY1a4S+3SOtWkPN3cTp+04Mwlqdbpg=; b=yqicWLGw4Y3ruEeYpJoegQZWD0PAG58FuixoHm0oOAGRWJs6PLIIoWGRysSfQk7WD3 ky/arbS4YBuHgfTWvOPerweAMYtNcsBt6z+NDTc8lbX9mx8Dx2izyHI4GK6otnTbS+DK JqnCRwxa9lsIN9JR8vcgVo4R/W0/IomiXqy42lqqPWXwG+BaCMcX7lQoeSRwDaeFflZx np4FKONACNBzzpqjiRcIxWF9oAd5QlOEZMauSfKsc89S74PICoTjGQuMMcCMEsVp4VVQ SjkCeM9vh5dyf37G/rT7aTsJK2SXFVm4b/O5ko73XN7GAyrwvGORLqHC7UwDoQ+tgWaJ EzWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b="T/FPd68Q"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d22-20020aa78e56000000b0056e4c95266bsi2681548pfr.77.2022.11.24.21.11.03; Thu, 24 Nov 2022 21:11:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b="T/FPd68Q"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229531AbiKYFJI (ORCPT + 99 others); Fri, 25 Nov 2022 00:09:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229755AbiKYFJC (ORCPT ); Fri, 25 Nov 2022 00:09:02 -0500 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20DD82A439; Thu, 24 Nov 2022 21:08:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1669352939; x=1700888939; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=9D1vnO5xBixc/bGtzLQjYYzgzLTddzr3Frgq5iBT1Ss=; b=T/FPd68Qsr00t+4EE+tVYejQM3U7x8xzmjhNWRnsykcjq/Uy7HCH5tnf t/9Sr+kgrt+mHPxcd1eknljaSyZeKM3CsXuGMACOUU2Mq2HHeN3N0lx2L W1K1rymchtMvRPKn7WGOQ5sG4r56IHhJA7iEjoNwdb5sOUcYCvqzy07Vr Z4UnZj/fTc2LonRpUlKrsWUmEqXv8eHQyl7SLg5hhswRqfFkEeg3N4Dkp GsYks7dJr4Bcl/75a03LfUuN+msempmjCEWYOmP3tFuZeq8+JDLS1bYk3 ytjsHAVV7MMWrCAfbgBHOifYUL0jAp4tC+haDdxKNNLrMmna4UDI6A4FN w==; X-IronPort-AV: E=Sophos;i="5.96,192,1665471600"; d="scan'208";a="201346277" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa1.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 24 Nov 2022 22:08:57 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Thu, 24 Nov 2022 22:08:57 -0700 Received: from microchip1-OptiPlex-9020.microchip.com (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Thu, 24 Nov 2022 22:08:54 -0700 From: shravan kumar To: , , CC: , , "Shravan Chippa" , Conor Dooley , Prakash Battu Subject: [PATCH v5 5/6] media: i2c: imx334: support lower bandwidth mode Date: Fri, 25 Nov 2022 10:38:06 +0530 Message-ID: <20221125050807.1857479-6-shravan.chippa@microchip.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221125050807.1857479-1-shravan.chippa@microchip.com> References: <20221125050807.1857479-1-shravan.chippa@microchip.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750443570999810033?= X-GMAIL-MSGID: =?utf-8?q?1750443570999810033?= From: Shravan Chippa Some platforms may not be capable of supporting the bandwidth required for 12 bit or 3840x2160@60 resolutions. Add support for dynamically selecting 10 bit and 1920x1080@30 resolutions while leaving the existing configuration as default CC: Conor Dooley Signed-off-by: Prakash Battu Signed-off-by: Shravan Chippa --- drivers/media/i2c/imx334.c | 302 +++++++++++++++++++++++++++++++++---- 1 file changed, 276 insertions(+), 26 deletions(-) diff --git a/drivers/media/i2c/imx334.c b/drivers/media/i2c/imx334.c index cd41df56ab7d..0e5575604d87 100644 --- a/drivers/media/i2c/imx334.c +++ b/drivers/media/i2c/imx334.c @@ -79,7 +79,6 @@ struct imx334_reg_list { * struct imx334_mode - imx334 sensor mode structure * @width: Frame width * @height: Frame height - * @code: Format code * @hblank: Horizontal blanking in lines * @vblank: Vertical blanking in lines * @vblank_min: Minimal vertical blanking in lines @@ -91,7 +90,6 @@ struct imx334_reg_list { struct imx334_mode { u32 width; u32 height; - u32 code; u32 hblank; u32 vblank; u32 vblank_min; @@ -119,6 +117,7 @@ struct imx334_mode { * @vblank: Vertical blanking in lines * @cur_mode: Pointer to current selected sensor mode * @mutex: Mutex for serializing sensor controls + * @cur_code: current selected format code * @streaming: Flag indicating streaming state */ struct imx334 { @@ -140,6 +139,7 @@ struct imx334 { u32 vblank; const struct imx334_mode *cur_mode; struct mutex mutex; + u32 cur_code; bool streaming; }; @@ -147,6 +147,169 @@ static const s64 link_freq[] = { IMX334_LINK_FREQ, }; +/* Sensor mode registers */ +static const struct imx334_reg mode_1920x1080_regs[] = { + {0x3000, 0x01}, + {0x3018, 0x04}, + {0x3030, 0xCA}, + {0x3031, 0x08}, + {0x3032, 0x00}, + {0x3034, 0x4C}, + {0x3035, 0x04}, + {0x302C, 0xF0}, + {0x302D, 0x03}, + {0x302E, 0x80}, + {0x302F, 0x07}, + {0x3074, 0xCC}, + {0x3075, 0x02}, + {0x308E, 0xCD}, + {0x308F, 0x02}, + {0x3076, 0x38}, + {0x3077, 0x04}, + {0x3090, 0x38}, + {0x3091, 0x04}, + {0x3308, 0x38}, + {0x3309, 0x04}, + {0x30C6, 0x00}, + {0x30C7, 0x00}, + {0x30CE, 0x00}, + {0x30CF, 0x00}, + {0x30D8, 0x18}, + {0x30D9, 0x0A}, + {0x304C, 0x00}, + {0x304E, 0x00}, + {0x304F, 0x00}, + {0x3050, 0x00}, + {0x30B6, 0x00}, + {0x30B7, 0x00}, + {0x3116, 0x08}, + {0x3117, 0x00}, + {0x31A0, 0x20}, + {0x31A1, 0x0F}, + {0x300C, 0x3B}, + {0x300D, 0x29}, + {0x314C, 0x29}, + {0x314D, 0x01}, + {0x315A, 0x06}, + {0x3168, 0xA0}, + {0x316A, 0x7E}, + {0x319E, 0x02}, + {0x3199, 0x00}, + {0x319D, 0x00}, + {0x31DD, 0x03}, + {0x3300, 0x00}, + {0x341C, 0xFF}, + {0x341D, 0x01}, + {0x3A01, 0x03}, + {0x3A18, 0x7F}, + {0x3A19, 0x00}, + {0x3A1A, 0x37}, + {0x3A1B, 0x00}, + {0x3A1C, 0x37}, + {0x3A1D, 0x00}, + {0x3A1E, 0xF7}, + {0x3A1F, 0x00}, + {0x3A20, 0x3F}, + {0x3A21, 0x00}, + {0x3A20, 0x6F}, + {0x3A21, 0x00}, + {0x3A20, 0x3F}, + {0x3A21, 0x00}, + {0x3A20, 0x5F}, + {0x3A21, 0x00}, + {0x3A20, 0x2F}, + {0x3A21, 0x00}, + {0x3078, 0x02}, + {0x3079, 0x00}, + {0x307A, 0x00}, + {0x307B, 0x00}, + {0x3080, 0x02}, + {0x3081, 0x00}, + {0x3082, 0x00}, + {0x3083, 0x00}, + {0x3088, 0x02}, + {0x3094, 0x00}, + {0x3095, 0x00}, + {0x3096, 0x00}, + {0x309B, 0x02}, + {0x309C, 0x00}, + {0x309D, 0x00}, + {0x309E, 0x00}, + {0x30A4, 0x00}, + {0x30A5, 0x00}, + {0x3288, 0x21}, + {0x328A, 0x02}, + {0x3414, 0x05}, + {0x3416, 0x18}, + {0x35AC, 0x0E}, + {0x3648, 0x01}, + {0x364A, 0x04}, + {0x364C, 0x04}, + {0x3678, 0x01}, + {0x367C, 0x31}, + {0x367E, 0x31}, + {0x3708, 0x02}, + {0x3714, 0x01}, + {0x3715, 0x02}, + {0x3716, 0x02}, + {0x3717, 0x02}, + {0x371C, 0x3D}, + {0x371D, 0x3F}, + {0x372C, 0x00}, + {0x372D, 0x00}, + {0x372E, 0x46}, + {0x372F, 0x00}, + {0x3730, 0x89}, + {0x3731, 0x00}, + {0x3732, 0x08}, + {0x3733, 0x01}, + {0x3734, 0xFE}, + {0x3735, 0x05}, + {0x375D, 0x00}, + {0x375E, 0x00}, + {0x375F, 0x61}, + {0x3760, 0x06}, + {0x3768, 0x1B}, + {0x3769, 0x1B}, + {0x376A, 0x1A}, + {0x376B, 0x19}, + {0x376C, 0x18}, + {0x376D, 0x14}, + {0x376E, 0x0F}, + {0x3776, 0x00}, + {0x3777, 0x00}, + {0x3778, 0x46}, + {0x3779, 0x00}, + {0x377A, 0x08}, + {0x377B, 0x01}, + {0x377C, 0x45}, + {0x377D, 0x01}, + {0x377E, 0x23}, + {0x377F, 0x02}, + {0x3780, 0xD9}, + {0x3781, 0x03}, + {0x3782, 0xF5}, + {0x3783, 0x06}, + {0x3784, 0xA5}, + {0x3788, 0x0F}, + {0x378A, 0xD9}, + {0x378B, 0x03}, + {0x378C, 0xEB}, + {0x378D, 0x05}, + {0x378E, 0x87}, + {0x378F, 0x06}, + {0x3790, 0xF5}, + {0x3792, 0x43}, + {0x3794, 0x7A}, + {0x3796, 0xA1}, + {0x37B0, 0x37}, + {0x3E04, 0x0E}, + {0x30E8, 0x50}, + {0x30E9, 0x00}, + {0x3E04, 0x0E}, + {0x3002, 0x00}, +}; + /* Sensor mode registers */ static const struct imx334_reg mode_3840x2160_regs[] = { {0x3000, 0x01}, @@ -263,20 +426,56 @@ static const struct imx334_reg mode_3840x2160_regs[] = { {0x3A29, 0x00}, }; +static const struct imx334_reg raw10_framefmt_regs[] = { + {0x3050, 0x00}, + {0x319D, 0x00}, + {0x341C, 0xFF}, + {0x341D, 0x01}, +}; + +static const struct imx334_reg raw12_framefmt_regs[] = { + {0x3050, 0x01}, + {0x319D, 0x01}, + {0x341C, 0x47}, + {0x341D, 0x00}, +}; + +/* + * The supported BUS formats. + */ +static const u32 imx334_mbus_codes[] = { + MEDIA_BUS_FMT_SRGGB12_1X12, + MEDIA_BUS_FMT_SRGGB10_1X10, +}; + /* Supported sensor mode configurations */ -static const struct imx334_mode supported_mode = { - .width = 3840, - .height = 2160, - .hblank = 560, - .vblank = 2340, - .vblank_min = 90, - .vblank_max = 132840, - .pclk = 594000000, - .link_freq_idx = 0, - .code = MEDIA_BUS_FMT_SRGGB12_1X12, - .reg_list = { - .num_of_regs = ARRAY_SIZE(mode_3840x2160_regs), - .regs = mode_3840x2160_regs, +static const struct imx334_mode supported_modes[] = { + { + .width = 3840, + .height = 2160, + .hblank = 560, + .vblank = 2340, + .vblank_min = 90, + .vblank_max = 132840, + .pclk = 594000000, + .link_freq_idx = 0, + .reg_list = { + .num_of_regs = ARRAY_SIZE(mode_3840x2160_regs), + .regs = mode_3840x2160_regs, + }, + }, { + .width = 1920, + .height = 1080, + .hblank = 280, + .vblank = 1170, + .vblank_min = 90, + .vblank_max = 132840, + .pclk = 74250000, + .link_freq_idx = 0, + .reg_list = { + .num_of_regs = ARRAY_SIZE(mode_1920x1080_regs), + .regs = mode_1920x1080_regs, + }, }, }; @@ -527,10 +726,10 @@ static int imx334_enum_mbus_code(struct v4l2_subdev *sd, struct v4l2_subdev_state *sd_state, struct v4l2_subdev_mbus_code_enum *code) { - if (code->index > 0) + if (code->index >= ARRAY_SIZE(imx334_mbus_codes)) return -EINVAL; - code->code = supported_mode.code; + code->code = imx334_mbus_codes[code->index]; return 0; } @@ -547,15 +746,22 @@ static int imx334_enum_frame_size(struct v4l2_subdev *sd, struct v4l2_subdev_state *sd_state, struct v4l2_subdev_frame_size_enum *fsize) { - if (fsize->index > 0) + unsigned int i; + + if (fsize->index >= ARRAY_SIZE(supported_modes)) return -EINVAL; - if (fsize->code != supported_mode.code) + for (i = 0; i < ARRAY_SIZE(imx334_mbus_codes); ++i) { + if (imx334_mbus_codes[i] == fsize->code) + break; + } + + if (i == ARRAY_SIZE(imx334_mbus_codes)) return -EINVAL; - fsize->min_width = supported_mode.width; + fsize->min_width = supported_modes[fsize->index].width; fsize->max_width = fsize->min_width; - fsize->min_height = supported_mode.height; + fsize->min_height = supported_modes[fsize->index].height; fsize->max_height = fsize->min_height; return 0; @@ -574,7 +780,6 @@ static void imx334_fill_pad_format(struct imx334 *imx334, { fmt->format.width = mode->width; fmt->format.height = mode->height; - fmt->format.code = mode->code; fmt->format.field = V4L2_FIELD_NONE; fmt->format.colorspace = V4L2_COLORSPACE_RAW; fmt->format.ycbcr_enc = V4L2_YCBCR_ENC_DEFAULT; @@ -612,6 +817,21 @@ static int imx334_get_pad_format(struct v4l2_subdev *sd, return 0; } +static int imx334_get_format_code(struct imx334 *imx334, struct v4l2_subdev_format *fmt) +{ + unsigned int i; + + for (i = 0; i < ARRAY_SIZE(imx334_mbus_codes); i++) { + if (imx334_mbus_codes[i] == fmt->format.code) + break; + } + + if (i >= ARRAY_SIZE(imx334_mbus_codes)) + i = 0; + + return imx334_mbus_codes[i]; +} + /** * imx334_set_pad_format() - Set subdevice pad format * @sd: pointer to imx334 V4L2 sub-device structure @@ -630,7 +850,13 @@ static int imx334_set_pad_format(struct v4l2_subdev *sd, mutex_lock(&imx334->mutex); - mode = &supported_mode; + fmt->format.code = imx334_get_format_code(imx334, fmt); + + mode = v4l2_find_nearest_size(supported_modes, + ARRAY_SIZE(supported_modes), + width, height, + fmt->format.width, fmt->format.height); + imx334_fill_pad_format(imx334, mode, fmt); if (fmt->which == V4L2_SUBDEV_FORMAT_TRY) { @@ -638,7 +864,8 @@ static int imx334_set_pad_format(struct v4l2_subdev *sd, framefmt = v4l2_subdev_get_try_format(sd, sd_state, fmt->pad); *framefmt = fmt->format; - } else { + } else if (imx334->cur_mode != mode || imx334->cur_code != fmt->format.code) { + imx334->cur_code = fmt->format.code; ret = imx334_update_controls(imx334, mode); if (!ret) imx334->cur_mode = mode; @@ -663,11 +890,26 @@ static int imx334_init_pad_cfg(struct v4l2_subdev *sd, struct v4l2_subdev_format fmt = { 0 }; fmt.which = sd_state ? V4L2_SUBDEV_FORMAT_TRY : V4L2_SUBDEV_FORMAT_ACTIVE; - imx334_fill_pad_format(imx334, &supported_mode, &fmt); + imx334_fill_pad_format(imx334, &supported_modes[0], &fmt); return imx334_set_pad_format(sd, sd_state, &fmt); } +static int imx334_set_framefmt(struct imx334 *imx334) +{ + switch (imx334->cur_code) { + case MEDIA_BUS_FMT_SRGGB10_1X10: + return imx334_write_regs(imx334, raw10_framefmt_regs, + ARRAY_SIZE(raw10_framefmt_regs)); + + case MEDIA_BUS_FMT_SRGGB12_1X12: + return imx334_write_regs(imx334, raw12_framefmt_regs, + ARRAY_SIZE(raw12_framefmt_regs)); + } + + return -EINVAL; +} + /** * imx334_start_streaming() - Start sensor stream * @imx334: pointer to imx334 device @@ -688,6 +930,13 @@ static int imx334_start_streaming(struct imx334 *imx334) return ret; } + ret = imx334_set_framefmt(imx334); + if (ret) { + dev_err(imx334->dev, "%s failed to set frame format: %d\n", + __func__, ret); + return ret; + } + /* Setup handler will write actual exposure and gain */ ret = __v4l2_ctrl_handler_setup(imx334->sd.ctrl_handler); if (ret) { @@ -1058,7 +1307,8 @@ static int imx334_probe(struct i2c_client *client) } /* Set default mode to max resolution */ - imx334->cur_mode = &supported_mode; + imx334->cur_mode = &supported_modes[0]; + imx334->cur_code = imx334_mbus_codes[0]; imx334->vblank = imx334->cur_mode->vblank; ret = imx334_init_controls(imx334); From patchwork Fri Nov 25 05:08:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: shravan chippa X-Patchwork-Id: 25823 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp3776757wrr; Thu, 24 Nov 2022 21:13:03 -0800 (PST) X-Google-Smtp-Source: AA0mqf4k35AF1H7HLtZxob9FeP7PfuxmL/JXikKDULeTkFIyAmW2ZaXdkrK//owN2YKKn4b2XB7/ X-Received: by 2002:a17:90a:5d08:b0:218:770c:9a40 with SMTP id s8-20020a17090a5d0800b00218770c9a40mr21657526pji.158.1669353183227; Thu, 24 Nov 2022 21:13:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669353183; cv=none; d=google.com; s=arc-20160816; b=HPL7wuSdQq83WG9PAg1lqk9hqjJPrlLajqjKZztn0tLRMS67RoqAzivrA/Q/A0wRSG hOM0M22WishtyyCOGofuYo+MnpQCmruBKIbe3/+h4leVyv6UDZgHr87BXaK+Fi8JpuZd JAuJEQMLSxIPRiQ7tfKDaO0adUmD4O26KJOPOrmg5xSSek5Ome/pQ/HiW4iCk1a4jIOW GO/sN1C6C3ZudhifgYKzjfyFgE91Beot6FdemZYpd77YDVajxNXX14ox8LGsSMU1STOC xuGMRyFDBj2up7rIH/kcGfiTDRg3RJLnxDQEXM8Qyy08ensc1tlhrlvNKMhGmcRuxzTC LipQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=HulUvQDP3Yo2K+EA3YnkFq6QTTFDox7hhmYSVQbx6Nk=; b=B+Wdeg+44DSqlfIIeXn4Ch1MTAeBhsPm+nOTYRYQmnCqQvLa6LEeCu3/mX4v3oFfmR 3x5xZ+ONkHG5dB1i4W5t8iCnMtC1fwmQo0mQsCJ8GQxcOaPc74Ljj6+TjkqsMBalGYsw EB6uEZfOrR75pvPV6mmT24GTOjhwwDjacE/D0D60WrQVx9QIwkLyKXWIqaksdKTCSCZu uIdFfPannPH//5vu6dc7wDPebe/AMxSXaMNmrkxBnHFXZUzQG/5aOC2OKrNyuInFFNCn m5LBVY49QQ38n4Heg4HQi8742TKvnmASrUrXgTVpw7fjS6PuNtfxmgPD0xvQ8z3gw3+D rpqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b="WfDy/eKG"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q11-20020a656a8b000000b0046ec7beb578si2946050pgu.94.2022.11.24.21.12.50; Thu, 24 Nov 2022 21:13:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b="WfDy/eKG"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229658AbiKYFJR (ORCPT + 99 others); Fri, 25 Nov 2022 00:09:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229695AbiKYFJE (ORCPT ); Fri, 25 Nov 2022 00:09:04 -0500 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB48028727; Thu, 24 Nov 2022 21:09:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1669352944; x=1700888944; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=GMVRwSHQ1d1bppR8aOD0mgZ9k9ac8N+YUIDRalV7lhM=; b=WfDy/eKGqfqKvwKKd0X5RS2nIj2/UD4EbcJFBQHBhy5dRGF8/dlPIwH6 lfrNyyxdyl+OjZhdFmaTIMdGb2z2CLBy/ccQ6MKCJi7FjzC6/Bar2QIEP dlm+/Kq9IJ7g99Of0fiRcuCiAff8dc6fEJe5Az9EkEz6ocZ6PSm1r6pYn MahK9PS20iS/3/DgWnNd+ULM6w8tJJeoIis2YyMkk60rrsdslOOTG18bD wb08N8s0bpLb/a8hZOeOxMBfqae33vq3qdKj2V3DaIIa81l6WpM+b2B6I aHIFEIbBEMsdbi6I4PLJDCMjKYJsC6X7kA81gT3+9vD/+pVwm8fNVMUH0 Q==; X-IronPort-AV: E=Sophos;i="5.96,192,1665471600"; d="scan'208";a="185123096" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa4.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 24 Nov 2022 22:09:03 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Thu, 24 Nov 2022 22:09:02 -0700 Received: from microchip1-OptiPlex-9020.microchip.com (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Thu, 24 Nov 2022 22:09:00 -0700 From: shravan kumar To: , , CC: , , "Shravan Chippa" , Sakari Ailus Subject: [PATCH v5 6/6] media: i2c: imx334: updating pixel and link frequency Date: Fri, 25 Nov 2022 10:38:07 +0530 Message-ID: <20221125050807.1857479-7-shravan.chippa@microchip.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221125050807.1857479-1-shravan.chippa@microchip.com> References: <20221125050807.1857479-1-shravan.chippa@microchip.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750443683103194242?= X-GMAIL-MSGID: =?utf-8?q?1750443683103194242?= From: Shravan Chippa -Update pixel_rate and link frequency for 1920x1080@30 Add dummy ctrl cases for pixel_rate and link frequency to avoid error while changing the modes dynamically Suggested-by: Sakari Ailus Signed-off-by: Shravan Chippa --- drivers/media/i2c/imx334.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/imx334.c b/drivers/media/i2c/imx334.c index 0e5575604d87..ec77835d94a2 100644 --- a/drivers/media/i2c/imx334.c +++ b/drivers/media/i2c/imx334.c @@ -50,6 +50,7 @@ /* CSI2 HW configuration */ #define IMX334_LINK_FREQ 1782000000 +#define IMX334_LINK_FREQ_891M 891000000 #define IMX334_NUM_DATA_LANES 4 #define IMX334_REG_MIN 0x00 @@ -145,6 +146,7 @@ struct imx334 { static const s64 link_freq[] = { IMX334_LINK_FREQ, + IMX334_LINK_FREQ_891M, }; /* Sensor mode registers */ @@ -471,7 +473,7 @@ static const struct imx334_mode supported_modes[] = { .vblank_min = 90, .vblank_max = 132840, .pclk = 74250000, - .link_freq_idx = 0, + .link_freq_idx = 1, .reg_list = { .num_of_regs = ARRAY_SIZE(mode_1920x1080_regs), .regs = mode_1920x1080_regs, @@ -601,6 +603,11 @@ static int imx334_update_controls(struct imx334 *imx334, if (ret) return ret; + ret = __v4l2_ctrl_modify_range(imx334->pclk_ctrl, mode->pclk, + mode->pclk, 1, mode->pclk); + if (ret) + return ret; + ret = __v4l2_ctrl_modify_range(imx334->hblank_ctrl, IMX334_REG_MIN, IMX334_REG_MAX, 1, mode->hblank); if (ret) @@ -700,6 +707,10 @@ static int imx334_set_ctrl(struct v4l2_ctrl *ctrl) pm_runtime_put(imx334->dev); + break; + case V4L2_CID_PIXEL_RATE: + case V4L2_CID_LINK_FREQ: + ret = 0; break; default: dev_err(imx334->dev, "Invalid control %d", ctrl->id);