From patchwork Fri Nov 25 04:11:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jammy Huang X-Patchwork-Id: 25808 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp3764774wrr; Thu, 24 Nov 2022 20:37:22 -0800 (PST) X-Google-Smtp-Source: AA0mqf5cIwmF+FnT44nEH/8HDL/lbvzXbZZU1z2m/f52V+2QJ9KV4WK0rm1dcDmqi02ENXRFU3tE X-Received: by 2002:a17:906:fca7:b0:7ae:9677:d8dd with SMTP id qw7-20020a170906fca700b007ae9677d8ddmr13814440ejb.71.1669351042193; Thu, 24 Nov 2022 20:37:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669351042; cv=none; d=google.com; s=arc-20160816; b=by+Wjx6xg+QNdwQIVBSPqU8Gi0/oe8AubIRSZXXPbxduXwbvxAb1vNrKLK6zsm+yjT haPipgNZOK3rAcNTy5ROph0T2MWNTvzkEjmLajTOjptgzvOkymlQaxZ0eRxBMyr0A3ng ODZDG0D10NozbHZGCAEHhXlir/+YXp09+Sa6dAS1UeaSwYXse7t2ZVyTf5BEvlnsSHig nOU7oRgXdwOqBgaF11ZkavieQRI0tad/pkbW2EuPe3g07sq3Q8ej6BSW8/hAdTU4C4ae 033vLAvvmJR0hYFUSX5Dp0flS8ZScT0Db0EkYzibqpc3XSt7UMVSX/pKJU6I1Xc3f3Gh 1AYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:to:from; bh=dQoy7SiyswawhfA0tYd4wCb+O+Yjf81S6ZOKnnQXz0U=; b=bvN472hQvG1QvMEm5HpX96OHRhw4Nd3ZrUoJsQmubD9eoOQcQxlYpYRj3xlGsQwLYQ 48owQAQtf4j2nY9TOoKsC0rlrrk/X1YGcPqC1iUS7nf+zQzEgaPKu330WypWrBGNG/Y4 8CAchBI7vZP4+MWIKE5awDGM+fNUFX1gQazBcALe7aap3luAgbxh+DovXWgcK29QaTEX 6mayGk++zQZbcoCu9w9Xml18/cfqjFmcmq5MT8ChswhDTlmdFzr1/FGQJg2YZfSQaX6H D/kHNXdUCIgDuuQki4/ZJunepOs1P9aCcXd+pyJKhDY1KWTqxVlKEFa7KO1RW7URFNXZ MWrQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id js14-20020a17090797ce00b007ae4c686a4esi2811769ejc.159.2022.11.24.20.36.58; Thu, 24 Nov 2022 20:37:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229607AbiKYEM1 (ORCPT + 99 others); Thu, 24 Nov 2022 23:12:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229450AbiKYEM0 (ORCPT ); Thu, 24 Nov 2022 23:12:26 -0500 Received: from twspam01.aspeedtech.com (twspam01.aspeedtech.com [211.20.114.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A149228E07; Thu, 24 Nov 2022 20:12:24 -0800 (PST) Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 2AP3l7uD037493; Fri, 25 Nov 2022 11:47:07 +0800 (GMT-8) (envelope-from jammy_huang@aspeedtech.com) Received: from JammyHuang-PC.aspeed.com (192.168.2.115) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 25 Nov 2022 12:11:36 +0800 From: Jammy Huang To: , , , , , , , , , , Subject: [PATCH v2] media: aspeed: Use v4l2_dbg to replace v4l2_warn to avoid log spam Date: Fri, 25 Nov 2022 12:11:51 +0800 Message-ID: <20221125041151.12957-1-jammy_huang@aspeedtech.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [192.168.2.115] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 2AP3l7uD037493 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749103014082482785?= X-GMAIL-MSGID: =?utf-8?q?1750441438351716342?= If the host is powered off, there will be many warning log: [ 335.526279] aspeed-video 1e700000.video: Timed out; first mode detect [ 335.544172] aspeed-video 1e700000.video: No signal; don't start frame [ 337.165555] aspeed-video 1e700000.video: Timed out; first mode detect [ 337.186214] aspeed-video 1e700000.video: No signal; don't start frame [ 338.815501] aspeed-video 1e700000.video: Timed out; first mode detect [ 338.834008] aspeed-video 1e700000.video: No signal; don't start frame To avoid the log spam in this condition, replace v4l2_warn with v4l2_dbg. Link: https://lore.kernel.org/openbmc/Y1dX9r9ybGjBrW0k@hatter.bewilderbeest.net/ Reported by: Zev Weiss Signed-off-by: Jammy Huang --- v2: - update commit message --- drivers/media/platform/aspeed/aspeed-video.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) base-commit: 08ad43d554bacb9769c6a69d5f771f02f5ba411c prerequisite-patch-id: bf47e8ab2998acfbc32be5a4b7b5ae8a3ae4218b prerequisite-patch-id: bf82715983e08f2e810ff1a82ce644f5f9006cd9 prerequisite-patch-id: 28a2040ef0235e5765f05d2fc5529bce2a0f4c6f prerequisite-patch-id: 7e761c779730536db8baf50db5fc8caf058e95af prerequisite-patch-id: c48ea20973fa35938a7d33a0e20d2900df48755f diff --git a/drivers/media/platform/aspeed/aspeed-video.c b/drivers/media/platform/aspeed/aspeed-video.c index cf76aeee8cb6..662465d13a0e 100644 --- a/drivers/media/platform/aspeed/aspeed-video.c +++ b/drivers/media/platform/aspeed/aspeed-video.c @@ -586,13 +586,13 @@ static int aspeed_video_start_frame(struct aspeed_video *video) bool bcd_buf_need = (video->format != VIDEO_FMT_STANDARD); if (video->v4l2_input_status) { - v4l2_warn(&video->v4l2_dev, "No signal; don't start frame\n"); + v4l2_dbg(1, debug, &video->v4l2_dev, "No signal; don't start frame\n"); return 0; } if (!(seq_ctrl & VE_SEQ_CTRL_COMP_BUSY) || !(seq_ctrl & VE_SEQ_CTRL_CAP_BUSY)) { - v4l2_warn(&video->v4l2_dev, "Engine busy; don't start frame\n"); + v4l2_dbg(1, debug, &video->v4l2_dev, "Engine busy; don't start frame\n"); return -EBUSY; } @@ -615,7 +615,7 @@ static int aspeed_video_start_frame(struct aspeed_video *video) struct aspeed_video_buffer, link); if (!buf) { spin_unlock_irqrestore(&video->lock, flags); - v4l2_warn(&video->v4l2_dev, "No buffers; don't start frame\n"); + v4l2_dbg(1, debug, &video->v4l2_dev, "No buffers; don't start frame\n"); return -EPROTO; } @@ -796,7 +796,7 @@ static irqreturn_t aspeed_video_irq(int irq, void *arg) if (video->format == VIDEO_FMT_STANDARD && list_is_last(&buf->link, &video->buffers)) { empty = false; - v4l2_warn(&video->v4l2_dev, "skip to keep last frame updated\n"); + v4l2_dbg(1, debug, &video->v4l2_dev, "skip to keep last frame updated\n"); } else { buf->vb.vb2_buf.timestamp = ktime_get_ns(); buf->vb.sequence = video->sequence++; @@ -1060,7 +1060,7 @@ static void aspeed_video_get_resolution(struct aspeed_video *video) res_check(video), MODE_DETECT_TIMEOUT); if (!rc) { - v4l2_warn(&video->v4l2_dev, "Timed out; first mode detect\n"); + v4l2_dbg(1, debug, &video->v4l2_dev, "Timed out; first mode detect\n"); clear_bit(VIDEO_RES_DETECT, &video->flags); return; } @@ -1081,7 +1081,7 @@ static void aspeed_video_get_resolution(struct aspeed_video *video) MODE_DETECT_TIMEOUT); clear_bit(VIDEO_RES_DETECT, &video->flags); if (!rc) { - v4l2_warn(&video->v4l2_dev, "Timed out; second mode detect\n"); + v4l2_dbg(1, debug, &video->v4l2_dev, "Timed out; second mode detect\n"); return; } @@ -1104,7 +1104,7 @@ static void aspeed_video_get_resolution(struct aspeed_video *video) } while (invalid_resolution && (tries++ < INVALID_RESOLUTION_RETRIES)); if (invalid_resolution) { - v4l2_warn(&video->v4l2_dev, "Invalid resolution detected\n"); + v4l2_dbg(1, debug, &video->v4l2_dev, "Invalid resolution detected\n"); return; } @@ -1856,7 +1856,7 @@ static void aspeed_video_stop_streaming(struct vb2_queue *q) !test_bit(VIDEO_FRAME_INPRG, &video->flags), STOP_TIMEOUT); if (!rc) { - v4l2_warn(&video->v4l2_dev, "Timed out when stopping streaming\n"); + v4l2_dbg(1, debug, &video->v4l2_dev, "Timed out when stopping streaming\n"); /* * Need to force stop any DMA and try and get HW into a good