From patchwork Thu Nov 24 18:48:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 25691 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp3567996wrr; Thu, 24 Nov 2022 11:09:36 -0800 (PST) X-Google-Smtp-Source: AA0mqf6Ekb+BbIQ5eVzxynaWbOWlGdmrCFpfPPdLV1DOMXggmFGJU3adF3Tl/iJKJWw1qCA3yx1Z X-Received: by 2002:a62:6205:0:b0:56c:14a5:2245 with SMTP id w5-20020a626205000000b0056c14a52245mr14859240pfb.12.1669316976238; Thu, 24 Nov 2022 11:09:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669316976; cv=none; d=google.com; s=arc-20160816; b=gYb1P7qn1WCTA7TUZMJ5Hjurwva83s2spRTbrf7m+LUXZJzaeWJTBPeIkCRCNHg2m4 +rXTHTvZRIZvW0pSGfBwOhBQ7E9oWJr16oydbxQcLxfELXvVv/2Kxp9vjpzIWm9RWgYf n1v33XDGxIJcMeQihB47VagmRPVHxNuwPrm38w5UULIdtRYk/AvGlThPC7xHeljjqqjS iedToJDyh+Mo8EnXtqdVU63p7fitQSZMqZhS+L9hEMs24bUJpc+or8gPNxRxWg7PB82b 9LbUqt0XE9q0BLdh7ot7NTSaraPOfRwTUvagraXEWB2/aDPLsbJptMqHHuHspVWfm7Q5 jSYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Wjk3sqmgMxqXp1nGcgFyZuyRB+dxkPBAQA8BdY2V3lM=; b=bI0DYmjQFwxuUc8d19NNq35EHG9vFAKoXMqtRzHhPlx0aiFnjtzMBQik+thlRxSpZ9 lmtBR/uzJ+m5NR7APkToN9vyQD5EMtwtMHSo/ufCcc7rUpZYq5c6zE4qtKvzoBO42g3g m44g0Km0T/snnfj+Az0dY5rwQpJjSVeocBkoHey9p+HvQNPSwWMHDCYrm9GvGIDDvhbD KJ196szT+VdXnS0T2FUipzyiwO1Hsozkw3dXMI66Bz6WYDat6n2Ux1K+kvSfKkhmO8jE 0KYGoamvYXas56UjWOAGBiqHZtOgkme5EZ7lmdIMKjSUlLH5rLDQg09UaqF07ClUgi9S xxzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=FUyjQmbt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 21-20020a631355000000b0046ff26f21f0si1846563pgt.503.2022.11.24.11.09.20; Thu, 24 Nov 2022 11:09:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=FUyjQmbt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229653AbiKXSsY (ORCPT + 99 others); Thu, 24 Nov 2022 13:48:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229580AbiKXSsW (ORCPT ); Thu, 24 Nov 2022 13:48:22 -0500 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B867D65A5 for ; Thu, 24 Nov 2022 10:48:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669315701; x=1700851701; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=qxZ51m9u691OKiCL/ysfXIXNDKj1rsv+8wIP0koy6OA=; b=FUyjQmbtWsolF2oBr0oPVOGBif+Fz/jGoudhlPKd96lRs2I3/SdIPfRR uZnPbSePfUYihsF3UTC+4cD4nQRwgE9jTChp8h4eUhnwX4SG2YA/4eSwx 78ssq8QaSznKU7XpTr01xZfbfE+xVXmwXXJE1TRKGRmTFCucSAi7OphrW Q8dCqEDrXzKvl1LYkgO1iUdNP3bgx4kpaaDldqCZ7jKpNb9Ob+tUqk5v1 a+TUgXf5gOkthUT5gUTSTsMLvPM5EWDzTopUqFiGMz7rE84YxbmPera8W gVayQL1lalnl7X7L/Nda30QToDcAXEZ7ZeRWNCPo3xrmBF7acb0ynm4YF A==; X-IronPort-AV: E=McAfee;i="6500,9779,10541"; a="313051827" X-IronPort-AV: E=Sophos;i="5.96,190,1665471600"; d="scan'208";a="313051827" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2022 10:48:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10541"; a="711044940" X-IronPort-AV: E=Sophos;i="5.96,190,1665471600"; d="scan'208";a="711044940" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 24 Nov 2022 10:48:19 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 26F49128; Thu, 24 Nov 2022 20:48:45 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , linux-kernel@vger.kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Rob Herring Subject: [PATCH v1 1/1] x86/of: Remove unused early_init_dt_add_memory_arch() Date: Thu, 24 Nov 2022 20:48:24 +0200 Message-Id: <20221124184824.9548-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750405717846428383?= X-GMAIL-MSGID: =?utf-8?q?1750405717846428383?= Recently the objtool starts complaining on the dead code in the object files, in particular vmlinux.o: warning: objtool: early_init_dt_scan_memory+0x191: unreachable instruction when CONFIG_OF=y. Indeed, the entire early_init_dt_scan() is not used on x86 and making it compile (with help of CONFIG_OF) will abrupt the code flow since in the middle of it we have a BUG() instruction. Remove the entire culprit function to make objtool happy. Signed-off-by: Andy Shevchenko --- arch/x86/kernel/devicetree.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/arch/x86/kernel/devicetree.c b/arch/x86/kernel/devicetree.c index 5cd51f25f446..59438d2b204c 100644 --- a/arch/x86/kernel/devicetree.c +++ b/arch/x86/kernel/devicetree.c @@ -31,11 +31,6 @@ char __initdata cmd_line[COMMAND_LINE_SIZE]; int __initdata of_ioapic; -void __init early_init_dt_add_memory_arch(u64 base, u64 size) -{ - BUG(); -} - void __init add_dtb(u64 data) { initial_dtb = data + offsetof(struct setup_data, data);