From patchwork Thu Nov 24 13:16:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean Delvare X-Patchwork-Id: 25530 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp3396959wrr; Thu, 24 Nov 2022 05:29:01 -0800 (PST) X-Google-Smtp-Source: AA0mqf5jZkKbgEHm1Z2O0BiEGvKBYyjhJSxG6tLd3KF2Z0dHDy66Z1au2Z4cQ6W7ag4PTOHZsmkw X-Received: by 2002:a17:906:f8cc:b0:7ad:92fa:589e with SMTP id lh12-20020a170906f8cc00b007ad92fa589emr11130483ejb.668.1669296540965; Thu, 24 Nov 2022 05:29:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669296540; cv=none; d=google.com; s=arc-20160816; b=e/U2q9w0g2Ls3zFy0zn2ixkMvyNn78zvE7K69jeSb/I4nQ3kV3FjLqSwLSAqqYnRz+ I8WQK68Wf2dssZs37E4Rc/EfiCZxoqkbdBtpkV/a819sg1sTlV7l2IQT5f6POGH5mVzb Te1zJ1pMxs3vAE4bRVauNDiVVWWB8GSwQA4StAmGGlFpVh2riCi9jljsrEJY1snj7AmN zV72LzYFyuwXuCSds+paU+SoZ47O46OeuFIw7OC2Wjc11ep4zzASiSJSK2aphwlSGQn0 qW+XfB42nmQ/CIyC0ERaHw7IoUerRlVRL5IcxG2SUI1wYB+0o0TsPqjAywd5NarbeRAQ c4Bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature; bh=DTq9mK8VryLtbjZZAvH3we6XnRn6OtTrekdTcapv/l8=; b=vLnkHyltNkX/XH/ddjvTiig+yosCuD4yjtPYgDkwb50BIUQjs4/MSZuLzMbB4abqE4 1miJr8JMhbch+b7C6pERzoXy3qzLj2ndDTWHYxXjd/sSYmMOhzq2Wt/9la1tqiUWEVKd sIHNXzRe3XYbi39Cd8huyVx+TphbjiU5VlrEZ/MMD/iW1dp24M0JWrcSx5RaUo9PJ9lU 2dOcMy2RTgUDx2HWVeij61SOfbnhvUhfIRPAFr7mXD+FpQXhReC1+VA3SdiqAMb7WFCB 207ATy8oB/IAChHfnfYCbaOyOL4k14Hdm+P/nzU5OE9w9Zk880lb29LZLT5XUBd/2U0i Skuw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="JGHx/Vzm"; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=3w3QYFQf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t23-20020a50ab57000000b0046363151bd1si534500edc.615.2022.11.24.05.28.34; Thu, 24 Nov 2022 05:29:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="JGHx/Vzm"; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=3w3QYFQf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229502AbiKXNQL (ORCPT + 99 others); Thu, 24 Nov 2022 08:16:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229379AbiKXNQK (ORCPT ); Thu, 24 Nov 2022 08:16:10 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB492F3937; Thu, 24 Nov 2022 05:16:07 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 74E7E1F6E6; Thu, 24 Nov 2022 13:16:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1669295766; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DTq9mK8VryLtbjZZAvH3we6XnRn6OtTrekdTcapv/l8=; b=JGHx/Vzm8iMeeco2EUjZhBy3Dm/bAuWC/r8DILvMltgPfyNvvrxcjDeOyYX8SkJysecsqC 0Ozc5TiUx/a1MN+/j1MIhvxXHujgZTIwYyjcxpiDNDnandnJoEGwvb/DLEzrB2R54YPgAl 5OrrEpbLV2+41q5+xcW9GjBLz0Z2AFI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1669295766; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DTq9mK8VryLtbjZZAvH3we6XnRn6OtTrekdTcapv/l8=; b=3w3QYFQfEMqpWgOhTx5Ft+Kb26w13b0GalTNfEuabZMqAMwSo6N5U7AG/6w4muHkASanTI GNT7pFI6HZevcyCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C8B8113B4F; Thu, 24 Nov 2022 13:16:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id wuYBLJVuf2NnIAAAMHmgww (envelope-from ); Thu, 24 Nov 2022 13:16:05 +0000 Date: Thu, 24 Nov 2022 14:16:04 +0100 From: Jean Delvare To: linux-can@vger.kernel.org, LKML Cc: Pavel Pisa , Ondrej Ille Subject: [PATCH] can: ctucanfd: Drop obsolete dependency on COMPILE_TEST Message-ID: <20221124141604.4265225f@endymion.delvare> Organization: SUSE Linux X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750384289510668153?= X-GMAIL-MSGID: =?utf-8?q?1750384289510668153?= Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it is possible to test-build any driver which depends on OF on any architecture by explicitly selecting OF. Therefore depending on COMPILE_TEST as an alternative is no longer needed. It is actually better to always build such drivers with OF enabled, so that the test builds are closer to how each driver will actually be built on its intended target. Building them without OF may not test much as the compiler will optimize out potentially large parts of the code. In the worst case, this could even pop false positive warnings. Dropping COMPILE_TEST here improves the quality of our testing and avoids wasting time on non-existent issues. Signed-off-by: Jean Delvare Cc: Pavel Pisa Cc: Ondrej Ille Acked-by: Pavel Pisa --- drivers/net/can/ctucanfd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-6.0.orig/drivers/net/can/ctucanfd/Kconfig +++ linux-6.0/drivers/net/can/ctucanfd/Kconfig @@ -23,7 +23,7 @@ config CAN_CTUCANFD_PCI config CAN_CTUCANFD_PLATFORM tristate "CTU CAN-FD IP core platform (FPGA, SoC) driver" - depends on HAS_IOMEM && (OF || COMPILE_TEST) + depends on HAS_IOMEM && OF select CAN_CTUCANFD help The core has been tested together with OpenCores SJA1000