From patchwork Thu Nov 24 12:02:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: tip-bot2 for Thomas Gleixner X-Patchwork-Id: 25475 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp3355248wrr; Thu, 24 Nov 2022 04:06:45 -0800 (PST) X-Google-Smtp-Source: AA0mqf6A5oyNO+1cd4WFXN2XV/BhAzX0iNLJUsfxnB7lWUzXojpR8+m+Kdya1JWxEffJ5mrpQDyV X-Received: by 2002:a17:907:cf84:b0:78d:4795:ff1f with SMTP id ux4-20020a170907cf8400b0078d4795ff1fmr28477223ejc.331.1669291604979; Thu, 24 Nov 2022 04:06:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669291604; cv=none; d=google.com; s=arc-20160816; b=KHhEKLPSxl4u+yPFIbFRj4CE9nNAvmrxlze8SzRyT2159AgxBr/bRBcxKVsG2NnaVq HnPq7JjZ/zyLpmhi/4lu+OnteM4WLDNgRG3OufQwJ2hordUVcsDLXmE0p266piRekCI6 U3o0zx02vOe2PWYfI1uXxf9qO21JSPyDTHQryYZ2QrVMw37XfirYnCd7ssGyy9FEieva 5fs/RXpm6LaMUF1SKUBbbvREZiEf/qjdZLrRjAbQbzc0X64d7f1eiDFVEymSXw6x/H7p 0Mk6MRQu8l/EjyQUauGgEoJSmO8Y+gIC3dTAzoGPhzL6RLQ9kCuBYb/Uov+2drr9UGh6 3Aig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:robot-unsubscribe :robot-id:message-id:mime-version:references:in-reply-to:cc:subject :to:reply-to:sender:from:dkim-signature:dkim-signature:date; bh=e2aSt7rfgtYYH96lPvOuOtCgk76ld4jgS5BO+XfA3kg=; b=Goi8nmOP1cd10SJy/kQsthe/Z0RpbQhYpVMB5FjJIKPY3sOJtLP4jbBOc1ghK9BoMS d/AmYlAwQazN7E8/8IUY/y31vKN+0uHUNknBO5WDsFNyohMpK/A/ToBAAnEmWH79vTgU nvh3CTqp76acuXFTKXa947gZ4usP0YjjJyRAE0NKzVk2W4qcPHKKCnoEFrnFUb8DT87M E7cVQ5nnqwJpohOzU173qnXcu4CTvL4szbXAMa+AFSRMT5HLN0Z9bq2D5F6BeSODk+oU x+bNnWDm7QTC3oyAh2I7cZ3AXaUnzd64MTV6PefFrJX2NO2jxsvtt6R+CI+zXDs+jxOk rueg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b="eCfQaV/n"; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ay10-20020a056402202a00b0046a6960c990si779366edb.431.2022.11.24.04.06.20; Thu, 24 Nov 2022 04:06:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b="eCfQaV/n"; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230252AbiKXMDC (ORCPT + 99 others); Thu, 24 Nov 2022 07:03:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230194AbiKXMCv (ORCPT ); Thu, 24 Nov 2022 07:02:51 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6A00429AF; Thu, 24 Nov 2022 04:02:50 -0800 (PST) Date: Thu, 24 Nov 2022 12:02:48 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1669291369; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e2aSt7rfgtYYH96lPvOuOtCgk76ld4jgS5BO+XfA3kg=; b=eCfQaV/nRj1MDDe8reVCJOGjhHk1yO/CThP8m1WnZzv4gDwORJLLWo4dUWFcezbzjWZhvS wN8K2JSVbNyHxZnuIgFWnOzOk8K/U4QCFO/enBdCMcJ22QBCPijmbjZUV3JhYh8CHPSleH VC3bGrzdHq0sPbjRfrBh53a8rJUZVBSM9DVdltZN+f8dSTNQv24EQ2sUy95XFOS3r3Nn/X I4dOixLWlCvR2M5w4jE5cZd5lnPcSkLkqrdVQzfvLKzBasvZFbTMycK7Jkl1MsckFLKy18 i/4lPssmdihG2N5RldaAh2C+dwO3wRY/9euSjLiHhmGJ77aytLROWg8SAyUxqg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1669291369; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e2aSt7rfgtYYH96lPvOuOtCgk76ld4jgS5BO+XfA3kg=; b=W/2j0PmYiAO2uwEuyGxXH3k7QzUpCNVaa19rl9NNTcCAaU+Y4yvkMgHPKPsNINVERHnmfe FliuHzT61hSyJ3DQ== From: "tip-bot2 for Xiongfeng Wang" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: perf/core] perf/x86/intel/uncore: Fix reference count leak in hswep_has_limit_sbox() Cc: Xiongfeng Wang , "Peter Zijlstra (Intel)" , Kan Liang , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20221118063137.121512-3-wangxiongfeng2@huawei.com> References: <20221118063137.121512-3-wangxiongfeng2@huawei.com> MIME-Version: 1.0 Message-ID: <166929136800.4906.10626350141240755490.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750379113485267839?= X-GMAIL-MSGID: =?utf-8?q?1750379113485267839?= The following commit has been merged into the perf/core branch of tip: Commit-ID: 1ff9dd6e7071a561f803135c1d684b13c7a7d01d Gitweb: https://git.kernel.org/tip/1ff9dd6e7071a561f803135c1d684b13c7a7d01d Author: Xiongfeng Wang AuthorDate: Fri, 18 Nov 2022 14:31:35 +08:00 Committer: Peter Zijlstra CommitterDate: Thu, 24 Nov 2022 11:09:25 +01:00 perf/x86/intel/uncore: Fix reference count leak in hswep_has_limit_sbox() pci_get_device() will increase the reference count for the returned 'dev'. We need to call pci_dev_put() to decrease the reference count. Since 'dev' is only used in pci_read_config_dword(), let's add pci_dev_put() right after it. Fixes: 9d480158ee86 ("perf/x86/intel/uncore: Remove uncore extra PCI dev HSWEP_PCI_PCU_3") Signed-off-by: Xiongfeng Wang Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Kan Liang Link: https://lore.kernel.org/r/20221118063137.121512-3-wangxiongfeng2@huawei.com --- arch/x86/events/intel/uncore_snbep.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/events/intel/uncore_snbep.c b/arch/x86/events/intel/uncore_snbep.c index b14d591..93b0f1f 100644 --- a/arch/x86/events/intel/uncore_snbep.c +++ b/arch/x86/events/intel/uncore_snbep.c @@ -2910,6 +2910,7 @@ static bool hswep_has_limit_sbox(unsigned int device) return false; pci_read_config_dword(dev, HSWEP_PCU_CAPID4_OFFET, &capid4); + pci_dev_put(dev); if (!hswep_get_chop(capid4)) return true;