From patchwork Thu Nov 24 12:02:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: tip-bot2 for Thomas Gleixner X-Patchwork-Id: 25474 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp3355230wrr; Thu, 24 Nov 2022 04:06:43 -0800 (PST) X-Google-Smtp-Source: AA0mqf4x7sQNO2dlfgO4f63gY/Hj3NAWdFcDYgSHbFIxEMeTTSw53w8+tbZkusPU9XCNqiIWGGin X-Received: by 2002:aa7:cc08:0:b0:461:8a43:e93 with SMTP id q8-20020aa7cc08000000b004618a430e93mr28578490edt.275.1669291603160; Thu, 24 Nov 2022 04:06:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669291603; cv=none; d=google.com; s=arc-20160816; b=mPlURisOlo24zik5tIMGX+n5FrWHHpkBw3lE05O7qRHd2tAqvkwqs4cpAv4wUlooiA kYTJ75sVTnStMCBKZCJiadBHAxqfvjezsFGz1ywj4kHwpHN8M03X7z2EKBO2NbfnrTNZ jDe/XCsiwvgToeiHCziYlQbwL2HhwOuEROeovkwIi0u4m37MA7uDzoQ4yg8fOT0YpK3y jRg/AfVso19IP+SFa4lacpXowHWAghM5bliyXTtmLujrr08Sf76TEgL2o31BCCKglldi rIxtLF3pgD4V7uC7GwtSnu+xQX3Qin7PVKoSaArMX+5OjYZZFmQKTVCxZUmo3Cvyy6R2 J+ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:robot-unsubscribe :robot-id:message-id:mime-version:references:in-reply-to:cc:subject :to:reply-to:sender:from:dkim-signature:dkim-signature:date; bh=MhC6bmc4f+IfIIYmCCearwAZxy7ciSOUUxSt5WzBXeE=; b=arVw7QdjLWIUGZLsY+EovsTL2Pl52+ONo7xeV4MUdifaogo9T6nyLhvywkxXSpVyCV DkTRdwBF0f+1LQRxcqDB0uS1Qq7v0wdS1I+ThRlH8mOV7GffgcMQnC2C1ZxVQh90OlLv d4HFMP9nJ5Ll13M27YIAL/9Aa0Gk8DN5FqXclyh4pR7uEPos+k6Ed9GfbNt2w3vHc10d WcaMFJOuiQ9id1GnSBhjQRFcc6MjESwKevApurYm/BQEYk39KAoyezgfsIoZQ2wTaaTz bXTtKtWGypf8M1YOW2TM6XvZL1WgVkWFN2Smo+Sq8T+vKWB0yke9LNqM7ZIk7Xwz6EOR hlYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=W+9rkPqh; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e16-20020a056402191000b0046327da0dacsi1015907edz.232.2022.11.24.04.06.19; Thu, 24 Nov 2022 04:06:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=W+9rkPqh; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230235AbiKXMC7 (ORCPT + 99 others); Thu, 24 Nov 2022 07:02:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230173AbiKXMCv (ORCPT ); Thu, 24 Nov 2022 07:02:51 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24F041DA5B; Thu, 24 Nov 2022 04:02:50 -0800 (PST) Date: Thu, 24 Nov 2022 12:02:46 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1669291368; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MhC6bmc4f+IfIIYmCCearwAZxy7ciSOUUxSt5WzBXeE=; b=W+9rkPqhVnYU5wg+2xM71y09bEFNtIfcKTQJ6cQ+2ybJT19IdS8EjNVbOM09jZCLelSTjS uZumMlNGd7Kb+3bZMOQPSZyMXTSxIYMCL1SjSjfGI+n3xKgZwMl690gjXe2IwkMzMFkhAx bWMEy/VV8pvuluHccxIEK33qyJODzr65Y5Jv01uZYm258MLdquwcQBpB2Xj1eVNgibb4Xz ysaRXsEhD0XPJVXlpfbQERlR6Q5HAV/15o1ACf/30KqTHP6i0wxoOYZVrImZS1HPOIa0NH p6lj+gqrD2sGWoljANCqUzgx03EcPR3zSddAPevRkLnEX4QJtRe+ePFberfvcg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1669291368; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MhC6bmc4f+IfIIYmCCearwAZxy7ciSOUUxSt5WzBXeE=; b=tOXDDpHUMFYAATNyqm6T11zQXVhpRst4FM/MRryUPh9lTYXZbkWZ/R6mS/R3r43gpyRRdl ixmMiTCsxmzrwZDQ== From: "tip-bot2 for Xiongfeng Wang" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: perf/core] perf/x86/intel/uncore: Fix reference count leak in snr_uncore_mmio_map() Cc: Xiongfeng Wang , "Peter Zijlstra (Intel)" , Kan Liang , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20221118063137.121512-4-wangxiongfeng2@huawei.com> References: <20221118063137.121512-4-wangxiongfeng2@huawei.com> MIME-Version: 1.0 Message-ID: <166929136687.4906.12321459785416092407.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750379111902653775?= X-GMAIL-MSGID: =?utf-8?q?1750379111902653775?= The following commit has been merged into the perf/core branch of tip: Commit-ID: 8ebd16c11c346751b3944d708e6c181ed4746c39 Gitweb: https://git.kernel.org/tip/8ebd16c11c346751b3944d708e6c181ed4746c39 Author: Xiongfeng Wang AuthorDate: Fri, 18 Nov 2022 14:31:36 +08:00 Committer: Peter Zijlstra CommitterDate: Thu, 24 Nov 2022 11:09:25 +01:00 perf/x86/intel/uncore: Fix reference count leak in snr_uncore_mmio_map() pci_get_device() will increase the reference count for the returned pci_dev, so snr_uncore_get_mc_dev() will return a pci_dev with its reference count increased. We need to call pci_dev_put() to decrease the reference count. Let's add the missing pci_dev_put(). Fixes: ee49532b38dd ("perf/x86/intel/uncore: Add IMC uncore support for Snow Ridge") Signed-off-by: Xiongfeng Wang Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Kan Liang Link: https://lore.kernel.org/r/20221118063137.121512-4-wangxiongfeng2@huawei.com --- arch/x86/events/intel/uncore_snbep.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/x86/events/intel/uncore_snbep.c b/arch/x86/events/intel/uncore_snbep.c index 93b0f1f..44c2f87 100644 --- a/arch/x86/events/intel/uncore_snbep.c +++ b/arch/x86/events/intel/uncore_snbep.c @@ -5111,6 +5111,8 @@ static int snr_uncore_mmio_map(struct intel_uncore_box *box, addr += box_ctl; + pci_dev_put(pdev); + box->io_addr = ioremap(addr, type->mmio_map_size); if (!box->io_addr) { pr_warn("perf uncore: Failed to ioremap for %s.\n", type->name);