From patchwork Mon Mar 4 05:04:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Edward Adam Davis X-Patchwork-Id: 209382 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:fa17:b0:10a:f01:a869 with SMTP id ju23csp1224736dyc; Sun, 3 Mar 2024 21:10:23 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVi1VQhBvdcYcuOIHA4uGypQ7Ad3nMb4a6YuM/iVvg4cdn33vGITp6dgO70lioWmYqLUycygzQlfsOeWz8HPpOQF+uEhw== X-Google-Smtp-Source: AGHT+IFxHxFPQV8IIMYNjrZ661LIUdubH1sjVVDLRLP7ksRP4X7VBq7wMe/gozPVpq3EyelMGYhY X-Received: by 2002:a17:90a:cb94:b0:29b:171c:a787 with SMTP id a20-20020a17090acb9400b0029b171ca787mr5147511pju.19.1709529023213; Sun, 03 Mar 2024 21:10:23 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709529023; cv=pass; d=google.com; s=arc-20160816; b=YpBOOOjETRoMu6/wA0WR2HNPrNNa11+Pxd7Hc/nEynZZOfwFvLxTsL6t2tEMadVwA9 nGMfGqdFnO5//IFfOdVSUsigyqN5AV8LI5Yp6x6xsG1UardTBgibqSU7ZPFJzTEmEOly Ua595Uib3Ed0jLQ0ez1BCUw3iRbByTrrEgZE1fAEpOk8auLL4c0sqmCWv47zo4dCbRif pZ4EHq9wHniZJPYj3MsCENJKFMXFgelo8UTBDbrJC7K3L+fW3GlAqi8Z6g61VyyueQaM LajoQfYw2vFJsLOoRveKGbyOCv2cwQ3Idn3rC94jXZpukwJmFvkVWDPLXGlQQRFArIHN PwDA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:date :subject:cc:to:from:message-id:dkim-signature; bh=Uo6+rVGqUfEBi3BWpquQslrkKBAv6/iFpXZsRLuvnJM=; fh=Lf2KYEsjD2J5/G4KyzDjfF5CXPi7fXlu38vp37dcJtg=; b=1FA42g2O0OJL34uM4ok/ODb6V+exezxW8gHX24gb7qv0xsd9XVldhtmaT+AHM2B6yN sHxGM69FogRDlSB2EAn4NRJkkdV9oN/naq9WsX07Edo5djXM9lgYCAkv0J00E49SXPU7 mBew99MHm1WDv+0D1BywRvvJLBmChKMgGtT+IS7OgBXUE4hOVt0z/Vg4LUMmEe3vGL+1 DqfncojCV6WYtJyTxbiyqkvNmLz7oIFJcMpy7YwkGb6VVFrWnXHagOHp2vfFn27has0J 9USYgsECuVuHPkQY9yJ+fynE7RD086BTkd1+2gHIVaZjUKs4J5JmCWK1v1phvbn4G0ox KIBA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@qq.com header.s=s201512 header.b=BsMurF+d; arc=pass (i=1 spf=pass spfdomain=qq.com dkim=pass dkdomain=qq.com dmarc=pass fromdomain=qq.com); spf=pass (google.com: domain of linux-kernel+bounces-90052-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90052-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=qq.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id mh15-20020a17090b4acf00b0029af3b2b337si8200366pjb.140.2024.03.03.21.10.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Mar 2024 21:10:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-90052-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@qq.com header.s=s201512 header.b=BsMurF+d; arc=pass (i=1 spf=pass spfdomain=qq.com dkim=pass dkdomain=qq.com dmarc=pass fromdomain=qq.com); spf=pass (google.com: domain of linux-kernel+bounces-90052-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90052-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=qq.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 0B26F281764 for ; Mon, 4 Mar 2024 05:10:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 902EA8BEA; Mon, 4 Mar 2024 05:10:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b="BsMurF+d" Received: from out203-205-221-202.mail.qq.com (out203-205-221-202.mail.qq.com [203.205.221.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D222946AD; Mon, 4 Mar 2024 05:10:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.205.221.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709529004; cv=none; b=cRBgobY/sEspavqlsiQS47PNlcXcMVxPbCD74F1bvaYFxOHD2oeGCW0j9AUgP/KE8ZLJ+6YwayUteNz26e7emysEYGGPiDk5VjxXRYS04bj28UqsWmaYs2+OZvT57pyCSUdqej5MbgjSYVCIwtQLzOHWdByDX2W9+WPRWl6Ybf4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709529004; c=relaxed/simple; bh=G/uUIcpfGezZClHWnrZDD9K0NYrXcF/UXKZ/8huSANM=; h=Message-ID:From:To:Cc:Subject:Date:In-Reply-To:References: MIME-Version; b=rRhG8TmFolY1QzeMIvFxcnffnV9TmGF9f9w2BtZMZXwNgpbRDHSRDkZELvJMieTjjajoFI6qImsnVNpIBoYRUo9u+GlB+Yf7hidg51D45pO+gVmm00AvEhg9cKWRnlOij7rJvTF+hRHXFlb2b0N8j0v7IHwgULRoslXocnUwH9k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com; spf=pass smtp.mailfrom=qq.com; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b=BsMurF+d; arc=none smtp.client-ip=203.205.221.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=qq.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1709528691; bh=Uo6+rVGqUfEBi3BWpquQslrkKBAv6/iFpXZsRLuvnJM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=BsMurF+dAlUa39T20GoIub98PkcvLTh9NbQkMObuhCHwtGlUGwhojN1b4BMEwY5UC JdiBcyPI5ArAC4LBrPXBRcOYGM63wYtnFdwVHeKMfDev76jzp53Z4cbeJu97Wm2Yfd 0AZrX93TgZpLs+JITlZIkeHs3TP25mpEt/ejFxjw= Received: from pek-lxu-l1.wrs.com ([111.198.228.140]) by newxmesmtplogicsvrsza10-0.qq.com (NewEsmtp) with SMTP id 12F9C638; Mon, 04 Mar 2024 13:04:47 +0800 X-QQ-mid: xmsmtpt1709528687tnp1fwg6v Message-ID: X-QQ-XMAILINFO: NkHKfw09D6j8L6Vf18I52L5AstsLXhNSNv1IFN95prqdn7p8CrYmjPJc7qeqCI 6+CwfYyItX5blQhwk0B2JPeRrbw70RW+B0g7+BNEGhCr0Dr0bPE98UvTf/fUWHwks8os6lM4K8/0 P2YejYU+PTDZ5XHCbpq8/gKSiXNTZtZue1b6LoilLQPG5nRvcmiVjZDE4Th2bk2BCwiaIbWx01EB oXiNL3EgFGevORNRomYUutnH1fyCZ+Nna3oOzvMER8wsAejB54iUT+C0qN6o3Z3meiCdHpaoWVfg /1WuTs4tmAHor12GkXz/4xzssJkUrTVx32pUj4LIuWOB/rGtURnR45FrVYkGl32LF67B6d5UEo51 OA4Myv1/DhZmKlhRcLo9sJ8h3HC9bD6cXpVuNsChF79yUfanFfeAi9J2MxHKaDbxNdYSSkXqNNhX gJEh6WOI66t8K5ZTV8Jh11KW+/+d0UZ2ycdAX1vQ9LBuomhs/R3lXn5Y8SMgPQ7urj8Txs+AnWBd nrIemF62rxbMyw0URkss4g9Imyh8KpgV9WG17K/GQdzUw2band0qBDPO1WuVzPbkt1bsSgxBC/hv 9I4LCe/baMolmXC9K1brXSe7h3S3ZRUbSUct/nZ4L1kAsrYT2W9BBl4AFRx0Qvnxmae/Q20+34Cr lxIW14JzgqhqqUgdoISMgC80rEiJDM3ieTPTgi+BI99e7ybRRk1UJZWuyI9eO3JZjsWL23HvE84r QMfLiqrcwZ+4Cw18dpfTzBqBdPvxOEdy9LvatFc190wTXWCDFoZuMrOcs4o85rltzrmbHibpBh1c WkuR1whUeIBwYKTllNFxwI9SrKCWssfXd2N31gGkJ89igk9dQ70lPAZ7/Xx7TGPK1arjd6VQgyz9 OYaaVVRmzuAsaCQhjv0KxqkuhDwKCRHszGPEUWnH7SAVrDvkPq68aepldSC+ZtbYa0x2R9F6DIcc QvbcPROXLCGPjtLr8ySvSxd4EfPj84nSeARKoNRdadvUwrHHL/faWXo2u3UB0s X-QQ-XMRINFO: NS+P29fieYNw95Bth2bWPxk= From: Edward Adam Davis To: edumazet@google.com Cc: davem@davemloft.net, eadavis@qq.com, kuba@kernel.org, linux-hams@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, ralf@linux-mips.org, syzbot+f770ce3566e60e5573ac@syzkaller.appspotmail.com, syzkaller-bugs@googlegroups.com Subject: [PATCH] net/netrom: fix uninit-value in nr_route_frame Date: Mon, 4 Mar 2024 13:04:48 +0800 X-OQ-MSGID: <20240304050447.1211572-2-eadavis@qq.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792571105152941848 X-GMAIL-MSGID: 1792571105152941848 [Syzbot reported] BUG: KMSAN: uninit-value in nr_route_frame+0x4a9/0xfc0 net/netrom/nr_route.c:787 nr_route_frame+0x4a9/0xfc0 net/netrom/nr_route.c:787 nr_xmit+0x5a/0x1c0 net/netrom/nr_dev.c:144 __netdev_start_xmit include/linux/netdevice.h:4980 [inline] netdev_start_xmit include/linux/netdevice.h:4994 [inline] xmit_one net/core/dev.c:3547 [inline] dev_hard_start_xmit+0x244/0xa10 net/core/dev.c:3563 __dev_queue_xmit+0x33ed/0x51c0 net/core/dev.c:4351 dev_queue_xmit include/linux/netdevice.h:3171 [inline] raw_sendmsg+0x64e/0xc10 net/ieee802154/socket.c:299 ieee802154_sock_sendmsg+0x91/0xc0 net/ieee802154/socket.c:96 sock_sendmsg_nosec net/socket.c:730 [inline] __sock_sendmsg net/socket.c:745 [inline] ____sys_sendmsg+0x9c2/0xd60 net/socket.c:2584 ___sys_sendmsg+0x28d/0x3c0 net/socket.c:2638 __sys_sendmsg net/socket.c:2667 [inline] __do_sys_sendmsg net/socket.c:2676 [inline] __se_sys_sendmsg net/socket.c:2674 [inline] __x64_sys_sendmsg+0x307/0x490 net/socket.c:2674 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcf/0x1e0 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x63/0x6b Uninit was created at: slab_post_alloc_hook mm/slub.c:3819 [inline] slab_alloc_node mm/slub.c:3860 [inline] kmem_cache_alloc_node+0x5cb/0xbc0 mm/slub.c:3903 kmalloc_reserve+0x13d/0x4a0 net/core/skbuff.c:560 __alloc_skb+0x352/0x790 net/core/skbuff.c:651 alloc_skb include/linux/skbuff.h:1296 [inline] alloc_skb_with_frags+0xc8/0xbd0 net/core/skbuff.c:6394 sock_alloc_send_pskb+0xa80/0xbf0 net/core/sock.c:2783 sock_alloc_send_skb include/net/sock.h:1855 [inline] raw_sendmsg+0x367/0xc10 net/ieee802154/socket.c:282 ieee802154_sock_sendmsg+0x91/0xc0 net/ieee802154/socket.c:96 sock_sendmsg_nosec net/socket.c:730 [inline] __sock_sendmsg net/socket.c:745 [inline] ____sys_sendmsg+0x9c2/0xd60 net/socket.c:2584 ___sys_sendmsg+0x28d/0x3c0 net/socket.c:2638 __sys_sendmsg net/socket.c:2667 [inline] __do_sys_sendmsg net/socket.c:2676 [inline] __se_sys_sendmsg net/socket.c:2674 [inline] __x64_sys_sendmsg+0x307/0x490 net/socket.c:2674 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcf/0x1e0 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x63/0x6b [Fix] Let's clear all skb data at alloc time. Reported-and-tested-by: syzbot+f770ce3566e60e5573ac@syzkaller.appspotmail.com Signed-off-by: Edward Adam Davis --- net/core/skbuff.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/core/skbuff.c b/net/core/skbuff.c index edbbef563d4d..5ca5a608daec 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -656,6 +656,7 @@ struct sk_buff *__alloc_skb(unsigned int size, gfp_t gfp_mask, * to allow max possible filling before reallocation. */ prefetchw(data + SKB_WITH_OVERHEAD(size)); + memset(data, 0, size); /* * Only clear those fields we need to clear, not those that we will