From patchwork Sun Feb 25 03:12:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: linke li X-Patchwork-Id: 205983 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp1413470dyb; Sat, 24 Feb 2024 19:13:12 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWTL2T4fL9VigbzjDtgsFiH1VFKSQ2Pfc1ZpoRKW2HTdTWb8zr69Ut3ojVErN7F7Vq6vtgPTmdRFdfStBbjcBamFdFbeQ== X-Google-Smtp-Source: AGHT+IEB1XSR+X148wT7o3zGJF+MHTuOUTBDwpD7Vu5fDA9i169BkY/iD+eWtQw98QnxK0dT4EK2 X-Received: by 2002:a05:6512:6cc:b0:512:b00f:a56b with SMTP id u12-20020a05651206cc00b00512b00fa56bmr2697099lff.33.1708830792217; Sat, 24 Feb 2024 19:13:12 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708830792; cv=pass; d=google.com; s=arc-20160816; b=qid8IeBrB+tUJfrPcFJpCLpKQk76SN8Aj7d0nh/LC6wqN+FPVHRronyKu2qksjBbwH 0WSkJf/vMAs7d/HWXI1wZLZbk9mNklNppDfM8RghJ3lAuKflKFK4nxXVj626iNHaC0Wg MhYlrUr0wqLfu20T0vwh7jzT7DPz4hx17Q5lhbQ+5jGSaSXPegWu4K4VcfIzsIuVM0V8 b0Cvfjmg+el0mF6w3tWDIJfdpslDMFL2S80+wWTe1l5CYzW/M7LPjxZTa01Xna71VSL5 Lzbk4WQozX64/qHcQTwPmzSXAfW8dNnzKGip5Ml8XNsvP5+RkvQ+dLsOaRLEoN1vAOlP Rrxw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:date :subject:cc:to:from:message-id:dkim-signature; bh=A/IxJBZi27mtkrsoxOZws5nHnODjFxtLyQdPu2a35uU=; fh=bHp1OZODnw0Zq9jd4R9IuFRH+G7Rtm5GGGAroj5eAmk=; b=TTiB+h4lhtY/fR2LULHDFuFJk7g9AJr75Yb2Ob5rH1AEZvX3geR9u1pd4eRJEUtTD7 ne/ILAuM449DUn4jLzzh5vG489JPdDELK7lvYn4YUslWuoc6MQSse1WZcM2v+/dKL2Ei 0LmKiTi98tRxy4RDrDyyuaarisJp247hi+iAOM24XcNgzaxN1oyzKv850oNV68T0J1cg lLTzfPrBDfPmkF8FCJxuve2IZc6Ka+UWYD51JNsz6hd93mRHK2ZhoZfHV7vZyMBqz8nT 6I2VdY5PIshaJH22XT5QJt5qNtfB2nNnG6Vh11Sxt2Vp7yuupI4spbRbGwEhEenCykgw 7iOg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@qq.com header.s=s201512 header.b=nvh++8F9; arc=pass (i=1 spf=pass spfdomain=qq.com dkim=pass dkdomain=qq.com dmarc=pass fromdomain=qq.com); spf=pass (google.com: domain of linux-kernel+bounces-79955-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-79955-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=qq.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id k7-20020a170906054700b00a3e9df08ad6si974579eja.115.2024.02.24.19.13.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Feb 2024 19:13:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-79955-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@qq.com header.s=s201512 header.b=nvh++8F9; arc=pass (i=1 spf=pass spfdomain=qq.com dkim=pass dkdomain=qq.com dmarc=pass fromdomain=qq.com); spf=pass (google.com: domain of linux-kernel+bounces-79955-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-79955-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=qq.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id CF9DA1F215CB for ; Sun, 25 Feb 2024 03:13:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5A4539454; Sun, 25 Feb 2024 03:13:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b="nvh++8F9" Received: from out203-205-221-191.mail.qq.com (out203-205-221-191.mail.qq.com [203.205.221.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EAE78BF6 for ; Sun, 25 Feb 2024 03:12:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.205.221.191 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708830778; cv=none; b=fWsy2PcI8+NMm9ov3fZ7/QsFMUm2+jfbr6xUoQKSctFypmtqFjfK9+n/OWsi9oURJHWk2ysg9T3GtxiK4tT0JR4IRhQmOkUCBTd7eBfiUJylIejJCY8rVT+hk0Evmi5PRwia3xPaeEqWWpG6vJJOVGi1sXQCZNlSm+14wUduVlk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708830778; c=relaxed/simple; bh=U4i+i9PdBw8hS+mhrV5wIJhHZ+uVQK46IFdaQMNvLmA=; h=Message-ID:From:To:Cc:Subject:Date:In-Reply-To:References: MIME-Version; b=tQdviae4w6ugQ5et1tPTp5em+IA1JgBVf9TMNmDlkC9j1sqV4TfFOPqqpIR8ArIHRXdy7ikq0nCRZoFdZ4fYLEFiI6JhPr7BbArtnS0Spypqm0KDN9h1+iafJDoy2a0WXzgunznm3VJL1o9GvGG3RpYJFjoCx+GA09bfWVkfhvI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com; spf=pass smtp.mailfrom=qq.com; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b=nvh++8F9; arc=none smtp.client-ip=203.205.221.191 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=qq.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1708830774; bh=A/IxJBZi27mtkrsoxOZws5nHnODjFxtLyQdPu2a35uU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=nvh++8F9zKycX2w3RdPceEsb0wHDDofJIs3hAodH8Elub/SuncE5O1OFA1/zmuXtL qi5TPcno55Up0+KxhFzDhrg7xgiiOgGPZSKueIJr2LfWnLD35AuxSmRykd564FIBAm 7Zm39RatLbVNRma8OwO0fwSJzOut4m7hbLFiHYv8= Received: from localhost.localdomain ([153.3.164.50]) by newxmesmtplogicsvrszc5-1.qq.com (NewEsmtp) with SMTP id 33487E60; Sun, 25 Feb 2024 11:12:52 +0800 X-QQ-mid: xmsmtpt1708830772td52svu9a Message-ID: X-QQ-XMAILINFO: NQR8mRxMnur91Jl8O5fz+Bb1i2ZaLpyIhNB7YV8SfRiLgwNQd1ahEc/2me8sSw 2Ltka2+r+ZOX6aMyZ9BXnUERzXeW/YeO/OtEs59JoTDgIpSchtqWKX6px3YDCLo3cQuw/zNdtsvT 3HRPEoBCgxGd2j46tEnUEn9NxGsAeao2qAUSAzBxxBiq4Gdt6ReDDLOxAhZWKnAxZ0eFr7I+Fy+y ibOc0oL6CB8OGoD8csgVq2NiWIBXKlW2iZIpIUwuBOH48G1k0OjQx4lVNQ+7YjsTs3/uTuBcUdNw I1CbM+l2Ir+WJ21+PppLWW+tBkUeU5Nrkd2oTKeSNBIxZw6b46nb3DsuYNKzeRUDzXmufomrOt0B LtNXbYLfSeyWPmXaWtN90Oe8DQelPjWifknj9LaL6QTG/9tjGbCF4FUBqZrg/EYG6c4rmwAhcDNA IGitLOXHWOObh7XyFA7uTvdCPY6sRnziFs6Ck0OD9ZVcXmQCNS0D+DYPWQFIGjw084L86yAeYrLv 1hKVM3UotzqDPYVZlZ/ZlFshFTx1+QWmwm4fMt5RGlWupYinKjaO6pZz8coykeSAjx9GTDCsfcdZ VI57tcf9K1ccfUBe/uJu0OYxRNZ86mhyulDghdEfvrltBJ0JgiU1BHEenViEv7Ln63ZE/2UyH5UK O3ZGVP1WVPwZuutrGsHeSixVqDR6eHG44hH5MS0EIHkjvn8/7ttLUirq0VoGq79yhLAE5jTmZUD5 aL4L/MelBa4gyCT/37Xi0yz9q181SWonCHDsdmHnocIR2dfdUYkOBipUqYnnbmYgUMyPVTlh/Z9V +PYo/18oOFZiSyR6nUoKhcb0j0ZwUJh5EFoxQDW6i40vQQv/Fxv7BcmMY102P+Q3vCMMpGBBxk7n 1DQUbd3HqSX368nn20jl0fijlX7fjehYQzoix/W8W+HZL4utjDkiAlAiBpv5syPO/0VMYgoo6Kl2 wBQvshHckPUs2m27W6hyQ+y+SsaOITW/i1fAhwtQHIE0VVqH3gn3+8sZmNSOmLIDw1bN6Un7+4XN 3GEO+xGnS9qqHzF17s X-QQ-XMRINFO: NyFYKkN4Ny6FSmKK/uo/jdU= From: linke li To: Cc: lilinke99@qq.com, Frederic Weisbecker , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org Subject: [PATCH] tick: use READ_ONCE() to read jiffies in concurrent environment Date: Sun, 25 Feb 2024 11:12:50 +0800 X-OQ-MSGID: <20240225031250.99386-1-lilinke99@qq.com> X-Mailer: git-send-email 2.39.3 (Apple Git-145) In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791838956452190778 X-GMAIL-MSGID: 1791838956452190778 In function tick_sched_do_timer(), jiffies is read using READ_ONCE() in line 224, while read directly in line 217 217 if (ts->last_tick_jiffies != jiffies) { 218 ts->stalled_jiffies = 0; 219 ts->last_tick_jiffies = READ_ONCE(jiffies); 220 } else { 221 if (++ts->stalled_jiffies == MAX_STALLED_JIFFIES) { 222 tick_do_update_jiffies64(now); 223 ts->stalled_jiffies = 0; 224 ts->last_tick_jiffies = READ_ONCE(jiffies); 225 } 226 } There is patch similar to this. commit c1c0ce31b242 ("r8169: fix the KCSAN reported data-race in rtl_tx() while reading tp->cur_tx") This patch find two read of same variable while one is protected, another is not. And READ_ONCE() is added to protect. Signed-off-by: linke li --- kernel/time/tick-sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c index 01fb50c1b17e..aa684511c25a 100644 --- a/kernel/time/tick-sched.c +++ b/kernel/time/tick-sched.c @@ -214,7 +214,7 @@ static void tick_sched_do_timer(struct tick_sched *ts, ktime_t now) * If the jiffies update stalled for too long (timekeeper in stop_machine() * or VMEXIT'ed for several msecs), force an update. */ - if (ts->last_tick_jiffies != jiffies) { + if (ts->last_tick_jiffies != READ_ONCE(jiffies)) { ts->stalled_jiffies = 0; ts->last_tick_jiffies = READ_ONCE(jiffies); } else {