From patchwork Tue Dec 5 12:26:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 174022 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp3391386vqy; Tue, 5 Dec 2023 04:26:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IFw3Ks1s0Uo2nJd9oSh1o0UmlOom0uUkNmhmta9f4dQojx5sB/ON6pCXmpCcEkBxPzbk8iJ X-Received: by 2002:a17:902:c950:b0:1d0:8abf:3ea with SMTP id i16-20020a170902c95000b001d08abf03eamr3287345pla.85.1701779204956; Tue, 05 Dec 2023 04:26:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701779204; cv=none; d=google.com; s=arc-20160816; b=VJg3GEd2+ykRgEX0a8Pysstlc6h/q/IwQVdT1QnGo/fqCJVNQJSvRCs4a3zcUD4szv UY7Nbgi6J1qNV8lFrBrJlCeWw40ruVGuTb+LN1O0g1iRAV1ojMczQQcCH+b6YGRBS0Gl lQCMnktlye3AoH93oEhJnztt6iHBEfNdHeC6dYwiv2ID7u5AAuxh59M++5JjXe7qknXw mq46u+syvUOJYASeCcE0XKigD0u6SyaXk/bXniYttgc8jvo7RRg/hr0AVYEQqlIui1qE ruup3PEDiR6cM2ocf5Tv2ouNqn/v0vj3eif4hLN4D46ofPXSFugR2hF2M/gR12Gzcx7L aZ9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=M43wITVH2fO0MFSx9k2ho7xUAIHJk3raduPLAQdMDxU=; fh=SV7jp/N4w5H/WguTuPXZpem2ktA8CMnlzZDNo6r9whw=; b=XHHXmI6Ixhg//XmLe2IbEAfE7nt73eMUdDvkxVpEMuM0YT4OIIRPfCRMFbA/bTRaSi BH7RaYCAhI1AjNDmvVF05/0sO15kTCrPsWp7RJMdjuJT5yR05wvDQ5Rm4gpj1sFWq4zJ YI0m8tJ8JZu3hjkuNBv8nPFS8XJBLzHF9Xs81/GNhvyVvKMQUUvoXRoWzw+s07pOGlpx /T5BBg7U99EJTdPU5DJyiZnq7ElKX1ECiQV6YZfHEZ1l88DRNm2u8jMiZFXj1agYGw9j 5BocgrCxD3Y2YPgDSAXlzZs+tO6SCY0plRXKgBDK1PFkAV5uYrGD35dJXp8Mc3noM+yk Lzqg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id bj6-20020a170902850600b001d06eae7137si5655702plb.260.2023.12.05.04.26.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 04:26:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id D816A80FE96A; Tue, 5 Dec 2023 04:26:41 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235140AbjLEM0c (ORCPT + 99 others); Tue, 5 Dec 2023 07:26:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231941AbjLEM0b (ORCPT ); Tue, 5 Dec 2023 07:26:31 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A44F910F for ; Tue, 5 Dec 2023 04:26:37 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rAUVX-0005XY-K6; Tue, 05 Dec 2023 13:26:35 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rAUVX-00Djuu-7a; Tue, 05 Dec 2023 13:26:35 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rAUVW-00EhQh-Uq; Tue, 05 Dec 2023 13:26:34 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 3/8] regulator: db8500-prcmu: Convert to platform remove callback returning void Date: Tue, 5 Dec 2023 13:26:18 +0100 Message-ID: X-Mailer: git-send-email 2.42.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1728; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=aQBaFL+FANXD31y3+CbqmAskYiXzkwfN3BmtZOQME1Q=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlbxbpizW0JIt1XczXtpIgApN7XcjmUuaG+FhOf Df5QsH3KhaJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZW8W6QAKCRCPgPtYfRL+ TmbUB/wK0Qf/b8gsd9YQ6Hsl1DpgEI0ASqXa8lirDvQU/cJMTo5iN1xlEcnjAqYEC8VR6+gBUWU 3/Nqjdcco4i+4fQ9KzGyL7HzmTuhL5xUcRSA6WYpVxeL940o6HfR7HBLiQZZziXdVe+uf6lilc8 oiJiqebw9iuv7BuMZHpo3tlbhOIcm9U1zb9/EsJYWtx55MmSrNbUx7SJsl9q7mY3WJS6cLDdOZ6 bEW/5dB8SPO19nZ6p0E9OrUAv9wFcfofvozmJwiv4O316ACdj3hDbVzkyagRuo7ycx83GuRcOp6 DABtEHAPSWb370DtrDpUBkbagM0g8oaB5ItADe/JUICsqV9+ X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 05 Dec 2023 04:26:42 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784444831730569521 X-GMAIL-MSGID: 1784444831730569521 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/regulator/db8500-prcmu.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/regulator/db8500-prcmu.c b/drivers/regulator/db8500-prcmu.c index 34c5e485d0af..1e2d54da1b9a 100644 --- a/drivers/regulator/db8500-prcmu.c +++ b/drivers/regulator/db8500-prcmu.c @@ -469,11 +469,9 @@ static int db8500_regulator_probe(struct platform_device *pdev) return 0; } -static int db8500_regulator_remove(struct platform_device *pdev) +static void db8500_regulator_remove(struct platform_device *pdev) { ux500_regulator_debug_exit(); - - return 0; } static struct platform_driver db8500_regulator_driver = { @@ -482,7 +480,7 @@ static struct platform_driver db8500_regulator_driver = { .probe_type = PROBE_PREFER_ASYNCHRONOUS, }, .probe = db8500_regulator_probe, - .remove = db8500_regulator_remove, + .remove_new = db8500_regulator_remove, }; static int __init db8500_regulator_init(void)