From patchwork Tue Jul 11 06:19:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thorsten Leemhuis X-Patchwork-Id: 118285 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp285940vqm; Mon, 10 Jul 2023 23:50:57 -0700 (PDT) X-Google-Smtp-Source: APBJJlEa/MwCJ602xmj+yfDdMn9U7mTXjAVc2QJPDWiLhgtE2w3MhY8WdD9gvBur/WxolLTjNMXZ X-Received: by 2002:a37:b6c2:0:b0:767:32cd:5fe8 with SMTP id g185-20020a37b6c2000000b0076732cd5fe8mr13340976qkf.14.1689058257570; Mon, 10 Jul 2023 23:50:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689058257; cv=none; d=google.com; s=arc-20160816; b=ARnVX1BCUPQAIHaqjVAF77BhcJxtx3TE2MYpW8oPdMjIStuylLWOaUW33dyJilmkAe RVTlHLJ3dOD1AwhI3naPQpI4LvWReSqrmuiYtH7TYIeB46vh4+0eNadBwwxjcLAj20UB GHQNGYKeKTV4eoypGF5c/mGLuUgkvC36q6gDoiiCJCLE7/80/sJ/Ljyi4ftj02coH5UH 9CK1NggJanL/ap3oREaRB+ILtiXb2Lsz1TqPvhxd7BFr4rro/Tv2H16xTnYCkomOxM13 ebnBFvm5thZSCtv6B7E162fies7bRfbT2Ft/G8ub32E68I4FNEVCyf4Gks9zdPiJgXch rqeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Vq/d9q38WIftwnj2cBiacXQN3GV3J52lXbMnsHSpSpM=; fh=IyOYz2aApVSZcG0zYEej1oDoCpl4LIOyTRZ6Vqq7g1o=; b=j8Oab3p79s0k8iFwkqFINtpOg+esgu45QfIKns9zOrAgaSUSAoDferXgJoJwx8S5TL BpNxTsLW6hzHC8SQGeRNvc6i27cHh7bCa11z6w4X+kvFztsPmxpH156AIM3a5uNUF7iM 2dVKHKG3znR6kgN+dZXsjpjYEIHgIQJ1nENzmc1poLtsGe4Obs4UHiSGCmThNEN2RXnv jVB3UAAu4Wo4Nvbx5u0qd7QlECCTHlCmtzlphmgMDw6q3tNrw5aF1vsOfz7cJNGkYzqz k4jp3Wpt8JoB55FuEN9/yv3N7Irkf6JJ5xM/7TTMFw2HyKwb5gr2HMMWdcZFNtl2JC80 ux7Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c6-20020a6566c6000000b005575a0b31d3si1025798pgw.11.2023.07.10.23.50.44; Mon, 10 Jul 2023 23:50:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231398AbjGKGUE (ORCPT + 99 others); Tue, 11 Jul 2023 02:20:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231296AbjGKGT7 (ORCPT ); Tue, 11 Jul 2023 02:19:59 -0400 Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de [80.237.130.52]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4E53E4F; Mon, 10 Jul 2023 23:19:57 -0700 (PDT) Received: from ip4d148da6.dynamic.kabel-deutschland.de ([77.20.141.166] helo=truhe.fritz.box); authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) id 1qJ6j6-0000FA-55; Tue, 11 Jul 2023 08:19:56 +0200 From: Thorsten Leemhuis To: Greg KH , stable@vger.kernel.org Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Sasha Levin , Jonathan Corbet Subject: [PATCH v2 2/2] docs: stable-kernel-rules: make rule section more straight forward Date: Tue, 11 Jul 2023 08:19:54 +0200 Message-Id: X-Mailer: git-send-email 2.40.1 In-Reply-To: References: MIME-Version: 1.0 X-bounce-key: webpack.hosteurope.de;linux@leemhuis.info;1689056398;82679b42; X-HE-SMSGID: 1qJ6j6-0000FA-55 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771105951626557294 X-GMAIL-MSGID: 1771105951626557294 Tweak some of the rule text to make things more straight forward, with the goal to stick closely to the intend of the old text: * put the "it or equivalent fix must be upstream" rule at the top, as it's one of the most important ones that at the same time often seems to be missed by developers. * "It must fix only one thing" was dropped, as that is almost always a thing that needs to be handled earlier when the change is mainlined. Furthermore, this is already indirectly covered by the "Separate your changes" section in Documentation/process/submitting-patches.rst which the rules already point to. * six other rules are in the end one rule with clarifications; structure the text accordingly to make it a lot easier to follow and understand the intend. * drop the 'In short, something critical' from one of those notes: it contradicts the "real bug that bothers people" aspect somewhat and does not really add anything CC: Greg KH CC: Sasha Levin CC: Jonathan Corbet Signed-off-by: Thorsten Leemhuis --- v1->v2: - also drop the 'In short, something critical' --- Documentation/process/stable-kernel-rules.rst | 38 +++++++++---------- 1 file changed, 18 insertions(+), 20 deletions(-) diff --git a/Documentation/process/stable-kernel-rules.rst b/Documentation/process/stable-kernel-rules.rst index de0046c0586b..d3f040c2738e 100644 --- a/Documentation/process/stable-kernel-rules.rst +++ b/Documentation/process/stable-kernel-rules.rst @@ -6,31 +6,29 @@ Everything you ever wanted to know about Linux -stable releases Rules on what kind of patches are accepted, and which ones are not, into the "-stable" tree: + - It or an equivalent fix must already exist in Linus' tree (upstream). - It must be obviously correct and tested. - It cannot be bigger than 100 lines, with context. - - It must fix only one thing. - - It must fix a real bug that bothers people (not a, "This could be a - problem..." type thing). - - It must fix a problem that causes a build error (but not for things - marked CONFIG_BROKEN), an oops, a hang, data corruption, a real - security issue, or some "oh, that's not good" issue. In short, something - critical. - - Serious issues as reported by a user of a distribution kernel may also - be considered if they fix a notable performance or interactivity issue. - As these fixes are not as obvious and have a higher risk of a subtle - regression they should only be submitted by a distribution kernel - maintainer and include an addendum linking to a bugzilla entry if it - exists and additional information on the user-visible impact. - - New device IDs and quirks are also accepted. - - No "theoretical race condition" issues, unless an explanation of how the - race can be exploited is also provided. - - It cannot contain any "trivial" fixes in it (spelling changes, - whitespace cleanups, etc). - It must follow the :ref:`Documentation/process/submitting-patches.rst ` rules. - - It or an equivalent fix must already exist in Linus' tree (upstream). - + - It must either fix a real bug that bothers people or just add a device ID. + To elaborate on the former: + + - It fixes a problem like an oops, a hang, data corruption, a real security + issue, a hardware quirk, a build error (but not for things marked + CONFIG_BROKEN), or some "oh, that's not good" issue. + - Serious issues as reported by a user of a distribution kernel may also + be considered if they fix a notable performance or interactivity issue. + As these fixes are not as obvious and have a higher risk of a subtle + regression they should only be submitted by a distribution kernel + maintainer and include an addendum linking to a bugzilla entry if it + exists and additional information on the user-visible impact. + - No "This could be a problem..." type of things like a "theoretical race + condition", unless an explanation of how the bug can be exploited is also + provided. + - No "trivial" fixes without benefit for users (spelling changes, whitespace + cleanups, etc). Procedure for submitting patches to the -stable tree ----------------------------------------------------