From patchwork Wed Dec 27 16:26:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 183522 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp1534578dyb; Wed, 27 Dec 2023 08:31:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IHMCxtonb4qC5Fao5mOJ6xCloP+dumIVmilYT9boPQ+nQ7zrKwhoEdakYS8NXUXoowJVfbE X-Received: by 2002:a17:902:6507:b0:1d4:1a0b:565 with SMTP id b7-20020a170902650700b001d41a0b0565mr8398340plk.93.1703694696071; Wed, 27 Dec 2023 08:31:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703694696; cv=none; d=google.com; s=arc-20160816; b=EoDTXyKTvNSNZYU9UB0dsdBINViOeCXYRbc9jisWKIMzOEzUW7Rc88GejOxhKFWKTB ApTeAjaDaIRY5Yj8/Wr3OMBZ3a3yXenum4vsQe+v7wykYMpoyjJrlz2+pYWQFtZEr/fT 6M15Vmby2w9b/jL8ZwyCyUZ5QmayhA9zvbohbTJm3nLOE+Z1rZL2tquiDlI1nTxVoSoq xeaGdW2nBrLQFaoEsiEJncrvtXvdfoyHk5zzYVQPKZP8QYl4rwXEpauPE6hHz/ddV8m4 FVA+knmS46+Zc725iaoTiHzWDDA/AelUsfEx3EIZr+yz4opaSnnIL4JdpngWJCxGl4me 4Yiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=8bUa8rjdzLTZPGqSsj4kHU4f8toeDtRDDiRaEIrchiM=; fh=vd9KFCtNILK6Y7bKkF6HrA1zvmNuSjgkAyrTSrhg27g=; b=wr3br0eBfSNZ3Y45Imi07aAELB4qIHh0LY2Ey8NvKHQF8ljm7BFwHT3eaDCZnTOnt3 6Ow+RQw3+1F+jkkySLA1S9HpscGYV2HKpm937/e+xe3RaSQKI3OSxpy2f9cRNzYVGx3I KWpKkRHCUHjACc7dicIkn8xEf/7/fjb6uION0LZrKWX0xsCXsaXNEc98m/H3O/+zNtod /XpL0f//A3SrJzZZsN3XiUXGvG0rB/EZOQ86VCSy5uWMlEOVghg4WxsL9acwYByeeZvn maPA7U8dNQcz8H9yXvOPcsWgEXIFn7ZoaQhXAc6TVxv9/pW29Z2+C57WSCzv6gQfvSBI t5Pw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12135-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12135-ouuuleilei=gmail.com@vger.kernel.org" Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id q12-20020a170902dacc00b001d42c9339d6si8539105plx.393.2023.12.27.08.31.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 08:31:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-12135-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12135-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12135-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 24070B22385 for ; Wed, 27 Dec 2023 16:29:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8246149887; Wed, 27 Dec 2023 16:27:05 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFD4848CDB for ; Wed, 27 Dec 2023 16:27:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rIWk9-00059p-P6; Wed, 27 Dec 2023 17:26:53 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rIWjx-001tZT-E1; Wed, 27 Dec 2023 17:26:42 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rIWjy-001Wmt-1O; Wed, 27 Dec 2023 17:26:42 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Shawn Guo , Sascha Hauer , Daniel Baluta , Thierry Reding , Sudeep Holla , Hao Ge , Rob Herring , Christophe JAILLET Cc: kernel@pengutronix.de, Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 04/11] firmware: imx-dsp: Convert to platform remove callback returning void Date: Wed, 27 Dec 2023 17:26:28 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1797; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=MlqBx3QsOKLYhj8m2E2EGfokVOl5XV7UkQvCbxh8Dg8=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBljFA2JBjZjJ80khzwObhQcArQ5cwJEx64zJY36 CtxgF7WSbyJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZYxQNgAKCRCPgPtYfRL+ TgByB/4kZis+maU+iwmZbE6Rj8EHJS/0bW1FPBZc3bFsDVcvmuiiduDOw8HVY6Kgtd8olF/jklr 6e9JAlfeFGPqi/HNkDXO/x9MCxCRjZHCuLL6Yo/9b481c7rDhEb4Z+n5je2qNU8zg32CqxA3jD/ PyMHg0Jh8UZuCTwsvgjzWG+Wuxy5trk2jF2zNQVlX1AGixbNOM7nGCCp6al65O2s0YOgY6ohRj2 tJ/IS4IYapHTbktUPR4bQ2a1/w8MhOOdkgrDxdchBkauQgNtbqT9gcb+Xp2Ec8ltF8pM6DnycHt /ySIHanZz7kGgxGI/agQ1ot69EXC5J/A09VnL8E8rtstvwbS X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786453369492772080 X-GMAIL-MSGID: 1786453369492772080 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/firmware/imx/imx-dsp.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/imx/imx-dsp.c b/drivers/firmware/imx/imx-dsp.c index a48a58e0c61f..01c8ef14eaec 100644 --- a/drivers/firmware/imx/imx-dsp.c +++ b/drivers/firmware/imx/imx-dsp.c @@ -160,7 +160,7 @@ static int imx_dsp_probe(struct platform_device *pdev) return 0; } -static int imx_dsp_remove(struct platform_device *pdev) +static void imx_dsp_remove(struct platform_device *pdev) { struct imx_dsp_chan *dsp_chan; struct imx_dsp_ipc *dsp_ipc; @@ -173,8 +173,6 @@ static int imx_dsp_remove(struct platform_device *pdev) mbox_free_channel(dsp_chan->ch); kfree(dsp_chan->name); } - - return 0; } static struct platform_driver imx_dsp_driver = { @@ -182,7 +180,7 @@ static struct platform_driver imx_dsp_driver = { .name = "imx-dsp", }, .probe = imx_dsp_probe, - .remove = imx_dsp_remove, + .remove_new = imx_dsp_remove, }; builtin_platform_driver(imx_dsp_driver);