From patchwork Tue May 23 15:52:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 98075 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2258296vqo; Tue, 23 May 2023 09:13:15 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ54vKMtOZHezxyFi1T8G5+sIdcWWmj0fYF+X+ZdvABUsz/XZjxmI5VDA6vWfPTScXzFePgS X-Received: by 2002:a17:902:d4cf:b0:1ac:6d4c:c24b with SMTP id o15-20020a170902d4cf00b001ac6d4cc24bmr16357174plg.3.1684858395329; Tue, 23 May 2023 09:13:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684858395; cv=none; d=google.com; s=arc-20160816; b=veVNDlaB9YoaKwQADqJdylPx0vmhi9KfymekyCSS/RfijLJkq3iKebycwhlsKZl8fz A0Q+dMNT1PzzwPSvpjsysyfIHJqnv1wZ39s2VzSxsqMETnt4Sxnf3afJ6ECoBbJmNa2Z PWh6p9Z9HUQlopTE9VrR4YF48i5Z3g/HUeeoGzfnETakwphS+SC1/3udE7lZ9ojosYTm dkdscfu6dvEceueVbrYGoXi7F8gn7Ck2H/GfGCig1eZAVU1Ui4WcMMzebBVMSNKbbGuo wFn7OHdcvf4+reII6LnPFRtuC0ORC8D2TQXFTFEIj5J4iDHXpX5dh8GkypdVmIjkqIWt Wreg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=MZIv7pCHhcQ8TEDmwiMdshKCZv41LdV5S/s4fLER72M=; b=rdanh3U+1Lctqs6Iolrl8/XID6bv/dJri2gOBE804yXQEPGckw7wFcBCzvGPYC9CFi FL8riMqgRdDBoYnzJrdMD1G1ptUcd6ed3y+DDagk6WWj6GjP+gCMOivL6s37cM9ImPW0 xYLgLVVtWPj/ytbrvR5G1ssBaF2ZnqlEicMVOdY8ONvQLN+KvgESs/tc1q1TGjmoLzz6 v0fskULo1/FI91EWHaXlPLK1UO0qBM/GnZYgNWrdwG6A7mUHylorKwe3xWWzEu7zX1Nr Ka8KFKoXGXiFJACRzikPjmc51A8R9EhXIC7hTj5leTWRySmsP5vetjIwxOf6THLxqvuB ndRA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s195-20020a632ccc000000b0053474ec7245si1734884pgs.683.2023.05.23.09.13.02; Tue, 23 May 2023 09:13:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237672AbjEWPw6 (ORCPT + 99 others); Tue, 23 May 2023 11:52:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237653AbjEWPwv (ORCPT ); Tue, 23 May 2023 11:52:51 -0400 Received: from laurent.telenet-ops.be (laurent.telenet-ops.be [IPv6:2a02:1800:110:4::f00:19]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0168CE0 for ; Tue, 23 May 2023 08:52:49 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed30:b0ac:7afd:272:4cff]) by laurent.telenet-ops.be with bizsmtp id 0Fsn2A00N0Jkz7G01FsnZc; Tue, 23 May 2023 17:52:48 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1q1UJN-002t6k-At; Tue, 23 May 2023 17:52:47 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1q1UJb-00CksO-NR; Tue, 23 May 2023 17:52:47 +0200 From: Geert Uytterhoeven To: Marek Vasut , Yoshihiro Shimoda , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Rob Herring , Bjorn Helgaas Cc: linux-pci@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH v2] PCI: rcar-host: Remove unused static pcie_base and pcie_dev Date: Tue, 23 May 2023 17:52:44 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766702077014991009?= X-GMAIL-MSGID: =?utf-8?q?1766702077014991009?= After the L1 link state transition exception handler rework, the static copies of the remapped PCIe controller address and the PCIe device pointer became unused. Remove them. Fixes: 6e36203bc14ce147 ("PCI: rcar: Use PCI_SET_ERROR_RESPONSE after read which triggered an exception") Signed-off-by: Geert Uytterhoeven Reviewed-by: Yoshihiro Shimoda --- Probably this was not noticed before due to two function parameters with the same name, thus shadowing the static globals. v2: - Add Reviewed-by. --- drivers/pci/controller/pcie-rcar-host.c | 21 --------------------- 1 file changed, 21 deletions(-) diff --git a/drivers/pci/controller/pcie-rcar-host.c b/drivers/pci/controller/pcie-rcar-host.c index e80e56b2a84243e5..7ffcd0f5aa45c989 100644 --- a/drivers/pci/controller/pcie-rcar-host.c +++ b/drivers/pci/controller/pcie-rcar-host.c @@ -41,21 +41,6 @@ struct rcar_msi { int irq2; }; -#ifdef CONFIG_ARM -/* - * Here we keep a static copy of the remapped PCIe controller address. - * This is only used on aarch32 systems, all of which have one single - * PCIe controller, to provide quick access to the PCIe controller in - * the L1 link state fixup function, called from the ARM fault handler. - */ -static void __iomem *pcie_base; -/* - * Static copy of PCIe device pointer, so we can check whether the - * device is runtime suspended or not. - */ -static struct device *pcie_dev; -#endif - /* Structure representing the PCIe interface */ struct rcar_pcie_host { struct rcar_pcie pcie; @@ -879,12 +864,6 @@ static int rcar_pcie_get_resources(struct rcar_pcie_host *host) } host->msi.irq2 = i; -#ifdef CONFIG_ARM - /* Cache static copy for L1 link state fixup hook on aarch32 */ - pcie_base = pcie->base; - pcie_dev = pcie->dev; -#endif - return 0; err_irq2: