From patchwork Thu Apr 27 17:36:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Reinette Chatre X-Patchwork-Id: 88330 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp430287vqo; Thu, 27 Apr 2023 10:39:42 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4z3D3yGIpSz5JWvJdyQbAxUj5EHaRxgKr5uTyQGaHx01MUoSrTxjDNbKlu2bpubfMziFs2 X-Received: by 2002:aa7:88d0:0:b0:63d:4407:b6c with SMTP id k16-20020aa788d0000000b0063d44070b6cmr3236861pff.7.1682617181722; Thu, 27 Apr 2023 10:39:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682617181; cv=none; d=google.com; s=arc-20160816; b=Fztzs6pwMiAWp4PqRw0NjRUTOYL4hzHyWDxYedZui5EyJj9lnheavQfAN9r/ZevZiK B1DIPIuRh/DhtikjZruamdlY7YIcGbR22eQ8LCCMU+ta5BaaR06AQ7lePj07vbb5mkR1 GelsiyYzjx9fRiWxWX4XLyVYecbyyZOgElU029Yi8U0HJZramzQstCS6vfalgN74tu7h CKYEe43qG1fLAFNkJ3DVDkaYImNPrRT4rGmk5znR92/JAlEy97QUEg0cAAeP/Ox2ZL8R soMWY6Qs+p0KU9pbyfXZj+5O3e2UUTCBNOhocI/uFFhuMtgO3AxxPd6+ytasuCjX5894 oTNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=I4uQ9UTyPM3LJS9eUpiq8DpmM3I+Q67FNUIpKVHyv+E=; b=nkz5NV42NLq8CjcCWiUqP1G3TJ7v5HWUbfdrvx9714pFsX1z7zM22lMT2gCjSQn6AE Z5CClRoai4bTTAiffHIj8dYlN+TZwfscF+EZDVcw9rOf9GXJ4douZtIqSl8UUmscUqwg fMSYoP3D+3OKo+n3bFZarSNYG/Q1HwaG96wqVA4jFrUtJx15GO6C7e4b1YiD56UlWNtn +T8G1W4PLDLpZVmMquhK23WSKLQ1qGdYjl+94a6pliQMHCj31RzMX1eXVa3r/jUYE3rq gwwfISiHAJirTOKemA/21NVVTx3Y1ElfNFIbNLuGEUf64sgi+c4rbUv49t8CBulxu4Fp HNQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=AsvZtfkh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d69-20020a621d48000000b0063b7bc5f3a8si19300548pfd.86.2023.04.27.10.39.27; Thu, 27 Apr 2023 10:39:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=AsvZtfkh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244607AbjD0RhI (ORCPT + 99 others); Thu, 27 Apr 2023 13:37:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244436AbjD0Rg1 (ORCPT ); Thu, 27 Apr 2023 13:36:27 -0400 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78D9035A4; Thu, 27 Apr 2023 10:36:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682616986; x=1714152986; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=cSgLlGdyxaXFMa3vrlcEIL4XkCkVpS7t5FiSBXiFMow=; b=AsvZtfkhjWhYkIOzSUUTF8NOt5+p58ne09Qs98uPd/DtS/hTsEakcDjg Ta/csH/pS0i5YfvXvFV5GeTjnCsqTHdWN+cERCpImxXO6f0atJDN+nXgO c5Yfn2o8FERX6Xo0i9Ua1b9k450+u8zL0QiJsvBe9jEZzs9vBCf7Lejlb VRzbejDlazqAuYKYvSrVsb+tMMSS+7ts9zeNv6Q6TtEShkLNXFUxoLxTp W0ImXyZfOA5YYgV9w/ZJZlH5okkeSvDJFt55H1wBJ0dLFT3npBrm/QRAz klTQJzPo3Q+2vXYrm3+b41Cv9NuiHMBKwZnhcF97dvOnLty2WqYJ9KLrS Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10693"; a="349496916" X-IronPort-AV: E=Sophos;i="5.99,232,1677571200"; d="scan'208";a="349496916" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2023 10:36:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10693"; a="697172986" X-IronPort-AV: E=Sophos;i="5.99,232,1677571200"; d="scan'208";a="697172986" Received: from rchatre-ws.ostc.intel.com ([10.54.69.144]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2023 10:36:21 -0700 From: Reinette Chatre To: jgg@nvidia.com, yishaih@nvidia.com, shameerali.kolothum.thodi@huawei.com, kevin.tian@intel.com, alex.williamson@redhat.com Cc: tglx@linutronix.de, darwi@linutronix.de, kvm@vger.kernel.org, dave.jiang@intel.com, jing2.liu@intel.com, ashok.raj@intel.com, fenghua.yu@intel.com, tom.zanussi@linux.intel.com, reinette.chatre@intel.com, linux-kernel@vger.kernel.org Subject: [PATCH V4 07/11] vfio/pci: Update stale comment Date: Thu, 27 Apr 2023 10:36:04 -0700 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764351994388998824?= X-GMAIL-MSGID: =?utf-8?q?1764351994388998824?= In preparation for surrounding code change it is helpful to ensure that existing comments are accurate. Remove inaccurate comment about direct access and update the rest of the comment to reflect the purpose of writing the cached MSI message to the device. Suggested-by: Alex Williamson Link: https://lore.kernel.org/lkml/20230330164050.0069e2a5.alex.williamson@redhat.com/ Signed-off-by: Reinette Chatre --- No changes since V3. Changes since V2: - New patch. drivers/vfio/pci/vfio_pci_intrs.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/vfio/pci/vfio_pci_intrs.c b/drivers/vfio/pci/vfio_pci_intrs.c index 5e3de004f4cb..bdda7f46c2be 100644 --- a/drivers/vfio/pci/vfio_pci_intrs.c +++ b/drivers/vfio/pci/vfio_pci_intrs.c @@ -419,11 +419,9 @@ static int vfio_msi_set_vector_signal(struct vfio_pci_core_device *vdev, } /* - * The MSIx vector table resides in device memory which may be cleared - * via backdoor resets. We don't allow direct access to the vector - * table so even if a userspace driver attempts to save/restore around - * such a reset it would be unsuccessful. To avoid this, restore the - * cached value of the message prior to enabling. + * If the vector was previously allocated, refresh the on-device + * message data before enabling in case it had been cleared or + * corrupted since writing. */ cmd = vfio_pci_memory_lock_and_enable(vdev); if (msix) {